--- jsr166/src/test/tck/CompletableFutureTest.java 2014/06/16 20:16:32 1.83 +++ jsr166/src/test/tck/CompletableFutureTest.java 2014/06/16 21:04:23 1.86 @@ -2922,13 +2922,13 @@ public class CompletableFutureTest exten * when all components complete normally */ public void testAllOf_normal() throws Exception { - for (int k = 1; k < 20; ++k) { + for (int k = 1; k < 20; k++) { CompletableFuture[] fs = (CompletableFuture[]) new CompletableFuture[k]; - for (int i = 0; i < k; ++i) + for (int i = 0; i < k; i++) fs[i] = new CompletableFuture<>(); CompletableFuture f = CompletableFuture.allOf(fs); - for (int i = 0; i < k; ++i) { + for (int i = 0; i < k; i++) { checkIncomplete(f); checkIncomplete(CompletableFuture.allOf(fs)); fs[i].complete(one); @@ -2939,10 +2939,10 @@ public class CompletableFutureTest exten } public void testAllOf_backwards() throws Exception { - for (int k = 1; k < 20; ++k) { + for (int k = 1; k < 20; k++) { CompletableFuture[] fs = (CompletableFuture[]) new CompletableFuture[k]; - for (int i = 0; i < k; ++i) + for (int i = 0; i < k; i++) fs[i] = new CompletableFuture<>(); CompletableFuture f = CompletableFuture.allOf(fs); for (int i = k - 1; i >= 0; i--) { @@ -2959,25 +2959,46 @@ public class CompletableFutureTest exten * anyOf(no component futures) returns an incomplete future */ public void testAnyOf_empty() throws Exception { + for (Integer v1 : new Integer[] { 1, null }) + { CompletableFuture f = CompletableFuture.anyOf(); checkIncomplete(f); - } + + f.complete(v1); + checkCompletedNormally(f, v1); + }} /** * anyOf returns a future completed normally with a value when * a component future does */ public void testAnyOf_normal() throws Exception { - for (int k = 0; k < 10; ++k) { + for (int k = 0; k < 10; k++) { CompletableFuture[] fs = new CompletableFuture[k]; - for (int i = 0; i < k; ++i) + for (int i = 0; i < k; i++) fs[i] = new CompletableFuture<>(); CompletableFuture f = CompletableFuture.anyOf(fs); checkIncomplete(f); - for (int i = 0; i < k; ++i) { - fs[i].complete(one); - checkCompletedNormally(f, one); - checkCompletedNormally(CompletableFuture.anyOf(fs), one); + for (int i = 0; i < k; i++) { + fs[i].complete(i); + checkCompletedNormally(f, 0); + int x = (int) CompletableFuture.anyOf(fs).join(); + assertTrue(0 <= x && x <= i); + } + } + } + public void testAnyOf_normal_backwards() throws Exception { + for (int k = 0; k < 10; k++) { + CompletableFuture[] fs = new CompletableFuture[k]; + for (int i = 0; i < k; i++) + fs[i] = new CompletableFuture<>(); + CompletableFuture f = CompletableFuture.anyOf(fs); + checkIncomplete(f); + for (int i = k - 1; i >= 0; i--) { + fs[i].complete(i); + checkCompletedNormally(f, k - 1); + int x = (int) CompletableFuture.anyOf(fs).join(); + assertTrue(i <= x && x <= k - 1); } } } @@ -2986,13 +3007,13 @@ public class CompletableFutureTest exten * anyOf result completes exceptionally when any component does. */ public void testAnyOf_exceptional() throws Exception { - for (int k = 0; k < 10; ++k) { + for (int k = 0; k < 10; k++) { CompletableFuture[] fs = new CompletableFuture[k]; - for (int i = 0; i < k; ++i) + for (int i = 0; i < k; i++) fs[i] = new CompletableFuture<>(); CompletableFuture f = CompletableFuture.anyOf(fs); checkIncomplete(f); - for (int i = 0; i < k; ++i) { + for (int i = 0; i < k; i++) { fs[i].completeExceptionally(new CFException()); checkCompletedWithWrappedCFException(f); checkCompletedWithWrappedCFException(CompletableFuture.anyOf(fs)); @@ -3156,6 +3177,9 @@ public class CompletableFutureTest exten dependentFactories.add((y) -> m.thenCompose(y, new CompletableFutureInc(m))); + dependentFactories.add((y) -> CompletableFuture.allOf(new CompletableFuture[] {y, v42})); + dependentFactories.add((y) -> CompletableFuture.anyOf(new CompletableFuture[] {y, incomplete})); + for (Function, CompletableFuture> dependentFactory : dependentFactories) { CompletableFuture f = new CompletableFuture<>(); @@ -3205,22 +3229,4 @@ public class CompletableFutureTest exten } }} -// public void testRunAfterEither_resultDeterminedAtTimeOfCreation() { -// for (ExecutionMode m : ExecutionMode.values()) -// for (boolean mayInterruptIfRunning : new boolean[] { true, false }) -// for (Integer v1 : new Integer[] { 1, null }) -// { -// final CompletableFuture f = new CompletableFuture<>(); -// final CompletableFuture g = new CompletableFuture<>(); -// final Noop[] rs = new Noop[2]; -// for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m); -// f.complete(v1); -// final CompletableFuture h0 = m.runAfterEither(f, g, rs[0]); -// final CompletableFuture h1 = m.runAfterEither(g, f, rs[1]); -// assertTrue(g.cancel(mayInterruptIfRunning)); -// checkCompletedNormally(h0, null); -// checkCompletedNormally(h1, null); -// for (Noop r : rs) r.assertInvoked(); -// }} - }