--- jsr166/src/test/tck/ConcurrentHashMap8Test.java 2016/11/06 22:42:10 1.33 +++ jsr166/src/test/tck/ConcurrentHashMap8Test.java 2018/05/28 21:36:41 1.37 @@ -173,8 +173,8 @@ public class ConcurrentHashMap8Test exte static Set populatedSet(Integer[] elements) { Set a = ConcurrentHashMap.newKeySet(); assertTrue(a.isEmpty()); - for (int i = 0; i < elements.length; i++) - assertTrue(a.add(elements[i])); + for (Integer element : elements) + assertTrue(a.add(element)); assertFalse(a.isEmpty()); assertEquals(elements.length, a.size()); return a; @@ -185,7 +185,7 @@ public class ConcurrentHashMap8Test exte */ public void testReplaceAll() { ConcurrentHashMap map = map5(); - map.replaceAll((x, y) -> { return x > 3 ? "Z" : y; }); + map.replaceAll((x, y) -> (x > 3) ? "Z" : y); assertEquals("A", map.get(one)); assertEquals("B", map.get(two)); assertEquals("C", map.get(three)); @@ -210,8 +210,8 @@ public class ConcurrentHashMap8Test exte Set set1 = map.keySet(); Set set2 = map.keySet(true); set2.add(six); - assertTrue(((ConcurrentHashMap.KeySetView)set2).getMap() == map); - assertTrue(((ConcurrentHashMap.KeySetView)set1).getMap() == map); + assertSame(map, ((ConcurrentHashMap.KeySetView)set2).getMap()); + assertSame(map, ((ConcurrentHashMap.KeySetView)set1).getMap()); assertEquals(set2.size(), map.size()); assertEquals(set1.size(), map.size()); assertTrue((Boolean)map.get(six)); @@ -305,10 +305,10 @@ public class ConcurrentHashMap8Test exte assertFalse(set.add(one)); assertTrue(set.add(six)); assertTrue(set.add(seven)); - assertTrue(set.getMappedValue() == one); - assertTrue(map.get(one) != one); - assertTrue(map.get(six) == one); - assertTrue(map.get(seven) == one); + assertSame(one, set.getMappedValue()); + assertNotSame(one, map.get(one)); + assertSame(one, map.get(six)); + assertSame(one, map.get(seven)); } void checkSpliteratorCharacteristics(Spliterator sp, @@ -543,7 +543,7 @@ public class ConcurrentHashMap8Test exte } /** - * A deserialized serialized set is equal + * A deserialized/reserialized set equals original */ public void testSerialization() throws Exception { int size = 20;