ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ConcurrentHashMapTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ConcurrentHashMapTest.java (file contents):
Revision 1.23 by jsr166, Tue Mar 15 19:47:06 2011 UTC vs.
Revision 1.40 by jsr166, Wed Dec 31 19:05:42 2014 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 < import junit.framework.*;
10 < import java.util.*;
11 < import java.util.concurrent.*;
9 > import java.util.ArrayList;
10 > import java.util.Arrays;
11 > import java.util.Collection;
12 > import java.util.Collections;
13   import java.util.Enumeration;
14 < import java.io.*;
14 > import java.util.Iterator;
15 > import java.util.Map;
16 > import java.util.Random;
17 > import java.util.Set;
18 > import java.util.concurrent.ConcurrentHashMap;
19 >
20 > import junit.framework.Test;
21 > import junit.framework.TestSuite;
22  
23   public class ConcurrentHashMapTest extends JSR166TestCase {
24      public static void main(String[] args) {
# Line 21 | Line 29 | public class ConcurrentHashMapTest exten
29      }
30  
31      /**
32 <     * Create a map from Integers 1-5 to Strings "A"-"E".
32 >     * Returns a new map from Integers 1-5 to Strings "A"-"E".
33       */
34 <    private static ConcurrentHashMap map5() {
35 <        ConcurrentHashMap map = new ConcurrentHashMap(5);
34 >    private static ConcurrentHashMap<Integer, String> map5() {
35 >        ConcurrentHashMap map = new ConcurrentHashMap<Integer, String>(5);
36          assertTrue(map.isEmpty());
37          map.put(one, "A");
38          map.put(two, "B");
# Line 36 | Line 44 | public class ConcurrentHashMapTest exten
44          return map;
45      }
46  
47 +    /** Re-implement Integer.compare for old java versions */
48 +    static int compare(int x, int y) { return x < y ? -1 : x > y ? 1 : 0; }
49 +
50 +    // classes for testing Comparable fallbacks
51 +    static class BI implements Comparable<BI> {
52 +        private final int value;
53 +        BI(int value) { this.value = value; }
54 +        public int compareTo(BI other) {
55 +            return compare(value, other.value);
56 +        }
57 +        public boolean equals(Object x) {
58 +            return (x instanceof BI) && ((BI)x).value == value;
59 +        }
60 +        public int hashCode() { return 42; }
61 +    }
62 +    static class CI extends BI { CI(int value) { super(value); } }
63 +    static class DI extends BI { DI(int value) { super(value); } }
64 +
65 +    static class BS implements Comparable<BS> {
66 +        private final String value;
67 +        BS(String value) { this.value = value; }
68 +        public int compareTo(BS other) {
69 +            return value.compareTo(other.value);
70 +        }
71 +        public boolean equals(Object x) {
72 +            return (x instanceof BS) && value.equals(((BS)x).value);
73 +        }
74 +        public int hashCode() { return 42; }
75 +    }
76 +
77 +    static class LexicographicList<E extends Comparable<E>> extends ArrayList<E>
78 +        implements Comparable<LexicographicList<E>> {
79 +        LexicographicList(Collection<E> c) { super(c); }
80 +        LexicographicList(E e) { super(Collections.singleton(e)); }
81 +        public int compareTo(LexicographicList<E> other) {
82 +            int common = Math.min(size(), other.size());
83 +            int r = 0;
84 +            for (int i = 0; i < common; i++) {
85 +                if ((r = get(i).compareTo(other.get(i))) != 0)
86 +                    break;
87 +            }
88 +            if (r == 0)
89 +                r = compare(size(), other.size());
90 +            return r;
91 +        }
92 +        private static final long serialVersionUID = 0;
93 +    }
94 +
95 +    static class CollidingObject {
96 +        final String value;
97 +        CollidingObject(final String value) { this.value = value; }
98 +        public int hashCode() { return this.value.hashCode() & 1; }
99 +        public boolean equals(final Object obj) {
100 +            return (obj instanceof CollidingObject) && ((CollidingObject)obj).value.equals(value);
101 +        }
102 +    }
103 +
104 +    static class ComparableCollidingObject extends CollidingObject implements Comparable<ComparableCollidingObject> {
105 +        ComparableCollidingObject(final String value) { super(value); }
106 +        public int compareTo(final ComparableCollidingObject o) {
107 +            return value.compareTo(o.value);
108 +        }
109 +    }
110 +
111 +    /**
112 +     * Inserted elements that are subclasses of the same Comparable
113 +     * class are found.
114 +     */
115 +    public void testComparableFamily() {
116 +        int size = 500;         // makes measured test run time -> 60ms
117 +        ConcurrentHashMap<BI, Boolean> m =
118 +            new ConcurrentHashMap<BI, Boolean>();
119 +        for (int i = 0; i < size; i++) {
120 +            assertTrue(m.put(new CI(i), true) == null);
121 +        }
122 +        for (int i = 0; i < size; i++) {
123 +            assertTrue(m.containsKey(new CI(i)));
124 +            assertTrue(m.containsKey(new DI(i)));
125 +        }
126 +    }
127 +
128 +    /**
129 +     * Elements of classes with erased generic type parameters based
130 +     * on Comparable can be inserted and found.
131 +     */
132 +    public void testGenericComparable() {
133 +        int size = 120;         // makes measured test run time -> 60ms
134 +        ConcurrentHashMap<Object, Boolean> m =
135 +            new ConcurrentHashMap<Object, Boolean>();
136 +        for (int i = 0; i < size; i++) {
137 +            BI bi = new BI(i);
138 +            BS bs = new BS(String.valueOf(i));
139 +            LexicographicList<BI> bis = new LexicographicList<BI>(bi);
140 +            LexicographicList<BS> bss = new LexicographicList<BS>(bs);
141 +            assertTrue(m.putIfAbsent(bis, true) == null);
142 +            assertTrue(m.containsKey(bis));
143 +            if (m.putIfAbsent(bss, true) == null)
144 +                assertTrue(m.containsKey(bss));
145 +            assertTrue(m.containsKey(bis));
146 +        }
147 +        for (int i = 0; i < size; i++) {
148 +            assertTrue(m.containsKey(Collections.singletonList(new BI(i))));
149 +        }
150 +    }
151 +
152 +    /**
153 +     * Elements of non-comparable classes equal to those of classes
154 +     * with erased generic type parameters based on Comparable can be
155 +     * inserted and found.
156 +     */
157 +    public void testGenericComparable2() {
158 +        int size = 500;         // makes measured test run time -> 60ms
159 +        ConcurrentHashMap<Object, Boolean> m =
160 +            new ConcurrentHashMap<Object, Boolean>();
161 +        for (int i = 0; i < size; i++) {
162 +            m.put(Collections.singletonList(new BI(i)), true);
163 +        }
164 +
165 +        for (int i = 0; i < size; i++) {
166 +            LexicographicList<BI> bis = new LexicographicList<BI>(new BI(i));
167 +            assertTrue(m.containsKey(bis));
168 +        }
169 +    }
170 +
171 +    /**
172 +     * Mixtures of instances of comparable and non-comparable classes
173 +     * can be inserted and found.
174 +     */
175 +    public void testMixedComparable() {
176 +        int size = 1200;        // makes measured test run time -> 35ms
177 +        ConcurrentHashMap<Object, Object> map =
178 +            new ConcurrentHashMap<Object, Object>();
179 +        Random rng = new Random();
180 +        for (int i = 0; i < size; i++) {
181 +            Object x;
182 +            switch (rng.nextInt(4)) {
183 +            case 0:
184 +                x = new Object();
185 +                break;
186 +            case 1:
187 +                x = new CollidingObject(Integer.toString(i));
188 +                break;
189 +            default:
190 +                x = new ComparableCollidingObject(Integer.toString(i));
191 +            }
192 +            assertNull(map.put(x, x));
193 +        }
194 +        int count = 0;
195 +        for (Object k : map.keySet()) {
196 +            assertEquals(map.get(k), k);
197 +            ++count;
198 +        }
199 +        assertEquals(count, size);
200 +        assertEquals(map.size(), size);
201 +        for (Object k : map.keySet()) {
202 +            assertEquals(map.put(k, k), k);
203 +        }
204 +    }
205 +
206      /**
207       * clear removes all pairs
208       */
209      public void testClear() {
210          ConcurrentHashMap map = map5();
211          map.clear();
212 <        assertEquals(map.size(), 0);
212 >        assertEquals(0, map.size());
213      }
214  
215      /**
# Line 59 | Line 226 | public class ConcurrentHashMapTest exten
226      }
227  
228      /**
229 +     * hashCode() equals sum of each key.hashCode ^ value.hashCode
230 +     */
231 +    public void testHashCode() {
232 +        ConcurrentHashMap<Integer,String> map = map5();
233 +        int sum = 0;
234 +        for (Map.Entry<Integer,String> e : map.entrySet())
235 +            sum += e.getKey().hashCode() ^ e.getValue().hashCode();
236 +        assertEquals(sum, map.hashCode());
237 +    }
238 +
239 +    /**
240       * contains returns true for contained value
241       */
242      public void testContains() {
# Line 275 | Line 453 | public class ConcurrentHashMapTest exten
453          assertEquals("Z", map.get(one));
454      }
455  
278 –
456      /**
457       * replace value fails when the given key not mapped to expected value
458       */
# Line 296 | Line 473 | public class ConcurrentHashMapTest exten
473          assertEquals("Z", map.get(one));
474      }
475  
299 –
476      /**
477       * remove removes the correct key-value pair from the map
478       */
# Line 337 | Line 513 | public class ConcurrentHashMapTest exten
513          ConcurrentHashMap map = map5();
514          String s = map.toString();
515          for (int i = 1; i <= 5; ++i) {
516 <            assertTrue(s.indexOf(String.valueOf(i)) >= 0);
516 >            assertTrue(s.contains(String.valueOf(i)));
517          }
518      }
519  
520      // Exception tests
521  
522      /**
523 <     * Cannot create with negative capacity
523 >     * Cannot create with only negative capacity
524       */
525      public void testConstructor1() {
526          try {
527 <            new ConcurrentHashMap(-1,0,1);
527 >            new ConcurrentHashMap(-1);
528              shouldThrow();
529          } catch (IllegalArgumentException success) {}
530      }
531  
532      /**
533 <     * Cannot create with negative concurrency level
534 <     */
533 >     * Constructor (initialCapacity, loadFactor) throws
534 >     * IllegalArgumentException if either argument is negative
535 >      */
536      public void testConstructor2() {
537          try {
538 <            new ConcurrentHashMap(1,0,-1);
538 >            new ConcurrentHashMap(-1, .75f);
539              shouldThrow();
540 <        } catch (IllegalArgumentException success) {}
540 >        } catch (IllegalArgumentException e) {}
541 >
542 >        try {
543 >            new ConcurrentHashMap(16, -1);
544 >            shouldThrow();
545 >        } catch (IllegalArgumentException e) {}
546      }
547  
548      /**
549 <     * Cannot create with only negative capacity
549 >     * Constructor (initialCapacity, loadFactor, concurrencyLevel)
550 >     * throws IllegalArgumentException if any argument is negative
551       */
552      public void testConstructor3() {
553          try {
554 <            new ConcurrentHashMap(-1);
554 >            new ConcurrentHashMap(-1, .75f, 1);
555              shouldThrow();
556 <        } catch (IllegalArgumentException success) {}
556 >        } catch (IllegalArgumentException e) {}
557 >
558 >        try {
559 >            new ConcurrentHashMap(16, -1, 1);
560 >            shouldThrow();
561 >        } catch (IllegalArgumentException e) {}
562 >
563 >        try {
564 >            new ConcurrentHashMap(16, .75f, -1);
565 >            shouldThrow();
566 >        } catch (IllegalArgumentException e) {}
567      }
568  
569      /**
570 +     * ConcurrentHashMap(map) throws NullPointerException if the given
571 +     * map is null
572 +     */
573 +    public void testConstructor4() {
574 +        try {
575 +            new ConcurrentHashMap(null);
576 +            shouldThrow();
577 +        } catch (NullPointerException e) {}
578 +    }
579 +
580 +    /**
581 +     * ConcurrentHashMap(map) creates a new map with the same mappings
582 +     * as the given map
583 +     */
584 +    public void testConstructor5() {
585 +        ConcurrentHashMap map1 = map5();
586 +        ConcurrentHashMap map2 = new ConcurrentHashMap(map5());
587 +        assertTrue(map2.equals(map1));
588 +        map2.put(one, "F");
589 +        assertFalse(map2.equals(map1));
590 +    }
591 +
592 +
593 +    /**
594       * get(null) throws NPE
595       */
596      public void testGet_NullPointerException() {
# Line 483 | Line 700 | public class ConcurrentHashMapTest exten
700          } catch (NullPointerException success) {}
701      }
702  
486 –
703      /**
704       * replace(x, null) throws NPE
705       */
# Line 517 | Line 733 | public class ConcurrentHashMapTest exten
733          } catch (NullPointerException success) {}
734      }
735  
520 –
736      /**
737       * remove(null) throws NPE
738       */
# Line 555 | Line 770 | public class ConcurrentHashMapTest exten
770       * A deserialized map equals original
771       */
772      public void testSerialization() throws Exception {
773 <        ConcurrentHashMap q = map5();
773 >        Map x = map5();
774 >        Map y = serialClone(x);
775  
776 <        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
777 <        ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
778 <        out.writeObject(q);
779 <        out.close();
564 <
565 <        ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
566 <        ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
567 <        ConcurrentHashMap r = (ConcurrentHashMap)in.readObject();
568 <        assertEquals(q.size(), r.size());
569 <        assertTrue(q.equals(r));
570 <        assertTrue(r.equals(q));
776 >        assertNotSame(x, y);
777 >        assertEquals(x.size(), y.size());
778 >        assertEquals(x, y);
779 >        assertEquals(y, x);
780      }
781  
573 –
782      /**
783       * SetValue of an EntrySet entry sets value in the map.
784       */
# Line 582 | Line 790 | public class ConcurrentHashMapTest exten
790              map.put(new Integer(i), new Integer(i));
791          assertFalse(map.isEmpty());
792          Map.Entry entry1 = (Map.Entry)map.entrySet().iterator().next();
793 <
794 <        // assert that entry1 is not 16
795 <        assertTrue("entry is 16, test not valid",
796 <                   !entry1.getKey().equals(new Integer(16)));
797 <
798 <        // remove 16 (a different key) from map
799 <        // which just happens to cause entry1 to be cloned in map
800 <        map.remove(new Integer(16));
801 <        entry1.setValue("XYZ");
594 <        assertTrue(map.containsValue("XYZ")); // fails
793 >        // Unless it happens to be first (in which case remainder of
794 >        // test is skipped), remove a possibly-colliding key from map
795 >        // which, under some implementations, may cause entry1 to be
796 >        // cloned in map
797 >        if (!entry1.getKey().equals(new Integer(16))) {
798 >            map.remove(new Integer(16));
799 >            entry1.setValue("XYZ");
800 >            assertTrue(map.containsValue("XYZ")); // fails if write-through broken
801 >        }
802      }
803  
804   }

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines