ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ConcurrentHashMapTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ConcurrentHashMapTest.java (file contents):
Revision 1.31 by jsr166, Thu May 30 03:28:55 2013 UTC vs.
Revision 1.50 by jsr166, Mon Aug 22 18:38:28 2016 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 < import junit.framework.*;
10 < import java.util.*;
9 > import java.util.ArrayList;
10 > import java.util.Arrays;
11 > import java.util.Collection;
12 > import java.util.Collections;
13 > import java.util.Enumeration;
14 > import java.util.Iterator;
15 > import java.util.Map;
16 > import java.util.Random;
17 > import java.util.Set;
18   import java.util.concurrent.ConcurrentHashMap;
19 + import java.util.concurrent.ExecutorService;
20 + import java.util.concurrent.Executors;
21 +
22 + import junit.framework.Test;
23 + import junit.framework.TestSuite;
24  
25   public class ConcurrentHashMapTest extends JSR166TestCase {
26      public static void main(String[] args) {
27 <        junit.textui.TestRunner.run(suite());
27 >        main(suite(), args);
28      }
29      public static Test suite() {
30          return new TestSuite(ConcurrentHashMapTest.class);
# Line 21 | Line 33 | public class ConcurrentHashMapTest exten
33      /**
34       * Returns a new map from Integers 1-5 to Strings "A"-"E".
35       */
36 <    private static ConcurrentHashMap map5() {
37 <        ConcurrentHashMap map = new ConcurrentHashMap(5);
36 >    private static ConcurrentHashMap<Integer, String> map5() {
37 >        ConcurrentHashMap map = new ConcurrentHashMap<Integer, String>(5);
38          assertTrue(map.isEmpty());
39          map.put(one, "A");
40          map.put(two, "B");
# Line 34 | Line 46 | public class ConcurrentHashMapTest exten
46          return map;
47      }
48  
49 +    /** Re-implement Integer.compare for old java versions */
50 +    static int compare(int x, int y) {
51 +        return (x < y) ? -1 : (x > y) ? 1 : 0;
52 +    }
53 +
54      // classes for testing Comparable fallbacks
55      static class BI implements Comparable<BI> {
56          private final int value;
57          BI(int value) { this.value = value; }
58          public int compareTo(BI other) {
59 <            return Integer.compare(value, other.value);
59 >            return compare(value, other.value);
60          }
61          public boolean equals(Object x) {
62              return (x instanceof BI) && ((BI)x).value == value;
# Line 73 | Line 90 | public class ConcurrentHashMapTest exten
90                      break;
91              }
92              if (r == 0)
93 <                r = Integer.compare(size(), other.size());
93 >                r = compare(size(), other.size());
94              return r;
95          }
96          private static final long serialVersionUID = 0;
97      }
98  
99 +    static class CollidingObject {
100 +        final String value;
101 +        CollidingObject(final String value) { this.value = value; }
102 +        public int hashCode() { return this.value.hashCode() & 1; }
103 +        public boolean equals(final Object obj) {
104 +            return (obj instanceof CollidingObject) && ((CollidingObject)obj).value.equals(value);
105 +        }
106 +    }
107 +
108 +    static class ComparableCollidingObject extends CollidingObject implements Comparable<ComparableCollidingObject> {
109 +        ComparableCollidingObject(final String value) { super(value); }
110 +        public int compareTo(final ComparableCollidingObject o) {
111 +            return value.compareTo(o.value);
112 +        }
113 +    }
114 +
115      /**
116       * Inserted elements that are subclasses of the same Comparable
117       * class are found.
118       */
119      public void testComparableFamily() {
120 <        ConcurrentHashMap<BI, Boolean> m = new ConcurrentHashMap<>();
121 <        for (int i = 0; i < 1000; i++) {
120 >        int size = 500;         // makes measured test run time -> 60ms
121 >        ConcurrentHashMap<BI, Boolean> m =
122 >            new ConcurrentHashMap<BI, Boolean>();
123 >        for (int i = 0; i < size; i++) {
124              assertTrue(m.put(new CI(i), true) == null);
125          }
126 <        for (int i = 0; i < 1000; i++) {
126 >        for (int i = 0; i < size; i++) {
127              assertTrue(m.containsKey(new CI(i)));
128              assertTrue(m.containsKey(new DI(i)));
129          }
# Line 99 | Line 134 | public class ConcurrentHashMapTest exten
134       * on Comparable can be inserted and found.
135       */
136      public void testGenericComparable() {
137 <        ConcurrentHashMap<Object, Boolean> m = new ConcurrentHashMap<>();
138 <        for (int i = 0; i < 1000; i++) {
137 >        int size = 120;         // makes measured test run time -> 60ms
138 >        ConcurrentHashMap<Object, Boolean> m =
139 >            new ConcurrentHashMap<Object, Boolean>();
140 >        for (int i = 0; i < size; i++) {
141              BI bi = new BI(i);
142              BS bs = new BS(String.valueOf(i));
143              LexicographicList<BI> bis = new LexicographicList<BI>(bi);
# Line 111 | Line 148 | public class ConcurrentHashMapTest exten
148                  assertTrue(m.containsKey(bss));
149              assertTrue(m.containsKey(bis));
150          }
151 <        for (int i = 0; i < 1000; i++) {
152 <            assertTrue(m.containsKey(new ArrayList(Collections.singleton(new BI(i)))));
151 >        for (int i = 0; i < size; i++) {
152 >            assertTrue(m.containsKey(Collections.singletonList(new BI(i))));
153          }
154      }
155  
# Line 122 | Line 159 | public class ConcurrentHashMapTest exten
159       * inserted and found.
160       */
161      public void testGenericComparable2() {
162 <        ConcurrentHashMap<Object, Boolean> m = new ConcurrentHashMap<>();
163 <        for (int i = 0; i < 1000; i++) {
164 <            m.put(new ArrayList(Collections.singleton(new BI(i))), true);
162 >        int size = 500;         // makes measured test run time -> 60ms
163 >        ConcurrentHashMap<Object, Boolean> m =
164 >            new ConcurrentHashMap<Object, Boolean>();
165 >        for (int i = 0; i < size; i++) {
166 >            m.put(Collections.singletonList(new BI(i)), true);
167          }
168  
169 <        for (int i = 0; i < 1000; i++) {
169 >        for (int i = 0; i < size; i++) {
170              LexicographicList<BI> bis = new LexicographicList<BI>(new BI(i));
171              assertTrue(m.containsKey(bis));
172          }
173      }
174  
175      /**
176 +     * Mixtures of instances of comparable and non-comparable classes
177 +     * can be inserted and found.
178 +     */
179 +    public void testMixedComparable() {
180 +        int size = 1200;        // makes measured test run time -> 35ms
181 +        ConcurrentHashMap<Object, Object> map =
182 +            new ConcurrentHashMap<Object, Object>();
183 +        Random rng = new Random();
184 +        for (int i = 0; i < size; i++) {
185 +            Object x;
186 +            switch (rng.nextInt(4)) {
187 +            case 0:
188 +                x = new Object();
189 +                break;
190 +            case 1:
191 +                x = new CollidingObject(Integer.toString(i));
192 +                break;
193 +            default:
194 +                x = new ComparableCollidingObject(Integer.toString(i));
195 +            }
196 +            assertNull(map.put(x, x));
197 +        }
198 +        int count = 0;
199 +        for (Object k : map.keySet()) {
200 +            assertEquals(map.get(k), k);
201 +            ++count;
202 +        }
203 +        assertEquals(count, size);
204 +        assertEquals(map.size(), size);
205 +        for (Object k : map.keySet()) {
206 +            assertEquals(map.put(k, k), k);
207 +        }
208 +    }
209 +
210 +    /**
211       * clear removes all pairs
212       */
213      public void testClear() {
# Line 156 | Line 230 | public class ConcurrentHashMapTest exten
230      }
231  
232      /**
233 +     * hashCode() equals sum of each key.hashCode ^ value.hashCode
234 +     */
235 +    public void testHashCode() {
236 +        ConcurrentHashMap<Integer,String> map = map5();
237 +        int sum = 0;
238 +        for (Map.Entry<Integer,String> e : map.entrySet())
239 +            sum += e.getKey().hashCode() ^ e.getValue().hashCode();
240 +        assertEquals(sum, map.hashCode());
241 +    }
242 +
243 +    /**
244       * contains returns true for contained value
245       */
246      public void testContains() {
# Line 206 | Line 291 | public class ConcurrentHashMapTest exten
291          assertEquals("A", (String)map.get(one));
292          ConcurrentHashMap empty = new ConcurrentHashMap();
293          assertNull(map.get("anything"));
294 +        assertNull(empty.get("anything"));
295      }
296  
297      /**
# Line 247 | Line 333 | public class ConcurrentHashMapTest exten
333      }
334  
335      /**
336 +     * Test keySet().removeAll on empty map
337 +     */
338 +    public void testKeySet_empty_removeAll() {
339 +        ConcurrentHashMap<Integer, String> map = new ConcurrentHashMap<>();
340 +        Set<Integer> set = map.keySet();
341 +        set.removeAll(Collections.emptyList());
342 +        assertTrue(map.isEmpty());
343 +        assertTrue(set.isEmpty());
344 +        // following is test for JDK-8163353
345 +        set.removeAll(Collections.emptySet());
346 +        assertTrue(map.isEmpty());
347 +        assertTrue(set.isEmpty());
348 +    }
349 +
350 +    /**
351       * keySet.toArray returns contains all keys
352       */
353      public void testKeySetToArray() {
# Line 439 | Line 540 | public class ConcurrentHashMapTest exten
540      // Exception tests
541  
542      /**
543 <     * Cannot create with negative capacity
543 >     * Cannot create with only negative capacity
544       */
545      public void testConstructor1() {
546          try {
547 <            new ConcurrentHashMap(-1,0,1);
547 >            new ConcurrentHashMap(-1);
548              shouldThrow();
549          } catch (IllegalArgumentException success) {}
550      }
551  
552      /**
553 <     * Cannot create with negative concurrency level
553 >     * Constructor (initialCapacity, loadFactor) throws
554 >     * IllegalArgumentException if either argument is negative
555       */
556      public void testConstructor2() {
557          try {
558 <            new ConcurrentHashMap(1,0,-1);
558 >            new ConcurrentHashMap(-1, .75f);
559 >            shouldThrow();
560 >        } catch (IllegalArgumentException success) {}
561 >
562 >        try {
563 >            new ConcurrentHashMap(16, -1);
564              shouldThrow();
565          } catch (IllegalArgumentException success) {}
566      }
567  
568      /**
569 <     * Cannot create with only negative capacity
569 >     * Constructor (initialCapacity, loadFactor, concurrencyLevel)
570 >     * throws IllegalArgumentException if any argument is negative
571       */
572      public void testConstructor3() {
573          try {
574 <            new ConcurrentHashMap(-1);
574 >            new ConcurrentHashMap(-1, .75f, 1);
575 >            shouldThrow();
576 >        } catch (IllegalArgumentException success) {}
577 >
578 >        try {
579 >            new ConcurrentHashMap(16, -1, 1);
580              shouldThrow();
581          } catch (IllegalArgumentException success) {}
582 +
583 +        try {
584 +            new ConcurrentHashMap(16, .75f, -1);
585 +            shouldThrow();
586 +        } catch (IllegalArgumentException success) {}
587 +    }
588 +
589 +    /**
590 +     * ConcurrentHashMap(map) throws NullPointerException if the given
591 +     * map is null
592 +     */
593 +    public void testConstructor4() {
594 +        try {
595 +            new ConcurrentHashMap(null);
596 +            shouldThrow();
597 +        } catch (NullPointerException success) {}
598 +    }
599 +
600 +    /**
601 +     * ConcurrentHashMap(map) creates a new map with the same mappings
602 +     * as the given map
603 +     */
604 +    public void testConstructor5() {
605 +        ConcurrentHashMap map1 = map5();
606 +        ConcurrentHashMap map2 = new ConcurrentHashMap(map5());
607 +        assertTrue(map2.equals(map1));
608 +        map2.put(one, "F");
609 +        assertFalse(map2.equals(map1));
610      }
611  
612      /**
613       * get(null) throws NPE
614       */
615      public void testGet_NullPointerException() {
616 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
617          try {
476 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
618              c.get(null);
619              shouldThrow();
620          } catch (NullPointerException success) {}
# Line 483 | Line 624 | public class ConcurrentHashMapTest exten
624       * containsKey(null) throws NPE
625       */
626      public void testContainsKey_NullPointerException() {
627 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
628          try {
487 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
629              c.containsKey(null);
630              shouldThrow();
631          } catch (NullPointerException success) {}
# Line 494 | Line 635 | public class ConcurrentHashMapTest exten
635       * containsValue(null) throws NPE
636       */
637      public void testContainsValue_NullPointerException() {
638 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
639          try {
498 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
640              c.containsValue(null);
641              shouldThrow();
642          } catch (NullPointerException success) {}
# Line 505 | Line 646 | public class ConcurrentHashMapTest exten
646       * contains(null) throws NPE
647       */
648      public void testContains_NullPointerException() {
649 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
650          try {
509 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
651              c.contains(null);
652              shouldThrow();
653          } catch (NullPointerException success) {}
# Line 516 | Line 657 | public class ConcurrentHashMapTest exten
657       * put(null,x) throws NPE
658       */
659      public void testPut1_NullPointerException() {
660 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
661          try {
520 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
662              c.put(null, "whatever");
663              shouldThrow();
664          } catch (NullPointerException success) {}
# Line 527 | Line 668 | public class ConcurrentHashMapTest exten
668       * put(x, null) throws NPE
669       */
670      public void testPut2_NullPointerException() {
671 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
672          try {
531 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
673              c.put("whatever", null);
674              shouldThrow();
675          } catch (NullPointerException success) {}
# Line 538 | Line 679 | public class ConcurrentHashMapTest exten
679       * putIfAbsent(null, x) throws NPE
680       */
681      public void testPutIfAbsent1_NullPointerException() {
682 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
683          try {
542 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
684              c.putIfAbsent(null, "whatever");
685              shouldThrow();
686          } catch (NullPointerException success) {}
# Line 549 | Line 690 | public class ConcurrentHashMapTest exten
690       * replace(null, x) throws NPE
691       */
692      public void testReplace_NullPointerException() {
693 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
694          try {
553 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
695              c.replace(null, "whatever");
696              shouldThrow();
697          } catch (NullPointerException success) {}
# Line 560 | Line 701 | public class ConcurrentHashMapTest exten
701       * replace(null, x, y) throws NPE
702       */
703      public void testReplaceValue_NullPointerException() {
704 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
705          try {
564 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
706              c.replace(null, one, "whatever");
707              shouldThrow();
708          } catch (NullPointerException success) {}
# Line 571 | Line 712 | public class ConcurrentHashMapTest exten
712       * putIfAbsent(x, null) throws NPE
713       */
714      public void testPutIfAbsent2_NullPointerException() {
715 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
716          try {
575 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
717              c.putIfAbsent("whatever", null);
718              shouldThrow();
719          } catch (NullPointerException success) {}
# Line 582 | Line 723 | public class ConcurrentHashMapTest exten
723       * replace(x, null) throws NPE
724       */
725      public void testReplace2_NullPointerException() {
726 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
727          try {
586 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
728              c.replace("whatever", null);
729              shouldThrow();
730          } catch (NullPointerException success) {}
# Line 593 | Line 734 | public class ConcurrentHashMapTest exten
734       * replace(x, null, y) throws NPE
735       */
736      public void testReplaceValue2_NullPointerException() {
737 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
738          try {
597 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
739              c.replace("whatever", null, "A");
740              shouldThrow();
741          } catch (NullPointerException success) {}
# Line 604 | Line 745 | public class ConcurrentHashMapTest exten
745       * replace(x, y, null) throws NPE
746       */
747      public void testReplaceValue3_NullPointerException() {
748 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
749          try {
608 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
750              c.replace("whatever", one, null);
751              shouldThrow();
752          } catch (NullPointerException success) {}
# Line 615 | Line 756 | public class ConcurrentHashMapTest exten
756       * remove(null) throws NPE
757       */
758      public void testRemove1_NullPointerException() {
759 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
760 +        c.put("sadsdf", "asdads");
761          try {
619 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
620 –            c.put("sadsdf", "asdads");
762              c.remove(null);
763              shouldThrow();
764          } catch (NullPointerException success) {}
# Line 627 | Line 768 | public class ConcurrentHashMapTest exten
768       * remove(null, x) throws NPE
769       */
770      public void testRemove2_NullPointerException() {
771 +        ConcurrentHashMap c = new ConcurrentHashMap(5);
772 +        c.put("sadsdf", "asdads");
773          try {
631 –            ConcurrentHashMap c = new ConcurrentHashMap(5);
632 –            c.put("sadsdf", "asdads");
774              c.remove(null, "whatever");
775              shouldThrow();
776          } catch (NullPointerException success) {}
# Line 679 | Line 820 | public class ConcurrentHashMapTest exten
820          }
821      }
822  
823 +    /**
824 +     * Tests performance of removeAll when the other collection is much smaller.
825 +     * ant -Djsr166.tckTestClass=ConcurrentHashMapTest -Djsr166.methodFilter=testRemoveAll_performance -Djsr166.expensiveTests=true tck
826 +     */
827 +    public void testRemoveAll_performance() {
828 +        final int mapSize = expensiveTests ? 1_000_000 : 100;
829 +        final int iterations = expensiveTests ? 500 : 2;
830 +        final ConcurrentHashMap<Integer, Integer> map = new ConcurrentHashMap<>();
831 +        for (int i = 0; i < mapSize; i++)
832 +            map.put(i, i);
833 +        Set<Integer> keySet = map.keySet();
834 +        Collection<Integer> removeMe = Arrays.asList(new Integer[] { -99, -86 });
835 +        for (int i = 0; i < iterations; i++)
836 +            assertFalse(keySet.removeAll(removeMe));
837 +        assertEquals(mapSize, map.size());
838 +    }
839 +
840 +    /**
841 +     * Tests performance of computeIfAbsent when the element is present.
842 +     * See JDK-8161372
843 +     * ant -Djsr166.tckTestClass=ConcurrentHashMapTest -Djsr166.methodFilter=testcomputeIfAbsent_performance -Djsr166.expensiveTests=true tck
844 +     */
845 +    public void testcomputeIfAbsent_performance() {
846 +        final int mapSize = 20;
847 +        final int iterations = expensiveTests ? (1 << 23) : mapSize * 2;
848 +        final int threads = expensiveTests ? 10 : 2;
849 +        final ConcurrentHashMap<Integer, Integer> map = new ConcurrentHashMap<>();
850 +        for (int i = 0; i < mapSize; i++)
851 +            map.put(i, i);
852 +        final ExecutorService pool = Executors.newFixedThreadPool(2);
853 +        try (PoolCleaner cleaner = cleaner(pool)) {
854 +            Runnable r = new CheckedRunnable() {
855 +                public void realRun() {
856 +                    int result = 0;
857 +                    for (int i = 0; i < iterations; i++)
858 +                        result += map.computeIfAbsent(i % mapSize, (k) -> k + k);
859 +                    if (result == -42) throw new Error();
860 +                }};
861 +            for (int i = 0; i < threads; i++)
862 +                pool.execute(r);
863 +        }
864 +    }
865 +
866   }

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines