ViewVC Help

View File | Revision Log | Show Annotations | Download File | Root Listing

root/jsr166/jsr166/src/test/tck/ConcurrentSkipListSetTest.java

Comparing jsr166/src/test/tck/ConcurrentSkipListSetTest.java (file contents):
Revision 1.21 by jsr166, Thu Apr 14 22:55:08 2011 UTC vs.
Revision 1.43 by jsr166, Thu Jun 2 01:15:46 2016 UTC

#	Line 4 | Line 4
4		* http://creativecommons.org/publicdomain/zero/1.0/
5		*/
6
7	<	import junit.framework.*;
8	<	import java.util.*;
9	<	import java.util.concurrent.*;
10	<	import java.io.*;
7	>	import java.util.Arrays;
8	>	import java.util.BitSet;
9	>	import java.util.Collection;
10	>	import java.util.Comparator;
11	>	import java.util.Iterator;
12	>	import java.util.NavigableSet;
13	>	import java.util.NoSuchElementException;
14	>	import java.util.Random;
15	>	import java.util.Set;
16	>	import java.util.SortedSet;
17	>	import java.util.concurrent.ConcurrentSkipListSet;
18	>
19	>	import junit.framework.Test;
20	>	import junit.framework.TestSuite;
21
22		public class ConcurrentSkipListSetTest extends JSR166TestCase {
23		public static void main(String[] args) {
24	<	junit.textui.TestRunner.run(suite());
24	>	main(suite(), args);
25		}
26		public static Test suite() {
27		return new TestSuite(ConcurrentSkipListSetTest.class);
#	Line 24 | Line 34 | public class ConcurrentSkipListSetTest e
34		}
35
36		/**
37	<	* Create a set of given size containing consecutive
37	>	* Returns a new set of given size containing consecutive
38		* Integers 0 ... n.
39		*/
40		private ConcurrentSkipListSet<Integer> populatedSet(int n) {
41		ConcurrentSkipListSet<Integer> q =
42		new ConcurrentSkipListSet<Integer>();
43		assertTrue(q.isEmpty());
44	<	for (int i = n-1; i >= 0; i-=2)
44	>	for (int i = n - 1; i >= 0; i -= 2)
45		assertTrue(q.add(new Integer(i)));
46	<	for (int i = (n & 1); i < n; i+=2)
46	>	for (int i = (n & 1); i < n; i += 2)
47		assertTrue(q.add(new Integer(i)));
48		assertFalse(q.isEmpty());
49		assertEquals(n, q.size());
#	Line 41 | Line 51 | public class ConcurrentSkipListSetTest e
51		}
52
53		/**
54	<	* Create set of first 5 ints
54	>	* Returns a new set of first 5 ints.
55		*/
56		private ConcurrentSkipListSet set5() {
57		ConcurrentSkipListSet q = new ConcurrentSkipListSet();
#	Line 67 | Line 77 | public class ConcurrentSkipListSetTest e
77		*/
78		public void testConstructor3() {
79		try {
80	<	ConcurrentSkipListSet q = new ConcurrentSkipListSet((Collection)null);
80	>	new ConcurrentSkipListSet((Collection)null);
81		shouldThrow();
82		} catch (NullPointerException success) {}
83		}
#	Line 77 | Line 87 | public class ConcurrentSkipListSetTest e
87		*/
88		public void testConstructor4() {
89		try {
90	<	Integer[] ints = new Integer[SIZE];
81	<	ConcurrentSkipListSet q = new ConcurrentSkipListSet(Arrays.asList(ints));
90	>	new ConcurrentSkipListSet(Arrays.asList(new Integer[SIZE]));
91		shouldThrow();
92		} catch (NullPointerException success) {}
93		}
#	Line 87 | Line 96 | public class ConcurrentSkipListSetTest e
96		* Initializing from Collection with some null elements throws NPE
97		*/
98		public void testConstructor5() {
99	+	Integer[] ints = new Integer[SIZE];
100	+	for (int i = 0; i < SIZE - 1; ++i)
101	+	ints[i] = new Integer(i);
102		try {
103	<	Integer[] ints = new Integer[SIZE];
92	<	for (int i = 0; i < SIZE-1; ++i)
93	<	ints[i] = new Integer(i);
94	<	ConcurrentSkipListSet q = new ConcurrentSkipListSet(Arrays.asList(ints));
103	>	new ConcurrentSkipListSet(Arrays.asList(ints));
104		shouldThrow();
105		} catch (NullPointerException success) {}
106		}
#	Line 119 | Line 128 | public class ConcurrentSkipListSetTest e
128		for (int i = 0; i < SIZE; ++i)
129		ints[i] = new Integer(i);
130		q.addAll(Arrays.asList(ints));
131	<	for (int i = SIZE-1; i >= 0; --i)
131	>	for (int i = SIZE - 1; i >= 0; --i)
132		assertEquals(ints[i], q.pollFirst());
133		}
134
#	Line 143 | Line 152 | public class ConcurrentSkipListSetTest e
152		public void testSize() {
153		ConcurrentSkipListSet q = populatedSet(SIZE);
154		for (int i = 0; i < SIZE; ++i) {
155	<	assertEquals(SIZE-i, q.size());
155	>	assertEquals(SIZE - i, q.size());
156		q.pollFirst();
157		}
158		for (int i = 0; i < SIZE; ++i) {
#	Line 156 | Line 165 | public class ConcurrentSkipListSetTest e
165		* add(null) throws NPE
166		*/
167		public void testAddNull() {
168	+	ConcurrentSkipListSet q = new ConcurrentSkipListSet();
169		try {
160	–	ConcurrentSkipListSet q = new ConcurrentSkipListSet();
170		q.add(null);
171		shouldThrow();
172		} catch (NullPointerException success) {}
#	Line 185 | Line 194 | public class ConcurrentSkipListSetTest e
194		* Add of non-Comparable throws CCE
195		*/
196		public void testAddNonComparable() {
197	+	ConcurrentSkipListSet q = new ConcurrentSkipListSet();
198		try {
189	–	ConcurrentSkipListSet q = new ConcurrentSkipListSet();
190	–	q.add(new Object());
199		q.add(new Object());
200		q.add(new Object());
201		shouldThrow();
202	<	} catch (ClassCastException success) {}
202	>	} catch (ClassCastException success) {
203	>	assertTrue(q.size() < 2);
204	>	for (int i = 0, size = q.size(); i < size; i++)
205	>	assertTrue(q.pollFirst().getClass() == Object.class);
206	>	assertNull(q.pollFirst());
207	>	assertTrue(q.isEmpty());
208	>	assertEquals(0, q.size());
209	>	}
210		}
211
212		/**
213		* addAll(null) throws NPE
214		*/
215		public void testAddAll1() {
216	+	ConcurrentSkipListSet q = new ConcurrentSkipListSet();
217		try {
202	–	ConcurrentSkipListSet q = new ConcurrentSkipListSet();
218		q.addAll(null);
219		shouldThrow();
220		} catch (NullPointerException success) {}
#	Line 209 | Line 224 | public class ConcurrentSkipListSetTest e
224		* addAll of a collection with null elements throws NPE
225		*/
226		public void testAddAll2() {
227	+	ConcurrentSkipListSet q = new ConcurrentSkipListSet();
228	+	Integer[] ints = new Integer[SIZE];
229		try {
213	–	ConcurrentSkipListSet q = new ConcurrentSkipListSet();
214	–	Integer[] ints = new Integer[SIZE];
230		q.addAll(Arrays.asList(ints));
231		shouldThrow();
232		} catch (NullPointerException success) {}
#	Line 222 | Line 237 | public class ConcurrentSkipListSetTest e
237		* possibly adding some elements
238		*/
239		public void testAddAll3() {
240	+	ConcurrentSkipListSet q = new ConcurrentSkipListSet();
241	+	Integer[] ints = new Integer[SIZE];
242	+	for (int i = 0; i < SIZE - 1; ++i)
243	+	ints[i] = new Integer(i);
244		try {
226	–	ConcurrentSkipListSet q = new ConcurrentSkipListSet();
227	–	Integer[] ints = new Integer[SIZE];
228	–	for (int i = 0; i < SIZE-1; ++i)
229	–	ints[i] = new Integer(i);
245		q.addAll(Arrays.asList(ints));
246		shouldThrow();
247		} catch (NullPointerException success) {}
#	Line 239 | Line 254 | public class ConcurrentSkipListSetTest e
254		Integer[] empty = new Integer[0];
255		Integer[] ints = new Integer[SIZE];
256		for (int i = 0; i < SIZE; ++i)
257	<	ints[i] = new Integer(SIZE-1-i);
257	>	ints[i] = new Integer(SIZE - 1 - i);
258		ConcurrentSkipListSet q = new ConcurrentSkipListSet();
259		assertFalse(q.addAll(Arrays.asList(empty)));
260		assertTrue(q.addAll(Arrays.asList(ints)));
#	Line 263 | Line 278 | public class ConcurrentSkipListSetTest e
278		*/
279		public void testPollLast() {
280		ConcurrentSkipListSet q = populatedSet(SIZE);
281	<	for (int i = SIZE-1; i >= 0; --i) {
281	>	for (int i = SIZE - 1; i >= 0; --i) {
282		assertEquals(i, q.pollLast());
283		}
284		assertNull(q.pollFirst());
285		}
286
272	–
287		/**
288		* remove(x) removes x and returns true if present
289		*/
290		public void testRemoveElement() {
291		ConcurrentSkipListSet q = populatedSet(SIZE);
292	<	for (int i = 1; i < SIZE; i+=2) {
292	>	for (int i = 1; i < SIZE; i += 2) {
293		assertTrue(q.contains(i));
294		assertTrue(q.remove(i));
295		assertFalse(q.contains(i));
296	<	assertTrue(q.contains(i-1));
296	>	assertTrue(q.contains(i - 1));
297		}
298	<	for (int i = 0; i < SIZE; i+=2) {
298	>	for (int i = 0; i < SIZE; i += 2) {
299		assertTrue(q.contains(i));
300		assertTrue(q.remove(i));
301		assertFalse(q.contains(i));
302	<	assertFalse(q.remove(i+1));
303	<	assertFalse(q.contains(i+1));
302	>	assertFalse(q.remove(i + 1));
303	>	assertFalse(q.contains(i + 1));
304		}
305		assertTrue(q.isEmpty());
306		}
#	Line 345 | Line 359 | public class ConcurrentSkipListSetTest e
359		assertTrue(changed);
360
361		assertTrue(q.containsAll(p));
362	<	assertEquals(SIZE-i, q.size());
362	>	assertEquals(SIZE - i, q.size());
363		p.pollFirst();
364		}
365		}
#	Line 358 | Line 372 | public class ConcurrentSkipListSetTest e
372		ConcurrentSkipListSet q = populatedSet(SIZE);
373		ConcurrentSkipListSet p = populatedSet(i);
374		assertTrue(q.removeAll(p));
375	<	assertEquals(SIZE-i, q.size());
375	>	assertEquals(SIZE - i, q.size());
376		for (int j = 0; j < i; ++j) {
377	<	Integer I = (Integer)(p.pollFirst());
378	<	assertFalse(q.contains(I));
377	>	Integer x = (Integer)(p.pollFirst());
378	>	assertFalse(q.contains(x));
379		}
380		}
381		}
382
369	–
370	–
383		/**
384		* lower returns preceding element
385		*/
#	Line 456 | Line 468 | public class ConcurrentSkipListSetTest e
468		public void testToArray2() {
469		ConcurrentSkipListSet<Integer> q = populatedSet(SIZE);
470		Integer[] ints = new Integer[SIZE];
471	<	Integer[] array = q.toArray(ints);
460	<	assertSame(ints, array);
471	>	assertSame(ints, q.toArray(ints));
472		for (int i = 0; i < ints.length; i++)
473		assertSame(ints[i], q.pollFirst());
474		}
#	Line 467 | Line 478 | public class ConcurrentSkipListSetTest e
478		*/
479		public void testIterator() {
480		ConcurrentSkipListSet q = populatedSet(SIZE);
470	–	int i = 0;
481		Iterator it = q.iterator();
482	<	while (it.hasNext()) {
482	>	int i;
483	>	for (i = 0; it.hasNext(); i++)
484		assertTrue(q.contains(it.next()));
474	–	++i;
475	–	}
485		assertEquals(i, SIZE);
486	+	assertIteratorExhausted(it);
487		}
488
489		/**
490		* iterator of empty set has no elements
491		*/
492		public void testEmptyIterator() {
493	<	ConcurrentSkipListSet q = new ConcurrentSkipListSet();
494	<	int i = 0;
495	<	Iterator it = q.iterator();
486	<	while (it.hasNext()) {
487	<	assertTrue(q.contains(it.next()));
488	<	++i;
489	<	}
490	<	assertEquals(i, 0);
493	>	NavigableSet s = new ConcurrentSkipListSet();
494	>	assertIteratorExhausted(s.iterator());
495	>	assertIteratorExhausted(s.descendingSet().iterator());
496		}
497
498		/**
#	Line 509 | Line 514 | public class ConcurrentSkipListSetTest e
514		assertFalse(it.hasNext());
515		}
516
512	–
517		/**
518		* toString contains toStrings of elements
519		*/
#	Line 517 | Line 521 | public class ConcurrentSkipListSetTest e
521		ConcurrentSkipListSet q = populatedSet(SIZE);
522		String s = q.toString();
523		for (int i = 0; i < SIZE; ++i) {
524	<	assertTrue(s.indexOf(String.valueOf(i)) >= 0);
524	>	assertTrue(s.contains(String.valueOf(i)));
525		}
526		}
527
#	Line 525 | Line 529 | public class ConcurrentSkipListSetTest e
529		* A deserialized serialized set has same elements
530		*/
531		public void testSerialization() throws Exception {
532	<	ConcurrentSkipListSet q = populatedSet(SIZE);
533	<	ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
534	<	ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
535	<	out.writeObject(q);
536	<	out.close();
537	<
538	<	ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
539	<	ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
540	<	ConcurrentSkipListSet r = (ConcurrentSkipListSet)in.readObject();
541	<	assertEquals(q.size(), r.size());
542	<	while (!q.isEmpty())
543	<	assertEquals(q.pollFirst(), r.pollFirst());
532	>	NavigableSet x = populatedSet(SIZE);
533	>	NavigableSet y = serialClone(x);
534	>
535	>	assertNotSame(x, y);
536	>	assertEquals(x.size(), y.size());
537	>	assertEquals(x, y);
538	>	assertEquals(y, x);
539	>	while (!x.isEmpty()) {
540	>	assertFalse(y.isEmpty());
541	>	assertEquals(x.pollFirst(), y.pollFirst());
542	>	}
543	>	assertTrue(y.isEmpty());
544		}
545
546		/**
#	Line 659 | Line 663 | public class ConcurrentSkipListSetTest e
663		}
664
665		Random rnd = new Random(666);
662	–	BitSet bs;
666
667		/**
668		* Subsets of subsets subdivide correctly
#	Line 669 | Line 672 | public class ConcurrentSkipListSetTest e
672		Class cl = ConcurrentSkipListSet.class;
673
674		NavigableSet<Integer> set = newSet(cl);
675	<	bs = new BitSet(setSize);
675	>	BitSet bs = new BitSet(setSize);
676
677	<	populate(set, setSize);
678	<	check(set,                 0, setSize - 1, true);
679	<	check(set.descendingSet(), 0, setSize - 1, false);
680	<
681	<	mutateSet(set, 0, setSize - 1);
682	<	check(set,                 0, setSize - 1, true);
683	<	check(set.descendingSet(), 0, setSize - 1, false);
677	>	populate(set, setSize, bs);
678	>	check(set,                 0, setSize - 1, true, bs);
679	>	check(set.descendingSet(), 0, setSize - 1, false, bs);
680	>
681	>	mutateSet(set, 0, setSize - 1, bs);
682	>	check(set,                 0, setSize - 1, true, bs);
683	>	check(set.descendingSet(), 0, setSize - 1, false, bs);
684
685		bashSubSet(set.subSet(0, true, setSize, false),
686	<	0, setSize - 1, true);
686	>	0, setSize - 1, true, bs);
687	>	}
688	>
689	>	/**
690	>	* addAll is idempotent
691	>	*/
692	>	public void testAddAll_idempotent() throws Exception {
693	>	Set x = populatedSet(SIZE);
694	>	Set y = new ConcurrentSkipListSet(x);
695	>	y.addAll(x);
696	>	assertEquals(x, y);
697	>	assertEquals(y, x);
698		}
699
700		static NavigableSet<Integer> newSet(Class cl) throws Exception {
701		NavigableSet<Integer> result = (NavigableSet<Integer>) cl.newInstance();
702	<	assertEquals(result.size(), 0);
702	>	assertEquals(0, result.size());
703		assertFalse(result.iterator().hasNext());
704		return result;
705		}
706
707	<	void populate(NavigableSet<Integer> set, int limit) {
707	>	void populate(NavigableSet<Integer> set, int limit, BitSet bs) {
708		for (int i = 0, n = 2 * limit / 3; i < n; i++) {
709		int element = rnd.nextInt(limit);
710	<	put(set, element);
710	>	put(set, element, bs);
711		}
712		}
713
714	<	void mutateSet(NavigableSet<Integer> set, int min, int max) {
714	>	void mutateSet(NavigableSet<Integer> set, int min, int max, BitSet bs) {
715		int size = set.size();
716		int rangeSize = max - min + 1;
717
718		// Remove a bunch of entries directly
719		for (int i = 0, n = rangeSize / 2; i < n; i++) {
720	<	remove(set, min - 5 + rnd.nextInt(rangeSize + 10));
720	>	remove(set, min - 5 + rnd.nextInt(rangeSize + 10), bs);
721		}
722
723		// Remove a bunch of entries with iterator
#	Line 717 | Line 731 | public class ConcurrentSkipListSetTest e
731		// Add entries till we're back to original size
732		while (set.size() < size) {
733		int element = min + rnd.nextInt(rangeSize);
734	<	assertTrue(element >= min && element<= max);
735	<	put(set, element);
734	>	assertTrue(element >= min && element <= max);
735	>	put(set, element, bs);
736		}
737		}
738
739	<	void mutateSubSet(NavigableSet<Integer> set, int min, int max) {
739	>	void mutateSubSet(NavigableSet<Integer> set, int min, int max,
740	>	BitSet bs) {
741		int size = set.size();
742		int rangeSize = max - min + 1;
743
744		// Remove a bunch of entries directly
745		for (int i = 0, n = rangeSize / 2; i < n; i++) {
746	<	remove(set, min - 5 + rnd.nextInt(rangeSize + 10));
746	>	remove(set, min - 5 + rnd.nextInt(rangeSize + 10), bs);
747		}
748
749		// Remove a bunch of entries with iterator
#	Line 742 | Line 757 | public class ConcurrentSkipListSetTest e
757		// Add entries till we're back to original size
758		while (set.size() < size) {
759		int element = min - 5 + rnd.nextInt(rangeSize + 10);
760	<	if (element >= min && element<= max) {
761	<	put(set, element);
760	>	if (element >= min && element <= max) {
761	>	put(set, element, bs);
762		} else {
763		try {
764		set.add(element);
#	Line 753 | Line 768 | public class ConcurrentSkipListSetTest e
768		}
769		}
770
771	<	void put(NavigableSet<Integer> set, int element) {
771	>	void put(NavigableSet<Integer> set, int element, BitSet bs) {
772		if (set.add(element))
773		bs.set(element);
774		}
775
776	<	void remove(NavigableSet<Integer> set, int element) {
776	>	void remove(NavigableSet<Integer> set, int element, BitSet bs) {
777		if (set.remove(element))
778		bs.clear(element);
779		}
780
781		void bashSubSet(NavigableSet<Integer> set,
782	<	int min, int max, boolean ascending) {
783	<	check(set, min, max, ascending);
784	<	check(set.descendingSet(), min, max, !ascending);
785	<
786	<	mutateSubSet(set, min, max);
787	<	check(set, min, max, ascending);
788	<	check(set.descendingSet(), min, max, !ascending);
782	>	int min, int max, boolean ascending,
783	>	BitSet bs) {
784	>	check(set, min, max, ascending, bs);
785	>	check(set.descendingSet(), min, max, !ascending, bs);
786	>
787	>	mutateSubSet(set, min, max, bs);
788	>	check(set, min, max, ascending, bs);
789	>	check(set.descendingSet(), min, max, !ascending, bs);
790
791		// Recurse
792		if (max - min < 2)
#	Line 782 | Line 798 | public class ConcurrentSkipListSetTest e
798		NavigableSet<Integer> hm = set.headSet(midPoint, incl);
799		if (ascending) {
800		if (rnd.nextBoolean())
801	<	bashSubSet(hm, min, midPoint - (incl ? 0 : 1), true);
801	>	bashSubSet(hm, min, midPoint - (incl ? 0 : 1), true, bs);
802		else
803		bashSubSet(hm.descendingSet(), min, midPoint - (incl ? 0 : 1),
804	<	false);
804	>	false, bs);
805		} else {
806		if (rnd.nextBoolean())
807	<	bashSubSet(hm, midPoint + (incl ? 0 : 1), max, false);
807	>	bashSubSet(hm, midPoint + (incl ? 0 : 1), max, false, bs);
808		else
809		bashSubSet(hm.descendingSet(), midPoint + (incl ? 0 : 1), max,
810	<	true);
810	>	true, bs);
811		}
812
813		// tailSet - pick direction and endpoint inclusion randomly
#	Line 799 | Line 815 | public class ConcurrentSkipListSetTest e
815		NavigableSet<Integer> tm = set.tailSet(midPoint,incl);
816		if (ascending) {
817		if (rnd.nextBoolean())
818	<	bashSubSet(tm, midPoint + (incl ? 0 : 1), max, true);
818	>	bashSubSet(tm, midPoint + (incl ? 0 : 1), max, true, bs);
819		else
820		bashSubSet(tm.descendingSet(), midPoint + (incl ? 0 : 1), max,
821	<	false);
821	>	false, bs);
822		} else {
823		if (rnd.nextBoolean()) {
824	<	bashSubSet(tm, min, midPoint - (incl ? 0 : 1), false);
824	>	bashSubSet(tm, min, midPoint - (incl ? 0 : 1), false, bs);
825		} else {
826		bashSubSet(tm.descendingSet(), min, midPoint - (incl ? 0 : 1),
827	<	true);
827	>	true, bs);
828		}
829		}
830
#	Line 825 | Line 841 | public class ConcurrentSkipListSetTest e
841		endpoints[0], lowIncl, endpoints[1], highIncl);
842		if (rnd.nextBoolean())
843		bashSubSet(sm, endpoints[0] + (lowIncl ? 0 : 1),
844	<	endpoints[1] - (highIncl ? 0 : 1), true);
844	>	endpoints[1] - (highIncl ? 0 : 1), true, bs);
845		else
846		bashSubSet(sm.descendingSet(), endpoints[0] + (lowIncl ? 0 : 1),
847	<	endpoints[1] - (highIncl ? 0 : 1), false);
847	>	endpoints[1] - (highIncl ? 0 : 1), false, bs);
848		} else {
849		NavigableSet<Integer> sm = set.subSet(
850		endpoints[1], highIncl, endpoints[0], lowIncl);
851		if (rnd.nextBoolean())
852		bashSubSet(sm, endpoints[0] + (lowIncl ? 0 : 1),
853	<	endpoints[1] - (highIncl ? 0 : 1), false);
853	>	endpoints[1] - (highIncl ? 0 : 1), false, bs);
854		else
855		bashSubSet(sm.descendingSet(), endpoints[0] + (lowIncl ? 0 : 1),
856	<	endpoints[1] - (highIncl ? 0 : 1), true);
856	>	endpoints[1] - (highIncl ? 0 : 1), true, bs);
857		}
858		}
859
#	Line 845 | Line 861 | public class ConcurrentSkipListSetTest e
861		* min and max are both inclusive.  If max < min, interval is empty.
862		*/
863		void check(NavigableSet<Integer> set,
864	<	final int min, final int max, final boolean ascending) {
864	>	final int min, final int max, final boolean ascending,
865	>	final BitSet bs) {
866		class ReferenceSet {
867		int lower(int element) {
868		return ascending ?
#	Line 916 | Line 933 | public class ConcurrentSkipListSetTest e
933		if (bsContainsI)
934		size++;
935		}
936	<	assertEquals(set.size(), size);
936	>	assertEquals(size, set.size());
937
938		// Test contents using contains elementSet iterator
939		int size2 = 0;
#	Line 964 | Line 981 | public class ConcurrentSkipListSetTest e
981		}
982
983		static boolean eq(Integer i, int j) {
984	<	return i == null ? j == -1 : i == j;
984	>	return (i == null) ? j == -1 : i == j;
985		}
986
987		}

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines