--- jsr166/src/test/tck/CopyOnWriteArrayListTest.java 2009/12/23 00:47:16 1.16 +++ jsr166/src/test/tck/CopyOnWriteArrayListTest.java 2011/11/30 05:42:38 1.27 @@ -1,36 +1,53 @@ /* * Written by Doug Lea with assistance from members of JCP JSR-166 * Expert Group and released to the public domain, as explained at - * http://creativecommons.org/licenses/publicdomain + * http://creativecommons.org/publicdomain/zero/1.0/ * Other contributors include Andrew Wright, Jeffrey Hayes, * Pat Fisher, Mike Judd. */ import junit.framework.*; -import java.util.*; -import java.util.concurrent.*; -import java.io.*; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.Iterator; +import java.util.LinkedList; +import java.util.List; +import java.util.ListIterator; +import java.util.NoSuchElementException; +import java.util.Vector; +import java.util.concurrent.CopyOnWriteArrayList; public class CopyOnWriteArrayListTest extends JSR166TestCase { public static void main(String[] args) { - junit.textui.TestRunner.run (suite()); + junit.textui.TestRunner.run(suite()); } public static Test suite() { return new TestSuite(CopyOnWriteArrayListTest.class); } - static CopyOnWriteArrayList populatedArray(int n) { - CopyOnWriteArrayList a = new CopyOnWriteArrayList(); + static CopyOnWriteArrayList populatedArray(int n) { + CopyOnWriteArrayList a = new CopyOnWriteArrayList(); assertTrue(a.isEmpty()); - for (int i = 0; i < n; ++i) - a.add(new Integer(i)); + for (int i = 0; i < n; i++) + a.add(i); assertFalse(a.isEmpty()); assertEquals(n, a.size()); return a; } + static CopyOnWriteArrayList populatedArray(Integer[] elements) { + CopyOnWriteArrayList a = new CopyOnWriteArrayList(); + assertTrue(a.isEmpty()); + for (int i = 0; i < elements.length; i++) + a.add(elements[i]); + assertFalse(a.isEmpty()); + assertEquals(elements.length, a.size()); + return a; + } /** * a new list is empty @@ -64,9 +81,8 @@ public class CopyOnWriteArrayListTest ex assertEquals(ints[i], a.get(i)); } - /** - * addAll adds each element from the given collection + * addAll adds each element from the given collection */ public void testAddAll() { CopyOnWriteArrayList full = populatedArray(3); @@ -79,8 +95,8 @@ public class CopyOnWriteArrayListTest ex } /** - * addAllAbsent adds each element from the given collection that did not - * already exist in the List + * addAllAbsent adds each element from the given collection that did not + * already exist in the List */ public void testAddAllAbsent() { CopyOnWriteArrayList full = populatedArray(3); @@ -93,7 +109,7 @@ public class CopyOnWriteArrayListTest ex } /** - * addIfAbsent will not add the element if it already exists in the list + * addIfAbsent will not add the element if it already exists in the list */ public void testAddIfAbsent() { CopyOnWriteArrayList full = populatedArray(SIZE); @@ -102,7 +118,7 @@ public class CopyOnWriteArrayListTest ex } /** - * addIfAbsent adds the element when it does not exist in the list + * addIfAbsent adds the element when it does not exist in the list */ public void testAddIfAbsent2() { CopyOnWriteArrayList full = populatedArray(SIZE); @@ -111,7 +127,7 @@ public class CopyOnWriteArrayListTest ex } /** - * clear removes all elements from the list + * clear removes all elements from the list */ public void testClear() { CopyOnWriteArrayList full = populatedArray(SIZE); @@ -119,9 +135,8 @@ public class CopyOnWriteArrayListTest ex assertEquals(0, full.size()); } - /** - * Cloned list is equal + * Cloned list is equal */ public void testClone() { CopyOnWriteArrayList l1 = populatedArray(SIZE); @@ -132,7 +147,7 @@ public class CopyOnWriteArrayListTest ex } /** - * contains is true for added elements + * contains is true for added elements */ public void testContains() { CopyOnWriteArrayList full = populatedArray(3); @@ -174,9 +189,8 @@ public class CopyOnWriteArrayListTest ex assertEquals(a.hashCode(), b.hashCode()); } - /** - * containsAll returns true for collection with subset of elements + * containsAll returns true for collection with subset of elements */ public void testContainsAll() { CopyOnWriteArrayList full = populatedArray(3); @@ -189,7 +203,7 @@ public class CopyOnWriteArrayListTest ex } /** - * get returns the value at the given index + * get returns the value at the given index */ public void testGet() { CopyOnWriteArrayList full = populatedArray(3); @@ -197,7 +211,7 @@ public class CopyOnWriteArrayListTest ex } /** - * indexOf gives the index for the given object + * indexOf gives the index for the given object */ public void testIndexOf() { CopyOnWriteArrayList full = populatedArray(3); @@ -206,8 +220,8 @@ public class CopyOnWriteArrayListTest ex } /** - * indexOf gives the index based on the given index - * at which to start searching + * indexOf gives the index based on the given index + * at which to start searching */ public void testIndexOf2() { CopyOnWriteArrayList full = populatedArray(3); @@ -216,7 +230,7 @@ public class CopyOnWriteArrayListTest ex } /** - * isEmpty returns true when empty, else false + * isEmpty returns true when empty, else false */ public void testIsEmpty() { CopyOnWriteArrayList empty = new CopyOnWriteArrayList(); @@ -226,21 +240,39 @@ public class CopyOnWriteArrayListTest ex } /** - * iterator() returns an iterator containing the elements of the list + * iterator() returns an iterator containing the elements of the + * list in insertion order */ public void testIterator() { - CopyOnWriteArrayList full = populatedArray(SIZE); - Iterator i = full.iterator(); - int j; - for (j = 0; i.hasNext(); j++) - assertEquals(j, i.next()); - assertEquals(SIZE, j); + Collection empty = new CopyOnWriteArrayList(); + assertFalse(empty.iterator().hasNext()); + try { + empty.iterator().next(); + shouldThrow(); + } catch (NoSuchElementException success) {} + + Integer[] elements = new Integer[SIZE]; + for (int i = 0; i < SIZE; i++) + elements[i] = i; + Collections.shuffle(Arrays.asList(elements)); + Collection full = populatedArray(elements); + + Iterator it = full.iterator(); + for (int j = 0; j < SIZE; j++) { + assertTrue(it.hasNext()); + assertEquals(elements[j], it.next()); + } + assertFalse(it.hasNext()); + try { + it.next(); + shouldThrow(); + } catch (NoSuchElementException success) {} } /** * iterator.remove throws UnsupportedOperationException */ - public void testIteratorRemove () { + public void testIteratorRemove() { CopyOnWriteArrayList full = populatedArray(SIZE); Iterator it = full.iterator(); it.next(); @@ -254,15 +286,17 @@ public class CopyOnWriteArrayListTest ex * toString contains toString of elements */ public void testToString() { + assertEquals("[]", new CopyOnWriteArrayList().toString()); CopyOnWriteArrayList full = populatedArray(3); String s = full.toString(); - for (int i = 0; i < 3; ++i) { - assertTrue(s.indexOf(String.valueOf(i)) >= 0); - } + for (int i = 0; i < 3; ++i) + assertTrue(s.contains(String.valueOf(i))); + assertEquals(new ArrayList(full).toString(), + full.toString()); } /** - * lastIndexOf returns the index for the given object + * lastIndexOf returns the index for the given object */ public void testLastIndexOf1() { CopyOnWriteArrayList full = populatedArray(3); @@ -273,9 +307,9 @@ public class CopyOnWriteArrayListTest ex } /** - * lastIndexOf returns the index from the given starting point + * lastIndexOf returns the index from the given starting point */ - public void testlastIndexOf2() { + public void testLastIndexOf2() { CopyOnWriteArrayList full = populatedArray(3); full.add(one); full.add(three); @@ -284,7 +318,7 @@ public class CopyOnWriteArrayListTest ex } /** - * listIterator traverses all elements + * listIterator traverses all elements */ public void testListIterator1() { CopyOnWriteArrayList full = populatedArray(SIZE); @@ -296,7 +330,7 @@ public class CopyOnWriteArrayListTest ex } /** - * listIterator only returns those elements after the given index + * listIterator only returns those elements after the given index */ public void testListIterator2() { CopyOnWriteArrayList full = populatedArray(3); @@ -308,7 +342,7 @@ public class CopyOnWriteArrayListTest ex } /** - * remove removes and returns the object at the given index + * remove removes and returns the object at the given index */ public void testRemove() { CopyOnWriteArrayList full = populatedArray(3); @@ -317,7 +351,7 @@ public class CopyOnWriteArrayListTest ex } /** - * removeAll removes all elements from the given collection + * removeAll removes all elements from the given collection */ public void testRemoveAll() { CopyOnWriteArrayList full = populatedArray(3); @@ -329,7 +363,7 @@ public class CopyOnWriteArrayListTest ex } /** - * set changes the element at the given index + * set changes the element at the given index */ public void testSet() { CopyOnWriteArrayList full = populatedArray(3); @@ -338,7 +372,7 @@ public class CopyOnWriteArrayListTest ex } /** - * size returns the number of elements + * size returns the number of elements */ public void testSize() { CopyOnWriteArrayList empty = new CopyOnWriteArrayList(); @@ -348,31 +382,67 @@ public class CopyOnWriteArrayListTest ex } /** - * toArray returns an Object array containing all elements from the list + * toArray() returns an Object array containing all elements from + * the list in insertion order */ public void testToArray() { - CopyOnWriteArrayList full = populatedArray(3); - Object[] o = full.toArray(); - assertEquals(3, o.length); - assertEquals(0, o[0]); - assertEquals(1, o[1]); - assertEquals(2, o[2]); + Object[] a = new CopyOnWriteArrayList().toArray(); + assertTrue(Arrays.equals(new Object[0], a)); + assertSame(Object[].class, a.getClass()); + + Integer[] elements = new Integer[SIZE]; + for (int i = 0; i < SIZE; i++) + elements[i] = i; + Collections.shuffle(Arrays.asList(elements)); + Collection full = populatedArray(elements); + + assertTrue(Arrays.equals(elements, full.toArray())); + assertSame(Object[].class, full.toArray().getClass()); } /** - * toArray returns an Integer array containing all elements from - * the list + * toArray(Integer array) returns an Integer array containing all + * elements from the list in insertion order */ public void testToArray2() { - CopyOnWriteArrayList full = populatedArray(3); - Integer[] i = new Integer[3]; - i = (Integer[])full.toArray(i); - assertEquals(3, i.length); - assertEquals(0, i[0].intValue()); - assertEquals(1, i[1].intValue()); - assertEquals(2, i[2].intValue()); - } + Collection empty = new CopyOnWriteArrayList(); + Integer[] a; + a = new Integer[0]; + assertSame(a, empty.toArray(a)); + + a = new Integer[SIZE/2]; + Arrays.fill(a, 42); + assertSame(a, empty.toArray(a)); + assertNull(a[0]); + for (int i = 1; i < a.length; i++) + assertEquals(42, (int) a[i]); + + Integer[] elements = new Integer[SIZE]; + for (int i = 0; i < SIZE; i++) + elements[i] = i; + Collections.shuffle(Arrays.asList(elements)); + Collection full = populatedArray(elements); + + Arrays.fill(a, 42); + assertTrue(Arrays.equals(elements, full.toArray(a))); + for (int i = 0; i < a.length; i++) + assertEquals(42, (int) a[i]); + assertSame(Integer[].class, full.toArray(a).getClass()); + + a = new Integer[SIZE]; + Arrays.fill(a, 42); + assertSame(a, full.toArray(a)); + assertTrue(Arrays.equals(elements, a)); + + a = new Integer[2*SIZE]; + Arrays.fill(a, 42); + assertSame(a, full.toArray(a)); + assertTrue(Arrays.equals(elements, Arrays.copyOf(a, SIZE))); + assertNull(a[SIZE]); + for (int i = SIZE + 1; i < a.length; i++) + assertEquals(42, (int) a[i]); + } /** * sublists contains elements at indexes offset from their base @@ -390,18 +460,18 @@ public class CopyOnWriteArrayListTest ex } List s = a.subList(2, 5); - assertEquals(s.size(), 3); + assertEquals(3, s.size()); s.set(2, m1); assertEquals(a.get(4), m1); s.clear(); - assertEquals(a.size(), 7); + assertEquals(7, a.size()); } // Exception tests /** - * toArray throws an ArrayStoreException when the given array - * can not store the objects inside the list + * toArray throws an ArrayStoreException when the given array + * can not store the objects inside the list */ public void testToArray_ArrayStoreException() { try { @@ -414,7 +484,7 @@ public class CopyOnWriteArrayListTest ex } /** - * get throws an IndexOutOfBoundsException on a negative index + * get throws an IndexOutOfBoundsException on a negative index */ public void testGet1_IndexOutOfBoundsException() { try { @@ -425,7 +495,7 @@ public class CopyOnWriteArrayListTest ex } /** - * get throws an IndexOutOfBoundsException on a too high index + * get throws an IndexOutOfBoundsException on a too high index */ public void testGet2_IndexOutOfBoundsException() { try { @@ -438,7 +508,7 @@ public class CopyOnWriteArrayListTest ex } /** - * set throws an IndexOutOfBoundsException on a negative index + * set throws an IndexOutOfBoundsException on a negative index */ public void testSet1_IndexOutOfBoundsException() { try { @@ -449,7 +519,7 @@ public class CopyOnWriteArrayListTest ex } /** - * set throws an IndexOutOfBoundsException on a too high index + * set throws an IndexOutOfBoundsException on a too high index */ public void testSet2() { try { @@ -462,7 +532,7 @@ public class CopyOnWriteArrayListTest ex } /** - * add throws an IndexOutOfBoundsException on a negative index + * add throws an IndexOutOfBoundsException on a negative index */ public void testAdd1_IndexOutOfBoundsException() { try { @@ -473,7 +543,7 @@ public class CopyOnWriteArrayListTest ex } /** - * add throws an IndexOutOfBoundsException on a too high index + * add throws an IndexOutOfBoundsException on a too high index */ public void testAdd2_IndexOutOfBoundsException() { try { @@ -486,7 +556,7 @@ public class CopyOnWriteArrayListTest ex } /** - * remove throws an IndexOutOfBoundsException on a negative index + * remove throws an IndexOutOfBoundsException on a negative index */ public void testRemove1_IndexOutOfBounds() { try { @@ -497,7 +567,7 @@ public class CopyOnWriteArrayListTest ex } /** - * remove throws an IndexOutOfBoundsException on a too high index + * remove throws an IndexOutOfBoundsException on a too high index */ public void testRemove2_IndexOutOfBounds() { try { @@ -510,7 +580,7 @@ public class CopyOnWriteArrayListTest ex } /** - * addAll throws an IndexOutOfBoundsException on a negative index + * addAll throws an IndexOutOfBoundsException on a negative index */ public void testAddAll1_IndexOutOfBoundsException() { try { @@ -521,7 +591,7 @@ public class CopyOnWriteArrayListTest ex } /** - * addAll throws an IndexOutOfBoundsException on a too high index + * addAll throws an IndexOutOfBoundsException on a too high index */ public void testAddAll2_IndexOutOfBoundsException() { try { @@ -534,7 +604,7 @@ public class CopyOnWriteArrayListTest ex } /** - * listIterator throws an IndexOutOfBoundsException on a negative index + * listIterator throws an IndexOutOfBoundsException on a negative index */ public void testListIterator1_IndexOutOfBoundsException() { try { @@ -545,7 +615,7 @@ public class CopyOnWriteArrayListTest ex } /** - * listIterator throws an IndexOutOfBoundsException on a too high index + * listIterator throws an IndexOutOfBoundsException on a too high index */ public void testListIterator2_IndexOutOfBoundsException() { try { @@ -558,7 +628,7 @@ public class CopyOnWriteArrayListTest ex } /** - * subList throws an IndexOutOfBoundsException on a negative index + * subList throws an IndexOutOfBoundsException on a negative index */ public void testSubList1_IndexOutOfBoundsException() { try { @@ -569,7 +639,7 @@ public class CopyOnWriteArrayListTest ex } /** - * subList throws an IndexOutOfBoundsException on a too high index + * subList throws an IndexOutOfBoundsException on a too high index */ public void testSubList2_IndexOutOfBoundsException() { try { @@ -581,8 +651,8 @@ public class CopyOnWriteArrayListTest ex } /** - * subList throws IndexOutOfBoundsException when the second index - * is lower then the first + * subList throws IndexOutOfBoundsException when the second index + * is lower then the first */ public void testSubList3_IndexOutOfBoundsException() { try { @@ -596,19 +666,20 @@ public class CopyOnWriteArrayListTest ex * a deserialized serialized list is equal */ public void testSerialization() throws Exception { - CopyOnWriteArrayList q = populatedArray(SIZE); + List x = populatedArray(SIZE); + List y = serialClone(x); - ByteArrayOutputStream bout = new ByteArrayOutputStream(10000); - ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout)); - out.writeObject(q); - out.close(); - - ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray()); - ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin)); - CopyOnWriteArrayList r = (CopyOnWriteArrayList)in.readObject(); - assertEquals(q.size(), r.size()); - assertTrue(q.equals(r)); - assertTrue(r.equals(q)); + assertTrue(x != y); + assertEquals(x.size(), y.size()); + assertEquals(x.toString(), y.toString()); + assertTrue(Arrays.equals(x.toArray(), y.toArray())); + assertEquals(x, y); + assertEquals(y, x); + while (!x.isEmpty()) { + assertFalse(y.isEmpty()); + assertEquals(x.remove(0), y.remove(0)); + } + assertTrue(y.isEmpty()); } }