ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CopyOnWriteArrayListTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CopyOnWriteArrayListTest.java (file contents):
Revision 1.26 by jsr166, Tue Nov 29 05:23:56 2011 UTC vs.
Revision 1.48 by jsr166, Tue Apr 3 00:58:28 2018 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 < import junit.framework.*;
9 > import java.util.ArrayList;
10   import java.util.Arrays;
11   import java.util.Collection;
12   import java.util.Collections;
13   import java.util.Iterator;
14 import java.util.LinkedList;
14   import java.util.List;
15   import java.util.ListIterator;
16 < import java.util.Vector;
16 > import java.util.NoSuchElementException;
17   import java.util.concurrent.CopyOnWriteArrayList;
18 + import java.util.concurrent.ThreadLocalRandom;
19 +
20 + import junit.framework.Test;
21  
22   public class CopyOnWriteArrayListTest extends JSR166TestCase {
23  
24      public static void main(String[] args) {
25 <        junit.textui.TestRunner.run(suite());
25 >        main(suite(), args);
26      }
27  
28      public static Test suite() {
29 <        return new TestSuite(CopyOnWriteArrayListTest.class);
29 >        class Implementation implements CollectionImplementation {
30 >            public Class<?> klazz() { return CopyOnWriteArrayList.class; }
31 >            public List emptyCollection() { return new CopyOnWriteArrayList(); }
32 >            public Object makeElement(int i) { return i; }
33 >            public boolean isConcurrent() { return true; }
34 >            public boolean permitsNulls() { return true; }
35 >        }
36 >        class SubListImplementation extends Implementation {
37 >            public List emptyCollection() {
38 >                return super.emptyCollection().subList(0, 0);
39 >            }
40 >        }
41 >        return newTestSuite(
42 >                CopyOnWriteArrayListTest.class,
43 >                CollectionTest.testSuite(new Implementation()),
44 >                CollectionTest.testSuite(new SubListImplementation()));
45      }
46  
47 <    static CopyOnWriteArrayList<Integer> populatedArray(int n) {
48 <        CopyOnWriteArrayList<Integer> a = new CopyOnWriteArrayList<Integer>();
49 <        assertTrue(a.isEmpty());
47 >    static CopyOnWriteArrayList<Integer> populatedList(int n) {
48 >        CopyOnWriteArrayList<Integer> list = new CopyOnWriteArrayList<>();
49 >        assertTrue(list.isEmpty());
50          for (int i = 0; i < n; i++)
51 <            a.add(i);
52 <        assertFalse(a.isEmpty());
53 <        assertEquals(n, a.size());
54 <        return a;
51 >            list.add(i);
52 >        assertEquals(n <= 0, list.isEmpty());
53 >        assertEquals(n, list.size());
54 >        return list;
55      }
56  
57 <    static CopyOnWriteArrayList<Integer> populatedArray(Integer[] elements) {
58 <        CopyOnWriteArrayList<Integer> a = new CopyOnWriteArrayList<Integer>();
59 <        assertTrue(a.isEmpty());
60 <        for (int i = 0; i < elements.length; i++)
61 <            a.add(elements[i]);
62 <        assertFalse(a.isEmpty());
63 <        assertEquals(elements.length, a.size());
64 <        return a;
57 >    static CopyOnWriteArrayList<Integer> populatedList(Integer[] elements) {
58 >        CopyOnWriteArrayList<Integer> list = new CopyOnWriteArrayList<>();
59 >        assertTrue(list.isEmpty());
60 >        for (Integer element : elements)
61 >            list.add(element);
62 >        assertFalse(list.isEmpty());
63 >        assertEquals(elements.length, list.size());
64 >        return list;
65      }
66  
67      /**
68       * a new list is empty
69       */
70      public void testConstructor() {
71 <        CopyOnWriteArrayList a = new CopyOnWriteArrayList();
72 <        assertTrue(a.isEmpty());
71 >        List list = new CopyOnWriteArrayList();
72 >        assertTrue(list.isEmpty());
73      }
74  
75      /**
76       * new list contains all elements of initializing array
77       */
78      public void testConstructor2() {
79 <        Integer[] ints = new Integer[SIZE];
80 <        for (int i = 0; i < SIZE-1; ++i)
81 <            ints[i] = new Integer(i);
82 <        CopyOnWriteArrayList a = new CopyOnWriteArrayList(ints);
79 >        Integer[] elts = new Integer[SIZE];
80 >        for (int i = 0; i < SIZE - 1; ++i)
81 >            elts[i] = i;
82 >        List list = new CopyOnWriteArrayList(elts);
83          for (int i = 0; i < SIZE; ++i)
84 <            assertEquals(ints[i], a.get(i));
84 >            assertEquals(elts[i], list.get(i));
85      }
86  
87      /**
88       * new list contains all elements of initializing collection
89       */
90      public void testConstructor3() {
91 <        Integer[] ints = new Integer[SIZE];
92 <        for (int i = 0; i < SIZE-1; ++i)
93 <            ints[i] = new Integer(i);
94 <        CopyOnWriteArrayList a = new CopyOnWriteArrayList(Arrays.asList(ints));
91 >        Integer[] elts = new Integer[SIZE];
92 >        for (int i = 0; i < SIZE - 1; ++i)
93 >            elts[i] = i;
94 >        List list = new CopyOnWriteArrayList(Arrays.asList(elts));
95          for (int i = 0; i < SIZE; ++i)
96 <            assertEquals(ints[i], a.get(i));
96 >            assertEquals(elts[i], list.get(i));
97      }
98  
99      /**
100 <     * addAll adds each element from the given collection
100 >     * addAll adds each element from the given collection, including duplicates
101       */
102      public void testAddAll() {
103 <        CopyOnWriteArrayList full = populatedArray(3);
104 <        Vector v = new Vector();
105 <        v.add(three);
106 <        v.add(four);
107 <        v.add(five);
91 <        full.addAll(v);
92 <        assertEquals(6, full.size());
103 >        List list = populatedList(3);
104 >        assertTrue(list.addAll(Arrays.asList(three, four, five)));
105 >        assertEquals(6, list.size());
106 >        assertTrue(list.addAll(Arrays.asList(three, four, five)));
107 >        assertEquals(9, list.size());
108      }
109  
110      /**
# Line 97 | Line 112 | public class CopyOnWriteArrayListTest ex
112       * already exist in the List
113       */
114      public void testAddAllAbsent() {
115 <        CopyOnWriteArrayList full = populatedArray(3);
116 <        Vector v = new Vector();
117 <        v.add(three);
118 <        v.add(four);
119 <        v.add(one); // will not add this element
120 <        full.addAllAbsent(v);
106 <        assertEquals(5, full.size());
115 >        CopyOnWriteArrayList list = populatedList(3);
116 >        // "one" is duplicate and will not be added
117 >        assertEquals(2, list.addAllAbsent(Arrays.asList(three, four, one)));
118 >        assertEquals(5, list.size());
119 >        assertEquals(0, list.addAllAbsent(Arrays.asList(three, four, one)));
120 >        assertEquals(5, list.size());
121      }
122  
123      /**
124       * addIfAbsent will not add the element if it already exists in the list
125       */
126      public void testAddIfAbsent() {
127 <        CopyOnWriteArrayList full = populatedArray(SIZE);
128 <        full.addIfAbsent(one);
129 <        assertEquals(SIZE, full.size());
127 >        CopyOnWriteArrayList list = populatedList(SIZE);
128 >        list.addIfAbsent(one);
129 >        assertEquals(SIZE, list.size());
130      }
131  
132      /**
133       * addIfAbsent adds the element when it does not exist in the list
134       */
135      public void testAddIfAbsent2() {
136 <        CopyOnWriteArrayList full = populatedArray(SIZE);
137 <        full.addIfAbsent(three);
138 <        assertTrue(full.contains(three));
136 >        CopyOnWriteArrayList list = populatedList(SIZE);
137 >        list.addIfAbsent(three);
138 >        assertTrue(list.contains(three));
139      }
140  
141      /**
142       * clear removes all elements from the list
143       */
144      public void testClear() {
145 <        CopyOnWriteArrayList full = populatedArray(SIZE);
146 <        full.clear();
147 <        assertEquals(0, full.size());
145 >        List list = populatedList(SIZE);
146 >        list.clear();
147 >        assertEquals(0, list.size());
148      }
149  
150      /**
151       * Cloned list is equal
152       */
153      public void testClone() {
154 <        CopyOnWriteArrayList l1 = populatedArray(SIZE);
154 >        CopyOnWriteArrayList l1 = populatedList(SIZE);
155          CopyOnWriteArrayList l2 = (CopyOnWriteArrayList)(l1.clone());
156          assertEquals(l1, l2);
157          l1.clear();
# Line 148 | Line 162 | public class CopyOnWriteArrayListTest ex
162       * contains is true for added elements
163       */
164      public void testContains() {
165 <        CopyOnWriteArrayList full = populatedArray(3);
166 <        assertTrue(full.contains(one));
167 <        assertFalse(full.contains(five));
165 >        List list = populatedList(3);
166 >        assertTrue(list.contains(one));
167 >        assertFalse(list.contains(five));
168      }
169  
170      /**
171       * adding at an index places it in the indicated index
172       */
173      public void testAddIndex() {
174 <        CopyOnWriteArrayList full = populatedArray(3);
175 <        full.add(0, m1);
176 <        assertEquals(4, full.size());
177 <        assertEquals(m1, full.get(0));
178 <        assertEquals(zero, full.get(1));
179 <
180 <        full.add(2, m2);
181 <        assertEquals(5, full.size());
182 <        assertEquals(m2, full.get(2));
183 <        assertEquals(two, full.get(4));
174 >        List list = populatedList(3);
175 >        list.add(0, m1);
176 >        assertEquals(4, list.size());
177 >        assertEquals(m1, list.get(0));
178 >        assertEquals(zero, list.get(1));
179 >
180 >        list.add(2, m2);
181 >        assertEquals(5, list.size());
182 >        assertEquals(m2, list.get(2));
183 >        assertEquals(two, list.get(4));
184      }
185  
186      /**
187       * lists with same elements are equal and have same hashCode
188       */
189      public void testEquals() {
190 <        CopyOnWriteArrayList a = populatedArray(3);
191 <        CopyOnWriteArrayList b = populatedArray(3);
190 >        List a = populatedList(3);
191 >        List b = populatedList(3);
192          assertTrue(a.equals(b));
193          assertTrue(b.equals(a));
194 +        assertTrue(a.containsAll(b));
195 +        assertTrue(b.containsAll(a));
196          assertEquals(a.hashCode(), b.hashCode());
197          a.add(m1);
198          assertFalse(a.equals(b));
199          assertFalse(b.equals(a));
200 +        assertTrue(a.containsAll(b));
201 +        assertFalse(b.containsAll(a));
202          b.add(m1);
203          assertTrue(a.equals(b));
204          assertTrue(b.equals(a));
205 +        assertTrue(a.containsAll(b));
206 +        assertTrue(b.containsAll(a));
207          assertEquals(a.hashCode(), b.hashCode());
208 +
209 +        assertFalse(a.equals(null));
210      }
211  
212      /**
213 <     * containsAll returns true for collection with subset of elements
213 >     * containsAll returns true for collections with subset of elements
214       */
215      public void testContainsAll() {
216 <        CopyOnWriteArrayList full = populatedArray(3);
217 <        Vector v = new Vector();
218 <        v.add(one);
219 <        v.add(two);
220 <        assertTrue(full.containsAll(v));
221 <        v.add(six);
222 <        assertFalse(full.containsAll(v));
216 >        List list = populatedList(3);
217 >        assertTrue(list.containsAll(Arrays.asList()));
218 >        assertTrue(list.containsAll(Arrays.asList(one)));
219 >        assertTrue(list.containsAll(Arrays.asList(one, two)));
220 >        assertFalse(list.containsAll(Arrays.asList(one, two, six)));
221 >        assertFalse(list.containsAll(Arrays.asList(six)));
222 >
223 >        try {
224 >            list.containsAll(null);
225 >            shouldThrow();
226 >        } catch (NullPointerException success) {}
227      }
228  
229      /**
230       * get returns the value at the given index
231       */
232      public void testGet() {
233 <        CopyOnWriteArrayList full = populatedArray(3);
234 <        assertEquals(0, full.get(0));
233 >        List list = populatedList(3);
234 >        assertEquals(0, list.get(0));
235      }
236  
237      /**
238 <     * indexOf gives the index for the given object
238 >     * indexOf(Object) returns the index of the first occurrence of the
239 >     * specified element in this list, or -1 if this list does not
240 >     * contain the element
241       */
242      public void testIndexOf() {
243 <        CopyOnWriteArrayList full = populatedArray(3);
244 <        assertEquals(1, full.indexOf(one));
245 <        assertEquals(-1, full.indexOf("puppies"));
243 >        List list = populatedList(3);
244 >        assertEquals(-1, list.indexOf(-42));
245 >        int size = list.size();
246 >        for (int i = 0; i < size; i++) {
247 >            assertEquals(i, list.indexOf(i));
248 >            assertEquals(i, list.subList(0, size).indexOf(i));
249 >            assertEquals(i, list.subList(0, i + 1).indexOf(i));
250 >            assertEquals(-1, list.subList(0, i).indexOf(i));
251 >            assertEquals(0, list.subList(i, size).indexOf(i));
252 >            assertEquals(-1, list.subList(i + 1, size).indexOf(i));
253 >        }
254 >
255 >        list.add(1);
256 >        assertEquals(1, list.indexOf(1));
257 >        assertEquals(1, list.subList(0, size + 1).indexOf(1));
258 >        assertEquals(0, list.subList(1, size + 1).indexOf(1));
259 >        assertEquals(size - 2, list.subList(2, size + 1).indexOf(1));
260 >        assertEquals(0, list.subList(size, size + 1).indexOf(1));
261 >        assertEquals(-1, list.subList(size + 1, size + 1).indexOf(1));
262      }
263  
264      /**
265 <     * indexOf gives the index based on the given index
266 <     * at which to start searching
265 >     * indexOf(E, int) returns the index of the first occurrence of the
266 >     * specified element in this list, searching forwards from index,
267 >     * or returns -1 if the element is not found
268       */
269      public void testIndexOf2() {
270 <        CopyOnWriteArrayList full = populatedArray(3);
271 <        assertEquals(1, full.indexOf(one, 0));
272 <        assertEquals(-1, full.indexOf(one, 2));
270 >        CopyOnWriteArrayList list = populatedList(3);
271 >        int size = list.size();
272 >        assertEquals(-1, list.indexOf(-42, 0));
273 >
274 >        // we might expect IOOBE, but spec says otherwise
275 >        assertEquals(-1, list.indexOf(0, size));
276 >        assertEquals(-1, list.indexOf(0, Integer.MAX_VALUE));
277 >
278 >        assertThrows(
279 >            IndexOutOfBoundsException.class,
280 >            () -> list.indexOf(0, -1),
281 >            () -> list.indexOf(0, Integer.MIN_VALUE));
282 >
283 >        for (int i = 0; i < size; i++) {
284 >            assertEquals(i, list.indexOf(i, 0));
285 >            assertEquals(i, list.indexOf(i, i));
286 >            assertEquals(-1, list.indexOf(i, i + 1));
287 >        }
288 >
289 >        list.add(1);
290 >        assertEquals(1, list.indexOf(1, 0));
291 >        assertEquals(1, list.indexOf(1, 1));
292 >        assertEquals(size, list.indexOf(1, 2));
293 >        assertEquals(size, list.indexOf(1, size));
294      }
295  
296      /**
297       * isEmpty returns true when empty, else false
298       */
299      public void testIsEmpty() {
300 <        CopyOnWriteArrayList empty = new CopyOnWriteArrayList();
235 <        CopyOnWriteArrayList full = populatedArray(SIZE);
300 >        List empty = new CopyOnWriteArrayList();
301          assertTrue(empty.isEmpty());
302 +        assertTrue(empty.subList(0, 0).isEmpty());
303 +
304 +        List full = populatedList(SIZE);
305          assertFalse(full.isEmpty());
306 +        assertTrue(full.subList(0, 0).isEmpty());
307 +        assertTrue(full.subList(SIZE, SIZE).isEmpty());
308      }
309  
310      /**
311 <     * iterator() returns an iterator containing the elements of the list
311 >     * iterator() returns an iterator containing the elements of the
312 >     * list in insertion order
313       */
314      public void testIterator() {
315 <        CopyOnWriteArrayList full = populatedArray(SIZE);
316 <        Iterator i = full.iterator();
317 <        int j;
318 <        for (j = 0; i.hasNext(); j++)
319 <            assertEquals(j, i.next());
320 <        assertEquals(SIZE, j);
315 >        Collection empty = new CopyOnWriteArrayList();
316 >        assertFalse(empty.iterator().hasNext());
317 >        try {
318 >            empty.iterator().next();
319 >            shouldThrow();
320 >        } catch (NoSuchElementException success) {}
321 >
322 >        Integer[] elements = new Integer[SIZE];
323 >        for (int i = 0; i < SIZE; i++)
324 >            elements[i] = i;
325 >        shuffle(elements);
326 >        Collection<Integer> full = populatedList(elements);
327 >
328 >        Iterator it = full.iterator();
329 >        for (int j = 0; j < SIZE; j++) {
330 >            assertTrue(it.hasNext());
331 >            assertEquals(elements[j], it.next());
332 >        }
333 >        assertIteratorExhausted(it);
334 >    }
335 >
336 >    /**
337 >     * iterator of empty collection has no elements
338 >     */
339 >    public void testEmptyIterator() {
340 >        Collection c = new CopyOnWriteArrayList();
341 >        assertIteratorExhausted(c.iterator());
342      }
343  
344      /**
345       * iterator.remove throws UnsupportedOperationException
346       */
347      public void testIteratorRemove() {
348 <        CopyOnWriteArrayList full = populatedArray(SIZE);
349 <        Iterator it = full.iterator();
348 >        CopyOnWriteArrayList list = populatedList(SIZE);
349 >        Iterator it = list.iterator();
350          it.next();
351          try {
352              it.remove();
# Line 266 | Line 358 | public class CopyOnWriteArrayListTest ex
358       * toString contains toString of elements
359       */
360      public void testToString() {
361 <        CopyOnWriteArrayList full = populatedArray(3);
362 <        String s = full.toString();
363 <        for (int i = 0; i < 3; ++i) {
361 >        assertEquals("[]", new CopyOnWriteArrayList().toString());
362 >        List list = populatedList(3);
363 >        String s = list.toString();
364 >        for (int i = 0; i < 3; ++i)
365              assertTrue(s.contains(String.valueOf(i)));
366 <        }
366 >        assertEquals(new ArrayList(list).toString(),
367 >                     list.toString());
368      }
369  
370      /**
371 <     * lastIndexOf returns the index for the given object
371 >     * lastIndexOf(Object) returns the index of the last occurrence of
372 >     * the specified element in this list, or -1 if this list does not
373 >     * contain the element
374       */
375      public void testLastIndexOf1() {
376 <        CopyOnWriteArrayList full = populatedArray(3);
377 <        full.add(one);
378 <        full.add(three);
379 <        assertEquals(3, full.lastIndexOf(one));
380 <        assertEquals(-1, full.lastIndexOf(six));
376 >        List list = populatedList(3);
377 >        assertEquals(-1, list.lastIndexOf(-42));
378 >        int size = list.size();
379 >        for (int i = 0; i < size; i++) {
380 >            assertEquals(i, list.lastIndexOf(i));
381 >            assertEquals(i, list.subList(0, size).lastIndexOf(i));
382 >            assertEquals(i, list.subList(0, i + 1).lastIndexOf(i));
383 >            assertEquals(-1, list.subList(0, i).lastIndexOf(i));
384 >            assertEquals(0, list.subList(i, size).lastIndexOf(i));
385 >            assertEquals(-1, list.subList(i + 1, size).lastIndexOf(i));
386 >        }
387 >
388 >        list.add(1);
389 >        assertEquals(size, list.lastIndexOf(1));
390 >        assertEquals(size, list.subList(0, size + 1).lastIndexOf(1));
391 >        assertEquals(1, list.subList(0, size).lastIndexOf(1));
392 >        assertEquals(0, list.subList(1, 2).lastIndexOf(1));
393 >        assertEquals(-1, list.subList(0, 1).indexOf(1));
394      }
395  
396      /**
397 <     * lastIndexOf returns the index from the given starting point
397 >     * lastIndexOf(E, int) returns the index of the last occurrence of the
398 >     * specified element in this list, searching backwards from index, or
399 >     * returns -1 if the element is not found
400       */
401      public void testLastIndexOf2() {
402 <        CopyOnWriteArrayList full = populatedArray(3);
403 <        full.add(one);
404 <        full.add(three);
405 <        assertEquals(3, full.lastIndexOf(one, 4));
406 <        assertEquals(-1, full.lastIndexOf(three, 3));
402 >        CopyOnWriteArrayList list = populatedList(3);
403 >
404 >        // we might expect IOOBE, but spec says otherwise
405 >        assertEquals(-1, list.lastIndexOf(0, -1));
406 >
407 >        int size = list.size();
408 >        assertThrows(
409 >            IndexOutOfBoundsException.class,
410 >            () -> list.lastIndexOf(0, size),
411 >            () -> list.lastIndexOf(0, Integer.MAX_VALUE));
412 >
413 >        for (int i = 0; i < size; i++) {
414 >            assertEquals(i, list.lastIndexOf(i, i));
415 >            assertEquals(list.indexOf(i), list.lastIndexOf(i, i));
416 >            if (i > 0)
417 >                assertEquals(-1, list.lastIndexOf(i, i - 1));
418 >        }
419 >        list.add(one);
420 >        list.add(three);
421 >        assertEquals(1, list.lastIndexOf(one, 1));
422 >        assertEquals(1, list.lastIndexOf(one, 2));
423 >        assertEquals(3, list.lastIndexOf(one, 3));
424 >        assertEquals(3, list.lastIndexOf(one, 4));
425 >        assertEquals(-1, list.lastIndexOf(three, 3));
426      }
427  
428      /**
429       * listIterator traverses all elements
430       */
431      public void testListIterator1() {
432 <        CopyOnWriteArrayList full = populatedArray(SIZE);
433 <        ListIterator i = full.listIterator();
432 >        List list = populatedList(SIZE);
433 >        ListIterator i = list.listIterator();
434          int j;
435          for (j = 0; i.hasNext(); j++)
436              assertEquals(j, i.next());
# Line 311 | Line 441 | public class CopyOnWriteArrayListTest ex
441       * listIterator only returns those elements after the given index
442       */
443      public void testListIterator2() {
444 <        CopyOnWriteArrayList full = populatedArray(3);
445 <        ListIterator i = full.listIterator(1);
444 >        List list = populatedList(3);
445 >        ListIterator i = list.listIterator(1);
446          int j;
447          for (j = 0; i.hasNext(); j++)
448 <            assertEquals(j+1, i.next());
448 >            assertEquals(j + 1, i.next());
449          assertEquals(2, j);
450      }
451  
452      /**
453 <     * remove removes and returns the object at the given index
453 >     * remove(int) removes and returns the object at the given index
454       */
455 <    public void testRemove() {
456 <        CopyOnWriteArrayList full = populatedArray(3);
457 <        assertEquals(2, full.remove(2));
458 <        assertEquals(2, full.size());
455 >    public void testRemove_int() {
456 >        int SIZE = 3;
457 >        for (int i = 0; i < SIZE; i++) {
458 >            List list = populatedList(SIZE);
459 >            assertEquals(i, list.remove(i));
460 >            assertEquals(SIZE - 1, list.size());
461 >            assertFalse(list.contains(new Integer(i)));
462 >        }
463 >    }
464 >
465 >    /**
466 >     * remove(Object) removes the object if found and returns true
467 >     */
468 >    public void testRemove_Object() {
469 >        int SIZE = 3;
470 >        for (int i = 0; i < SIZE; i++) {
471 >            List list = populatedList(SIZE);
472 >            assertFalse(list.remove(new Integer(-42)));
473 >            assertTrue(list.remove(new Integer(i)));
474 >            assertEquals(SIZE - 1, list.size());
475 >            assertFalse(list.contains(new Integer(i)));
476 >        }
477 >        CopyOnWriteArrayList x = new CopyOnWriteArrayList(Arrays.asList(4, 5, 6));
478 >        assertTrue(x.remove(new Integer(6)));
479 >        assertEquals(x, Arrays.asList(4, 5));
480 >        assertTrue(x.remove(new Integer(4)));
481 >        assertEquals(x, Arrays.asList(5));
482 >        assertTrue(x.remove(new Integer(5)));
483 >        assertEquals(x, Arrays.asList());
484 >        assertFalse(x.remove(new Integer(5)));
485      }
486  
487      /**
488       * removeAll removes all elements from the given collection
489       */
490      public void testRemoveAll() {
491 <        CopyOnWriteArrayList full = populatedArray(3);
492 <        Vector v = new Vector();
493 <        v.add(one);
494 <        v.add(two);
495 <        full.removeAll(v);
340 <        assertEquals(1, full.size());
491 >        List list = populatedList(3);
492 >        assertTrue(list.removeAll(Arrays.asList(one, two)));
493 >        assertEquals(1, list.size());
494 >        assertFalse(list.removeAll(Arrays.asList(one, two)));
495 >        assertEquals(1, list.size());
496      }
497  
498      /**
499       * set changes the element at the given index
500       */
501      public void testSet() {
502 <        CopyOnWriteArrayList full = populatedArray(3);
503 <        assertEquals(2, full.set(2, four));
504 <        assertEquals(4, full.get(2));
502 >        List list = populatedList(3);
503 >        assertEquals(2, list.set(2, four));
504 >        assertEquals(4, list.get(2));
505      }
506  
507      /**
508       * size returns the number of elements
509       */
510      public void testSize() {
511 <        CopyOnWriteArrayList empty = new CopyOnWriteArrayList();
357 <        CopyOnWriteArrayList full = populatedArray(SIZE);
358 <        assertEquals(SIZE, full.size());
511 >        List empty = new CopyOnWriteArrayList();
512          assertEquals(0, empty.size());
513 +        assertEquals(0, empty.subList(0, 0).size());
514 +
515 +        List full = populatedList(SIZE);
516 +        assertEquals(SIZE, full.size());
517 +        assertEquals(0, full.subList(0, 0).size());
518 +        assertEquals(0, full.subList(SIZE, SIZE).size());
519      }
520  
521      /**
# Line 371 | Line 530 | public class CopyOnWriteArrayListTest ex
530          Integer[] elements = new Integer[SIZE];
531          for (int i = 0; i < SIZE; i++)
532              elements[i] = i;
533 <        Collections.shuffle(Arrays.asList(elements));
534 <        Collection<Integer> full = populatedArray(elements);
533 >        shuffle(elements);
534 >        Collection<Integer> full = populatedList(elements);
535  
536          assertTrue(Arrays.equals(elements, full.toArray()));
537          assertSame(Object[].class, full.toArray().getClass());
# Line 389 | Line 548 | public class CopyOnWriteArrayListTest ex
548          a = new Integer[0];
549          assertSame(a, empty.toArray(a));
550  
551 <        a = new Integer[SIZE/2];
551 >        a = new Integer[SIZE / 2];
552          Arrays.fill(a, 42);
553          assertSame(a, empty.toArray(a));
554          assertNull(a[0]);
# Line 399 | Line 558 | public class CopyOnWriteArrayListTest ex
558          Integer[] elements = new Integer[SIZE];
559          for (int i = 0; i < SIZE; i++)
560              elements[i] = i;
561 <        Collections.shuffle(Arrays.asList(elements));
562 <        Collection<Integer> full = populatedArray(elements);
561 >        shuffle(elements);
562 >        Collection<Integer> full = populatedList(elements);
563  
564          Arrays.fill(a, 42);
565          assertTrue(Arrays.equals(elements, full.toArray(a)));
# Line 413 | Line 572 | public class CopyOnWriteArrayListTest ex
572          assertSame(a, full.toArray(a));
573          assertTrue(Arrays.equals(elements, a));
574  
575 <        a = new Integer[2*SIZE];
575 >        a = new Integer[2 * SIZE];
576          Arrays.fill(a, 42);
577          assertSame(a, full.toArray(a));
578          assertTrue(Arrays.equals(elements, Arrays.copyOf(a, SIZE)));
# Line 426 | Line 585 | public class CopyOnWriteArrayListTest ex
585       * sublists contains elements at indexes offset from their base
586       */
587      public void testSubList() {
588 <        CopyOnWriteArrayList a = populatedArray(10);
588 >        List a = populatedList(10);
589          assertTrue(a.subList(1,1).isEmpty());
590          for (int j = 0; j < 9; ++j) {
591              for (int i = j ; i < 10; ++i) {
# Line 443 | Line 602 | public class CopyOnWriteArrayListTest ex
602          assertEquals(a.get(4), m1);
603          s.clear();
604          assertEquals(7, a.size());
605 +
606 +        assertThrows(
607 +            IndexOutOfBoundsException.class,
608 +            () -> s.get(0),
609 +            () -> s.set(0, 42));
610      }
611  
612      // Exception tests
# Line 452 | Line 616 | public class CopyOnWriteArrayListTest ex
616       * can not store the objects inside the list
617       */
618      public void testToArray_ArrayStoreException() {
619 <        try {
620 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
621 <            c.add("zfasdfsdf");
622 <            c.add("asdadasd");
623 <            c.toArray(new Long[5]);
624 <            shouldThrow();
625 <        } catch (ArrayStoreException success) {}
626 <    }
627 <
628 <    /**
629 <     * get throws an IndexOutOfBoundsException on a negative index
630 <     */
631 <    public void testGet1_IndexOutOfBoundsException() {
632 <        try {
633 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
634 <            c.get(-1);
635 <            shouldThrow();
636 <        } catch (IndexOutOfBoundsException success) {}
637 <    }
638 <
639 <    /**
640 <     * get throws an IndexOutOfBoundsException on a too high index
641 <     */
642 <    public void testGet2_IndexOutOfBoundsException() {
643 <        try {
644 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
645 <            c.add("asdasd");
646 <            c.add("asdad");
647 <            c.get(100);
648 <            shouldThrow();
649 <        } catch (IndexOutOfBoundsException success) {}
650 <    }
651 <
652 <    /**
653 <     * set throws an IndexOutOfBoundsException on a negative index
654 <     */
655 <    public void testSet1_IndexOutOfBoundsException() {
656 <        try {
657 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
658 <            c.set(-1,"qwerty");
659 <            shouldThrow();
660 <        } catch (IndexOutOfBoundsException success) {}
619 >        List list = new CopyOnWriteArrayList();
620 >        // Integers are not auto-converted to Longs
621 >        list.add(86);
622 >        list.add(99);
623 >        assertThrows(
624 >            ArrayStoreException.class,
625 >            () -> list.toArray(new Long[0]),
626 >            () -> list.toArray(new Long[5]));
627 >    }
628 >
629 >    void testIndexOutOfBoundsException(List list) {
630 >        int size = list.size();
631 >        assertThrows(
632 >            IndexOutOfBoundsException.class,
633 >            () -> list.get(-1),
634 >            () -> list.get(size),
635 >            () -> list.set(-1, "qwerty"),
636 >            () -> list.set(size, "qwerty"),
637 >            () -> list.add(-1, "qwerty"),
638 >            () -> list.add(size + 1, "qwerty"),
639 >            () -> list.remove(-1),
640 >            () -> list.remove(size),
641 >            () -> list.addAll(-1, Collections.emptyList()),
642 >            () -> list.addAll(size + 1, Collections.emptyList()),
643 >            () -> list.listIterator(-1),
644 >            () -> list.listIterator(size + 1),
645 >            () -> list.subList(-1, size),
646 >            () -> list.subList(0, size + 1));
647 >
648 >        // Conversely, operations that must not throw
649 >        list.addAll(0, Collections.emptyList());
650 >        list.addAll(size, Collections.emptyList());
651 >        list.add(0, "qwerty");
652 >        list.add(list.size(), "qwerty");
653 >        list.get(0);
654 >        list.get(list.size() - 1);
655 >        list.set(0, "azerty");
656 >        list.set(list.size() - 1, "azerty");
657 >        list.listIterator(0);
658 >        list.listIterator(list.size());
659 >        list.subList(0, list.size());
660 >        list.remove(list.size() - 1);
661      }
662  
663      /**
664 <     * set throws an IndexOutOfBoundsException on a too high index
665 <     */
666 <    public void testSet2() {
667 <        try {
668 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
669 <            c.add("asdasd");
670 <            c.add("asdad");
671 <            c.set(100, "qwerty");
672 <            shouldThrow();
673 <        } catch (IndexOutOfBoundsException success) {}
674 <    }
675 <
676 <    /**
677 <     * add throws an IndexOutOfBoundsException on a negative index
514 <     */
515 <    public void testAdd1_IndexOutOfBoundsException() {
516 <        try {
517 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
518 <            c.add(-1,"qwerty");
519 <            shouldThrow();
520 <        } catch (IndexOutOfBoundsException success) {}
521 <    }
522 <
523 <    /**
524 <     * add throws an IndexOutOfBoundsException on a too high index
525 <     */
526 <    public void testAdd2_IndexOutOfBoundsException() {
527 <        try {
528 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
529 <            c.add("asdasd");
530 <            c.add("asdasdasd");
531 <            c.add(100, "qwerty");
532 <            shouldThrow();
533 <        } catch (IndexOutOfBoundsException success) {}
534 <    }
535 <
536 <    /**
537 <     * remove throws an IndexOutOfBoundsException on a negative index
538 <     */
539 <    public void testRemove1_IndexOutOfBounds() {
540 <        try {
541 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
542 <            c.remove(-1);
543 <            shouldThrow();
544 <        } catch (IndexOutOfBoundsException success) {}
545 <    }
546 <
547 <    /**
548 <     * remove throws an IndexOutOfBoundsException on a too high index
549 <     */
550 <    public void testRemove2_IndexOutOfBounds() {
551 <        try {
552 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
553 <            c.add("asdasd");
554 <            c.add("adasdasd");
555 <            c.remove(100);
556 <            shouldThrow();
557 <        } catch (IndexOutOfBoundsException success) {}
558 <    }
559 <
560 <    /**
561 <     * addAll throws an IndexOutOfBoundsException on a negative index
562 <     */
563 <    public void testAddAll1_IndexOutOfBoundsException() {
564 <        try {
565 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
566 <            c.addAll(-1,new LinkedList());
567 <            shouldThrow();
568 <        } catch (IndexOutOfBoundsException success) {}
569 <    }
570 <
571 <    /**
572 <     * addAll throws an IndexOutOfBoundsException on a too high index
573 <     */
574 <    public void testAddAll2_IndexOutOfBoundsException() {
575 <        try {
576 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
577 <            c.add("asdasd");
578 <            c.add("asdasdasd");
579 <            c.addAll(100, new LinkedList());
580 <            shouldThrow();
581 <        } catch (IndexOutOfBoundsException success) {}
582 <    }
583 <
584 <    /**
585 <     * listIterator throws an IndexOutOfBoundsException on a negative index
586 <     */
587 <    public void testListIterator1_IndexOutOfBoundsException() {
588 <        try {
589 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
590 <            c.listIterator(-1);
591 <            shouldThrow();
592 <        } catch (IndexOutOfBoundsException success) {}
593 <    }
594 <
595 <    /**
596 <     * listIterator throws an IndexOutOfBoundsException on a too high index
597 <     */
598 <    public void testListIterator2_IndexOutOfBoundsException() {
599 <        try {
600 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
601 <            c.add("adasd");
602 <            c.add("asdasdas");
603 <            c.listIterator(100);
604 <            shouldThrow();
605 <        } catch (IndexOutOfBoundsException success) {}
606 <    }
607 <
608 <    /**
609 <     * subList throws an IndexOutOfBoundsException on a negative index
610 <     */
611 <    public void testSubList1_IndexOutOfBoundsException() {
612 <        try {
613 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
614 <            c.subList(-1,100);
615 <            shouldThrow();
616 <        } catch (IndexOutOfBoundsException success) {}
617 <    }
618 <
619 <    /**
620 <     * subList throws an IndexOutOfBoundsException on a too high index
621 <     */
622 <    public void testSubList2_IndexOutOfBoundsException() {
623 <        try {
624 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
625 <            c.add("asdasd");
626 <            c.subList(1,100);
627 <            shouldThrow();
628 <        } catch (IndexOutOfBoundsException success) {}
629 <    }
630 <
631 <    /**
632 <     * subList throws IndexOutOfBoundsException when the second index
633 <     * is lower then the first
634 <     */
635 <    public void testSubList3_IndexOutOfBoundsException() {
636 <        try {
637 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
638 <            c.subList(3,1);
639 <            shouldThrow();
640 <        } catch (IndexOutOfBoundsException success) {}
664 >     * IndexOutOfBoundsException is thrown when specified
665 >     */
666 >    public void testIndexOutOfBoundsException() {
667 >        ThreadLocalRandom rnd = ThreadLocalRandom.current();
668 >        List x = populatedList(rnd.nextInt(5));
669 >        testIndexOutOfBoundsException(x);
670 >
671 >        int start = rnd.nextInt(x.size() + 1);
672 >        int end = rnd.nextInt(start, x.size() + 1);
673 >        assertThrows(
674 >            IndexOutOfBoundsException.class,
675 >            () -> x.subList(start, start - 1));
676 >        List subList = x.subList(start, end);
677 >        testIndexOutOfBoundsException(x);
678      }
679  
680      /**
681 <     * a deserialized serialized list is equal
681 >     * a deserialized/reserialized list equals original
682       */
683      public void testSerialization() throws Exception {
684 <        List x = populatedArray(SIZE);
684 >        List x = populatedList(SIZE);
685          List y = serialClone(x);
686  
687 <        assertTrue(x != y);
687 >        assertNotSame(x, y);
688          assertEquals(x.size(), y.size());
689          assertEquals(x.toString(), y.toString());
690          assertTrue(Arrays.equals(x.toArray(), y.toArray()));

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines