--- jsr166/src/test/tck/CountDownLatchTest.java	2010/08/25 00:07:03	1.14
+++ jsr166/src/test/tck/CountDownLatchTest.java	2014/12/31 19:05:42	1.22
@@ -1,16 +1,18 @@
 /*
  * Written by Doug Lea with assistance from members of JCP JSR-166
  * Expert Group and released to the public domain, as explained at
- * http://creativecommons.org/licenses/publicdomain
+ * http://creativecommons.org/publicdomain/zero/1.0/
  * Other contributors include Andrew Wright, Jeffrey Hayes,
  * Pat Fisher, Mike Judd.
  */
 
-import junit.framework.*;
-import java.util.*;
-import java.util.concurrent.*;
 import static java.util.concurrent.TimeUnit.MILLISECONDS;
 
+import java.util.concurrent.CountDownLatch;
+
+import junit.framework.Test;
+import junit.framework.TestSuite;
+
 public class CountDownLatchTest extends JSR166TestCase {
     public static void main(String[] args) {
         junit.textui.TestRunner.run(suite());
@@ -54,82 +56,113 @@ public class CountDownLatchTest extends
     /**
      * await returns after countDown to zero, but not before
      */
-    public void testAwait() throws InterruptedException {
+    public void testAwait() {
         final CountDownLatch l = new CountDownLatch(2);
+        final CountDownLatch pleaseCountDown = new CountDownLatch(1);
 
-        Thread t = new Thread(new CheckedRunnable() {
+        Thread t = newStartedThread(new CheckedRunnable() {
             public void realRun() throws InterruptedException {
-                threadAssertTrue(l.getCount() > 0);
+                assertEquals(2, l.getCount());
+                pleaseCountDown.countDown();
                 l.await();
-                threadAssertTrue(l.getCount() == 0);
+                assertEquals(0, l.getCount());
             }});
 
-        t.start();
-        assertEquals(l.getCount(), 2);
-        Thread.sleep(SHORT_DELAY_MS);
+        await(pleaseCountDown);
+        assertEquals(2, l.getCount());
         l.countDown();
-        assertEquals(l.getCount(), 1);
+        assertEquals(1, l.getCount());
+        assertThreadStaysAlive(t);
         l.countDown();
-        assertEquals(l.getCount(), 0);
-        t.join();
+        assertEquals(0, l.getCount());
+        awaitTermination(t);
     }
 
-
     /**
      * timed await returns after countDown to zero
      */
-    public void testTimedAwait() throws InterruptedException {
+    public void testTimedAwait() {
         final CountDownLatch l = new CountDownLatch(2);
+        final CountDownLatch pleaseCountDown = new CountDownLatch(1);
 
-        Thread t = new Thread(new CheckedRunnable() {
+        Thread t = newStartedThread(new CheckedRunnable() {
             public void realRun() throws InterruptedException {
-                threadAssertTrue(l.getCount() > 0);
-                threadAssertTrue(l.await(SMALL_DELAY_MS, MILLISECONDS));
+                assertEquals(2, l.getCount());
+                pleaseCountDown.countDown();
+                assertTrue(l.await(LONG_DELAY_MS, MILLISECONDS));
+                assertEquals(0, l.getCount());
             }});
 
-        t.start();
-        assertEquals(l.getCount(), 2);
-        Thread.sleep(SHORT_DELAY_MS);
+        await(pleaseCountDown);
+        assertEquals(2, l.getCount());
         l.countDown();
-        assertEquals(l.getCount(), 1);
+        assertEquals(1, l.getCount());
+        assertThreadStaysAlive(t);
         l.countDown();
-        assertEquals(l.getCount(), 0);
-        t.join();
+        assertEquals(0, l.getCount());
+        awaitTermination(t);
     }
 
     /**
      * await throws IE if interrupted before counted down
      */
-    public void testAwait_InterruptedException() throws InterruptedException {
+    public void testAwait_Interruptible() {
         final CountDownLatch l = new CountDownLatch(1);
-        Thread t = new Thread(new CheckedInterruptedRunnable() {
+        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
+        Thread t = newStartedThread(new CheckedRunnable() {
             public void realRun() throws InterruptedException {
-                threadAssertTrue(l.getCount() > 0);
-                l.await();
+                Thread.currentThread().interrupt();
+                try {
+                    l.await();
+                    shouldThrow();
+                } catch (InterruptedException success) {}
+                assertFalse(Thread.interrupted());
+
+                pleaseInterrupt.countDown();
+                try {
+                    l.await();
+                    shouldThrow();
+                } catch (InterruptedException success) {}
+                assertFalse(Thread.interrupted());
+
+                assertEquals(1, l.getCount());
             }});
 
-        t.start();
-        assertEquals(l.getCount(), 1);
+        await(pleaseInterrupt);
+        assertThreadStaysAlive(t);
         t.interrupt();
-        t.join();
+        awaitTermination(t);
     }
 
     /**
      * timed await throws IE if interrupted before counted down
      */
-    public void testTimedAwait_InterruptedException() throws InterruptedException {
+    public void testTimedAwait_Interruptible() {
         final CountDownLatch l = new CountDownLatch(1);
-        Thread t = new Thread(new CheckedInterruptedRunnable() {
+        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
+        Thread t = newStartedThread(new CheckedRunnable() {
             public void realRun() throws InterruptedException {
-                threadAssertTrue(l.getCount() > 0);
-                l.await(MEDIUM_DELAY_MS, MILLISECONDS);
+                Thread.currentThread().interrupt();
+                try {
+                    l.await(LONG_DELAY_MS, MILLISECONDS);
+                    shouldThrow();
+                } catch (InterruptedException success) {}
+                assertFalse(Thread.interrupted());
+
+                pleaseInterrupt.countDown();
+                try {
+                    l.await(LONG_DELAY_MS, MILLISECONDS);
+                    shouldThrow();
+                } catch (InterruptedException success) {}
+                assertFalse(Thread.interrupted());
+
+                assertEquals(1, l.getCount());
             }});
 
-        t.start();
-        Thread.sleep(SHORT_DELAY_MS);
-        assertEquals(l.getCount(), 1);
+        await(pleaseInterrupt);
+        assertThreadStaysAlive(t);
         t.interrupt();
-        t.join();
+        awaitTermination(t);
     }
 
     /**
@@ -137,16 +170,15 @@ public class CountDownLatchTest extends
      */
     public void testAwaitTimeout() throws InterruptedException {
         final CountDownLatch l = new CountDownLatch(1);
-        Thread t = new Thread(new CheckedRunnable() {
+        Thread t = newStartedThread(new CheckedRunnable() {
             public void realRun() throws InterruptedException {
-                threadAssertTrue(l.getCount() > 0);
-                threadAssertFalse(l.await(SHORT_DELAY_MS, MILLISECONDS));
-                threadAssertTrue(l.getCount() > 0);
+                assertEquals(1, l.getCount());
+                assertFalse(l.await(timeoutMillis(), MILLISECONDS));
+                assertEquals(1, l.getCount());
             }});
 
-        t.start();
-        assertEquals(l.getCount(), 1);
-        t.join();
+        awaitTermination(t);
+        assertEquals(1, l.getCount());
     }
 
     /**
@@ -154,14 +186,11 @@ public class CountDownLatchTest extends
      */
     public void testToString() {
         CountDownLatch s = new CountDownLatch(2);
-        String us = s.toString();
-        assertTrue(us.indexOf("Count = 2") >= 0);
+        assertTrue(s.toString().contains("Count = 2"));
         s.countDown();
-        String s1 = s.toString();
-        assertTrue(s1.indexOf("Count = 1") >= 0);
+        assertTrue(s.toString().contains("Count = 1"));
         s.countDown();
-        String s2 = s.toString();
-        assertTrue(s2.indexOf("Count = 0") >= 0);
+        assertTrue(s.toString().contains("Count = 0"));
     }
 
 }