ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/DelayQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/DelayQueueTest.java (file contents):
Revision 1.16 by jsr166, Mon Nov 16 04:57:10 2009 UTC vs.
Revision 1.43 by jsr166, Wed Nov 3 16:46:34 2010 UTC

# Line 8 | Line 8
8  
9   import junit.framework.*;
10   import java.util.*;
11 + import static java.util.concurrent.TimeUnit.MILLISECONDS;
12   import java.util.concurrent.*;
13  
14   public class DelayQueueTest extends JSR166TestCase {
15      public static void main(String[] args) {
16 <        junit.textui.TestRunner.run (suite());
16 >        junit.textui.TestRunner.run(suite());
17      }
18  
19      public static Test suite() {
20 <        return new TestSuite(DelayQueueTest.class);
20 >        return new TestSuite(DelayQueueTest.class);
21      }
22  
23      private static final int NOCAP = Integer.MAX_VALUE;
24  
25      /**
26       * A delayed implementation for testing.
27 <     * Most  tests use Pseudodelays, where delays are all elapsed
27 >     * Most tests use Pseudodelays, where delays are all elapsed
28       * (so, no blocking solely for delays) but are still ordered
29       */
30      static class PDelay implements Delayed {
# Line 31 | Line 32 | public class DelayQueueTest extends JSR1
32          PDelay(int i) { pseudodelay = Integer.MIN_VALUE + i; }
33          public int compareTo(PDelay y) {
34              int i = pseudodelay;
35 <            int j = ((PDelay)y).pseudodelay;
35 >            int j = y.pseudodelay;
36              if (i < j) return -1;
37              if (i > j) return 1;
38              return 0;
39          }
40  
41          public int compareTo(Delayed y) {
42 <            int i = pseudodelay;
42 <            int j = ((PDelay)y).pseudodelay;
43 <            if (i < j) return -1;
44 <            if (i > j) return 1;
45 <            return 0;
42 >            return compareTo((PDelay)y);
43          }
44  
45          public boolean equals(Object other) {
46 <            return ((PDelay)other).pseudodelay == pseudodelay;
46 >            return equals((PDelay)other);
47          }
48          public boolean equals(PDelay other) {
49 <            return ((PDelay)other).pseudodelay == pseudodelay;
49 >            return other.pseudodelay == pseudodelay;
50          }
51  
52  
# Line 76 | Line 73 | public class DelayQueueTest extends JSR1
73          }
74          public int compareTo(NanoDelay y) {
75              long i = trigger;
76 <            long j = ((NanoDelay)y).trigger;
76 >            long j = y.trigger;
77              if (i < j) return -1;
78              if (i > j) return 1;
79              return 0;
80          }
81  
82          public int compareTo(Delayed y) {
83 <            long i = trigger;
87 <            long j = ((NanoDelay)y).trigger;
88 <            if (i < j) return -1;
89 <            if (i > j) return 1;
90 <            return 0;
83 >            return compareTo((NanoDelay)y);
84          }
85  
86          public boolean equals(Object other) {
87 <            return ((NanoDelay)other).trigger == trigger;
87 >            return equals((NanoDelay)other);
88          }
89          public boolean equals(NanoDelay other) {
90 <            return ((NanoDelay)other).trigger == trigger;
90 >            return other.trigger == trigger;
91          }
92  
93          public long getDelay(TimeUnit unit) {
# Line 119 | Line 112 | public class DelayQueueTest extends JSR1
112      private DelayQueue populatedQueue(int n) {
113          DelayQueue q = new DelayQueue();
114          assertTrue(q.isEmpty());
115 <        for (int i = n-1; i >= 0; i-=2)
116 <            assertTrue(q.offer(new PDelay(i)));
117 <        for (int i = (n & 1); i < n; i+=2)
118 <            assertTrue(q.offer(new PDelay(i)));
115 >        for (int i = n-1; i >= 0; i-=2)
116 >            assertTrue(q.offer(new PDelay(i)));
117 >        for (int i = (n & 1); i < n; i+=2)
118 >            assertTrue(q.offer(new PDelay(i)));
119          assertFalse(q.isEmpty());
120          assertEquals(NOCAP, q.remainingCapacity());
121 <        assertEquals(n, q.size());
121 >        assertEquals(n, q.size());
122          return q;
123      }
124  
# Line 143 | Line 136 | public class DelayQueueTest extends JSR1
136          try {
137              DelayQueue q = new DelayQueue(null);
138              shouldThrow();
139 <        }
147 <        catch (NullPointerException success) {}
139 >        } catch (NullPointerException success) {}
140      }
141  
142      /**
# Line 155 | Line 147 | public class DelayQueueTest extends JSR1
147              PDelay[] ints = new PDelay[SIZE];
148              DelayQueue q = new DelayQueue(Arrays.asList(ints));
149              shouldThrow();
150 <        }
159 <        catch (NullPointerException success) {}
150 >        } catch (NullPointerException success) {}
151      }
152  
153      /**
# Line 169 | Line 160 | public class DelayQueueTest extends JSR1
160                  ints[i] = new PDelay(i);
161              DelayQueue q = new DelayQueue(Arrays.asList(ints));
162              shouldThrow();
163 <        }
173 <        catch (NullPointerException success) {}
163 >        } catch (NullPointerException success) {}
164      }
165  
166      /**
167       * Queue contains all elements of collection used to initialize
168       */
169      public void testConstructor6() {
170 <        try {
171 <            PDelay[] ints = new PDelay[SIZE];
172 <            for (int i = 0; i < SIZE; ++i)
173 <                ints[i] = new PDelay(i);
174 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
175 <            for (int i = 0; i < SIZE; ++i)
186 <                assertEquals(ints[i], q.poll());
187 <        }
188 <        finally {}
170 >        PDelay[] ints = new PDelay[SIZE];
171 >        for (int i = 0; i < SIZE; ++i)
172 >            ints[i] = new PDelay(i);
173 >        DelayQueue q = new DelayQueue(Arrays.asList(ints));
174 >        for (int i = 0; i < SIZE; ++i)
175 >            assertEquals(ints[i], q.poll());
176      }
177  
178      /**
# Line 204 | Line 191 | public class DelayQueueTest extends JSR1
191      }
192  
193      /**
194 <     * remainingCapacity does not change when elementa added or removed,
194 >     * remainingCapacity does not change when elements added or removed,
195       * but size does
196       */
197      public void testRemainingCapacity() {
# Line 225 | Line 212 | public class DelayQueueTest extends JSR1
212       * offer(null) throws NPE
213       */
214      public void testOfferNull() {
215 <        try {
215 >        try {
216              DelayQueue q = new DelayQueue();
217              q.offer(null);
218              shouldThrow();
219 <        } catch (NullPointerException success) { }
219 >        } catch (NullPointerException success) {}
220      }
221  
222      /**
223       * add(null) throws NPE
224       */
225      public void testAddNull() {
226 <        try {
226 >        try {
227              DelayQueue q = new DelayQueue();
228              q.add(null);
229              shouldThrow();
230 <        } catch (NullPointerException success) { }
230 >        } catch (NullPointerException success) {}
231      }
232  
233      /**
# Line 271 | Line 258 | public class DelayQueueTest extends JSR1
258              DelayQueue q = new DelayQueue();
259              q.addAll(null);
260              shouldThrow();
261 <        }
275 <        catch (NullPointerException success) {}
261 >        } catch (NullPointerException success) {}
262      }
263  
264  
# Line 284 | Line 270 | public class DelayQueueTest extends JSR1
270              DelayQueue q = populatedQueue(SIZE);
271              q.addAll(q);
272              shouldThrow();
273 <        }
288 <        catch (IllegalArgumentException success) {}
273 >        } catch (IllegalArgumentException success) {}
274      }
275  
276      /**
# Line 297 | Line 282 | public class DelayQueueTest extends JSR1
282              PDelay[] ints = new PDelay[SIZE];
283              q.addAll(Arrays.asList(ints));
284              shouldThrow();
285 <        }
301 <        catch (NullPointerException success) {}
285 >        } catch (NullPointerException success) {}
286      }
287 +
288      /**
289       * addAll of a collection with any null elements throws NPE after
290       * possibly adding some elements
# Line 312 | Line 297 | public class DelayQueueTest extends JSR1
297                  ints[i] = new PDelay(i);
298              q.addAll(Arrays.asList(ints));
299              shouldThrow();
300 <        }
316 <        catch (NullPointerException success) {}
300 >        } catch (NullPointerException success) {}
301      }
302  
303      /**
304       * Queue contains all elements of successful addAll
305       */
306      public void testAddAll5() {
307 <        try {
308 <            PDelay[] empty = new PDelay[0];
309 <            PDelay[] ints = new PDelay[SIZE];
310 <            for (int i = SIZE-1; i >= 0; --i)
311 <                ints[i] = new PDelay(i);
312 <            DelayQueue q = new DelayQueue();
313 <            assertFalse(q.addAll(Arrays.asList(empty)));
314 <            assertTrue(q.addAll(Arrays.asList(ints)));
315 <            for (int i = 0; i < SIZE; ++i)
332 <                assertEquals(ints[i], q.poll());
333 <        }
334 <        finally {}
307 >        PDelay[] empty = new PDelay[0];
308 >        PDelay[] ints = new PDelay[SIZE];
309 >        for (int i = SIZE-1; i >= 0; --i)
310 >            ints[i] = new PDelay(i);
311 >        DelayQueue q = new DelayQueue();
312 >        assertFalse(q.addAll(Arrays.asList(empty)));
313 >        assertTrue(q.addAll(Arrays.asList(ints)));
314 >        for (int i = 0; i < SIZE; ++i)
315 >            assertEquals(ints[i], q.poll());
316      }
317  
318      /**
319       * put(null) throws NPE
320       */
321       public void testPutNull() {
322 <        try {
322 >        try {
323              DelayQueue q = new DelayQueue();
324              q.put(null);
325              shouldThrow();
326 <        }
346 <        catch (NullPointerException success){
347 <        }
326 >        } catch (NullPointerException success) {}
327       }
328  
329      /**
330       * all elements successfully put are contained
331       */
332       public void testPut() {
333 <         try {
334 <             DelayQueue q = new DelayQueue();
335 <             for (int i = 0; i < SIZE; ++i) {
336 <                 PDelay I = new PDelay(i);
337 <                 q.put(I);
359 <                 assertTrue(q.contains(I));
360 <             }
361 <             assertEquals(SIZE, q.size());
333 >         DelayQueue q = new DelayQueue();
334 >         for (int i = 0; i < SIZE; ++i) {
335 >             PDelay I = new PDelay(i);
336 >             q.put(I);
337 >             assertTrue(q.contains(I));
338           }
339 <         finally {
364 <        }
339 >         assertEquals(SIZE, q.size());
340      }
341  
342      /**
343       * put doesn't block waiting for take
344       */
345 <    public void testPutWithTake() {
345 >    public void testPutWithTake() throws InterruptedException {
346          final DelayQueue q = new DelayQueue();
347 <        Thread t = new Thread(new Runnable() {
348 <                public void run() {
349 <                    int added = 0;
350 <                    try {
351 <                        q.put(new PDelay(0));
352 <                        ++added;
353 <                        q.put(new PDelay(0));
354 <                        ++added;
355 <                        q.put(new PDelay(0));
356 <                        ++added;
357 <                        q.put(new PDelay(0));
358 <                        ++added;
359 <                        threadAssertTrue(added == 4);
385 <                    } finally {
386 <                    }
387 <                }
388 <            });
389 <        try {
390 <            t.start();
391 <            Thread.sleep(SHORT_DELAY_MS);
392 <            q.take();
393 <            t.interrupt();
394 <            t.join();
395 <        } catch (Exception e){
396 <            unexpectedException();
397 <        }
347 >        Thread t = new Thread(new CheckedRunnable() {
348 >            public void realRun() {
349 >                q.put(new PDelay(0));
350 >                q.put(new PDelay(0));
351 >                q.put(new PDelay(0));
352 >                q.put(new PDelay(0));
353 >            }});
354 >
355 >        t.start();
356 >        Thread.sleep(SHORT_DELAY_MS);
357 >        q.take();
358 >        t.interrupt();
359 >        t.join();
360      }
361  
362      /**
363       * timed offer does not time out
364       */
365 <    public void testTimedOffer() {
365 >    public void testTimedOffer() throws InterruptedException {
366          final DelayQueue q = new DelayQueue();
367 <        Thread t = new Thread(new Runnable() {
368 <                public void run() {
369 <                    try {
370 <                        q.put(new PDelay(0));
371 <                        q.put(new PDelay(0));
372 <                        threadAssertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
373 <                        threadAssertTrue(q.offer(new PDelay(0), LONG_DELAY_MS, TimeUnit.MILLISECONDS));
412 <                    } finally { }
413 <                }
414 <            });
367 >        Thread t = new Thread(new CheckedRunnable() {
368 >            public void realRun() throws InterruptedException {
369 >                q.put(new PDelay(0));
370 >                q.put(new PDelay(0));
371 >                assertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, MILLISECONDS));
372 >                assertTrue(q.offer(new PDelay(0), LONG_DELAY_MS, MILLISECONDS));
373 >            }});
374  
375 <        try {
376 <            t.start();
377 <            Thread.sleep(SMALL_DELAY_MS);
378 <            t.interrupt();
420 <            t.join();
421 <        } catch (Exception e){
422 <            unexpectedException();
423 <        }
375 >        t.start();
376 >        Thread.sleep(SMALL_DELAY_MS);
377 >        t.interrupt();
378 >        t.join();
379      }
380  
381      /**
382       * take retrieves elements in priority order
383       */
384 <    public void testTake() {
385 <        try {
386 <            DelayQueue q = populatedQueue(SIZE);
387 <            for (int i = 0; i < SIZE; ++i) {
388 <                assertEquals(new PDelay(i), ((PDelay)q.take()));
434 <            }
435 <        } catch (InterruptedException e){
436 <            unexpectedException();
437 <        }
384 >    public void testTake() throws InterruptedException {
385 >        DelayQueue q = populatedQueue(SIZE);
386 >        for (int i = 0; i < SIZE; ++i) {
387 >            assertEquals(new PDelay(i), ((PDelay)q.take()));
388 >        }
389      }
390  
391      /**
392       * take blocks interruptibly when empty
393       */
394 <    public void testTakeFromEmpty() {
395 <        final DelayQueue q = new DelayQueue();
396 <        Thread t = new Thread(new Runnable() {
397 <                public void run() {
398 <                    try {
399 <                        q.take();
400 <                        threadShouldThrow();
401 <                    } catch (InterruptedException success){ }
402 <                }
403 <            });
404 <        try {
405 <            t.start();
406 <            Thread.sleep(SHORT_DELAY_MS);
407 <            t.interrupt();
408 <            t.join();
409 <        } catch (Exception e){
410 <            unexpectedException();
411 <        }
394 >    public void testTakeFromEmptyBlocksInterruptibly()
395 >            throws InterruptedException {
396 >        final BlockingQueue q = new DelayQueue();
397 >        final CountDownLatch threadStarted = new CountDownLatch(1);
398 >        Thread t = newStartedThread(new CheckedRunnable() {
399 >            public void realRun() {
400 >                long t0 = System.nanoTime();
401 >                threadStarted.countDown();
402 >                try {
403 >                    q.take();
404 >                    shouldThrow();
405 >                } catch (InterruptedException expected) {}
406 >                assertTrue(millisElapsedSince(t0) >= SHORT_DELAY_MS);
407 >            }});
408 >        threadStarted.await();
409 >        Thread.sleep(SHORT_DELAY_MS);
410 >        assertTrue(t.isAlive());
411 >        t.interrupt();
412 >        awaitTermination(t, MEDIUM_DELAY_MS);
413 >        assertFalse(t.isAlive());
414      }
415  
416      /**
417       * Take removes existing elements until empty, then blocks interruptibly
418       */
419 <    public void testBlockingTake() {
420 <        Thread t = new Thread(new Runnable() {
421 <                public void run() {
422 <                    try {
423 <                        DelayQueue q = populatedQueue(SIZE);
424 <                        for (int i = 0; i < SIZE; ++i) {
425 <                            threadAssertEquals(new PDelay(i), ((PDelay)q.take()));
426 <                        }
427 <                        q.take();
428 <                        threadShouldThrow();
429 <                    } catch (InterruptedException success){
430 <                    }
431 <                }});
419 >    public void testBlockingTake() throws InterruptedException {
420 >        final DelayQueue q = populatedQueue(SIZE);
421 >        Thread t = new Thread(new CheckedRunnable() {
422 >            public void realRun() throws InterruptedException {
423 >                for (int i = 0; i < SIZE; ++i) {
424 >                    assertEquals(new PDelay(i), ((PDelay)q.take()));
425 >                }
426 >                try {
427 >                    q.take();
428 >                    shouldThrow();
429 >                } catch (InterruptedException success) {}
430 >            }});
431 >
432          t.start();
433 <        try {
434 <           Thread.sleep(SHORT_DELAY_MS);
435 <           t.interrupt();
483 <           t.join();
484 <        }
485 <        catch (InterruptedException ie) {
486 <            unexpectedException();
487 <        }
433 >        Thread.sleep(SHORT_DELAY_MS);
434 >        t.interrupt();
435 >        t.join();
436      }
437  
438  
# Line 496 | Line 444 | public class DelayQueueTest extends JSR1
444          for (int i = 0; i < SIZE; ++i) {
445              assertEquals(new PDelay(i), ((PDelay)q.poll()));
446          }
447 <        assertNull(q.poll());
447 >        assertNull(q.poll());
448      }
449  
450      /**
451 <     * timed pool with zero timeout succeeds when non-empty, else times out
451 >     * timed poll with zero timeout succeeds when non-empty, else times out
452       */
453 <    public void testTimedPoll0() {
454 <        try {
455 <            DelayQueue q = populatedQueue(SIZE);
456 <            for (int i = 0; i < SIZE; ++i) {
457 <                assertEquals(new PDelay(i), ((PDelay)q.poll(0, TimeUnit.MILLISECONDS)));
458 <            }
511 <            assertNull(q.poll(0, TimeUnit.MILLISECONDS));
512 <        } catch (InterruptedException e){
513 <            unexpectedException();
514 <        }
453 >    public void testTimedPoll0() throws InterruptedException {
454 >        DelayQueue q = populatedQueue(SIZE);
455 >        for (int i = 0; i < SIZE; ++i) {
456 >            assertEquals(new PDelay(i), ((PDelay)q.poll(0, MILLISECONDS)));
457 >        }
458 >        assertNull(q.poll(0, MILLISECONDS));
459      }
460  
461      /**
462 <     * timed pool with nonzero timeout succeeds when non-empty, else times out
462 >     * timed poll with nonzero timeout succeeds when non-empty, else times out
463       */
464 <    public void testTimedPoll() {
465 <        try {
466 <            DelayQueue q = populatedQueue(SIZE);
467 <            for (int i = 0; i < SIZE; ++i) {
468 <                assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)));
469 <            }
526 <            assertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
527 <        } catch (InterruptedException e){
528 <            unexpectedException();
529 <        }
464 >    public void testTimedPoll() throws InterruptedException {
465 >        DelayQueue q = populatedQueue(SIZE);
466 >        for (int i = 0; i < SIZE; ++i) {
467 >            assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, MILLISECONDS)));
468 >        }
469 >        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
470      }
471  
472      /**
473       * Interrupted timed poll throws InterruptedException instead of
474       * returning timeout status
475       */
476 <    public void testInterruptedTimedPoll() {
477 <        Thread t = new Thread(new Runnable() {
478 <                public void run() {
479 <                    try {
480 <                        DelayQueue q = populatedQueue(SIZE);
481 <                        for (int i = 0; i < SIZE; ++i) {
482 <                            threadAssertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)));
483 <                        }
484 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
485 <                    } catch (InterruptedException success){
486 <                    }
487 <                }});
476 >    public void testInterruptedTimedPoll() throws InterruptedException {
477 >        Thread t = new Thread(new CheckedRunnable() {
478 >            public void realRun() throws InterruptedException {
479 >                DelayQueue q = populatedQueue(SIZE);
480 >                for (int i = 0; i < SIZE; ++i) {
481 >                    assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, MILLISECONDS)));
482 >                }
483 >                try {
484 >                    q.poll(SMALL_DELAY_MS, MILLISECONDS);
485 >                    shouldThrow();
486 >                } catch (InterruptedException success) {}
487 >            }});
488 >
489          t.start();
490 <        try {
491 <           Thread.sleep(SHORT_DELAY_MS);
492 <           t.interrupt();
552 <           t.join();
553 <        }
554 <        catch (InterruptedException ie) {
555 <            unexpectedException();
556 <        }
490 >        Thread.sleep(SHORT_DELAY_MS);
491 >        t.interrupt();
492 >        t.join();
493      }
494  
495      /**
496 <     *  timed poll before a delayed offer fails; after offer succeeds;
497 <     *  on interruption throws
496 >     * timed poll before a delayed offer fails; after offer succeeds;
497 >     * on interruption throws
498       */
499 <    public void testTimedPollWithOffer() {
499 >    public void testTimedPollWithOffer() throws InterruptedException {
500          final DelayQueue q = new DelayQueue();
501 <        Thread t = new Thread(new Runnable() {
502 <                public void run() {
503 <                    try {
504 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
505 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
506 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
507 <                        threadFail("Should block");
508 <                    } catch (InterruptedException success) { }
509 <                }
510 <            });
511 <        try {
512 <            t.start();
513 <            Thread.sleep(SMALL_DELAY_MS);
514 <            assertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
515 <            t.interrupt();
516 <            t.join();
517 <        } catch (Exception e){
518 <            unexpectedException();
519 <        }
501 >        final PDelay pdelay = new PDelay(0);
502 >        final CheckedBarrier barrier = new CheckedBarrier(2);
503 >        Thread t = new Thread(new CheckedRunnable() {
504 >            public void realRun() throws InterruptedException {
505 >                assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
506 >
507 >                barrier.await();
508 >                assertSame(pdelay, q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
509 >
510 >                Thread.currentThread().interrupt();
511 >                try {
512 >                    q.poll(SHORT_DELAY_MS, MILLISECONDS);
513 >                    shouldThrow();
514 >                } catch (InterruptedException success) {}
515 >
516 >                barrier.await();
517 >                try {
518 >                    q.poll(MEDIUM_DELAY_MS, MILLISECONDS);
519 >                    shouldThrow();
520 >                } catch (InterruptedException success) {}
521 >            }});
522 >
523 >        t.start();
524 >        barrier.await();
525 >        assertTrue(q.offer(pdelay, SHORT_DELAY_MS, MILLISECONDS));
526 >        barrier.await();
527 >        sleep(SHORT_DELAY_MS);
528 >        t.interrupt();
529 >        t.join();
530      }
531  
532  
# Line 591 | Line 537 | public class DelayQueueTest extends JSR1
537          DelayQueue q = populatedQueue(SIZE);
538          for (int i = 0; i < SIZE; ++i) {
539              assertEquals(new PDelay(i), ((PDelay)q.peek()));
540 <            q.poll();
540 >            assertEquals(new PDelay(i), ((PDelay)q.poll()));
541              if (q.isEmpty())
542                  assertNull(q.peek());
543              else
544 <                assertTrue(i != ((PDelay)q.peek()).intValue());
544 >                assertFalse(new PDelay(i).equals(q.peek()));
545          }
546 <        assertNull(q.peek());
546 >        assertNull(q.peek());
547      }
548  
549      /**
# Line 612 | Line 558 | public class DelayQueueTest extends JSR1
558          try {
559              q.element();
560              shouldThrow();
561 <        }
616 <        catch (NoSuchElementException success) {}
561 >        } catch (NoSuchElementException success) {}
562      }
563  
564      /**
# Line 627 | Line 572 | public class DelayQueueTest extends JSR1
572          try {
573              q.remove();
574              shouldThrow();
575 <        } catch (NoSuchElementException success){
631 <        }
575 >        } catch (NoSuchElementException success) {}
576      }
577  
578      /**
# Line 727 | Line 671 | public class DelayQueueTest extends JSR1
671      /**
672       * toArray contains all elements
673       */
674 <    public void testToArray() {
674 >    public void testToArray() throws InterruptedException {
675          DelayQueue q = populatedQueue(SIZE);
676 <        Object[] o = q.toArray();
676 >        Object[] o = q.toArray();
677          Arrays.sort(o);
678 <        try {
679 <        for (int i = 0; i < o.length; i++)
736 <            assertEquals(o[i], q.take());
737 <        } catch (InterruptedException e){
738 <            unexpectedException();
739 <        }
678 >        for (int i = 0; i < o.length; i++)
679 >            assertEquals(o[i], q.take());
680      }
681  
682      /**
683       * toArray(a) contains all elements
684       */
685 <    public void testToArray2() {
685 >    public void testToArray2() throws InterruptedException {
686          DelayQueue q = populatedQueue(SIZE);
687 <        PDelay[] ints = new PDelay[SIZE];
688 <        ints = (PDelay[])q.toArray(ints);
687 >        PDelay[] ints = new PDelay[SIZE];
688 >        ints = (PDelay[])q.toArray(ints);
689          Arrays.sort(ints);
690 <        try {
691 <            for (int i = 0; i < ints.length; i++)
752 <                assertEquals(ints[i], q.take());
753 <        } catch (InterruptedException e){
754 <            unexpectedException();
755 <        }
690 >        for (int i = 0; i < ints.length; i++)
691 >            assertEquals(ints[i], q.take());
692      }
693  
694  
695      /**
696 <     * toArray(null) throws NPE
696 >     * toArray(null) throws NullPointerException
697       */
698 <    public void testToArray_BadArg() {
699 <        try {
700 <            DelayQueue q = populatedQueue(SIZE);
701 <            Object o[] = q.toArray(null);
702 <            shouldThrow();
703 <        } catch (NullPointerException success){}
698 >    public void testToArray_NullArg() {
699 >        DelayQueue q = populatedQueue(SIZE);
700 >        try {
701 >            q.toArray(null);
702 >            shouldThrow();
703 >        } catch (NullPointerException success) {}
704      }
705  
706      /**
707 <     * toArray with incompatible array type throws CCE
707 >     * toArray(incompatible array type) throws ArrayStoreException
708       */
709      public void testToArray1_BadArg() {
710 <        try {
711 <            DelayQueue q = populatedQueue(SIZE);
712 <            Object o[] = q.toArray(new String[10] );
713 <            shouldThrow();
714 <        } catch (ArrayStoreException  success){}
710 >        DelayQueue q = populatedQueue(SIZE);
711 >        try {
712 >            q.toArray(new String[10]);
713 >            shouldThrow();
714 >        } catch (ArrayStoreException success) {}
715      }
716  
717      /**
# Line 784 | Line 720 | public class DelayQueueTest extends JSR1
720      public void testIterator() {
721          DelayQueue q = populatedQueue(SIZE);
722          int i = 0;
723 <        Iterator it = q.iterator();
723 >        Iterator it = q.iterator();
724          while (it.hasNext()) {
725              assertTrue(q.contains(it.next()));
726              ++i;
# Line 795 | Line 731 | public class DelayQueueTest extends JSR1
731      /**
732       * iterator.remove removes current element
733       */
734 <    public void testIteratorRemove () {
734 >    public void testIteratorRemove() {
735          final DelayQueue q = new DelayQueue();
736          q.add(new PDelay(2));
737          q.add(new PDelay(1));
# Line 827 | Line 763 | public class DelayQueueTest extends JSR1
763      public void testPollInExecutor() {
764          final DelayQueue q = new DelayQueue();
765          ExecutorService executor = Executors.newFixedThreadPool(2);
766 <        executor.execute(new Runnable() {
767 <            public void run() {
768 <                threadAssertNull(q.poll());
769 <                try {
770 <                    threadAssertTrue(null != q.poll(MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS));
771 <                    threadAssertTrue(q.isEmpty());
772 <                }
773 <                catch (InterruptedException e) {
774 <                    threadUnexpectedException();
775 <                }
776 <            }
777 <        });
766 >        executor.execute(new CheckedRunnable() {
767 >            public void realRun() throws InterruptedException {
768 >                assertNull(q.poll());
769 >                assertTrue(null != q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
770 >                assertTrue(q.isEmpty());
771 >            }});
772 >
773 >        executor.execute(new CheckedRunnable() {
774 >            public void realRun() throws InterruptedException {
775 >                Thread.sleep(SHORT_DELAY_MS);
776 >                q.put(new PDelay(1));
777 >            }});
778  
843        executor.execute(new Runnable() {
844            public void run() {
845                try {
846                    Thread.sleep(SHORT_DELAY_MS);
847                    q.put(new PDelay(1));
848                }
849                catch (InterruptedException e) {
850                    threadUnexpectedException();
851                }
852            }
853        });
779          joinPool(executor);
855
780      }
781  
782  
783      /**
784       * Delayed actions do not occur until their delay elapses
785       */
786 <    public void testDelay() {
787 <        DelayQueue q = new DelayQueue();
788 <        NanoDelay[] elements = new NanoDelay[SIZE];
789 <        for (int i = 0; i < SIZE; ++i) {
866 <            elements[i] = new NanoDelay(1000000000L + 1000000L * (SIZE - i));
867 <        }
868 <        for (int i = 0; i < SIZE; ++i) {
869 <            q.add(elements[i]);
870 <        }
786 >    public void testDelay() throws InterruptedException {
787 >        DelayQueue<NanoDelay> q = new DelayQueue<NanoDelay>();
788 >        for (int i = 0; i < SIZE; ++i)
789 >            q.add(new NanoDelay(1000000L * (SIZE - i)));
790  
791 <        try {
792 <            long last = 0;
793 <            for (int i = 0; i < SIZE; ++i) {
794 <                NanoDelay e = (NanoDelay)(q.take());
795 <                long tt = e.getTriggerTime();
796 <                assertTrue(tt <= System.nanoTime());
797 <                if (i != 0)
798 <                    assertTrue(tt >= last);
880 <                last = tt;
881 <            }
882 <        }
883 <        catch (InterruptedException ie) {
884 <            unexpectedException();
791 >        long last = 0;
792 >        for (int i = 0; i < SIZE; ++i) {
793 >            NanoDelay e = q.take();
794 >            long tt = e.getTriggerTime();
795 >            assertTrue(System.nanoTime() - tt >= 0);
796 >            if (i != 0)
797 >                assertTrue(tt >= last);
798 >            last = tt;
799          }
800 +        assertTrue(q.isEmpty());
801      }
802  
803      /**
# Line 891 | Line 806 | public class DelayQueueTest extends JSR1
806      public void testPeekDelayed() {
807          DelayQueue q = new DelayQueue();
808          q.add(new NanoDelay(Long.MAX_VALUE));
809 <        assert(q.peek() != null);
809 >        assertNotNull(q.peek());
810      }
811  
812  
# Line 907 | Line 822 | public class DelayQueueTest extends JSR1
822      /**
823       * timed poll of a non-empty queue returns null if no expired elements.
824       */
825 <    public void testTimedPollDelayed() {
825 >    public void testTimedPollDelayed() throws InterruptedException {
826          DelayQueue q = new DelayQueue();
827          q.add(new NanoDelay(LONG_DELAY_MS * 1000000L));
828 <        try {
914 <            assertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
915 <        } catch (Exception ex) {
916 <            unexpectedException();
917 <        }
828 >        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
829      }
830  
831      /**
# Line 925 | Line 836 | public class DelayQueueTest extends JSR1
836          try {
837              q.drainTo(null);
838              shouldThrow();
839 <        } catch (NullPointerException success) {
929 <        }
839 >        } catch (NullPointerException success) {}
840      }
841  
842      /**
# Line 937 | Line 847 | public class DelayQueueTest extends JSR1
847          try {
848              q.drainTo(q);
849              shouldThrow();
850 <        } catch (IllegalArgumentException success) {
941 <        }
850 >        } catch (IllegalArgumentException success) {}
851      }
852  
853      /**
# Line 972 | Line 881 | public class DelayQueueTest extends JSR1
881      /**
882       * drainTo empties queue
883       */
884 <    public void testDrainToWithActivePut() {
884 >    public void testDrainToWithActivePut() throws InterruptedException {
885          final DelayQueue q = populatedQueue(SIZE);
886 <        Thread t = new Thread(new Runnable() {
887 <                public void run() {
888 <                    q.put(new PDelay(SIZE+1));
889 <                }
890 <            });
891 <        try {
892 <            t.start();
893 <            ArrayList l = new ArrayList();
894 <            q.drainTo(l);
895 <            assertTrue(l.size() >= SIZE);
896 <            t.join();
988 <            assertTrue(q.size() + l.size() >= SIZE);
989 <        } catch (Exception e){
990 <            unexpectedException();
991 <        }
886 >        Thread t = new Thread(new CheckedRunnable() {
887 >            public void realRun() {
888 >                q.put(new PDelay(SIZE+1));
889 >            }});
890 >
891 >        t.start();
892 >        ArrayList l = new ArrayList();
893 >        q.drainTo(l);
894 >        assertTrue(l.size() >= SIZE);
895 >        t.join();
896 >        assertTrue(q.size() + l.size() >= SIZE);
897      }
898  
899      /**
# Line 999 | Line 904 | public class DelayQueueTest extends JSR1
904          try {
905              q.drainTo(null, 0);
906              shouldThrow();
907 <        } catch (NullPointerException success) {
1003 <        }
907 >        } catch (NullPointerException success) {}
908      }
909  
910      /**
# Line 1011 | Line 915 | public class DelayQueueTest extends JSR1
915          try {
916              q.drainTo(q, 0);
917              shouldThrow();
918 <        } catch (IllegalArgumentException success) {
1015 <        }
918 >        } catch (IllegalArgumentException success) {}
919      }
920  
921      /**
922 <     * drainTo(c, n) empties first max {n, size} elements of queue into c
922 >     * drainTo(c, n) empties first min(n, size) elements of queue into c
923       */
924      public void testDrainToN() {
925          for (int i = 0; i < SIZE + 2; ++i) {
926              DelayQueue q = populatedQueue(SIZE);
927              ArrayList l = new ArrayList();
928              q.drainTo(l, i);
929 <            int k = (i < SIZE)? i : SIZE;
929 >            int k = (i < SIZE) ? i : SIZE;
930              assertEquals(q.size(), SIZE-k);
931              assertEquals(l.size(), k);
932          }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines