ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/DelayQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/DelayQueueTest.java (file contents):
Revision 1.17 by jsr166, Mon Nov 16 05:30:07 2009 UTC vs.
Revision 1.81 by jsr166, Wed Jan 4 06:09:58 2017 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include Andrew Wright, Jeffrey Hayes,
6   * Pat Fisher, Mike Judd.
7   */
8  
9 < import junit.framework.*;
10 < import java.util.*;
11 < import java.util.concurrent.*;
9 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 >
11 > import java.util.ArrayList;
12 > import java.util.Arrays;
13 > import java.util.Collection;
14 > import java.util.Iterator;
15 > import java.util.NoSuchElementException;
16 > import java.util.concurrent.BlockingQueue;
17 > import java.util.concurrent.CountDownLatch;
18 > import java.util.concurrent.Delayed;
19 > import java.util.concurrent.DelayQueue;
20 > import java.util.concurrent.Executors;
21 > import java.util.concurrent.ExecutorService;
22 > import java.util.concurrent.TimeUnit;
23 >
24 > import junit.framework.Test;
25  
26   public class DelayQueueTest extends JSR166TestCase {
27 +
28 +    public static class Generic extends BlockingQueueTest {
29 +        protected BlockingQueue emptyCollection() {
30 +            return new DelayQueue();
31 +        }
32 +        protected PDelay makeElement(int i) {
33 +            return new PDelay(i);
34 +        }
35 +    }
36 +
37      public static void main(String[] args) {
38 <        junit.textui.TestRunner.run (suite());
38 >        main(suite(), args);
39      }
40  
41      public static Test suite() {
42 <        return new TestSuite(DelayQueueTest.class);
42 >        class Implementation implements CollectionImplementation {
43 >            public Class<?> klazz() { return DelayQueue.class; }
44 >            public Collection emptyCollection() { return new DelayQueue(); }
45 >            public Object makeElement(int i) { return new PDelay(i); }
46 >            public boolean isConcurrent() { return true; }
47 >            public boolean permitsNulls() { return false; }
48 >        }
49 >        return newTestSuite(DelayQueueTest.class,
50 >                            new Generic().testSuite(),
51 >                            CollectionTest.testSuite(new Implementation()));
52      }
53  
22    private static final int NOCAP = Integer.MAX_VALUE;
23
54      /**
55 <     * A delayed implementation for testing.
56 <     * Most  tests use Pseudodelays, where delays are all elapsed
55 >     * A fake Delayed implementation for testing.
56 >     * Most tests use PDelays, where delays are all elapsed
57       * (so, no blocking solely for delays) but are still ordered
58       */
59      static class PDelay implements Delayed {
60 <        int pseudodelay;
61 <        PDelay(int i) { pseudodelay = Integer.MIN_VALUE + i; }
32 <        public int compareTo(PDelay y) {
33 <            int i = pseudodelay;
34 <            int j = ((PDelay)y).pseudodelay;
35 <            if (i < j) return -1;
36 <            if (i > j) return 1;
37 <            return 0;
38 <        }
39 <
60 >        final int pseudodelay;
61 >        PDelay(int pseudodelay) { this.pseudodelay = pseudodelay; }
62          public int compareTo(Delayed y) {
63 <            int i = pseudodelay;
42 <            int j = ((PDelay)y).pseudodelay;
43 <            if (i < j) return -1;
44 <            if (i > j) return 1;
45 <            return 0;
63 >            return Integer.compare(this.pseudodelay, ((PDelay)y).pseudodelay);
64          }
47
65          public boolean equals(Object other) {
66 <            return ((PDelay)other).pseudodelay == pseudodelay;
66 >            return (other instanceof PDelay) &&
67 >                this.pseudodelay == ((PDelay)other).pseudodelay;
68          }
69 <        public boolean equals(PDelay other) {
70 <            return ((PDelay)other).pseudodelay == pseudodelay;
53 <        }
54 <
55 <
69 >        // suppress [overrides] javac warning
70 >        public int hashCode() { return pseudodelay; }
71          public long getDelay(TimeUnit ignore) {
72 <            return pseudodelay;
72 >            return Integer.MIN_VALUE + pseudodelay;
73          }
59        public int intValue() {
60            return pseudodelay;
61        }
62
74          public String toString() {
75              return String.valueOf(pseudodelay);
76          }
77      }
78  
68
79      /**
80       * Delayed implementation that actually delays
81       */
82      static class NanoDelay implements Delayed {
83 <        long trigger;
83 >        final long trigger;
84          NanoDelay(long i) {
85              trigger = System.nanoTime() + i;
86          }
77        public int compareTo(NanoDelay y) {
78            long i = trigger;
79            long j = ((NanoDelay)y).trigger;
80            if (i < j) return -1;
81            if (i > j) return 1;
82            return 0;
83        }
87  
88          public int compareTo(Delayed y) {
89 <            long i = trigger;
87 <            long j = ((NanoDelay)y).trigger;
88 <            if (i < j) return -1;
89 <            if (i > j) return 1;
90 <            return 0;
89 >            return Long.compare(trigger, ((NanoDelay)y).trigger);
90          }
91  
92          public boolean equals(Object other) {
93 <            return ((NanoDelay)other).trigger == trigger;
94 <        }
96 <        public boolean equals(NanoDelay other) {
97 <            return ((NanoDelay)other).trigger == trigger;
93 >            return (other instanceof NanoDelay) &&
94 >                this.trigger == ((NanoDelay)other).trigger;
95          }
96  
97 +        // suppress [overrides] javac warning
98 +        public int hashCode() { return (int) trigger; }
99 +
100          public long getDelay(TimeUnit unit) {
101              long n = trigger - System.nanoTime();
102              return unit.convert(n, TimeUnit.NANOSECONDS);
# Line 111 | Line 111 | public class DelayQueueTest extends JSR1
111          }
112      }
113  
114
114      /**
115 <     * Create a queue of given size containing consecutive
116 <     * PDelays 0 ... n.
115 >     * Returns a new queue of given size containing consecutive
116 >     * PDelays 0 ... n - 1.
117       */
118 <    private DelayQueue populatedQueue(int n) {
119 <        DelayQueue q = new DelayQueue();
118 >    private DelayQueue<PDelay> populatedQueue(int n) {
119 >        DelayQueue<PDelay> q = new DelayQueue<>();
120          assertTrue(q.isEmpty());
121 <        for (int i = n-1; i >= 0; i-=2)
122 <            assertTrue(q.offer(new PDelay(i)));
123 <        for (int i = (n & 1); i < n; i+=2)
124 <            assertTrue(q.offer(new PDelay(i)));
121 >        for (int i = n - 1; i >= 0; i -= 2)
122 >            assertTrue(q.offer(new PDelay(i)));
123 >        for (int i = (n & 1); i < n; i += 2)
124 >            assertTrue(q.offer(new PDelay(i)));
125          assertFalse(q.isEmpty());
126 <        assertEquals(NOCAP, q.remainingCapacity());
127 <        assertEquals(n, q.size());
126 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
127 >        assertEquals(n, q.size());
128 >        assertEquals(new PDelay(0), q.peek());
129          return q;
130      }
131  
# Line 133 | Line 133 | public class DelayQueueTest extends JSR1
133       * A new queue has unbounded capacity
134       */
135      public void testConstructor1() {
136 <        assertEquals(NOCAP, new DelayQueue().remainingCapacity());
136 >        assertEquals(Integer.MAX_VALUE, new DelayQueue().remainingCapacity());
137      }
138  
139      /**
# Line 141 | Line 141 | public class DelayQueueTest extends JSR1
141       */
142      public void testConstructor3() {
143          try {
144 <            DelayQueue q = new DelayQueue(null);
144 >            new DelayQueue(null);
145              shouldThrow();
146 <        }
147 <        catch (NullPointerException success) {}
146 >        } catch (NullPointerException success) {}
147      }
148  
149      /**
# Line 152 | Line 151 | public class DelayQueueTest extends JSR1
151       */
152      public void testConstructor4() {
153          try {
154 <            PDelay[] ints = new PDelay[SIZE];
156 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
154 >            new DelayQueue(Arrays.asList(new PDelay[SIZE]));
155              shouldThrow();
156 <        }
159 <        catch (NullPointerException success) {}
156 >        } catch (NullPointerException success) {}
157      }
158  
159      /**
160       * Initializing from Collection with some null elements throws NPE
161       */
162      public void testConstructor5() {
163 +        PDelay[] a = new PDelay[SIZE];
164 +        for (int i = 0; i < SIZE - 1; ++i)
165 +            a[i] = new PDelay(i);
166          try {
167 <            PDelay[] ints = new PDelay[SIZE];
168 <            for (int i = 0; i < SIZE-1; ++i)
169 <                ints[i] = new PDelay(i);
170 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
167 >            new DelayQueue(Arrays.asList(a));
168              shouldThrow();
169 <        }
173 <        catch (NullPointerException success) {}
169 >        } catch (NullPointerException success) {}
170      }
171  
172      /**
173       * Queue contains all elements of collection used to initialize
174       */
175      public void testConstructor6() {
176 <        try {
177 <            PDelay[] ints = new PDelay[SIZE];
178 <            for (int i = 0; i < SIZE; ++i)
179 <                ints[i] = new PDelay(i);
180 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
181 <            for (int i = 0; i < SIZE; ++i)
186 <                assertEquals(ints[i], q.poll());
187 <        }
188 <        finally {}
176 >        PDelay[] ints = new PDelay[SIZE];
177 >        for (int i = 0; i < SIZE; ++i)
178 >            ints[i] = new PDelay(i);
179 >        DelayQueue q = new DelayQueue(Arrays.asList(ints));
180 >        for (int i = 0; i < SIZE; ++i)
181 >            assertEquals(ints[i], q.poll());
182      }
183  
184      /**
# Line 194 | Line 187 | public class DelayQueueTest extends JSR1
187      public void testEmpty() {
188          DelayQueue q = new DelayQueue();
189          assertTrue(q.isEmpty());
190 <        assertEquals(NOCAP, q.remainingCapacity());
190 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
191          q.add(new PDelay(1));
192          assertFalse(q.isEmpty());
193          q.add(new PDelay(2));
# Line 204 | Line 197 | public class DelayQueueTest extends JSR1
197      }
198  
199      /**
200 <     * remainingCapacity does not change when elementa added or removed,
208 <     * but size does
200 >     * remainingCapacity() always returns Integer.MAX_VALUE
201       */
202      public void testRemainingCapacity() {
203 <        DelayQueue q = populatedQueue(SIZE);
203 >        BlockingQueue q = populatedQueue(SIZE);
204          for (int i = 0; i < SIZE; ++i) {
205 <            assertEquals(NOCAP, q.remainingCapacity());
206 <            assertEquals(SIZE-i, q.size());
207 <            q.remove();
205 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
206 >            assertEquals(SIZE - i, q.size());
207 >            assertTrue(q.remove() instanceof PDelay);
208          }
209          for (int i = 0; i < SIZE; ++i) {
210 <            assertEquals(NOCAP, q.remainingCapacity());
210 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
211              assertEquals(i, q.size());
212 <            q.add(new PDelay(i));
212 >            assertTrue(q.add(new PDelay(i)));
213          }
214      }
215  
216      /**
225     * offer(null) throws NPE
226     */
227    public void testOfferNull() {
228        try {
229            DelayQueue q = new DelayQueue();
230            q.offer(null);
231            shouldThrow();
232        } catch (NullPointerException success) { }
233    }
234
235    /**
236     * add(null) throws NPE
237     */
238    public void testAddNull() {
239        try {
240            DelayQueue q = new DelayQueue();
241            q.add(null);
242            shouldThrow();
243        } catch (NullPointerException success) { }
244    }
245
246    /**
217       * offer non-null succeeds
218       */
219      public void testOffer() {
# Line 264 | Line 234 | public class DelayQueueTest extends JSR1
234      }
235  
236      /**
267     * addAll(null) throws NPE
268     */
269    public void testAddAll1() {
270        try {
271            DelayQueue q = new DelayQueue();
272            q.addAll(null);
273            shouldThrow();
274        }
275        catch (NullPointerException success) {}
276    }
277
278
279    /**
237       * addAll(this) throws IAE
238       */
239      public void testAddAllSelf() {
240 +        DelayQueue q = populatedQueue(SIZE);
241          try {
284            DelayQueue q = populatedQueue(SIZE);
242              q.addAll(q);
243              shouldThrow();
244 <        }
288 <        catch (IllegalArgumentException success) {}
244 >        } catch (IllegalArgumentException success) {}
245      }
246  
247      /**
292     * addAll of a collection with null elements throws NPE
293     */
294    public void testAddAll2() {
295        try {
296            DelayQueue q = new DelayQueue();
297            PDelay[] ints = new PDelay[SIZE];
298            q.addAll(Arrays.asList(ints));
299            shouldThrow();
300        }
301        catch (NullPointerException success) {}
302    }
303    /**
248       * addAll of a collection with any null elements throws NPE after
249       * possibly adding some elements
250       */
251      public void testAddAll3() {
252 +        DelayQueue q = new DelayQueue();
253 +        PDelay[] a = new PDelay[SIZE];
254 +        for (int i = 0; i < SIZE - 1; ++i)
255 +            a[i] = new PDelay(i);
256          try {
257 <            DelayQueue q = new DelayQueue();
310 <            PDelay[] ints = new PDelay[SIZE];
311 <            for (int i = 0; i < SIZE-1; ++i)
312 <                ints[i] = new PDelay(i);
313 <            q.addAll(Arrays.asList(ints));
257 >            q.addAll(Arrays.asList(a));
258              shouldThrow();
259 <        }
316 <        catch (NullPointerException success) {}
259 >        } catch (NullPointerException success) {}
260      }
261  
262      /**
263       * Queue contains all elements of successful addAll
264       */
265      public void testAddAll5() {
266 <        try {
267 <            PDelay[] empty = new PDelay[0];
268 <            PDelay[] ints = new PDelay[SIZE];
269 <            for (int i = SIZE-1; i >= 0; --i)
270 <                ints[i] = new PDelay(i);
271 <            DelayQueue q = new DelayQueue();
272 <            assertFalse(q.addAll(Arrays.asList(empty)));
273 <            assertTrue(q.addAll(Arrays.asList(ints)));
274 <            for (int i = 0; i < SIZE; ++i)
332 <                assertEquals(ints[i], q.poll());
333 <        }
334 <        finally {}
266 >        PDelay[] empty = new PDelay[0];
267 >        PDelay[] ints = new PDelay[SIZE];
268 >        for (int i = SIZE - 1; i >= 0; --i)
269 >            ints[i] = new PDelay(i);
270 >        DelayQueue q = new DelayQueue();
271 >        assertFalse(q.addAll(Arrays.asList(empty)));
272 >        assertTrue(q.addAll(Arrays.asList(ints)));
273 >        for (int i = 0; i < SIZE; ++i)
274 >            assertEquals(ints[i], q.poll());
275      }
276  
277      /**
338     * put(null) throws NPE
339     */
340     public void testPutNull() {
341        try {
342            DelayQueue q = new DelayQueue();
343            q.put(null);
344            shouldThrow();
345        }
346        catch (NullPointerException success) {
347        }
348     }
349
350    /**
278       * all elements successfully put are contained
279       */
280 <     public void testPut() {
281 <         try {
282 <             DelayQueue q = new DelayQueue();
283 <             for (int i = 0; i < SIZE; ++i) {
284 <                 PDelay I = new PDelay(i);
285 <                 q.put(I);
359 <                 assertTrue(q.contains(I));
360 <             }
361 <             assertEquals(SIZE, q.size());
362 <         }
363 <         finally {
280 >    public void testPut() {
281 >        DelayQueue q = new DelayQueue();
282 >        for (int i = 0; i < SIZE; ++i) {
283 >            PDelay x = new PDelay(i);
284 >            q.put(x);
285 >            assertTrue(q.contains(x));
286          }
287 +        assertEquals(SIZE, q.size());
288      }
289  
290      /**
291       * put doesn't block waiting for take
292       */
293 <    public void testPutWithTake() {
293 >    public void testPutWithTake() throws InterruptedException {
294          final DelayQueue q = new DelayQueue();
295 <        Thread t = new Thread(new Runnable() {
296 <                public void run() {
297 <                    int added = 0;
298 <                    try {
299 <                        q.put(new PDelay(0));
300 <                        ++added;
301 <                        q.put(new PDelay(0));
302 <                        ++added;
303 <                        q.put(new PDelay(0));
304 <                        ++added;
382 <                        q.put(new PDelay(0));
383 <                        ++added;
384 <                        threadAssertTrue(added == 4);
385 <                    } finally {
386 <                    }
387 <                }
388 <            });
389 <        try {
390 <            t.start();
391 <            Thread.sleep(SHORT_DELAY_MS);
392 <            q.take();
393 <            t.interrupt();
394 <            t.join();
395 <        } catch (Exception e) {
396 <            unexpectedException();
397 <        }
295 >        Thread t = newStartedThread(new CheckedRunnable() {
296 >            public void realRun() {
297 >                q.put(new PDelay(0));
298 >                q.put(new PDelay(0));
299 >                q.put(new PDelay(0));
300 >                q.put(new PDelay(0));
301 >            }});
302 >
303 >        awaitTermination(t);
304 >        assertEquals(4, q.size());
305      }
306  
307      /**
308       * timed offer does not time out
309       */
310 <    public void testTimedOffer() {
310 >    public void testTimedOffer() throws InterruptedException {
311          final DelayQueue q = new DelayQueue();
312 <        Thread t = new Thread(new Runnable() {
313 <                public void run() {
314 <                    try {
315 <                        q.put(new PDelay(0));
316 <                        q.put(new PDelay(0));
317 <                        threadAssertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
318 <                        threadAssertTrue(q.offer(new PDelay(0), LONG_DELAY_MS, TimeUnit.MILLISECONDS));
412 <                    } finally { }
413 <                }
414 <            });
312 >        Thread t = newStartedThread(new CheckedRunnable() {
313 >            public void realRun() throws InterruptedException {
314 >                q.put(new PDelay(0));
315 >                q.put(new PDelay(0));
316 >                assertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, MILLISECONDS));
317 >                assertTrue(q.offer(new PDelay(0), LONG_DELAY_MS, MILLISECONDS));
318 >            }});
319  
320 <        try {
417 <            t.start();
418 <            Thread.sleep(SMALL_DELAY_MS);
419 <            t.interrupt();
420 <            t.join();
421 <        } catch (Exception e) {
422 <            unexpectedException();
423 <        }
320 >        awaitTermination(t);
321      }
322  
323      /**
324       * take retrieves elements in priority order
325       */
326 <    public void testTake() {
327 <        try {
328 <            DelayQueue q = populatedQueue(SIZE);
329 <            for (int i = 0; i < SIZE; ++i) {
433 <                assertEquals(new PDelay(i), ((PDelay)q.take()));
434 <            }
435 <        } catch (InterruptedException e) {
436 <            unexpectedException();
437 <        }
438 <    }
439 <
440 <    /**
441 <     * take blocks interruptibly when empty
442 <     */
443 <    public void testTakeFromEmpty() {
444 <        final DelayQueue q = new DelayQueue();
445 <        Thread t = new Thread(new Runnable() {
446 <                public void run() {
447 <                    try {
448 <                        q.take();
449 <                        threadShouldThrow();
450 <                    } catch (InterruptedException success) { }
451 <                }
452 <            });
453 <        try {
454 <            t.start();
455 <            Thread.sleep(SHORT_DELAY_MS);
456 <            t.interrupt();
457 <            t.join();
458 <        } catch (Exception e) {
459 <            unexpectedException();
326 >    public void testTake() throws InterruptedException {
327 >        DelayQueue q = populatedQueue(SIZE);
328 >        for (int i = 0; i < SIZE; ++i) {
329 >            assertEquals(new PDelay(i), q.take());
330          }
331      }
332  
333      /**
334       * Take removes existing elements until empty, then blocks interruptibly
335       */
336 <    public void testBlockingTake() {
337 <        Thread t = new Thread(new Runnable() {
338 <                public void run() {
339 <                    try {
340 <                        DelayQueue q = populatedQueue(SIZE);
341 <                        for (int i = 0; i < SIZE; ++i) {
342 <                            threadAssertEquals(new PDelay(i), ((PDelay)q.take()));
343 <                        }
474 <                        q.take();
475 <                        threadShouldThrow();
476 <                    } catch (InterruptedException success) {
477 <                    }
478 <                }});
479 <        t.start();
480 <        try {
481 <           Thread.sleep(SHORT_DELAY_MS);
482 <           t.interrupt();
483 <           t.join();
484 <        }
485 <        catch (InterruptedException ie) {
486 <            unexpectedException();
487 <        }
488 <    }
336 >    public void testBlockingTake() throws InterruptedException {
337 >        final DelayQueue q = populatedQueue(SIZE);
338 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
339 >        Thread t = newStartedThread(new CheckedRunnable() {
340 >            public void realRun() throws InterruptedException {
341 >                for (int i = 0; i < SIZE; ++i) {
342 >                    assertEquals(new PDelay(i), ((PDelay)q.take()));
343 >                }
344  
345 +                Thread.currentThread().interrupt();
346 +                try {
347 +                    q.take();
348 +                    shouldThrow();
349 +                } catch (InterruptedException success) {}
350 +                assertFalse(Thread.interrupted());
351 +
352 +                pleaseInterrupt.countDown();
353 +                try {
354 +                    q.take();
355 +                    shouldThrow();
356 +                } catch (InterruptedException success) {}
357 +                assertFalse(Thread.interrupted());
358 +            }});
359 +
360 +        await(pleaseInterrupt);
361 +        assertThreadStaysAlive(t);
362 +        t.interrupt();
363 +        awaitTermination(t);
364 +    }
365  
366      /**
367       * poll succeeds unless empty
# Line 494 | Line 369 | public class DelayQueueTest extends JSR1
369      public void testPoll() {
370          DelayQueue q = populatedQueue(SIZE);
371          for (int i = 0; i < SIZE; ++i) {
372 <            assertEquals(new PDelay(i), ((PDelay)q.poll()));
372 >            assertEquals(new PDelay(i), q.poll());
373          }
374 <        assertNull(q.poll());
374 >        assertNull(q.poll());
375      }
376  
377      /**
378 <     * timed pool with zero timeout succeeds when non-empty, else times out
378 >     * timed poll with zero timeout succeeds when non-empty, else times out
379       */
380 <    public void testTimedPoll0() {
381 <        try {
382 <            DelayQueue q = populatedQueue(SIZE);
383 <            for (int i = 0; i < SIZE; ++i) {
384 <                assertEquals(new PDelay(i), ((PDelay)q.poll(0, TimeUnit.MILLISECONDS)));
385 <            }
511 <            assertNull(q.poll(0, TimeUnit.MILLISECONDS));
512 <        } catch (InterruptedException e) {
513 <            unexpectedException();
514 <        }
380 >    public void testTimedPoll0() throws InterruptedException {
381 >        DelayQueue q = populatedQueue(SIZE);
382 >        for (int i = 0; i < SIZE; ++i) {
383 >            assertEquals(new PDelay(i), q.poll(0, MILLISECONDS));
384 >        }
385 >        assertNull(q.poll(0, MILLISECONDS));
386      }
387  
388      /**
389 <     * timed pool with nonzero timeout succeeds when non-empty, else times out
389 >     * timed poll with nonzero timeout succeeds when non-empty, else times out
390       */
391 <    public void testTimedPoll() {
392 <        try {
393 <            DelayQueue q = populatedQueue(SIZE);
394 <            for (int i = 0; i < SIZE; ++i) {
395 <                assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)));
396 <            }
397 <            assertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
398 <        } catch (InterruptedException e) {
399 <            unexpectedException();
400 <        }
391 >    public void testTimedPoll() throws InterruptedException {
392 >        DelayQueue q = populatedQueue(SIZE);
393 >        for (int i = 0; i < SIZE; ++i) {
394 >            long startTime = System.nanoTime();
395 >            assertEquals(new PDelay(i), q.poll(LONG_DELAY_MS, MILLISECONDS));
396 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
397 >        }
398 >        long startTime = System.nanoTime();
399 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
400 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
401 >        checkEmpty(q);
402      }
403  
404      /**
405       * Interrupted timed poll throws InterruptedException instead of
406       * returning timeout status
407       */
408 <    public void testInterruptedTimedPoll() {
409 <        Thread t = new Thread(new Runnable() {
410 <                public void run() {
411 <                    try {
412 <                        DelayQueue q = populatedQueue(SIZE);
413 <                        for (int i = 0; i < SIZE; ++i) {
414 <                            threadAssertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)));
415 <                        }
416 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
545 <                    } catch (InterruptedException success) {
546 <                    }
547 <                }});
548 <        t.start();
549 <        try {
550 <           Thread.sleep(SHORT_DELAY_MS);
551 <           t.interrupt();
552 <           t.join();
553 <        }
554 <        catch (InterruptedException ie) {
555 <            unexpectedException();
556 <        }
557 <    }
558 <
559 <    /**
560 <     *  timed poll before a delayed offer fails; after offer succeeds;
561 <     *  on interruption throws
562 <     */
563 <    public void testTimedPollWithOffer() {
564 <        final DelayQueue q = new DelayQueue();
565 <        Thread t = new Thread(new Runnable() {
566 <                public void run() {
567 <                    try {
568 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
569 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
570 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
571 <                        threadFail("Should block");
572 <                    } catch (InterruptedException success) { }
408 >    public void testInterruptedTimedPoll() throws InterruptedException {
409 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
410 >        final DelayQueue q = populatedQueue(SIZE);
411 >        Thread t = newStartedThread(new CheckedRunnable() {
412 >            public void realRun() throws InterruptedException {
413 >                long startTime = System.nanoTime();
414 >                for (int i = 0; i < SIZE; ++i) {
415 >                    assertEquals(new PDelay(i),
416 >                                 ((PDelay)q.poll(LONG_DELAY_MS, MILLISECONDS)));
417                  }
574            });
575        try {
576            t.start();
577            Thread.sleep(SMALL_DELAY_MS);
578            assertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
579            t.interrupt();
580            t.join();
581        } catch (Exception e) {
582            unexpectedException();
583        }
584    }
418  
419 +                Thread.currentThread().interrupt();
420 +                try {
421 +                    q.poll(LONG_DELAY_MS, MILLISECONDS);
422 +                    shouldThrow();
423 +                } catch (InterruptedException success) {}
424 +                assertFalse(Thread.interrupted());
425 +
426 +                pleaseInterrupt.countDown();
427 +                try {
428 +                    q.poll(LONG_DELAY_MS, MILLISECONDS);
429 +                    shouldThrow();
430 +                } catch (InterruptedException success) {}
431 +                assertFalse(Thread.interrupted());
432 +                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
433 +            }});
434 +
435 +        await(pleaseInterrupt);
436 +        assertThreadStaysAlive(t);
437 +        t.interrupt();
438 +        awaitTermination(t);
439 +        checkEmpty(q);
440 +    }
441  
442      /**
443       * peek returns next element, or null if empty
# Line 590 | Line 445 | public class DelayQueueTest extends JSR1
445      public void testPeek() {
446          DelayQueue q = populatedQueue(SIZE);
447          for (int i = 0; i < SIZE; ++i) {
448 <            assertEquals(new PDelay(i), ((PDelay)q.peek()));
449 <            q.poll();
448 >            assertEquals(new PDelay(i), q.peek());
449 >            assertEquals(new PDelay(i), q.poll());
450              if (q.isEmpty())
451                  assertNull(q.peek());
452              else
453 <                assertTrue(i != ((PDelay)q.peek()).intValue());
453 >                assertFalse(new PDelay(i).equals(q.peek()));
454          }
455 <        assertNull(q.peek());
455 >        assertNull(q.peek());
456      }
457  
458      /**
# Line 606 | Line 461 | public class DelayQueueTest extends JSR1
461      public void testElement() {
462          DelayQueue q = populatedQueue(SIZE);
463          for (int i = 0; i < SIZE; ++i) {
464 <            assertEquals(new PDelay(i), ((PDelay)q.element()));
464 >            assertEquals(new PDelay(i), q.element());
465              q.poll();
466          }
467          try {
468              q.element();
469              shouldThrow();
470 <        }
616 <        catch (NoSuchElementException success) {}
470 >        } catch (NoSuchElementException success) {}
471      }
472  
473      /**
# Line 622 | Line 476 | public class DelayQueueTest extends JSR1
476      public void testRemove() {
477          DelayQueue q = populatedQueue(SIZE);
478          for (int i = 0; i < SIZE; ++i) {
479 <            assertEquals(new PDelay(i), ((PDelay)q.remove()));
479 >            assertEquals(new PDelay(i), q.remove());
480          }
481          try {
482              q.remove();
483              shouldThrow();
484 <        } catch (NoSuchElementException success) {
631 <        }
632 <    }
633 <
634 <    /**
635 <     * remove(x) removes x and returns true if present
636 <     */
637 <    public void testRemoveElement() {
638 <        DelayQueue q = populatedQueue(SIZE);
639 <        for (int i = 1; i < SIZE; i+=2) {
640 <            assertTrue(q.remove(new PDelay(i)));
641 <        }
642 <        for (int i = 0; i < SIZE; i+=2) {
643 <            assertTrue(q.remove(new PDelay(i)));
644 <            assertFalse(q.remove(new PDelay(i+1)));
645 <        }
646 <        assertTrue(q.isEmpty());
484 >        } catch (NoSuchElementException success) {}
485      }
486  
487      /**
# Line 666 | Line 504 | public class DelayQueueTest extends JSR1
504          q.clear();
505          assertTrue(q.isEmpty());
506          assertEquals(0, q.size());
507 <        assertEquals(NOCAP, q.remainingCapacity());
507 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
508          PDelay x = new PDelay(1);
509          q.add(x);
510          assertFalse(q.isEmpty());
# Line 703 | Line 541 | public class DelayQueueTest extends JSR1
541                  assertTrue(changed);
542  
543              assertTrue(q.containsAll(p));
544 <            assertEquals(SIZE-i, q.size());
544 >            assertEquals(SIZE - i, q.size());
545              p.remove();
546          }
547      }
# Line 716 | Line 554 | public class DelayQueueTest extends JSR1
554              DelayQueue q = populatedQueue(SIZE);
555              DelayQueue p = populatedQueue(i);
556              assertTrue(q.removeAll(p));
557 <            assertEquals(SIZE-i, q.size());
557 >            assertEquals(SIZE - i, q.size());
558              for (int j = 0; j < i; ++j) {
559 <                PDelay I = (PDelay)(p.remove());
560 <                assertFalse(q.contains(I));
559 >                PDelay x = (PDelay)(p.remove());
560 >                assertFalse(q.contains(x));
561              }
562          }
563      }
# Line 727 | Line 565 | public class DelayQueueTest extends JSR1
565      /**
566       * toArray contains all elements
567       */
568 <    public void testToArray() {
568 >    public void testToArray() throws InterruptedException {
569          DelayQueue q = populatedQueue(SIZE);
570 <        Object[] o = q.toArray();
570 >        Object[] o = q.toArray();
571          Arrays.sort(o);
572 <        try {
573 <        for (int i = 0; i < o.length; i++)
736 <            assertEquals(o[i], q.take());
737 <        } catch (InterruptedException e) {
738 <            unexpectedException();
739 <        }
572 >        for (int i = 0; i < o.length; i++)
573 >            assertSame(o[i], q.take());
574      }
575  
576      /**
577       * toArray(a) contains all elements
578       */
579      public void testToArray2() {
580 <        DelayQueue q = populatedQueue(SIZE);
581 <        PDelay[] ints = new PDelay[SIZE];
582 <        ints = (PDelay[])q.toArray(ints);
580 >        DelayQueue<PDelay> q = populatedQueue(SIZE);
581 >        PDelay[] ints = new PDelay[SIZE];
582 >        PDelay[] array = q.toArray(ints);
583 >        assertSame(ints, array);
584          Arrays.sort(ints);
585 <        try {
586 <            for (int i = 0; i < ints.length; i++)
752 <                assertEquals(ints[i], q.take());
753 <        } catch (InterruptedException e) {
754 <            unexpectedException();
755 <        }
756 <    }
757 <
758 <
759 <    /**
760 <     * toArray(null) throws NPE
761 <     */
762 <    public void testToArray_BadArg() {
763 <        try {
764 <            DelayQueue q = populatedQueue(SIZE);
765 <            Object o[] = q.toArray(null);
766 <            shouldThrow();
767 <        } catch (NullPointerException success) {}
585 >        for (int i = 0; i < ints.length; i++)
586 >            assertSame(ints[i], q.remove());
587      }
588  
589      /**
590 <     * toArray with incompatible array type throws CCE
590 >     * toArray(incompatible array type) throws ArrayStoreException
591       */
592      public void testToArray1_BadArg() {
593 <        try {
594 <            DelayQueue q = populatedQueue(SIZE);
595 <            Object o[] = q.toArray(new String[10] );
596 <            shouldThrow();
597 <        } catch (ArrayStoreException  success) {}
593 >        DelayQueue q = populatedQueue(SIZE);
594 >        try {
595 >            q.toArray(new String[10]);
596 >            shouldThrow();
597 >        } catch (ArrayStoreException success) {}
598      }
599  
600      /**
# Line 784 | Line 603 | public class DelayQueueTest extends JSR1
603      public void testIterator() {
604          DelayQueue q = populatedQueue(SIZE);
605          int i = 0;
606 <        Iterator it = q.iterator();
606 >        Iterator it = q.iterator();
607          while (it.hasNext()) {
608              assertTrue(q.contains(it.next()));
609              ++i;
610          }
611          assertEquals(i, SIZE);
612 +        assertIteratorExhausted(it);
613 +    }
614 +
615 +    /**
616 +     * iterator of empty collection has no elements
617 +     */
618 +    public void testEmptyIterator() {
619 +        assertIteratorExhausted(new DelayQueue().iterator());
620      }
621  
622      /**
623       * iterator.remove removes current element
624       */
625 <    public void testIteratorRemove () {
625 >    public void testIteratorRemove() {
626          final DelayQueue q = new DelayQueue();
627          q.add(new PDelay(2));
628          q.add(new PDelay(1));
# Line 804 | Line 631 | public class DelayQueueTest extends JSR1
631          it.next();
632          it.remove();
633          it = q.iterator();
634 <        assertEquals(it.next(), new PDelay(2));
635 <        assertEquals(it.next(), new PDelay(3));
634 >        assertEquals(new PDelay(2), it.next());
635 >        assertEquals(new PDelay(3), it.next());
636          assertFalse(it.hasNext());
637      }
638  
812
639      /**
640       * toString contains toStrings of elements
641       */
642      public void testToString() {
643          DelayQueue q = populatedQueue(SIZE);
644          String s = q.toString();
645 <        for (int i = 0; i < SIZE; ++i) {
646 <            assertTrue(s.indexOf(String.valueOf(Integer.MIN_VALUE+i)) >= 0);
821 <        }
645 >        for (Object e : q)
646 >            assertTrue(s.contains(e.toString()));
647      }
648  
649      /**
650 <     * offer transfers elements across Executor tasks
650 >     * timed poll transfers elements across Executor tasks
651       */
652      public void testPollInExecutor() {
653          final DelayQueue q = new DelayQueue();
654 <        ExecutorService executor = Executors.newFixedThreadPool(2);
655 <        executor.execute(new Runnable() {
656 <            public void run() {
657 <                threadAssertNull(q.poll());
658 <                try {
659 <                    threadAssertTrue(null != q.poll(MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS));
660 <                    threadAssertTrue(q.isEmpty());
661 <                }
662 <                catch (InterruptedException e) {
663 <                    threadUnexpectedException();
839 <                }
840 <            }
841 <        });
654 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
655 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
656 >        try (PoolCleaner cleaner = cleaner(executor)) {
657 >            executor.execute(new CheckedRunnable() {
658 >                public void realRun() throws InterruptedException {
659 >                    assertNull(q.poll());
660 >                    threadsStarted.await();
661 >                    assertNotNull(q.poll(LONG_DELAY_MS, MILLISECONDS));
662 >                    checkEmpty(q);
663 >                }});
664  
665 <        executor.execute(new Runnable() {
666 <            public void run() {
667 <                try {
846 <                    Thread.sleep(SHORT_DELAY_MS);
665 >            executor.execute(new CheckedRunnable() {
666 >                public void realRun() throws InterruptedException {
667 >                    threadsStarted.await();
668                      q.put(new PDelay(1));
669 <                }
670 <                catch (InterruptedException e) {
850 <                    threadUnexpectedException();
851 <                }
852 <            }
853 <        });
854 <        joinPool(executor);
855 <
669 >                }});
670 >        }
671      }
672  
858
673      /**
674       * Delayed actions do not occur until their delay elapses
675       */
676 <    public void testDelay() {
677 <        DelayQueue q = new DelayQueue();
678 <        NanoDelay[] elements = new NanoDelay[SIZE];
679 <        for (int i = 0; i < SIZE; ++i) {
866 <            elements[i] = new NanoDelay(1000000000L + 1000000L * (SIZE - i));
867 <        }
868 <        for (int i = 0; i < SIZE; ++i) {
869 <            q.add(elements[i]);
870 <        }
676 >    public void testDelay() throws InterruptedException {
677 >        DelayQueue<NanoDelay> q = new DelayQueue<>();
678 >        for (int i = 0; i < SIZE; ++i)
679 >            q.add(new NanoDelay(1000000L * (SIZE - i)));
680  
681 <        try {
682 <            long last = 0;
683 <            for (int i = 0; i < SIZE; ++i) {
684 <                NanoDelay e = (NanoDelay)(q.take());
685 <                long tt = e.getTriggerTime();
686 <                assertTrue(tt <= System.nanoTime());
687 <                if (i != 0)
688 <                    assertTrue(tt >= last);
880 <                last = tt;
881 <            }
882 <        }
883 <        catch (InterruptedException ie) {
884 <            unexpectedException();
681 >        long last = 0;
682 >        for (int i = 0; i < SIZE; ++i) {
683 >            NanoDelay e = q.take();
684 >            long tt = e.getTriggerTime();
685 >            assertTrue(System.nanoTime() - tt >= 0);
686 >            if (i != 0)
687 >                assertTrue(tt >= last);
688 >            last = tt;
689          }
690 +        assertTrue(q.isEmpty());
691      }
692  
693      /**
# Line 891 | Line 696 | public class DelayQueueTest extends JSR1
696      public void testPeekDelayed() {
697          DelayQueue q = new DelayQueue();
698          q.add(new NanoDelay(Long.MAX_VALUE));
699 <        assert(q.peek() != null);
699 >        assertNotNull(q.peek());
700      }
701  
897
702      /**
703       * poll of a non-empty queue returns null if no expired elements.
704       */
# Line 907 | Line 711 | public class DelayQueueTest extends JSR1
711      /**
712       * timed poll of a non-empty queue returns null if no expired elements.
713       */
714 <    public void testTimedPollDelayed() {
714 >    public void testTimedPollDelayed() throws InterruptedException {
715          DelayQueue q = new DelayQueue();
716          q.add(new NanoDelay(LONG_DELAY_MS * 1000000L));
717 <        try {
914 <            assertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
915 <        } catch (Exception ex) {
916 <            unexpectedException();
917 <        }
918 <    }
919 <
920 <    /**
921 <     * drainTo(null) throws NPE
922 <     */
923 <    public void testDrainToNull() {
924 <        DelayQueue q = populatedQueue(SIZE);
925 <        try {
926 <            q.drainTo(null);
927 <            shouldThrow();
928 <        } catch (NullPointerException success) {
929 <        }
930 <    }
931 <
932 <    /**
933 <     * drainTo(this) throws IAE
934 <     */
935 <    public void testDrainToSelf() {
936 <        DelayQueue q = populatedQueue(SIZE);
937 <        try {
938 <            q.drainTo(q);
939 <            shouldThrow();
940 <        } catch (IllegalArgumentException success) {
941 <        }
717 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
718      }
719  
720      /**
# Line 953 | Line 729 | public class DelayQueueTest extends JSR1
729          }
730          ArrayList l = new ArrayList();
731          q.drainTo(l);
732 <        assertEquals(q.size(), 0);
732 >        assertEquals(0, q.size());
733          for (int i = 0; i < SIZE; ++i)
734 <            assertEquals(l.get(i), elems[i]);
734 >            assertEquals(elems[i], l.get(i));
735          q.add(elems[0]);
736          q.add(elems[1]);
737          assertFalse(q.isEmpty());
# Line 963 | Line 739 | public class DelayQueueTest extends JSR1
739          assertTrue(q.contains(elems[1]));
740          l.clear();
741          q.drainTo(l);
742 <        assertEquals(q.size(), 0);
743 <        assertEquals(l.size(), 2);
742 >        assertEquals(0, q.size());
743 >        assertEquals(2, l.size());
744          for (int i = 0; i < 2; ++i)
745 <            assertEquals(l.get(i), elems[i]);
745 >            assertEquals(elems[i], l.get(i));
746      }
747  
748      /**
749       * drainTo empties queue
750       */
751 <    public void testDrainToWithActivePut() {
751 >    public void testDrainToWithActivePut() throws InterruptedException {
752          final DelayQueue q = populatedQueue(SIZE);
753 <        Thread t = new Thread(new Runnable() {
754 <                public void run() {
755 <                    q.put(new PDelay(SIZE+1));
756 <                }
981 <            });
982 <        try {
983 <            t.start();
984 <            ArrayList l = new ArrayList();
985 <            q.drainTo(l);
986 <            assertTrue(l.size() >= SIZE);
987 <            t.join();
988 <            assertTrue(q.size() + l.size() >= SIZE);
989 <        } catch (Exception e) {
990 <            unexpectedException();
991 <        }
992 <    }
753 >        Thread t = new Thread(new CheckedRunnable() {
754 >            public void realRun() {
755 >                q.put(new PDelay(SIZE + 1));
756 >            }});
757  
758 <    /**
759 <     * drainTo(null, n) throws NPE
760 <     */
761 <    public void testDrainToNullN() {
762 <        DelayQueue q = populatedQueue(SIZE);
763 <        try {
1000 <            q.drainTo(null, 0);
1001 <            shouldThrow();
1002 <        } catch (NullPointerException success) {
1003 <        }
1004 <    }
1005 <
1006 <    /**
1007 <     * drainTo(this, n) throws IAE
1008 <     */
1009 <    public void testDrainToSelfN() {
1010 <        DelayQueue q = populatedQueue(SIZE);
1011 <        try {
1012 <            q.drainTo(q, 0);
1013 <            shouldThrow();
1014 <        } catch (IllegalArgumentException success) {
1015 <        }
758 >        t.start();
759 >        ArrayList l = new ArrayList();
760 >        q.drainTo(l);
761 >        assertTrue(l.size() >= SIZE);
762 >        t.join();
763 >        assertTrue(q.size() + l.size() >= SIZE);
764      }
765  
766      /**
767 <     * drainTo(c, n) empties first max {n, size} elements of queue into c
767 >     * drainTo(c, n) empties first min(n, size) elements of queue into c
768       */
769      public void testDrainToN() {
770          for (int i = 0; i < SIZE + 2; ++i) {
771              DelayQueue q = populatedQueue(SIZE);
772              ArrayList l = new ArrayList();
773              q.drainTo(l, i);
774 <            int k = (i < SIZE)? i : SIZE;
775 <            assertEquals(q.size(), SIZE-k);
776 <            assertEquals(l.size(), k);
774 >            int k = (i < SIZE) ? i : SIZE;
775 >            assertEquals(SIZE - k, q.size());
776 >            assertEquals(k, l.size());
777          }
778      }
779  
780 <
780 >    /**
781 >     * remove(null), contains(null) always return false
782 >     */
783 >    public void testNeverContainsNull() {
784 >        Collection<?> q = populatedQueue(SIZE);
785 >        assertFalse(q.contains(null));
786 >        assertFalse(q.remove(null));
787 >    }
788   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines