ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/DelayQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/DelayQueueTest.java (file contents):
Revision 1.26 by jsr166, Sun Nov 22 18:57:17 2009 UTC vs.
Revision 1.34 by dl, Wed Sep 29 12:33:48 2010 UTC

# Line 13 | Line 13 | import java.util.concurrent.*;
13  
14   public class DelayQueueTest extends JSR166TestCase {
15      public static void main(String[] args) {
16 <        junit.textui.TestRunner.run (suite());
16 >        junit.textui.TestRunner.run(suite());
17      }
18  
19      public static Test suite() {
# Line 24 | Line 24 | public class DelayQueueTest extends JSR1
24  
25      /**
26       * A delayed implementation for testing.
27 <     * Most  tests use Pseudodelays, where delays are all elapsed
27 >     * Most tests use Pseudodelays, where delays are all elapsed
28       * (so, no blocking solely for delays) but are still ordered
29       */
30      static class PDelay implements Delayed {
# Line 32 | Line 32 | public class DelayQueueTest extends JSR1
32          PDelay(int i) { pseudodelay = Integer.MIN_VALUE + i; }
33          public int compareTo(PDelay y) {
34              int i = pseudodelay;
35 <            int j = ((PDelay)y).pseudodelay;
35 >            int j = y.pseudodelay;
36              if (i < j) return -1;
37              if (i > j) return 1;
38              return 0;
39          }
40  
41          public int compareTo(Delayed y) {
42 <            int i = pseudodelay;
43 <            int j = ((PDelay)y).pseudodelay;
44 <            if (i < j) return -1;
45 <            if (i > j) return 1;
46 <            return 0;
42 >            return compareTo((PDelay)y);
43          }
44  
45          public boolean equals(Object other) {
46 <            return ((PDelay)other).pseudodelay == pseudodelay;
46 >            return equals((PDelay)other);
47          }
48          public boolean equals(PDelay other) {
49 <            return ((PDelay)other).pseudodelay == pseudodelay;
49 >            return other.pseudodelay == pseudodelay;
50          }
51  
52  
# Line 77 | Line 73 | public class DelayQueueTest extends JSR1
73          }
74          public int compareTo(NanoDelay y) {
75              long i = trigger;
76 <            long j = ((NanoDelay)y).trigger;
76 >            long j = y.trigger;
77              if (i < j) return -1;
78              if (i > j) return 1;
79              return 0;
80          }
81  
82          public int compareTo(Delayed y) {
83 <            long i = trigger;
88 <            long j = ((NanoDelay)y).trigger;
89 <            if (i < j) return -1;
90 <            if (i > j) return 1;
91 <            return 0;
83 >            return compareTo((NanoDelay)y);
84          }
85  
86          public boolean equals(Object other) {
87 <            return ((NanoDelay)other).trigger == trigger;
87 >            return equals((NanoDelay)other);
88          }
89          public boolean equals(NanoDelay other) {
90 <            return ((NanoDelay)other).trigger == trigger;
90 >            return other.trigger == trigger;
91          }
92  
93          public long getDelay(TimeUnit unit) {
# Line 199 | Line 191 | public class DelayQueueTest extends JSR1
191      }
192  
193      /**
194 <     * remainingCapacity does not change when elementa added or removed,
194 >     * remainingCapacity does not change when elements added or removed,
195       * but size does
196       */
197      public void testRemainingCapacity() {
# Line 292 | Line 284 | public class DelayQueueTest extends JSR1
284              shouldThrow();
285          } catch (NullPointerException success) {}
286      }
287 +
288      /**
289       * addAll of a collection with any null elements throws NPE after
290       * possibly adding some elements
# Line 499 | Line 492 | public class DelayQueueTest extends JSR1
492          final PDelay pdelay = new PDelay(0);
493          Thread t = new Thread(new CheckedRunnable() {
494              public void realRun() throws InterruptedException {
502 –                assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
503 –                assertSame(pdelay, q.poll(LONG_DELAY_MS, MILLISECONDS));
495                  try {
496 +                    assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
497 +                    assertSame(pdelay, q.poll(LONG_DELAY_MS, MILLISECONDS));
498                      q.poll(LONG_DELAY_MS, MILLISECONDS);
499                      shouldThrow();
500                  } catch (InterruptedException success) {}
# Line 716 | Line 709 | public class DelayQueueTest extends JSR1
709      /**
710       * iterator.remove removes current element
711       */
712 <    public void testIteratorRemove () {
712 >    public void testIteratorRemove() {
713          final DelayQueue q = new DelayQueue();
714          q.add(new PDelay(2));
715          q.add(new PDelay(1));
# Line 750 | Line 743 | public class DelayQueueTest extends JSR1
743          ExecutorService executor = Executors.newFixedThreadPool(2);
744          executor.execute(new CheckedRunnable() {
745              public void realRun() throws InterruptedException {
746 <                threadAssertNull(q.poll());
747 <                threadAssertTrue(null != q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
748 <                threadAssertTrue(q.isEmpty());
746 >                assertNull(q.poll());
747 >                assertTrue(null != q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
748 >                assertTrue(q.isEmpty());
749              }});
750  
751          executor.execute(new CheckedRunnable() {
# Line 762 | Line 755 | public class DelayQueueTest extends JSR1
755              }});
756  
757          joinPool(executor);
765 –
758      }
759  
760  
# Line 796 | Line 788 | public class DelayQueueTest extends JSR1
788      public void testPeekDelayed() {
789          DelayQueue q = new DelayQueue();
790          q.add(new NanoDelay(Long.MAX_VALUE));
791 <        assert(q.peek() != null);
791 >        assertNotNull(q.peek());
792      }
793  
794  

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines