ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/DelayQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/DelayQueueTest.java (file contents):
Revision 1.49 by dl, Fri May 6 11:22:07 2011 UTC vs.
Revision 1.61 by jsr166, Fri Apr 5 19:27:23 2013 UTC

# Line 7 | Line 7
7   */
8  
9   import junit.framework.*;
10 < import java.util.*;
10 > import java.util.Arrays;
11 > import java.util.ArrayList;
12 > import java.util.Iterator;
13 > import java.util.NoSuchElementException;
14 > import java.util.concurrent.BlockingQueue;
15 > import java.util.concurrent.CountDownLatch;
16 > import java.util.concurrent.Delayed;
17 > import java.util.concurrent.DelayQueue;
18 > import java.util.concurrent.Executors;
19 > import java.util.concurrent.ExecutorService;
20 > import java.util.concurrent.TimeUnit;
21   import static java.util.concurrent.TimeUnit.MILLISECONDS;
12 import java.util.concurrent.*;
22  
23   public class DelayQueueTest extends JSR166TestCase {
24 +
25 +    public static class Generic extends BlockingQueueTest {
26 +        protected BlockingQueue emptyCollection() {
27 +            return new DelayQueue();
28 +        }
29 +        protected PDelay makeElement(int i) {
30 +            return new PDelay(i);
31 +        }
32 +    }
33 +
34      public static void main(String[] args) {
35          junit.textui.TestRunner.run(suite());
36      }
37  
38      public static Test suite() {
39 <        return new TestSuite(DelayQueueTest.class);
39 >        return newTestSuite(DelayQueueTest.class,
40 >                            new Generic().testSuite());
41      }
42  
43      private static final int NOCAP = Integer.MAX_VALUE;
# Line 29 | Line 49 | public class DelayQueueTest extends JSR1
49       */
50      static class PDelay implements Delayed {
51          int pseudodelay;
52 <        PDelay(int i) { pseudodelay = Integer.MIN_VALUE + i; }
53 <        public int compareTo(PDelay y) {
54 <            int i = pseudodelay;
55 <            int j = y.pseudodelay;
56 <            if (i < j) return -1;
37 <            if (i > j) return 1;
38 <            return 0;
52 >        PDelay(int i) { pseudodelay = i; }
53 >        public int compareTo(PDelay other) {
54 >            int a = this.pseudodelay;
55 >            int b = other.pseudodelay;
56 >            return (a < b) ? -1 : (a > b) ? 1 : 0;
57          }
40
58          public int compareTo(Delayed y) {
59              return compareTo((PDelay)y);
60          }
44
61          public boolean equals(Object other) {
62 <            return equals((PDelay)other);
63 <        }
48 <        public boolean equals(PDelay other) {
49 <            return other.pseudodelay == pseudodelay;
62 >            return (other instanceof PDelay) &&
63 >                this.pseudodelay == ((PDelay)other).pseudodelay;
64          }
65 <
66 <
65 >        // suppress [overrides] javac warning
66 >        public int hashCode() { return pseudodelay; }
67          public long getDelay(TimeUnit ignore) {
68 <            return pseudodelay;
55 <        }
56 <        public int intValue() {
57 <            return pseudodelay;
68 >            return Integer.MIN_VALUE + pseudodelay;
69          }
59
70          public String toString() {
71              return String.valueOf(pseudodelay);
72          }
73      }
74  
65
75      /**
76       * Delayed implementation that actually delays
77       */
# Line 90 | Line 99 | public class DelayQueueTest extends JSR1
99              return other.trigger == trigger;
100          }
101  
102 +        // suppress [overrides] javac warning
103 +        public int hashCode() { return (int) trigger; }
104 +
105          public long getDelay(TimeUnit unit) {
106              long n = trigger - System.nanoTime();
107              return unit.convert(n, TimeUnit.NANOSECONDS);
# Line 104 | Line 116 | public class DelayQueueTest extends JSR1
116          }
117      }
118  
107
119      /**
120 <     * Create a queue of given size containing consecutive
120 >     * Returns a new queue of given size containing consecutive
121       * PDelays 0 ... n.
122       */
123      private DelayQueue<PDelay> populatedQueue(int n) {
# Line 209 | Line 220 | public class DelayQueueTest extends JSR1
220      }
221  
222      /**
212     * offer(null) throws NPE
213     */
214    public void testOfferNull() {
215        try {
216            DelayQueue q = new DelayQueue();
217            q.offer(null);
218            shouldThrow();
219        } catch (NullPointerException success) {}
220    }
221
222    /**
223     * add(null) throws NPE
224     */
225    public void testAddNull() {
226        try {
227            DelayQueue q = new DelayQueue();
228            q.add(null);
229            shouldThrow();
230        } catch (NullPointerException success) {}
231    }
232
233    /**
223       * offer non-null succeeds
224       */
225      public void testOffer() {
# Line 251 | Line 240 | public class DelayQueueTest extends JSR1
240      }
241  
242      /**
254     * addAll(null) throws NPE
255     */
256    public void testAddAll1() {
257        try {
258            DelayQueue q = new DelayQueue();
259            q.addAll(null);
260            shouldThrow();
261        } catch (NullPointerException success) {}
262    }
263
264
265    /**
243       * addAll(this) throws IAE
244       */
245      public void testAddAllSelf() {
# Line 274 | Line 251 | public class DelayQueueTest extends JSR1
251      }
252  
253      /**
277     * addAll of a collection with null elements throws NPE
278     */
279    public void testAddAll2() {
280        try {
281            DelayQueue q = new DelayQueue();
282            PDelay[] ints = new PDelay[SIZE];
283            q.addAll(Arrays.asList(ints));
284            shouldThrow();
285        } catch (NullPointerException success) {}
286    }
287
288    /**
254       * addAll of a collection with any null elements throws NPE after
255       * possibly adding some elements
256       */
# Line 316 | Line 281 | public class DelayQueueTest extends JSR1
281      }
282  
283      /**
319     * put(null) throws NPE
320     */
321    public void testPutNull() {
322        try {
323            DelayQueue q = new DelayQueue();
324            q.put(null);
325            shouldThrow();
326        } catch (NullPointerException success) {}
327    }
328
329    /**
284       * all elements successfully put are contained
285       */
286      public void testPut() {
# Line 344 | Line 298 | public class DelayQueueTest extends JSR1
298       */
299      public void testPutWithTake() throws InterruptedException {
300          final DelayQueue q = new DelayQueue();
301 <        Thread t = new Thread(new CheckedRunnable() {
301 >        Thread t = newStartedThread(new CheckedRunnable() {
302              public void realRun() {
303                  q.put(new PDelay(0));
304                  q.put(new PDelay(0));
# Line 352 | Line 306 | public class DelayQueueTest extends JSR1
306                  q.put(new PDelay(0));
307              }});
308  
309 <        t.start();
310 <        delay(SHORT_DELAY_MS);
357 <        q.take();
358 <        t.interrupt();
359 <        t.join();
309 >        awaitTermination(t);
310 >        assertEquals(4, q.size());
311      }
312  
313      /**
# Line 364 | Line 315 | public class DelayQueueTest extends JSR1
315       */
316      public void testTimedOffer() throws InterruptedException {
317          final DelayQueue q = new DelayQueue();
318 <        Thread t = new Thread(new CheckedRunnable() {
318 >        Thread t = newStartedThread(new CheckedRunnable() {
319              public void realRun() throws InterruptedException {
320                  q.put(new PDelay(0));
321                  q.put(new PDelay(0));
# Line 372 | Line 323 | public class DelayQueueTest extends JSR1
323                  assertTrue(q.offer(new PDelay(0), LONG_DELAY_MS, MILLISECONDS));
324              }});
325  
326 <        t.start();
376 <        delay(SMALL_DELAY_MS);
377 <        t.interrupt();
378 <        t.join();
326 >        awaitTermination(t);
327      }
328  
329      /**
# Line 389 | Line 337 | public class DelayQueueTest extends JSR1
337      }
338  
339      /**
392     * take blocks interruptibly when empty
393     */
394    public void testTakeFromEmptyBlocksInterruptibly()
395            throws InterruptedException {
396        final BlockingQueue q = new DelayQueue();
397        final CountDownLatch threadStarted = new CountDownLatch(1);
398        Thread t = newStartedThread(new CheckedRunnable() {
399            public void realRun() {
400                long t0 = System.nanoTime();
401                threadStarted.countDown();
402                try {
403                    q.take();
404                    shouldThrow();
405                } catch (InterruptedException success) {}
406                assertTrue(millisElapsedSince(t0) >= SHORT_DELAY_MS);
407            }});
408        threadStarted.await();
409        delay(SHORT_DELAY_MS);
410        assertTrue(t.isAlive());
411        t.interrupt();
412        awaitTermination(t, MEDIUM_DELAY_MS);
413        assertFalse(t.isAlive());
414    }
415
416    /**
340       * Take removes existing elements until empty, then blocks interruptibly
341       */
342      public void testBlockingTake() throws InterruptedException {
343          final DelayQueue q = populatedQueue(SIZE);
344 <        Thread t = new Thread(new CheckedRunnable() {
344 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
345 >        Thread t = newStartedThread(new CheckedRunnable() {
346              public void realRun() throws InterruptedException {
347                  for (int i = 0; i < SIZE; ++i) {
348                      assertEquals(new PDelay(i), ((PDelay)q.take()));
349                  }
350 +
351 +                Thread.currentThread().interrupt();
352                  try {
353                      q.take();
354                      shouldThrow();
355                  } catch (InterruptedException success) {}
356 +                assertFalse(Thread.interrupted());
357 +
358 +                pleaseInterrupt.countDown();
359 +                try {
360 +                    q.take();
361 +                    shouldThrow();
362 +                } catch (InterruptedException success) {}
363 +                assertFalse(Thread.interrupted());
364              }});
365  
366 <        t.start();
367 <        delay(SHORT_DELAY_MS);
366 >        await(pleaseInterrupt);
367 >        assertThreadStaysAlive(t);
368          t.interrupt();
369 <        t.join();
369 >        awaitTermination(t);
370      }
371  
438
372      /**
373       * poll succeeds unless empty
374       */
# Line 464 | Line 397 | public class DelayQueueTest extends JSR1
397      public void testTimedPoll() throws InterruptedException {
398          DelayQueue q = populatedQueue(SIZE);
399          for (int i = 0; i < SIZE; ++i) {
400 <            assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, MILLISECONDS)));
401 <        }
402 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
400 >            long startTime = System.nanoTime();
401 >            assertEquals(new PDelay(i), ((PDelay)q.poll(LONG_DELAY_MS, MILLISECONDS)));
402 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
403 >        }
404 >        long startTime = System.nanoTime();
405 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
406 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
407 >        checkEmpty(q);
408      }
409  
410      /**
# Line 474 | Line 412 | public class DelayQueueTest extends JSR1
412       * returning timeout status
413       */
414      public void testInterruptedTimedPoll() throws InterruptedException {
415 <        Thread t = new Thread(new CheckedRunnable() {
415 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
416 >        Thread t = newStartedThread(new CheckedRunnable() {
417              public void realRun() throws InterruptedException {
418                  DelayQueue q = populatedQueue(SIZE);
419                  for (int i = 0; i < SIZE; ++i) {
420                      assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, MILLISECONDS)));
421                  }
483                try {
484                    q.poll(SMALL_DELAY_MS, MILLISECONDS);
485                    shouldThrow();
486                } catch (InterruptedException success) {}
487            }});
488
489        t.start();
490        delay(SHORT_DELAY_MS);
491        t.interrupt();
492        t.join();
493    }
494
495    /**
496     * timed poll before a delayed offer fails; after offer succeeds;
497     * on interruption throws
498     */
499    public void testTimedPollWithOffer() throws InterruptedException {
500        final DelayQueue q = new DelayQueue();
501        final PDelay pdelay = new PDelay(0);
502        final CheckedBarrier barrier = new CheckedBarrier(2);
503        Thread t = new Thread(new CheckedRunnable() {
504            public void realRun() throws InterruptedException {
505                assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
506
507                barrier.await();
508                assertSame(pdelay, q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
422  
423                  Thread.currentThread().interrupt();
424                  try {
425 <                    q.poll(SHORT_DELAY_MS, MILLISECONDS);
425 >                    q.poll(LONG_DELAY_MS, MILLISECONDS);
426                      shouldThrow();
427                  } catch (InterruptedException success) {}
428 +                assertFalse(Thread.interrupted());
429  
430 <                barrier.await();
430 >                pleaseInterrupt.countDown();
431                  try {
432 <                    q.poll(MEDIUM_DELAY_MS, MILLISECONDS);
432 >                    q.poll(LONG_DELAY_MS, MILLISECONDS);
433                      shouldThrow();
434                  } catch (InterruptedException success) {}
435 +                assertFalse(Thread.interrupted());
436              }});
437  
438 <        t.start();
439 <        barrier.await();
525 <        assertTrue(q.offer(pdelay, SHORT_DELAY_MS, MILLISECONDS));
526 <        barrier.await();
527 <        sleep(SHORT_DELAY_MS);
438 >        await(pleaseInterrupt);
439 >        assertThreadStaysAlive(t);
440          t.interrupt();
441 <        t.join();
441 >        awaitTermination(t);
442      }
443  
532
444      /**
445       * peek returns next element, or null if empty
446       */
# Line 576 | Line 487 | public class DelayQueueTest extends JSR1
487      }
488  
489      /**
579     * remove(x) removes x and returns true if present
580     */
581    public void testRemoveElement() {
582        DelayQueue q = populatedQueue(SIZE);
583        for (int i = 1; i < SIZE; i+=2) {
584            assertTrue(q.remove(new PDelay(i)));
585        }
586        for (int i = 0; i < SIZE; i+=2) {
587            assertTrue(q.remove(new PDelay(i)));
588            assertFalse(q.remove(new PDelay(i+1)));
589        }
590        assertTrue(q.isEmpty());
591    }
592
593    /**
490       * contains(x) reports true when elements added but not yet removed
491       */
492      public void testContains() {
# Line 692 | Line 588 | public class DelayQueueTest extends JSR1
588              assertSame(ints[i], q.remove());
589      }
590  
695
696    /**
697     * toArray(null) throws NullPointerException
698     */
699    public void testToArray_NullArg() {
700        DelayQueue q = populatedQueue(SIZE);
701        try {
702            q.toArray(null);
703            shouldThrow();
704        } catch (NullPointerException success) {}
705    }
706
591      /**
592       * toArray(incompatible array type) throws ArrayStoreException
593       */
# Line 741 | Line 625 | public class DelayQueueTest extends JSR1
625          it.next();
626          it.remove();
627          it = q.iterator();
628 <        assertEquals(it.next(), new PDelay(2));
629 <        assertEquals(it.next(), new PDelay(3));
628 >        assertEquals(new PDelay(2), it.next());
629 >        assertEquals(new PDelay(3), it.next());
630          assertFalse(it.hasNext());
631      }
632  
749
633      /**
634       * toString contains toStrings of elements
635       */
636      public void testToString() {
637          DelayQueue q = populatedQueue(SIZE);
638          String s = q.toString();
639 <        for (int i = 0; i < SIZE; ++i) {
640 <            assertTrue(s.indexOf(String.valueOf(Integer.MIN_VALUE+i)) >= 0);
758 <        }
639 >        for (Object e : q)
640 >            assertTrue(s.contains(e.toString()));
641      }
642  
643      /**
644 <     * offer transfers elements across Executor tasks
644 >     * timed poll transfers elements across Executor tasks
645       */
646      public void testPollInExecutor() {
647          final DelayQueue q = new DelayQueue();
648 +        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
649          ExecutorService executor = Executors.newFixedThreadPool(2);
650          executor.execute(new CheckedRunnable() {
651              public void realRun() throws InterruptedException {
652                  assertNull(q.poll());
653 <                assertTrue(null != q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
654 <                assertTrue(q.isEmpty());
653 >                threadsStarted.await();
654 >                assertTrue(null != q.poll(LONG_DELAY_MS, MILLISECONDS));
655 >                checkEmpty(q);
656              }});
657  
658          executor.execute(new CheckedRunnable() {
659              public void realRun() throws InterruptedException {
660 <                delay(SHORT_DELAY_MS);
660 >                threadsStarted.await();
661                  q.put(new PDelay(1));
662              }});
663  
664          joinPool(executor);
665      }
666  
783
667      /**
668       * Delayed actions do not occur until their delay elapses
669       */
# Line 810 | Line 693 | public class DelayQueueTest extends JSR1
693          assertNotNull(q.peek());
694      }
695  
813
696      /**
697       * poll of a non-empty queue returns null if no expired elements.
698       */
# Line 826 | Line 708 | public class DelayQueueTest extends JSR1
708      public void testTimedPollDelayed() throws InterruptedException {
709          DelayQueue q = new DelayQueue();
710          q.add(new NanoDelay(LONG_DELAY_MS * 1000000L));
711 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
830 <    }
831 <
832 <    /**
833 <     * drainTo(null) throws NPE
834 <     */
835 <    public void testDrainToNull() {
836 <        DelayQueue q = populatedQueue(SIZE);
837 <        try {
838 <            q.drainTo(null);
839 <            shouldThrow();
840 <        } catch (NullPointerException success) {}
841 <    }
842 <
843 <    /**
844 <     * drainTo(this) throws IAE
845 <     */
846 <    public void testDrainToSelf() {
847 <        DelayQueue q = populatedQueue(SIZE);
848 <        try {
849 <            q.drainTo(q);
850 <            shouldThrow();
851 <        } catch (IllegalArgumentException success) {}
711 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
712      }
713  
714      /**
# Line 863 | Line 723 | public class DelayQueueTest extends JSR1
723          }
724          ArrayList l = new ArrayList();
725          q.drainTo(l);
726 <        assertEquals(q.size(), 0);
726 >        assertEquals(0, q.size());
727          for (int i = 0; i < SIZE; ++i)
728 <            assertEquals(l.get(i), elems[i]);
728 >            assertEquals(elems[i], l.get(i));
729          q.add(elems[0]);
730          q.add(elems[1]);
731          assertFalse(q.isEmpty());
# Line 873 | Line 733 | public class DelayQueueTest extends JSR1
733          assertTrue(q.contains(elems[1]));
734          l.clear();
735          q.drainTo(l);
736 <        assertEquals(q.size(), 0);
737 <        assertEquals(l.size(), 2);
736 >        assertEquals(0, q.size());
737 >        assertEquals(2, l.size());
738          for (int i = 0; i < 2; ++i)
739 <            assertEquals(l.get(i), elems[i]);
739 >            assertEquals(elems[i], l.get(i));
740      }
741  
742      /**
# Line 898 | Line 758 | public class DelayQueueTest extends JSR1
758      }
759  
760      /**
901     * drainTo(null, n) throws NPE
902     */
903    public void testDrainToNullN() {
904        DelayQueue q = populatedQueue(SIZE);
905        try {
906            q.drainTo(null, 0);
907            shouldThrow();
908        } catch (NullPointerException success) {}
909    }
910
911    /**
912     * drainTo(this, n) throws IAE
913     */
914    public void testDrainToSelfN() {
915        DelayQueue q = populatedQueue(SIZE);
916        try {
917            q.drainTo(q, 0);
918            shouldThrow();
919        } catch (IllegalArgumentException success) {}
920    }
921
922    /**
761       * drainTo(c, n) empties first min(n, size) elements of queue into c
762       */
763      public void testDrainToN() {
# Line 928 | Line 766 | public class DelayQueueTest extends JSR1
766              ArrayList l = new ArrayList();
767              q.drainTo(l, i);
768              int k = (i < SIZE) ? i : SIZE;
769 <            assertEquals(q.size(), SIZE-k);
770 <            assertEquals(l.size(), k);
769 >            assertEquals(SIZE-k, q.size());
770 >            assertEquals(k, l.size());
771          }
772      }
773  
936
774   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines