ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/DelayQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/DelayQueueTest.java (file contents):
Revision 1.6 by dl, Sun Oct 5 23:00:40 2003 UTC vs.
Revision 1.69 by jsr166, Sun Feb 22 04:34:44 2015 UTC

# Line 1 | Line 1
1   /*
2 < * Written by members of JCP JSR-166 Expert Group and released to the
3 < * public domain. Use, modify, and redistribute this code in any way
4 < * without acknowledgement. Other contributors include Andrew Wright,
5 < * Jeffrey Hayes, Pat Fischer, Mike Judd.
2 > * Written by Doug Lea with assistance from members of JCP JSR-166
3 > * Expert Group and released to the public domain, as explained at
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5 > * Other contributors include Andrew Wright, Jeffrey Hayes,
6 > * Pat Fisher, Mike Judd.
7   */
8  
9 < import junit.framework.*;
10 < import java.util.*;
11 < import java.util.concurrent.*;
9 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 >
11 > import java.util.ArrayList;
12 > import java.util.Arrays;
13 > import java.util.Collection;
14 > import java.util.Iterator;
15 > import java.util.NoSuchElementException;
16 > import java.util.concurrent.BlockingQueue;
17 > import java.util.concurrent.CountDownLatch;
18 > import java.util.concurrent.Delayed;
19 > import java.util.concurrent.DelayQueue;
20 > import java.util.concurrent.Executors;
21 > import java.util.concurrent.ExecutorService;
22 > import java.util.concurrent.TimeUnit;
23 >
24 > import junit.framework.Test;
25  
26   public class DelayQueueTest extends JSR166TestCase {
27 +
28 +    public static class Generic extends BlockingQueueTest {
29 +        protected BlockingQueue emptyCollection() {
30 +            return new DelayQueue();
31 +        }
32 +        protected PDelay makeElement(int i) {
33 +            return new PDelay(i);
34 +        }
35 +    }
36 +
37      public static void main(String[] args) {
38 <        junit.textui.TestRunner.run (suite());  
38 >        junit.textui.TestRunner.run(suite());
39      }
40  
41      public static Test suite() {
42 <        return new TestSuite(DelayQueueTest.class);
42 >        return newTestSuite(DelayQueueTest.class,
43 >                            new Generic().testSuite());
44      }
45  
46      private static final int NOCAP = Integer.MAX_VALUE;
47  
48      /**
49 <     * A delayed implmentation for testing.
50 <     * Most  tests use Pseudodelays, where delays are all elapsed
49 >     * A delayed implementation for testing.
50 >     * Most tests use Pseudodelays, where delays are all elapsed
51       * (so, no blocking solely for delays) but are still ordered
52 <     */
53 <    static class PDelay implements Delayed {
52 >     */
53 >    static class PDelay implements Delayed {
54          int pseudodelay;
55 <        PDelay(int i) { pseudodelay = Integer.MIN_VALUE + i; }
56 <        public int compareTo(Object y) {
57 <            int i = pseudodelay;
58 <            int j = ((PDelay)y).pseudodelay;
59 <            if (i < j) return -1;
35 <            if (i > j) return 1;
36 <            return 0;
55 >        PDelay(int i) { pseudodelay = i; }
56 >        public int compareTo(PDelay other) {
57 >            int a = this.pseudodelay;
58 >            int b = other.pseudodelay;
59 >            return (a < b) ? -1 : (a > b) ? 1 : 0;
60          }
61 <
62 <        public int compareTo(PDelay y) {
40 <            int i = pseudodelay;
41 <            int j = ((PDelay)y).pseudodelay;
42 <            if (i < j) return -1;
43 <            if (i > j) return 1;
44 <            return 0;
61 >        public int compareTo(Delayed y) {
62 >            return compareTo((PDelay)y);
63          }
46
64          public boolean equals(Object other) {
65 <            return ((PDelay)other).pseudodelay == pseudodelay;
65 >            return (other instanceof PDelay) &&
66 >                this.pseudodelay == ((PDelay)other).pseudodelay;
67          }
68 <        public boolean equals(PDelay other) {
69 <            return ((PDelay)other).pseudodelay == pseudodelay;
52 <        }
53 <
54 <
68 >        // suppress [overrides] javac warning
69 >        public int hashCode() { return pseudodelay; }
70          public long getDelay(TimeUnit ignore) {
71 <            return pseudodelay;
57 <        }
58 <        public int intValue() {
59 <            return pseudodelay;
71 >            return Integer.MIN_VALUE + pseudodelay;
72          }
61
73          public String toString() {
74              return String.valueOf(pseudodelay);
75          }
76      }
77  
67
78      /**
79       * Delayed implementation that actually delays
80       */
81 <    static class NanoDelay implements Delayed {
81 >    static class NanoDelay implements Delayed {
82          long trigger;
83 <        NanoDelay(long i) {
83 >        NanoDelay(long i) {
84              trigger = System.nanoTime() + i;
85          }
86 <        public int compareTo(Object y) {
86 >        public int compareTo(NanoDelay y) {
87              long i = trigger;
88 <            long j = ((NanoDelay)y).trigger;
88 >            long j = y.trigger;
89              if (i < j) return -1;
90              if (i > j) return 1;
91              return 0;
92          }
93  
94 <        public int compareTo(NanoDelay y) {
95 <            long i = trigger;
86 <            long j = ((NanoDelay)y).trigger;
87 <            if (i < j) return -1;
88 <            if (i > j) return 1;
89 <            return 0;
94 >        public int compareTo(Delayed y) {
95 >            return compareTo((NanoDelay)y);
96          }
97  
98          public boolean equals(Object other) {
99 <            return ((NanoDelay)other).trigger == trigger;
99 >            return equals((NanoDelay)other);
100          }
101          public boolean equals(NanoDelay other) {
102 <            return ((NanoDelay)other).trigger == trigger;
102 >            return other.trigger == trigger;
103          }
104  
105 +        // suppress [overrides] javac warning
106 +        public int hashCode() { return (int) trigger; }
107 +
108          public long getDelay(TimeUnit unit) {
109              long n = trigger - System.nanoTime();
110              return unit.convert(n, TimeUnit.NANOSECONDS);
# Line 110 | Line 119 | public class DelayQueueTest extends JSR1
119          }
120      }
121  
113
122      /**
123 <     * Create a queue of given size containing consecutive
123 >     * Returns a new queue of given size containing consecutive
124       * PDelays 0 ... n.
125       */
126 <    private DelayQueue populatedQueue(int n) {
127 <        DelayQueue q = new DelayQueue();
126 >    private DelayQueue<PDelay> populatedQueue(int n) {
127 >        DelayQueue<PDelay> q = new DelayQueue<PDelay>();
128          assertTrue(q.isEmpty());
129 <        for(int i = n-1; i >= 0; i-=2)
130 <            assertTrue(q.offer(new PDelay(i)));
131 <        for(int i = (n & 1); i < n; i+=2)
132 <            assertTrue(q.offer(new PDelay(i)));
129 >        for (int i = n-1; i >= 0; i -= 2)
130 >            assertTrue(q.offer(new PDelay(i)));
131 >        for (int i = (n & 1); i < n; i += 2)
132 >            assertTrue(q.offer(new PDelay(i)));
133          assertFalse(q.isEmpty());
134          assertEquals(NOCAP, q.remainingCapacity());
135 <        assertEquals(n, q.size());
135 >        assertEquals(n, q.size());
136          return q;
137      }
138 <
138 >
139      /**
140       * A new queue has unbounded capacity
141       */
# Line 140 | Line 148 | public class DelayQueueTest extends JSR1
148       */
149      public void testConstructor3() {
150          try {
151 <            DelayQueue q = new DelayQueue(null);
151 >            new DelayQueue(null);
152              shouldThrow();
153 <        }
146 <        catch (NullPointerException success) {}
153 >        } catch (NullPointerException success) {}
154      }
155  
156      /**
# Line 152 | Line 159 | public class DelayQueueTest extends JSR1
159      public void testConstructor4() {
160          try {
161              PDelay[] ints = new PDelay[SIZE];
162 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
162 >            new DelayQueue(Arrays.asList(ints));
163              shouldThrow();
164 <        }
158 <        catch (NullPointerException success) {}
164 >        } catch (NullPointerException success) {}
165      }
166  
167      /**
# Line 166 | Line 172 | public class DelayQueueTest extends JSR1
172              PDelay[] ints = new PDelay[SIZE];
173              for (int i = 0; i < SIZE-1; ++i)
174                  ints[i] = new PDelay(i);
175 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
175 >            new DelayQueue(Arrays.asList(ints));
176              shouldThrow();
177 <        }
172 <        catch (NullPointerException success) {}
177 >        } catch (NullPointerException success) {}
178      }
179  
180      /**
181       * Queue contains all elements of collection used to initialize
182       */
183      public void testConstructor6() {
184 <        try {
185 <            PDelay[] ints = new PDelay[SIZE];
186 <            for (int i = 0; i < SIZE; ++i)
187 <                ints[i] = new PDelay(i);
188 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
189 <            for (int i = 0; i < SIZE; ++i)
185 <                assertEquals(ints[i], q.poll());
186 <        }
187 <        finally {}
184 >        PDelay[] ints = new PDelay[SIZE];
185 >        for (int i = 0; i < SIZE; ++i)
186 >            ints[i] = new PDelay(i);
187 >        DelayQueue q = new DelayQueue(Arrays.asList(ints));
188 >        for (int i = 0; i < SIZE; ++i)
189 >            assertEquals(ints[i], q.poll());
190      }
191  
192      /**
# Line 203 | Line 205 | public class DelayQueueTest extends JSR1
205      }
206  
207      /**
208 <     * remainingCapacity does not change when elementa added or removed,
208 >     * remainingCapacity does not change when elements added or removed,
209       * but size does
210       */
211      public void testRemainingCapacity() {
# Line 221 | Line 223 | public class DelayQueueTest extends JSR1
223      }
224  
225      /**
224     * offer(null) throws NPE
225     */
226    public void testOfferNull() {
227        try {
228            DelayQueue q = new DelayQueue();
229            q.offer(null);
230            shouldThrow();
231        } catch (NullPointerException success) { }  
232    }
233
234    /**
235     * add(null) throws NPE
236     */
237    public void testAddNull() {
238        try {
239            DelayQueue q = new DelayQueue();
240            q.add(null);
241            shouldThrow();
242        } catch (NullPointerException success) { }  
243    }
244
245    /**
226       * offer non-null succeeds
227       */
228      public void testOffer() {
# Line 263 | Line 243 | public class DelayQueueTest extends JSR1
243      }
244  
245      /**
266     * addAll(null) throws NPE
267     */
268    public void testAddAll1() {
269        try {
270            DelayQueue q = new DelayQueue();
271            q.addAll(null);
272            shouldThrow();
273        }
274        catch (NullPointerException success) {}
275    }
276
277
278    /**
246       * addAll(this) throws IAE
247       */
248      public void testAddAllSelf() {
# Line 283 | Line 250 | public class DelayQueueTest extends JSR1
250              DelayQueue q = populatedQueue(SIZE);
251              q.addAll(q);
252              shouldThrow();
253 <        }
287 <        catch (IllegalArgumentException success) {}
253 >        } catch (IllegalArgumentException success) {}
254      }
255  
256      /**
291     * addAll of a collection with null elements throws NPE
292     */
293    public void testAddAll2() {
294        try {
295            DelayQueue q = new DelayQueue();
296            PDelay[] ints = new PDelay[SIZE];
297            q.addAll(Arrays.asList(ints));
298            shouldThrow();
299        }
300        catch (NullPointerException success) {}
301    }
302    /**
257       * addAll of a collection with any null elements throws NPE after
258       * possibly adding some elements
259       */
# Line 311 | Line 265 | public class DelayQueueTest extends JSR1
265                  ints[i] = new PDelay(i);
266              q.addAll(Arrays.asList(ints));
267              shouldThrow();
268 <        }
315 <        catch (NullPointerException success) {}
268 >        } catch (NullPointerException success) {}
269      }
270  
271      /**
272       * Queue contains all elements of successful addAll
273       */
274      public void testAddAll5() {
275 <        try {
276 <            PDelay[] empty = new PDelay[0];
277 <            PDelay[] ints = new PDelay[SIZE];
278 <            for (int i = SIZE-1; i >= 0; --i)
279 <                ints[i] = new PDelay(i);
280 <            DelayQueue q = new DelayQueue();
281 <            assertFalse(q.addAll(Arrays.asList(empty)));
282 <            assertTrue(q.addAll(Arrays.asList(ints)));
283 <            for (int i = 0; i < SIZE; ++i)
331 <                assertEquals(ints[i], q.poll());
332 <        }
333 <        finally {}
275 >        PDelay[] empty = new PDelay[0];
276 >        PDelay[] ints = new PDelay[SIZE];
277 >        for (int i = SIZE-1; i >= 0; --i)
278 >            ints[i] = new PDelay(i);
279 >        DelayQueue q = new DelayQueue();
280 >        assertFalse(q.addAll(Arrays.asList(empty)));
281 >        assertTrue(q.addAll(Arrays.asList(ints)));
282 >        for (int i = 0; i < SIZE; ++i)
283 >            assertEquals(ints[i], q.poll());
284      }
285  
286      /**
337     * put(null) throws NPE
338     */
339     public void testPutNull() {
340        try {
341            DelayQueue q = new DelayQueue();
342            q.put(null);
343            shouldThrow();
344        }
345        catch (NullPointerException success){
346        }  
347     }
348
349    /**
287       * all elements successfully put are contained
288       */
289 <     public void testPut() {
290 <         try {
291 <             DelayQueue q = new DelayQueue();
292 <             for (int i = 0; i < SIZE; ++i) {
293 <                 PDelay I = new PDelay(i);
294 <                 q.put(I);
358 <                 assertTrue(q.contains(I));
359 <             }
360 <             assertEquals(SIZE, q.size());
361 <         }
362 <         finally {
289 >    public void testPut() {
290 >        DelayQueue q = new DelayQueue();
291 >        for (int i = 0; i < SIZE; ++i) {
292 >            PDelay x = new PDelay(i);
293 >            q.put(x);
294 >            assertTrue(q.contains(x));
295          }
296 +        assertEquals(SIZE, q.size());
297      }
298  
299      /**
300       * put doesn't block waiting for take
301       */
302 <    public void testPutWithTake() {
302 >    public void testPutWithTake() throws InterruptedException {
303          final DelayQueue q = new DelayQueue();
304 <        Thread t = new Thread(new Runnable() {
305 <                public void run() {
306 <                    int added = 0;
307 <                    try {
308 <                        q.put(new PDelay(0));
309 <                        ++added;
310 <                        q.put(new PDelay(0));
311 <                        ++added;
312 <                        q.put(new PDelay(0));
313 <                        ++added;
381 <                        q.put(new PDelay(0));
382 <                        ++added;
383 <                        threadAssertTrue(added == 4);
384 <                    } finally {
385 <                    }
386 <                }
387 <            });
388 <        try {
389 <            t.start();
390 <            Thread.sleep(SHORT_DELAY_MS);
391 <            q.take();
392 <            t.interrupt();
393 <            t.join();
394 <        } catch (Exception e){
395 <            unexpectedException();
396 <        }
304 >        Thread t = newStartedThread(new CheckedRunnable() {
305 >            public void realRun() {
306 >                q.put(new PDelay(0));
307 >                q.put(new PDelay(0));
308 >                q.put(new PDelay(0));
309 >                q.put(new PDelay(0));
310 >            }});
311 >
312 >        awaitTermination(t);
313 >        assertEquals(4, q.size());
314      }
315  
316      /**
317       * timed offer does not time out
318       */
319 <    public void testTimedOffer() {
319 >    public void testTimedOffer() throws InterruptedException {
320          final DelayQueue q = new DelayQueue();
321 <        Thread t = new Thread(new Runnable() {
322 <                public void run() {
323 <                    try {
324 <                        q.put(new PDelay(0));
325 <                        q.put(new PDelay(0));
326 <                        threadAssertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
327 <                        threadAssertTrue(q.offer(new PDelay(0), LONG_DELAY_MS, TimeUnit.MILLISECONDS));
411 <                    } finally { }
412 <                }
413 <            });
414 <        
415 <        try {
416 <            t.start();
417 <            Thread.sleep(SMALL_DELAY_MS);
418 <            t.interrupt();
419 <            t.join();
420 <        } catch (Exception e){
421 <            unexpectedException();
422 <        }
423 <    }
321 >        Thread t = newStartedThread(new CheckedRunnable() {
322 >            public void realRun() throws InterruptedException {
323 >                q.put(new PDelay(0));
324 >                q.put(new PDelay(0));
325 >                assertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, MILLISECONDS));
326 >                assertTrue(q.offer(new PDelay(0), LONG_DELAY_MS, MILLISECONDS));
327 >            }});
328  
329 <    /**
426 <     * take retrieves elements in priority order
427 <     */
428 <    public void testTake() {
429 <        try {
430 <            DelayQueue q = populatedQueue(SIZE);
431 <            for (int i = 0; i < SIZE; ++i) {
432 <                assertEquals(new PDelay(i), ((PDelay)q.take()));
433 <            }
434 <        } catch (InterruptedException e){
435 <            unexpectedException();
436 <        }  
329 >        awaitTermination(t);
330      }
331  
332      /**
333 <     * take blocks interruptibly when empty
333 >     * take retrieves elements in priority order
334       */
335 <    public void testTakeFromEmpty() {
336 <        final DelayQueue q = new DelayQueue();
337 <        Thread t = new Thread(new Runnable() {
338 <                public void run() {
446 <                    try {
447 <                        q.take();
448 <                        threadShouldThrow();
449 <                    } catch (InterruptedException success){ }                
450 <                }
451 <            });
452 <        try {
453 <            t.start();
454 <            Thread.sleep(SHORT_DELAY_MS);
455 <            t.interrupt();
456 <            t.join();
457 <        } catch (Exception e){
458 <            unexpectedException();
335 >    public void testTake() throws InterruptedException {
336 >        DelayQueue q = populatedQueue(SIZE);
337 >        for (int i = 0; i < SIZE; ++i) {
338 >            assertEquals(new PDelay(i), q.take());
339          }
340      }
341  
342      /**
343       * Take removes existing elements until empty, then blocks interruptibly
344       */
345 <    public void testBlockingTake() {
346 <        Thread t = new Thread(new Runnable() {
347 <                public void run() {
348 <                    try {
349 <                        DelayQueue q = populatedQueue(SIZE);
350 <                        for (int i = 0; i < SIZE; ++i) {
351 <                            threadAssertEquals(new PDelay(i), ((PDelay)q.take()));
352 <                        }
353 <                        q.take();
354 <                        threadShouldThrow();
355 <                    } catch (InterruptedException success){
356 <                    }  
357 <                }});
358 <        t.start();
359 <        try {
480 <           Thread.sleep(SHORT_DELAY_MS);
481 <           t.interrupt();
482 <           t.join();
483 <        }
484 <        catch (InterruptedException ie) {
485 <            unexpectedException();
486 <        }
487 <    }
345 >    public void testBlockingTake() throws InterruptedException {
346 >        final DelayQueue q = populatedQueue(SIZE);
347 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
348 >        Thread t = newStartedThread(new CheckedRunnable() {
349 >            public void realRun() throws InterruptedException {
350 >                for (int i = 0; i < SIZE; ++i) {
351 >                    assertEquals(new PDelay(i), ((PDelay)q.take()));
352 >                }
353 >
354 >                Thread.currentThread().interrupt();
355 >                try {
356 >                    q.take();
357 >                    shouldThrow();
358 >                } catch (InterruptedException success) {}
359 >                assertFalse(Thread.interrupted());
360  
361 +                pleaseInterrupt.countDown();
362 +                try {
363 +                    q.take();
364 +                    shouldThrow();
365 +                } catch (InterruptedException success) {}
366 +                assertFalse(Thread.interrupted());
367 +            }});
368 +
369 +        await(pleaseInterrupt);
370 +        assertThreadStaysAlive(t);
371 +        t.interrupt();
372 +        awaitTermination(t);
373 +    }
374  
375      /**
376       * poll succeeds unless empty
# Line 493 | Line 378 | public class DelayQueueTest extends JSR1
378      public void testPoll() {
379          DelayQueue q = populatedQueue(SIZE);
380          for (int i = 0; i < SIZE; ++i) {
381 <            assertEquals(new PDelay(i), ((PDelay)q.poll()));
381 >            assertEquals(new PDelay(i), q.poll());
382          }
383 <        assertNull(q.poll());
383 >        assertNull(q.poll());
384      }
385  
386      /**
387 <     * timed pool with zero timeout succeeds when non-empty, else times out
387 >     * timed poll with zero timeout succeeds when non-empty, else times out
388       */
389 <    public void testTimedPoll0() {
390 <        try {
391 <            DelayQueue q = populatedQueue(SIZE);
392 <            for (int i = 0; i < SIZE; ++i) {
393 <                assertEquals(new PDelay(i), ((PDelay)q.poll(0, TimeUnit.MILLISECONDS)));
394 <            }
510 <            assertNull(q.poll(0, TimeUnit.MILLISECONDS));
511 <        } catch (InterruptedException e){
512 <            unexpectedException();
513 <        }  
389 >    public void testTimedPoll0() throws InterruptedException {
390 >        DelayQueue q = populatedQueue(SIZE);
391 >        for (int i = 0; i < SIZE; ++i) {
392 >            assertEquals(new PDelay(i), q.poll(0, MILLISECONDS));
393 >        }
394 >        assertNull(q.poll(0, MILLISECONDS));
395      }
396  
397      /**
398 <     * timed pool with nonzero timeout succeeds when non-empty, else times out
398 >     * timed poll with nonzero timeout succeeds when non-empty, else times out
399       */
400 <    public void testTimedPoll() {
401 <        try {
402 <            DelayQueue q = populatedQueue(SIZE);
403 <            for (int i = 0; i < SIZE; ++i) {
404 <                assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)));
405 <            }
406 <            assertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
407 <        } catch (InterruptedException e){
408 <            unexpectedException();
409 <        }  
400 >    public void testTimedPoll() throws InterruptedException {
401 >        DelayQueue q = populatedQueue(SIZE);
402 >        for (int i = 0; i < SIZE; ++i) {
403 >            long startTime = System.nanoTime();
404 >            assertEquals(new PDelay(i), q.poll(LONG_DELAY_MS, MILLISECONDS));
405 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
406 >        }
407 >        long startTime = System.nanoTime();
408 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
409 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
410 >        checkEmpty(q);
411      }
412  
413      /**
414       * Interrupted timed poll throws InterruptedException instead of
415       * returning timeout status
416       */
417 <    public void testInterruptedTimedPoll() {
418 <        Thread t = new Thread(new Runnable() {
419 <                public void run() {
420 <                    try {
421 <                        DelayQueue q = populatedQueue(SIZE);
422 <                        for (int i = 0; i < SIZE; ++i) {
423 <                            threadAssertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)));
542 <                        }
543 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
544 <                    } catch (InterruptedException success){
545 <                    }  
546 <                }});
547 <        t.start();
548 <        try {
549 <           Thread.sleep(SHORT_DELAY_MS);
550 <           t.interrupt();
551 <           t.join();
552 <        }
553 <        catch (InterruptedException ie) {
554 <            unexpectedException();
555 <        }
556 <    }
557 <
558 <    /**
559 <     *  timed poll before a delayed offer fails; after offer succeeds;
560 <     *  on interruption throws
561 <     */
562 <    public void testTimedPollWithOffer() {
563 <        final DelayQueue q = new DelayQueue();
564 <        Thread t = new Thread(new Runnable() {
565 <                public void run() {
566 <                    try {
567 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
568 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
569 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
570 <                        threadFail("Should block");
571 <                    } catch (InterruptedException success) { }                
417 >    public void testInterruptedTimedPoll() throws InterruptedException {
418 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
419 >        Thread t = newStartedThread(new CheckedRunnable() {
420 >            public void realRun() throws InterruptedException {
421 >                DelayQueue q = populatedQueue(SIZE);
422 >                for (int i = 0; i < SIZE; ++i) {
423 >                    assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, MILLISECONDS)));
424                  }
573            });
574        try {
575            t.start();
576            Thread.sleep(SMALL_DELAY_MS);
577            assertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
578            t.interrupt();
579            t.join();
580        } catch (Exception e){
581            unexpectedException();
582        }
583    }  
425  
426 +                Thread.currentThread().interrupt();
427 +                try {
428 +                    q.poll(LONG_DELAY_MS, MILLISECONDS);
429 +                    shouldThrow();
430 +                } catch (InterruptedException success) {}
431 +                assertFalse(Thread.interrupted());
432 +
433 +                pleaseInterrupt.countDown();
434 +                try {
435 +                    q.poll(LONG_DELAY_MS, MILLISECONDS);
436 +                    shouldThrow();
437 +                } catch (InterruptedException success) {}
438 +                assertFalse(Thread.interrupted());
439 +            }});
440 +
441 +        await(pleaseInterrupt);
442 +        assertThreadStaysAlive(t);
443 +        t.interrupt();
444 +        awaitTermination(t);
445 +    }
446  
447      /**
448       * peek returns next element, or null if empty
# Line 589 | Line 450 | public class DelayQueueTest extends JSR1
450      public void testPeek() {
451          DelayQueue q = populatedQueue(SIZE);
452          for (int i = 0; i < SIZE; ++i) {
453 <            assertEquals(new PDelay(i), ((PDelay)q.peek()));
454 <            q.poll();
455 <            assertTrue(q.peek() == null ||
456 <                       i != ((PDelay)q.peek()).intValue());
453 >            assertEquals(new PDelay(i), q.peek());
454 >            assertEquals(new PDelay(i), q.poll());
455 >            if (q.isEmpty())
456 >                assertNull(q.peek());
457 >            else
458 >                assertFalse(new PDelay(i).equals(q.peek()));
459          }
460 <        assertNull(q.peek());
460 >        assertNull(q.peek());
461      }
462  
463      /**
# Line 603 | Line 466 | public class DelayQueueTest extends JSR1
466      public void testElement() {
467          DelayQueue q = populatedQueue(SIZE);
468          for (int i = 0; i < SIZE; ++i) {
469 <            assertEquals(new PDelay(i), ((PDelay)q.element()));
469 >            assertEquals(new PDelay(i), q.element());
470              q.poll();
471          }
472          try {
473              q.element();
474              shouldThrow();
475 <        }
613 <        catch (NoSuchElementException success) {}
475 >        } catch (NoSuchElementException success) {}
476      }
477  
478      /**
# Line 619 | Line 481 | public class DelayQueueTest extends JSR1
481      public void testRemove() {
482          DelayQueue q = populatedQueue(SIZE);
483          for (int i = 0; i < SIZE; ++i) {
484 <            assertEquals(new PDelay(i), ((PDelay)q.remove()));
484 >            assertEquals(new PDelay(i), q.remove());
485          }
486          try {
487              q.remove();
488              shouldThrow();
489 <        } catch (NoSuchElementException success){
628 <        }  
489 >        } catch (NoSuchElementException success) {}
490      }
491  
492      /**
632     * remove(x) removes x and returns true if present
633     */
634    public void testRemoveElement() {
635        DelayQueue q = populatedQueue(SIZE);
636        for (int i = 1; i < SIZE; i+=2) {
637            assertTrue(q.remove(new PDelay(i)));
638        }
639        for (int i = 0; i < SIZE; i+=2) {
640            assertTrue(q.remove(new PDelay(i)));
641            assertFalse(q.remove(new PDelay(i+1)));
642        }
643        assertTrue(q.isEmpty());
644    }
645        
646    /**
493       * contains(x) reports true when elements added but not yet removed
494       */
495      public void testContains() {
# Line 664 | Line 510 | public class DelayQueueTest extends JSR1
510          assertTrue(q.isEmpty());
511          assertEquals(0, q.size());
512          assertEquals(NOCAP, q.remainingCapacity());
513 <        q.add(new PDelay(1));
513 >        PDelay x = new PDelay(1);
514 >        q.add(x);
515          assertFalse(q.isEmpty());
516 +        assertTrue(q.contains(x));
517          q.clear();
518          assertTrue(q.isEmpty());
519      }
# Line 713 | Line 561 | public class DelayQueueTest extends JSR1
561              assertTrue(q.removeAll(p));
562              assertEquals(SIZE-i, q.size());
563              for (int j = 0; j < i; ++j) {
564 <                PDelay I = (PDelay)(p.remove());
565 <                assertFalse(q.contains(I));
564 >                PDelay x = (PDelay)(p.remove());
565 >                assertFalse(q.contains(x));
566              }
567          }
568      }
# Line 722 | Line 570 | public class DelayQueueTest extends JSR1
570      /**
571       * toArray contains all elements
572       */
573 <    public void testToArray() {
573 >    public void testToArray() throws InterruptedException {
574          DelayQueue q = populatedQueue(SIZE);
575 <        Object[] o = q.toArray();
575 >        Object[] o = q.toArray();
576          Arrays.sort(o);
577 <        try {
578 <        for(int i = 0; i < o.length; i++)
731 <            assertEquals(o[i], q.take());
732 <        } catch (InterruptedException e){
733 <            unexpectedException();
734 <        }    
577 >        for (int i = 0; i < o.length; i++)
578 >            assertSame(o[i], q.take());
579      }
580  
581      /**
582       * toArray(a) contains all elements
583       */
584      public void testToArray2() {
585 <        DelayQueue q = populatedQueue(SIZE);
586 <        PDelay[] ints = new PDelay[SIZE];
587 <        ints = (PDelay[])q.toArray(ints);
585 >        DelayQueue<PDelay> q = populatedQueue(SIZE);
586 >        PDelay[] ints = new PDelay[SIZE];
587 >        PDelay[] array = q.toArray(ints);
588 >        assertSame(ints, array);
589          Arrays.sort(ints);
590 <        try {
591 <            for(int i = 0; i < ints.length; i++)
747 <                assertEquals(ints[i], q.take());
748 <        } catch (InterruptedException e){
749 <            unexpectedException();
750 <        }    
590 >        for (int i = 0; i < ints.length; i++)
591 >            assertSame(ints[i], q.remove());
592      }
593  
753
594      /**
595 <     * toArray(null) throws NPE
756 <     */
757 <    public void testToArray_BadArg() {
758 <        try {
759 <            DelayQueue q = populatedQueue(SIZE);
760 <            Object o[] = q.toArray(null);
761 <            shouldThrow();
762 <        } catch(NullPointerException success){}
763 <    }
764 <
765 <    /**
766 <     * toArray with incompatable array type throws CCE
595 >     * toArray(incompatible array type) throws ArrayStoreException
596       */
597      public void testToArray1_BadArg() {
598 <        try {
599 <            DelayQueue q = populatedQueue(SIZE);
600 <            Object o[] = q.toArray(new String[10] );
601 <            shouldThrow();
602 <        } catch(ArrayStoreException  success){}
598 >        DelayQueue q = populatedQueue(SIZE);
599 >        try {
600 >            q.toArray(new String[10]);
601 >            shouldThrow();
602 >        } catch (ArrayStoreException success) {}
603      }
604 <    
604 >
605      /**
606       * iterator iterates through all elements
607       */
608      public void testIterator() {
609          DelayQueue q = populatedQueue(SIZE);
610          int i = 0;
611 <        Iterator it = q.iterator();
612 <        while(it.hasNext()) {
611 >        Iterator it = q.iterator();
612 >        while (it.hasNext()) {
613              assertTrue(q.contains(it.next()));
614              ++i;
615          }
616          assertEquals(i, SIZE);
617 +        assertIteratorExhausted(it);
618 +    }
619 +
620 +    /**
621 +     * iterator of empty collection has no elements
622 +     */
623 +    public void testEmptyIterator() {
624 +        assertIteratorExhausted(new DelayQueue().iterator());
625      }
626  
627      /**
628       * iterator.remove removes current element
629       */
630 <    public void testIteratorRemove () {
630 >    public void testIteratorRemove() {
631          final DelayQueue q = new DelayQueue();
632          q.add(new PDelay(2));
633          q.add(new PDelay(1));
# Line 799 | Line 636 | public class DelayQueueTest extends JSR1
636          it.next();
637          it.remove();
638          it = q.iterator();
639 <        assertEquals(it.next(), new PDelay(2));
640 <        assertEquals(it.next(), new PDelay(3));
639 >        assertEquals(new PDelay(2), it.next());
640 >        assertEquals(new PDelay(3), it.next());
641          assertFalse(it.hasNext());
642      }
643  
807
644      /**
645       * toString contains toStrings of elements
646       */
647      public void testToString() {
648          DelayQueue q = populatedQueue(SIZE);
649          String s = q.toString();
650 <        for (int i = 0; i < SIZE; ++i) {
651 <            assertTrue(s.indexOf(String.valueOf(Integer.MIN_VALUE+i)) >= 0);
652 <        }
817 <    }        
650 >        for (Object e : q)
651 >            assertTrue(s.contains(e.toString()));
652 >    }
653  
654      /**
655 <     * offer transfers elements across Executor tasks
655 >     * timed poll transfers elements across Executor tasks
656       */
657      public void testPollInExecutor() {
658          final DelayQueue q = new DelayQueue();
659 +        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
660          ExecutorService executor = Executors.newFixedThreadPool(2);
661 <        executor.execute(new Runnable() {
662 <            public void run() {
663 <                threadAssertNull(q.poll());
664 <                try {
665 <                    threadAssertTrue(null != q.poll(MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS));
666 <                    threadAssertTrue(q.isEmpty());
667 <                }
668 <                catch (InterruptedException e) {
669 <                    threadUnexpectedException();
670 <                }
671 <            }
672 <        });
661 >        executor.execute(new CheckedRunnable() {
662 >            public void realRun() throws InterruptedException {
663 >                assertNull(q.poll());
664 >                threadsStarted.await();
665 >                assertNotNull(q.poll(LONG_DELAY_MS, MILLISECONDS));
666 >                checkEmpty(q);
667 >            }});
668 >
669 >        executor.execute(new CheckedRunnable() {
670 >            public void realRun() throws InterruptedException {
671 >                threadsStarted.await();
672 >                q.put(new PDelay(1));
673 >            }});
674  
838        executor.execute(new Runnable() {
839            public void run() {
840                try {
841                    Thread.sleep(SHORT_DELAY_MS);
842                    q.put(new PDelay(1));
843                }
844                catch (InterruptedException e) {
845                    threadUnexpectedException();
846                }
847            }
848        });
675          joinPool(executor);
850
676      }
677  
853
678      /**
679 <     * Dekayed actions do not occur until their delay elapses
679 >     * Delayed actions do not occur until their delay elapses
680       */
681 <    public void testDelay() {
682 <        DelayQueue q = new DelayQueue();
683 <        NanoDelay[] elements = new NanoDelay[SIZE];
684 <        for (int i = 0; i < SIZE; ++i) {
685 <            elements[i] = new NanoDelay(1000000000L + 1000000L * (SIZE - i));
686 <        }
687 <        for (int i = 0; i < SIZE; ++i) {
688 <            q.add(elements[i]);
689 <        }
690 <
691 <        try {
692 <            long last = 0;
693 <            for (int i = 0; i < SIZE; ++i) {
870 <                NanoDelay e = (NanoDelay)(q.take());
871 <                long tt = e.getTriggerTime();
872 <                assertTrue(tt <= System.nanoTime());
873 <                if (i != 0)
874 <                    assertTrue(tt >= last);
875 <                last = tt;
876 <            }
877 <        }
878 <        catch(InterruptedException ie) {
879 <            unexpectedException();
681 >    public void testDelay() throws InterruptedException {
682 >        DelayQueue<NanoDelay> q = new DelayQueue<NanoDelay>();
683 >        for (int i = 0; i < SIZE; ++i)
684 >            q.add(new NanoDelay(1000000L * (SIZE - i)));
685 >
686 >        long last = 0;
687 >        for (int i = 0; i < SIZE; ++i) {
688 >            NanoDelay e = q.take();
689 >            long tt = e.getTriggerTime();
690 >            assertTrue(System.nanoTime() - tt >= 0);
691 >            if (i != 0)
692 >                assertTrue(tt >= last);
693 >            last = tt;
694          }
695 +        assertTrue(q.isEmpty());
696      }
697  
698 +    /**
699 +     * peek of a non-empty queue returns non-null even if not expired
700 +     */
701 +    public void testPeekDelayed() {
702 +        DelayQueue q = new DelayQueue();
703 +        q.add(new NanoDelay(Long.MAX_VALUE));
704 +        assertNotNull(q.peek());
705 +    }
706  
707      /**
708 <     * drainTo(null) throws NPE
709 <     */
710 <    public void testDrainToNull() {
711 <        DelayQueue q = populatedQueue(SIZE);
712 <        try {
713 <            q.drainTo(null);
891 <            shouldThrow();
892 <        } catch(NullPointerException success) {
893 <        }
708 >     * poll of a non-empty queue returns null if no expired elements.
709 >     */
710 >    public void testPollDelayed() {
711 >        DelayQueue q = new DelayQueue();
712 >        q.add(new NanoDelay(Long.MAX_VALUE));
713 >        assertNull(q.poll());
714      }
715  
716      /**
717 <     * drainTo(this) throws IAE
718 <     */
719 <    public void testDrainToSelf() {
720 <        DelayQueue q = populatedQueue(SIZE);
721 <        try {
722 <            q.drainTo(q);
903 <            shouldThrow();
904 <        } catch(IllegalArgumentException success) {
905 <        }
717 >     * timed poll of a non-empty queue returns null if no expired elements.
718 >     */
719 >    public void testTimedPollDelayed() throws InterruptedException {
720 >        DelayQueue q = new DelayQueue();
721 >        q.add(new NanoDelay(LONG_DELAY_MS * 1000000L));
722 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
723      }
724  
725      /**
726       * drainTo(c) empties queue into another collection c
727 <     */
727 >     */
728      public void testDrainTo() {
729 <        DelayQueue q = populatedQueue(SIZE);
729 >        DelayQueue q = new DelayQueue();
730 >        PDelay[] elems = new PDelay[SIZE];
731 >        for (int i = 0; i < SIZE; ++i) {
732 >            elems[i] = new PDelay(i);
733 >            q.add(elems[i]);
734 >        }
735          ArrayList l = new ArrayList();
736          q.drainTo(l);
737 <        assertEquals(q.size(), 0);
738 <        assertEquals(l.size(), SIZE);
737 >        assertEquals(0, q.size());
738 >        for (int i = 0; i < SIZE; ++i)
739 >            assertEquals(elems[i], l.get(i));
740 >        q.add(elems[0]);
741 >        q.add(elems[1]);
742 >        assertFalse(q.isEmpty());
743 >        assertTrue(q.contains(elems[0]));
744 >        assertTrue(q.contains(elems[1]));
745 >        l.clear();
746 >        q.drainTo(l);
747 >        assertEquals(0, q.size());
748 >        assertEquals(2, l.size());
749 >        for (int i = 0; i < 2; ++i)
750 >            assertEquals(elems[i], l.get(i));
751      }
752  
753      /**
754       * drainTo empties queue
755 <     */
756 <    public void testDrainToWithActivePut() {
755 >     */
756 >    public void testDrainToWithActivePut() throws InterruptedException {
757          final DelayQueue q = populatedQueue(SIZE);
758 <        Thread t = new Thread(new Runnable() {
759 <                public void run() {
760 <                    q.put(new PDelay(SIZE+1));
761 <                }
928 <            });
929 <        try {
930 <            t.start();
931 <            ArrayList l = new ArrayList();
932 <            q.drainTo(l);
933 <            assertTrue(l.size() >= SIZE);
934 <            t.join();
935 <            assertTrue(q.size() + l.size() == SIZE+1);
936 <        } catch(Exception e){
937 <            unexpectedException();
938 <        }
939 <    }
940 <
941 <    /**
942 <     * drainTo(null, n) throws NPE
943 <     */
944 <    public void testDrainToNullN() {
945 <        DelayQueue q = populatedQueue(SIZE);
946 <        try {
947 <            q.drainTo(null, 0);
948 <            shouldThrow();
949 <        } catch(NullPointerException success) {
950 <        }
951 <    }
758 >        Thread t = new Thread(new CheckedRunnable() {
759 >            public void realRun() {
760 >                q.put(new PDelay(SIZE+1));
761 >            }});
762  
763 <    /**
764 <     * drainTo(this, n) throws IAE
765 <     */
766 <    public void testDrainToSelfN() {
767 <        DelayQueue q = populatedQueue(SIZE);
768 <        try {
959 <            q.drainTo(q, 0);
960 <            shouldThrow();
961 <        } catch(IllegalArgumentException success) {
962 <        }
763 >        t.start();
764 >        ArrayList l = new ArrayList();
765 >        q.drainTo(l);
766 >        assertTrue(l.size() >= SIZE);
767 >        t.join();
768 >        assertTrue(q.size() + l.size() >= SIZE);
769      }
770  
771      /**
772 <     * drainTo(c, n) empties first max {n, size} elements of queue into c
773 <     */
772 >     * drainTo(c, n) empties first min(n, size) elements of queue into c
773 >     */
774      public void testDrainToN() {
775          for (int i = 0; i < SIZE + 2; ++i) {
776              DelayQueue q = populatedQueue(SIZE);
777              ArrayList l = new ArrayList();
778              q.drainTo(l, i);
779 <            int k = (i < SIZE)? i : SIZE;
780 <            assertEquals(q.size(), SIZE-k);
781 <            assertEquals(l.size(), k);
779 >            int k = (i < SIZE) ? i : SIZE;
780 >            assertEquals(SIZE-k, q.size());
781 >            assertEquals(k, l.size());
782          }
783      }
784  
785 <
785 >    /**
786 >     * remove(null), contains(null) always return false
787 >     */
788 >    public void testNeverContainsNull() {
789 >        Collection<?> q = populatedQueue(SIZE);
790 >        assertFalse(q.contains(null));
791 >        assertFalse(q.remove(null));
792 >    }
793   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines