ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/DelayQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/DelayQueueTest.java (file contents):
Revision 1.6 by dl, Sun Oct 5 23:00:40 2003 UTC vs.
Revision 1.78 by jsr166, Sun Oct 16 20:44:18 2016 UTC

# Line 1 | Line 1
1   /*
2 < * Written by members of JCP JSR-166 Expert Group and released to the
3 < * public domain. Use, modify, and redistribute this code in any way
4 < * without acknowledgement. Other contributors include Andrew Wright,
5 < * Jeffrey Hayes, Pat Fischer, Mike Judd.
2 > * Written by Doug Lea with assistance from members of JCP JSR-166
3 > * Expert Group and released to the public domain, as explained at
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5 > * Other contributors include Andrew Wright, Jeffrey Hayes,
6 > * Pat Fisher, Mike Judd.
7   */
8  
9 < import junit.framework.*;
10 < import java.util.*;
11 < import java.util.concurrent.*;
9 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 >
11 > import java.util.ArrayList;
12 > import java.util.Arrays;
13 > import java.util.Collection;
14 > import java.util.Iterator;
15 > import java.util.NoSuchElementException;
16 > import java.util.concurrent.BlockingQueue;
17 > import java.util.concurrent.CountDownLatch;
18 > import java.util.concurrent.Delayed;
19 > import java.util.concurrent.DelayQueue;
20 > import java.util.concurrent.Executors;
21 > import java.util.concurrent.ExecutorService;
22 > import java.util.concurrent.TimeUnit;
23 >
24 > import junit.framework.Test;
25  
26   public class DelayQueueTest extends JSR166TestCase {
27 +
28 +    public static class Generic extends BlockingQueueTest {
29 +        protected BlockingQueue emptyCollection() {
30 +            return new DelayQueue();
31 +        }
32 +        protected PDelay makeElement(int i) {
33 +            return new PDelay(i);
34 +        }
35 +    }
36 +
37      public static void main(String[] args) {
38 <        junit.textui.TestRunner.run (suite());  
38 >        main(suite(), args);
39      }
40  
41      public static Test suite() {
42 <        return new TestSuite(DelayQueueTest.class);
42 >        return newTestSuite(DelayQueueTest.class,
43 >                            new Generic().testSuite());
44      }
45  
21    private static final int NOCAP = Integer.MAX_VALUE;
22
46      /**
47 <     * A delayed implmentation for testing.
48 <     * Most  tests use Pseudodelays, where delays are all elapsed
47 >     * A delayed implementation for testing.
48 >     * Most tests use Pseudodelays, where delays are all elapsed
49       * (so, no blocking solely for delays) but are still ordered
50 <     */
51 <    static class PDelay implements Delayed {
50 >     */
51 >    static class PDelay implements Delayed {
52          int pseudodelay;
53 <        PDelay(int i) { pseudodelay = Integer.MIN_VALUE + i; }
54 <        public int compareTo(Object y) {
55 <            int i = pseudodelay;
56 <            int j = ((PDelay)y).pseudodelay;
57 <            if (i < j) return -1;
35 <            if (i > j) return 1;
36 <            return 0;
53 >        PDelay(int i) { pseudodelay = i; }
54 >        public int compareTo(PDelay other) {
55 >            int a = this.pseudodelay;
56 >            int b = other.pseudodelay;
57 >            return (a < b) ? -1 : (a > b) ? 1 : 0;
58          }
59 <
60 <        public int compareTo(PDelay y) {
40 <            int i = pseudodelay;
41 <            int j = ((PDelay)y).pseudodelay;
42 <            if (i < j) return -1;
43 <            if (i > j) return 1;
44 <            return 0;
59 >        public int compareTo(Delayed y) {
60 >            return compareTo((PDelay)y);
61          }
46
62          public boolean equals(Object other) {
63 <            return ((PDelay)other).pseudodelay == pseudodelay;
64 <        }
50 <        public boolean equals(PDelay other) {
51 <            return ((PDelay)other).pseudodelay == pseudodelay;
63 >            return (other instanceof PDelay) &&
64 >                this.pseudodelay == ((PDelay)other).pseudodelay;
65          }
66 <
67 <
66 >        // suppress [overrides] javac warning
67 >        public int hashCode() { return pseudodelay; }
68          public long getDelay(TimeUnit ignore) {
69 <            return pseudodelay;
69 >            return Integer.MIN_VALUE + pseudodelay;
70          }
58        public int intValue() {
59            return pseudodelay;
60        }
61
71          public String toString() {
72              return String.valueOf(pseudodelay);
73          }
74      }
75  
67
76      /**
77       * Delayed implementation that actually delays
78       */
79 <    static class NanoDelay implements Delayed {
79 >    static class NanoDelay implements Delayed {
80          long trigger;
81 <        NanoDelay(long i) {
81 >        NanoDelay(long i) {
82              trigger = System.nanoTime() + i;
83          }
84 <        public int compareTo(Object y) {
84 >        public int compareTo(NanoDelay y) {
85              long i = trigger;
86 <            long j = ((NanoDelay)y).trigger;
86 >            long j = y.trigger;
87              if (i < j) return -1;
88              if (i > j) return 1;
89              return 0;
90          }
91  
92 <        public int compareTo(NanoDelay y) {
93 <            long i = trigger;
86 <            long j = ((NanoDelay)y).trigger;
87 <            if (i < j) return -1;
88 <            if (i > j) return 1;
89 <            return 0;
92 >        public int compareTo(Delayed y) {
93 >            return compareTo((NanoDelay)y);
94          }
95  
96          public boolean equals(Object other) {
97 <            return ((NanoDelay)other).trigger == trigger;
98 <        }
95 <        public boolean equals(NanoDelay other) {
96 <            return ((NanoDelay)other).trigger == trigger;
97 >            return (other instanceof NanoDelay) &&
98 >                this.trigger == ((NanoDelay)other).trigger;
99          }
100  
101 +        // suppress [overrides] javac warning
102 +        public int hashCode() { return (int) trigger; }
103 +
104          public long getDelay(TimeUnit unit) {
105              long n = trigger - System.nanoTime();
106              return unit.convert(n, TimeUnit.NANOSECONDS);
# Line 110 | Line 115 | public class DelayQueueTest extends JSR1
115          }
116      }
117  
113
118      /**
119 <     * Create a queue of given size containing consecutive
120 <     * PDelays 0 ... n.
119 >     * Returns a new queue of given size containing consecutive
120 >     * PDelays 0 ... n - 1.
121       */
122 <    private DelayQueue populatedQueue(int n) {
123 <        DelayQueue q = new DelayQueue();
122 >    private DelayQueue<PDelay> populatedQueue(int n) {
123 >        DelayQueue<PDelay> q = new DelayQueue<PDelay>();
124          assertTrue(q.isEmpty());
125 <        for(int i = n-1; i >= 0; i-=2)
126 <            assertTrue(q.offer(new PDelay(i)));
127 <        for(int i = (n & 1); i < n; i+=2)
128 <            assertTrue(q.offer(new PDelay(i)));
125 >        for (int i = n - 1; i >= 0; i -= 2)
126 >            assertTrue(q.offer(new PDelay(i)));
127 >        for (int i = (n & 1); i < n; i += 2)
128 >            assertTrue(q.offer(new PDelay(i)));
129          assertFalse(q.isEmpty());
130 <        assertEquals(NOCAP, q.remainingCapacity());
131 <        assertEquals(n, q.size());
130 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
131 >        assertEquals(n, q.size());
132 >        assertEquals(new PDelay(0), q.peek());
133          return q;
134      }
135 <
135 >
136      /**
137       * A new queue has unbounded capacity
138       */
139      public void testConstructor1() {
140 <        assertEquals(NOCAP, new DelayQueue().remainingCapacity());
140 >        assertEquals(Integer.MAX_VALUE, new DelayQueue().remainingCapacity());
141      }
142  
143      /**
# Line 140 | Line 145 | public class DelayQueueTest extends JSR1
145       */
146      public void testConstructor3() {
147          try {
148 <            DelayQueue q = new DelayQueue(null);
148 >            new DelayQueue(null);
149              shouldThrow();
150 <        }
146 <        catch (NullPointerException success) {}
150 >        } catch (NullPointerException success) {}
151      }
152  
153      /**
# Line 151 | Line 155 | public class DelayQueueTest extends JSR1
155       */
156      public void testConstructor4() {
157          try {
158 <            PDelay[] ints = new PDelay[SIZE];
155 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
158 >            new DelayQueue(Arrays.asList(new PDelay[SIZE]));
159              shouldThrow();
160 <        }
158 <        catch (NullPointerException success) {}
160 >        } catch (NullPointerException success) {}
161      }
162  
163      /**
164       * Initializing from Collection with some null elements throws NPE
165       */
166      public void testConstructor5() {
167 +        PDelay[] a = new PDelay[SIZE];
168 +        for (int i = 0; i < SIZE - 1; ++i)
169 +            a[i] = new PDelay(i);
170          try {
171 <            PDelay[] ints = new PDelay[SIZE];
167 <            for (int i = 0; i < SIZE-1; ++i)
168 <                ints[i] = new PDelay(i);
169 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
171 >            new DelayQueue(Arrays.asList(a));
172              shouldThrow();
173 <        }
172 <        catch (NullPointerException success) {}
173 >        } catch (NullPointerException success) {}
174      }
175  
176      /**
177       * Queue contains all elements of collection used to initialize
178       */
179      public void testConstructor6() {
180 <        try {
181 <            PDelay[] ints = new PDelay[SIZE];
182 <            for (int i = 0; i < SIZE; ++i)
183 <                ints[i] = new PDelay(i);
184 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
185 <            for (int i = 0; i < SIZE; ++i)
185 <                assertEquals(ints[i], q.poll());
186 <        }
187 <        finally {}
180 >        PDelay[] ints = new PDelay[SIZE];
181 >        for (int i = 0; i < SIZE; ++i)
182 >            ints[i] = new PDelay(i);
183 >        DelayQueue q = new DelayQueue(Arrays.asList(ints));
184 >        for (int i = 0; i < SIZE; ++i)
185 >            assertEquals(ints[i], q.poll());
186      }
187  
188      /**
# Line 193 | Line 191 | public class DelayQueueTest extends JSR1
191      public void testEmpty() {
192          DelayQueue q = new DelayQueue();
193          assertTrue(q.isEmpty());
194 <        assertEquals(NOCAP, q.remainingCapacity());
194 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
195          q.add(new PDelay(1));
196          assertFalse(q.isEmpty());
197          q.add(new PDelay(2));
# Line 203 | Line 201 | public class DelayQueueTest extends JSR1
201      }
202  
203      /**
204 <     * remainingCapacity does not change when elementa added or removed,
207 <     * but size does
204 >     * remainingCapacity() always returns Integer.MAX_VALUE
205       */
206      public void testRemainingCapacity() {
207 <        DelayQueue q = populatedQueue(SIZE);
207 >        BlockingQueue q = populatedQueue(SIZE);
208          for (int i = 0; i < SIZE; ++i) {
209 <            assertEquals(NOCAP, q.remainingCapacity());
210 <            assertEquals(SIZE-i, q.size());
211 <            q.remove();
209 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
210 >            assertEquals(SIZE - i, q.size());
211 >            assertTrue(q.remove() instanceof PDelay);
212          }
213          for (int i = 0; i < SIZE; ++i) {
214 <            assertEquals(NOCAP, q.remainingCapacity());
214 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
215              assertEquals(i, q.size());
216 <            q.add(new PDelay(i));
216 >            assertTrue(q.add(new PDelay(i)));
217          }
218      }
219  
220      /**
224     * offer(null) throws NPE
225     */
226    public void testOfferNull() {
227        try {
228            DelayQueue q = new DelayQueue();
229            q.offer(null);
230            shouldThrow();
231        } catch (NullPointerException success) { }  
232    }
233
234    /**
235     * add(null) throws NPE
236     */
237    public void testAddNull() {
238        try {
239            DelayQueue q = new DelayQueue();
240            q.add(null);
241            shouldThrow();
242        } catch (NullPointerException success) { }  
243    }
244
245    /**
221       * offer non-null succeeds
222       */
223      public void testOffer() {
# Line 263 | Line 238 | public class DelayQueueTest extends JSR1
238      }
239  
240      /**
266     * addAll(null) throws NPE
267     */
268    public void testAddAll1() {
269        try {
270            DelayQueue q = new DelayQueue();
271            q.addAll(null);
272            shouldThrow();
273        }
274        catch (NullPointerException success) {}
275    }
276
277
278    /**
241       * addAll(this) throws IAE
242       */
243      public void testAddAllSelf() {
244 +        DelayQueue q = populatedQueue(SIZE);
245          try {
283            DelayQueue q = populatedQueue(SIZE);
246              q.addAll(q);
247              shouldThrow();
248 <        }
287 <        catch (IllegalArgumentException success) {}
248 >        } catch (IllegalArgumentException success) {}
249      }
250  
251      /**
291     * addAll of a collection with null elements throws NPE
292     */
293    public void testAddAll2() {
294        try {
295            DelayQueue q = new DelayQueue();
296            PDelay[] ints = new PDelay[SIZE];
297            q.addAll(Arrays.asList(ints));
298            shouldThrow();
299        }
300        catch (NullPointerException success) {}
301    }
302    /**
252       * addAll of a collection with any null elements throws NPE after
253       * possibly adding some elements
254       */
255      public void testAddAll3() {
256 +        DelayQueue q = new DelayQueue();
257 +        PDelay[] a = new PDelay[SIZE];
258 +        for (int i = 0; i < SIZE - 1; ++i)
259 +            a[i] = new PDelay(i);
260          try {
261 <            DelayQueue q = new DelayQueue();
309 <            PDelay[] ints = new PDelay[SIZE];
310 <            for (int i = 0; i < SIZE-1; ++i)
311 <                ints[i] = new PDelay(i);
312 <            q.addAll(Arrays.asList(ints));
261 >            q.addAll(Arrays.asList(a));
262              shouldThrow();
263 <        }
315 <        catch (NullPointerException success) {}
263 >        } catch (NullPointerException success) {}
264      }
265  
266      /**
267       * Queue contains all elements of successful addAll
268       */
269      public void testAddAll5() {
270 <        try {
271 <            PDelay[] empty = new PDelay[0];
272 <            PDelay[] ints = new PDelay[SIZE];
273 <            for (int i = SIZE-1; i >= 0; --i)
274 <                ints[i] = new PDelay(i);
275 <            DelayQueue q = new DelayQueue();
276 <            assertFalse(q.addAll(Arrays.asList(empty)));
277 <            assertTrue(q.addAll(Arrays.asList(ints)));
278 <            for (int i = 0; i < SIZE; ++i)
331 <                assertEquals(ints[i], q.poll());
332 <        }
333 <        finally {}
270 >        PDelay[] empty = new PDelay[0];
271 >        PDelay[] ints = new PDelay[SIZE];
272 >        for (int i = SIZE - 1; i >= 0; --i)
273 >            ints[i] = new PDelay(i);
274 >        DelayQueue q = new DelayQueue();
275 >        assertFalse(q.addAll(Arrays.asList(empty)));
276 >        assertTrue(q.addAll(Arrays.asList(ints)));
277 >        for (int i = 0; i < SIZE; ++i)
278 >            assertEquals(ints[i], q.poll());
279      }
280  
281      /**
337     * put(null) throws NPE
338     */
339     public void testPutNull() {
340        try {
341            DelayQueue q = new DelayQueue();
342            q.put(null);
343            shouldThrow();
344        }
345        catch (NullPointerException success){
346        }  
347     }
348
349    /**
282       * all elements successfully put are contained
283       */
284 <     public void testPut() {
285 <         try {
286 <             DelayQueue q = new DelayQueue();
287 <             for (int i = 0; i < SIZE; ++i) {
288 <                 PDelay I = new PDelay(i);
289 <                 q.put(I);
358 <                 assertTrue(q.contains(I));
359 <             }
360 <             assertEquals(SIZE, q.size());
361 <         }
362 <         finally {
284 >    public void testPut() {
285 >        DelayQueue q = new DelayQueue();
286 >        for (int i = 0; i < SIZE; ++i) {
287 >            PDelay x = new PDelay(i);
288 >            q.put(x);
289 >            assertTrue(q.contains(x));
290          }
291 +        assertEquals(SIZE, q.size());
292      }
293  
294      /**
295       * put doesn't block waiting for take
296       */
297 <    public void testPutWithTake() {
297 >    public void testPutWithTake() throws InterruptedException {
298          final DelayQueue q = new DelayQueue();
299 <        Thread t = new Thread(new Runnable() {
300 <                public void run() {
301 <                    int added = 0;
302 <                    try {
303 <                        q.put(new PDelay(0));
304 <                        ++added;
305 <                        q.put(new PDelay(0));
306 <                        ++added;
307 <                        q.put(new PDelay(0));
308 <                        ++added;
381 <                        q.put(new PDelay(0));
382 <                        ++added;
383 <                        threadAssertTrue(added == 4);
384 <                    } finally {
385 <                    }
386 <                }
387 <            });
388 <        try {
389 <            t.start();
390 <            Thread.sleep(SHORT_DELAY_MS);
391 <            q.take();
392 <            t.interrupt();
393 <            t.join();
394 <        } catch (Exception e){
395 <            unexpectedException();
396 <        }
299 >        Thread t = newStartedThread(new CheckedRunnable() {
300 >            public void realRun() {
301 >                q.put(new PDelay(0));
302 >                q.put(new PDelay(0));
303 >                q.put(new PDelay(0));
304 >                q.put(new PDelay(0));
305 >            }});
306 >
307 >        awaitTermination(t);
308 >        assertEquals(4, q.size());
309      }
310  
311      /**
312       * timed offer does not time out
313       */
314 <    public void testTimedOffer() {
314 >    public void testTimedOffer() throws InterruptedException {
315          final DelayQueue q = new DelayQueue();
316 <        Thread t = new Thread(new Runnable() {
317 <                public void run() {
318 <                    try {
319 <                        q.put(new PDelay(0));
320 <                        q.put(new PDelay(0));
321 <                        threadAssertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
322 <                        threadAssertTrue(q.offer(new PDelay(0), LONG_DELAY_MS, TimeUnit.MILLISECONDS));
411 <                    } finally { }
412 <                }
413 <            });
414 <        
415 <        try {
416 <            t.start();
417 <            Thread.sleep(SMALL_DELAY_MS);
418 <            t.interrupt();
419 <            t.join();
420 <        } catch (Exception e){
421 <            unexpectedException();
422 <        }
423 <    }
316 >        Thread t = newStartedThread(new CheckedRunnable() {
317 >            public void realRun() throws InterruptedException {
318 >                q.put(new PDelay(0));
319 >                q.put(new PDelay(0));
320 >                assertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, MILLISECONDS));
321 >                assertTrue(q.offer(new PDelay(0), LONG_DELAY_MS, MILLISECONDS));
322 >            }});
323  
324 <    /**
426 <     * take retrieves elements in priority order
427 <     */
428 <    public void testTake() {
429 <        try {
430 <            DelayQueue q = populatedQueue(SIZE);
431 <            for (int i = 0; i < SIZE; ++i) {
432 <                assertEquals(new PDelay(i), ((PDelay)q.take()));
433 <            }
434 <        } catch (InterruptedException e){
435 <            unexpectedException();
436 <        }  
324 >        awaitTermination(t);
325      }
326  
327      /**
328 <     * take blocks interruptibly when empty
328 >     * take retrieves elements in priority order
329       */
330 <    public void testTakeFromEmpty() {
331 <        final DelayQueue q = new DelayQueue();
332 <        Thread t = new Thread(new Runnable() {
333 <                public void run() {
446 <                    try {
447 <                        q.take();
448 <                        threadShouldThrow();
449 <                    } catch (InterruptedException success){ }                
450 <                }
451 <            });
452 <        try {
453 <            t.start();
454 <            Thread.sleep(SHORT_DELAY_MS);
455 <            t.interrupt();
456 <            t.join();
457 <        } catch (Exception e){
458 <            unexpectedException();
330 >    public void testTake() throws InterruptedException {
331 >        DelayQueue q = populatedQueue(SIZE);
332 >        for (int i = 0; i < SIZE; ++i) {
333 >            assertEquals(new PDelay(i), q.take());
334          }
335      }
336  
337      /**
338       * Take removes existing elements until empty, then blocks interruptibly
339       */
340 <    public void testBlockingTake() {
341 <        Thread t = new Thread(new Runnable() {
342 <                public void run() {
343 <                    try {
344 <                        DelayQueue q = populatedQueue(SIZE);
345 <                        for (int i = 0; i < SIZE; ++i) {
346 <                            threadAssertEquals(new PDelay(i), ((PDelay)q.take()));
347 <                        }
348 <                        q.take();
349 <                        threadShouldThrow();
350 <                    } catch (InterruptedException success){
351 <                    }  
352 <                }});
353 <        t.start();
354 <        try {
480 <           Thread.sleep(SHORT_DELAY_MS);
481 <           t.interrupt();
482 <           t.join();
483 <        }
484 <        catch (InterruptedException ie) {
485 <            unexpectedException();
486 <        }
487 <    }
340 >    public void testBlockingTake() throws InterruptedException {
341 >        final DelayQueue q = populatedQueue(SIZE);
342 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
343 >        Thread t = newStartedThread(new CheckedRunnable() {
344 >            public void realRun() throws InterruptedException {
345 >                for (int i = 0; i < SIZE; ++i) {
346 >                    assertEquals(new PDelay(i), ((PDelay)q.take()));
347 >                }
348 >
349 >                Thread.currentThread().interrupt();
350 >                try {
351 >                    q.take();
352 >                    shouldThrow();
353 >                } catch (InterruptedException success) {}
354 >                assertFalse(Thread.interrupted());
355  
356 +                pleaseInterrupt.countDown();
357 +                try {
358 +                    q.take();
359 +                    shouldThrow();
360 +                } catch (InterruptedException success) {}
361 +                assertFalse(Thread.interrupted());
362 +            }});
363 +
364 +        await(pleaseInterrupt);
365 +        assertThreadStaysAlive(t);
366 +        t.interrupt();
367 +        awaitTermination(t);
368 +    }
369  
370      /**
371       * poll succeeds unless empty
# Line 493 | Line 373 | public class DelayQueueTest extends JSR1
373      public void testPoll() {
374          DelayQueue q = populatedQueue(SIZE);
375          for (int i = 0; i < SIZE; ++i) {
376 <            assertEquals(new PDelay(i), ((PDelay)q.poll()));
376 >            assertEquals(new PDelay(i), q.poll());
377          }
378 <        assertNull(q.poll());
378 >        assertNull(q.poll());
379      }
380  
381      /**
382 <     * timed pool with zero timeout succeeds when non-empty, else times out
382 >     * timed poll with zero timeout succeeds when non-empty, else times out
383       */
384 <    public void testTimedPoll0() {
385 <        try {
386 <            DelayQueue q = populatedQueue(SIZE);
387 <            for (int i = 0; i < SIZE; ++i) {
388 <                assertEquals(new PDelay(i), ((PDelay)q.poll(0, TimeUnit.MILLISECONDS)));
389 <            }
510 <            assertNull(q.poll(0, TimeUnit.MILLISECONDS));
511 <        } catch (InterruptedException e){
512 <            unexpectedException();
513 <        }  
384 >    public void testTimedPoll0() throws InterruptedException {
385 >        DelayQueue q = populatedQueue(SIZE);
386 >        for (int i = 0; i < SIZE; ++i) {
387 >            assertEquals(new PDelay(i), q.poll(0, MILLISECONDS));
388 >        }
389 >        assertNull(q.poll(0, MILLISECONDS));
390      }
391  
392      /**
393 <     * timed pool with nonzero timeout succeeds when non-empty, else times out
393 >     * timed poll with nonzero timeout succeeds when non-empty, else times out
394       */
395 <    public void testTimedPoll() {
396 <        try {
397 <            DelayQueue q = populatedQueue(SIZE);
398 <            for (int i = 0; i < SIZE; ++i) {
399 <                assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)));
400 <            }
401 <            assertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
402 <        } catch (InterruptedException e){
403 <            unexpectedException();
404 <        }  
395 >    public void testTimedPoll() throws InterruptedException {
396 >        DelayQueue q = populatedQueue(SIZE);
397 >        for (int i = 0; i < SIZE; ++i) {
398 >            long startTime = System.nanoTime();
399 >            assertEquals(new PDelay(i), q.poll(LONG_DELAY_MS, MILLISECONDS));
400 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
401 >        }
402 >        long startTime = System.nanoTime();
403 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
404 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
405 >        checkEmpty(q);
406      }
407  
408      /**
409       * Interrupted timed poll throws InterruptedException instead of
410       * returning timeout status
411       */
412 <    public void testInterruptedTimedPoll() {
413 <        Thread t = new Thread(new Runnable() {
414 <                public void run() {
415 <                    try {
416 <                        DelayQueue q = populatedQueue(SIZE);
417 <                        for (int i = 0; i < SIZE; ++i) {
418 <                            threadAssertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)));
419 <                        }
420 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
544 <                    } catch (InterruptedException success){
545 <                    }  
546 <                }});
547 <        t.start();
548 <        try {
549 <           Thread.sleep(SHORT_DELAY_MS);
550 <           t.interrupt();
551 <           t.join();
552 <        }
553 <        catch (InterruptedException ie) {
554 <            unexpectedException();
555 <        }
556 <    }
557 <
558 <    /**
559 <     *  timed poll before a delayed offer fails; after offer succeeds;
560 <     *  on interruption throws
561 <     */
562 <    public void testTimedPollWithOffer() {
563 <        final DelayQueue q = new DelayQueue();
564 <        Thread t = new Thread(new Runnable() {
565 <                public void run() {
566 <                    try {
567 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
568 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
569 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
570 <                        threadFail("Should block");
571 <                    } catch (InterruptedException success) { }                
412 >    public void testInterruptedTimedPoll() throws InterruptedException {
413 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
414 >        final DelayQueue q = populatedQueue(SIZE);
415 >        Thread t = newStartedThread(new CheckedRunnable() {
416 >            public void realRun() throws InterruptedException {
417 >                long startTime = System.nanoTime();
418 >                for (int i = 0; i < SIZE; ++i) {
419 >                    assertEquals(new PDelay(i),
420 >                                 ((PDelay)q.poll(LONG_DELAY_MS, MILLISECONDS)));
421                  }
573            });
574        try {
575            t.start();
576            Thread.sleep(SMALL_DELAY_MS);
577            assertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
578            t.interrupt();
579            t.join();
580        } catch (Exception e){
581            unexpectedException();
582        }
583    }  
422  
423 +                Thread.currentThread().interrupt();
424 +                try {
425 +                    q.poll(LONG_DELAY_MS, MILLISECONDS);
426 +                    shouldThrow();
427 +                } catch (InterruptedException success) {}
428 +                assertFalse(Thread.interrupted());
429 +
430 +                pleaseInterrupt.countDown();
431 +                try {
432 +                    q.poll(LONG_DELAY_MS, MILLISECONDS);
433 +                    shouldThrow();
434 +                } catch (InterruptedException success) {}
435 +                assertFalse(Thread.interrupted());
436 +                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
437 +            }});
438 +
439 +        await(pleaseInterrupt);
440 +        assertThreadStaysAlive(t);
441 +        t.interrupt();
442 +        awaitTermination(t);
443 +        checkEmpty(q);
444 +    }
445  
446      /**
447       * peek returns next element, or null if empty
# Line 589 | Line 449 | public class DelayQueueTest extends JSR1
449      public void testPeek() {
450          DelayQueue q = populatedQueue(SIZE);
451          for (int i = 0; i < SIZE; ++i) {
452 <            assertEquals(new PDelay(i), ((PDelay)q.peek()));
453 <            q.poll();
454 <            assertTrue(q.peek() == null ||
455 <                       i != ((PDelay)q.peek()).intValue());
452 >            assertEquals(new PDelay(i), q.peek());
453 >            assertEquals(new PDelay(i), q.poll());
454 >            if (q.isEmpty())
455 >                assertNull(q.peek());
456 >            else
457 >                assertFalse(new PDelay(i).equals(q.peek()));
458          }
459 <        assertNull(q.peek());
459 >        assertNull(q.peek());
460      }
461  
462      /**
# Line 603 | Line 465 | public class DelayQueueTest extends JSR1
465      public void testElement() {
466          DelayQueue q = populatedQueue(SIZE);
467          for (int i = 0; i < SIZE; ++i) {
468 <            assertEquals(new PDelay(i), ((PDelay)q.element()));
468 >            assertEquals(new PDelay(i), q.element());
469              q.poll();
470          }
471          try {
472              q.element();
473              shouldThrow();
474 <        }
613 <        catch (NoSuchElementException success) {}
474 >        } catch (NoSuchElementException success) {}
475      }
476  
477      /**
# Line 619 | Line 480 | public class DelayQueueTest extends JSR1
480      public void testRemove() {
481          DelayQueue q = populatedQueue(SIZE);
482          for (int i = 0; i < SIZE; ++i) {
483 <            assertEquals(new PDelay(i), ((PDelay)q.remove()));
483 >            assertEquals(new PDelay(i), q.remove());
484          }
485          try {
486              q.remove();
487              shouldThrow();
488 <        } catch (NoSuchElementException success){
628 <        }  
488 >        } catch (NoSuchElementException success) {}
489      }
490  
491      /**
632     * remove(x) removes x and returns true if present
633     */
634    public void testRemoveElement() {
635        DelayQueue q = populatedQueue(SIZE);
636        for (int i = 1; i < SIZE; i+=2) {
637            assertTrue(q.remove(new PDelay(i)));
638        }
639        for (int i = 0; i < SIZE; i+=2) {
640            assertTrue(q.remove(new PDelay(i)));
641            assertFalse(q.remove(new PDelay(i+1)));
642        }
643        assertTrue(q.isEmpty());
644    }
645        
646    /**
492       * contains(x) reports true when elements added but not yet removed
493       */
494      public void testContains() {
# Line 663 | Line 508 | public class DelayQueueTest extends JSR1
508          q.clear();
509          assertTrue(q.isEmpty());
510          assertEquals(0, q.size());
511 <        assertEquals(NOCAP, q.remainingCapacity());
512 <        q.add(new PDelay(1));
511 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
512 >        PDelay x = new PDelay(1);
513 >        q.add(x);
514          assertFalse(q.isEmpty());
515 +        assertTrue(q.contains(x));
516          q.clear();
517          assertTrue(q.isEmpty());
518      }
# Line 698 | Line 545 | public class DelayQueueTest extends JSR1
545                  assertTrue(changed);
546  
547              assertTrue(q.containsAll(p));
548 <            assertEquals(SIZE-i, q.size());
548 >            assertEquals(SIZE - i, q.size());
549              p.remove();
550          }
551      }
# Line 711 | Line 558 | public class DelayQueueTest extends JSR1
558              DelayQueue q = populatedQueue(SIZE);
559              DelayQueue p = populatedQueue(i);
560              assertTrue(q.removeAll(p));
561 <            assertEquals(SIZE-i, q.size());
561 >            assertEquals(SIZE - i, q.size());
562              for (int j = 0; j < i; ++j) {
563 <                PDelay I = (PDelay)(p.remove());
564 <                assertFalse(q.contains(I));
563 >                PDelay x = (PDelay)(p.remove());
564 >                assertFalse(q.contains(x));
565              }
566          }
567      }
# Line 722 | Line 569 | public class DelayQueueTest extends JSR1
569      /**
570       * toArray contains all elements
571       */
572 <    public void testToArray() {
572 >    public void testToArray() throws InterruptedException {
573          DelayQueue q = populatedQueue(SIZE);
574 <        Object[] o = q.toArray();
574 >        Object[] o = q.toArray();
575          Arrays.sort(o);
576 <        try {
577 <        for(int i = 0; i < o.length; i++)
731 <            assertEquals(o[i], q.take());
732 <        } catch (InterruptedException e){
733 <            unexpectedException();
734 <        }    
576 >        for (int i = 0; i < o.length; i++)
577 >            assertSame(o[i], q.take());
578      }
579  
580      /**
581       * toArray(a) contains all elements
582       */
583      public void testToArray2() {
584 <        DelayQueue q = populatedQueue(SIZE);
585 <        PDelay[] ints = new PDelay[SIZE];
586 <        ints = (PDelay[])q.toArray(ints);
584 >        DelayQueue<PDelay> q = populatedQueue(SIZE);
585 >        PDelay[] ints = new PDelay[SIZE];
586 >        PDelay[] array = q.toArray(ints);
587 >        assertSame(ints, array);
588          Arrays.sort(ints);
589 <        try {
590 <            for(int i = 0; i < ints.length; i++)
747 <                assertEquals(ints[i], q.take());
748 <        } catch (InterruptedException e){
749 <            unexpectedException();
750 <        }    
589 >        for (int i = 0; i < ints.length; i++)
590 >            assertSame(ints[i], q.remove());
591      }
592  
753
593      /**
594 <     * toArray(null) throws NPE
756 <     */
757 <    public void testToArray_BadArg() {
758 <        try {
759 <            DelayQueue q = populatedQueue(SIZE);
760 <            Object o[] = q.toArray(null);
761 <            shouldThrow();
762 <        } catch(NullPointerException success){}
763 <    }
764 <
765 <    /**
766 <     * toArray with incompatable array type throws CCE
594 >     * toArray(incompatible array type) throws ArrayStoreException
595       */
596      public void testToArray1_BadArg() {
597 <        try {
598 <            DelayQueue q = populatedQueue(SIZE);
599 <            Object o[] = q.toArray(new String[10] );
600 <            shouldThrow();
601 <        } catch(ArrayStoreException  success){}
597 >        DelayQueue q = populatedQueue(SIZE);
598 >        try {
599 >            q.toArray(new String[10]);
600 >            shouldThrow();
601 >        } catch (ArrayStoreException success) {}
602      }
603 <    
603 >
604      /**
605       * iterator iterates through all elements
606       */
607      public void testIterator() {
608          DelayQueue q = populatedQueue(SIZE);
609          int i = 0;
610 <        Iterator it = q.iterator();
611 <        while(it.hasNext()) {
610 >        Iterator it = q.iterator();
611 >        while (it.hasNext()) {
612              assertTrue(q.contains(it.next()));
613              ++i;
614          }
615          assertEquals(i, SIZE);
616 +        assertIteratorExhausted(it);
617 +    }
618 +
619 +    /**
620 +     * iterator of empty collection has no elements
621 +     */
622 +    public void testEmptyIterator() {
623 +        assertIteratorExhausted(new DelayQueue().iterator());
624      }
625  
626      /**
627       * iterator.remove removes current element
628       */
629 <    public void testIteratorRemove () {
629 >    public void testIteratorRemove() {
630          final DelayQueue q = new DelayQueue();
631          q.add(new PDelay(2));
632          q.add(new PDelay(1));
# Line 799 | Line 635 | public class DelayQueueTest extends JSR1
635          it.next();
636          it.remove();
637          it = q.iterator();
638 <        assertEquals(it.next(), new PDelay(2));
639 <        assertEquals(it.next(), new PDelay(3));
638 >        assertEquals(new PDelay(2), it.next());
639 >        assertEquals(new PDelay(3), it.next());
640          assertFalse(it.hasNext());
641      }
642  
807
643      /**
644       * toString contains toStrings of elements
645       */
646      public void testToString() {
647          DelayQueue q = populatedQueue(SIZE);
648          String s = q.toString();
649 <        for (int i = 0; i < SIZE; ++i) {
650 <            assertTrue(s.indexOf(String.valueOf(Integer.MIN_VALUE+i)) >= 0);
651 <        }
817 <    }        
649 >        for (Object e : q)
650 >            assertTrue(s.contains(e.toString()));
651 >    }
652  
653      /**
654 <     * offer transfers elements across Executor tasks
654 >     * timed poll transfers elements across Executor tasks
655       */
656      public void testPollInExecutor() {
657          final DelayQueue q = new DelayQueue();
658 <        ExecutorService executor = Executors.newFixedThreadPool(2);
659 <        executor.execute(new Runnable() {
660 <            public void run() {
661 <                threadAssertNull(q.poll());
662 <                try {
663 <                    threadAssertTrue(null != q.poll(MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS));
664 <                    threadAssertTrue(q.isEmpty());
665 <                }
666 <                catch (InterruptedException e) {
667 <                    threadUnexpectedException();
834 <                }
835 <            }
836 <        });
658 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
659 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
660 >        try (PoolCleaner cleaner = cleaner(executor)) {
661 >            executor.execute(new CheckedRunnable() {
662 >                public void realRun() throws InterruptedException {
663 >                    assertNull(q.poll());
664 >                    threadsStarted.await();
665 >                    assertNotNull(q.poll(LONG_DELAY_MS, MILLISECONDS));
666 >                    checkEmpty(q);
667 >                }});
668  
669 <        executor.execute(new Runnable() {
670 <            public void run() {
671 <                try {
841 <                    Thread.sleep(SHORT_DELAY_MS);
669 >            executor.execute(new CheckedRunnable() {
670 >                public void realRun() throws InterruptedException {
671 >                    threadsStarted.await();
672                      q.put(new PDelay(1));
673 <                }
674 <                catch (InterruptedException e) {
845 <                    threadUnexpectedException();
846 <                }
847 <            }
848 <        });
849 <        joinPool(executor);
850 <
673 >                }});
674 >        }
675      }
676  
853
677      /**
678 <     * Dekayed actions do not occur until their delay elapses
678 >     * Delayed actions do not occur until their delay elapses
679       */
680 <    public void testDelay() {
681 <        DelayQueue q = new DelayQueue();
682 <        NanoDelay[] elements = new NanoDelay[SIZE];
683 <        for (int i = 0; i < SIZE; ++i) {
684 <            elements[i] = new NanoDelay(1000000000L + 1000000L * (SIZE - i));
685 <        }
686 <        for (int i = 0; i < SIZE; ++i) {
687 <            q.add(elements[i]);
688 <        }
689 <
690 <        try {
691 <            long last = 0;
692 <            for (int i = 0; i < SIZE; ++i) {
870 <                NanoDelay e = (NanoDelay)(q.take());
871 <                long tt = e.getTriggerTime();
872 <                assertTrue(tt <= System.nanoTime());
873 <                if (i != 0)
874 <                    assertTrue(tt >= last);
875 <                last = tt;
876 <            }
877 <        }
878 <        catch(InterruptedException ie) {
879 <            unexpectedException();
680 >    public void testDelay() throws InterruptedException {
681 >        DelayQueue<NanoDelay> q = new DelayQueue<NanoDelay>();
682 >        for (int i = 0; i < SIZE; ++i)
683 >            q.add(new NanoDelay(1000000L * (SIZE - i)));
684 >
685 >        long last = 0;
686 >        for (int i = 0; i < SIZE; ++i) {
687 >            NanoDelay e = q.take();
688 >            long tt = e.getTriggerTime();
689 >            assertTrue(System.nanoTime() - tt >= 0);
690 >            if (i != 0)
691 >                assertTrue(tt >= last);
692 >            last = tt;
693          }
694 +        assertTrue(q.isEmpty());
695      }
696  
697 +    /**
698 +     * peek of a non-empty queue returns non-null even if not expired
699 +     */
700 +    public void testPeekDelayed() {
701 +        DelayQueue q = new DelayQueue();
702 +        q.add(new NanoDelay(Long.MAX_VALUE));
703 +        assertNotNull(q.peek());
704 +    }
705  
706      /**
707 <     * drainTo(null) throws NPE
708 <     */
709 <    public void testDrainToNull() {
710 <        DelayQueue q = populatedQueue(SIZE);
711 <        try {
712 <            q.drainTo(null);
891 <            shouldThrow();
892 <        } catch(NullPointerException success) {
893 <        }
707 >     * poll of a non-empty queue returns null if no expired elements.
708 >     */
709 >    public void testPollDelayed() {
710 >        DelayQueue q = new DelayQueue();
711 >        q.add(new NanoDelay(Long.MAX_VALUE));
712 >        assertNull(q.poll());
713      }
714  
715      /**
716 <     * drainTo(this) throws IAE
717 <     */
718 <    public void testDrainToSelf() {
719 <        DelayQueue q = populatedQueue(SIZE);
720 <        try {
721 <            q.drainTo(q);
903 <            shouldThrow();
904 <        } catch(IllegalArgumentException success) {
905 <        }
716 >     * timed poll of a non-empty queue returns null if no expired elements.
717 >     */
718 >    public void testTimedPollDelayed() throws InterruptedException {
719 >        DelayQueue q = new DelayQueue();
720 >        q.add(new NanoDelay(LONG_DELAY_MS * 1000000L));
721 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
722      }
723  
724      /**
725       * drainTo(c) empties queue into another collection c
726 <     */
726 >     */
727      public void testDrainTo() {
728 <        DelayQueue q = populatedQueue(SIZE);
728 >        DelayQueue q = new DelayQueue();
729 >        PDelay[] elems = new PDelay[SIZE];
730 >        for (int i = 0; i < SIZE; ++i) {
731 >            elems[i] = new PDelay(i);
732 >            q.add(elems[i]);
733 >        }
734          ArrayList l = new ArrayList();
735          q.drainTo(l);
736 <        assertEquals(q.size(), 0);
737 <        assertEquals(l.size(), SIZE);
736 >        assertEquals(0, q.size());
737 >        for (int i = 0; i < SIZE; ++i)
738 >            assertEquals(elems[i], l.get(i));
739 >        q.add(elems[0]);
740 >        q.add(elems[1]);
741 >        assertFalse(q.isEmpty());
742 >        assertTrue(q.contains(elems[0]));
743 >        assertTrue(q.contains(elems[1]));
744 >        l.clear();
745 >        q.drainTo(l);
746 >        assertEquals(0, q.size());
747 >        assertEquals(2, l.size());
748 >        for (int i = 0; i < 2; ++i)
749 >            assertEquals(elems[i], l.get(i));
750      }
751  
752      /**
753       * drainTo empties queue
754 <     */
755 <    public void testDrainToWithActivePut() {
754 >     */
755 >    public void testDrainToWithActivePut() throws InterruptedException {
756          final DelayQueue q = populatedQueue(SIZE);
757 <        Thread t = new Thread(new Runnable() {
758 <                public void run() {
759 <                    q.put(new PDelay(SIZE+1));
760 <                }
928 <            });
929 <        try {
930 <            t.start();
931 <            ArrayList l = new ArrayList();
932 <            q.drainTo(l);
933 <            assertTrue(l.size() >= SIZE);
934 <            t.join();
935 <            assertTrue(q.size() + l.size() == SIZE+1);
936 <        } catch(Exception e){
937 <            unexpectedException();
938 <        }
939 <    }
940 <
941 <    /**
942 <     * drainTo(null, n) throws NPE
943 <     */
944 <    public void testDrainToNullN() {
945 <        DelayQueue q = populatedQueue(SIZE);
946 <        try {
947 <            q.drainTo(null, 0);
948 <            shouldThrow();
949 <        } catch(NullPointerException success) {
950 <        }
951 <    }
757 >        Thread t = new Thread(new CheckedRunnable() {
758 >            public void realRun() {
759 >                q.put(new PDelay(SIZE + 1));
760 >            }});
761  
762 <    /**
763 <     * drainTo(this, n) throws IAE
764 <     */
765 <    public void testDrainToSelfN() {
766 <        DelayQueue q = populatedQueue(SIZE);
767 <        try {
959 <            q.drainTo(q, 0);
960 <            shouldThrow();
961 <        } catch(IllegalArgumentException success) {
962 <        }
762 >        t.start();
763 >        ArrayList l = new ArrayList();
764 >        q.drainTo(l);
765 >        assertTrue(l.size() >= SIZE);
766 >        t.join();
767 >        assertTrue(q.size() + l.size() >= SIZE);
768      }
769  
770      /**
771 <     * drainTo(c, n) empties first max {n, size} elements of queue into c
772 <     */
771 >     * drainTo(c, n) empties first min(n, size) elements of queue into c
772 >     */
773      public void testDrainToN() {
774          for (int i = 0; i < SIZE + 2; ++i) {
775              DelayQueue q = populatedQueue(SIZE);
776              ArrayList l = new ArrayList();
777              q.drainTo(l, i);
778 <            int k = (i < SIZE)? i : SIZE;
779 <            assertEquals(q.size(), SIZE-k);
780 <            assertEquals(l.size(), k);
778 >            int k = (i < SIZE) ? i : SIZE;
779 >            assertEquals(SIZE - k, q.size());
780 >            assertEquals(k, l.size());
781          }
782      }
783  
784 <
784 >    /**
785 >     * remove(null), contains(null) always return false
786 >     */
787 >    public void testNeverContainsNull() {
788 >        Collection<?> q = populatedQueue(SIZE);
789 >        assertFalse(q.contains(null));
790 >        assertFalse(q.remove(null));
791 >    }
792   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines