ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/DelayQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/DelayQueueTest.java (file contents):
Revision 1.30 by jsr166, Wed Dec 23 00:47:16 2009 UTC vs.
Revision 1.69 by jsr166, Sun Feb 22 04:34:44 2015 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include Andrew Wright, Jeffrey Hayes,
6   * Pat Fisher, Mike Judd.
7   */
8  
9 import junit.framework.*;
10 import java.util.*;
9   import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 < import java.util.concurrent.*;
10 >
11 > import java.util.ArrayList;
12 > import java.util.Arrays;
13 > import java.util.Collection;
14 > import java.util.Iterator;
15 > import java.util.NoSuchElementException;
16 > import java.util.concurrent.BlockingQueue;
17 > import java.util.concurrent.CountDownLatch;
18 > import java.util.concurrent.Delayed;
19 > import java.util.concurrent.DelayQueue;
20 > import java.util.concurrent.Executors;
21 > import java.util.concurrent.ExecutorService;
22 > import java.util.concurrent.TimeUnit;
23 >
24 > import junit.framework.Test;
25  
26   public class DelayQueueTest extends JSR166TestCase {
27 +
28 +    public static class Generic extends BlockingQueueTest {
29 +        protected BlockingQueue emptyCollection() {
30 +            return new DelayQueue();
31 +        }
32 +        protected PDelay makeElement(int i) {
33 +            return new PDelay(i);
34 +        }
35 +    }
36 +
37      public static void main(String[] args) {
38 <        junit.textui.TestRunner.run (suite());
38 >        junit.textui.TestRunner.run(suite());
39      }
40  
41      public static Test suite() {
42 <        return new TestSuite(DelayQueueTest.class);
42 >        return newTestSuite(DelayQueueTest.class,
43 >                            new Generic().testSuite());
44      }
45  
46      private static final int NOCAP = Integer.MAX_VALUE;
# Line 29 | Line 52 | public class DelayQueueTest extends JSR1
52       */
53      static class PDelay implements Delayed {
54          int pseudodelay;
55 <        PDelay(int i) { pseudodelay = Integer.MIN_VALUE + i; }
56 <        public int compareTo(PDelay y) {
57 <            int i = pseudodelay;
58 <            int j = y.pseudodelay;
59 <            if (i < j) return -1;
37 <            if (i > j) return 1;
38 <            return 0;
55 >        PDelay(int i) { pseudodelay = i; }
56 >        public int compareTo(PDelay other) {
57 >            int a = this.pseudodelay;
58 >            int b = other.pseudodelay;
59 >            return (a < b) ? -1 : (a > b) ? 1 : 0;
60          }
40
61          public int compareTo(Delayed y) {
62              return compareTo((PDelay)y);
63          }
44
64          public boolean equals(Object other) {
65 <            return equals((PDelay)other);
65 >            return (other instanceof PDelay) &&
66 >                this.pseudodelay == ((PDelay)other).pseudodelay;
67          }
68 <        public boolean equals(PDelay other) {
69 <            return other.pseudodelay == pseudodelay;
50 <        }
51 <
52 <
68 >        // suppress [overrides] javac warning
69 >        public int hashCode() { return pseudodelay; }
70          public long getDelay(TimeUnit ignore) {
71 <            return pseudodelay;
71 >            return Integer.MIN_VALUE + pseudodelay;
72          }
56        public int intValue() {
57            return pseudodelay;
58        }
59
73          public String toString() {
74              return String.valueOf(pseudodelay);
75          }
76      }
77  
65
78      /**
79       * Delayed implementation that actually delays
80       */
# Line 90 | Line 102 | public class DelayQueueTest extends JSR1
102              return other.trigger == trigger;
103          }
104  
105 +        // suppress [overrides] javac warning
106 +        public int hashCode() { return (int) trigger; }
107 +
108          public long getDelay(TimeUnit unit) {
109              long n = trigger - System.nanoTime();
110              return unit.convert(n, TimeUnit.NANOSECONDS);
# Line 104 | Line 119 | public class DelayQueueTest extends JSR1
119          }
120      }
121  
107
122      /**
123 <     * Create a queue of given size containing consecutive
123 >     * Returns a new queue of given size containing consecutive
124       * PDelays 0 ... n.
125       */
126 <    private DelayQueue populatedQueue(int n) {
127 <        DelayQueue q = new DelayQueue();
126 >    private DelayQueue<PDelay> populatedQueue(int n) {
127 >        DelayQueue<PDelay> q = new DelayQueue<PDelay>();
128          assertTrue(q.isEmpty());
129 <        for (int i = n-1; i >= 0; i-=2)
129 >        for (int i = n-1; i >= 0; i -= 2)
130              assertTrue(q.offer(new PDelay(i)));
131 <        for (int i = (n & 1); i < n; i+=2)
131 >        for (int i = (n & 1); i < n; i += 2)
132              assertTrue(q.offer(new PDelay(i)));
133          assertFalse(q.isEmpty());
134          assertEquals(NOCAP, q.remainingCapacity());
# Line 134 | Line 148 | public class DelayQueueTest extends JSR1
148       */
149      public void testConstructor3() {
150          try {
151 <            DelayQueue q = new DelayQueue(null);
151 >            new DelayQueue(null);
152              shouldThrow();
153          } catch (NullPointerException success) {}
154      }
# Line 145 | Line 159 | public class DelayQueueTest extends JSR1
159      public void testConstructor4() {
160          try {
161              PDelay[] ints = new PDelay[SIZE];
162 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
162 >            new DelayQueue(Arrays.asList(ints));
163              shouldThrow();
164          } catch (NullPointerException success) {}
165      }
# Line 158 | Line 172 | public class DelayQueueTest extends JSR1
172              PDelay[] ints = new PDelay[SIZE];
173              for (int i = 0; i < SIZE-1; ++i)
174                  ints[i] = new PDelay(i);
175 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
175 >            new DelayQueue(Arrays.asList(ints));
176              shouldThrow();
177          } catch (NullPointerException success) {}
178      }
# Line 209 | Line 223 | public class DelayQueueTest extends JSR1
223      }
224  
225      /**
212     * offer(null) throws NPE
213     */
214    public void testOfferNull() {
215        try {
216            DelayQueue q = new DelayQueue();
217            q.offer(null);
218            shouldThrow();
219        } catch (NullPointerException success) {}
220    }
221
222    /**
223     * add(null) throws NPE
224     */
225    public void testAddNull() {
226        try {
227            DelayQueue q = new DelayQueue();
228            q.add(null);
229            shouldThrow();
230        } catch (NullPointerException success) {}
231    }
232
233    /**
226       * offer non-null succeeds
227       */
228      public void testOffer() {
# Line 251 | Line 243 | public class DelayQueueTest extends JSR1
243      }
244  
245      /**
254     * addAll(null) throws NPE
255     */
256    public void testAddAll1() {
257        try {
258            DelayQueue q = new DelayQueue();
259            q.addAll(null);
260            shouldThrow();
261        } catch (NullPointerException success) {}
262    }
263
264
265    /**
246       * addAll(this) throws IAE
247       */
248      public void testAddAllSelf() {
# Line 274 | Line 254 | public class DelayQueueTest extends JSR1
254      }
255  
256      /**
277     * addAll of a collection with null elements throws NPE
278     */
279    public void testAddAll2() {
280        try {
281            DelayQueue q = new DelayQueue();
282            PDelay[] ints = new PDelay[SIZE];
283            q.addAll(Arrays.asList(ints));
284            shouldThrow();
285        } catch (NullPointerException success) {}
286    }
287    /**
257       * addAll of a collection with any null elements throws NPE after
258       * possibly adding some elements
259       */
# Line 315 | Line 284 | public class DelayQueueTest extends JSR1
284      }
285  
286      /**
318     * put(null) throws NPE
319     */
320     public void testPutNull() {
321        try {
322            DelayQueue q = new DelayQueue();
323            q.put(null);
324            shouldThrow();
325        } catch (NullPointerException success) {}
326     }
327
328    /**
287       * all elements successfully put are contained
288       */
289 <     public void testPut() {
290 <         DelayQueue q = new DelayQueue();
291 <         for (int i = 0; i < SIZE; ++i) {
292 <             PDelay I = new PDelay(i);
293 <             q.put(I);
294 <             assertTrue(q.contains(I));
295 <         }
296 <         assertEquals(SIZE, q.size());
289 >    public void testPut() {
290 >        DelayQueue q = new DelayQueue();
291 >        for (int i = 0; i < SIZE; ++i) {
292 >            PDelay x = new PDelay(i);
293 >            q.put(x);
294 >            assertTrue(q.contains(x));
295 >        }
296 >        assertEquals(SIZE, q.size());
297      }
298  
299      /**
# Line 343 | Line 301 | public class DelayQueueTest extends JSR1
301       */
302      public void testPutWithTake() throws InterruptedException {
303          final DelayQueue q = new DelayQueue();
304 <        Thread t = new Thread(new CheckedRunnable() {
304 >        Thread t = newStartedThread(new CheckedRunnable() {
305              public void realRun() {
306                  q.put(new PDelay(0));
307                  q.put(new PDelay(0));
# Line 351 | Line 309 | public class DelayQueueTest extends JSR1
309                  q.put(new PDelay(0));
310              }});
311  
312 <        t.start();
313 <        Thread.sleep(SHORT_DELAY_MS);
356 <        q.take();
357 <        t.interrupt();
358 <        t.join();
312 >        awaitTermination(t);
313 >        assertEquals(4, q.size());
314      }
315  
316      /**
# Line 363 | Line 318 | public class DelayQueueTest extends JSR1
318       */
319      public void testTimedOffer() throws InterruptedException {
320          final DelayQueue q = new DelayQueue();
321 <        Thread t = new Thread(new CheckedRunnable() {
321 >        Thread t = newStartedThread(new CheckedRunnable() {
322              public void realRun() throws InterruptedException {
323                  q.put(new PDelay(0));
324                  q.put(new PDelay(0));
# Line 371 | Line 326 | public class DelayQueueTest extends JSR1
326                  assertTrue(q.offer(new PDelay(0), LONG_DELAY_MS, MILLISECONDS));
327              }});
328  
329 <        t.start();
375 <        Thread.sleep(SMALL_DELAY_MS);
376 <        t.interrupt();
377 <        t.join();
329 >        awaitTermination(t);
330      }
331  
332      /**
# Line 383 | Line 335 | public class DelayQueueTest extends JSR1
335      public void testTake() throws InterruptedException {
336          DelayQueue q = populatedQueue(SIZE);
337          for (int i = 0; i < SIZE; ++i) {
338 <            assertEquals(new PDelay(i), ((PDelay)q.take()));
338 >            assertEquals(new PDelay(i), q.take());
339          }
340      }
341  
342      /**
391     * take blocks interruptibly when empty
392     */
393    public void testTakeFromEmpty() throws InterruptedException {
394        final DelayQueue q = new DelayQueue();
395        Thread t = new ThreadShouldThrow(InterruptedException.class) {
396            public void realRun() throws InterruptedException {
397                q.take();
398            }};
399
400        t.start();
401        Thread.sleep(SHORT_DELAY_MS);
402        t.interrupt();
403        t.join();
404    }
405
406    /**
343       * Take removes existing elements until empty, then blocks interruptibly
344       */
345      public void testBlockingTake() throws InterruptedException {
346          final DelayQueue q = populatedQueue(SIZE);
347 <        Thread t = new Thread(new CheckedRunnable() {
347 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
348 >        Thread t = newStartedThread(new CheckedRunnable() {
349              public void realRun() throws InterruptedException {
350                  for (int i = 0; i < SIZE; ++i) {
351                      assertEquals(new PDelay(i), ((PDelay)q.take()));
352                  }
353 +
354 +                Thread.currentThread().interrupt();
355                  try {
356                      q.take();
357                      shouldThrow();
358                  } catch (InterruptedException success) {}
359 +                assertFalse(Thread.interrupted());
360 +
361 +                pleaseInterrupt.countDown();
362 +                try {
363 +                    q.take();
364 +                    shouldThrow();
365 +                } catch (InterruptedException success) {}
366 +                assertFalse(Thread.interrupted());
367              }});
368  
369 <        t.start();
370 <        Thread.sleep(SHORT_DELAY_MS);
369 >        await(pleaseInterrupt);
370 >        assertThreadStaysAlive(t);
371          t.interrupt();
372 <        t.join();
372 >        awaitTermination(t);
373      }
374  
428
375      /**
376       * poll succeeds unless empty
377       */
378      public void testPoll() {
379          DelayQueue q = populatedQueue(SIZE);
380          for (int i = 0; i < SIZE; ++i) {
381 <            assertEquals(new PDelay(i), ((PDelay)q.poll()));
381 >            assertEquals(new PDelay(i), q.poll());
382          }
383          assertNull(q.poll());
384      }
385  
386      /**
387 <     * timed pool with zero timeout succeeds when non-empty, else times out
387 >     * timed poll with zero timeout succeeds when non-empty, else times out
388       */
389      public void testTimedPoll0() throws InterruptedException {
390          DelayQueue q = populatedQueue(SIZE);
391          for (int i = 0; i < SIZE; ++i) {
392 <            assertEquals(new PDelay(i), ((PDelay)q.poll(0, MILLISECONDS)));
392 >            assertEquals(new PDelay(i), q.poll(0, MILLISECONDS));
393          }
394          assertNull(q.poll(0, MILLISECONDS));
395      }
396  
397      /**
398 <     * timed pool with nonzero timeout succeeds when non-empty, else times out
398 >     * timed poll with nonzero timeout succeeds when non-empty, else times out
399       */
400      public void testTimedPoll() throws InterruptedException {
401          DelayQueue q = populatedQueue(SIZE);
402          for (int i = 0; i < SIZE; ++i) {
403 <            assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, MILLISECONDS)));
404 <        }
405 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
403 >            long startTime = System.nanoTime();
404 >            assertEquals(new PDelay(i), q.poll(LONG_DELAY_MS, MILLISECONDS));
405 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
406 >        }
407 >        long startTime = System.nanoTime();
408 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
409 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
410 >        checkEmpty(q);
411      }
412  
413      /**
# Line 464 | Line 415 | public class DelayQueueTest extends JSR1
415       * returning timeout status
416       */
417      public void testInterruptedTimedPoll() throws InterruptedException {
418 <        Thread t = new Thread(new CheckedRunnable() {
418 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
419 >        Thread t = newStartedThread(new CheckedRunnable() {
420              public void realRun() throws InterruptedException {
421                  DelayQueue q = populatedQueue(SIZE);
422                  for (int i = 0; i < SIZE; ++i) {
423                      assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, MILLISECONDS)));
424                  }
425 +
426 +                Thread.currentThread().interrupt();
427                  try {
428 <                    q.poll(SMALL_DELAY_MS, MILLISECONDS);
428 >                    q.poll(LONG_DELAY_MS, MILLISECONDS);
429                      shouldThrow();
430                  } catch (InterruptedException success) {}
431 <            }});
431 >                assertFalse(Thread.interrupted());
432  
433 <        t.start();
480 <        Thread.sleep(SHORT_DELAY_MS);
481 <        t.interrupt();
482 <        t.join();
483 <    }
484 <
485 <    /**
486 <     *  timed poll before a delayed offer fails; after offer succeeds;
487 <     *  on interruption throws
488 <     */
489 <    public void testTimedPollWithOffer() throws InterruptedException {
490 <        final DelayQueue q = new DelayQueue();
491 <        final PDelay pdelay = new PDelay(0);
492 <        Thread t = new Thread(new CheckedRunnable() {
493 <            public void realRun() throws InterruptedException {
494 <                assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
495 <                assertSame(pdelay, q.poll(LONG_DELAY_MS, MILLISECONDS));
433 >                pleaseInterrupt.countDown();
434                  try {
435                      q.poll(LONG_DELAY_MS, MILLISECONDS);
436                      shouldThrow();
437                  } catch (InterruptedException success) {}
438 +                assertFalse(Thread.interrupted());
439              }});
440  
441 <        t.start();
442 <        Thread.sleep(SMALL_DELAY_MS);
504 <        assertTrue(q.offer(pdelay, SHORT_DELAY_MS, MILLISECONDS));
441 >        await(pleaseInterrupt);
442 >        assertThreadStaysAlive(t);
443          t.interrupt();
444 <        t.join();
444 >        awaitTermination(t);
445      }
446  
509
447      /**
448       * peek returns next element, or null if empty
449       */
450      public void testPeek() {
451          DelayQueue q = populatedQueue(SIZE);
452          for (int i = 0; i < SIZE; ++i) {
453 <            assertEquals(new PDelay(i), ((PDelay)q.peek()));
454 <            assertEquals(new PDelay(i), ((PDelay)q.poll()));
453 >            assertEquals(new PDelay(i), q.peek());
454 >            assertEquals(new PDelay(i), q.poll());
455              if (q.isEmpty())
456                  assertNull(q.peek());
457              else
# Line 529 | Line 466 | public class DelayQueueTest extends JSR1
466      public void testElement() {
467          DelayQueue q = populatedQueue(SIZE);
468          for (int i = 0; i < SIZE; ++i) {
469 <            assertEquals(new PDelay(i), ((PDelay)q.element()));
469 >            assertEquals(new PDelay(i), q.element());
470              q.poll();
471          }
472          try {
# Line 544 | Line 481 | public class DelayQueueTest extends JSR1
481      public void testRemove() {
482          DelayQueue q = populatedQueue(SIZE);
483          for (int i = 0; i < SIZE; ++i) {
484 <            assertEquals(new PDelay(i), ((PDelay)q.remove()));
484 >            assertEquals(new PDelay(i), q.remove());
485          }
486          try {
487              q.remove();
# Line 553 | Line 490 | public class DelayQueueTest extends JSR1
490      }
491  
492      /**
556     * remove(x) removes x and returns true if present
557     */
558    public void testRemoveElement() {
559        DelayQueue q = populatedQueue(SIZE);
560        for (int i = 1; i < SIZE; i+=2) {
561            assertTrue(q.remove(new PDelay(i)));
562        }
563        for (int i = 0; i < SIZE; i+=2) {
564            assertTrue(q.remove(new PDelay(i)));
565            assertFalse(q.remove(new PDelay(i+1)));
566        }
567        assertTrue(q.isEmpty());
568    }
569
570    /**
493       * contains(x) reports true when elements added but not yet removed
494       */
495      public void testContains() {
# Line 639 | Line 561 | public class DelayQueueTest extends JSR1
561              assertTrue(q.removeAll(p));
562              assertEquals(SIZE-i, q.size());
563              for (int j = 0; j < i; ++j) {
564 <                PDelay I = (PDelay)(p.remove());
565 <                assertFalse(q.contains(I));
564 >                PDelay x = (PDelay)(p.remove());
565 >                assertFalse(q.contains(x));
566              }
567          }
568      }
# Line 653 | Line 575 | public class DelayQueueTest extends JSR1
575          Object[] o = q.toArray();
576          Arrays.sort(o);
577          for (int i = 0; i < o.length; i++)
578 <            assertEquals(o[i], q.take());
578 >            assertSame(o[i], q.take());
579      }
580  
581      /**
582       * toArray(a) contains all elements
583       */
584 <    public void testToArray2() throws InterruptedException {
585 <        DelayQueue q = populatedQueue(SIZE);
584 >    public void testToArray2() {
585 >        DelayQueue<PDelay> q = populatedQueue(SIZE);
586          PDelay[] ints = new PDelay[SIZE];
587 <        ints = (PDelay[])q.toArray(ints);
587 >        PDelay[] array = q.toArray(ints);
588 >        assertSame(ints, array);
589          Arrays.sort(ints);
590          for (int i = 0; i < ints.length; i++)
591 <            assertEquals(ints[i], q.take());
591 >            assertSame(ints[i], q.remove());
592      }
593  
671
594      /**
595 <     * toArray(null) throws NPE
674 <     */
675 <    public void testToArray_BadArg() {
676 <        DelayQueue q = populatedQueue(SIZE);
677 <        try {
678 <            Object o[] = q.toArray(null);
679 <            shouldThrow();
680 <        } catch (NullPointerException success) {}
681 <    }
682 <
683 <    /**
684 <     * toArray with incompatible array type throws CCE
595 >     * toArray(incompatible array type) throws ArrayStoreException
596       */
597      public void testToArray1_BadArg() {
598          DelayQueue q = populatedQueue(SIZE);
599          try {
600 <            Object o[] = q.toArray(new String[10]);
600 >            q.toArray(new String[10]);
601              shouldThrow();
602          } catch (ArrayStoreException success) {}
603      }
# Line 703 | Line 614 | public class DelayQueueTest extends JSR1
614              ++i;
615          }
616          assertEquals(i, SIZE);
617 +        assertIteratorExhausted(it);
618 +    }
619 +
620 +    /**
621 +     * iterator of empty collection has no elements
622 +     */
623 +    public void testEmptyIterator() {
624 +        assertIteratorExhausted(new DelayQueue().iterator());
625      }
626  
627      /**
628       * iterator.remove removes current element
629       */
630 <    public void testIteratorRemove () {
630 >    public void testIteratorRemove() {
631          final DelayQueue q = new DelayQueue();
632          q.add(new PDelay(2));
633          q.add(new PDelay(1));
# Line 717 | Line 636 | public class DelayQueueTest extends JSR1
636          it.next();
637          it.remove();
638          it = q.iterator();
639 <        assertEquals(it.next(), new PDelay(2));
640 <        assertEquals(it.next(), new PDelay(3));
639 >        assertEquals(new PDelay(2), it.next());
640 >        assertEquals(new PDelay(3), it.next());
641          assertFalse(it.hasNext());
642      }
643  
725
644      /**
645       * toString contains toStrings of elements
646       */
647      public void testToString() {
648          DelayQueue q = populatedQueue(SIZE);
649          String s = q.toString();
650 <        for (int i = 0; i < SIZE; ++i) {
651 <            assertTrue(s.indexOf(String.valueOf(Integer.MIN_VALUE+i)) >= 0);
734 <        }
650 >        for (Object e : q)
651 >            assertTrue(s.contains(e.toString()));
652      }
653  
654      /**
655 <     * offer transfers elements across Executor tasks
655 >     * timed poll transfers elements across Executor tasks
656       */
657      public void testPollInExecutor() {
658          final DelayQueue q = new DelayQueue();
659 +        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
660          ExecutorService executor = Executors.newFixedThreadPool(2);
661          executor.execute(new CheckedRunnable() {
662              public void realRun() throws InterruptedException {
663                  assertNull(q.poll());
664 <                assertTrue(null != q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
665 <                assertTrue(q.isEmpty());
664 >                threadsStarted.await();
665 >                assertNotNull(q.poll(LONG_DELAY_MS, MILLISECONDS));
666 >                checkEmpty(q);
667              }});
668  
669          executor.execute(new CheckedRunnable() {
670              public void realRun() throws InterruptedException {
671 <                Thread.sleep(SHORT_DELAY_MS);
671 >                threadsStarted.await();
672                  q.put(new PDelay(1));
673              }});
674  
675          joinPool(executor);
676      }
677  
759
678      /**
679       * Delayed actions do not occur until their delay elapses
680       */
681      public void testDelay() throws InterruptedException {
682 <        DelayQueue q = new DelayQueue();
683 <        NanoDelay[] elements = new NanoDelay[SIZE];
684 <        for (int i = 0; i < SIZE; ++i) {
767 <            elements[i] = new NanoDelay(1000000000L + 1000000L * (SIZE - i));
768 <        }
769 <        for (int i = 0; i < SIZE; ++i) {
770 <            q.add(elements[i]);
771 <        }
682 >        DelayQueue<NanoDelay> q = new DelayQueue<NanoDelay>();
683 >        for (int i = 0; i < SIZE; ++i)
684 >            q.add(new NanoDelay(1000000L * (SIZE - i)));
685  
686          long last = 0;
687          for (int i = 0; i < SIZE; ++i) {
688 <            NanoDelay e = (NanoDelay)(q.take());
688 >            NanoDelay e = q.take();
689              long tt = e.getTriggerTime();
690 <            assertTrue(tt <= System.nanoTime());
690 >            assertTrue(System.nanoTime() - tt >= 0);
691              if (i != 0)
692                  assertTrue(tt >= last);
693              last = tt;
694          }
695 +        assertTrue(q.isEmpty());
696      }
697  
698      /**
# Line 787 | Line 701 | public class DelayQueueTest extends JSR1
701      public void testPeekDelayed() {
702          DelayQueue q = new DelayQueue();
703          q.add(new NanoDelay(Long.MAX_VALUE));
704 <        assert(q.peek() != null);
704 >        assertNotNull(q.peek());
705      }
706  
793
707      /**
708       * poll of a non-empty queue returns null if no expired elements.
709       */
# Line 806 | Line 719 | public class DelayQueueTest extends JSR1
719      public void testTimedPollDelayed() throws InterruptedException {
720          DelayQueue q = new DelayQueue();
721          q.add(new NanoDelay(LONG_DELAY_MS * 1000000L));
722 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
810 <    }
811 <
812 <    /**
813 <     * drainTo(null) throws NPE
814 <     */
815 <    public void testDrainToNull() {
816 <        DelayQueue q = populatedQueue(SIZE);
817 <        try {
818 <            q.drainTo(null);
819 <            shouldThrow();
820 <        } catch (NullPointerException success) {}
821 <    }
822 <
823 <    /**
824 <     * drainTo(this) throws IAE
825 <     */
826 <    public void testDrainToSelf() {
827 <        DelayQueue q = populatedQueue(SIZE);
828 <        try {
829 <            q.drainTo(q);
830 <            shouldThrow();
831 <        } catch (IllegalArgumentException success) {}
722 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
723      }
724  
725      /**
# Line 843 | Line 734 | public class DelayQueueTest extends JSR1
734          }
735          ArrayList l = new ArrayList();
736          q.drainTo(l);
737 <        assertEquals(q.size(), 0);
737 >        assertEquals(0, q.size());
738          for (int i = 0; i < SIZE; ++i)
739 <            assertEquals(l.get(i), elems[i]);
739 >            assertEquals(elems[i], l.get(i));
740          q.add(elems[0]);
741          q.add(elems[1]);
742          assertFalse(q.isEmpty());
# Line 853 | Line 744 | public class DelayQueueTest extends JSR1
744          assertTrue(q.contains(elems[1]));
745          l.clear();
746          q.drainTo(l);
747 <        assertEquals(q.size(), 0);
748 <        assertEquals(l.size(), 2);
747 >        assertEquals(0, q.size());
748 >        assertEquals(2, l.size());
749          for (int i = 0; i < 2; ++i)
750 <            assertEquals(l.get(i), elems[i]);
750 >            assertEquals(elems[i], l.get(i));
751      }
752  
753      /**
# Line 878 | Line 769 | public class DelayQueueTest extends JSR1
769      }
770  
771      /**
772 <     * drainTo(null, n) throws NPE
882 <     */
883 <    public void testDrainToNullN() {
884 <        DelayQueue q = populatedQueue(SIZE);
885 <        try {
886 <            q.drainTo(null, 0);
887 <            shouldThrow();
888 <        } catch (NullPointerException success) {}
889 <    }
890 <
891 <    /**
892 <     * drainTo(this, n) throws IAE
893 <     */
894 <    public void testDrainToSelfN() {
895 <        DelayQueue q = populatedQueue(SIZE);
896 <        try {
897 <            q.drainTo(q, 0);
898 <            shouldThrow();
899 <        } catch (IllegalArgumentException success) {}
900 <    }
901 <
902 <    /**
903 <     * drainTo(c, n) empties first max {n, size} elements of queue into c
772 >     * drainTo(c, n) empties first min(n, size) elements of queue into c
773       */
774      public void testDrainToN() {
775          for (int i = 0; i < SIZE + 2; ++i) {
776              DelayQueue q = populatedQueue(SIZE);
777              ArrayList l = new ArrayList();
778              q.drainTo(l, i);
779 <            int k = (i < SIZE)? i : SIZE;
780 <            assertEquals(q.size(), SIZE-k);
781 <            assertEquals(l.size(), k);
779 >            int k = (i < SIZE) ? i : SIZE;
780 >            assertEquals(SIZE-k, q.size());
781 >            assertEquals(k, l.size());
782          }
783      }
784  
785 <
785 >    /**
786 >     * remove(null), contains(null) always return false
787 >     */
788 >    public void testNeverContainsNull() {
789 >        Collection<?> q = populatedQueue(SIZE);
790 >        assertFalse(q.contains(null));
791 >        assertFalse(q.remove(null));
792 >    }
793   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines