ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/DelayQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/DelayQueueTest.java (file contents):
Revision 1.6 by dl, Sun Oct 5 23:00:40 2003 UTC vs.
Revision 1.77 by jsr166, Thu Sep 15 17:07:16 2016 UTC

# Line 1 | Line 1
1   /*
2 < * Written by members of JCP JSR-166 Expert Group and released to the
3 < * public domain. Use, modify, and redistribute this code in any way
4 < * without acknowledgement. Other contributors include Andrew Wright,
5 < * Jeffrey Hayes, Pat Fischer, Mike Judd.
2 > * Written by Doug Lea with assistance from members of JCP JSR-166
3 > * Expert Group and released to the public domain, as explained at
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5 > * Other contributors include Andrew Wright, Jeffrey Hayes,
6 > * Pat Fisher, Mike Judd.
7   */
8  
9 < import junit.framework.*;
10 < import java.util.*;
11 < import java.util.concurrent.*;
9 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 >
11 > import java.util.ArrayList;
12 > import java.util.Arrays;
13 > import java.util.Collection;
14 > import java.util.Iterator;
15 > import java.util.NoSuchElementException;
16 > import java.util.concurrent.BlockingQueue;
17 > import java.util.concurrent.CountDownLatch;
18 > import java.util.concurrent.Delayed;
19 > import java.util.concurrent.DelayQueue;
20 > import java.util.concurrent.Executors;
21 > import java.util.concurrent.ExecutorService;
22 > import java.util.concurrent.TimeUnit;
23 >
24 > import junit.framework.Test;
25  
26   public class DelayQueueTest extends JSR166TestCase {
27 +
28 +    public static class Generic extends BlockingQueueTest {
29 +        protected BlockingQueue emptyCollection() {
30 +            return new DelayQueue();
31 +        }
32 +        protected PDelay makeElement(int i) {
33 +            return new PDelay(i);
34 +        }
35 +    }
36 +
37      public static void main(String[] args) {
38 <        junit.textui.TestRunner.run (suite());  
38 >        main(suite(), args);
39      }
40  
41      public static Test suite() {
42 <        return new TestSuite(DelayQueueTest.class);
42 >        return newTestSuite(DelayQueueTest.class,
43 >                            new Generic().testSuite());
44      }
45  
21    private static final int NOCAP = Integer.MAX_VALUE;
22
46      /**
47 <     * A delayed implmentation for testing.
48 <     * Most  tests use Pseudodelays, where delays are all elapsed
47 >     * A delayed implementation for testing.
48 >     * Most tests use Pseudodelays, where delays are all elapsed
49       * (so, no blocking solely for delays) but are still ordered
50 <     */
51 <    static class PDelay implements Delayed {
50 >     */
51 >    static class PDelay implements Delayed {
52          int pseudodelay;
53 <        PDelay(int i) { pseudodelay = Integer.MIN_VALUE + i; }
54 <        public int compareTo(Object y) {
55 <            int i = pseudodelay;
56 <            int j = ((PDelay)y).pseudodelay;
57 <            if (i < j) return -1;
35 <            if (i > j) return 1;
36 <            return 0;
53 >        PDelay(int i) { pseudodelay = i; }
54 >        public int compareTo(PDelay other) {
55 >            int a = this.pseudodelay;
56 >            int b = other.pseudodelay;
57 >            return (a < b) ? -1 : (a > b) ? 1 : 0;
58          }
59 <
60 <        public int compareTo(PDelay y) {
40 <            int i = pseudodelay;
41 <            int j = ((PDelay)y).pseudodelay;
42 <            if (i < j) return -1;
43 <            if (i > j) return 1;
44 <            return 0;
59 >        public int compareTo(Delayed y) {
60 >            return compareTo((PDelay)y);
61          }
46
62          public boolean equals(Object other) {
63 <            return ((PDelay)other).pseudodelay == pseudodelay;
64 <        }
50 <        public boolean equals(PDelay other) {
51 <            return ((PDelay)other).pseudodelay == pseudodelay;
63 >            return (other instanceof PDelay) &&
64 >                this.pseudodelay == ((PDelay)other).pseudodelay;
65          }
66 <
67 <
66 >        // suppress [overrides] javac warning
67 >        public int hashCode() { return pseudodelay; }
68          public long getDelay(TimeUnit ignore) {
69 <            return pseudodelay;
69 >            return Integer.MIN_VALUE + pseudodelay;
70          }
58        public int intValue() {
59            return pseudodelay;
60        }
61
71          public String toString() {
72              return String.valueOf(pseudodelay);
73          }
74      }
75  
67
76      /**
77       * Delayed implementation that actually delays
78       */
79 <    static class NanoDelay implements Delayed {
79 >    static class NanoDelay implements Delayed {
80          long trigger;
81 <        NanoDelay(long i) {
81 >        NanoDelay(long i) {
82              trigger = System.nanoTime() + i;
83          }
84 <        public int compareTo(Object y) {
84 >        public int compareTo(NanoDelay y) {
85              long i = trigger;
86 <            long j = ((NanoDelay)y).trigger;
86 >            long j = y.trigger;
87              if (i < j) return -1;
88              if (i > j) return 1;
89              return 0;
90          }
91  
92 <        public int compareTo(NanoDelay y) {
93 <            long i = trigger;
86 <            long j = ((NanoDelay)y).trigger;
87 <            if (i < j) return -1;
88 <            if (i > j) return 1;
89 <            return 0;
92 >        public int compareTo(Delayed y) {
93 >            return compareTo((NanoDelay)y);
94          }
95  
96          public boolean equals(Object other) {
97 <            return ((NanoDelay)other).trigger == trigger;
98 <        }
95 <        public boolean equals(NanoDelay other) {
96 <            return ((NanoDelay)other).trigger == trigger;
97 >            return (other instanceof NanoDelay) &&
98 >                this.trigger == ((NanoDelay)other).trigger;
99          }
100  
101 +        // suppress [overrides] javac warning
102 +        public int hashCode() { return (int) trigger; }
103 +
104          public long getDelay(TimeUnit unit) {
105              long n = trigger - System.nanoTime();
106              return unit.convert(n, TimeUnit.NANOSECONDS);
# Line 110 | Line 115 | public class DelayQueueTest extends JSR1
115          }
116      }
117  
113
118      /**
119 <     * Create a queue of given size containing consecutive
119 >     * Returns a new queue of given size containing consecutive
120       * PDelays 0 ... n.
121       */
122 <    private DelayQueue populatedQueue(int n) {
123 <        DelayQueue q = new DelayQueue();
122 >    private DelayQueue<PDelay> populatedQueue(int n) {
123 >        DelayQueue<PDelay> q = new DelayQueue<PDelay>();
124          assertTrue(q.isEmpty());
125 <        for(int i = n-1; i >= 0; i-=2)
126 <            assertTrue(q.offer(new PDelay(i)));
127 <        for(int i = (n & 1); i < n; i+=2)
128 <            assertTrue(q.offer(new PDelay(i)));
125 >        for (int i = n - 1; i >= 0; i -= 2)
126 >            assertTrue(q.offer(new PDelay(i)));
127 >        for (int i = (n & 1); i < n; i += 2)
128 >            assertTrue(q.offer(new PDelay(i)));
129          assertFalse(q.isEmpty());
130 <        assertEquals(NOCAP, q.remainingCapacity());
131 <        assertEquals(n, q.size());
130 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
131 >        assertEquals(n, q.size());
132          return q;
133      }
134 <
134 >
135      /**
136       * A new queue has unbounded capacity
137       */
138      public void testConstructor1() {
139 <        assertEquals(NOCAP, new DelayQueue().remainingCapacity());
139 >        assertEquals(Integer.MAX_VALUE, new DelayQueue().remainingCapacity());
140      }
141  
142      /**
# Line 140 | Line 144 | public class DelayQueueTest extends JSR1
144       */
145      public void testConstructor3() {
146          try {
147 <            DelayQueue q = new DelayQueue(null);
147 >            new DelayQueue(null);
148              shouldThrow();
149 <        }
146 <        catch (NullPointerException success) {}
149 >        } catch (NullPointerException success) {}
150      }
151  
152      /**
# Line 151 | Line 154 | public class DelayQueueTest extends JSR1
154       */
155      public void testConstructor4() {
156          try {
157 <            PDelay[] ints = new PDelay[SIZE];
155 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
157 >            new DelayQueue(Arrays.asList(new PDelay[SIZE]));
158              shouldThrow();
159 <        }
158 <        catch (NullPointerException success) {}
159 >        } catch (NullPointerException success) {}
160      }
161  
162      /**
163       * Initializing from Collection with some null elements throws NPE
164       */
165      public void testConstructor5() {
166 +        PDelay[] a = new PDelay[SIZE];
167 +        for (int i = 0; i < SIZE - 1; ++i)
168 +            a[i] = new PDelay(i);
169          try {
170 <            PDelay[] ints = new PDelay[SIZE];
167 <            for (int i = 0; i < SIZE-1; ++i)
168 <                ints[i] = new PDelay(i);
169 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
170 >            new DelayQueue(Arrays.asList(a));
171              shouldThrow();
172 <        }
172 <        catch (NullPointerException success) {}
172 >        } catch (NullPointerException success) {}
173      }
174  
175      /**
176       * Queue contains all elements of collection used to initialize
177       */
178      public void testConstructor6() {
179 <        try {
180 <            PDelay[] ints = new PDelay[SIZE];
181 <            for (int i = 0; i < SIZE; ++i)
182 <                ints[i] = new PDelay(i);
183 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
184 <            for (int i = 0; i < SIZE; ++i)
185 <                assertEquals(ints[i], q.poll());
186 <        }
187 <        finally {}
179 >        PDelay[] ints = new PDelay[SIZE];
180 >        for (int i = 0; i < SIZE; ++i)
181 >            ints[i] = new PDelay(i);
182 >        DelayQueue q = new DelayQueue(Arrays.asList(ints));
183 >        for (int i = 0; i < SIZE; ++i)
184 >            assertEquals(ints[i], q.poll());
185      }
186  
187      /**
# Line 193 | Line 190 | public class DelayQueueTest extends JSR1
190      public void testEmpty() {
191          DelayQueue q = new DelayQueue();
192          assertTrue(q.isEmpty());
193 <        assertEquals(NOCAP, q.remainingCapacity());
193 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
194          q.add(new PDelay(1));
195          assertFalse(q.isEmpty());
196          q.add(new PDelay(2));
# Line 203 | Line 200 | public class DelayQueueTest extends JSR1
200      }
201  
202      /**
203 <     * remainingCapacity does not change when elementa added or removed,
207 <     * but size does
203 >     * remainingCapacity() always returns Integer.MAX_VALUE
204       */
205      public void testRemainingCapacity() {
206 <        DelayQueue q = populatedQueue(SIZE);
206 >        BlockingQueue q = populatedQueue(SIZE);
207          for (int i = 0; i < SIZE; ++i) {
208 <            assertEquals(NOCAP, q.remainingCapacity());
209 <            assertEquals(SIZE-i, q.size());
210 <            q.remove();
208 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
209 >            assertEquals(SIZE - i, q.size());
210 >            assertTrue(q.remove() instanceof PDelay);
211          }
212          for (int i = 0; i < SIZE; ++i) {
213 <            assertEquals(NOCAP, q.remainingCapacity());
213 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
214              assertEquals(i, q.size());
215 <            q.add(new PDelay(i));
215 >            assertTrue(q.add(new PDelay(i)));
216          }
217      }
218  
219      /**
224     * offer(null) throws NPE
225     */
226    public void testOfferNull() {
227        try {
228            DelayQueue q = new DelayQueue();
229            q.offer(null);
230            shouldThrow();
231        } catch (NullPointerException success) { }  
232    }
233
234    /**
235     * add(null) throws NPE
236     */
237    public void testAddNull() {
238        try {
239            DelayQueue q = new DelayQueue();
240            q.add(null);
241            shouldThrow();
242        } catch (NullPointerException success) { }  
243    }
244
245    /**
220       * offer non-null succeeds
221       */
222      public void testOffer() {
# Line 263 | Line 237 | public class DelayQueueTest extends JSR1
237      }
238  
239      /**
266     * addAll(null) throws NPE
267     */
268    public void testAddAll1() {
269        try {
270            DelayQueue q = new DelayQueue();
271            q.addAll(null);
272            shouldThrow();
273        }
274        catch (NullPointerException success) {}
275    }
276
277
278    /**
240       * addAll(this) throws IAE
241       */
242      public void testAddAllSelf() {
243 +        DelayQueue q = populatedQueue(SIZE);
244          try {
283            DelayQueue q = populatedQueue(SIZE);
245              q.addAll(q);
246              shouldThrow();
247 <        }
287 <        catch (IllegalArgumentException success) {}
247 >        } catch (IllegalArgumentException success) {}
248      }
249  
250      /**
291     * addAll of a collection with null elements throws NPE
292     */
293    public void testAddAll2() {
294        try {
295            DelayQueue q = new DelayQueue();
296            PDelay[] ints = new PDelay[SIZE];
297            q.addAll(Arrays.asList(ints));
298            shouldThrow();
299        }
300        catch (NullPointerException success) {}
301    }
302    /**
251       * addAll of a collection with any null elements throws NPE after
252       * possibly adding some elements
253       */
254      public void testAddAll3() {
255 +        DelayQueue q = new DelayQueue();
256 +        PDelay[] a = new PDelay[SIZE];
257 +        for (int i = 0; i < SIZE - 1; ++i)
258 +            a[i] = new PDelay(i);
259          try {
260 <            DelayQueue q = new DelayQueue();
309 <            PDelay[] ints = new PDelay[SIZE];
310 <            for (int i = 0; i < SIZE-1; ++i)
311 <                ints[i] = new PDelay(i);
312 <            q.addAll(Arrays.asList(ints));
260 >            q.addAll(Arrays.asList(a));
261              shouldThrow();
262 <        }
315 <        catch (NullPointerException success) {}
262 >        } catch (NullPointerException success) {}
263      }
264  
265      /**
266       * Queue contains all elements of successful addAll
267       */
268      public void testAddAll5() {
269 <        try {
270 <            PDelay[] empty = new PDelay[0];
271 <            PDelay[] ints = new PDelay[SIZE];
272 <            for (int i = SIZE-1; i >= 0; --i)
273 <                ints[i] = new PDelay(i);
274 <            DelayQueue q = new DelayQueue();
275 <            assertFalse(q.addAll(Arrays.asList(empty)));
276 <            assertTrue(q.addAll(Arrays.asList(ints)));
277 <            for (int i = 0; i < SIZE; ++i)
331 <                assertEquals(ints[i], q.poll());
332 <        }
333 <        finally {}
269 >        PDelay[] empty = new PDelay[0];
270 >        PDelay[] ints = new PDelay[SIZE];
271 >        for (int i = SIZE - 1; i >= 0; --i)
272 >            ints[i] = new PDelay(i);
273 >        DelayQueue q = new DelayQueue();
274 >        assertFalse(q.addAll(Arrays.asList(empty)));
275 >        assertTrue(q.addAll(Arrays.asList(ints)));
276 >        for (int i = 0; i < SIZE; ++i)
277 >            assertEquals(ints[i], q.poll());
278      }
279  
280      /**
337     * put(null) throws NPE
338     */
339     public void testPutNull() {
340        try {
341            DelayQueue q = new DelayQueue();
342            q.put(null);
343            shouldThrow();
344        }
345        catch (NullPointerException success){
346        }  
347     }
348
349    /**
281       * all elements successfully put are contained
282       */
283 <     public void testPut() {
284 <         try {
285 <             DelayQueue q = new DelayQueue();
286 <             for (int i = 0; i < SIZE; ++i) {
287 <                 PDelay I = new PDelay(i);
288 <                 q.put(I);
358 <                 assertTrue(q.contains(I));
359 <             }
360 <             assertEquals(SIZE, q.size());
361 <         }
362 <         finally {
283 >    public void testPut() {
284 >        DelayQueue q = new DelayQueue();
285 >        for (int i = 0; i < SIZE; ++i) {
286 >            PDelay x = new PDelay(i);
287 >            q.put(x);
288 >            assertTrue(q.contains(x));
289          }
290 +        assertEquals(SIZE, q.size());
291      }
292  
293      /**
294       * put doesn't block waiting for take
295       */
296 <    public void testPutWithTake() {
296 >    public void testPutWithTake() throws InterruptedException {
297          final DelayQueue q = new DelayQueue();
298 <        Thread t = new Thread(new Runnable() {
299 <                public void run() {
300 <                    int added = 0;
301 <                    try {
302 <                        q.put(new PDelay(0));
303 <                        ++added;
304 <                        q.put(new PDelay(0));
305 <                        ++added;
306 <                        q.put(new PDelay(0));
307 <                        ++added;
381 <                        q.put(new PDelay(0));
382 <                        ++added;
383 <                        threadAssertTrue(added == 4);
384 <                    } finally {
385 <                    }
386 <                }
387 <            });
388 <        try {
389 <            t.start();
390 <            Thread.sleep(SHORT_DELAY_MS);
391 <            q.take();
392 <            t.interrupt();
393 <            t.join();
394 <        } catch (Exception e){
395 <            unexpectedException();
396 <        }
298 >        Thread t = newStartedThread(new CheckedRunnable() {
299 >            public void realRun() {
300 >                q.put(new PDelay(0));
301 >                q.put(new PDelay(0));
302 >                q.put(new PDelay(0));
303 >                q.put(new PDelay(0));
304 >            }});
305 >
306 >        awaitTermination(t);
307 >        assertEquals(4, q.size());
308      }
309  
310      /**
311       * timed offer does not time out
312       */
313 <    public void testTimedOffer() {
313 >    public void testTimedOffer() throws InterruptedException {
314          final DelayQueue q = new DelayQueue();
315 <        Thread t = new Thread(new Runnable() {
316 <                public void run() {
317 <                    try {
318 <                        q.put(new PDelay(0));
319 <                        q.put(new PDelay(0));
320 <                        threadAssertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
321 <                        threadAssertTrue(q.offer(new PDelay(0), LONG_DELAY_MS, TimeUnit.MILLISECONDS));
411 <                    } finally { }
412 <                }
413 <            });
414 <        
415 <        try {
416 <            t.start();
417 <            Thread.sleep(SMALL_DELAY_MS);
418 <            t.interrupt();
419 <            t.join();
420 <        } catch (Exception e){
421 <            unexpectedException();
422 <        }
423 <    }
315 >        Thread t = newStartedThread(new CheckedRunnable() {
316 >            public void realRun() throws InterruptedException {
317 >                q.put(new PDelay(0));
318 >                q.put(new PDelay(0));
319 >                assertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, MILLISECONDS));
320 >                assertTrue(q.offer(new PDelay(0), LONG_DELAY_MS, MILLISECONDS));
321 >            }});
322  
323 <    /**
426 <     * take retrieves elements in priority order
427 <     */
428 <    public void testTake() {
429 <        try {
430 <            DelayQueue q = populatedQueue(SIZE);
431 <            for (int i = 0; i < SIZE; ++i) {
432 <                assertEquals(new PDelay(i), ((PDelay)q.take()));
433 <            }
434 <        } catch (InterruptedException e){
435 <            unexpectedException();
436 <        }  
323 >        awaitTermination(t);
324      }
325  
326      /**
327 <     * take blocks interruptibly when empty
327 >     * take retrieves elements in priority order
328       */
329 <    public void testTakeFromEmpty() {
330 <        final DelayQueue q = new DelayQueue();
331 <        Thread t = new Thread(new Runnable() {
332 <                public void run() {
446 <                    try {
447 <                        q.take();
448 <                        threadShouldThrow();
449 <                    } catch (InterruptedException success){ }                
450 <                }
451 <            });
452 <        try {
453 <            t.start();
454 <            Thread.sleep(SHORT_DELAY_MS);
455 <            t.interrupt();
456 <            t.join();
457 <        } catch (Exception e){
458 <            unexpectedException();
329 >    public void testTake() throws InterruptedException {
330 >        DelayQueue q = populatedQueue(SIZE);
331 >        for (int i = 0; i < SIZE; ++i) {
332 >            assertEquals(new PDelay(i), q.take());
333          }
334      }
335  
336      /**
337       * Take removes existing elements until empty, then blocks interruptibly
338       */
339 <    public void testBlockingTake() {
340 <        Thread t = new Thread(new Runnable() {
341 <                public void run() {
342 <                    try {
343 <                        DelayQueue q = populatedQueue(SIZE);
344 <                        for (int i = 0; i < SIZE; ++i) {
345 <                            threadAssertEquals(new PDelay(i), ((PDelay)q.take()));
346 <                        }
347 <                        q.take();
348 <                        threadShouldThrow();
349 <                    } catch (InterruptedException success){
350 <                    }  
351 <                }});
352 <        t.start();
353 <        try {
480 <           Thread.sleep(SHORT_DELAY_MS);
481 <           t.interrupt();
482 <           t.join();
483 <        }
484 <        catch (InterruptedException ie) {
485 <            unexpectedException();
486 <        }
487 <    }
339 >    public void testBlockingTake() throws InterruptedException {
340 >        final DelayQueue q = populatedQueue(SIZE);
341 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
342 >        Thread t = newStartedThread(new CheckedRunnable() {
343 >            public void realRun() throws InterruptedException {
344 >                for (int i = 0; i < SIZE; ++i) {
345 >                    assertEquals(new PDelay(i), ((PDelay)q.take()));
346 >                }
347 >
348 >                Thread.currentThread().interrupt();
349 >                try {
350 >                    q.take();
351 >                    shouldThrow();
352 >                } catch (InterruptedException success) {}
353 >                assertFalse(Thread.interrupted());
354  
355 +                pleaseInterrupt.countDown();
356 +                try {
357 +                    q.take();
358 +                    shouldThrow();
359 +                } catch (InterruptedException success) {}
360 +                assertFalse(Thread.interrupted());
361 +            }});
362 +
363 +        await(pleaseInterrupt);
364 +        assertThreadStaysAlive(t);
365 +        t.interrupt();
366 +        awaitTermination(t);
367 +    }
368  
369      /**
370       * poll succeeds unless empty
# Line 493 | Line 372 | public class DelayQueueTest extends JSR1
372      public void testPoll() {
373          DelayQueue q = populatedQueue(SIZE);
374          for (int i = 0; i < SIZE; ++i) {
375 <            assertEquals(new PDelay(i), ((PDelay)q.poll()));
375 >            assertEquals(new PDelay(i), q.poll());
376          }
377 <        assertNull(q.poll());
377 >        assertNull(q.poll());
378      }
379  
380      /**
381 <     * timed pool with zero timeout succeeds when non-empty, else times out
381 >     * timed poll with zero timeout succeeds when non-empty, else times out
382       */
383 <    public void testTimedPoll0() {
384 <        try {
385 <            DelayQueue q = populatedQueue(SIZE);
386 <            for (int i = 0; i < SIZE; ++i) {
387 <                assertEquals(new PDelay(i), ((PDelay)q.poll(0, TimeUnit.MILLISECONDS)));
388 <            }
510 <            assertNull(q.poll(0, TimeUnit.MILLISECONDS));
511 <        } catch (InterruptedException e){
512 <            unexpectedException();
513 <        }  
383 >    public void testTimedPoll0() throws InterruptedException {
384 >        DelayQueue q = populatedQueue(SIZE);
385 >        for (int i = 0; i < SIZE; ++i) {
386 >            assertEquals(new PDelay(i), q.poll(0, MILLISECONDS));
387 >        }
388 >        assertNull(q.poll(0, MILLISECONDS));
389      }
390  
391      /**
392 <     * timed pool with nonzero timeout succeeds when non-empty, else times out
392 >     * timed poll with nonzero timeout succeeds when non-empty, else times out
393       */
394 <    public void testTimedPoll() {
395 <        try {
396 <            DelayQueue q = populatedQueue(SIZE);
397 <            for (int i = 0; i < SIZE; ++i) {
398 <                assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)));
399 <            }
400 <            assertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
401 <        } catch (InterruptedException e){
402 <            unexpectedException();
403 <        }  
394 >    public void testTimedPoll() throws InterruptedException {
395 >        DelayQueue q = populatedQueue(SIZE);
396 >        for (int i = 0; i < SIZE; ++i) {
397 >            long startTime = System.nanoTime();
398 >            assertEquals(new PDelay(i), q.poll(LONG_DELAY_MS, MILLISECONDS));
399 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
400 >        }
401 >        long startTime = System.nanoTime();
402 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
403 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
404 >        checkEmpty(q);
405      }
406  
407      /**
408       * Interrupted timed poll throws InterruptedException instead of
409       * returning timeout status
410       */
411 <    public void testInterruptedTimedPoll() {
412 <        Thread t = new Thread(new Runnable() {
413 <                public void run() {
414 <                    try {
415 <                        DelayQueue q = populatedQueue(SIZE);
416 <                        for (int i = 0; i < SIZE; ++i) {
417 <                            threadAssertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)));
418 <                        }
419 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
544 <                    } catch (InterruptedException success){
545 <                    }  
546 <                }});
547 <        t.start();
548 <        try {
549 <           Thread.sleep(SHORT_DELAY_MS);
550 <           t.interrupt();
551 <           t.join();
552 <        }
553 <        catch (InterruptedException ie) {
554 <            unexpectedException();
555 <        }
556 <    }
557 <
558 <    /**
559 <     *  timed poll before a delayed offer fails; after offer succeeds;
560 <     *  on interruption throws
561 <     */
562 <    public void testTimedPollWithOffer() {
563 <        final DelayQueue q = new DelayQueue();
564 <        Thread t = new Thread(new Runnable() {
565 <                public void run() {
566 <                    try {
567 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
568 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
569 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
570 <                        threadFail("Should block");
571 <                    } catch (InterruptedException success) { }                
411 >    public void testInterruptedTimedPoll() throws InterruptedException {
412 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
413 >        final DelayQueue q = populatedQueue(SIZE);
414 >        Thread t = newStartedThread(new CheckedRunnable() {
415 >            public void realRun() throws InterruptedException {
416 >                long startTime = System.nanoTime();
417 >                for (int i = 0; i < SIZE; ++i) {
418 >                    assertEquals(new PDelay(i),
419 >                                 ((PDelay)q.poll(LONG_DELAY_MS, MILLISECONDS)));
420                  }
573            });
574        try {
575            t.start();
576            Thread.sleep(SMALL_DELAY_MS);
577            assertTrue(q.offer(new PDelay(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
578            t.interrupt();
579            t.join();
580        } catch (Exception e){
581            unexpectedException();
582        }
583    }  
421  
422 +                Thread.currentThread().interrupt();
423 +                try {
424 +                    q.poll(LONG_DELAY_MS, MILLISECONDS);
425 +                    shouldThrow();
426 +                } catch (InterruptedException success) {}
427 +                assertFalse(Thread.interrupted());
428 +
429 +                pleaseInterrupt.countDown();
430 +                try {
431 +                    q.poll(LONG_DELAY_MS, MILLISECONDS);
432 +                    shouldThrow();
433 +                } catch (InterruptedException success) {}
434 +                assertFalse(Thread.interrupted());
435 +                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
436 +            }});
437 +
438 +        await(pleaseInterrupt);
439 +        assertThreadStaysAlive(t);
440 +        t.interrupt();
441 +        awaitTermination(t);
442 +        checkEmpty(q);
443 +    }
444  
445      /**
446       * peek returns next element, or null if empty
# Line 589 | Line 448 | public class DelayQueueTest extends JSR1
448      public void testPeek() {
449          DelayQueue q = populatedQueue(SIZE);
450          for (int i = 0; i < SIZE; ++i) {
451 <            assertEquals(new PDelay(i), ((PDelay)q.peek()));
452 <            q.poll();
453 <            assertTrue(q.peek() == null ||
454 <                       i != ((PDelay)q.peek()).intValue());
451 >            assertEquals(new PDelay(i), q.peek());
452 >            assertEquals(new PDelay(i), q.poll());
453 >            if (q.isEmpty())
454 >                assertNull(q.peek());
455 >            else
456 >                assertFalse(new PDelay(i).equals(q.peek()));
457          }
458 <        assertNull(q.peek());
458 >        assertNull(q.peek());
459      }
460  
461      /**
# Line 603 | Line 464 | public class DelayQueueTest extends JSR1
464      public void testElement() {
465          DelayQueue q = populatedQueue(SIZE);
466          for (int i = 0; i < SIZE; ++i) {
467 <            assertEquals(new PDelay(i), ((PDelay)q.element()));
467 >            assertEquals(new PDelay(i), q.element());
468              q.poll();
469          }
470          try {
471              q.element();
472              shouldThrow();
473 <        }
613 <        catch (NoSuchElementException success) {}
473 >        } catch (NoSuchElementException success) {}
474      }
475  
476      /**
# Line 619 | Line 479 | public class DelayQueueTest extends JSR1
479      public void testRemove() {
480          DelayQueue q = populatedQueue(SIZE);
481          for (int i = 0; i < SIZE; ++i) {
482 <            assertEquals(new PDelay(i), ((PDelay)q.remove()));
482 >            assertEquals(new PDelay(i), q.remove());
483          }
484          try {
485              q.remove();
486              shouldThrow();
487 <        } catch (NoSuchElementException success){
628 <        }  
487 >        } catch (NoSuchElementException success) {}
488      }
489  
490      /**
632     * remove(x) removes x and returns true if present
633     */
634    public void testRemoveElement() {
635        DelayQueue q = populatedQueue(SIZE);
636        for (int i = 1; i < SIZE; i+=2) {
637            assertTrue(q.remove(new PDelay(i)));
638        }
639        for (int i = 0; i < SIZE; i+=2) {
640            assertTrue(q.remove(new PDelay(i)));
641            assertFalse(q.remove(new PDelay(i+1)));
642        }
643        assertTrue(q.isEmpty());
644    }
645        
646    /**
491       * contains(x) reports true when elements added but not yet removed
492       */
493      public void testContains() {
# Line 663 | Line 507 | public class DelayQueueTest extends JSR1
507          q.clear();
508          assertTrue(q.isEmpty());
509          assertEquals(0, q.size());
510 <        assertEquals(NOCAP, q.remainingCapacity());
511 <        q.add(new PDelay(1));
510 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
511 >        PDelay x = new PDelay(1);
512 >        q.add(x);
513          assertFalse(q.isEmpty());
514 +        assertTrue(q.contains(x));
515          q.clear();
516          assertTrue(q.isEmpty());
517      }
# Line 698 | Line 544 | public class DelayQueueTest extends JSR1
544                  assertTrue(changed);
545  
546              assertTrue(q.containsAll(p));
547 <            assertEquals(SIZE-i, q.size());
547 >            assertEquals(SIZE - i, q.size());
548              p.remove();
549          }
550      }
# Line 711 | Line 557 | public class DelayQueueTest extends JSR1
557              DelayQueue q = populatedQueue(SIZE);
558              DelayQueue p = populatedQueue(i);
559              assertTrue(q.removeAll(p));
560 <            assertEquals(SIZE-i, q.size());
560 >            assertEquals(SIZE - i, q.size());
561              for (int j = 0; j < i; ++j) {
562 <                PDelay I = (PDelay)(p.remove());
563 <                assertFalse(q.contains(I));
562 >                PDelay x = (PDelay)(p.remove());
563 >                assertFalse(q.contains(x));
564              }
565          }
566      }
# Line 722 | Line 568 | public class DelayQueueTest extends JSR1
568      /**
569       * toArray contains all elements
570       */
571 <    public void testToArray() {
571 >    public void testToArray() throws InterruptedException {
572          DelayQueue q = populatedQueue(SIZE);
573 <        Object[] o = q.toArray();
573 >        Object[] o = q.toArray();
574          Arrays.sort(o);
575 <        try {
576 <        for(int i = 0; i < o.length; i++)
731 <            assertEquals(o[i], q.take());
732 <        } catch (InterruptedException e){
733 <            unexpectedException();
734 <        }    
575 >        for (int i = 0; i < o.length; i++)
576 >            assertSame(o[i], q.take());
577      }
578  
579      /**
580       * toArray(a) contains all elements
581       */
582      public void testToArray2() {
583 <        DelayQueue q = populatedQueue(SIZE);
584 <        PDelay[] ints = new PDelay[SIZE];
585 <        ints = (PDelay[])q.toArray(ints);
583 >        DelayQueue<PDelay> q = populatedQueue(SIZE);
584 >        PDelay[] ints = new PDelay[SIZE];
585 >        PDelay[] array = q.toArray(ints);
586 >        assertSame(ints, array);
587          Arrays.sort(ints);
588 <        try {
589 <            for(int i = 0; i < ints.length; i++)
747 <                assertEquals(ints[i], q.take());
748 <        } catch (InterruptedException e){
749 <            unexpectedException();
750 <        }    
588 >        for (int i = 0; i < ints.length; i++)
589 >            assertSame(ints[i], q.remove());
590      }
591  
753
592      /**
593 <     * toArray(null) throws NPE
756 <     */
757 <    public void testToArray_BadArg() {
758 <        try {
759 <            DelayQueue q = populatedQueue(SIZE);
760 <            Object o[] = q.toArray(null);
761 <            shouldThrow();
762 <        } catch(NullPointerException success){}
763 <    }
764 <
765 <    /**
766 <     * toArray with incompatable array type throws CCE
593 >     * toArray(incompatible array type) throws ArrayStoreException
594       */
595      public void testToArray1_BadArg() {
596 <        try {
597 <            DelayQueue q = populatedQueue(SIZE);
598 <            Object o[] = q.toArray(new String[10] );
599 <            shouldThrow();
600 <        } catch(ArrayStoreException  success){}
596 >        DelayQueue q = populatedQueue(SIZE);
597 >        try {
598 >            q.toArray(new String[10]);
599 >            shouldThrow();
600 >        } catch (ArrayStoreException success) {}
601      }
602 <    
602 >
603      /**
604       * iterator iterates through all elements
605       */
606      public void testIterator() {
607          DelayQueue q = populatedQueue(SIZE);
608          int i = 0;
609 <        Iterator it = q.iterator();
610 <        while(it.hasNext()) {
609 >        Iterator it = q.iterator();
610 >        while (it.hasNext()) {
611              assertTrue(q.contains(it.next()));
612              ++i;
613          }
614          assertEquals(i, SIZE);
615 +        assertIteratorExhausted(it);
616 +    }
617 +
618 +    /**
619 +     * iterator of empty collection has no elements
620 +     */
621 +    public void testEmptyIterator() {
622 +        assertIteratorExhausted(new DelayQueue().iterator());
623      }
624  
625      /**
626       * iterator.remove removes current element
627       */
628 <    public void testIteratorRemove () {
628 >    public void testIteratorRemove() {
629          final DelayQueue q = new DelayQueue();
630          q.add(new PDelay(2));
631          q.add(new PDelay(1));
# Line 799 | Line 634 | public class DelayQueueTest extends JSR1
634          it.next();
635          it.remove();
636          it = q.iterator();
637 <        assertEquals(it.next(), new PDelay(2));
638 <        assertEquals(it.next(), new PDelay(3));
637 >        assertEquals(new PDelay(2), it.next());
638 >        assertEquals(new PDelay(3), it.next());
639          assertFalse(it.hasNext());
640      }
641  
807
642      /**
643       * toString contains toStrings of elements
644       */
645      public void testToString() {
646          DelayQueue q = populatedQueue(SIZE);
647          String s = q.toString();
648 <        for (int i = 0; i < SIZE; ++i) {
649 <            assertTrue(s.indexOf(String.valueOf(Integer.MIN_VALUE+i)) >= 0);
650 <        }
817 <    }        
648 >        for (Object e : q)
649 >            assertTrue(s.contains(e.toString()));
650 >    }
651  
652      /**
653 <     * offer transfers elements across Executor tasks
653 >     * timed poll transfers elements across Executor tasks
654       */
655      public void testPollInExecutor() {
656          final DelayQueue q = new DelayQueue();
657 <        ExecutorService executor = Executors.newFixedThreadPool(2);
658 <        executor.execute(new Runnable() {
659 <            public void run() {
660 <                threadAssertNull(q.poll());
661 <                try {
662 <                    threadAssertTrue(null != q.poll(MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS));
663 <                    threadAssertTrue(q.isEmpty());
664 <                }
665 <                catch (InterruptedException e) {
666 <                    threadUnexpectedException();
834 <                }
835 <            }
836 <        });
657 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
658 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
659 >        try (PoolCleaner cleaner = cleaner(executor)) {
660 >            executor.execute(new CheckedRunnable() {
661 >                public void realRun() throws InterruptedException {
662 >                    assertNull(q.poll());
663 >                    threadsStarted.await();
664 >                    assertNotNull(q.poll(LONG_DELAY_MS, MILLISECONDS));
665 >                    checkEmpty(q);
666 >                }});
667  
668 <        executor.execute(new Runnable() {
669 <            public void run() {
670 <                try {
841 <                    Thread.sleep(SHORT_DELAY_MS);
668 >            executor.execute(new CheckedRunnable() {
669 >                public void realRun() throws InterruptedException {
670 >                    threadsStarted.await();
671                      q.put(new PDelay(1));
672 <                }
673 <                catch (InterruptedException e) {
845 <                    threadUnexpectedException();
846 <                }
847 <            }
848 <        });
849 <        joinPool(executor);
850 <
672 >                }});
673 >        }
674      }
675  
853
676      /**
677 <     * Dekayed actions do not occur until their delay elapses
677 >     * Delayed actions do not occur until their delay elapses
678       */
679 <    public void testDelay() {
680 <        DelayQueue q = new DelayQueue();
681 <        NanoDelay[] elements = new NanoDelay[SIZE];
682 <        for (int i = 0; i < SIZE; ++i) {
683 <            elements[i] = new NanoDelay(1000000000L + 1000000L * (SIZE - i));
684 <        }
685 <        for (int i = 0; i < SIZE; ++i) {
686 <            q.add(elements[i]);
687 <        }
688 <
689 <        try {
690 <            long last = 0;
691 <            for (int i = 0; i < SIZE; ++i) {
870 <                NanoDelay e = (NanoDelay)(q.take());
871 <                long tt = e.getTriggerTime();
872 <                assertTrue(tt <= System.nanoTime());
873 <                if (i != 0)
874 <                    assertTrue(tt >= last);
875 <                last = tt;
876 <            }
877 <        }
878 <        catch(InterruptedException ie) {
879 <            unexpectedException();
679 >    public void testDelay() throws InterruptedException {
680 >        DelayQueue<NanoDelay> q = new DelayQueue<NanoDelay>();
681 >        for (int i = 0; i < SIZE; ++i)
682 >            q.add(new NanoDelay(1000000L * (SIZE - i)));
683 >
684 >        long last = 0;
685 >        for (int i = 0; i < SIZE; ++i) {
686 >            NanoDelay e = q.take();
687 >            long tt = e.getTriggerTime();
688 >            assertTrue(System.nanoTime() - tt >= 0);
689 >            if (i != 0)
690 >                assertTrue(tt >= last);
691 >            last = tt;
692          }
693 +        assertTrue(q.isEmpty());
694      }
695  
696 +    /**
697 +     * peek of a non-empty queue returns non-null even if not expired
698 +     */
699 +    public void testPeekDelayed() {
700 +        DelayQueue q = new DelayQueue();
701 +        q.add(new NanoDelay(Long.MAX_VALUE));
702 +        assertNotNull(q.peek());
703 +    }
704  
705      /**
706 <     * drainTo(null) throws NPE
707 <     */
708 <    public void testDrainToNull() {
709 <        DelayQueue q = populatedQueue(SIZE);
710 <        try {
711 <            q.drainTo(null);
891 <            shouldThrow();
892 <        } catch(NullPointerException success) {
893 <        }
706 >     * poll of a non-empty queue returns null if no expired elements.
707 >     */
708 >    public void testPollDelayed() {
709 >        DelayQueue q = new DelayQueue();
710 >        q.add(new NanoDelay(Long.MAX_VALUE));
711 >        assertNull(q.poll());
712      }
713  
714      /**
715 <     * drainTo(this) throws IAE
716 <     */
717 <    public void testDrainToSelf() {
718 <        DelayQueue q = populatedQueue(SIZE);
719 <        try {
720 <            q.drainTo(q);
903 <            shouldThrow();
904 <        } catch(IllegalArgumentException success) {
905 <        }
715 >     * timed poll of a non-empty queue returns null if no expired elements.
716 >     */
717 >    public void testTimedPollDelayed() throws InterruptedException {
718 >        DelayQueue q = new DelayQueue();
719 >        q.add(new NanoDelay(LONG_DELAY_MS * 1000000L));
720 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
721      }
722  
723      /**
724       * drainTo(c) empties queue into another collection c
725 <     */
725 >     */
726      public void testDrainTo() {
727 <        DelayQueue q = populatedQueue(SIZE);
727 >        DelayQueue q = new DelayQueue();
728 >        PDelay[] elems = new PDelay[SIZE];
729 >        for (int i = 0; i < SIZE; ++i) {
730 >            elems[i] = new PDelay(i);
731 >            q.add(elems[i]);
732 >        }
733          ArrayList l = new ArrayList();
734          q.drainTo(l);
735 <        assertEquals(q.size(), 0);
736 <        assertEquals(l.size(), SIZE);
735 >        assertEquals(0, q.size());
736 >        for (int i = 0; i < SIZE; ++i)
737 >            assertEquals(elems[i], l.get(i));
738 >        q.add(elems[0]);
739 >        q.add(elems[1]);
740 >        assertFalse(q.isEmpty());
741 >        assertTrue(q.contains(elems[0]));
742 >        assertTrue(q.contains(elems[1]));
743 >        l.clear();
744 >        q.drainTo(l);
745 >        assertEquals(0, q.size());
746 >        assertEquals(2, l.size());
747 >        for (int i = 0; i < 2; ++i)
748 >            assertEquals(elems[i], l.get(i));
749      }
750  
751      /**
752       * drainTo empties queue
753 <     */
754 <    public void testDrainToWithActivePut() {
753 >     */
754 >    public void testDrainToWithActivePut() throws InterruptedException {
755          final DelayQueue q = populatedQueue(SIZE);
756 <        Thread t = new Thread(new Runnable() {
757 <                public void run() {
758 <                    q.put(new PDelay(SIZE+1));
759 <                }
928 <            });
929 <        try {
930 <            t.start();
931 <            ArrayList l = new ArrayList();
932 <            q.drainTo(l);
933 <            assertTrue(l.size() >= SIZE);
934 <            t.join();
935 <            assertTrue(q.size() + l.size() == SIZE+1);
936 <        } catch(Exception e){
937 <            unexpectedException();
938 <        }
939 <    }
940 <
941 <    /**
942 <     * drainTo(null, n) throws NPE
943 <     */
944 <    public void testDrainToNullN() {
945 <        DelayQueue q = populatedQueue(SIZE);
946 <        try {
947 <            q.drainTo(null, 0);
948 <            shouldThrow();
949 <        } catch(NullPointerException success) {
950 <        }
951 <    }
756 >        Thread t = new Thread(new CheckedRunnable() {
757 >            public void realRun() {
758 >                q.put(new PDelay(SIZE + 1));
759 >            }});
760  
761 <    /**
762 <     * drainTo(this, n) throws IAE
763 <     */
764 <    public void testDrainToSelfN() {
765 <        DelayQueue q = populatedQueue(SIZE);
766 <        try {
959 <            q.drainTo(q, 0);
960 <            shouldThrow();
961 <        } catch(IllegalArgumentException success) {
962 <        }
761 >        t.start();
762 >        ArrayList l = new ArrayList();
763 >        q.drainTo(l);
764 >        assertTrue(l.size() >= SIZE);
765 >        t.join();
766 >        assertTrue(q.size() + l.size() >= SIZE);
767      }
768  
769      /**
770 <     * drainTo(c, n) empties first max {n, size} elements of queue into c
771 <     */
770 >     * drainTo(c, n) empties first min(n, size) elements of queue into c
771 >     */
772      public void testDrainToN() {
773          for (int i = 0; i < SIZE + 2; ++i) {
774              DelayQueue q = populatedQueue(SIZE);
775              ArrayList l = new ArrayList();
776              q.drainTo(l, i);
777 <            int k = (i < SIZE)? i : SIZE;
778 <            assertEquals(q.size(), SIZE-k);
779 <            assertEquals(l.size(), k);
777 >            int k = (i < SIZE) ? i : SIZE;
778 >            assertEquals(SIZE - k, q.size());
779 >            assertEquals(k, l.size());
780          }
781      }
782  
783 <
783 >    /**
784 >     * remove(null), contains(null) always return false
785 >     */
786 >    public void testNeverContainsNull() {
787 >        Collection<?> q = populatedQueue(SIZE);
788 >        assertFalse(q.contains(null));
789 >        assertFalse(q.remove(null));
790 >    }
791   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines