ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/DelayQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/DelayQueueTest.java (file contents):
Revision 1.57 by jsr166, Sat Nov 26 05:19:17 2011 UTC vs.
Revision 1.81 by jsr166, Wed Jan 4 06:09:58 2017 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 < import junit.framework.*;
10 < import java.util.Arrays;
9 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 >
11   import java.util.ArrayList;
12 + import java.util.Arrays;
13 + import java.util.Collection;
14   import java.util.Iterator;
15   import java.util.NoSuchElementException;
16   import java.util.concurrent.BlockingQueue;
# Line 18 | Line 20 | import java.util.concurrent.DelayQueue;
20   import java.util.concurrent.Executors;
21   import java.util.concurrent.ExecutorService;
22   import java.util.concurrent.TimeUnit;
23 < import static java.util.concurrent.TimeUnit.MILLISECONDS;
23 >
24 > import junit.framework.Test;
25  
26   public class DelayQueueTest extends JSR166TestCase {
27  
# Line 32 | Line 35 | public class DelayQueueTest extends JSR1
35      }
36  
37      public static void main(String[] args) {
38 <        junit.textui.TestRunner.run(suite());
38 >        main(suite(), args);
39      }
40  
41      public static Test suite() {
42 +        class Implementation implements CollectionImplementation {
43 +            public Class<?> klazz() { return DelayQueue.class; }
44 +            public Collection emptyCollection() { return new DelayQueue(); }
45 +            public Object makeElement(int i) { return new PDelay(i); }
46 +            public boolean isConcurrent() { return true; }
47 +            public boolean permitsNulls() { return false; }
48 +        }
49          return newTestSuite(DelayQueueTest.class,
50 <                            new Generic().testSuite());
50 >                            new Generic().testSuite(),
51 >                            CollectionTest.testSuite(new Implementation()));
52      }
53  
43    private static final int NOCAP = Integer.MAX_VALUE;
44
54      /**
55 <     * A delayed implementation for testing.
56 <     * Most tests use Pseudodelays, where delays are all elapsed
55 >     * A fake Delayed implementation for testing.
56 >     * Most tests use PDelays, where delays are all elapsed
57       * (so, no blocking solely for delays) but are still ordered
58       */
59      static class PDelay implements Delayed {
60 <        int pseudodelay;
61 <        PDelay(int i) { pseudodelay = i; }
53 <        public int compareTo(PDelay other) {
54 <            int a = this.pseudodelay;
55 <            int b = other.pseudodelay;
56 <            return (a < b) ? -1 : (a > b) ? 1 : 0;
57 <        }
60 >        final int pseudodelay;
61 >        PDelay(int pseudodelay) { this.pseudodelay = pseudodelay; }
62          public int compareTo(Delayed y) {
63 <            return compareTo((PDelay)y);
63 >            return Integer.compare(this.pseudodelay, ((PDelay)y).pseudodelay);
64          }
65          public boolean equals(Object other) {
66              return (other instanceof PDelay) &&
67                  this.pseudodelay == ((PDelay)other).pseudodelay;
68          }
69 +        // suppress [overrides] javac warning
70 +        public int hashCode() { return pseudodelay; }
71          public long getDelay(TimeUnit ignore) {
72              return Integer.MIN_VALUE + pseudodelay;
73          }
# Line 74 | Line 80 | public class DelayQueueTest extends JSR1
80       * Delayed implementation that actually delays
81       */
82      static class NanoDelay implements Delayed {
83 <        long trigger;
83 >        final long trigger;
84          NanoDelay(long i) {
85              trigger = System.nanoTime() + i;
86          }
81        public int compareTo(NanoDelay y) {
82            long i = trigger;
83            long j = y.trigger;
84            if (i < j) return -1;
85            if (i > j) return 1;
86            return 0;
87        }
87  
88          public int compareTo(Delayed y) {
89 <            return compareTo((NanoDelay)y);
89 >            return Long.compare(trigger, ((NanoDelay)y).trigger);
90          }
91  
92          public boolean equals(Object other) {
93 <            return equals((NanoDelay)other);
94 <        }
96 <        public boolean equals(NanoDelay other) {
97 <            return other.trigger == trigger;
93 >            return (other instanceof NanoDelay) &&
94 >                this.trigger == ((NanoDelay)other).trigger;
95          }
96  
97 +        // suppress [overrides] javac warning
98 +        public int hashCode() { return (int) trigger; }
99 +
100          public long getDelay(TimeUnit unit) {
101              long n = trigger - System.nanoTime();
102              return unit.convert(n, TimeUnit.NANOSECONDS);
# Line 112 | Line 112 | public class DelayQueueTest extends JSR1
112      }
113  
114      /**
115 <     * Create a queue of given size containing consecutive
116 <     * PDelays 0 ... n.
115 >     * Returns a new queue of given size containing consecutive
116 >     * PDelays 0 ... n - 1.
117       */
118      private DelayQueue<PDelay> populatedQueue(int n) {
119 <        DelayQueue<PDelay> q = new DelayQueue<PDelay>();
119 >        DelayQueue<PDelay> q = new DelayQueue<>();
120          assertTrue(q.isEmpty());
121 <        for (int i = n-1; i >= 0; i-=2)
121 >        for (int i = n - 1; i >= 0; i -= 2)
122              assertTrue(q.offer(new PDelay(i)));
123 <        for (int i = (n & 1); i < n; i+=2)
123 >        for (int i = (n & 1); i < n; i += 2)
124              assertTrue(q.offer(new PDelay(i)));
125          assertFalse(q.isEmpty());
126 <        assertEquals(NOCAP, q.remainingCapacity());
126 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
127          assertEquals(n, q.size());
128 +        assertEquals(new PDelay(0), q.peek());
129          return q;
130      }
131  
# Line 132 | Line 133 | public class DelayQueueTest extends JSR1
133       * A new queue has unbounded capacity
134       */
135      public void testConstructor1() {
136 <        assertEquals(NOCAP, new DelayQueue().remainingCapacity());
136 >        assertEquals(Integer.MAX_VALUE, new DelayQueue().remainingCapacity());
137      }
138  
139      /**
# Line 140 | Line 141 | public class DelayQueueTest extends JSR1
141       */
142      public void testConstructor3() {
143          try {
144 <            DelayQueue q = new DelayQueue(null);
144 >            new DelayQueue(null);
145              shouldThrow();
146          } catch (NullPointerException success) {}
147      }
# Line 150 | Line 151 | public class DelayQueueTest extends JSR1
151       */
152      public void testConstructor4() {
153          try {
154 <            PDelay[] ints = new PDelay[SIZE];
154 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
154 >            new DelayQueue(Arrays.asList(new PDelay[SIZE]));
155              shouldThrow();
156          } catch (NullPointerException success) {}
157      }
# Line 160 | Line 160 | public class DelayQueueTest extends JSR1
160       * Initializing from Collection with some null elements throws NPE
161       */
162      public void testConstructor5() {
163 +        PDelay[] a = new PDelay[SIZE];
164 +        for (int i = 0; i < SIZE - 1; ++i)
165 +            a[i] = new PDelay(i);
166          try {
167 <            PDelay[] ints = new PDelay[SIZE];
165 <            for (int i = 0; i < SIZE-1; ++i)
166 <                ints[i] = new PDelay(i);
167 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
167 >            new DelayQueue(Arrays.asList(a));
168              shouldThrow();
169          } catch (NullPointerException success) {}
170      }
# Line 187 | Line 187 | public class DelayQueueTest extends JSR1
187      public void testEmpty() {
188          DelayQueue q = new DelayQueue();
189          assertTrue(q.isEmpty());
190 <        assertEquals(NOCAP, q.remainingCapacity());
190 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
191          q.add(new PDelay(1));
192          assertFalse(q.isEmpty());
193          q.add(new PDelay(2));
# Line 197 | Line 197 | public class DelayQueueTest extends JSR1
197      }
198  
199      /**
200 <     * remainingCapacity does not change when elements added or removed,
201 <     * but size does
200 >     * remainingCapacity() always returns Integer.MAX_VALUE
201       */
202      public void testRemainingCapacity() {
203 <        DelayQueue q = populatedQueue(SIZE);
203 >        BlockingQueue q = populatedQueue(SIZE);
204          for (int i = 0; i < SIZE; ++i) {
205 <            assertEquals(NOCAP, q.remainingCapacity());
206 <            assertEquals(SIZE-i, q.size());
207 <            q.remove();
205 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
206 >            assertEquals(SIZE - i, q.size());
207 >            assertTrue(q.remove() instanceof PDelay);
208          }
209          for (int i = 0; i < SIZE; ++i) {
210 <            assertEquals(NOCAP, q.remainingCapacity());
210 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
211              assertEquals(i, q.size());
212 <            q.add(new PDelay(i));
212 >            assertTrue(q.add(new PDelay(i)));
213          }
214      }
215  
# Line 238 | Line 237 | public class DelayQueueTest extends JSR1
237       * addAll(this) throws IAE
238       */
239      public void testAddAllSelf() {
240 +        DelayQueue q = populatedQueue(SIZE);
241          try {
242            DelayQueue q = populatedQueue(SIZE);
242              q.addAll(q);
243              shouldThrow();
244          } catch (IllegalArgumentException success) {}
# Line 250 | Line 249 | public class DelayQueueTest extends JSR1
249       * possibly adding some elements
250       */
251      public void testAddAll3() {
252 +        DelayQueue q = new DelayQueue();
253 +        PDelay[] a = new PDelay[SIZE];
254 +        for (int i = 0; i < SIZE - 1; ++i)
255 +            a[i] = new PDelay(i);
256          try {
257 <            DelayQueue q = new DelayQueue();
255 <            PDelay[] ints = new PDelay[SIZE];
256 <            for (int i = 0; i < SIZE-1; ++i)
257 <                ints[i] = new PDelay(i);
258 <            q.addAll(Arrays.asList(ints));
257 >            q.addAll(Arrays.asList(a));
258              shouldThrow();
259          } catch (NullPointerException success) {}
260      }
# Line 266 | Line 265 | public class DelayQueueTest extends JSR1
265      public void testAddAll5() {
266          PDelay[] empty = new PDelay[0];
267          PDelay[] ints = new PDelay[SIZE];
268 <        for (int i = SIZE-1; i >= 0; --i)
268 >        for (int i = SIZE - 1; i >= 0; --i)
269              ints[i] = new PDelay(i);
270          DelayQueue q = new DelayQueue();
271          assertFalse(q.addAll(Arrays.asList(empty)));
# Line 281 | Line 280 | public class DelayQueueTest extends JSR1
280      public void testPut() {
281          DelayQueue q = new DelayQueue();
282          for (int i = 0; i < SIZE; ++i) {
283 <            PDelay I = new PDelay(i);
284 <            q.put(I);
285 <            assertTrue(q.contains(I));
283 >            PDelay x = new PDelay(i);
284 >            q.put(x);
285 >            assertTrue(q.contains(x));
286          }
287          assertEquals(SIZE, q.size());
288      }
# Line 327 | Line 326 | public class DelayQueueTest extends JSR1
326      public void testTake() throws InterruptedException {
327          DelayQueue q = populatedQueue(SIZE);
328          for (int i = 0; i < SIZE; ++i) {
329 <            assertEquals(new PDelay(i), ((PDelay)q.take()));
329 >            assertEquals(new PDelay(i), q.take());
330          }
331      }
332  
# Line 370 | Line 369 | public class DelayQueueTest extends JSR1
369      public void testPoll() {
370          DelayQueue q = populatedQueue(SIZE);
371          for (int i = 0; i < SIZE; ++i) {
372 <            assertEquals(new PDelay(i), ((PDelay)q.poll()));
372 >            assertEquals(new PDelay(i), q.poll());
373          }
374          assertNull(q.poll());
375      }
# Line 381 | Line 380 | public class DelayQueueTest extends JSR1
380      public void testTimedPoll0() throws InterruptedException {
381          DelayQueue q = populatedQueue(SIZE);
382          for (int i = 0; i < SIZE; ++i) {
383 <            assertEquals(new PDelay(i), ((PDelay)q.poll(0, MILLISECONDS)));
383 >            assertEquals(new PDelay(i), q.poll(0, MILLISECONDS));
384          }
385          assertNull(q.poll(0, MILLISECONDS));
386      }
# Line 393 | Line 392 | public class DelayQueueTest extends JSR1
392          DelayQueue q = populatedQueue(SIZE);
393          for (int i = 0; i < SIZE; ++i) {
394              long startTime = System.nanoTime();
395 <            assertEquals(new PDelay(i), ((PDelay)q.poll(LONG_DELAY_MS, MILLISECONDS)));
395 >            assertEquals(new PDelay(i), q.poll(LONG_DELAY_MS, MILLISECONDS));
396              assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
397          }
398          long startTime = System.nanoTime();
# Line 408 | Line 407 | public class DelayQueueTest extends JSR1
407       */
408      public void testInterruptedTimedPoll() throws InterruptedException {
409          final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
410 +        final DelayQueue q = populatedQueue(SIZE);
411          Thread t = newStartedThread(new CheckedRunnable() {
412              public void realRun() throws InterruptedException {
413 <                DelayQueue q = populatedQueue(SIZE);
413 >                long startTime = System.nanoTime();
414                  for (int i = 0; i < SIZE; ++i) {
415 <                    assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, MILLISECONDS)));
415 >                    assertEquals(new PDelay(i),
416 >                                 ((PDelay)q.poll(LONG_DELAY_MS, MILLISECONDS)));
417                  }
418  
419                  Thread.currentThread().interrupt();
# Line 428 | Line 429 | public class DelayQueueTest extends JSR1
429                      shouldThrow();
430                  } catch (InterruptedException success) {}
431                  assertFalse(Thread.interrupted());
432 +                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
433              }});
434  
435          await(pleaseInterrupt);
436          assertThreadStaysAlive(t);
437          t.interrupt();
438          awaitTermination(t);
439 +        checkEmpty(q);
440      }
441  
442      /**
# Line 442 | Line 445 | public class DelayQueueTest extends JSR1
445      public void testPeek() {
446          DelayQueue q = populatedQueue(SIZE);
447          for (int i = 0; i < SIZE; ++i) {
448 <            assertEquals(new PDelay(i), ((PDelay)q.peek()));
449 <            assertEquals(new PDelay(i), ((PDelay)q.poll()));
448 >            assertEquals(new PDelay(i), q.peek());
449 >            assertEquals(new PDelay(i), q.poll());
450              if (q.isEmpty())
451                  assertNull(q.peek());
452              else
# Line 458 | Line 461 | public class DelayQueueTest extends JSR1
461      public void testElement() {
462          DelayQueue q = populatedQueue(SIZE);
463          for (int i = 0; i < SIZE; ++i) {
464 <            assertEquals(new PDelay(i), ((PDelay)q.element()));
464 >            assertEquals(new PDelay(i), q.element());
465              q.poll();
466          }
467          try {
# Line 473 | Line 476 | public class DelayQueueTest extends JSR1
476      public void testRemove() {
477          DelayQueue q = populatedQueue(SIZE);
478          for (int i = 0; i < SIZE; ++i) {
479 <            assertEquals(new PDelay(i), ((PDelay)q.remove()));
479 >            assertEquals(new PDelay(i), q.remove());
480          }
481          try {
482              q.remove();
# Line 501 | Line 504 | public class DelayQueueTest extends JSR1
504          q.clear();
505          assertTrue(q.isEmpty());
506          assertEquals(0, q.size());
507 <        assertEquals(NOCAP, q.remainingCapacity());
507 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
508          PDelay x = new PDelay(1);
509          q.add(x);
510          assertFalse(q.isEmpty());
# Line 538 | Line 541 | public class DelayQueueTest extends JSR1
541                  assertTrue(changed);
542  
543              assertTrue(q.containsAll(p));
544 <            assertEquals(SIZE-i, q.size());
544 >            assertEquals(SIZE - i, q.size());
545              p.remove();
546          }
547      }
# Line 551 | Line 554 | public class DelayQueueTest extends JSR1
554              DelayQueue q = populatedQueue(SIZE);
555              DelayQueue p = populatedQueue(i);
556              assertTrue(q.removeAll(p));
557 <            assertEquals(SIZE-i, q.size());
557 >            assertEquals(SIZE - i, q.size());
558              for (int j = 0; j < i; ++j) {
559 <                PDelay I = (PDelay)(p.remove());
560 <                assertFalse(q.contains(I));
559 >                PDelay x = (PDelay)(p.remove());
560 >                assertFalse(q.contains(x));
561              }
562          }
563      }
# Line 606 | Line 609 | public class DelayQueueTest extends JSR1
609              ++i;
610          }
611          assertEquals(i, SIZE);
612 +        assertIteratorExhausted(it);
613 +    }
614 +
615 +    /**
616 +     * iterator of empty collection has no elements
617 +     */
618 +    public void testEmptyIterator() {
619 +        assertIteratorExhausted(new DelayQueue().iterator());
620      }
621  
622      /**
# Line 620 | Line 631 | public class DelayQueueTest extends JSR1
631          it.next();
632          it.remove();
633          it = q.iterator();
634 <        assertEquals(it.next(), new PDelay(2));
635 <        assertEquals(it.next(), new PDelay(3));
634 >        assertEquals(new PDelay(2), it.next());
635 >        assertEquals(new PDelay(3), it.next());
636          assertFalse(it.hasNext());
637      }
638  
# Line 641 | Line 652 | public class DelayQueueTest extends JSR1
652      public void testPollInExecutor() {
653          final DelayQueue q = new DelayQueue();
654          final CheckedBarrier threadsStarted = new CheckedBarrier(2);
655 <        ExecutorService executor = Executors.newFixedThreadPool(2);
656 <        executor.execute(new CheckedRunnable() {
657 <            public void realRun() throws InterruptedException {
658 <                assertNull(q.poll());
659 <                threadsStarted.await();
660 <                assertTrue(null != q.poll(LONG_DELAY_MS, MILLISECONDS));
661 <                checkEmpty(q);
662 <            }});
663 <
664 <        executor.execute(new CheckedRunnable() {
665 <            public void realRun() throws InterruptedException {
666 <                threadsStarted.await();
667 <                q.put(new PDelay(1));
668 <            }});
669 <
670 <        joinPool(executor);
655 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
656 >        try (PoolCleaner cleaner = cleaner(executor)) {
657 >            executor.execute(new CheckedRunnable() {
658 >                public void realRun() throws InterruptedException {
659 >                    assertNull(q.poll());
660 >                    threadsStarted.await();
661 >                    assertNotNull(q.poll(LONG_DELAY_MS, MILLISECONDS));
662 >                    checkEmpty(q);
663 >                }});
664 >
665 >            executor.execute(new CheckedRunnable() {
666 >                public void realRun() throws InterruptedException {
667 >                    threadsStarted.await();
668 >                    q.put(new PDelay(1));
669 >                }});
670 >        }
671      }
672  
673      /**
674       * Delayed actions do not occur until their delay elapses
675       */
676      public void testDelay() throws InterruptedException {
677 <        DelayQueue<NanoDelay> q = new DelayQueue<NanoDelay>();
677 >        DelayQueue<NanoDelay> q = new DelayQueue<>();
678          for (int i = 0; i < SIZE; ++i)
679              q.add(new NanoDelay(1000000L * (SIZE - i)));
680  
# Line 720 | Line 731 | public class DelayQueueTest extends JSR1
731          q.drainTo(l);
732          assertEquals(0, q.size());
733          for (int i = 0; i < SIZE; ++i)
734 <            assertEquals(l.get(i), elems[i]);
734 >            assertEquals(elems[i], l.get(i));
735          q.add(elems[0]);
736          q.add(elems[1]);
737          assertFalse(q.isEmpty());
# Line 731 | Line 742 | public class DelayQueueTest extends JSR1
742          assertEquals(0, q.size());
743          assertEquals(2, l.size());
744          for (int i = 0; i < 2; ++i)
745 <            assertEquals(l.get(i), elems[i]);
745 >            assertEquals(elems[i], l.get(i));
746      }
747  
748      /**
# Line 741 | Line 752 | public class DelayQueueTest extends JSR1
752          final DelayQueue q = populatedQueue(SIZE);
753          Thread t = new Thread(new CheckedRunnable() {
754              public void realRun() {
755 <                q.put(new PDelay(SIZE+1));
755 >                q.put(new PDelay(SIZE + 1));
756              }});
757  
758          t.start();
# Line 761 | Line 772 | public class DelayQueueTest extends JSR1
772              ArrayList l = new ArrayList();
773              q.drainTo(l, i);
774              int k = (i < SIZE) ? i : SIZE;
775 <            assertEquals(q.size(), SIZE-k);
776 <            assertEquals(l.size(), k);
775 >            assertEquals(SIZE - k, q.size());
776 >            assertEquals(k, l.size());
777          }
778      }
779  
780 +    /**
781 +     * remove(null), contains(null) always return false
782 +     */
783 +    public void testNeverContainsNull() {
784 +        Collection<?> q = populatedQueue(SIZE);
785 +        assertFalse(q.contains(null));
786 +        assertFalse(q.remove(null));
787 +    }
788   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines