ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/DelayQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/DelayQueueTest.java (file contents):
Revision 1.51 by jsr166, Sat May 28 12:45:38 2011 UTC vs.
Revision 1.86 by jsr166, Sun May 14 00:48:20 2017 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 import junit.framework.*;
10 import java.util.*;
9   import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 < import java.util.concurrent.*;
10 >
11 > import java.util.ArrayList;
12 > import java.util.Arrays;
13 > import java.util.Collection;
14 > import java.util.Iterator;
15 > import java.util.NoSuchElementException;
16 > import java.util.concurrent.BlockingQueue;
17 > import java.util.concurrent.CountDownLatch;
18 > import java.util.concurrent.Delayed;
19 > import java.util.concurrent.DelayQueue;
20 > import java.util.concurrent.Executors;
21 > import java.util.concurrent.ExecutorService;
22 > import java.util.concurrent.TimeUnit;
23 >
24 > import junit.framework.Test;
25  
26   public class DelayQueueTest extends JSR166TestCase {
27 +
28 +    public static class Generic extends BlockingQueueTest {
29 +        protected BlockingQueue emptyCollection() {
30 +            return new DelayQueue();
31 +        }
32 +        protected PDelay makeElement(int i) {
33 +            return new PDelay(i);
34 +        }
35 +    }
36 +
37      public static void main(String[] args) {
38 <        junit.textui.TestRunner.run(suite());
38 >        main(suite(), args);
39      }
40  
41      public static Test suite() {
42 <        return new TestSuite(DelayQueueTest.class);
42 >        class Implementation implements CollectionImplementation {
43 >            public Class<?> klazz() { return DelayQueue.class; }
44 >            public Collection emptyCollection() { return new DelayQueue(); }
45 >            public Object makeElement(int i) { return new PDelay(i); }
46 >            public boolean isConcurrent() { return true; }
47 >            public boolean permitsNulls() { return false; }
48 >        }
49 >        return newTestSuite(DelayQueueTest.class,
50 >                            new Generic().testSuite(),
51 >                            CollectionTest.testSuite(new Implementation()));
52      }
53  
23    private static final int NOCAP = Integer.MAX_VALUE;
24
54      /**
55 <     * A delayed implementation for testing.
56 <     * Most tests use Pseudodelays, where delays are all elapsed
55 >     * A fake Delayed implementation for testing.
56 >     * Most tests use PDelays, where delays are all elapsed
57       * (so, no blocking solely for delays) but are still ordered
58       */
59      static class PDelay implements Delayed {
60 <        int pseudodelay;
61 <        PDelay(int i) { pseudodelay = Integer.MIN_VALUE + i; }
33 <        public int compareTo(PDelay y) {
34 <            int i = pseudodelay;
35 <            int j = y.pseudodelay;
36 <            if (i < j) return -1;
37 <            if (i > j) return 1;
38 <            return 0;
39 <        }
40 <
60 >        final int pseudodelay;
61 >        PDelay(int pseudodelay) { this.pseudodelay = pseudodelay; }
62          public int compareTo(Delayed y) {
63 <            return compareTo((PDelay)y);
63 >            return Integer.compare(this.pseudodelay, ((PDelay)y).pseudodelay);
64          }
44
65          public boolean equals(Object other) {
66 <            return equals((PDelay)other);
67 <        }
48 <        public boolean equals(PDelay other) {
49 <            return other.pseudodelay == pseudodelay;
66 >            return (other instanceof PDelay) &&
67 >                this.pseudodelay == ((PDelay)other).pseudodelay;
68          }
69 <
69 >        // suppress [overrides] javac warning
70 >        public int hashCode() { return pseudodelay; }
71          public long getDelay(TimeUnit ignore) {
72 <            return pseudodelay;
72 >            return Integer.MIN_VALUE + pseudodelay;
73          }
55        public int intValue() {
56            return pseudodelay;
57        }
58
74          public String toString() {
75              return String.valueOf(pseudodelay);
76          }
# Line 65 | Line 80 | public class DelayQueueTest extends JSR1
80       * Delayed implementation that actually delays
81       */
82      static class NanoDelay implements Delayed {
83 <        long trigger;
83 >        final long trigger;
84          NanoDelay(long i) {
85              trigger = System.nanoTime() + i;
86          }
72        public int compareTo(NanoDelay y) {
73            long i = trigger;
74            long j = y.trigger;
75            if (i < j) return -1;
76            if (i > j) return 1;
77            return 0;
78        }
87  
88          public int compareTo(Delayed y) {
89 <            return compareTo((NanoDelay)y);
89 >            return Long.compare(trigger, ((NanoDelay)y).trigger);
90          }
91  
92          public boolean equals(Object other) {
93 <            return equals((NanoDelay)other);
94 <        }
87 <        public boolean equals(NanoDelay other) {
88 <            return other.trigger == trigger;
93 >            return (other instanceof NanoDelay) &&
94 >                this.trigger == ((NanoDelay)other).trigger;
95          }
96  
97 +        // suppress [overrides] javac warning
98 +        public int hashCode() { return (int) trigger; }
99 +
100          public long getDelay(TimeUnit unit) {
101              long n = trigger - System.nanoTime();
102              return unit.convert(n, TimeUnit.NANOSECONDS);
# Line 103 | Line 112 | public class DelayQueueTest extends JSR1
112      }
113  
114      /**
115 <     * Create a queue of given size containing consecutive
116 <     * PDelays 0 ... n.
115 >     * Returns a new queue of given size containing consecutive
116 >     * PDelays 0 ... n - 1.
117       */
118 <    private DelayQueue<PDelay> populatedQueue(int n) {
119 <        DelayQueue<PDelay> q = new DelayQueue<PDelay>();
118 >    private static DelayQueue<PDelay> populatedQueue(int n) {
119 >        DelayQueue<PDelay> q = new DelayQueue<>();
120          assertTrue(q.isEmpty());
121 <        for (int i = n-1; i >= 0; i-=2)
121 >        for (int i = n - 1; i >= 0; i -= 2)
122              assertTrue(q.offer(new PDelay(i)));
123 <        for (int i = (n & 1); i < n; i+=2)
123 >        for (int i = (n & 1); i < n; i += 2)
124              assertTrue(q.offer(new PDelay(i)));
125          assertFalse(q.isEmpty());
126 <        assertEquals(NOCAP, q.remainingCapacity());
126 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
127          assertEquals(n, q.size());
128 +        assertEquals(new PDelay(0), q.peek());
129          return q;
130      }
131  
# Line 123 | Line 133 | public class DelayQueueTest extends JSR1
133       * A new queue has unbounded capacity
134       */
135      public void testConstructor1() {
136 <        assertEquals(NOCAP, new DelayQueue().remainingCapacity());
136 >        assertEquals(Integer.MAX_VALUE, new DelayQueue().remainingCapacity());
137      }
138  
139      /**
# Line 131 | Line 141 | public class DelayQueueTest extends JSR1
141       */
142      public void testConstructor3() {
143          try {
144 <            DelayQueue q = new DelayQueue(null);
144 >            new DelayQueue(null);
145              shouldThrow();
146          } catch (NullPointerException success) {}
147      }
# Line 141 | Line 151 | public class DelayQueueTest extends JSR1
151       */
152      public void testConstructor4() {
153          try {
154 <            PDelay[] ints = new PDelay[SIZE];
145 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
154 >            new DelayQueue(Arrays.asList(new PDelay[SIZE]));
155              shouldThrow();
156          } catch (NullPointerException success) {}
157      }
# Line 151 | Line 160 | public class DelayQueueTest extends JSR1
160       * Initializing from Collection with some null elements throws NPE
161       */
162      public void testConstructor5() {
163 +        PDelay[] a = new PDelay[SIZE];
164 +        for (int i = 0; i < SIZE - 1; ++i)
165 +            a[i] = new PDelay(i);
166          try {
167 <            PDelay[] ints = new PDelay[SIZE];
156 <            for (int i = 0; i < SIZE-1; ++i)
157 <                ints[i] = new PDelay(i);
158 <            DelayQueue q = new DelayQueue(Arrays.asList(ints));
167 >            new DelayQueue(Arrays.asList(a));
168              shouldThrow();
169          } catch (NullPointerException success) {}
170      }
# Line 178 | Line 187 | public class DelayQueueTest extends JSR1
187      public void testEmpty() {
188          DelayQueue q = new DelayQueue();
189          assertTrue(q.isEmpty());
190 <        assertEquals(NOCAP, q.remainingCapacity());
190 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
191          q.add(new PDelay(1));
192          assertFalse(q.isEmpty());
193          q.add(new PDelay(2));
# Line 188 | Line 197 | public class DelayQueueTest extends JSR1
197      }
198  
199      /**
200 <     * remainingCapacity does not change when elements added or removed,
192 <     * but size does
200 >     * remainingCapacity() always returns Integer.MAX_VALUE
201       */
202      public void testRemainingCapacity() {
203 <        DelayQueue q = populatedQueue(SIZE);
203 >        BlockingQueue q = populatedQueue(SIZE);
204          for (int i = 0; i < SIZE; ++i) {
205 <            assertEquals(NOCAP, q.remainingCapacity());
206 <            assertEquals(SIZE-i, q.size());
207 <            q.remove();
205 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
206 >            assertEquals(SIZE - i, q.size());
207 >            assertTrue(q.remove() instanceof PDelay);
208          }
209          for (int i = 0; i < SIZE; ++i) {
210 <            assertEquals(NOCAP, q.remainingCapacity());
210 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
211              assertEquals(i, q.size());
212 <            q.add(new PDelay(i));
212 >            assertTrue(q.add(new PDelay(i)));
213          }
214      }
215  
216      /**
209     * offer(null) throws NPE
210     */
211    public void testOfferNull() {
212        try {
213            DelayQueue q = new DelayQueue();
214            q.offer(null);
215            shouldThrow();
216        } catch (NullPointerException success) {}
217    }
218
219    /**
220     * add(null) throws NPE
221     */
222    public void testAddNull() {
223        try {
224            DelayQueue q = new DelayQueue();
225            q.add(null);
226            shouldThrow();
227        } catch (NullPointerException success) {}
228    }
229
230    /**
217       * offer non-null succeeds
218       */
219      public void testOffer() {
# Line 248 | Line 234 | public class DelayQueueTest extends JSR1
234      }
235  
236      /**
251     * addAll(null) throws NPE
252     */
253    public void testAddAll1() {
254        try {
255            DelayQueue q = new DelayQueue();
256            q.addAll(null);
257            shouldThrow();
258        } catch (NullPointerException success) {}
259    }
260
261    /**
237       * addAll(this) throws IAE
238       */
239      public void testAddAllSelf() {
240 +        DelayQueue q = populatedQueue(SIZE);
241          try {
266            DelayQueue q = populatedQueue(SIZE);
242              q.addAll(q);
243              shouldThrow();
244          } catch (IllegalArgumentException success) {}
245      }
246  
247      /**
273     * addAll of a collection with null elements throws NPE
274     */
275    public void testAddAll2() {
276        try {
277            DelayQueue q = new DelayQueue();
278            PDelay[] ints = new PDelay[SIZE];
279            q.addAll(Arrays.asList(ints));
280            shouldThrow();
281        } catch (NullPointerException success) {}
282    }
283
284    /**
248       * addAll of a collection with any null elements throws NPE after
249       * possibly adding some elements
250       */
251      public void testAddAll3() {
252 +        DelayQueue q = new DelayQueue();
253 +        PDelay[] a = new PDelay[SIZE];
254 +        for (int i = 0; i < SIZE - 1; ++i)
255 +            a[i] = new PDelay(i);
256          try {
257 <            DelayQueue q = new DelayQueue();
291 <            PDelay[] ints = new PDelay[SIZE];
292 <            for (int i = 0; i < SIZE-1; ++i)
293 <                ints[i] = new PDelay(i);
294 <            q.addAll(Arrays.asList(ints));
257 >            q.addAll(Arrays.asList(a));
258              shouldThrow();
259          } catch (NullPointerException success) {}
260      }
# Line 302 | Line 265 | public class DelayQueueTest extends JSR1
265      public void testAddAll5() {
266          PDelay[] empty = new PDelay[0];
267          PDelay[] ints = new PDelay[SIZE];
268 <        for (int i = SIZE-1; i >= 0; --i)
268 >        for (int i = SIZE - 1; i >= 0; --i)
269              ints[i] = new PDelay(i);
270          DelayQueue q = new DelayQueue();
271          assertFalse(q.addAll(Arrays.asList(empty)));
# Line 312 | Line 275 | public class DelayQueueTest extends JSR1
275      }
276  
277      /**
315     * put(null) throws NPE
316     */
317    public void testPutNull() {
318        try {
319            DelayQueue q = new DelayQueue();
320            q.put(null);
321            shouldThrow();
322        } catch (NullPointerException success) {}
323    }
324
325    /**
278       * all elements successfully put are contained
279       */
280      public void testPut() {
281          DelayQueue q = new DelayQueue();
282          for (int i = 0; i < SIZE; ++i) {
283 <            PDelay I = new PDelay(i);
284 <            q.put(I);
285 <            assertTrue(q.contains(I));
283 >            PDelay x = new PDelay(i);
284 >            q.put(x);
285 >            assertTrue(q.contains(x));
286          }
287          assertEquals(SIZE, q.size());
288      }
# Line 374 | Line 326 | public class DelayQueueTest extends JSR1
326      public void testTake() throws InterruptedException {
327          DelayQueue q = populatedQueue(SIZE);
328          for (int i = 0; i < SIZE; ++i) {
329 <            assertEquals(new PDelay(i), ((PDelay)q.take()));
329 >            assertEquals(new PDelay(i), q.take());
330          }
331      }
332  
333      /**
382     * take blocks interruptibly when empty
383     */
384    public void testTakeFromEmptyBlocksInterruptibly()
385            throws InterruptedException {
386        final BlockingQueue q = new DelayQueue();
387        final CountDownLatch threadStarted = new CountDownLatch(1);
388        Thread t = newStartedThread(new CheckedRunnable() {
389            public void realRun() {
390                threadStarted.countDown();
391                try {
392                    q.take();
393                    shouldThrow();
394                } catch (InterruptedException success) {}
395                assertFalse(Thread.interrupted());
396            }});
397
398        await(threadStarted);
399        assertThreadStaysAlive(t);
400        t.interrupt();
401        awaitTermination(t);
402    }
403
404    /**
334       * Take removes existing elements until empty, then blocks interruptibly
335       */
336      public void testBlockingTake() throws InterruptedException {
# Line 409 | Line 338 | public class DelayQueueTest extends JSR1
338          final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
339          Thread t = newStartedThread(new CheckedRunnable() {
340              public void realRun() throws InterruptedException {
341 <                for (int i = 0; i < SIZE; ++i) {
341 >                for (int i = 0; i < SIZE; i++)
342                      assertEquals(new PDelay(i), ((PDelay)q.take()));
414                }
343  
344                  Thread.currentThread().interrupt();
345                  try {
# Line 429 | Line 357 | public class DelayQueueTest extends JSR1
357              }});
358  
359          await(pleaseInterrupt);
360 <        assertThreadStaysAlive(t);
360 >        assertThreadBlocks(t, Thread.State.WAITING);
361          t.interrupt();
362          awaitTermination(t);
363      }
# Line 440 | Line 368 | public class DelayQueueTest extends JSR1
368      public void testPoll() {
369          DelayQueue q = populatedQueue(SIZE);
370          for (int i = 0; i < SIZE; ++i) {
371 <            assertEquals(new PDelay(i), ((PDelay)q.poll()));
371 >            assertEquals(new PDelay(i), q.poll());
372          }
373          assertNull(q.poll());
374      }
# Line 451 | Line 379 | public class DelayQueueTest extends JSR1
379      public void testTimedPoll0() throws InterruptedException {
380          DelayQueue q = populatedQueue(SIZE);
381          for (int i = 0; i < SIZE; ++i) {
382 <            assertEquals(new PDelay(i), ((PDelay)q.poll(0, MILLISECONDS)));
382 >            assertEquals(new PDelay(i), q.poll(0, MILLISECONDS));
383          }
384          assertNull(q.poll(0, MILLISECONDS));
385      }
# Line 463 | Line 391 | public class DelayQueueTest extends JSR1
391          DelayQueue q = populatedQueue(SIZE);
392          for (int i = 0; i < SIZE; ++i) {
393              long startTime = System.nanoTime();
394 <            assertEquals(new PDelay(i), ((PDelay)q.poll(LONG_DELAY_MS, MILLISECONDS)));
394 >            assertEquals(new PDelay(i), q.poll(LONG_DELAY_MS, MILLISECONDS));
395              assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
396          }
397          long startTime = System.nanoTime();
# Line 478 | Line 406 | public class DelayQueueTest extends JSR1
406       */
407      public void testInterruptedTimedPoll() throws InterruptedException {
408          final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
409 +        final DelayQueue q = populatedQueue(SIZE);
410          Thread t = newStartedThread(new CheckedRunnable() {
411              public void realRun() throws InterruptedException {
412 <                DelayQueue q = populatedQueue(SIZE);
412 >                long startTime = System.nanoTime();
413                  for (int i = 0; i < SIZE; ++i) {
414 <                    assertEquals(new PDelay(i), ((PDelay)q.poll(SHORT_DELAY_MS, MILLISECONDS)));
414 >                    assertEquals(new PDelay(i),
415 >                                 ((PDelay)q.poll(LONG_DELAY_MS, MILLISECONDS)));
416                  }
417  
418                  Thread.currentThread().interrupt();
# Line 498 | Line 428 | public class DelayQueueTest extends JSR1
428                      shouldThrow();
429                  } catch (InterruptedException success) {}
430                  assertFalse(Thread.interrupted());
501            }});
502
503        await(pleaseInterrupt);
504        assertThreadStaysAlive(t);
505        t.interrupt();
506        awaitTermination(t);
507    }
508
509    /**
510     * timed poll before a delayed offer fails; after offer succeeds;
511     * on interruption throws
512     */
513    public void testTimedPollWithOffer() throws InterruptedException {
514        final DelayQueue q = new DelayQueue();
515        final PDelay pdelay = new PDelay(0);
516        final CheckedBarrier barrier = new CheckedBarrier(2);
517        Thread t = newStartedThread(new CheckedRunnable() {
518            public void realRun() throws InterruptedException {
519                assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
520
521                barrier.await();
522                assertSame(pdelay, q.poll(LONG_DELAY_MS, MILLISECONDS));
523
524                Thread.currentThread().interrupt();
525                try {
526                    q.poll(LONG_DELAY_MS, MILLISECONDS);
527                    shouldThrow();
528                } catch (InterruptedException success) {}
529                assertFalse(Thread.interrupted());
431  
432 <                barrier.await();
532 <                try {
533 <                    q.poll(LONG_DELAY_MS, MILLISECONDS);
534 <                    shouldThrow();
535 <                } catch (InterruptedException success) {}
536 <                assertFalse(Thread.interrupted());
432 >                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
433              }});
434  
435 <        barrier.await();
436 <        long startTime = System.nanoTime();
541 <        assertTrue(q.offer(pdelay, LONG_DELAY_MS, MILLISECONDS));
542 <        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
543 <
544 <        barrier.await();
545 <        assertThreadStaysAlive(t);
435 >        await(pleaseInterrupt);
436 >        assertThreadBlocks(t, Thread.State.TIMED_WAITING);
437          t.interrupt();
438          awaitTermination(t);
439 +        checkEmpty(q);
440      }
441  
442      /**
# Line 553 | Line 445 | public class DelayQueueTest extends JSR1
445      public void testPeek() {
446          DelayQueue q = populatedQueue(SIZE);
447          for (int i = 0; i < SIZE; ++i) {
448 <            assertEquals(new PDelay(i), ((PDelay)q.peek()));
449 <            assertEquals(new PDelay(i), ((PDelay)q.poll()));
448 >            assertEquals(new PDelay(i), q.peek());
449 >            assertEquals(new PDelay(i), q.poll());
450              if (q.isEmpty())
451                  assertNull(q.peek());
452              else
# Line 569 | Line 461 | public class DelayQueueTest extends JSR1
461      public void testElement() {
462          DelayQueue q = populatedQueue(SIZE);
463          for (int i = 0; i < SIZE; ++i) {
464 <            assertEquals(new PDelay(i), ((PDelay)q.element()));
464 >            assertEquals(new PDelay(i), q.element());
465              q.poll();
466          }
467          try {
# Line 584 | Line 476 | public class DelayQueueTest extends JSR1
476      public void testRemove() {
477          DelayQueue q = populatedQueue(SIZE);
478          for (int i = 0; i < SIZE; ++i) {
479 <            assertEquals(new PDelay(i), ((PDelay)q.remove()));
479 >            assertEquals(new PDelay(i), q.remove());
480          }
481          try {
482              q.remove();
# Line 593 | Line 485 | public class DelayQueueTest extends JSR1
485      }
486  
487      /**
596     * remove(x) removes x and returns true if present
597     */
598    public void testRemoveElement() {
599        DelayQueue q = populatedQueue(SIZE);
600        for (int i = 1; i < SIZE; i+=2) {
601            assertTrue(q.remove(new PDelay(i)));
602        }
603        for (int i = 0; i < SIZE; i+=2) {
604            assertTrue(q.remove(new PDelay(i)));
605            assertFalse(q.remove(new PDelay(i+1)));
606        }
607        assertTrue(q.isEmpty());
608    }
609
610    /**
488       * contains(x) reports true when elements added but not yet removed
489       */
490      public void testContains() {
# Line 627 | Line 504 | public class DelayQueueTest extends JSR1
504          q.clear();
505          assertTrue(q.isEmpty());
506          assertEquals(0, q.size());
507 <        assertEquals(NOCAP, q.remainingCapacity());
507 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
508          PDelay x = new PDelay(1);
509          q.add(x);
510          assertFalse(q.isEmpty());
# Line 664 | Line 541 | public class DelayQueueTest extends JSR1
541                  assertTrue(changed);
542  
543              assertTrue(q.containsAll(p));
544 <            assertEquals(SIZE-i, q.size());
544 >            assertEquals(SIZE - i, q.size());
545              p.remove();
546          }
547      }
# Line 677 | Line 554 | public class DelayQueueTest extends JSR1
554              DelayQueue q = populatedQueue(SIZE);
555              DelayQueue p = populatedQueue(i);
556              assertTrue(q.removeAll(p));
557 <            assertEquals(SIZE-i, q.size());
557 >            assertEquals(SIZE - i, q.size());
558              for (int j = 0; j < i; ++j) {
559 <                PDelay I = (PDelay)(p.remove());
560 <                assertFalse(q.contains(I));
559 >                PDelay x = (PDelay)(p.remove());
560 >                assertFalse(q.contains(x));
561              }
562          }
563      }
# Line 710 | Line 587 | public class DelayQueueTest extends JSR1
587      }
588  
589      /**
713     * toArray(null) throws NullPointerException
714     */
715    public void testToArray_NullArg() {
716        DelayQueue q = populatedQueue(SIZE);
717        try {
718            q.toArray(null);
719            shouldThrow();
720        } catch (NullPointerException success) {}
721    }
722
723    /**
590       * toArray(incompatible array type) throws ArrayStoreException
591       */
592      public void testToArray1_BadArg() {
# Line 743 | Line 609 | public class DelayQueueTest extends JSR1
609              ++i;
610          }
611          assertEquals(i, SIZE);
612 +        assertIteratorExhausted(it);
613 +    }
614 +
615 +    /**
616 +     * iterator of empty collection has no elements
617 +     */
618 +    public void testEmptyIterator() {
619 +        assertIteratorExhausted(new DelayQueue().iterator());
620      }
621  
622      /**
# Line 757 | Line 631 | public class DelayQueueTest extends JSR1
631          it.next();
632          it.remove();
633          it = q.iterator();
634 <        assertEquals(it.next(), new PDelay(2));
635 <        assertEquals(it.next(), new PDelay(3));
634 >        assertEquals(new PDelay(2), it.next());
635 >        assertEquals(new PDelay(3), it.next());
636          assertFalse(it.hasNext());
637      }
638  
# Line 768 | Line 642 | public class DelayQueueTest extends JSR1
642      public void testToString() {
643          DelayQueue q = populatedQueue(SIZE);
644          String s = q.toString();
645 <        for (int i = 0; i < SIZE; ++i) {
646 <            assertTrue(s.contains(String.valueOf(Integer.MIN_VALUE+i)));
773 <        }
645 >        for (Object e : q)
646 >            assertTrue(s.contains(e.toString()));
647      }
648  
649      /**
# Line 779 | Line 652 | public class DelayQueueTest extends JSR1
652      public void testPollInExecutor() {
653          final DelayQueue q = new DelayQueue();
654          final CheckedBarrier threadsStarted = new CheckedBarrier(2);
655 <        ExecutorService executor = Executors.newFixedThreadPool(2);
656 <        executor.execute(new CheckedRunnable() {
657 <            public void realRun() throws InterruptedException {
658 <                assertNull(q.poll());
659 <                threadsStarted.await();
660 <                assertTrue(null != q.poll(LONG_DELAY_MS, MILLISECONDS));
661 <                checkEmpty(q);
662 <            }});
663 <
664 <        executor.execute(new CheckedRunnable() {
665 <            public void realRun() throws InterruptedException {
666 <                threadsStarted.await();
667 <                q.put(new PDelay(1));
668 <            }});
669 <
670 <        joinPool(executor);
655 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
656 >        try (PoolCleaner cleaner = cleaner(executor)) {
657 >            executor.execute(new CheckedRunnable() {
658 >                public void realRun() throws InterruptedException {
659 >                    assertNull(q.poll());
660 >                    threadsStarted.await();
661 >                    assertNotNull(q.poll(LONG_DELAY_MS, MILLISECONDS));
662 >                    checkEmpty(q);
663 >                }});
664 >
665 >            executor.execute(new CheckedRunnable() {
666 >                public void realRun() throws InterruptedException {
667 >                    threadsStarted.await();
668 >                    q.put(new PDelay(1));
669 >                }});
670 >        }
671      }
672  
673      /**
674       * Delayed actions do not occur until their delay elapses
675       */
676      public void testDelay() throws InterruptedException {
677 <        DelayQueue<NanoDelay> q = new DelayQueue<NanoDelay>();
677 >        DelayQueue<NanoDelay> q = new DelayQueue<>();
678          for (int i = 0; i < SIZE; ++i)
679              q.add(new NanoDelay(1000000L * (SIZE - i)));
680  
# Line 841 | Line 714 | public class DelayQueueTest extends JSR1
714      public void testTimedPollDelayed() throws InterruptedException {
715          DelayQueue q = new DelayQueue();
716          q.add(new NanoDelay(LONG_DELAY_MS * 1000000L));
717 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
718 <    }
719 <
847 <    /**
848 <     * drainTo(null) throws NPE
849 <     */
850 <    public void testDrainToNull() {
851 <        DelayQueue q = populatedQueue(SIZE);
852 <        try {
853 <            q.drainTo(null);
854 <            shouldThrow();
855 <        } catch (NullPointerException success) {}
856 <    }
857 <
858 <    /**
859 <     * drainTo(this) throws IAE
860 <     */
861 <    public void testDrainToSelf() {
862 <        DelayQueue q = populatedQueue(SIZE);
863 <        try {
864 <            q.drainTo(q);
865 <            shouldThrow();
866 <        } catch (IllegalArgumentException success) {}
717 >        long startTime = System.nanoTime();
718 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
719 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
720      }
721  
722      /**
# Line 878 | Line 731 | public class DelayQueueTest extends JSR1
731          }
732          ArrayList l = new ArrayList();
733          q.drainTo(l);
734 <        assertEquals(q.size(), 0);
734 >        assertEquals(0, q.size());
735          for (int i = 0; i < SIZE; ++i)
736 <            assertEquals(l.get(i), elems[i]);
736 >            assertEquals(elems[i], l.get(i));
737          q.add(elems[0]);
738          q.add(elems[1]);
739          assertFalse(q.isEmpty());
# Line 888 | Line 741 | public class DelayQueueTest extends JSR1
741          assertTrue(q.contains(elems[1]));
742          l.clear();
743          q.drainTo(l);
744 <        assertEquals(q.size(), 0);
745 <        assertEquals(l.size(), 2);
744 >        assertEquals(0, q.size());
745 >        assertEquals(2, l.size());
746          for (int i = 0; i < 2; ++i)
747 <            assertEquals(l.get(i), elems[i]);
747 >            assertEquals(elems[i], l.get(i));
748      }
749  
750      /**
# Line 901 | Line 754 | public class DelayQueueTest extends JSR1
754          final DelayQueue q = populatedQueue(SIZE);
755          Thread t = new Thread(new CheckedRunnable() {
756              public void realRun() {
757 <                q.put(new PDelay(SIZE+1));
757 >                q.put(new PDelay(SIZE + 1));
758              }});
759  
760          t.start();
# Line 913 | Line 766 | public class DelayQueueTest extends JSR1
766      }
767  
768      /**
916     * drainTo(null, n) throws NPE
917     */
918    public void testDrainToNullN() {
919        DelayQueue q = populatedQueue(SIZE);
920        try {
921            q.drainTo(null, 0);
922            shouldThrow();
923        } catch (NullPointerException success) {}
924    }
925
926    /**
927     * drainTo(this, n) throws IAE
928     */
929    public void testDrainToSelfN() {
930        DelayQueue q = populatedQueue(SIZE);
931        try {
932            q.drainTo(q, 0);
933            shouldThrow();
934        } catch (IllegalArgumentException success) {}
935    }
936
937    /**
769       * drainTo(c, n) empties first min(n, size) elements of queue into c
770       */
771      public void testDrainToN() {
# Line 943 | Line 774 | public class DelayQueueTest extends JSR1
774              ArrayList l = new ArrayList();
775              q.drainTo(l, i);
776              int k = (i < SIZE) ? i : SIZE;
777 <            assertEquals(q.size(), SIZE-k);
778 <            assertEquals(l.size(), k);
777 >            assertEquals(SIZE - k, q.size());
778 >            assertEquals(k, l.size());
779          }
780      }
781  
782 +    /**
783 +     * remove(null), contains(null) always return false
784 +     */
785 +    public void testNeverContainsNull() {
786 +        Collection<?> q = populatedQueue(SIZE);
787 +        assertFalse(q.contains(null));
788 +        assertFalse(q.remove(null));
789 +    }
790   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines