--- jsr166/src/test/tck/ExecutorCompletionServiceTest.java	2011/05/06 11:22:07	1.14
+++ jsr166/src/test/tck/ExecutorCompletionServiceTest.java	2015/02/22 04:34:44	1.20
@@ -6,14 +6,22 @@
  * Pat Fisher, Mike Judd.
  */
 
-
-import junit.framework.*;
-import java.util.*;
-import java.util.concurrent.*;
 import static java.util.concurrent.TimeUnit.MILLISECONDS;
-import java.util.concurrent.atomic.*;
-import java.math.BigInteger;
-import java.security.*;
+
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutorCompletionService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Future;
+import java.util.concurrent.FutureTask;
+import java.util.concurrent.RunnableFuture;
+import java.util.concurrent.ThreadPoolExecutor;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+import junit.framework.Test;
+import junit.framework.TestSuite;
 
 public class ExecutorCompletionServiceTest extends JSR166TestCase {
     public static void main(String[] args) {
@@ -23,13 +31,12 @@ public class ExecutorCompletionServiceTe
         return new TestSuite(ExecutorCompletionServiceTest.class);
     }
 
-
     /**
      * Creating a new ECS with null Executor throw NPE
      */
     public void testConstructorNPE() {
         try {
-            ExecutorCompletionService ecs = new ExecutorCompletionService(null);
+            new ExecutorCompletionService(null);
             shouldThrow();
         } catch (NullPointerException success) {}
     }
@@ -40,7 +47,7 @@ public class ExecutorCompletionServiceTe
     public void testConstructorNPE2() {
         try {
             ExecutorService e = Executors.newCachedThreadPool();
-            ExecutorCompletionService ecs = new ExecutorCompletionService(e, null);
+            new ExecutorCompletionService(e, null);
             shouldThrow();
         } catch (NullPointerException success) {}
     }
@@ -112,21 +119,23 @@ public class ExecutorCompletionServiceTe
     /**
      * If poll returns non-null, the returned task is completed
      */
-    public void testPoll1() throws InterruptedException {
+    public void testPoll1() throws Exception {
         ExecutorService e = Executors.newCachedThreadPool();
         ExecutorCompletionService ecs = new ExecutorCompletionService(e);
         try {
             assertNull(ecs.poll());
             Callable c = new StringTask();
             ecs.submit(c);
-            delay(SHORT_DELAY_MS);
-            for (;;) {
-                Future f = ecs.poll();
-                if (f != null) {
-                    assertTrue(f.isDone());
-                    break;
-                }
+
+            long startTime = System.nanoTime();
+            Future f;
+            while ((f = ecs.poll()) == null) {
+                if (millisElapsedSince(startTime) > LONG_DELAY_MS)
+                    fail("timed out");
+                Thread.yield();
             }
+            assertTrue(f.isDone());
+            assertSame(TEST_STRING, f.get());
         } finally {
             joinPool(e);
         }