ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ExecutorsTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ExecutorsTest.java (file contents):
Revision 1.50 by jsr166, Wed Aug 16 17:18:34 2017 UTC vs.
Revision 1.54 by jsr166, Sat Feb 1 18:52:17 2020 UTC

# Line 63 | Line 63 | public class ExecutorsTest extends JSR16
63       */
64      public void testNewCachedThreadPool3() {
65          try {
66 <            ExecutorService e = Executors.newCachedThreadPool(null);
66 >            ExecutorService unused = Executors.newCachedThreadPool(null);
67              shouldThrow();
68          } catch (NullPointerException success) {}
69      }
# Line 97 | Line 97 | public class ExecutorsTest extends JSR16
97       */
98      public void testNewSingleThreadExecutor3() {
99          try {
100 <            ExecutorService e = Executors.newSingleThreadExecutor(null);
100 >            ExecutorService unused = Executors.newSingleThreadExecutor(null);
101              shouldThrow();
102          } catch (NullPointerException success) {}
103      }
# Line 145 | Line 145 | public class ExecutorsTest extends JSR16
145       */
146      public void testNewFixedThreadPool3() {
147          try {
148 <            ExecutorService e = Executors.newFixedThreadPool(2, null);
148 >            ExecutorService unused = Executors.newFixedThreadPool(2, null);
149              shouldThrow();
150          } catch (NullPointerException success) {}
151      }
# Line 155 | Line 155 | public class ExecutorsTest extends JSR16
155       */
156      public void testNewFixedThreadPool4() {
157          try {
158 <            ExecutorService e = Executors.newFixedThreadPool(0);
158 >            ExecutorService unused = Executors.newFixedThreadPool(0);
159              shouldThrow();
160          } catch (IllegalArgumentException success) {}
161      }
# Line 177 | Line 177 | public class ExecutorsTest extends JSR16
177       */
178      public void testUnconfigurableExecutorServiceNPE() {
179          try {
180 <            ExecutorService e = Executors.unconfigurableExecutorService(null);
180 >            ExecutorService unused =
181 >                Executors.unconfigurableExecutorService(null);
182              shouldThrow();
183          } catch (NullPointerException success) {}
184      }
# Line 187 | Line 188 | public class ExecutorsTest extends JSR16
188       */
189      public void testUnconfigurableScheduledExecutorServiceNPE() {
190          try {
191 <            ExecutorService e = Executors.unconfigurableScheduledExecutorService(null);
191 >            ExecutorService unused =
192 >                Executors.unconfigurableScheduledExecutorService(null);
193              shouldThrow();
194          } catch (NullPointerException success) {}
195      }
# Line 277 | Line 279 | public class ExecutorsTest extends JSR16
279              Executors.newScheduledThreadPool(2),
280          };
281  
282 <        final Runnable sleeper = new CheckedInterruptedRunnable() {
282 >        final CountDownLatch done = new CountDownLatch(1);
283 >
284 >        final Runnable sleeper = new CheckedRunnable() {
285              public void realRun() throws InterruptedException {
286 <                delay(LONG_DELAY_MS);
286 >                done.await(LONG_DELAY_MS, MILLISECONDS);
287              }};
288  
289          List<Thread> threads = new ArrayList<>();
# Line 292 | Line 296 | public class ExecutorsTest extends JSR16
296          }
297          for (Thread thread : threads)
298              awaitTermination(thread);
299 +        done.countDown();
300          for (ExecutorService executor : executors)
301              joinPool(executor);
302      }
# Line 551 | Line 556 | public class ExecutorsTest extends JSR16
556       */
557      public void testCallableNPE1() {
558          try {
559 <            Callable c = Executors.callable((Runnable) null);
559 >            Callable unused = Executors.callable((Runnable) null);
560              shouldThrow();
561          } catch (NullPointerException success) {}
562      }
# Line 561 | Line 566 | public class ExecutorsTest extends JSR16
566       */
567      public void testCallableNPE2() {
568          try {
569 <            Callable c = Executors.callable((Runnable) null, one);
569 >            Callable unused = Executors.callable((Runnable) null, one);
570              shouldThrow();
571          } catch (NullPointerException success) {}
572      }
# Line 571 | Line 576 | public class ExecutorsTest extends JSR16
576       */
577      public void testCallableNPE3() {
578          try {
579 <            Callable c = Executors.callable((PrivilegedAction) null);
579 >            Callable unused = Executors.callable((PrivilegedAction) null);
580              shouldThrow();
581          } catch (NullPointerException success) {}
582      }
# Line 581 | Line 586 | public class ExecutorsTest extends JSR16
586       */
587      public void testCallableNPE4() {
588          try {
589 <            Callable c = Executors.callable((PrivilegedExceptionAction) null);
589 >            Callable unused = Executors.callable((PrivilegedExceptionAction) null);
590              shouldThrow();
591          } catch (NullPointerException success) {}
592      }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines