ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ExecutorsTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ExecutorsTest.java (file contents):
Revision 1.6 by dl, Fri Sep 26 15:33:13 2003 UTC vs.
Revision 1.48 by jsr166, Sat Mar 18 20:42:20 2017 UTC

# Line 1 | Line 1
1   /*
2 < * Written by members of JCP JSR-166 Expert Group and released to the
3 < * public domain. Use, modify, and redistribute this code in any way
4 < * without acknowledgement. Other contributors include Andrew Wright,
5 < * Jeffrey Hayes, Pat Fischer, Mike Judd.
2 > * Written by Doug Lea with assistance from members of JCP JSR-166
3 > * Expert Group and released to the public domain, as explained at
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5 > * Other contributors include Andrew Wright, Jeffrey Hayes,
6 > * Pat Fisher, Mike Judd.
7   */
8  
9 + import static java.util.concurrent.TimeUnit.MILLISECONDS;
10  
11 < import junit.framework.*;
12 < import java.util.*;
13 < import java.util.concurrent.*;
14 < import java.math.BigInteger;
11 > import java.security.AccessControlContext;
12 > import java.security.AccessControlException;
13 > import java.security.AccessController;
14 > import java.security.PrivilegedAction;
15 > import java.security.PrivilegedExceptionAction;
16 > import java.util.ArrayList;
17 > import java.util.List;
18 > import java.util.concurrent.Callable;
19 > import java.util.concurrent.CountDownLatch;
20 > import java.util.concurrent.Executors;
21 > import java.util.concurrent.ExecutorService;
22 > import java.util.concurrent.Future;
23 > import java.util.concurrent.ScheduledExecutorService;
24 > import java.util.concurrent.ThreadPoolExecutor;
25  
26 < public class ExecutorsTest extends JSR166TestCase{
26 > import junit.framework.Test;
27 > import junit.framework.TestSuite;
28 >
29 > public class ExecutorsTest extends JSR166TestCase {
30      public static void main(String[] args) {
31 <        junit.textui.TestRunner.run (suite());  
31 >        main(suite(), args);
32      }
33      public static Test suite() {
34 <        return new TestSuite(ExecutorsTest.class);
20 <    }
21 <
22 <    private static final String TEST_STRING = "a test string";
23 <
24 <    private static class StringTask implements Callable<String> {
25 <        public String call() { return TEST_STRING; }
26 <    }
27 <
28 <    static class DirectExecutor implements Executor {
29 <        public void execute(Runnable r) {
30 <            r.run();
31 <        }
34 >        return new TestSuite(ExecutorsTest.class);
35      }
36  
34    static class TimedCallable<T> implements Callable<T> {
35        private final Executor exec;
36        private final Callable<T> func;
37        private final long msecs;
38        
39        TimedCallable(Executor exec, Callable<T> func, long msecs) {
40            this.exec = exec;
41            this.func = func;
42            this.msecs = msecs;
43        }
44        
45        public T call() throws Exception {
46            Future<T> ftask = Executors.execute(exec, func);
47            try {
48                return ftask.get(msecs, TimeUnit.MILLISECONDS);
49            } finally {
50                ftask.cancel(true);
51            }
52        }
53    }
54
55
56    private static class Fib implements Callable<BigInteger> {
57        private final BigInteger n;
58        Fib(long n) {
59            if (n < 0) throw new IllegalArgumentException("need non-negative arg, but got " + n);
60            this.n = BigInteger.valueOf(n);
61        }
62        public BigInteger call() {
63            BigInteger f1 = BigInteger.ONE;
64            BigInteger f2 = f1;
65            for (BigInteger i = BigInteger.ZERO; i.compareTo(n) < 0; i = i.add(BigInteger.ONE)) {
66                BigInteger t = f1.add(f2);
67                f1 = f2;
68                f2 = t;
69            }
70            return f1;
71        }
72    };
73
37      /**
38       * A newCachedThreadPool can execute runnables
39       */
40      public void testNewCachedThreadPool1() {
41 <        ExecutorService e = Executors.newCachedThreadPool();
42 <        e.execute(new NoOpRunnable());
43 <        e.execute(new NoOpRunnable());
44 <        e.execute(new NoOpRunnable());
45 <        e.shutdown();
41 >        final ExecutorService e = Executors.newCachedThreadPool();
42 >        try (PoolCleaner cleaner = cleaner(e)) {
43 >            e.execute(new NoOpRunnable());
44 >            e.execute(new NoOpRunnable());
45 >            e.execute(new NoOpRunnable());
46 >        }
47      }
48  
49      /**
50       * A newCachedThreadPool with given ThreadFactory can execute runnables
51       */
52      public void testNewCachedThreadPool2() {
53 <        ExecutorService e = Executors.newCachedThreadPool(new SimpleThreadFactory());
54 <        e.execute(new NoOpRunnable());
55 <        e.execute(new NoOpRunnable());
56 <        e.execute(new NoOpRunnable());
57 <        e.shutdown();
53 >        final ExecutorService e = Executors.newCachedThreadPool(new SimpleThreadFactory());
54 >        try (PoolCleaner cleaner = cleaner(e)) {
55 >            e.execute(new NoOpRunnable());
56 >            e.execute(new NoOpRunnable());
57 >            e.execute(new NoOpRunnable());
58 >        }
59      }
60  
61      /**
# Line 100 | Line 65 | public class ExecutorsTest extends JSR16
65          try {
66              ExecutorService e = Executors.newCachedThreadPool(null);
67              shouldThrow();
68 <        }
104 <        catch(NullPointerException success) {
105 <        }
68 >        } catch (NullPointerException success) {}
69      }
70  
108
71      /**
72       * A new SingleThreadExecutor can execute runnables
73       */
74      public void testNewSingleThreadExecutor1() {
75 <        ExecutorService e = Executors.newSingleThreadExecutor();
76 <        e.execute(new NoOpRunnable());
77 <        e.execute(new NoOpRunnable());
78 <        e.execute(new NoOpRunnable());
79 <        e.shutdown();
75 >        final ExecutorService e = Executors.newSingleThreadExecutor();
76 >        try (PoolCleaner cleaner = cleaner(e)) {
77 >            e.execute(new NoOpRunnable());
78 >            e.execute(new NoOpRunnable());
79 >            e.execute(new NoOpRunnable());
80 >        }
81      }
82  
83      /**
84       * A new SingleThreadExecutor with given ThreadFactory can execute runnables
85       */
86      public void testNewSingleThreadExecutor2() {
87 <        ExecutorService e = Executors.newSingleThreadExecutor(new SimpleThreadFactory());
88 <        e.execute(new NoOpRunnable());
89 <        e.execute(new NoOpRunnable());
90 <        e.execute(new NoOpRunnable());
91 <        e.shutdown();
87 >        final ExecutorService e = Executors.newSingleThreadExecutor(new SimpleThreadFactory());
88 >        try (PoolCleaner cleaner = cleaner(e)) {
89 >            e.execute(new NoOpRunnable());
90 >            e.execute(new NoOpRunnable());
91 >            e.execute(new NoOpRunnable());
92 >        }
93      }
94  
95      /**
# Line 135 | Line 99 | public class ExecutorsTest extends JSR16
99          try {
100              ExecutorService e = Executors.newSingleThreadExecutor(null);
101              shouldThrow();
102 <        }
103 <        catch(NullPointerException success) {
102 >        } catch (NullPointerException success) {}
103 >    }
104 >
105 >    /**
106 >     * A new SingleThreadExecutor cannot be casted to concrete implementation
107 >     */
108 >    public void testCastNewSingleThreadExecutor() {
109 >        final ExecutorService e = Executors.newSingleThreadExecutor();
110 >        try (PoolCleaner cleaner = cleaner(e)) {
111 >            try {
112 >                ThreadPoolExecutor tpe = (ThreadPoolExecutor)e;
113 >                shouldThrow();
114 >            } catch (ClassCastException success) {}
115          }
116      }
117  
# Line 144 | Line 119 | public class ExecutorsTest extends JSR16
119       * A new newFixedThreadPool can execute runnables
120       */
121      public void testNewFixedThreadPool1() {
122 <        ExecutorService e = Executors.newFixedThreadPool(2);
123 <        e.execute(new NoOpRunnable());
124 <        e.execute(new NoOpRunnable());
125 <        e.execute(new NoOpRunnable());
126 <        e.shutdown();
122 >        final ExecutorService e = Executors.newFixedThreadPool(2);
123 >        try (PoolCleaner cleaner = cleaner(e)) {
124 >            e.execute(new NoOpRunnable());
125 >            e.execute(new NoOpRunnable());
126 >            e.execute(new NoOpRunnable());
127 >        }
128      }
129  
130      /**
131       * A new newFixedThreadPool with given ThreadFactory can execute runnables
132       */
133      public void testNewFixedThreadPool2() {
134 <        ExecutorService e = Executors.newFixedThreadPool(2, new SimpleThreadFactory());
135 <        e.execute(new NoOpRunnable());
136 <        e.execute(new NoOpRunnable());
137 <        e.execute(new NoOpRunnable());
138 <        e.shutdown();
134 >        final ExecutorService e = Executors.newFixedThreadPool(2, new SimpleThreadFactory());
135 >        try (PoolCleaner cleaner = cleaner(e)) {
136 >            e.execute(new NoOpRunnable());
137 >            e.execute(new NoOpRunnable());
138 >            e.execute(new NoOpRunnable());
139 >        }
140      }
141  
142      /**
# Line 169 | Line 146 | public class ExecutorsTest extends JSR16
146          try {
147              ExecutorService e = Executors.newFixedThreadPool(2, null);
148              shouldThrow();
149 <        }
173 <        catch(NullPointerException success) {
174 <        }
149 >        } catch (NullPointerException success) {}
150      }
151  
152      /**
# Line 181 | Line 156 | public class ExecutorsTest extends JSR16
156          try {
157              ExecutorService e = Executors.newFixedThreadPool(0);
158              shouldThrow();
159 <        }
185 <        catch(IllegalArgumentException success) {
186 <        }
159 >        } catch (IllegalArgumentException success) {}
160      }
161  
162      /**
163 <     * execute of runnable runs it to completion
163 >     * An unconfigurable newFixedThreadPool can execute runnables
164       */
165 <    public void testExecuteRunnable () {
166 <        try {
167 <            Executor e = new DirectExecutor();
168 <            TrackedRunnable task = new TrackedRunnable();
169 <            assertFalse(task.done);
170 <            Future<String> future = Executors.execute(e, task, TEST_STRING);
198 <            String result = future.get();
199 <            assertTrue(task.done);
200 <            assertSame(TEST_STRING, result);
201 <        }
202 <        catch (ExecutionException ex) {
203 <            unexpectedException();
204 <        }
205 <        catch (InterruptedException ex) {
206 <            unexpectedException();
165 >    public void testUnconfigurableExecutorService() {
166 >        final ExecutorService e = Executors.unconfigurableExecutorService(Executors.newFixedThreadPool(2));
167 >        try (PoolCleaner cleaner = cleaner(e)) {
168 >            e.execute(new NoOpRunnable());
169 >            e.execute(new NoOpRunnable());
170 >            e.execute(new NoOpRunnable());
171          }
172      }
173  
174      /**
175 <     * invoke of a runnable runs it to completion
175 >     * unconfigurableExecutorService(null) throws NPE
176       */
177 <    public void testInvokeRunnable () {
177 >    public void testUnconfigurableExecutorServiceNPE() {
178          try {
179 <            Executor e = new DirectExecutor();
180 <            TrackedRunnable task = new TrackedRunnable();
181 <            assertFalse(task.done);
218 <            Executors.invoke(e, task);
219 <            assertTrue(task.done);
220 <        }
221 <        catch (ExecutionException ex) {
222 <            unexpectedException();
223 <        }
224 <        catch (InterruptedException ex) {
225 <            unexpectedException();
226 <        }
179 >            ExecutorService e = Executors.unconfigurableExecutorService(null);
180 >            shouldThrow();
181 >        } catch (NullPointerException success) {}
182      }
183  
184      /**
185 <     * execute of a callable runs it to completion
185 >     * unconfigurableScheduledExecutorService(null) throws NPE
186       */
187 <    public void testExecuteCallable () {
187 >    public void testUnconfigurableScheduledExecutorServiceNPE() {
188          try {
189 <            Executor e = new DirectExecutor();
190 <            Future<String> future = Executors.execute(e, new StringTask());
191 <            String result = future.get();
237 <            assertSame(TEST_STRING, result);
238 <        }
239 <        catch (ExecutionException ex) {
240 <            unexpectedException();
241 <        }
242 <        catch (InterruptedException ex) {
243 <            unexpectedException();
244 <        }
189 >            ExecutorService e = Executors.unconfigurableScheduledExecutorService(null);
190 >            shouldThrow();
191 >        } catch (NullPointerException success) {}
192      }
193  
194      /**
195 <     * invoke of a collable runs it to completion
195 >     * a newSingleThreadScheduledExecutor successfully runs delayed task
196       */
197 <    public void testInvokeCallable () {
198 <        try {
199 <            Executor e = new DirectExecutor();
200 <            String result = Executors.invoke(e, new StringTask());
201 <
202 <            assertSame(TEST_STRING, result);
203 <        }
204 <        catch (ExecutionException ex) {
205 <            unexpectedException();
206 <        }
207 <        catch (InterruptedException ex) {
208 <            unexpectedException();
197 >    public void testNewSingleThreadScheduledExecutor() throws Exception {
198 >        final ScheduledExecutorService p = Executors.newSingleThreadScheduledExecutor();
199 >        try (PoolCleaner cleaner = cleaner(p)) {
200 >            final CountDownLatch proceed = new CountDownLatch(1);
201 >            final Runnable task = new CheckedRunnable() {
202 >                public void realRun() {
203 >                    await(proceed);
204 >                }};
205 >            long startTime = System.nanoTime();
206 >            Future f = p.schedule(Executors.callable(task, Boolean.TRUE),
207 >                                  timeoutMillis(), MILLISECONDS);
208 >            assertFalse(f.isDone());
209 >            proceed.countDown();
210 >            assertSame(Boolean.TRUE, f.get(LONG_DELAY_MS, MILLISECONDS));
211 >            assertSame(Boolean.TRUE, f.get());
212 >            assertTrue(f.isDone());
213 >            assertFalse(f.isCancelled());
214 >            assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
215          }
216      }
217  
218      /**
219 <     * execute with null executor throws NPE
219 >     * a newScheduledThreadPool successfully runs delayed task
220       */
221 <    public void testNullExecuteRunnable () {
222 <        try {
223 <            TrackedRunnable task = new TrackedRunnable();
224 <            assertFalse(task.done);
225 <            Future<String> future = Executors.execute(null, task, TEST_STRING);
226 <            shouldThrow();
227 <        }
228 <        catch (NullPointerException success) {
229 <        }
230 <        catch (Exception ex) {
231 <            unexpectedException();
221 >    public void testNewScheduledThreadPool() throws Exception {
222 >        final ScheduledExecutorService p = Executors.newScheduledThreadPool(2);
223 >        try (PoolCleaner cleaner = cleaner(p)) {
224 >            final CountDownLatch proceed = new CountDownLatch(1);
225 >            final Runnable task = new CheckedRunnable() {
226 >                public void realRun() {
227 >                    await(proceed);
228 >                }};
229 >            long startTime = System.nanoTime();
230 >            Future f = p.schedule(Executors.callable(task, Boolean.TRUE),
231 >                                  timeoutMillis(), MILLISECONDS);
232 >            assertFalse(f.isDone());
233 >            proceed.countDown();
234 >            assertSame(Boolean.TRUE, f.get(LONG_DELAY_MS, MILLISECONDS));
235 >            assertSame(Boolean.TRUE, f.get());
236 >            assertTrue(f.isDone());
237 >            assertFalse(f.isCancelled());
238 >            assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
239          }
240      }
241  
242      /**
243 <     * execute with a null runnable throws NPE
243 >     * an unconfigurable newScheduledThreadPool successfully runs delayed task
244       */
245 <    public void testExecuteNullRunnable() {
246 <        try {
247 <            Executor e = new DirectExecutor();
248 <            TrackedRunnable task = null;
249 <            Future<String> future = Executors.execute(e, task, TEST_STRING);
250 <            shouldThrow();
251 <        }
252 <        catch (NullPointerException success) {
253 <        }
254 <        catch (Exception ex) {
255 <            unexpectedException();
245 >    public void testUnconfigurableScheduledExecutorService() throws Exception {
246 >        final ScheduledExecutorService p =
247 >            Executors.unconfigurableScheduledExecutorService
248 >            (Executors.newScheduledThreadPool(2));
249 >        try (PoolCleaner cleaner = cleaner(p)) {
250 >            final CountDownLatch proceed = new CountDownLatch(1);
251 >            final Runnable task = new CheckedRunnable() {
252 >                public void realRun() {
253 >                    await(proceed);
254 >                }};
255 >            long startTime = System.nanoTime();
256 >            Future f = p.schedule(Executors.callable(task, Boolean.TRUE),
257 >                                  timeoutMillis(), MILLISECONDS);
258 >            assertFalse(f.isDone());
259 >            proceed.countDown();
260 >            assertSame(Boolean.TRUE, f.get(LONG_DELAY_MS, MILLISECONDS));
261 >            assertSame(Boolean.TRUE, f.get());
262 >            assertTrue(f.isDone());
263 >            assertFalse(f.isCancelled());
264 >            assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
265          }
266      }
267  
268      /**
269 <     * invoke of a null runnable throws NPE
269 >     * Future.get on submitted tasks will time out if they compute too long.
270       */
271 <    public void testInvokeNullRunnable () {
272 <        try {
273 <            Executor e = new DirectExecutor();
274 <            TrackedRunnable task = null;
275 <            Executors.invoke(e, task);
276 <            shouldThrow();
277 <        }
278 <        catch (NullPointerException success) {
279 <        }
280 <        catch (Exception ex) {
281 <            unexpectedException();
271 >    public void testTimedCallable() throws Exception {
272 >        final ExecutorService[] executors = {
273 >            Executors.newSingleThreadExecutor(),
274 >            Executors.newCachedThreadPool(),
275 >            Executors.newFixedThreadPool(2),
276 >            Executors.newScheduledThreadPool(2),
277 >        };
278 >
279 >        final Runnable sleeper = new CheckedInterruptedRunnable() {
280 >            public void realRun() throws InterruptedException {
281 >                delay(LONG_DELAY_MS);
282 >            }};
283 >
284 >        List<Thread> threads = new ArrayList<>();
285 >        for (final ExecutorService executor : executors) {
286 >            threads.add(newStartedThread(new CheckedRunnable() {
287 >                public void realRun() {
288 >                    Future future = executor.submit(sleeper);
289 >                    assertFutureTimesOut(future);
290 >                }}));
291          }
292 +        for (Thread thread : threads)
293 +            awaitTermination(thread);
294 +        for (ExecutorService executor : executors)
295 +            joinPool(executor);
296      }
297  
298      /**
299 <     * execute of a null callable throws NPE
299 >     * ThreadPoolExecutor using defaultThreadFactory has
300 >     * specified group, priority, daemon status, and name
301       */
302 <    public void testExecuteNullCallable () {
303 <        try {
304 <            Executor e = new DirectExecutor();
305 <            StringTask t = null;
306 <            Future<String> future = Executors.execute(e, t);
307 <            shouldThrow();
308 <        }
309 <        catch (NullPointerException success) {
310 <        }
311 <        catch (Exception ex) {
312 <            unexpectedException();
302 >    public void testDefaultThreadFactory() throws Exception {
303 >        final ThreadGroup egroup = Thread.currentThread().getThreadGroup();
304 >        final CountDownLatch done = new CountDownLatch(1);
305 >        Runnable r = new CheckedRunnable() {
306 >            public void realRun() {
307 >                try {
308 >                    Thread current = Thread.currentThread();
309 >                    assertFalse(current.isDaemon());
310 >                    assertTrue(current.getPriority() <= Thread.NORM_PRIORITY);
311 >                    SecurityManager s = System.getSecurityManager();
312 >                    assertSame(current.getThreadGroup(),
313 >                               (s == null) ? egroup : s.getThreadGroup());
314 >                    assertTrue(current.getName().endsWith("thread-1"));
315 >                } catch (SecurityException ok) {
316 >                    // Also pass if not allowed to change setting
317 >                }
318 >                done.countDown();
319 >            }};
320 >        ExecutorService e = Executors.newSingleThreadExecutor(Executors.defaultThreadFactory());
321 >        try (PoolCleaner cleaner = cleaner(e)) {
322 >            e.execute(r);
323 >            await(done);
324          }
325      }
326  
327      /**
328 <     * invoke of a null callable throws NPE
329 <     */
330 <    public void testInvokeNullCallable () {
331 <        try {
332 <            Executor e = new DirectExecutor();
333 <            StringTask t = null;
334 <            String result = Executors.invoke(e, t);
335 <            shouldThrow();
328 >     * ThreadPoolExecutor using privilegedThreadFactory has
329 >     * specified group, priority, daemon status, name,
330 >     * access control context and context class loader
331 >     */
332 >    public void testPrivilegedThreadFactory() throws Exception {
333 >        final CountDownLatch done = new CountDownLatch(1);
334 >        Runnable r = new CheckedRunnable() {
335 >            public void realRun() throws Exception {
336 >                final ThreadGroup egroup = Thread.currentThread().getThreadGroup();
337 >                final ClassLoader thisccl = Thread.currentThread().getContextClassLoader();
338 >                final AccessControlContext thisacc = AccessController.getContext();
339 >                Runnable r = new CheckedRunnable() {
340 >                    public void realRun() {
341 >                        Thread current = Thread.currentThread();
342 >                        assertFalse(current.isDaemon());
343 >                        assertTrue(current.getPriority() <= Thread.NORM_PRIORITY);
344 >                        SecurityManager s = System.getSecurityManager();
345 >                        assertSame(current.getThreadGroup(),
346 >                                   (s == null) ? egroup : s.getThreadGroup());
347 >                        assertTrue(current.getName().endsWith("thread-1"));
348 >                        assertSame(thisccl, current.getContextClassLoader());
349 >                        assertEquals(thisacc, AccessController.getContext());
350 >                        done.countDown();
351 >                    }};
352 >                ExecutorService e = Executors.newSingleThreadExecutor(Executors.privilegedThreadFactory());
353 >                try (PoolCleaner cleaner = cleaner(e)) {
354 >                    e.execute(r);
355 >                    await(done);
356 >                }
357 >            }};
358 >
359 >        runWithPermissions(r,
360 >                           new RuntimePermission("getClassLoader"),
361 >                           new RuntimePermission("setContextClassLoader"),
362 >                           new RuntimePermission("modifyThread"));
363 >    }
364 >
365 >    boolean haveCCLPermissions() {
366 >        SecurityManager sm = System.getSecurityManager();
367 >        if (sm != null) {
368 >            try {
369 >                sm.checkPermission(new RuntimePermission("setContextClassLoader"));
370 >                sm.checkPermission(new RuntimePermission("getClassLoader"));
371 >            } catch (AccessControlException e) {
372 >                return false;
373 >            }
374          }
375 <        catch (NullPointerException success) {
375 >        return true;
376 >    }
377 >
378 >    void checkCCL() {
379 >        SecurityManager sm = System.getSecurityManager();
380 >        if (sm != null) {
381 >            sm.checkPermission(new RuntimePermission("setContextClassLoader"));
382 >            sm.checkPermission(new RuntimePermission("getClassLoader"));
383          }
384 <        catch (Exception ex) {
385 <            unexpectedException();
384 >    }
385 >
386 >    class CheckCCL implements Callable<Object> {
387 >        public Object call() {
388 >            checkCCL();
389 >            return null;
390          }
391      }
392  
393      /**
394 <     *  execute(Executor, Runnable) throws RejectedExecutionException
395 <     *  if saturated.
394 >     * Without class loader permissions, creating
395 >     * privilegedCallableUsingCurrentClassLoader throws ACE
396       */
397 <    public void testExecute1() {
398 <        ThreadPoolExecutor p = new ThreadPoolExecutor(1,1, SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(1));
399 <        try {
400 <            
401 <            for(int i = 0; i < 5; ++i){
402 <                Executors.execute(p, new MediumRunnable(), Boolean.TRUE);
403 <            }
404 <            shouldThrow();
405 <        } catch(RejectedExecutionException success){}
406 <        joinPool(p);
397 >    public void testCreatePrivilegedCallableUsingCCLWithNoPrivs() {
398 >        Runnable r = new CheckedRunnable() {
399 >            public void realRun() throws Exception {
400 >                if (System.getSecurityManager() == null)
401 >                    return;
402 >                try {
403 >                    Executors.privilegedCallableUsingCurrentClassLoader(new NoOpCallable());
404 >                    shouldThrow();
405 >                } catch (AccessControlException success) {}
406 >            }};
407 >
408 >        runWithoutPermissions(r);
409      }
410  
411      /**
412 <     *  execute(Executor, Callable)throws RejectedExecutionException
413 <     *  if saturated.
412 >     * With class loader permissions, calling
413 >     * privilegedCallableUsingCurrentClassLoader does not throw ACE
414       */
415 <    public void testExecute2() {
416 <         ThreadPoolExecutor p = new ThreadPoolExecutor(1,1, SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(1));
417 <        try {
418 <            for(int i = 0; i < 5; ++i) {
419 <                Executors.execute(p, new SmallCallable());
420 <            }
421 <            shouldThrow();
377 <        } catch(RejectedExecutionException e){}
378 <        joinPool(p);
379 <    }
415 >    public void testPrivilegedCallableUsingCCLWithPrivs() throws Exception {
416 >        Runnable r = new CheckedRunnable() {
417 >            public void realRun() throws Exception {
418 >                Executors.privilegedCallableUsingCurrentClassLoader
419 >                    (new NoOpCallable())
420 >                    .call();
421 >            }};
422  
423 +        runWithPermissions(r,
424 +                           new RuntimePermission("getClassLoader"),
425 +                           new RuntimePermission("setContextClassLoader"));
426 +    }
427  
428      /**
429 <     *  invoke(Executor, Runnable) throws InterruptedException if
384 <     *  caller interrupted.
429 >     * Without permissions, calling privilegedCallable throws ACE
430       */
431 <    public void testInterruptedInvoke() {
432 <        final ThreadPoolExecutor p = new ThreadPoolExecutor(1,1,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
433 <        Thread t = new Thread(new Runnable() {
434 <                public void run() {
435 <                    try {
436 <                        Executors.invoke(p,new Runnable() {
437 <                                public void run() {
438 <                                    try {
439 <                                        Thread.sleep(MEDIUM_DELAY_MS);
440 <                                        shouldThrow();
441 <                                    } catch(InterruptedException e){
442 <                                    }
443 <                                }
444 <                            });
445 <                    } catch(InterruptedException success){
446 <                    } catch(Exception e) {
447 <                        unexpectedException();
448 <                    }
449 <                    
450 <                }
451 <            });
452 <        try {
453 <            t.start();
454 <            Thread.sleep(SHORT_DELAY_MS);
455 <            t.interrupt();
456 <        } catch(Exception e){
457 <            unexpectedException();
458 <        }
459 <        joinPool(p);
431 >    public void testPrivilegedCallableWithNoPrivs() throws Exception {
432 >        // Avoid classloader-related SecurityExceptions in swingui.TestRunner
433 >        Executors.privilegedCallable(new CheckCCL());
434 >
435 >        Runnable r = new CheckedRunnable() {
436 >            public void realRun() throws Exception {
437 >                if (System.getSecurityManager() == null)
438 >                    return;
439 >                Callable task = Executors.privilegedCallable(new CheckCCL());
440 >                try {
441 >                    task.call();
442 >                    shouldThrow();
443 >                } catch (AccessControlException success) {}
444 >            }};
445 >
446 >        runWithoutPermissions(r);
447 >
448 >        // It seems rather difficult to test that the
449 >        // AccessControlContext of the privilegedCallable is used
450 >        // instead of its caller.  Below is a failed attempt to do
451 >        // that, which does not work because the AccessController
452 >        // cannot capture the internal state of the current Policy.
453 >        // It would be much more work to differentiate based on,
454 >        // e.g. CodeSource.
455 >
456 > //         final AccessControlContext[] noprivAcc = new AccessControlContext[1];
457 > //         final Callable[] task = new Callable[1];
458 >
459 > //         runWithPermissions
460 > //             (new CheckedRunnable() {
461 > //                 public void realRun() {
462 > //                     if (System.getSecurityManager() == null)
463 > //                         return;
464 > //                     noprivAcc[0] = AccessController.getContext();
465 > //                     task[0] = Executors.privilegedCallable(new CheckCCL());
466 > //                     try {
467 > //                         AccessController.doPrivileged(new PrivilegedAction<Void>() {
468 > //                                                           public Void run() {
469 > //                                                               checkCCL();
470 > //                                                               return null;
471 > //                                                           }}, noprivAcc[0]);
472 > //                         shouldThrow();
473 > //                     } catch (AccessControlException success) {}
474 > //                 }});
475 >
476 > //         runWithPermissions
477 > //             (new CheckedRunnable() {
478 > //                 public void realRun() throws Exception {
479 > //                     if (System.getSecurityManager() == null)
480 > //                         return;
481 > //                     // Verify that we have an underprivileged ACC
482 > //                     try {
483 > //                         AccessController.doPrivileged(new PrivilegedAction<Void>() {
484 > //                                                           public Void run() {
485 > //                                                               checkCCL();
486 > //                                                               return null;
487 > //                                                           }}, noprivAcc[0]);
488 > //                         shouldThrow();
489 > //                     } catch (AccessControlException success) {}
490 >
491 > //                     try {
492 > //                         task[0].call();
493 > //                         shouldThrow();
494 > //                     } catch (AccessControlException success) {}
495 > //                 }},
496 > //              new RuntimePermission("getClassLoader"),
497 > //              new RuntimePermission("setContextClassLoader"));
498      }
499  
500      /**
501 <     *  invoke(Executor, Runnable) throws ExecutionException if
419 <     *  runnable throws exception.
501 >     * With permissions, calling privilegedCallable succeeds
502       */
503 <    public void testInvoke3() {
504 <        ThreadPoolExecutor p = new ThreadPoolExecutor(1,1,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
505 <        try {
506 <            Runnable r = new Runnable() {
507 <                    public void run() {
508 <                        int i = 5/0;
509 <                    }
510 <                };
511 <            
430 <            for(int i =0; i < 5; i++){
431 <                Executors.invoke(p,r);
432 <            }
433 <            
434 <            shouldThrow();
435 <        } catch(ExecutionException success){
436 <        } catch(Exception e){
437 <            unexpectedException();
438 <        }
439 <        joinPool(p);
503 >    public void testPrivilegedCallableWithPrivs() throws Exception {
504 >        Runnable r = new CheckedRunnable() {
505 >            public void realRun() throws Exception {
506 >                Executors.privilegedCallable(new CheckCCL()).call();
507 >            }};
508 >
509 >        runWithPermissions(r,
510 >                           new RuntimePermission("getClassLoader"),
511 >                           new RuntimePermission("setContextClassLoader"));
512      }
513  
514 +    /**
515 +     * callable(Runnable) returns null when called
516 +     */
517 +    public void testCallable1() throws Exception {
518 +        Callable c = Executors.callable(new NoOpRunnable());
519 +        assertNull(c.call());
520 +    }
521  
522 +    /**
523 +     * callable(Runnable, result) returns result when called
524 +     */
525 +    public void testCallable2() throws Exception {
526 +        Callable c = Executors.callable(new NoOpRunnable(), one);
527 +        assertSame(one, c.call());
528 +    }
529  
530      /**
531 <     *  invoke(Executor, Callable) throws InterruptedException if
446 <     *  callable throws exception
531 >     * callable(PrivilegedAction) returns its result when called
532       */
533 <    public void testInvoke5() {
534 <        final ThreadPoolExecutor p = new ThreadPoolExecutor(1,1,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
535 <        
536 <        final Callable c = new Callable() {
537 <                public Object call() {
453 <                    try {
454 <                        Executors.invoke(p, new SmallCallable());
455 <                        shouldThrow();
456 <                    } catch(InterruptedException e){}
457 <                    catch(RejectedExecutionException e2){}
458 <                    catch(ExecutionException e3){}
459 <                    return Boolean.TRUE;
460 <                }
461 <            };
533 >    public void testCallable3() throws Exception {
534 >        Callable c = Executors.callable(new PrivilegedAction() {
535 >                public Object run() { return one; }});
536 >        assertSame(one, c.call());
537 >    }
538  
539 +    /**
540 +     * callable(PrivilegedExceptionAction) returns its result when called
541 +     */
542 +    public void testCallable4() throws Exception {
543 +        Callable c = Executors.callable(new PrivilegedExceptionAction() {
544 +                public Object run() { return one; }});
545 +        assertSame(one, c.call());
546 +    }
547  
548 <        
549 <        Thread t = new Thread(new Runnable() {
550 <                public void run() {
551 <                    try {
468 <                        c.call();
469 <                    } catch(Exception e){}
470 <                }
471 <          });
548 >    /**
549 >     * callable(null Runnable) throws NPE
550 >     */
551 >    public void testCallableNPE1() {
552          try {
553 <            t.start();
554 <            Thread.sleep(SHORT_DELAY_MS);
555 <            t.interrupt();
476 <            t.join();
477 <        } catch(InterruptedException e){
478 <            unexpectedException();
479 <        }
480 <        
481 <        joinPool(p);
553 >            Callable c = Executors.callable((Runnable) null);
554 >            shouldThrow();
555 >        } catch (NullPointerException success) {}
556      }
557  
558      /**
559 <     *  invoke(Executor, Callable) will throw ExecutionException
486 <     *  if callable throws exception
559 >     * callable(null, result) throws NPE
560       */
561 <    public void testInvoke6() {
489 <        ThreadPoolExecutor p = new ThreadPoolExecutor(1,1,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
490 <
561 >    public void testCallableNPE2() {
562          try {
563 <            Callable c = new Callable() {
493 <                    public Object call() {
494 <                        int i = 5/0;
495 <                        return Boolean.TRUE;
496 <                    }
497 <                };
498 <            
499 <            for(int i =0; i < 5; i++){
500 <                Executors.invoke(p,c);
501 <            }
502 <            
563 >            Callable c = Executors.callable((Runnable) null, one);
564              shouldThrow();
565 <        }
505 <        catch(ExecutionException success){
506 <        } catch(Exception e) {
507 <            unexpectedException();
508 <        }
509 <        joinPool(p);
565 >        } catch (NullPointerException success) {}
566      }
567  
512
513
568      /**
569 <     *  timeouts from execute will time out if they compute too long.
569 >     * callable(null PrivilegedAction) throws NPE
570       */
571 <    public void testTimedCallable() {
518 <        int N = 10000;
519 <        ExecutorService executor = Executors.newSingleThreadExecutor();
520 <        List<Callable<BigInteger>> tasks = new ArrayList<Callable<BigInteger>>(N);
571 >    public void testCallableNPE3() {
572          try {
573 <            long startTime = System.currentTimeMillis();
574 <            
575 <            long i = 0;
525 <            while (tasks.size() < N) {
526 <                tasks.add(new TimedCallable<BigInteger>(executor, new Fib(i), 1));
527 <                i += 10;
528 <            }
529 <            
530 <            int iters = 0;
531 <            BigInteger sum = BigInteger.ZERO;
532 <            for (Iterator<Callable<BigInteger>> it = tasks.iterator(); it.hasNext();) {
533 <                try {
534 <                    ++iters;
535 <                    sum = sum.add(it.next().call());
536 <                }
537 <                catch (TimeoutException success) {
538 <                    assertTrue(iters > 0);
539 <                    return;
540 <                }
541 <                catch (Exception e) {
542 <                    unexpectedException();
543 <                }
544 <            }
545 <            // if by chance we didn't ever time out, total time must be small
546 <            long elapsed = System.currentTimeMillis() - startTime;
547 <            assertTrue(elapsed < N);
548 <        }
549 <        finally {
550 <            joinPool(executor);
551 <        }
573 >            Callable c = Executors.callable((PrivilegedAction) null);
574 >            shouldThrow();
575 >        } catch (NullPointerException success) {}
576      }
577  
578 <    
579 <
578 >    /**
579 >     * callable(null PrivilegedExceptionAction) throws NPE
580 >     */
581 >    public void testCallableNPE4() {
582 >        try {
583 >            Callable c = Executors.callable((PrivilegedExceptionAction) null);
584 >            shouldThrow();
585 >        } catch (NullPointerException success) {}
586 >    }
587  
588   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines