--- jsr166/src/test/tck/ForkJoinTask8Test.java 2015/09/08 23:56:19 1.15 +++ jsr166/src/test/tck/ForkJoinTask8Test.java 2015/10/05 22:59:29 1.19 @@ -74,7 +74,7 @@ public class ForkJoinTask8Test extends J } private void testInvokeOnPool(ForkJoinPool pool, RecursiveAction a) { - try { + try (PoolCleaner cleaner = cleaner(pool)) { assertFalse(a.isDone()); assertFalse(a.isCompletedNormally()); assertFalse(a.isCompletedAbnormally()); @@ -90,8 +90,6 @@ public class ForkJoinTask8Test extends J assertFalse(a.isCancelled()); assertNull(a.getException()); assertNull(a.getRawResult()); - } finally { - joinPool(pool); } } @@ -200,9 +198,9 @@ public class ForkJoinTask8Test extends J abstract static class BinaryAsyncAction extends ForkJoinTask { - private BinaryAsyncAction parent; + private volatile BinaryAsyncAction parent; - private BinaryAsyncAction sibling; + private volatile BinaryAsyncAction sibling; protected BinaryAsyncAction() { setForkJoinTaskTag(INITIAL_STATE); @@ -1155,7 +1153,7 @@ public class ForkJoinTask8Test extends J } // jdk9 - + /** * pollSubmission returns unexecuted submitted task, if present */ @@ -1165,18 +1163,19 @@ public class ForkJoinTask8Test extends J final ForkJoinTask b = ForkJoinTask.adapt(awaiter(done)); final ForkJoinTask c = ForkJoinTask.adapt(awaiter(done)); final ForkJoinPool p = singletonPool(); - Thread external = new Thread() { - public void run() { + try (PoolCleaner cleaner = cleaner(p)) { + Thread external = new Thread(new CheckedRunnable() { + public void realRun() { p.execute(a); p.execute(b); p.execute(c); - }}; - RecursiveAction s = new CheckedRecursiveAction() { + }}); + RecursiveAction s = new CheckedRecursiveAction() { protected void realCompute() { external.start(); try { external.join(); - } catch(Exception ex) { + } catch (Exception ex) { threadUnexpectedException(ex); } assertTrue(p.hasQueuedSubmissions()); @@ -1185,13 +1184,9 @@ public class ForkJoinTask8Test extends J assertTrue(r == a || r == b || r == c); assertFalse(r.isDone()); }}; - try { p.invoke(s); - } finally { done.countDown(); - joinPool(p); } } - }