ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/FutureTaskTest.java
(Generate patch)

Comparing jsr166/src/test/tck/FutureTaskTest.java (file contents):
Revision 1.3 by dl, Fri Sep 12 15:40:25 2003 UTC vs.
Revision 1.26 by jsr166, Tue May 31 16:16:23 2011 UTC

# Line 1 | Line 1
1   /*
2 < * Written by members of JCP JSR-166 Expert Group and released to the
3 < * public domain. Use, modify, and redistribute this code in any way
4 < * without acknowledgement. Other contributors include Andrew Wright,
5 < * Jeffrey Hayes, Pat Fischer, Mike Judd.
2 > * Written by Doug Lea with assistance from members of JCP JSR-166
3 > * Expert Group and released to the public domain, as explained at
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5 > * Other contributors include Andrew Wright, Jeffrey Hayes,
6 > * Pat Fisher, Mike Judd.
7   */
8  
9   import junit.framework.*;
10 < import java.util.concurrent.*;
10 > import java.util.concurrent.Callable;
11 > import java.util.concurrent.CancellationException;
12 > import java.util.concurrent.CountDownLatch;
13 > import java.util.concurrent.ExecutionException;
14 > import java.util.concurrent.Future;
15 > import java.util.concurrent.FutureTask;
16 > import java.util.concurrent.TimeoutException;
17 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
18 > import static java.util.concurrent.TimeUnit.SECONDS;
19 > import java.util.*;
20  
21 < public class FutureTaskTest extends TestCase {
21 > public class FutureTaskTest extends JSR166TestCase {
22  
23      public static void main(String[] args) {
24 <        junit.textui.TestRunner.run (suite());  
24 >        junit.textui.TestRunner.run(suite());
25      }
26      public static Test suite() {
27 <        return new TestSuite(FutureTaskTest.class);
27 >        return new TestSuite(FutureTaskTest.class);
28      }
29  
30 <    private static long SHORT_DELAY_MS = 100;
31 <    private static long MEDIUM_DELAY_MS = 1000;
32 <    private static long LONG_DELAY_MS = 10000;
30 >    void checkNotDone(Future<?> f) {
31 >        assertFalse(f.isDone());
32 >        assertFalse(f.isCancelled());
33 >    }
34 >
35 >    <T> void checkCompletedNormally(Future<T> f, T expected) {
36 >        assertTrue(f.isDone());
37 >        assertFalse(f.isCancelled());
38 >
39 >        try {
40 >            assertSame(expected, f.get());
41 >        } catch (Throwable fail) { threadUnexpectedException(fail); }
42 >        try {
43 >            assertSame(expected, f.get(5L, SECONDS));
44 >        } catch (Throwable fail) { threadUnexpectedException(fail); }
45 >
46 >        assertFalse(f.cancel(false));
47 >        assertFalse(f.cancel(true));
48 >    }
49 >
50 >    void checkCancelled(Future<?> f) {
51 >        assertTrue(f.isDone());
52 >        assertTrue(f.isCancelled());
53 >
54 >        try {
55 >            f.get();
56 >            shouldThrow();
57 >        } catch (CancellationException success) {
58 >        } catch (Throwable fail) { threadUnexpectedException(fail); }
59 >
60 >        try {
61 >            f.get(5L, SECONDS);
62 >            shouldThrow();
63 >        } catch (CancellationException success) {
64 >        } catch (Throwable fail) { threadUnexpectedException(fail); }
65 >
66 >        assertFalse(f.cancel(false));
67 >        assertFalse(f.cancel(true));
68 >    }
69 >
70 >    void checkCompletedAbnormally(Future<?> f, Throwable t) {
71 >        assertTrue(f.isDone());
72 >        assertFalse(f.isCancelled());
73 >
74 >        try {
75 >            f.get();
76 >            shouldThrow();
77 >        } catch (ExecutionException success) {
78 >            assertSame(t, success.getCause());
79 >        } catch (Throwable fail) { threadUnexpectedException(fail); }
80  
81 <    public void testConstructor(){
81 >        try {
82 >            f.get(5L, SECONDS);
83 >            shouldThrow();
84 >        } catch (ExecutionException success) {
85 >            assertSame(t, success.getCause());
86 >        } catch (Throwable fail) { threadUnexpectedException(fail); }
87 >
88 >        assertFalse(f.cancel(false));
89 >        assertFalse(f.cancel(true));
90 >    }
91 >
92 >    /**
93 >     * Subclass to expose protected methods
94 >     */
95 >    static class PublicFutureTask extends FutureTask {
96 >        public PublicFutureTask(Callable r) { super(r); }
97 >        public boolean runAndReset() { return super.runAndReset(); }
98 >        public void set(Object x) { super.set(x); }
99 >        public void setException(Throwable t) { super.setException(t); }
100 >    }
101 >
102 >    /**
103 >     * Creating a future with a null callable throws NPE
104 >     */
105 >    public void testConstructor() {
106          try {
107              FutureTask task = new FutureTask(null);
108 <            fail("should throw");
109 <        }
29 <        catch(NullPointerException success) {
30 <        }
108 >            shouldThrow();
109 >        } catch (NullPointerException success) {}
110      }
111  
112 <    public void testConstructor2(){
112 >    /**
113 >     * creating a future with null runnable fails
114 >     */
115 >    public void testConstructor2() {
116          try {
117              FutureTask task = new FutureTask(null, Boolean.TRUE);
118 <            fail("should throw");
119 <        }
38 <        catch(NullPointerException success) {
39 <        }
118 >            shouldThrow();
119 >        } catch (NullPointerException success) {}
120      }
121  
122 <    public void testIsDone(){
123 <        FutureTask task = new FutureTask( new Callable() {
124 <                public Object call() { return Boolean.TRUE; } });
125 <        task.run();
126 <        assertTrue(task.isDone());
127 <        assertFalse(task.isCancelled());
122 >    /**
123 >     * isDone is true when a task completes
124 >     */
125 >    public void testIsDone() {
126 >        FutureTask task = new FutureTask(new NoOpCallable());
127 >        task.run();
128 >        assertTrue(task.isDone());
129 >        checkCompletedNormally(task, Boolean.TRUE);
130 >    }
131 >
132 >    /**
133 >     * runAndReset of a non-cancelled task succeeds
134 >     */
135 >    public void testRunAndReset() {
136 >        PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
137 >        assertTrue(task.runAndReset());
138 >        checkNotDone(task);
139 >    }
140 >
141 >    /**
142 >     * runAndReset after cancellation fails
143 >     */
144 >    public void testResetAfterCancel() {
145 >        PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
146 >        assertTrue(task.cancel(false));
147 >        assertFalse(task.runAndReset());
148 >        checkCancelled(task);
149      }
150  
151 +
152 +    /**
153 +     * setting value causes get to return it
154 +     */
155 +    public void testSet() throws Exception {
156 +        PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
157 +        task.set(one);
158 +        assertSame(task.get(), one);
159 +        checkCompletedNormally(task, one);
160 +    }
161 +
162 +    /**
163 +     * setException causes get to throw ExecutionException
164 +     */
165 +    public void testSetException() throws Exception {
166 +        Exception nse = new NoSuchElementException();
167 +        PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
168 +        task.setException(nse);
169 +        try {
170 +            Object x = task.get();
171 +            shouldThrow();
172 +        } catch (ExecutionException success) {
173 +            assertSame(success.getCause(), nse);
174 +            checkCompletedAbnormally(task, nse);
175 +        }
176 +    }
177 +
178 +    /**
179 +     * Cancelling before running succeeds
180 +     */
181      public void testCancelBeforeRun() {
182 <        FutureTask task = new FutureTask( new Callable() {
52 <                public Object call() { return Boolean.TRUE; } });
182 >        FutureTask task = new FutureTask(new NoOpCallable());
183          assertTrue(task.cancel(false));
184 <        task.run();
185 <        assertTrue(task.isDone());
56 <        assertTrue(task.isCancelled());
184 >        task.run();
185 >        checkCancelled(task);
186      }
187  
188 +    /**
189 +     * Cancel(true) before run succeeds
190 +     */
191      public void testCancelBeforeRun2() {
192 <        FutureTask task = new FutureTask( new Callable() {
61 <                public Object call() { return Boolean.TRUE; } });
192 >        FutureTask task = new FutureTask(new NoOpCallable());
193          assertTrue(task.cancel(true));
194 <        task.run();
195 <        assertTrue(task.isDone());
65 <        assertTrue(task.isCancelled());
194 >        task.run();
195 >        checkCancelled(task);
196      }
197  
198 +    /**
199 +     * cancel of a completed task fails
200 +     */
201      public void testCancelAfterRun() {
202 <        FutureTask task = new FutureTask( new Callable() {
203 <                public Object call() { return Boolean.TRUE; } });
71 <        task.run();
202 >        FutureTask task = new FutureTask(new NoOpCallable());
203 >        task.run();
204          assertFalse(task.cancel(false));
205 <        assertTrue(task.isDone());
74 <        assertFalse(task.isCancelled());
205 >        checkCompletedNormally(task, Boolean.TRUE);
206      }
207  
208 <    public void testCancelInterrupt(){
209 <        FutureTask task = new FutureTask( new Callable() {
210 <                public Object call() {
211 <                    try {
212 <                        Thread.sleep(SHORT_DELAY_MS* 2);
213 <                        fail("should throw");
208 >    /**
209 >     * cancel(true) interrupts a running task
210 >     */
211 >    public void testCancelInterrupt() throws InterruptedException {
212 >        final CountDownLatch threadStarted = new CountDownLatch(1);
213 >        final FutureTask task =
214 >            new FutureTask(new CheckedCallable<Object>() {
215 >                public Object realCall() {
216 >                    threadStarted.countDown();
217 >                    long t0 = System.nanoTime();
218 >                    for (;;) {
219 >                        if (Thread.interrupted())
220 >                            return Boolean.TRUE;
221 >                        if (millisElapsedSince(t0) > MEDIUM_DELAY_MS)
222 >                            fail("interrupt not delivered");
223 >                        Thread.yield();
224                      }
225 <                    catch (InterruptedException success) {}
225 >                }});
226 >
227 >        Thread t = newStartedThread(task);
228 >        threadStarted.await();
229 >        assertTrue(task.cancel(true));
230 >        checkCancelled(task);
231 >        awaitTermination(t, MEDIUM_DELAY_MS);
232 >        checkCancelled(task);
233 >    }
234 >
235 >    /**
236 >     * cancel(false) does not interrupt a running task
237 >     */
238 >    public void testCancelNoInterrupt() throws InterruptedException {
239 >        final CountDownLatch threadStarted = new CountDownLatch(1);
240 >        final CountDownLatch cancelled = new CountDownLatch(1);
241 >        final FutureTask<Boolean> task =
242 >            new FutureTask<Boolean>(new CheckedCallable<Boolean>() {
243 >                public Boolean realCall() throws InterruptedException {
244 >                    threadStarted.countDown();
245 >                    cancelled.await(MEDIUM_DELAY_MS, MILLISECONDS);
246 >                    assertFalse(Thread.interrupted());
247                      return Boolean.TRUE;
248 <                } });
249 <        Thread t = new  Thread(task);
250 <        t.start();
251 <        
252 <        try{
253 <            Thread.sleep(SHORT_DELAY_MS);
254 <            assertTrue(task.cancel(true));
255 <            t.join();
256 <            assertTrue(task.isDone());
95 <            assertTrue(task.isCancelled());
96 <        } catch(InterruptedException e){
97 <            fail("unexpected exception");
98 <        }
248 >                }});
249 >
250 >        Thread t = newStartedThread(task);
251 >        threadStarted.await();
252 >        assertTrue(task.cancel(false));
253 >        checkCancelled(task);
254 >        cancelled.countDown();
255 >        awaitTermination(t, MEDIUM_DELAY_MS);
256 >        checkCancelled(task);
257      }
258  
259 +    /**
260 +     * run in one thread causes get in another thread to retrieve value
261 +     */
262 +    public void testGetRun() throws InterruptedException {
263 +        final CountDownLatch threadStarted = new CountDownLatch(1);
264 +
265 +        final FutureTask task =
266 +            new FutureTask(new CheckedCallable<Object>() {
267 +                public Object realCall() throws InterruptedException {
268 +                    return Boolean.TRUE;
269 +                }});
270  
271 <    public void testCancelNoInterrupt(){
272 <        FutureTask task = new FutureTask( new Callable() {
273 <                public Object call() {
274 <                    try {
275 <                        Thread.sleep(SHORT_DELAY_MS* 2);
276 <                    }
277 <                    catch (InterruptedException success) {
278 <                        fail("should not interrupt");
279 <                    }
271 >        Thread t = newStartedThread(new CheckedRunnable() {
272 >            public void realRun() throws Exception {
273 >                threadStarted.countDown();
274 >                assertSame(Boolean.TRUE, task.get());
275 >            }});
276 >
277 >        threadStarted.await();
278 >        checkNotDone(task);
279 >        assertTrue(t.isAlive());
280 >        task.run();
281 >        checkCompletedNormally(task, Boolean.TRUE);
282 >        awaitTermination(t, MEDIUM_DELAY_MS);
283 >    }
284 >
285 >    /**
286 >     * set in one thread causes get in another thread to retrieve value
287 >     */
288 >    public void testGetSet() throws InterruptedException {
289 >        final CountDownLatch threadStarted = new CountDownLatch(1);
290 >
291 >        final PublicFutureTask task =
292 >            new PublicFutureTask(new CheckedCallable<Object>() {
293 >                public Object realCall() throws InterruptedException {
294                      return Boolean.TRUE;
295 <                } });
113 <        Thread t = new  Thread(task);
114 <        t.start();
115 <        
116 <        try{
117 <            Thread.sleep(SHORT_DELAY_MS);
118 <            assertTrue(task.cancel(false));
119 <            t.join();
120 <            assertTrue(task.isDone());
121 <            assertTrue(task.isCancelled());
122 <        } catch(InterruptedException e){
123 <            fail("unexpected exception");
124 <        }
125 <    }
295 >                }});
296  
297 <    public void testGet1() {
298 <        final FutureTask ft = new FutureTask(new Callable(){
299 <                public Object call(){
300 <                    try{
301 <                        Thread.sleep(MEDIUM_DELAY_MS);
302 <                    } catch(InterruptedException e){
303 <                        fail("unexpected exception");
304 <                    }
297 >        Thread t = newStartedThread(new CheckedRunnable() {
298 >            public void realRun() throws Exception {
299 >                threadStarted.countDown();
300 >                assertSame(Boolean.FALSE, task.get());
301 >            }});
302 >
303 >        threadStarted.await();
304 >        checkNotDone(task);
305 >        assertTrue(t.isAlive());
306 >        task.set(Boolean.FALSE);
307 >        checkCompletedNormally(task, Boolean.FALSE);
308 >        awaitTermination(t, MEDIUM_DELAY_MS);
309 >    }
310 >
311 >    /**
312 >     * run in one thread causes timed get in another thread to retrieve value
313 >     */
314 >    public void testTimedGetRun() throws InterruptedException {
315 >        final CountDownLatch threadStarted = new CountDownLatch(1);
316 >
317 >        final FutureTask task =
318 >            new FutureTask(new CheckedCallable<Object>() {
319 >                public Object realCall() throws InterruptedException {
320                      return Boolean.TRUE;
321 <                }
322 <        });
323 <        Thread t = new Thread(new Runnable(){
324 <                public void run(){
325 <                    try{
326 <                        ft.get();
327 <                    } catch(Exception e){
328 <                        fail("unexpected exception");
329 <                    }
330 <                }
331 <            });
332 <        try{
333 <            assertFalse(ft.isDone());
334 <            assertFalse(ft.isCancelled());
335 <            t.start();
336 <            Thread.sleep(SHORT_DELAY_MS);
337 <            ft.run();
338 <            t.join();
339 <            assertTrue(ft.isDone());
340 <            assertFalse(ft.isCancelled());
341 <        } catch(InterruptedException e){
342 <            fail("unexpected exception");
343 <
344 <        }      
345 <    }
346 <
162 <    public void testTimedGet1() {
163 <        final FutureTask ft = new FutureTask(new Callable(){
164 <                public Object call(){
165 <                    try{
166 <                        Thread.sleep(MEDIUM_DELAY_MS);
167 <                    } catch(InterruptedException e){
168 <                        fail("unexpected exception");
169 <                    }
321 >                }});
322 >
323 >        Thread t = newStartedThread(new CheckedRunnable() {
324 >            public void realRun() throws Exception {
325 >                threadStarted.countDown();
326 >                assertSame(Boolean.TRUE,
327 >                           task.get(MEDIUM_DELAY_MS, MILLISECONDS));
328 >            }});
329 >
330 >        threadStarted.await();
331 >        checkNotDone(task);
332 >        assertTrue(t.isAlive());
333 >        task.run();
334 >        checkCompletedNormally(task, Boolean.TRUE);
335 >        awaitTermination(t, MEDIUM_DELAY_MS);
336 >    }
337 >
338 >    /**
339 >     * set in one thread causes timed get in another thread to retrieve value
340 >     */
341 >    public void testTimedGetSet() throws InterruptedException {
342 >        final CountDownLatch threadStarted = new CountDownLatch(1);
343 >
344 >        final PublicFutureTask task =
345 >            new PublicFutureTask(new CheckedCallable<Object>() {
346 >                public Object realCall() throws InterruptedException {
347                      return Boolean.TRUE;
348 <                }
172 <            });
173 <        Thread t = new Thread(new Runnable(){
174 <                public void run(){
175 <                    try{
176 <                        ft.get(SHORT_DELAY_MS, TimeUnit.MILLISECONDS);
177 <                    } catch(TimeoutException success) {
178 <                    } catch(Exception e){
179 <                        fail("unexpected exception");
180 <                    }
181 <                }
182 <            });
183 <        try{
184 <            assertFalse(ft.isDone());
185 <            assertFalse(ft.isCancelled());
186 <            t.start();
187 <            ft.run();
188 <            t.join();
189 <            assertTrue(ft.isDone());
190 <            assertFalse(ft.isCancelled());
191 <        } catch(InterruptedException e){
192 <            fail("unexpected exception");
193 <            
194 <        }      
195 <    }
348 >                }});
349  
350 +        Thread t = newStartedThread(new CheckedRunnable() {
351 +            public void realRun() throws Exception {
352 +                threadStarted.countDown();
353 +                assertSame(Boolean.FALSE,
354 +                           task.get(MEDIUM_DELAY_MS, MILLISECONDS));
355 +            }});
356 +
357 +        threadStarted.await();
358 +        checkNotDone(task);
359 +        assertTrue(t.isAlive());
360 +        task.set(Boolean.FALSE);
361 +        checkCompletedNormally(task, Boolean.FALSE);
362 +        awaitTermination(t, MEDIUM_DELAY_MS);
363 +    }
364 +
365 +    /**
366 +     * Cancelling a task causes timed get in another thread to throw
367 +     * CancellationException
368 +     */
369 +    public void testTimedGet_Cancellation() throws InterruptedException {
370 +        final CountDownLatch threadStarted = new CountDownLatch(2);
371 +        final FutureTask task =
372 +            new FutureTask(new CheckedInterruptedCallable<Object>() {
373 +                public Object realCall() throws InterruptedException {
374 +                    threadStarted.countDown();
375 +                    delay(LONG_DELAY_MS);
376 +                    return Boolean.TRUE;
377 +                }});
378  
379 <    public void testGet_Cancellation(){
380 <        final FutureTask ft = new FutureTask(new Callable(){
381 <                public Object call(){
382 <                    try{
383 <                        Thread.sleep(MEDIUM_DELAY_MS);
384 <                    } catch(InterruptedException e){
385 <                        fail("unexpected exception");
386 <                    }
379 >        Thread t1 = new ThreadShouldThrow(CancellationException.class) {
380 >            public void realRun() throws Exception {
381 >                threadStarted.countDown();
382 >                task.get(MEDIUM_DELAY_MS, MILLISECONDS);
383 >            }};
384 >        Thread t2 = new Thread(task);
385 >        t1.start();
386 >        t2.start();
387 >        threadStarted.await();
388 >        task.cancel(true);
389 >        awaitTermination(t1, MEDIUM_DELAY_MS);
390 >        awaitTermination(t2, MEDIUM_DELAY_MS);
391 >        checkCancelled(task);
392 >    }
393 >
394 >    /**
395 >     * Cancelling a task causes get in another thread to throw
396 >     * CancellationException
397 >     */
398 >    public void testGet_Cancellation() throws InterruptedException {
399 >        final CountDownLatch threadStarted = new CountDownLatch(2);
400 >        final FutureTask task =
401 >            new FutureTask(new CheckedInterruptedCallable<Object>() {
402 >                public Object realCall() throws InterruptedException {
403 >                    threadStarted.countDown();
404 >                    delay(LONG_DELAY_MS);
405                      return Boolean.TRUE;
406 <                }
407 <            });
408 <        try {
409 <            Thread.sleep(SHORT_DELAY_MS);
410 <            Thread t = new Thread(new Runnable(){
411 <                    public void run(){
412 <                        try{
413 <                            ft.get();
414 <                            fail("should throw");
415 <                        } catch(CancellationException success){
416 <                        }
417 <                        catch(Exception e){
418 <                            fail("unexpected exception");
419 <                        }
420 <                    }
222 <                });
223 <            t.start();
224 <            ft.cancel(true);
225 <            t.join();
226 <        } catch(InterruptedException success){
227 <            fail("unexpected exception");
228 <        }
229 <    }
230 <    
231 <    public void testGet_Cancellation2(){
232 <        final FutureTask ft = new FutureTask(new Callable(){
233 <                public Object call(){
234 <                    try{
235 <                        Thread.sleep(SHORT_DELAY_MS);
236 <                    } catch(InterruptedException e) {
237 <                        fail("unexpected exception");
238 <                    }
239 <                    return Boolean.TRUE;
240 <                }
241 <            });
242 <        try{
243 <            Thread.sleep(100);
244 <            Thread t = new Thread(new Runnable(){
245 <                    public void run(){
246 <                        try{
247 <                            ft.get(3 * SHORT_DELAY_MS, TimeUnit.MILLISECONDS);
248 <                            fail("should throw");
249 <                        } catch(CancellationException success) {}
250 <                        catch(Exception e){
251 <                            fail("unexpected exception");
252 <                        }
253 <                    }
254 <                });
255 <            t.start();
256 <            Thread.sleep(SHORT_DELAY_MS);
257 <            ft.cancel(true);
258 <            Thread.sleep(SHORT_DELAY_MS);
259 <            t.join();
260 <        } catch(InterruptedException ie){
261 <            fail("unexpected exception");
262 <        }
406 >                }});
407 >
408 >        Thread t1 = new ThreadShouldThrow(CancellationException.class) {
409 >            public void realRun() throws Exception {
410 >                threadStarted.countDown();
411 >                task.get();
412 >            }};
413 >        Thread t2 = new Thread(task);
414 >        t1.start();
415 >        t2.start();
416 >        threadStarted.await();
417 >        task.cancel(true);
418 >        awaitTermination(t1, MEDIUM_DELAY_MS);
419 >        awaitTermination(t2, MEDIUM_DELAY_MS);
420 >        checkCancelled(task);
421      }
422  
423 <    public void testGet_ExecutionException(){
424 <        final FutureTask ft = new FutureTask(new Callable(){
425 <                public Object call(){
426 <                    int i = 5/0;
427 <                    return Boolean.TRUE;
428 <                }
429 <            });
430 <        try{
431 <            ft.run();
432 <            ft.get();
433 <            fail("should throw");
276 <        } catch(ExecutionException success){
277 <        }
278 <        catch(Exception e){
279 <            fail("unexpected exception");
280 <        }
281 <    }
282 <  
283 <    public void testTimedGet_ExecutionException2(){
284 <        final FutureTask ft = new FutureTask(new Callable(){
285 <                public Object call(){
286 <                    int i = 5/0;
287 <                    return Boolean.TRUE;
288 <                }
289 <            });
290 <        try{
291 <            ft.run();
292 <            ft.get(SHORT_DELAY_MS, TimeUnit.MILLISECONDS);
293 <            fail("should throw");
294 <        } catch(ExecutionException success) {
295 <        } catch(TimeoutException success) { } // unlikely but OK
296 <        catch(Exception e){
297 <            fail("unexpected exception");
298 <        }
299 <    }
300 <      
301 <
302 <    public void testGet_InterruptedException(){
303 <        final FutureTask ft = new FutureTask(new Callable(){
304 <                public Object call(){
305 <                    return new Object();
306 <                }
307 <            });
308 <        Thread t = new Thread(new Runnable(){
309 <                public void run(){                  
310 <                    try{
311 <                        ft.get();
312 <                        fail("should throw");
313 <                    } catch(InterruptedException success){
314 <                    } catch(Exception e){
315 <                        fail("unexpected exception");
316 <                    }
317 <                }
318 <            });
423 >
424 >    /**
425 >     * A runtime exception in task causes get to throw ExecutionException
426 >     */
427 >    public void testGet_ExecutionException() throws InterruptedException {
428 >        final FutureTask task = new FutureTask(new Callable() {
429 >            public Object call() {
430 >                return 5/0;
431 >            }});
432 >
433 >        task.run();
434          try {
435 <            t.start();
436 <            Thread.sleep(SHORT_DELAY_MS);
437 <            t.interrupt();
438 <            t.join();
439 <        } catch(Exception e){
325 <            fail("unexpected exception");
435 >            task.get();
436 >            shouldThrow();
437 >        } catch (ExecutionException success) {
438 >            assertTrue(success.getCause() instanceof ArithmeticException);
439 >            checkCompletedAbnormally(task, success.getCause());
440          }
441      }
442  
443 <    public void testTimedGet_InterruptedException2(){
444 <        final FutureTask ft = new FutureTask(new Callable(){
445 <                public Object call(){
446 <                    return new Object();
447 <                }
448 <            });
449 <        Thread t = new Thread(new Runnable(){
450 <                public void run(){                  
451 <                    try{
452 <                        ft.get(100,TimeUnit.SECONDS);
453 <                        fail("should throw");
454 <                    } catch(InterruptedException success){}
455 <                    catch(Exception e){
456 <                        fail("unexpected exception");
457 <                    }
458 <                }
345 <            });
346 <        try {
347 <            t.start();
348 <            Thread.sleep(SHORT_DELAY_MS);
349 <            t.interrupt();
350 <            t.join();
351 <        } catch(Exception e){
352 <            fail("unexpected exception");
443 >    /**
444 >     * A runtime exception in task causes timed get to throw ExecutionException
445 >     */
446 >    public void testTimedGet_ExecutionException2() throws Exception {
447 >        final FutureTask task = new FutureTask(new Callable() {
448 >            public Object call() {
449 >                return 5/0;
450 >            }});
451 >
452 >        task.run();
453 >        try {
454 >            task.get(SHORT_DELAY_MS, MILLISECONDS);
455 >            shouldThrow();
456 >        } catch (ExecutionException success) {
457 >            assertTrue(success.getCause() instanceof ArithmeticException);
458 >            checkCompletedAbnormally(task, success.getCause());
459          }
460      }
461 <    
462 <    public void testGet_TimeoutException(){
463 <        FutureTask ft = new FutureTask(new Callable(){
464 <                public Object call(){
465 <                    return new Object();
466 <                }
467 <            });
468 <        try{
469 <            ft.get(1,TimeUnit.MILLISECONDS);
470 <            fail("should throw");
471 <        } catch(TimeoutException success){}
472 <        catch(Exception success){
473 <            fail("unexpected exception");
474 <        }
475 <        
476 <        
461 >
462 >
463 >    /**
464 >     * Interrupting a waiting get causes it to throw InterruptedException
465 >     */
466 >    public void testGet_InterruptedException() throws InterruptedException {
467 >        final CountDownLatch threadStarted = new CountDownLatch(1);
468 >        final FutureTask task = new FutureTask(new NoOpCallable());
469 >        Thread t = newStartedThread(new CheckedInterruptedRunnable() {
470 >            public void realRun() throws Exception {
471 >                threadStarted.countDown();
472 >                task.get();
473 >            }});
474 >
475 >        threadStarted.await();
476 >        t.interrupt();
477 >        awaitTermination(t, MEDIUM_DELAY_MS);
478 >        checkNotDone(task);
479 >    }
480 >
481 >    /**
482 >     * Interrupting a waiting timed get causes it to throw InterruptedException
483 >     */
484 >    public void testTimedGet_InterruptedException2() throws InterruptedException {
485 >        final CountDownLatch threadStarted = new CountDownLatch(1);
486 >        final FutureTask task = new FutureTask(new NoOpCallable());
487 >        Thread t = newStartedThread(new CheckedInterruptedRunnable() {
488 >            public void realRun() throws Exception {
489 >                threadStarted.countDown();
490 >                task.get(LONG_DELAY_MS, MILLISECONDS);
491 >            }});
492 >
493 >        threadStarted.await();
494 >        t.interrupt();
495 >        awaitTermination(t, MEDIUM_DELAY_MS);
496 >        checkNotDone(task);
497 >    }
498 >
499 >    /**
500 >     * A timed out timed get throws TimeoutException
501 >     */
502 >    public void testGet_TimeoutException() throws Exception {
503 >        try {
504 >            FutureTask task = new FutureTask(new NoOpCallable());
505 >            task.get(1, MILLISECONDS);
506 >            shouldThrow();
507 >        } catch (TimeoutException success) {}
508      }
509 <    
509 >
510   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines