ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/FutureTaskTest.java
(Generate patch)

Comparing jsr166/src/test/tck/FutureTaskTest.java (file contents):
Revision 1.27 by jsr166, Sat Jun 18 14:16:42 2011 UTC vs.
Revision 1.53 by jsr166, Sun Jul 22 22:13:55 2018 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 < import junit.framework.*;
9 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 > import static java.util.concurrent.TimeUnit.NANOSECONDS;
11 >
12 > import java.util.ArrayList;
13 > import java.util.List;
14 > import java.util.NoSuchElementException;
15   import java.util.concurrent.Callable;
16   import java.util.concurrent.CancellationException;
17   import java.util.concurrent.CountDownLatch;
18   import java.util.concurrent.ExecutionException;
19 + import java.util.concurrent.Executors;
20 + import java.util.concurrent.ExecutorService;
21   import java.util.concurrent.Future;
22   import java.util.concurrent.FutureTask;
23   import java.util.concurrent.TimeoutException;
24 < import static java.util.concurrent.TimeUnit.MILLISECONDS;
25 < import static java.util.concurrent.TimeUnit.SECONDS;
26 < import java.util.*;
24 > import java.util.concurrent.atomic.AtomicInteger;
25 >
26 > import junit.framework.Test;
27 > import junit.framework.TestSuite;
28  
29   public class FutureTaskTest extends JSR166TestCase {
30  
31      public static void main(String[] args) {
32 <        junit.textui.TestRunner.run(suite());
32 >        main(suite(), args);
33      }
34      public static Test suite() {
35          return new TestSuite(FutureTaskTest.class);
36      }
37  
38 +    void checkIsDone(Future<?> f) {
39 +        assertTrue(f.isDone());
40 +        assertFalse(f.cancel(false));
41 +        assertFalse(f.cancel(true));
42 +        if (f instanceof PublicFutureTask) {
43 +            PublicFutureTask pf = (PublicFutureTask) f;
44 +            assertEquals(1, pf.doneCount());
45 +            assertFalse(pf.runAndReset());
46 +            assertEquals(1, pf.doneCount());
47 +            Object r = null; Object exInfo = null;
48 +            try {
49 +                r = f.get();
50 +            } catch (CancellationException t) {
51 +                exInfo = CancellationException.class;
52 +            } catch (ExecutionException t) {
53 +                exInfo = t.getCause();
54 +            } catch (Throwable t) {
55 +                threadUnexpectedException(t);
56 +            }
57 +
58 +            // Check that run and runAndReset have no effect.
59 +            int savedRunCount = pf.runCount();
60 +            pf.run();
61 +            pf.runAndReset();
62 +            assertEquals(savedRunCount, pf.runCount());
63 +            Object r2 = null;
64 +            try {
65 +                r2 = f.get();
66 +            } catch (CancellationException t) {
67 +                assertSame(exInfo, CancellationException.class);
68 +            } catch (ExecutionException t) {
69 +                assertSame(exInfo, t.getCause());
70 +            } catch (Throwable t) {
71 +                threadUnexpectedException(t);
72 +            }
73 +            if (exInfo == null)
74 +                assertSame(r, r2);
75 +            assertTrue(f.isDone());
76 +        }
77 +    }
78 +
79      void checkNotDone(Future<?> f) {
80          assertFalse(f.isDone());
81          assertFalse(f.isCancelled());
82 +        if (f instanceof PublicFutureTask) {
83 +            PublicFutureTask pf = (PublicFutureTask) f;
84 +            assertEquals(0, pf.doneCount());
85 +            assertEquals(0, pf.setCount());
86 +            assertEquals(0, pf.setExceptionCount());
87 +        }
88      }
89  
90 <    <T> void checkCompletedNormally(Future<T> f, T expected) {
91 <        assertTrue(f.isDone());
90 >    void checkIsRunning(Future<?> f) {
91 >        checkNotDone(f);
92 >        if (f instanceof FutureTask) {
93 >            FutureTask ft = (FutureTask<?>) f;
94 >            // Check that run methods do nothing
95 >            ft.run();
96 >            if (f instanceof PublicFutureTask) {
97 >                PublicFutureTask pf = (PublicFutureTask) f;
98 >                int savedRunCount = pf.runCount();
99 >                pf.run();
100 >                assertFalse(pf.runAndReset());
101 >                assertEquals(savedRunCount, pf.runCount());
102 >            }
103 >            checkNotDone(f);
104 >        }
105 >    }
106 >
107 >    <T> void checkCompletedNormally(Future<T> f, T expectedValue) {
108 >        checkIsDone(f);
109          assertFalse(f.isCancelled());
110  
111 +        T v1 = null, v2 = null;
112          try {
113 <            assertSame(expected, f.get());
113 >            v1 = f.get();
114 >            v2 = f.get(randomTimeout(), randomTimeUnit());
115          } catch (Throwable fail) { threadUnexpectedException(fail); }
116 <        try {
117 <            assertSame(expected, f.get(5L, SECONDS));
44 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
45 <
46 <        assertFalse(f.cancel(false));
47 <        assertFalse(f.cancel(true));
116 >        assertSame(expectedValue, v1);
117 >        assertSame(expectedValue, v2);
118      }
119  
120      void checkCancelled(Future<?> f) {
121 <        assertTrue(f.isDone());
121 >        checkIsDone(f);
122          assertTrue(f.isCancelled());
123  
124          try {
# Line 58 | Line 128 | public class FutureTaskTest extends JSR1
128          } catch (Throwable fail) { threadUnexpectedException(fail); }
129  
130          try {
131 <            f.get(5L, SECONDS);
131 >            f.get(randomTimeout(), randomTimeUnit());
132              shouldThrow();
133          } catch (CancellationException success) {
134          } catch (Throwable fail) { threadUnexpectedException(fail); }
135 +    }
136  
137 <        assertFalse(f.cancel(false));
138 <        assertFalse(f.cancel(true));
137 >    void tryToConfuseDoneTask(PublicFutureTask pf) {
138 >        pf.set(new Object());
139 >        pf.setException(new Error());
140 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false }) {
141 >            pf.cancel(mayInterruptIfRunning);
142 >        }
143      }
144  
145      void checkCompletedAbnormally(Future<?> f, Throwable t) {
146 <        assertTrue(f.isDone());
146 >        checkIsDone(f);
147          assertFalse(f.isCancelled());
148  
149          try {
# Line 79 | Line 154 | public class FutureTaskTest extends JSR1
154          } catch (Throwable fail) { threadUnexpectedException(fail); }
155  
156          try {
157 <            f.get(5L, SECONDS);
157 >            f.get(randomTimeout(), randomTimeUnit());
158              shouldThrow();
159          } catch (ExecutionException success) {
160              assertSame(t, success.getCause());
161          } catch (Throwable fail) { threadUnexpectedException(fail); }
87
88        assertFalse(f.cancel(false));
89        assertFalse(f.cancel(true));
162      }
163  
164      /**
165       * Subclass to expose protected methods
166       */
167      static class PublicFutureTask extends FutureTask {
168 <        public PublicFutureTask(Callable r) { super(r); }
169 <        public boolean runAndReset() { return super.runAndReset(); }
170 <        public void set(Object x) { super.set(x); }
171 <        public void setException(Throwable t) { super.setException(t); }
168 >        private final AtomicInteger runCount;
169 >        private final AtomicInteger doneCount = new AtomicInteger(0);
170 >        private final AtomicInteger runAndResetCount = new AtomicInteger(0);
171 >        private final AtomicInteger setCount = new AtomicInteger(0);
172 >        private final AtomicInteger setExceptionCount = new AtomicInteger(0);
173 >        public int runCount() { return runCount.get(); }
174 >        public int doneCount() { return doneCount.get(); }
175 >        public int runAndResetCount() { return runAndResetCount.get(); }
176 >        public int setCount() { return setCount.get(); }
177 >        public int setExceptionCount() { return setExceptionCount.get(); }
178 >
179 >        PublicFutureTask(Runnable runnable) {
180 >            this(runnable, seven);
181 >        }
182 >        PublicFutureTask(Runnable runnable, Object result) {
183 >            this(runnable, result, new AtomicInteger(0));
184 >        }
185 >        private PublicFutureTask(final Runnable runnable, Object result,
186 >                                 final AtomicInteger runCount) {
187 >            super(new Runnable() {
188 >                public void run() {
189 >                    runCount.getAndIncrement();
190 >                    runnable.run();
191 >                }}, result);
192 >            this.runCount = runCount;
193 >        }
194 >        PublicFutureTask(Callable callable) {
195 >            this(callable, new AtomicInteger(0));
196 >        }
197 >        private PublicFutureTask(final Callable callable,
198 >                                 final AtomicInteger runCount) {
199 >            super(new Callable() {
200 >                public Object call() throws Exception {
201 >                    runCount.getAndIncrement();
202 >                    return callable.call();
203 >                }});
204 >            this.runCount = runCount;
205 >        }
206 >        @Override public void done() {
207 >            assertTrue(isDone());
208 >            doneCount.incrementAndGet();
209 >            super.done();
210 >        }
211 >        @Override public boolean runAndReset() {
212 >            runAndResetCount.incrementAndGet();
213 >            return super.runAndReset();
214 >        }
215 >        @Override public void set(Object x) {
216 >            setCount.incrementAndGet();
217 >            super.set(x);
218 >        }
219 >        @Override public void setException(Throwable t) {
220 >            setExceptionCount.incrementAndGet();
221 >            super.setException(t);
222 >        }
223 >    }
224 >
225 >    class Counter extends CheckedRunnable {
226 >        final AtomicInteger count = new AtomicInteger(0);
227 >        public int get() { return count.get(); }
228 >        public void realRun() {
229 >            count.getAndIncrement();
230 >        }
231      }
232  
233      /**
234 <     * Creating a future with a null callable throws NPE
234 >     * creating a future with a null callable throws NullPointerException
235       */
236      public void testConstructor() {
237          try {
238 <            FutureTask task = new FutureTask(null);
238 >            new FutureTask(null);
239              shouldThrow();
240          } catch (NullPointerException success) {}
241      }
242  
243      /**
244 <     * creating a future with null runnable fails
244 >     * creating a future with null runnable throws NullPointerException
245       */
246      public void testConstructor2() {
247          try {
248 <            FutureTask task = new FutureTask(null, Boolean.TRUE);
248 >            new FutureTask(null, Boolean.TRUE);
249              shouldThrow();
250          } catch (NullPointerException success) {}
251      }
# Line 123 | Line 254 | public class FutureTaskTest extends JSR1
254       * isDone is true when a task completes
255       */
256      public void testIsDone() {
257 <        FutureTask task = new FutureTask(new NoOpCallable());
257 >        PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
258 >        assertFalse(task.isDone());
259          task.run();
260          assertTrue(task.isDone());
261          checkCompletedNormally(task, Boolean.TRUE);
262 +        assertEquals(1, task.runCount());
263      }
264  
265      /**
# Line 134 | Line 267 | public class FutureTaskTest extends JSR1
267       */
268      public void testRunAndReset() {
269          PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
270 <        assertTrue(task.runAndReset());
271 <        checkNotDone(task);
270 >        for (int i = 0; i < 3; i++) {
271 >            assertTrue(task.runAndReset());
272 >            checkNotDone(task);
273 >            assertEquals(i + 1, task.runCount());
274 >            assertEquals(i + 1, task.runAndResetCount());
275 >            assertEquals(0, task.setCount());
276 >            assertEquals(0, task.setExceptionCount());
277 >        }
278      }
279  
280      /**
281       * runAndReset after cancellation fails
282       */
283 <    public void testResetAfterCancel() {
284 <        PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
285 <        assertTrue(task.cancel(false));
286 <        assertFalse(task.runAndReset());
287 <        checkCancelled(task);
283 >    public void testRunAndResetAfterCancel() {
284 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false }) {
285 >            PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
286 >            assertTrue(task.cancel(mayInterruptIfRunning));
287 >            for (int i = 0; i < 3; i++) {
288 >                assertFalse(task.runAndReset());
289 >                assertEquals(0, task.runCount());
290 >                assertEquals(i + 1, task.runAndResetCount());
291 >                assertEquals(0, task.setCount());
292 >                assertEquals(0, task.setExceptionCount());
293 >            }
294 >            tryToConfuseDoneTask(task);
295 >            checkCancelled(task);
296 >        }
297      }
298  
299      /**
# Line 154 | Line 302 | public class FutureTaskTest extends JSR1
302      public void testSet() throws Exception {
303          PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
304          task.set(one);
305 <        assertSame(task.get(), one);
305 >        for (int i = 0; i < 3; i++) {
306 >            assertSame(one, task.get());
307 >            assertSame(one, task.get(LONG_DELAY_MS, MILLISECONDS));
308 >            assertEquals(1, task.setCount());
309 >        }
310 >        tryToConfuseDoneTask(task);
311          checkCompletedNormally(task, one);
312 +        assertEquals(0, task.runCount());
313      }
314  
315      /**
316       * setException causes get to throw ExecutionException
317       */
318 <    public void testSetException() throws Exception {
318 >    public void testSetException_get() throws Exception {
319          Exception nse = new NoSuchElementException();
320          PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
321          task.setException(nse);
322 +
323 +        try {
324 +            task.get();
325 +            shouldThrow();
326 +        } catch (ExecutionException success) {
327 +            assertSame(nse, success.getCause());
328 +            checkCompletedAbnormally(task, nse);
329 +        }
330 +
331          try {
332 <            Object x = task.get();
332 >            task.get(LONG_DELAY_MS, MILLISECONDS);
333              shouldThrow();
334          } catch (ExecutionException success) {
335 <            assertSame(success.getCause(), nse);
335 >            assertSame(nse, success.getCause());
336              checkCompletedAbnormally(task, nse);
337          }
338 +
339 +        assertEquals(1, task.setExceptionCount());
340 +        assertEquals(0, task.setCount());
341 +        tryToConfuseDoneTask(task);
342 +        checkCompletedAbnormally(task, nse);
343 +        assertEquals(0, task.runCount());
344      }
345  
346      /**
347 <     * Cancelling before running succeeds
347 >     * cancel(false) before run succeeds
348       */
349      public void testCancelBeforeRun() {
350 <        FutureTask task = new FutureTask(new NoOpCallable());
350 >        PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
351          assertTrue(task.cancel(false));
352          task.run();
353 +        assertEquals(0, task.runCount());
354 +        assertEquals(0, task.setCount());
355 +        assertEquals(0, task.setExceptionCount());
356 +        assertTrue(task.isCancelled());
357 +        assertTrue(task.isDone());
358 +        tryToConfuseDoneTask(task);
359 +        assertEquals(0, task.runCount());
360          checkCancelled(task);
361      }
362  
363      /**
364 <     * Cancel(true) before run succeeds
364 >     * cancel(true) before run succeeds
365       */
366      public void testCancelBeforeRun2() {
367 <        FutureTask task = new FutureTask(new NoOpCallable());
367 >        PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
368          assertTrue(task.cancel(true));
369          task.run();
370 +        assertEquals(0, task.runCount());
371 +        assertEquals(0, task.setCount());
372 +        assertEquals(0, task.setExceptionCount());
373 +        assertTrue(task.isCancelled());
374 +        assertTrue(task.isDone());
375 +        tryToConfuseDoneTask(task);
376 +        assertEquals(0, task.runCount());
377          checkCancelled(task);
378      }
379  
380      /**
381 <     * cancel of a completed task fails
381 >     * cancel(false) of a completed task fails
382       */
383      public void testCancelAfterRun() {
384 <        FutureTask task = new FutureTask(new NoOpCallable());
384 >        PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
385          task.run();
386          assertFalse(task.cancel(false));
387 +        assertEquals(1, task.runCount());
388 +        assertEquals(1, task.setCount());
389 +        assertEquals(0, task.setExceptionCount());
390 +        tryToConfuseDoneTask(task);
391          checkCompletedNormally(task, Boolean.TRUE);
392 +        assertEquals(1, task.runCount());
393      }
394  
395      /**
396 <     * cancel(true) interrupts a running task
396 >     * cancel(true) of a completed task fails
397       */
398 <    public void testCancelInterrupt() throws InterruptedException {
399 <        final CountDownLatch threadStarted = new CountDownLatch(1);
400 <        final FutureTask task =
401 <            new FutureTask(new CheckedCallable<Object>() {
402 <                public Object realCall() {
403 <                    threadStarted.countDown();
404 <                    long t0 = System.nanoTime();
405 <                    for (;;) {
406 <                        if (Thread.interrupted())
407 <                            return Boolean.TRUE;
408 <                        if (millisElapsedSince(t0) > MEDIUM_DELAY_MS)
409 <                            fail("interrupt not delivered");
410 <                        Thread.yield();
411 <                    }
398 >    public void testCancelAfterRun2() {
399 >        PublicFutureTask task = new PublicFutureTask(new NoOpCallable());
400 >        task.run();
401 >        assertFalse(task.cancel(true));
402 >        assertEquals(1, task.runCount());
403 >        assertEquals(1, task.setCount());
404 >        assertEquals(0, task.setExceptionCount());
405 >        tryToConfuseDoneTask(task);
406 >        checkCompletedNormally(task, Boolean.TRUE);
407 >        assertEquals(1, task.runCount());
408 >    }
409 >
410 >    /**
411 >     * cancel(true) interrupts a running task that subsequently succeeds
412 >     */
413 >    public void testCancelInterrupt() {
414 >        final CountDownLatch pleaseCancel = new CountDownLatch(1);
415 >        final PublicFutureTask task =
416 >            new PublicFutureTask(new CheckedRunnable() {
417 >                public void realRun() {
418 >                    pleaseCancel.countDown();
419 >                    try {
420 >                        delay(LONG_DELAY_MS);
421 >                        shouldThrow();
422 >                    } catch (InterruptedException success) {}
423 >                    assertFalse(Thread.interrupted());
424                  }});
425  
426          Thread t = newStartedThread(task);
427 <        threadStarted.await();
427 >        await(pleaseCancel);
428          assertTrue(task.cancel(true));
429 <        checkCancelled(task);
430 <        awaitTermination(t, MEDIUM_DELAY_MS);
429 >        assertTrue(task.isCancelled());
430 >        assertTrue(task.isDone());
431 >        awaitTermination(t);
432 >        assertEquals(1, task.runCount());
433 >        assertEquals(1, task.setCount());
434 >        assertEquals(0, task.setExceptionCount());
435 >        tryToConfuseDoneTask(task);
436          checkCancelled(task);
437      }
438  
439      /**
440 <     * cancel(false) does not interrupt a running task
440 >     * cancel(true) tries to interrupt a running task, but
441 >     * Thread.interrupt throws (simulating a restrictive security
442 >     * manager)
443       */
444 <    public void testCancelNoInterrupt() throws InterruptedException {
445 <        final CountDownLatch threadStarted = new CountDownLatch(1);
444 >    public void testCancelInterrupt_ThrowsSecurityException() {
445 >        final CountDownLatch pleaseCancel = new CountDownLatch(1);
446          final CountDownLatch cancelled = new CountDownLatch(1);
447 <        final FutureTask<Boolean> task =
448 <            new FutureTask<Boolean>(new CheckedCallable<Boolean>() {
449 <                public Boolean realCall() throws InterruptedException {
450 <                    threadStarted.countDown();
451 <                    cancelled.await(MEDIUM_DELAY_MS, MILLISECONDS);
447 >        final PublicFutureTask task =
448 >            new PublicFutureTask(new CheckedRunnable() {
449 >                public void realRun() {
450 >                    pleaseCancel.countDown();
451 >                    await(cancelled);
452                      assertFalse(Thread.interrupted());
246                    return Boolean.TRUE;
453                  }});
454  
455 <        Thread t = newStartedThread(task);
456 <        threadStarted.await();
457 <        assertTrue(task.cancel(false));
458 <        checkCancelled(task);
455 >        final Thread t = new Thread(task) {
456 >            // Simulate a restrictive security manager.
457 >            @Override public void interrupt() {
458 >                throw new SecurityException();
459 >            }};
460 >        t.setDaemon(true);
461 >        t.start();
462 >
463 >        await(pleaseCancel);
464 >        try {
465 >            task.cancel(true);
466 >            shouldThrow();
467 >        } catch (SecurityException success) {}
468 >
469 >        // We failed to deliver the interrupt, but the world retains
470 >        // its sanity, as if we had done task.cancel(false)
471 >        assertTrue(task.isCancelled());
472 >        assertTrue(task.isDone());
473 >        assertEquals(1, task.runCount());
474 >        assertEquals(1, task.doneCount());
475 >        assertEquals(0, task.setCount());
476 >        assertEquals(0, task.setExceptionCount());
477          cancelled.countDown();
478 <        awaitTermination(t, MEDIUM_DELAY_MS);
478 >        awaitTermination(t);
479 >        assertEquals(1, task.setCount());
480 >        assertEquals(0, task.setExceptionCount());
481 >        tryToConfuseDoneTask(task);
482          checkCancelled(task);
483      }
484  
485      /**
486 <     * run in one thread causes get in another thread to retrieve value
486 >     * cancel(true) interrupts a running task that subsequently throws
487       */
488 <    public void testGetRun() throws InterruptedException {
489 <        final CountDownLatch threadStarted = new CountDownLatch(1);
490 <
491 <        final FutureTask task =
492 <            new FutureTask(new CheckedCallable<Object>() {
493 <                public Object realCall() throws InterruptedException {
494 <                    return Boolean.TRUE;
488 >    public void testCancelInterrupt_taskFails() {
489 >        final CountDownLatch pleaseCancel = new CountDownLatch(1);
490 >        final PublicFutureTask task =
491 >            new PublicFutureTask(new Runnable() {
492 >                public void run() {
493 >                    pleaseCancel.countDown();
494 >                    try {
495 >                        delay(LONG_DELAY_MS);
496 >                        threadShouldThrow();
497 >                    } catch (InterruptedException success) {
498 >                    } catch (Throwable t) { threadUnexpectedException(t); }
499 >                    throw new RuntimeException();
500                  }});
501  
502 <        Thread t = newStartedThread(new CheckedRunnable() {
503 <            public void realRun() throws Exception {
504 <                threadStarted.countDown();
505 <                assertSame(Boolean.TRUE, task.get());
506 <            }});
507 <
508 <        threadStarted.await();
509 <        checkNotDone(task);
510 <        assertTrue(t.isAlive());
511 <        task.run();
280 <        checkCompletedNormally(task, Boolean.TRUE);
281 <        awaitTermination(t, MEDIUM_DELAY_MS);
502 >        Thread t = newStartedThread(task);
503 >        await(pleaseCancel);
504 >        assertTrue(task.cancel(true));
505 >        assertTrue(task.isCancelled());
506 >        awaitTermination(t);
507 >        assertEquals(1, task.runCount());
508 >        assertEquals(0, task.setCount());
509 >        assertEquals(1, task.setExceptionCount());
510 >        tryToConfuseDoneTask(task);
511 >        checkCancelled(task);
512      }
513  
514      /**
515 <     * set in one thread causes get in another thread to retrieve value
515 >     * cancel(false) does not interrupt a running task
516       */
517 <    public void testGetSet() throws InterruptedException {
518 <        final CountDownLatch threadStarted = new CountDownLatch(1);
519 <
517 >    public void testCancelNoInterrupt() {
518 >        final CountDownLatch pleaseCancel = new CountDownLatch(1);
519 >        final CountDownLatch cancelled = new CountDownLatch(1);
520          final PublicFutureTask task =
521 <            new PublicFutureTask(new CheckedCallable<Object>() {
522 <                public Object realCall() throws InterruptedException {
521 >            new PublicFutureTask(new CheckedCallable<Boolean>() {
522 >                public Boolean realCall() {
523 >                    pleaseCancel.countDown();
524 >                    await(cancelled);
525 >                    assertFalse(Thread.interrupted());
526                      return Boolean.TRUE;
527                  }});
528  
529 <        Thread t = newStartedThread(new CheckedRunnable() {
530 <            public void realRun() throws Exception {
531 <                threadStarted.countDown();
532 <                assertSame(Boolean.FALSE, task.get());
533 <            }});
534 <
535 <        threadStarted.await();
536 <        checkNotDone(task);
537 <        assertTrue(t.isAlive());
538 <        task.set(Boolean.FALSE);
539 <        checkCompletedNormally(task, Boolean.FALSE);
307 <        awaitTermination(t, MEDIUM_DELAY_MS);
529 >        Thread t = newStartedThread(task);
530 >        await(pleaseCancel);
531 >        assertTrue(task.cancel(false));
532 >        assertTrue(task.isCancelled());
533 >        cancelled.countDown();
534 >        awaitTermination(t);
535 >        assertEquals(1, task.runCount());
536 >        assertEquals(1, task.setCount());
537 >        assertEquals(0, task.setExceptionCount());
538 >        tryToConfuseDoneTask(task);
539 >        checkCancelled(task);
540      }
541  
542      /**
543 <     * run in one thread causes timed get in another thread to retrieve value
543 >     * run in one thread causes get in another thread to retrieve value
544       */
545 <    public void testTimedGetRun() throws InterruptedException {
546 <        final CountDownLatch threadStarted = new CountDownLatch(1);
545 >    public void testGetRun() {
546 >        final CountDownLatch pleaseRun = new CountDownLatch(2);
547  
548 <        final FutureTask task =
549 <            new FutureTask(new CheckedCallable<Object>() {
550 <                public Object realCall() throws InterruptedException {
551 <                    return Boolean.TRUE;
548 >        final PublicFutureTask task =
549 >            new PublicFutureTask(new CheckedCallable<Object>() {
550 >                public Object realCall() {
551 >                    return two;
552                  }});
553  
554 <        Thread t = newStartedThread(new CheckedRunnable() {
554 >        Thread t1 = newStartedThread(new CheckedRunnable() {
555              public void realRun() throws Exception {
556 <                threadStarted.countDown();
557 <                assertSame(Boolean.TRUE,
326 <                           task.get(MEDIUM_DELAY_MS, MILLISECONDS));
556 >                pleaseRun.countDown();
557 >                assertSame(two, task.get());
558              }});
559  
560 <        threadStarted.await();
560 >        Thread t2 = newStartedThread(new CheckedRunnable() {
561 >            public void realRun() throws Exception {
562 >                pleaseRun.countDown();
563 >                assertSame(two, task.get(2*LONG_DELAY_MS, MILLISECONDS));
564 >            }});
565 >
566 >        await(pleaseRun);
567          checkNotDone(task);
568 <        assertTrue(t.isAlive());
568 >        assertTrue(t1.isAlive());
569 >        assertTrue(t2.isAlive());
570          task.run();
571 <        checkCompletedNormally(task, Boolean.TRUE);
572 <        awaitTermination(t, MEDIUM_DELAY_MS);
571 >        checkCompletedNormally(task, two);
572 >        assertEquals(1, task.runCount());
573 >        assertEquals(1, task.setCount());
574 >        assertEquals(0, task.setExceptionCount());
575 >        awaitTermination(t1);
576 >        awaitTermination(t2);
577 >        tryToConfuseDoneTask(task);
578 >        checkCompletedNormally(task, two);
579      }
580  
581      /**
582 <     * set in one thread causes timed get in another thread to retrieve value
582 >     * set in one thread causes get in another thread to retrieve value
583       */
584 <    public void testTimedGetSet() throws InterruptedException {
585 <        final CountDownLatch threadStarted = new CountDownLatch(1);
584 >    public void testGetSet() {
585 >        final CountDownLatch pleaseSet = new CountDownLatch(2);
586  
587          final PublicFutureTask task =
588              new PublicFutureTask(new CheckedCallable<Object>() {
589                  public Object realCall() throws InterruptedException {
590 <                    return Boolean.TRUE;
590 >                    return two;
591                  }});
592  
593 <        Thread t = newStartedThread(new CheckedRunnable() {
593 >        Thread t1 = newStartedThread(new CheckedRunnable() {
594 >            public void realRun() throws Exception {
595 >                pleaseSet.countDown();
596 >                assertSame(two, task.get());
597 >            }});
598 >
599 >        Thread t2 = newStartedThread(new CheckedRunnable() {
600              public void realRun() throws Exception {
601 <                threadStarted.countDown();
602 <                assertSame(Boolean.FALSE,
353 <                           task.get(MEDIUM_DELAY_MS, MILLISECONDS));
601 >                pleaseSet.countDown();
602 >                assertSame(two, task.get(2*LONG_DELAY_MS, MILLISECONDS));
603              }});
604  
605 <        threadStarted.await();
605 >        await(pleaseSet);
606          checkNotDone(task);
607 <        assertTrue(t.isAlive());
608 <        task.set(Boolean.FALSE);
609 <        checkCompletedNormally(task, Boolean.FALSE);
610 <        awaitTermination(t, MEDIUM_DELAY_MS);
607 >        assertTrue(t1.isAlive());
608 >        assertTrue(t2.isAlive());
609 >        task.set(two);
610 >        assertEquals(0, task.runCount());
611 >        assertEquals(1, task.setCount());
612 >        assertEquals(0, task.setExceptionCount());
613 >        tryToConfuseDoneTask(task);
614 >        checkCompletedNormally(task, two);
615 >        awaitTermination(t1);
616 >        awaitTermination(t2);
617      }
618  
619      /**
620       * Cancelling a task causes timed get in another thread to throw
621       * CancellationException
622       */
623 <    public void testTimedGet_Cancellation() throws InterruptedException {
624 <        final CountDownLatch threadStarted = new CountDownLatch(2);
370 <        final FutureTask task =
371 <            new FutureTask(new CheckedInterruptedCallable<Object>() {
372 <                public Object realCall() throws InterruptedException {
373 <                    threadStarted.countDown();
374 <                    delay(LONG_DELAY_MS);
375 <                    return Boolean.TRUE;
376 <                }});
377 <
378 <        Thread t1 = new ThreadShouldThrow(CancellationException.class) {
379 <            public void realRun() throws Exception {
380 <                threadStarted.countDown();
381 <                task.get(MEDIUM_DELAY_MS, MILLISECONDS);
382 <            }};
383 <        Thread t2 = new Thread(task);
384 <        t1.start();
385 <        t2.start();
386 <        threadStarted.await();
387 <        task.cancel(true);
388 <        awaitTermination(t1, MEDIUM_DELAY_MS);
389 <        awaitTermination(t2, MEDIUM_DELAY_MS);
390 <        checkCancelled(task);
623 >    public void testTimedGet_Cancellation() {
624 >        testTimedGet_Cancellation(false);
625      }
626 <
627 <    /**
628 <     * Cancelling a task causes get in another thread to throw
629 <     * CancellationException
630 <     */
631 <    public void testGet_Cancellation() throws InterruptedException {
632 <        final CountDownLatch threadStarted = new CountDownLatch(2);
633 <        final FutureTask task =
634 <            new FutureTask(new CheckedInterruptedCallable<Object>() {
635 <                public Object realCall() throws InterruptedException {
636 <                    threadStarted.countDown();
637 <                    delay(LONG_DELAY_MS);
638 <                    return Boolean.TRUE;
639 <                }});
626 >    public void testTimedGet_Cancellation_interrupt() {
627 >        testTimedGet_Cancellation(true);
628 >    }
629 >    public void testTimedGet_Cancellation(final boolean mayInterruptIfRunning) {
630 >        final CountDownLatch pleaseCancel = new CountDownLatch(3);
631 >        final CountDownLatch cancelled = new CountDownLatch(1);
632 >        final Callable<Object> callable =
633 >            new CheckedCallable<Object>() {
634 >            public Object realCall() throws InterruptedException {
635 >                pleaseCancel.countDown();
636 >                if (mayInterruptIfRunning) {
637 >                    try {
638 >                        delay(2*LONG_DELAY_MS);
639 >                    } catch (InterruptedException success) {}
640 >                } else {
641 >                    await(cancelled);
642 >                }
643 >                return two;
644 >            }};
645 >        final PublicFutureTask task = new PublicFutureTask(callable);
646  
647          Thread t1 = new ThreadShouldThrow(CancellationException.class) {
648 <            public void realRun() throws Exception {
649 <                threadStarted.countDown();
650 <                task.get();
651 <            }};
652 <        Thread t2 = new Thread(task);
648 >                public void realRun() throws Exception {
649 >                    pleaseCancel.countDown();
650 >                    task.get();
651 >                }};
652 >        Thread t2 = new ThreadShouldThrow(CancellationException.class) {
653 >                public void realRun() throws Exception {
654 >                    pleaseCancel.countDown();
655 >                    task.get(2*LONG_DELAY_MS, MILLISECONDS);
656 >                }};
657          t1.start();
658          t2.start();
659 <        threadStarted.await();
660 <        task.cancel(true);
661 <        awaitTermination(t1, MEDIUM_DELAY_MS);
662 <        awaitTermination(t2, MEDIUM_DELAY_MS);
659 >        Thread t3 = newStartedThread(task);
660 >        await(pleaseCancel);
661 >        checkIsRunning(task);
662 >        task.cancel(mayInterruptIfRunning);
663 >        checkCancelled(task);
664 >        awaitTermination(t1);
665 >        awaitTermination(t2);
666 >        cancelled.countDown();
667 >        awaitTermination(t3);
668 >        assertEquals(1, task.runCount());
669 >        assertEquals(1, task.setCount());
670 >        assertEquals(0, task.setExceptionCount());
671 >        tryToConfuseDoneTask(task);
672          checkCancelled(task);
673      }
674  
# Line 423 | Line 676 | public class FutureTaskTest extends JSR1
676       * A runtime exception in task causes get to throw ExecutionException
677       */
678      public void testGet_ExecutionException() throws InterruptedException {
679 <        final FutureTask task = new FutureTask(new Callable() {
679 >        final ArithmeticException e = new ArithmeticException();
680 >        final PublicFutureTask task = new PublicFutureTask(new Callable() {
681              public Object call() {
682 <                return 5/0;
682 >                throw e;
683              }});
684  
685          task.run();
686 +        assertEquals(1, task.runCount());
687 +        assertEquals(0, task.setCount());
688 +        assertEquals(1, task.setExceptionCount());
689          try {
690              task.get();
691              shouldThrow();
692          } catch (ExecutionException success) {
693 <            assertTrue(success.getCause() instanceof ArithmeticException);
693 >            assertSame(e, success.getCause());
694 >            tryToConfuseDoneTask(task);
695              checkCompletedAbnormally(task, success.getCause());
696          }
697      }
# Line 442 | Line 700 | public class FutureTaskTest extends JSR1
700       * A runtime exception in task causes timed get to throw ExecutionException
701       */
702      public void testTimedGet_ExecutionException2() throws Exception {
703 <        final FutureTask task = new FutureTask(new Callable() {
703 >        final ArithmeticException e = new ArithmeticException();
704 >        final PublicFutureTask task = new PublicFutureTask(new Callable() {
705              public Object call() {
706 <                return 5/0;
706 >                throw e;
707              }});
708  
709          task.run();
710          try {
711 <            task.get(SHORT_DELAY_MS, MILLISECONDS);
711 >            task.get(LONG_DELAY_MS, MILLISECONDS);
712              shouldThrow();
713          } catch (ExecutionException success) {
714 <            assertTrue(success.getCause() instanceof ArithmeticException);
714 >            assertSame(e, success.getCause());
715 >            tryToConfuseDoneTask(task);
716              checkCompletedAbnormally(task, success.getCause());
717          }
718      }
719  
720      /**
721 <     * Interrupting a waiting get causes it to throw InterruptedException
721 >     * get is interruptible
722       */
723 <    public void testGet_InterruptedException() throws InterruptedException {
724 <        final CountDownLatch threadStarted = new CountDownLatch(1);
723 >    public void testGet_interruptible() {
724 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
725          final FutureTask task = new FutureTask(new NoOpCallable());
726 <        Thread t = newStartedThread(new CheckedInterruptedRunnable() {
726 >        Thread t = newStartedThread(new CheckedRunnable() {
727              public void realRun() throws Exception {
728 <                threadStarted.countDown();
729 <                task.get();
728 >                Thread.currentThread().interrupt();
729 >                try {
730 >                    task.get();
731 >                    shouldThrow();
732 >                } catch (InterruptedException success) {}
733 >                assertFalse(Thread.interrupted());
734 >
735 >                pleaseInterrupt.countDown();
736 >                try {
737 >                    task.get();
738 >                    shouldThrow();
739 >                } catch (InterruptedException success) {}
740 >                assertFalse(Thread.interrupted());
741              }});
742  
743 <        threadStarted.await();
743 >        await(pleaseInterrupt);
744          t.interrupt();
745 <        awaitTermination(t, MEDIUM_DELAY_MS);
745 >        awaitTermination(t);
746          checkNotDone(task);
747      }
748  
749      /**
750 <     * Interrupting a waiting timed get causes it to throw InterruptedException
750 >     * timed get is interruptible
751       */
752 <    public void testTimedGet_InterruptedException2() throws InterruptedException {
753 <        final CountDownLatch threadStarted = new CountDownLatch(1);
752 >    public void testTimedGet_interruptible() {
753 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
754          final FutureTask task = new FutureTask(new NoOpCallable());
755 <        Thread t = newStartedThread(new CheckedInterruptedRunnable() {
755 >        Thread t = newStartedThread(new CheckedRunnable() {
756              public void realRun() throws Exception {
757 <                threadStarted.countDown();
758 <                task.get(LONG_DELAY_MS, MILLISECONDS);
757 >                Thread.currentThread().interrupt();
758 >                try {
759 >                    task.get(2*LONG_DELAY_MS, MILLISECONDS);
760 >                    shouldThrow();
761 >                } catch (InterruptedException success) {}
762 >                assertFalse(Thread.interrupted());
763 >
764 >                pleaseInterrupt.countDown();
765 >                try {
766 >                    task.get(2*LONG_DELAY_MS, MILLISECONDS);
767 >                    shouldThrow();
768 >                } catch (InterruptedException success) {}
769 >                assertFalse(Thread.interrupted());
770              }});
771  
772 <        threadStarted.await();
772 >        await(pleaseInterrupt);
773          t.interrupt();
774 <        awaitTermination(t, MEDIUM_DELAY_MS);
774 >        awaitTermination(t);
775          checkNotDone(task);
776      }
777  
# Line 497 | Line 779 | public class FutureTaskTest extends JSR1
779       * A timed out timed get throws TimeoutException
780       */
781      public void testGet_TimeoutException() throws Exception {
782 +        FutureTask task = new FutureTask(new NoOpCallable());
783 +        long startTime = System.nanoTime();
784          try {
785 <            FutureTask task = new FutureTask(new NoOpCallable());
502 <            task.get(1, MILLISECONDS);
785 >            task.get(timeoutMillis(), MILLISECONDS);
786              shouldThrow();
787 <        } catch (TimeoutException success) {}
787 >        } catch (TimeoutException success) {
788 >            assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
789 >        }
790 >    }
791 >
792 >    /**
793 >     * timed get with null TimeUnit throws NullPointerException
794 >     */
795 >    public void testGet_NullTimeUnit() throws Exception {
796 >        FutureTask task = new FutureTask(new NoOpCallable());
797 >        long[] timeouts = { Long.MIN_VALUE, 0L, Long.MAX_VALUE };
798 >
799 >        for (long timeout : timeouts) {
800 >            try {
801 >                task.get(timeout, null);
802 >                shouldThrow();
803 >            } catch (NullPointerException success) {}
804 >        }
805 >
806 >        task.run();
807 >
808 >        for (long timeout : timeouts) {
809 >            try {
810 >                task.get(timeout, null);
811 >                shouldThrow();
812 >            } catch (NullPointerException success) {}
813 >        }
814 >    }
815 >
816 >    /**
817 >     * timed get with most negative timeout works correctly (i.e. no
818 >     * underflow bug)
819 >     */
820 >    public void testGet_NegativeInfinityTimeout() throws Exception {
821 >        final ExecutorService pool = Executors.newFixedThreadPool(10);
822 >        final Runnable nop = new Runnable() { public void run() {}};
823 >        final FutureTask<Void> task = new FutureTask<>(nop, null);
824 >        final List<Future<?>> futures = new ArrayList<>();
825 >        Runnable r = new Runnable() { public void run() {
826 >            for (long timeout : new long[] { 0L, -1L, Long.MIN_VALUE }) {
827 >                try {
828 >                    task.get(timeout, NANOSECONDS);
829 >                    shouldThrow();
830 >                } catch (TimeoutException success) {
831 >                } catch (Throwable fail) {threadUnexpectedException(fail);}}}};
832 >        for (int i = 0; i < 10; i++)
833 >            futures.add(pool.submit(r));
834 >        try {
835 >            joinPool(pool);
836 >            for (Future<?> future : futures)
837 >                checkCompletedNormally(future, null);
838 >        } finally {
839 >            task.run();         // last resort to help terminate
840 >        }
841 >    }
842 >
843 >    /**
844 >     * toString indicates current completion state
845 >     */
846 >    public void testToString_incomplete() {
847 >        FutureTask<String> f = new FutureTask<>(() -> "");
848 >        assertTrue(f.toString().matches(".*\\[.*Not completed.*\\]"));
849 >        if (testImplementationDetails)
850 >            assertTrue(f.toString().startsWith(
851 >                               identityString(f) + "[Not completed, task ="));
852 >    }
853 >
854 >    public void testToString_normal() {
855 >        FutureTask<String> f = new FutureTask<>(() -> "");
856 >        f.run();
857 >        assertTrue(f.toString().matches(".*\\[.*Completed normally.*\\]"));
858 >        if (testImplementationDetails)
859 >            assertEquals(identityString(f) + "[Completed normally]",
860 >                         f.toString());
861 >    }
862 >
863 >    public void testToString_exception() {
864 >        FutureTask<String> f = new FutureTask<>(
865 >                () -> { throw new ArithmeticException(); });
866 >        f.run();
867 >        assertTrue(f.toString().matches(".*\\[.*Completed exceptionally.*\\]"));
868 >        if (testImplementationDetails)
869 >            assertTrue(f.toString().startsWith(
870 >                               identityString(f) + "[Completed exceptionally: "));
871 >    }
872 >
873 >    public void testToString_cancelled() {
874 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false }) {
875 >            FutureTask<String> f = new FutureTask<>(() -> "");
876 >            assertTrue(f.cancel(mayInterruptIfRunning));
877 >            assertTrue(f.toString().matches(".*\\[.*Cancelled.*\\]"));
878 >            if (testImplementationDetails)
879 >                assertEquals(identityString(f) + "[Cancelled]",
880 >                             f.toString());
881 >        }
882      }
883  
884   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines