ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/JSR166TestCase.java
(Generate patch)

Comparing jsr166/src/test/tck/JSR166TestCase.java (file contents):
Revision 1.151 by jsr166, Sat Oct 3 19:19:01 2015 UTC vs.
Revision 1.194 by jsr166, Mon May 23 18:42:17 2016 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 + /*
10 + * @test
11 + * @summary JSR-166 tck tests
12 + * @modules java.management
13 + * @build *
14 + * @run junit/othervm/timeout=1000 -Djsr166.testImplementationDetails=true JSR166TestCase
15 + * @run junit/othervm/timeout=1000 -Djava.util.concurrent.ForkJoinPool.common.parallelism=0 -Djsr166.testImplementationDetails=true JSR166TestCase
16 + */
17 +
18   import static java.util.concurrent.TimeUnit.MILLISECONDS;
19 + import static java.util.concurrent.TimeUnit.MINUTES;
20   import static java.util.concurrent.TimeUnit.NANOSECONDS;
21  
22   import java.io.ByteArrayInputStream;
# Line 19 | Line 29 | import java.lang.management.ThreadMXBean
29   import java.lang.reflect.Constructor;
30   import java.lang.reflect.Method;
31   import java.lang.reflect.Modifier;
32 + import java.nio.file.Files;
33 + import java.nio.file.Paths;
34   import java.security.CodeSource;
35   import java.security.Permission;
36   import java.security.PermissionCollection;
# Line 47 | Line 59 | import java.util.concurrent.RecursiveAct
59   import java.util.concurrent.RecursiveTask;
60   import java.util.concurrent.RejectedExecutionHandler;
61   import java.util.concurrent.Semaphore;
62 + import java.util.concurrent.SynchronousQueue;
63   import java.util.concurrent.ThreadFactory;
64   import java.util.concurrent.ThreadPoolExecutor;
65   import java.util.concurrent.TimeoutException;
66 + import java.util.concurrent.atomic.AtomicBoolean;
67   import java.util.concurrent.atomic.AtomicReference;
68 + import java.util.regex.Matcher;
69   import java.util.regex.Pattern;
70  
71   import junit.framework.AssertionFailedError;
# Line 108 | Line 123 | import junit.framework.TestSuite;
123   * methods as there are exceptions the method can throw. Sometimes
124   * there are multiple tests per JSR166 method when the different
125   * "normal" behaviors differ significantly. And sometimes testcases
126 < * cover multiple methods when they cannot be tested in
112 < * isolation.
126 > * cover multiple methods when they cannot be tested in isolation.
127   *
128   * <li>The documentation style for testcases is to provide as javadoc
129   * a simple sentence or two describing the property that the testcase
# Line 172 | Line 186 | public class JSR166TestCase extends Test
186      private static final int suiteRuns =
187          Integer.getInteger("jsr166.suiteRuns", 1);
188  
189 +    /**
190 +     * Returns the value of the system property, or NaN if not defined.
191 +     */
192 +    private static float systemPropertyValue(String name) {
193 +        String floatString = System.getProperty(name);
194 +        if (floatString == null)
195 +            return Float.NaN;
196 +        try {
197 +            return Float.parseFloat(floatString);
198 +        } catch (NumberFormatException ex) {
199 +            throw new IllegalArgumentException(
200 +                String.format("Bad float value in system property %s=%s",
201 +                              name, floatString));
202 +        }
203 +    }
204 +
205 +    /**
206 +     * The scaling factor to apply to standard delays used in tests.
207 +     * May be initialized from any of:
208 +     * - the "jsr166.delay.factor" system property
209 +     * - the "test.timeout.factor" system property (as used by jtreg)
210 +     *   See: http://openjdk.java.net/jtreg/tag-spec.html
211 +     * - hard-coded fuzz factor when using a known slowpoke VM
212 +     */
213 +    private static final float delayFactor = delayFactor();
214 +
215 +    private static float delayFactor() {
216 +        float x;
217 +        if (!Float.isNaN(x = systemPropertyValue("jsr166.delay.factor")))
218 +            return x;
219 +        if (!Float.isNaN(x = systemPropertyValue("test.timeout.factor")))
220 +            return x;
221 +        String prop = System.getProperty("java.vm.version");
222 +        if (prop != null && prop.matches(".*debug.*"))
223 +            return 4.0f; // How much slower is fastdebug than product?!
224 +        return 1.0f;
225 +    }
226 +
227      public JSR166TestCase() { super(); }
228      public JSR166TestCase(String name) { super(name); }
229  
# Line 187 | Line 239 | public class JSR166TestCase extends Test
239          return (regex == null) ? null : Pattern.compile(regex);
240      }
241  
242 +    // Instrumentation to debug very rare, but very annoying hung test runs.
243 +    static volatile TestCase currentTestCase;
244 +    // static volatile int currentRun = 0;
245 +    static {
246 +        Runnable checkForWedgedTest = new Runnable() { public void run() {
247 +            // Avoid spurious reports with enormous runsPerTest.
248 +            // A single test case run should never take more than 1 second.
249 +            // But let's cap it at the high end too ...
250 +            final int timeoutMinutes =
251 +                Math.min(15, Math.max(runsPerTest / 60, 1));
252 +            for (TestCase lastTestCase = currentTestCase;;) {
253 +                try { MINUTES.sleep(timeoutMinutes); }
254 +                catch (InterruptedException unexpected) { break; }
255 +                if (lastTestCase == currentTestCase) {
256 +                    System.err.printf(
257 +                        "Looks like we're stuck running test: %s%n",
258 +                        lastTestCase);
259 + //                     System.err.printf(
260 + //                         "Looks like we're stuck running test: %s (%d/%d)%n",
261 + //                         lastTestCase, currentRun, runsPerTest);
262 + //                     System.err.println("availableProcessors=" +
263 + //                         Runtime.getRuntime().availableProcessors());
264 + //                     System.err.printf("cpu model = %s%n", cpuModel());
265 +                    dumpTestThreads();
266 +                    // one stack dump is probably enough; more would be spam
267 +                    break;
268 +                }
269 +                lastTestCase = currentTestCase;
270 +            }}};
271 +        Thread thread = new Thread(checkForWedgedTest, "checkForWedgedTest");
272 +        thread.setDaemon(true);
273 +        thread.start();
274 +    }
275 +
276 + //     public static String cpuModel() {
277 + //         try {
278 + //             Matcher matcher = Pattern.compile("model name\\s*: (.*)")
279 + //                 .matcher(new String(
280 + //                      Files.readAllBytes(Paths.get("/proc/cpuinfo")), "UTF-8"));
281 + //             matcher.find();
282 + //             return matcher.group(1);
283 + //         } catch (Exception ex) { return null; }
284 + //     }
285 +
286      public void runBare() throws Throwable {
287 +        currentTestCase = this;
288          if (methodFilter == null
289              || methodFilter.matcher(toString()).find())
290              super.runBare();
# Line 195 | Line 292 | public class JSR166TestCase extends Test
292  
293      protected void runTest() throws Throwable {
294          for (int i = 0; i < runsPerTest; i++) {
295 +            // currentRun = i;
296              if (profileTests)
297                  runTestProfiled();
298              else
# Line 223 | Line 321 | public class JSR166TestCase extends Test
321          main(suite(), args);
322      }
323  
324 +    static class PithyResultPrinter extends junit.textui.ResultPrinter {
325 +        PithyResultPrinter(java.io.PrintStream writer) { super(writer); }
326 +        long runTime;
327 +        public void startTest(Test test) {}
328 +        protected void printHeader(long runTime) {
329 +            this.runTime = runTime; // defer printing for later
330 +        }
331 +        protected void printFooter(TestResult result) {
332 +            if (result.wasSuccessful()) {
333 +                getWriter().println("OK (" + result.runCount() + " tests)"
334 +                    + "  Time: " + elapsedTimeAsString(runTime));
335 +            } else {
336 +                getWriter().println("Time: " + elapsedTimeAsString(runTime));
337 +                super.printFooter(result);
338 +            }
339 +        }
340 +    }
341 +
342 +    /**
343 +     * Returns a TestRunner that doesn't bother with unnecessary
344 +     * fluff, like printing a "." for each test case.
345 +     */
346 +    static junit.textui.TestRunner newPithyTestRunner() {
347 +        junit.textui.TestRunner runner = new junit.textui.TestRunner();
348 +        runner.setPrinter(new PithyResultPrinter(System.out));
349 +        return runner;
350 +    }
351 +
352      /**
353       * Runs all unit tests in the given test suite.
354       * Actual behavior influenced by jsr166.* system properties.
# Line 234 | Line 360 | public class JSR166TestCase extends Test
360              System.setSecurityManager(new SecurityManager());
361          }
362          for (int i = 0; i < suiteRuns; i++) {
363 <            TestResult result = junit.textui.TestRunner.run(suite);
363 >            TestResult result = newPithyTestRunner().doRun(suite);
364              if (!result.wasSuccessful())
365                  System.exit(1);
366              System.gc();
# Line 387 | Line 513 | public class JSR166TestCase extends Test
513                  "StampedLockTest",
514                  "SubmissionPublisherTest",
515                  "ThreadLocalRandom8Test",
516 +                "TimeUnit8Test",
517              };
518              addNamedTestClasses(suite, java8TestClassNames);
519          }
# Line 394 | Line 521 | public class JSR166TestCase extends Test
521          // Java9+ test classes
522          if (atLeastJava9()) {
523              String[] java9TestClassNames = {
524 <                // Currently empty, but expecting varhandle tests
524 >                "ExecutorCompletionService9Test",
525              };
526              addNamedTestClasses(suite, java9TestClassNames);
527          }
# Line 461 | Line 588 | public class JSR166TestCase extends Test
588          } else {
589              return new TestSuite();
590          }
464
591      }
592  
593      // Delays for timing-dependent tests, in milliseconds.
# Line 472 | Line 598 | public class JSR166TestCase extends Test
598      public static long LONG_DELAY_MS;
599  
600      /**
601 <     * Returns the shortest timed delay. This could
602 <     * be reimplemented to use for example a Property.
601 >     * Returns the shortest timed delay. This can be scaled up for
602 >     * slow machines using the jsr166.delay.factor system property,
603 >     * or via jtreg's -timeoutFactor: flag.
604 >     * http://openjdk.java.net/jtreg/command-help.html
605       */
606      protected long getShortDelay() {
607 <        return 50;
607 >        return (long) (50 * delayFactor);
608      }
609  
610      /**
# Line 519 | Line 647 | public class JSR166TestCase extends Test
647       * the same test have no effect.
648       */
649      public void threadRecordFailure(Throwable t) {
650 +        System.err.println(t);
651 +        dumpTestThreads();
652          threadFailure.compareAndSet(null, t);
653      }
654  
# Line 529 | Line 659 | public class JSR166TestCase extends Test
659      void tearDownFail(String format, Object... args) {
660          String msg = toString() + ": " + String.format(format, args);
661          System.err.println(msg);
662 <        printAllStackTraces();
662 >        dumpTestThreads();
663          throw new AssertionFailedError(msg);
664      }
665  
# Line 566 | Line 696 | public class JSR166TestCase extends Test
696      }
697  
698      /**
699 <     * Finds missing try { ... } finally { joinPool(e); }
699 >     * Finds missing PoolCleaners
700       */
701      void checkForkJoinPoolThreadLeaks() throws InterruptedException {
702          Thread[] survivors = new Thread[7];
# Line 598 | Line 728 | public class JSR166TestCase extends Test
728              fail(reason);
729          } catch (AssertionFailedError t) {
730              threadRecordFailure(t);
731 <            fail(reason);
731 >            throw t;
732          }
733      }
734  
# Line 725 | Line 855 | public class JSR166TestCase extends Test
855      /**
856       * Delays, via Thread.sleep, for the given millisecond delay, but
857       * if the sleep is shorter than specified, may re-sleep or yield
858 <     * until time elapses.
858 >     * until time elapses.  Ensures that the given time, as measured
859 >     * by System.nanoTime(), has elapsed.
860       */
861      static void delay(long millis) throws InterruptedException {
862 <        long startTime = System.nanoTime();
863 <        long ns = millis * 1000 * 1000;
864 <        for (;;) {
862 >        long nanos = millis * (1000 * 1000);
863 >        final long wakeupTime = System.nanoTime() + nanos;
864 >        do {
865              if (millis > 0L)
866                  Thread.sleep(millis);
867              else // too short to sleep
868                  Thread.yield();
869 <            long d = ns - (System.nanoTime() - startTime);
870 <            if (d > 0L)
871 <                millis = d / (1000 * 1000);
741 <            else
742 <                break;
743 <        }
869 >            nanos = wakeupTime - System.nanoTime();
870 >            millis = nanos / (1000 * 1000);
871 >        } while (nanos >= 0L);
872      }
873  
874      /**
875       * Allows use of try-with-resources with per-test thread pools.
876       */
877 <    static class PoolCloser<T extends ExecutorService>
878 <            implements AutoCloseable {
879 <        public final T pool;
752 <        public PoolCloser(T pool) { this.pool = pool; }
877 >    class PoolCleaner implements AutoCloseable {
878 >        private final ExecutorService pool;
879 >        public PoolCleaner(ExecutorService pool) { this.pool = pool; }
880          public void close() { joinPool(pool); }
881      }
882  
883      /**
884 +     * An extension of PoolCleaner that has an action to release the pool.
885 +     */
886 +    class PoolCleanerWithReleaser extends PoolCleaner {
887 +        private final Runnable releaser;
888 +        public PoolCleanerWithReleaser(ExecutorService pool, Runnable releaser) {
889 +            super(pool);
890 +            this.releaser = releaser;
891 +        }
892 +        public void close() {
893 +            try {
894 +                releaser.run();
895 +            } finally {
896 +                super.close();
897 +            }
898 +        }
899 +    }
900 +
901 +    PoolCleaner cleaner(ExecutorService pool) {
902 +        return new PoolCleaner(pool);
903 +    }
904 +
905 +    PoolCleaner cleaner(ExecutorService pool, Runnable releaser) {
906 +        return new PoolCleanerWithReleaser(pool, releaser);
907 +    }
908 +
909 +    PoolCleaner cleaner(ExecutorService pool, CountDownLatch latch) {
910 +        return new PoolCleanerWithReleaser(pool, releaser(latch));
911 +    }
912 +
913 +    Runnable releaser(final CountDownLatch latch) {
914 +        return new Runnable() { public void run() {
915 +            do { latch.countDown(); }
916 +            while (latch.getCount() > 0);
917 +        }};
918 +    }
919 +
920 +    PoolCleaner cleaner(ExecutorService pool, AtomicBoolean flag) {
921 +        return new PoolCleanerWithReleaser(pool, releaser(flag));
922 +    }
923 +
924 +    Runnable releaser(final AtomicBoolean flag) {
925 +        return new Runnable() { public void run() { flag.set(true); }};
926 +    }
927 +
928 +    /**
929       * Waits out termination of a thread pool or fails doing so.
930       */
931 <    static void joinPool(ExecutorService pool) {
931 >    void joinPool(ExecutorService pool) {
932          try {
933              pool.shutdown();
934 <            if (!pool.awaitTermination(2 * LONG_DELAY_MS, MILLISECONDS))
935 <                fail("ExecutorService " + pool +
936 <                     " did not terminate in a timely manner");
934 >            if (!pool.awaitTermination(2 * LONG_DELAY_MS, MILLISECONDS)) {
935 >                try {
936 >                    threadFail("ExecutorService " + pool +
937 >                               " did not terminate in a timely manner");
938 >                } finally {
939 >                    // last resort, for the benefit of subsequent tests
940 >                    pool.shutdownNow();
941 >                    pool.awaitTermination(MEDIUM_DELAY_MS, MILLISECONDS);
942 >                }
943 >            }
944          } catch (SecurityException ok) {
945              // Allowed in case test doesn't have privs
946          } catch (InterruptedException fail) {
947 <            fail("Unexpected InterruptedException");
947 >            threadFail("Unexpected InterruptedException");
948          }
949      }
950  
# Line 778 | Line 957 | public class JSR166TestCase extends Test
957       * necessarily individually slow because they must block.
958       */
959      void testInParallel(Action ... actions) {
960 <        try (PoolCloser<ExecutorService> poolCloser
961 <             = new PoolCloser<>(Executors.newCachedThreadPool())) {
783 <            ExecutorService pool = poolCloser.pool;
960 >        ExecutorService pool = Executors.newCachedThreadPool();
961 >        try (PoolCleaner cleaner = cleaner(pool)) {
962              ArrayList<Future<?>> futures = new ArrayList<>(actions.length);
963              for (final Action action : actions)
964                  futures.add(pool.submit(new CheckedRunnable() {
# Line 797 | Line 975 | public class JSR166TestCase extends Test
975      }
976  
977      /**
978 <     * A debugging tool to print all stack traces, as jstack does.
978 >     * A debugging tool to print stack traces of most threads, as jstack does.
979       * Uninteresting threads are filtered out.
980       */
981 <    static void printAllStackTraces() {
981 >    static void dumpTestThreads() {
982          ThreadMXBean threadMXBean = ManagementFactory.getThreadMXBean();
983          System.err.println("------ stacktrace dump start ------");
984          for (ThreadInfo info : threadMXBean.dumpAllThreads(true, true)) {
# Line 813 | Line 991 | public class JSR166TestCase extends Test
991              if ("Finalizer".equals(name)
992                  && info.getLockName().startsWith("java.lang.ref.ReferenceQueue$Lock"))
993                  continue;
994 +            if ("checkForWedgedTest".equals(name))
995 +                continue;
996              System.err.print(info);
997          }
998          System.err.println("------ stacktrace dump end ------");
# Line 835 | Line 1015 | public class JSR166TestCase extends Test
1015              delay(millis);
1016              assertTrue(thread.isAlive());
1017          } catch (InterruptedException fail) {
1018 <            fail("Unexpected InterruptedException");
1018 >            threadFail("Unexpected InterruptedException");
1019          }
1020      }
1021  
# Line 857 | Line 1037 | public class JSR166TestCase extends Test
1037              for (Thread thread : threads)
1038                  assertTrue(thread.isAlive());
1039          } catch (InterruptedException fail) {
1040 <            fail("Unexpected InterruptedException");
1040 >            threadFail("Unexpected InterruptedException");
1041          }
1042      }
1043  
# Line 1135 | Line 1315 | public class JSR166TestCase extends Test
1315          } finally {
1316              if (t.getState() != Thread.State.TERMINATED) {
1317                  t.interrupt();
1318 <                fail("Test timed out");
1318 >                threadFail("timed out waiting for thread to terminate");
1319              }
1320          }
1321      }
# Line 1283 | Line 1463 | public class JSR166TestCase extends Test
1463              }};
1464      }
1465  
1466 <    public Runnable awaiter(final CountDownLatch latch) {
1467 <        return new CheckedRunnable() {
1468 <            public void realRun() throws InterruptedException {
1469 <                await(latch);
1470 <            }};
1466 >    class LatchAwaiter extends CheckedRunnable {
1467 >        static final int NEW = 0;
1468 >        static final int RUNNING = 1;
1469 >        static final int DONE = 2;
1470 >        final CountDownLatch latch;
1471 >        int state = NEW;
1472 >        LatchAwaiter(CountDownLatch latch) { this.latch = latch; }
1473 >        public void realRun() throws InterruptedException {
1474 >            state = 1;
1475 >            await(latch);
1476 >            state = 2;
1477 >        }
1478      }
1479  
1480 <    public void await(CountDownLatch latch) {
1480 >    public LatchAwaiter awaiter(CountDownLatch latch) {
1481 >        return new LatchAwaiter(latch);
1482 >    }
1483 >
1484 >    public void await(CountDownLatch latch, long timeoutMillis) {
1485          try {
1486 <            assertTrue(latch.await(LONG_DELAY_MS, MILLISECONDS));
1486 >            if (!latch.await(timeoutMillis, MILLISECONDS))
1487 >                fail("timed out waiting for CountDownLatch for "
1488 >                     + (timeoutMillis/1000) + " sec");
1489          } catch (Throwable fail) {
1490              threadUnexpectedException(fail);
1491          }
1492      }
1493  
1494 +    public void await(CountDownLatch latch) {
1495 +        await(latch, LONG_DELAY_MS);
1496 +    }
1497 +
1498      public void await(Semaphore semaphore) {
1499          try {
1500 <            assertTrue(semaphore.tryAcquire(LONG_DELAY_MS, MILLISECONDS));
1500 >            if (!semaphore.tryAcquire(LONG_DELAY_MS, MILLISECONDS))
1501 >                fail("timed out waiting for Semaphore for "
1502 >                     + (LONG_DELAY_MS/1000) + " sec");
1503          } catch (Throwable fail) {
1504              threadUnexpectedException(fail);
1505          }
# Line 1636 | Line 1835 | public class JSR166TestCase extends Test
1835          } catch (NoSuchElementException success) {}
1836          assertFalse(it.hasNext());
1837      }
1838 +
1839 +    public <T> Callable<T> callableThrowing(final Exception ex) {
1840 +        return new Callable<T>() { public T call() throws Exception { throw ex; }};
1841 +    }
1842 +
1843 +    public Runnable runnableThrowing(final RuntimeException ex) {
1844 +        return new Runnable() { public void run() { throw ex; }};
1845 +    }
1846 +
1847 +    /** A reusable thread pool to be shared by tests. */
1848 +    static final ExecutorService cachedThreadPool =
1849 +        new ThreadPoolExecutor(0, Integer.MAX_VALUE,
1850 +                               1000L, MILLISECONDS,
1851 +                               new SynchronousQueue<Runnable>());
1852 +
1853   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines