ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/JSR166TestCase.java
(Generate patch)

Comparing jsr166/src/test/tck/JSR166TestCase.java (file contents):
Revision 1.157 by jsr166, Sat Oct 3 22:20:05 2015 UTC vs.
Revision 1.202 by jsr166, Thu Sep 15 00:32:45 2016 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 + /*
10 + * @test
11 + * @summary JSR-166 tck tests
12 + * @modules java.management
13 + * @build *
14 + * @run junit/othervm/timeout=1000 -Djsr166.testImplementationDetails=true JSR166TestCase
15 + * @run junit/othervm/timeout=1000 -Djava.util.concurrent.ForkJoinPool.common.parallelism=0 -Djsr166.testImplementationDetails=true JSR166TestCase
16 + * @run junit/othervm/timeout=1000 -Djava.util.concurrent.ForkJoinPool.common.parallelism=1 -Djava.util.secureRandomSeed=true JSR166TestCase
17 + */
18 +
19   import static java.util.concurrent.TimeUnit.MILLISECONDS;
20   import static java.util.concurrent.TimeUnit.MINUTES;
21   import static java.util.concurrent.TimeUnit.NANOSECONDS;
# Line 20 | Line 30 | import java.lang.management.ThreadMXBean
30   import java.lang.reflect.Constructor;
31   import java.lang.reflect.Method;
32   import java.lang.reflect.Modifier;
33 + import java.nio.file.Files;
34 + import java.nio.file.Paths;
35   import java.security.CodeSource;
36   import java.security.Permission;
37   import java.security.PermissionCollection;
# Line 29 | Line 41 | import java.security.ProtectionDomain;
41   import java.security.SecurityPermission;
42   import java.util.ArrayList;
43   import java.util.Arrays;
44 + import java.util.Collections;
45   import java.util.Date;
46   import java.util.Enumeration;
47   import java.util.Iterator;
# Line 48 | Line 61 | import java.util.concurrent.RecursiveAct
61   import java.util.concurrent.RecursiveTask;
62   import java.util.concurrent.RejectedExecutionHandler;
63   import java.util.concurrent.Semaphore;
64 + import java.util.concurrent.SynchronousQueue;
65   import java.util.concurrent.ThreadFactory;
66 + import java.util.concurrent.ThreadLocalRandom;
67   import java.util.concurrent.ThreadPoolExecutor;
68   import java.util.concurrent.TimeoutException;
69 + import java.util.concurrent.atomic.AtomicBoolean;
70   import java.util.concurrent.atomic.AtomicReference;
71 + import java.util.regex.Matcher;
72   import java.util.regex.Pattern;
73  
74   import junit.framework.AssertionFailedError;
# Line 109 | Line 126 | import junit.framework.TestSuite;
126   * methods as there are exceptions the method can throw. Sometimes
127   * there are multiple tests per JSR166 method when the different
128   * "normal" behaviors differ significantly. And sometimes testcases
129 < * cover multiple methods when they cannot be tested in
113 < * isolation.
129 > * cover multiple methods when they cannot be tested in isolation.
130   *
131   * <li>The documentation style for testcases is to provide as javadoc
132   * a simple sentence or two describing the property that the testcase
# Line 173 | Line 189 | public class JSR166TestCase extends Test
189      private static final int suiteRuns =
190          Integer.getInteger("jsr166.suiteRuns", 1);
191  
192 +    /**
193 +     * Returns the value of the system property, or NaN if not defined.
194 +     */
195 +    private static float systemPropertyValue(String name) {
196 +        String floatString = System.getProperty(name);
197 +        if (floatString == null)
198 +            return Float.NaN;
199 +        try {
200 +            return Float.parseFloat(floatString);
201 +        } catch (NumberFormatException ex) {
202 +            throw new IllegalArgumentException(
203 +                String.format("Bad float value in system property %s=%s",
204 +                              name, floatString));
205 +        }
206 +    }
207 +
208 +    /**
209 +     * The scaling factor to apply to standard delays used in tests.
210 +     * May be initialized from any of:
211 +     * - the "jsr166.delay.factor" system property
212 +     * - the "test.timeout.factor" system property (as used by jtreg)
213 +     *   See: http://openjdk.java.net/jtreg/tag-spec.html
214 +     * - hard-coded fuzz factor when using a known slowpoke VM
215 +     */
216 +    private static final float delayFactor = delayFactor();
217 +
218 +    private static float delayFactor() {
219 +        float x;
220 +        if (!Float.isNaN(x = systemPropertyValue("jsr166.delay.factor")))
221 +            return x;
222 +        if (!Float.isNaN(x = systemPropertyValue("test.timeout.factor")))
223 +            return x;
224 +        String prop = System.getProperty("java.vm.version");
225 +        if (prop != null && prop.matches(".*debug.*"))
226 +            return 4.0f; // How much slower is fastdebug than product?!
227 +        return 1.0f;
228 +    }
229 +
230      public JSR166TestCase() { super(); }
231      public JSR166TestCase(String name) { super(name); }
232  
# Line 188 | Line 242 | public class JSR166TestCase extends Test
242          return (regex == null) ? null : Pattern.compile(regex);
243      }
244  
245 +    // Instrumentation to debug very rare, but very annoying hung test runs.
246      static volatile TestCase currentTestCase;
247 +    // static volatile int currentRun = 0;
248      static {
249          Runnable checkForWedgedTest = new Runnable() { public void run() {
250 <            // avoid spurious reports with enormous runsPerTest
251 <            final int timeoutMinutes = Math.max(runsPerTest / 10, 1);
250 >            // Avoid spurious reports with enormous runsPerTest.
251 >            // A single test case run should never take more than 1 second.
252 >            // But let's cap it at the high end too ...
253 >            final int timeoutMinutes =
254 >                Math.min(15, Math.max(runsPerTest / 60, 1));
255              for (TestCase lastTestCase = currentTestCase;;) {
256                  try { MINUTES.sleep(timeoutMinutes); }
257                  catch (InterruptedException unexpected) { break; }
258                  if (lastTestCase == currentTestCase) {
259 <                    System.err.println
260 <                        ("Looks like we're stuck running test: "
261 <                         + lastTestCase);
259 >                    System.err.printf(
260 >                        "Looks like we're stuck running test: %s%n",
261 >                        lastTestCase);
262 > //                     System.err.printf(
263 > //                         "Looks like we're stuck running test: %s (%d/%d)%n",
264 > //                         lastTestCase, currentRun, runsPerTest);
265 > //                     System.err.println("availableProcessors=" +
266 > //                         Runtime.getRuntime().availableProcessors());
267 > //                     System.err.printf("cpu model = %s%n", cpuModel());
268                      dumpTestThreads();
269 +                    // one stack dump is probably enough; more would be spam
270 +                    break;
271                  }
272                  lastTestCase = currentTestCase;
273              }}};
# Line 209 | Line 276 | public class JSR166TestCase extends Test
276          thread.start();
277      }
278  
279 + //     public static String cpuModel() {
280 + //         try {
281 + //             Matcher matcher = Pattern.compile("model name\\s*: (.*)")
282 + //                 .matcher(new String(
283 + //                      Files.readAllBytes(Paths.get("/proc/cpuinfo")), "UTF-8"));
284 + //             matcher.find();
285 + //             return matcher.group(1);
286 + //         } catch (Exception ex) { return null; }
287 + //     }
288 +
289      public void runBare() throws Throwable {
290          currentTestCase = this;
291          if (methodFilter == null
# Line 218 | Line 295 | public class JSR166TestCase extends Test
295  
296      protected void runTest() throws Throwable {
297          for (int i = 0; i < runsPerTest; i++) {
298 +            // currentRun = i;
299              if (profileTests)
300                  runTestProfiled();
301              else
# Line 246 | Line 324 | public class JSR166TestCase extends Test
324          main(suite(), args);
325      }
326  
327 +    static class PithyResultPrinter extends junit.textui.ResultPrinter {
328 +        PithyResultPrinter(java.io.PrintStream writer) { super(writer); }
329 +        long runTime;
330 +        public void startTest(Test test) {}
331 +        protected void printHeader(long runTime) {
332 +            this.runTime = runTime; // defer printing for later
333 +        }
334 +        protected void printFooter(TestResult result) {
335 +            if (result.wasSuccessful()) {
336 +                getWriter().println("OK (" + result.runCount() + " tests)"
337 +                    + "  Time: " + elapsedTimeAsString(runTime));
338 +            } else {
339 +                getWriter().println("Time: " + elapsedTimeAsString(runTime));
340 +                super.printFooter(result);
341 +            }
342 +        }
343 +    }
344 +
345 +    /**
346 +     * Returns a TestRunner that doesn't bother with unnecessary
347 +     * fluff, like printing a "." for each test case.
348 +     */
349 +    static junit.textui.TestRunner newPithyTestRunner() {
350 +        junit.textui.TestRunner runner = new junit.textui.TestRunner();
351 +        runner.setPrinter(new PithyResultPrinter(System.out));
352 +        return runner;
353 +    }
354 +
355      /**
356       * Runs all unit tests in the given test suite.
357       * Actual behavior influenced by jsr166.* system properties.
# Line 257 | Line 363 | public class JSR166TestCase extends Test
363              System.setSecurityManager(new SecurityManager());
364          }
365          for (int i = 0; i < suiteRuns; i++) {
366 <            TestResult result = junit.textui.TestRunner.run(suite);
366 >            TestResult result = newPithyTestRunner().doRun(suite);
367              if (!result.wasSuccessful())
368                  System.exit(1);
369              System.gc();
# Line 410 | Line 516 | public class JSR166TestCase extends Test
516                  "StampedLockTest",
517                  "SubmissionPublisherTest",
518                  "ThreadLocalRandom8Test",
519 +                "TimeUnit8Test",
520              };
521              addNamedTestClasses(suite, java8TestClassNames);
522          }
# Line 417 | Line 524 | public class JSR166TestCase extends Test
524          // Java9+ test classes
525          if (atLeastJava9()) {
526              String[] java9TestClassNames = {
527 <                // Currently empty, but expecting varhandle tests
527 >                "AtomicBoolean9Test",
528 >                "AtomicInteger9Test",
529 >                "AtomicIntegerArray9Test",
530 >                "AtomicLong9Test",
531 >                "AtomicLongArray9Test",
532 >                "AtomicReference9Test",
533 >                "AtomicReferenceArray9Test",
534 >                "ExecutorCompletionService9Test",
535              };
536              addNamedTestClasses(suite, java9TestClassNames);
537          }
# Line 494 | Line 608 | public class JSR166TestCase extends Test
608      public static long LONG_DELAY_MS;
609  
610      /**
611 <     * Returns the shortest timed delay. This could
612 <     * be reimplemented to use for example a Property.
611 >     * Returns the shortest timed delay. This can be scaled up for
612 >     * slow machines using the jsr166.delay.factor system property,
613 >     * or via jtreg's -timeoutFactor: flag.
614 >     * http://openjdk.java.net/jtreg/command-help.html
615       */
616      protected long getShortDelay() {
617 <        return 50;
617 >        return (long) (50 * delayFactor);
618      }
619  
620      /**
# Line 541 | Line 657 | public class JSR166TestCase extends Test
657       * the same test have no effect.
658       */
659      public void threadRecordFailure(Throwable t) {
660 +        System.err.println(t);
661          dumpTestThreads();
662          threadFailure.compareAndSet(null, t);
663      }
# Line 589 | Line 706 | public class JSR166TestCase extends Test
706      }
707  
708      /**
709 <     * Finds missing try { ... } finally { joinPool(e); }
709 >     * Finds missing PoolCleaners
710       */
711      void checkForkJoinPoolThreadLeaks() throws InterruptedException {
712          Thread[] survivors = new Thread[7];
# Line 748 | Line 865 | public class JSR166TestCase extends Test
865      /**
866       * Delays, via Thread.sleep, for the given millisecond delay, but
867       * if the sleep is shorter than specified, may re-sleep or yield
868 <     * until time elapses.
868 >     * until time elapses.  Ensures that the given time, as measured
869 >     * by System.nanoTime(), has elapsed.
870       */
871      static void delay(long millis) throws InterruptedException {
872 <        long startTime = System.nanoTime();
873 <        long ns = millis * 1000 * 1000;
874 <        for (;;) {
872 >        long nanos = millis * (1000 * 1000);
873 >        final long wakeupTime = System.nanoTime() + nanos;
874 >        do {
875              if (millis > 0L)
876                  Thread.sleep(millis);
877              else // too short to sleep
878                  Thread.yield();
879 <            long d = ns - (System.nanoTime() - startTime);
880 <            if (d > 0L)
881 <                millis = d / (1000 * 1000);
764 <            else
765 <                break;
766 <        }
879 >            nanos = wakeupTime - System.nanoTime();
880 >            millis = nanos / (1000 * 1000);
881 >        } while (nanos >= 0L);
882      }
883  
884      /**
885       * Allows use of try-with-resources with per-test thread pools.
886       */
887 <    static class PoolCloser<T extends ExecutorService>
888 <            implements AutoCloseable {
889 <        public final T pool;
775 <        public PoolCloser(T pool) { this.pool = pool; }
887 >    class PoolCleaner implements AutoCloseable {
888 >        private final ExecutorService pool;
889 >        public PoolCleaner(ExecutorService pool) { this.pool = pool; }
890          public void close() { joinPool(pool); }
891      }
892  
893      /**
894 +     * An extension of PoolCleaner that has an action to release the pool.
895 +     */
896 +    class PoolCleanerWithReleaser extends PoolCleaner {
897 +        private final Runnable releaser;
898 +        public PoolCleanerWithReleaser(ExecutorService pool, Runnable releaser) {
899 +            super(pool);
900 +            this.releaser = releaser;
901 +        }
902 +        public void close() {
903 +            try {
904 +                releaser.run();
905 +            } finally {
906 +                super.close();
907 +            }
908 +        }
909 +    }
910 +
911 +    PoolCleaner cleaner(ExecutorService pool) {
912 +        return new PoolCleaner(pool);
913 +    }
914 +
915 +    PoolCleaner cleaner(ExecutorService pool, Runnable releaser) {
916 +        return new PoolCleanerWithReleaser(pool, releaser);
917 +    }
918 +
919 +    PoolCleaner cleaner(ExecutorService pool, CountDownLatch latch) {
920 +        return new PoolCleanerWithReleaser(pool, releaser(latch));
921 +    }
922 +
923 +    Runnable releaser(final CountDownLatch latch) {
924 +        return new Runnable() { public void run() {
925 +            do { latch.countDown(); }
926 +            while (latch.getCount() > 0);
927 +        }};
928 +    }
929 +
930 +    PoolCleaner cleaner(ExecutorService pool, AtomicBoolean flag) {
931 +        return new PoolCleanerWithReleaser(pool, releaser(flag));
932 +    }
933 +
934 +    Runnable releaser(final AtomicBoolean flag) {
935 +        return new Runnable() { public void run() { flag.set(true); }};
936 +    }
937 +
938 +    /**
939       * Waits out termination of a thread pool or fails doing so.
940       */
941 <    static void joinPool(ExecutorService pool) {
941 >    void joinPool(ExecutorService pool) {
942          try {
943              pool.shutdown();
944 <            if (!pool.awaitTermination(2 * LONG_DELAY_MS, MILLISECONDS))
945 <                fail("ExecutorService " + pool +
946 <                     " did not terminate in a timely manner");
944 >            if (!pool.awaitTermination(2 * LONG_DELAY_MS, MILLISECONDS)) {
945 >                try {
946 >                    threadFail("ExecutorService " + pool +
947 >                               " did not terminate in a timely manner");
948 >                } finally {
949 >                    // last resort, for the benefit of subsequent tests
950 >                    pool.shutdownNow();
951 >                    pool.awaitTermination(MEDIUM_DELAY_MS, MILLISECONDS);
952 >                }
953 >            }
954          } catch (SecurityException ok) {
955              // Allowed in case test doesn't have privs
956          } catch (InterruptedException fail) {
957 <            fail("Unexpected InterruptedException");
957 >            threadFail("Unexpected InterruptedException");
958          }
959      }
960  
961 <    /** Like Runnable, but with the freedom to throw anything */
961 >    /**
962 >     * Like Runnable, but with the freedom to throw anything.
963 >     * junit folks had the same idea:
964 >     * http://junit.org/junit5/docs/snapshot/api/org/junit/gen5/api/Executable.html
965 >     */
966      interface Action { public void run() throws Throwable; }
967  
968      /**
# Line 801 | Line 971 | public class JSR166TestCase extends Test
971       * necessarily individually slow because they must block.
972       */
973      void testInParallel(Action ... actions) {
974 <        try (PoolCloser<ExecutorService> poolCloser
975 <             = new PoolCloser<>(Executors.newCachedThreadPool())) {
806 <            ExecutorService pool = poolCloser.pool;
974 >        ExecutorService pool = Executors.newCachedThreadPool();
975 >        try (PoolCleaner cleaner = cleaner(pool)) {
976              ArrayList<Future<?>> futures = new ArrayList<>(actions.length);
977              for (final Action action : actions)
978                  futures.add(pool.submit(new CheckedRunnable() {
# Line 824 | Line 993 | public class JSR166TestCase extends Test
993       * Uninteresting threads are filtered out.
994       */
995      static void dumpTestThreads() {
996 +        SecurityManager sm = System.getSecurityManager();
997 +        if (sm != null) {
998 +            try {
999 +                System.setSecurityManager(null);
1000 +            } catch (SecurityException giveUp) {
1001 +                return;
1002 +            }
1003 +        }
1004 +
1005          ThreadMXBean threadMXBean = ManagementFactory.getThreadMXBean();
1006          System.err.println("------ stacktrace dump start ------");
1007          for (ThreadInfo info : threadMXBean.dumpAllThreads(true, true)) {
# Line 841 | Line 1019 | public class JSR166TestCase extends Test
1019              System.err.print(info);
1020          }
1021          System.err.println("------ stacktrace dump end ------");
1022 +
1023 +        if (sm != null) System.setSecurityManager(sm);
1024      }
1025  
1026      /**
# Line 860 | Line 1040 | public class JSR166TestCase extends Test
1040              delay(millis);
1041              assertTrue(thread.isAlive());
1042          } catch (InterruptedException fail) {
1043 <            fail("Unexpected InterruptedException");
1043 >            threadFail("Unexpected InterruptedException");
1044          }
1045      }
1046  
# Line 882 | Line 1062 | public class JSR166TestCase extends Test
1062              for (Thread thread : threads)
1063                  assertTrue(thread.isAlive());
1064          } catch (InterruptedException fail) {
1065 <            fail("Unexpected InterruptedException");
1065 >            threadFail("Unexpected InterruptedException");
1066          }
1067      }
1068  
# Line 1057 | Line 1237 | public class JSR166TestCase extends Test
1237       * Sleeps until the given time has elapsed.
1238       * Throws AssertionFailedError if interrupted.
1239       */
1240 <    void sleep(long millis) {
1240 >    static void sleep(long millis) {
1241          try {
1242              delay(millis);
1243          } catch (InterruptedException fail) {
# Line 1073 | Line 1253 | public class JSR166TestCase extends Test
1253       * thread to enter a wait state: BLOCKED, WAITING, or TIMED_WAITING.
1254       */
1255      void waitForThreadToEnterWaitState(Thread thread, long timeoutMillis) {
1256 <        long startTime = System.nanoTime();
1256 >        long startTime = 0L;
1257          for (;;) {
1258              Thread.State s = thread.getState();
1259              if (s == Thread.State.BLOCKED ||
# Line 1082 | Line 1262 | public class JSR166TestCase extends Test
1262                  return;
1263              else if (s == Thread.State.TERMINATED)
1264                  fail("Unexpected thread termination");
1265 +            else if (startTime == 0L)
1266 +                startTime = System.nanoTime();
1267              else if (millisElapsedSince(startTime) > timeoutMillis) {
1268                  threadAssertTrue(thread.isAlive());
1269                  return;
# Line 1160 | Line 1342 | public class JSR166TestCase extends Test
1342          } finally {
1343              if (t.getState() != Thread.State.TERMINATED) {
1344                  t.interrupt();
1345 <                fail("Test timed out");
1345 >                threadFail("timed out waiting for thread to terminate");
1346              }
1347          }
1348      }
# Line 1308 | Line 1490 | public class JSR166TestCase extends Test
1490              }};
1491      }
1492  
1493 <    public Runnable awaiter(final CountDownLatch latch) {
1494 <        return new CheckedRunnable() {
1495 <            public void realRun() throws InterruptedException {
1496 <                await(latch);
1497 <            }};
1493 >    class LatchAwaiter extends CheckedRunnable {
1494 >        static final int NEW = 0;
1495 >        static final int RUNNING = 1;
1496 >        static final int DONE = 2;
1497 >        final CountDownLatch latch;
1498 >        int state = NEW;
1499 >        LatchAwaiter(CountDownLatch latch) { this.latch = latch; }
1500 >        public void realRun() throws InterruptedException {
1501 >            state = 1;
1502 >            await(latch);
1503 >            state = 2;
1504 >        }
1505      }
1506  
1507 <    public void await(CountDownLatch latch) {
1507 >    public LatchAwaiter awaiter(CountDownLatch latch) {
1508 >        return new LatchAwaiter(latch);
1509 >    }
1510 >
1511 >    public void await(CountDownLatch latch, long timeoutMillis) {
1512          try {
1513 <            assertTrue(latch.await(LONG_DELAY_MS, MILLISECONDS));
1513 >            if (!latch.await(timeoutMillis, MILLISECONDS))
1514 >                fail("timed out waiting for CountDownLatch for "
1515 >                     + (timeoutMillis/1000) + " sec");
1516          } catch (Throwable fail) {
1517              threadUnexpectedException(fail);
1518          }
1519      }
1520  
1521 +    public void await(CountDownLatch latch) {
1522 +        await(latch, LONG_DELAY_MS);
1523 +    }
1524 +
1525      public void await(Semaphore semaphore) {
1526          try {
1527 <            assertTrue(semaphore.tryAcquire(LONG_DELAY_MS, MILLISECONDS));
1527 >            if (!semaphore.tryAcquire(LONG_DELAY_MS, MILLISECONDS))
1528 >                fail("timed out waiting for Semaphore for "
1529 >                     + (LONG_DELAY_MS/1000) + " sec");
1530          } catch (Throwable fail) {
1531              threadUnexpectedException(fail);
1532          }
# Line 1555 | Line 1756 | public class JSR166TestCase extends Test
1756       * A CyclicBarrier that uses timed await and fails with
1757       * AssertionFailedErrors instead of throwing checked exceptions.
1758       */
1759 <    public class CheckedBarrier extends CyclicBarrier {
1759 >    public static class CheckedBarrier extends CyclicBarrier {
1760          public CheckedBarrier(int parties) { super(parties); }
1761  
1762          public int await() {
# Line 1661 | Line 1862 | public class JSR166TestCase extends Test
1862          } catch (NoSuchElementException success) {}
1863          assertFalse(it.hasNext());
1864      }
1865 +
1866 +    public <T> Callable<T> callableThrowing(final Exception ex) {
1867 +        return new Callable<T>() { public T call() throws Exception { throw ex; }};
1868 +    }
1869 +
1870 +    public Runnable runnableThrowing(final RuntimeException ex) {
1871 +        return new Runnable() { public void run() { throw ex; }};
1872 +    }
1873 +
1874 +    /** A reusable thread pool to be shared by tests. */
1875 +    static final ExecutorService cachedThreadPool =
1876 +        new ThreadPoolExecutor(0, Integer.MAX_VALUE,
1877 +                               1000L, MILLISECONDS,
1878 +                               new SynchronousQueue<Runnable>());
1879 +
1880 +    static <T> void shuffle(T[] array) {
1881 +        Collections.shuffle(Arrays.asList(array), ThreadLocalRandom.current());
1882 +    }
1883   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines