--- jsr166/src/test/tck/JSR166TestCase.java	2015/10/05 01:10:09	1.165
+++ jsr166/src/test/tck/JSR166TestCase.java	2015/10/11 23:07:44	1.175
@@ -20,6 +20,8 @@ import java.lang.management.ThreadMXBean
 import java.lang.reflect.Constructor;
 import java.lang.reflect.Method;
 import java.lang.reflect.Modifier;
+import java.nio.file.Files;
+import java.nio.file.Paths;
 import java.security.CodeSource;
 import java.security.Permission;
 import java.security.PermissionCollection;
@@ -52,6 +54,7 @@ import java.util.concurrent.ThreadFactor
 import java.util.concurrent.ThreadPoolExecutor;
 import java.util.concurrent.TimeoutException;
 import java.util.concurrent.atomic.AtomicReference;
+import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
 import junit.framework.AssertionFailedError;
@@ -188,18 +191,29 @@ public class JSR166TestCase extends Test
         return (regex == null) ? null : Pattern.compile(regex);
     }
 
+    // Instrumentation to debug very rare, but very annoying hung test runs.
     static volatile TestCase currentTestCase;
+    // static volatile int currentRun = 0;
     static {
         Runnable checkForWedgedTest = new Runnable() { public void run() {
-            // avoid spurious reports with enormous runsPerTest
-            final int timeoutMinutes = Math.max(runsPerTest / 10, 1);
+            // Avoid spurious reports with enormous runsPerTest.
+            // A single test case run should never take more than 1 second.
+            // But let's cap it at the high end too ...
+            final int timeoutMinutes =
+                Math.min(15, Math.max(runsPerTest / 60, 1));
             for (TestCase lastTestCase = currentTestCase;;) {
                 try { MINUTES.sleep(timeoutMinutes); }
                 catch (InterruptedException unexpected) { break; }
                 if (lastTestCase == currentTestCase) {
-                    System.err.println
-                        ("Looks like we're stuck running test: "
-                         + lastTestCase);
+                    System.err.printf(
+                        "Looks like we're stuck running test: %s%n",
+                        lastTestCase);
+//                     System.err.printf(
+//                         "Looks like we're stuck running test: %s (%d/%d)%n",
+//                         lastTestCase, currentRun, runsPerTest);
+//                     System.err.println("availableProcessors=" +
+//                         Runtime.getRuntime().availableProcessors());
+//                     System.err.printf("cpu model = %s%n", cpuModel());
                     dumpTestThreads();
                     // one stack dump is probably enough; more would be spam
                     break;
@@ -211,6 +225,16 @@ public class JSR166TestCase extends Test
         thread.start();
     }
 
+//     public static String cpuModel() {
+//         try {
+//             Matcher matcher = Pattern.compile("model name\\s*: (.*)")
+//                 .matcher(new String(
+//                      Files.readAllBytes(Paths.get("/proc/cpuinfo")), "UTF-8"));
+//             matcher.find();
+//             return matcher.group(1);
+//         } catch (Exception ex) { return null; }
+//     }
+
     public void runBare() throws Throwable {
         currentTestCase = this;
         if (methodFilter == null
@@ -220,6 +244,7 @@ public class JSR166TestCase extends Test
 
     protected void runTest() throws Throwable {
         for (int i = 0; i < runsPerTest; i++) {
+            // currentRun = i;
             if (profileTests)
                 runTestProfiled();
             else
@@ -776,10 +801,43 @@ public class JSR166TestCase extends Test
         public void close() { joinPool(pool); }
     }
 
+    /**
+     * An extension of PoolCleaner that has an action to release the pool.
+     */
+    class PoolCleanerWithReleaser extends PoolCleaner {
+        private final Runnable releaser;
+        public PoolCleanerWithReleaser(ExecutorService pool, Runnable releaser) {
+            super(pool);
+            this.releaser = releaser;
+        }
+        public void close() {
+            try {
+                releaser.run();
+            } finally {
+                super.close();
+            }
+        }
+    }
+
     PoolCleaner cleaner(ExecutorService pool) {
         return new PoolCleaner(pool);
     }
 
+    PoolCleaner cleaner(ExecutorService pool, Runnable releaser) {
+        return new PoolCleanerWithReleaser(pool, releaser);
+    }
+
+    PoolCleaner cleaner(ExecutorService pool, CountDownLatch latch) {
+        return new PoolCleanerWithReleaser(pool, releaser(latch));
+    }
+
+    Runnable releaser(final CountDownLatch latch) {
+        return new Runnable() { public void run() {
+            do { latch.countDown(); }
+            while (latch.getCount() > 0);
+        }};
+    }
+
     /**
      * Waits out termination of a thread pool or fails doing so.
      */
@@ -793,7 +851,7 @@ public class JSR166TestCase extends Test
                 } finally {
                     // last resort, for the benefit of subsequent tests
                     pool.shutdownNow();
-                    pool.awaitTermination(SMALL_DELAY_MS, MILLISECONDS);
+                    pool.awaitTermination(MEDIUM_DELAY_MS, MILLISECONDS);
                 }
             }
         } catch (SecurityException ok) {
@@ -1170,7 +1228,7 @@ public class JSR166TestCase extends Test
         } finally {
             if (t.getState() != Thread.State.TERMINATED) {
                 t.interrupt();
-                fail("Test timed out");
+                threadFail("Test timed out");
             }
         }
     }