ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/JSR166TestCase.java
(Generate patch)

Comparing jsr166/src/test/tck/JSR166TestCase.java (file contents):
Revision 1.145 by jsr166, Fri Sep 25 05:41:29 2015 UTC vs.
Revision 1.173 by jsr166, Fri Oct 9 16:24:12 2015 UTC

# Line 7 | Line 7
7   */
8  
9   import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 + import static java.util.concurrent.TimeUnit.MINUTES;
11   import static java.util.concurrent.TimeUnit.NANOSECONDS;
12  
13   import java.io.ByteArrayInputStream;
# Line 15 | Line 16 | import java.io.ObjectInputStream;
16   import java.io.ObjectOutputStream;
17   import java.lang.management.ManagementFactory;
18   import java.lang.management.ThreadInfo;
19 + import java.lang.management.ThreadMXBean;
20   import java.lang.reflect.Constructor;
21   import java.lang.reflect.Method;
22   import java.lang.reflect.Modifier;
23 + import java.nio.file.Files;
24 + import java.nio.file.Paths;
25   import java.security.CodeSource;
26   import java.security.Permission;
27   import java.security.PermissionCollection;
# Line 40 | Line 44 | import java.util.concurrent.CyclicBarrie
44   import java.util.concurrent.ExecutionException;
45   import java.util.concurrent.Executors;
46   import java.util.concurrent.ExecutorService;
47 + import java.util.concurrent.ForkJoinPool;
48   import java.util.concurrent.Future;
49   import java.util.concurrent.RecursiveAction;
50   import java.util.concurrent.RecursiveTask;
# Line 49 | Line 54 | import java.util.concurrent.ThreadFactor
54   import java.util.concurrent.ThreadPoolExecutor;
55   import java.util.concurrent.TimeoutException;
56   import java.util.concurrent.atomic.AtomicReference;
57 + import java.util.regex.Matcher;
58   import java.util.regex.Pattern;
59  
60   import junit.framework.AssertionFailedError;
# Line 185 | Line 191 | public class JSR166TestCase extends Test
191          return (regex == null) ? null : Pattern.compile(regex);
192      }
193  
194 <    protected void runTest() throws Throwable {
194 >    // Instrumentation to debug very rare, but very annoying hung test runs.
195 >    static volatile TestCase currentTestCase;
196 >    // static volatile int currentRun = 0;
197 >    static {
198 >        Runnable checkForWedgedTest = new Runnable() { public void run() {
199 >            // avoid spurious reports with enormous runsPerTest
200 >            final int timeoutMinutes = Math.max(runsPerTest / 10, 1);
201 >            for (TestCase lastTestCase = currentTestCase;;) {
202 >                try { MINUTES.sleep(timeoutMinutes); }
203 >                catch (InterruptedException unexpected) { break; }
204 >                if (lastTestCase == currentTestCase) {
205 >                    System.err.printf(
206 >                        "Looks like we're stuck running test: %s%n",
207 >                        lastTestCase);
208 > //                     System.err.printf(
209 > //                         "Looks like we're stuck running test: %s (%d/%d)%n",
210 > //                         lastTestCase, currentRun, runsPerTest);
211 >                    System.err.println("availableProcessors=" +
212 >                        Runtime.getRuntime().availableProcessors());
213 >                    System.err.printf("cpu model = %s%n", cpuModel());
214 >                    dumpTestThreads();
215 >                    // one stack dump is probably enough; more would be spam
216 >                    break;
217 >                }
218 >                lastTestCase = currentTestCase;
219 >            }}};
220 >        Thread thread = new Thread(checkForWedgedTest, "checkForWedgedTest");
221 >        thread.setDaemon(true);
222 >        thread.start();
223 >    }
224 >
225 >    public static String cpuModel() {
226 >        try {
227 >            Matcher matcher = Pattern.compile("model name\\s*: (.*)")
228 >                .matcher(new String(
229 >                     Files.readAllBytes(Paths.get("/proc/cpuinfo")), "UTF-8"));
230 >            matcher.find();
231 >            return matcher.group(1);
232 >        } catch (Exception ex) { return null; }
233 >    }
234 >
235 >    public void runBare() throws Throwable {
236 >        currentTestCase = this;
237          if (methodFilter == null
238 <            || methodFilter.matcher(toString()).find()) {
239 <            for (int i = 0; i < runsPerTest; i++) {
240 <                if (profileTests)
241 <                    runTestProfiled();
242 <                else
243 <                    super.runTest();
244 <            }
238 >            || methodFilter.matcher(toString()).find())
239 >            super.runBare();
240 >    }
241 >
242 >    protected void runTest() throws Throwable {
243 >        for (int i = 0; i < runsPerTest; i++) {
244 >            // currentRun = i;
245 >            if (profileTests)
246 >                runTestProfiled();
247 >            else
248 >                super.runTest();
249          }
250      }
251  
# Line 456 | Line 508 | public class JSR166TestCase extends Test
508          } else {
509              return new TestSuite();
510          }
459
511      }
512  
513      // Delays for timing-dependent tests, in milliseconds.
# Line 514 | Line 565 | public class JSR166TestCase extends Test
565       * the same test have no effect.
566       */
567      public void threadRecordFailure(Throwable t) {
568 +        System.err.println(t);
569 +        dumpTestThreads();
570          threadFailure.compareAndSet(null, t);
571      }
572  
# Line 521 | Line 574 | public class JSR166TestCase extends Test
574          setDelays();
575      }
576  
577 +    void tearDownFail(String format, Object... args) {
578 +        String msg = toString() + ": " + String.format(format, args);
579 +        System.err.println(msg);
580 +        dumpTestThreads();
581 +        throw new AssertionFailedError(msg);
582 +    }
583 +
584      /**
585       * Extra checks that get done for all test cases.
586       *
# Line 548 | Line 608 | public class JSR166TestCase extends Test
608          }
609  
610          if (Thread.interrupted())
611 <            throw new AssertionFailedError("interrupt status set in main thread");
611 >            tearDownFail("interrupt status set in main thread");
612  
613          checkForkJoinPoolThreadLeaks();
614      }
615  
616      /**
617 <     * Finds missing try { ... } finally { joinPool(e); }
617 >     * Finds missing PoolCleaners
618       */
619      void checkForkJoinPoolThreadLeaks() throws InterruptedException {
620 <        Thread[] survivors = new Thread[5];
620 >        Thread[] survivors = new Thread[7];
621          int count = Thread.enumerate(survivors);
622          for (int i = 0; i < count; i++) {
623              Thread thread = survivors[i];
# Line 565 | Line 625 | public class JSR166TestCase extends Test
625              if (name.startsWith("ForkJoinPool-")) {
626                  // give thread some time to terminate
627                  thread.join(LONG_DELAY_MS);
628 <                if (!thread.isAlive()) continue;
629 <                throw new AssertionFailedError
630 <                    (String.format("Found leaked ForkJoinPool thread test=%s thread=%s%n",
571 <                                   toString(), name));
628 >                if (thread.isAlive())
629 >                    tearDownFail("Found leaked ForkJoinPool thread thread=%s",
630 >                                 thread);
631              }
632          }
633 +
634 +        if (!ForkJoinPool.commonPool()
635 +            .awaitQuiescence(LONG_DELAY_MS, MILLISECONDS))
636 +            tearDownFail("ForkJoin common pool thread stuck");
637      }
638  
639      /**
# Line 583 | Line 646 | public class JSR166TestCase extends Test
646              fail(reason);
647          } catch (AssertionFailedError t) {
648              threadRecordFailure(t);
649 <            fail(reason);
649 >            throw t;
650          }
651      }
652  
# Line 710 | Line 773 | public class JSR166TestCase extends Test
773      /**
774       * Delays, via Thread.sleep, for the given millisecond delay, but
775       * if the sleep is shorter than specified, may re-sleep or yield
776 <     * until time elapses.
776 >     * until time elapses.  Ensures that the given time, as measured
777 >     * by System.nanoTime(), has elapsed.
778       */
779      static void delay(long millis) throws InterruptedException {
780 <        long startTime = System.nanoTime();
781 <        long ns = millis * 1000 * 1000;
782 <        for (;;) {
780 >        long nanos = millis * (1000 * 1000);
781 >        final long wakeupTime = System.nanoTime() + nanos;
782 >        do {
783              if (millis > 0L)
784                  Thread.sleep(millis);
785              else // too short to sleep
786                  Thread.yield();
787 <            long d = ns - (System.nanoTime() - startTime);
788 <            if (d > 0L)
789 <                millis = d / (1000 * 1000);
790 <            else
791 <                break;
787 >            nanos = wakeupTime - System.nanoTime();
788 >            millis = nanos / (1000 * 1000);
789 >        } while (nanos >= 0L);
790 >    }
791 >
792 >    /**
793 >     * Allows use of try-with-resources with per-test thread pools.
794 >     */
795 >    class PoolCleaner implements AutoCloseable {
796 >        private final ExecutorService pool;
797 >        public PoolCleaner(ExecutorService pool) { this.pool = pool; }
798 >        public void close() { joinPool(pool); }
799 >    }
800 >
801 >    /**
802 >     * An extension of PoolCleaner that has an action to release the pool.
803 >     */
804 >    class PoolCleanerWithReleaser extends PoolCleaner {
805 >        private final Runnable releaser;
806 >        public PoolCleanerWithReleaser(ExecutorService pool, Runnable releaser) {
807 >            super(pool);
808 >            this.releaser = releaser;
809 >        }
810 >        public void close() {
811 >            try {
812 >                releaser.run();
813 >            } finally {
814 >                super.close();
815 >            }
816          }
817      }
818  
819 +    PoolCleaner cleaner(ExecutorService pool) {
820 +        return new PoolCleaner(pool);
821 +    }
822 +
823 +    PoolCleaner cleaner(ExecutorService pool, Runnable releaser) {
824 +        return new PoolCleanerWithReleaser(pool, releaser);
825 +    }
826 +
827 +    PoolCleaner cleaner(ExecutorService pool, CountDownLatch latch) {
828 +        return new PoolCleanerWithReleaser(pool, releaser(latch));
829 +    }
830 +
831 +    Runnable releaser(final CountDownLatch latch) {
832 +        return new Runnable() { public void run() {
833 +            do { latch.countDown(); }
834 +            while (latch.getCount() > 0);
835 +        }};
836 +    }
837 +
838      /**
839       * Waits out termination of a thread pool or fails doing so.
840       */
841      void joinPool(ExecutorService pool) {
842          try {
843              pool.shutdown();
844 <            if (!pool.awaitTermination(2 * LONG_DELAY_MS, MILLISECONDS))
845 <                fail("ExecutorService " + pool +
846 <                     " did not terminate in a timely manner");
844 >            if (!pool.awaitTermination(2 * LONG_DELAY_MS, MILLISECONDS)) {
845 >                try {
846 >                    threadFail("ExecutorService " + pool +
847 >                               " did not terminate in a timely manner");
848 >                } finally {
849 >                    // last resort, for the benefit of subsequent tests
850 >                    pool.shutdownNow();
851 >                    pool.awaitTermination(MEDIUM_DELAY_MS, MILLISECONDS);
852 >                }
853 >            }
854          } catch (SecurityException ok) {
855              // Allowed in case test doesn't have privs
856          } catch (InterruptedException fail) {
857 <            fail("Unexpected InterruptedException");
857 >            threadFail("Unexpected InterruptedException");
858          }
859      }
860  
# Line 754 | Line 868 | public class JSR166TestCase extends Test
868       */
869      void testInParallel(Action ... actions) {
870          ExecutorService pool = Executors.newCachedThreadPool();
871 <        try {
871 >        try (PoolCleaner cleaner = cleaner(pool)) {
872              ArrayList<Future<?>> futures = new ArrayList<>(actions.length);
873              for (final Action action : actions)
874                  futures.add(pool.submit(new CheckedRunnable() {
# Line 767 | Line 881 | public class JSR166TestCase extends Test
881                  } catch (Exception ex) {
882                      threadUnexpectedException(ex);
883                  }
770        } finally {
771            joinPool(pool);
884          }
885      }
886  
887      /**
888 <     * A debugging tool to print all stack traces, as jstack does.
888 >     * A debugging tool to print stack traces of most threads, as jstack does.
889 >     * Uninteresting threads are filtered out.
890       */
891 <    static void printAllStackTraces() {
892 <        for (ThreadInfo info :
893 <                 ManagementFactory.getThreadMXBean()
894 <                 .dumpAllThreads(true, true))
891 >    static void dumpTestThreads() {
892 >        ThreadMXBean threadMXBean = ManagementFactory.getThreadMXBean();
893 >        System.err.println("------ stacktrace dump start ------");
894 >        for (ThreadInfo info : threadMXBean.dumpAllThreads(true, true)) {
895 >            String name = info.getThreadName();
896 >            if ("Signal Dispatcher".equals(name))
897 >                continue;
898 >            if ("Reference Handler".equals(name)
899 >                && info.getLockName().startsWith("java.lang.ref.Reference$Lock"))
900 >                continue;
901 >            if ("Finalizer".equals(name)
902 >                && info.getLockName().startsWith("java.lang.ref.ReferenceQueue$Lock"))
903 >                continue;
904 >            if ("checkForWedgedTest".equals(name))
905 >                continue;
906              System.err.print(info);
907 +        }
908 +        System.err.println("------ stacktrace dump end ------");
909      }
910  
911      /**
# Line 799 | Line 925 | public class JSR166TestCase extends Test
925              delay(millis);
926              assertTrue(thread.isAlive());
927          } catch (InterruptedException fail) {
928 <            fail("Unexpected InterruptedException");
928 >            threadFail("Unexpected InterruptedException");
929          }
930      }
931  
# Line 821 | Line 947 | public class JSR166TestCase extends Test
947              for (Thread thread : threads)
948                  assertTrue(thread.isAlive());
949          } catch (InterruptedException fail) {
950 <            fail("Unexpected InterruptedException");
950 >            threadFail("Unexpected InterruptedException");
951          }
952      }
953  
# Line 1099 | Line 1225 | public class JSR166TestCase extends Test
1225          } finally {
1226              if (t.getState() != Thread.State.TERMINATED) {
1227                  t.interrupt();
1228 <                fail("Test timed out");
1228 >                threadFail("Test timed out");
1229              }
1230          }
1231      }
# Line 1240 | Line 1366 | public class JSR166TestCase extends Test
1366              }};
1367      }
1368  
1369 <    public Runnable awaiter(final CountDownLatch latch) {
1369 >    public Runnable countDowner(final CountDownLatch latch) {
1370          return new CheckedRunnable() {
1371              public void realRun() throws InterruptedException {
1372 <                await(latch);
1372 >                latch.countDown();
1373              }};
1374      }
1375  
1376 +    class LatchAwaiter extends CheckedRunnable {
1377 +        static final int NEW = 0;
1378 +        static final int RUNNING = 1;
1379 +        static final int DONE = 2;
1380 +        final CountDownLatch latch;
1381 +        int state = NEW;
1382 +        LatchAwaiter(CountDownLatch latch) { this.latch = latch; }
1383 +        public void realRun() throws InterruptedException {
1384 +            state = 1;
1385 +            await(latch);
1386 +            state = 2;
1387 +        }
1388 +    }
1389 +
1390 +    public LatchAwaiter awaiter(CountDownLatch latch) {
1391 +        return new LatchAwaiter(latch);
1392 +    }
1393 +
1394      public void await(CountDownLatch latch) {
1395          try {
1396              assertTrue(latch.await(LONG_DELAY_MS, MILLISECONDS));

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines