ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/JSR166TestCase.java
(Generate patch)

Comparing jsr166/src/test/tck/JSR166TestCase.java (file contents):
Revision 1.179 by jsr166, Fri Oct 23 21:59:58 2015 UTC vs.
Revision 1.257 by jsr166, Wed Aug 14 23:06:11 2019 UTC

# Line 1 | Line 1
1   /*
2 < * Written by Doug Lea with assistance from members of JCP JSR-166
3 < * Expert Group and released to the public domain, as explained at
2 > * Written by Doug Lea and Martin Buchholz with assistance from
3 > * members of JCP JSR-166 Expert Group and released to the public
4 > * domain, as explained at
5   * http://creativecommons.org/publicdomain/zero/1.0/
6   * Other contributors include Andrew Wright, Jeffrey Hayes,
7   * Pat Fisher, Mike Judd.
8   */
9  
10 + /*
11 + * @test
12 + * @summary JSR-166 tck tests, in a number of variations.
13 + *          The first is the conformance testing variant,
14 + *          while others also test implementation details.
15 + * @build *
16 + * @modules java.management
17 + * @run junit/othervm/timeout=1000 JSR166TestCase
18 + * @run junit/othervm/timeout=1000
19 + *      --add-opens java.base/java.util.concurrent=ALL-UNNAMED
20 + *      --add-opens java.base/java.lang=ALL-UNNAMED
21 + *      -Djsr166.testImplementationDetails=true
22 + *      JSR166TestCase
23 + * @run junit/othervm/timeout=1000
24 + *      --add-opens java.base/java.util.concurrent=ALL-UNNAMED
25 + *      --add-opens java.base/java.lang=ALL-UNNAMED
26 + *      -Djsr166.testImplementationDetails=true
27 + *      -Djava.util.concurrent.ForkJoinPool.common.parallelism=0
28 + *      JSR166TestCase
29 + * @run junit/othervm/timeout=1000
30 + *      --add-opens java.base/java.util.concurrent=ALL-UNNAMED
31 + *      --add-opens java.base/java.lang=ALL-UNNAMED
32 + *      -Djsr166.testImplementationDetails=true
33 + *      -Djava.util.concurrent.ForkJoinPool.common.parallelism=1
34 + *      -Djava.util.secureRandomSeed=true
35 + *      JSR166TestCase
36 + * @run junit/othervm/timeout=1000/policy=tck.policy
37 + *      --add-opens java.base/java.util.concurrent=ALL-UNNAMED
38 + *      --add-opens java.base/java.lang=ALL-UNNAMED
39 + *      -Djsr166.testImplementationDetails=true
40 + *      JSR166TestCase
41 + */
42 +
43   import static java.util.concurrent.TimeUnit.MILLISECONDS;
44   import static java.util.concurrent.TimeUnit.MINUTES;
45   import static java.util.concurrent.TimeUnit.NANOSECONDS;
# Line 20 | Line 54 | import java.lang.management.ThreadMXBean
54   import java.lang.reflect.Constructor;
55   import java.lang.reflect.Method;
56   import java.lang.reflect.Modifier;
23 import java.nio.file.Files;
24 import java.nio.file.Paths;
57   import java.security.CodeSource;
58   import java.security.Permission;
59   import java.security.PermissionCollection;
# Line 31 | Line 63 | import java.security.ProtectionDomain;
63   import java.security.SecurityPermission;
64   import java.util.ArrayList;
65   import java.util.Arrays;
66 + import java.util.Collection;
67 + import java.util.Collections;
68   import java.util.Date;
69 + import java.util.Deque;
70   import java.util.Enumeration;
71 + import java.util.HashSet;
72   import java.util.Iterator;
73   import java.util.List;
74   import java.util.NoSuchElementException;
75   import java.util.PropertyPermission;
76 + import java.util.Set;
77   import java.util.concurrent.BlockingQueue;
78   import java.util.concurrent.Callable;
79   import java.util.concurrent.CountDownLatch;
80   import java.util.concurrent.CyclicBarrier;
81   import java.util.concurrent.ExecutionException;
82 + import java.util.concurrent.Executor;
83   import java.util.concurrent.Executors;
84   import java.util.concurrent.ExecutorService;
85   import java.util.concurrent.ForkJoinPool;
86   import java.util.concurrent.Future;
87 + import java.util.concurrent.FutureTask;
88   import java.util.concurrent.RecursiveAction;
89   import java.util.concurrent.RecursiveTask;
90 + import java.util.concurrent.RejectedExecutionException;
91   import java.util.concurrent.RejectedExecutionHandler;
92   import java.util.concurrent.Semaphore;
93 + import java.util.concurrent.ScheduledExecutorService;
94 + import java.util.concurrent.ScheduledFuture;
95 + import java.util.concurrent.SynchronousQueue;
96   import java.util.concurrent.ThreadFactory;
97 + import java.util.concurrent.ThreadLocalRandom;
98   import java.util.concurrent.ThreadPoolExecutor;
99 + import java.util.concurrent.TimeUnit;
100   import java.util.concurrent.TimeoutException;
101 + import java.util.concurrent.atomic.AtomicBoolean;
102   import java.util.concurrent.atomic.AtomicReference;
57 import java.util.regex.Matcher;
103   import java.util.regex.Pattern;
104  
60 import junit.framework.AssertionFailedError;
105   import junit.framework.Test;
106   import junit.framework.TestCase;
107   import junit.framework.TestResult;
# Line 73 | Line 117 | import junit.framework.TestSuite;
117   *
118   * <ol>
119   *
120 < * <li>All assertions in code running in generated threads must use
121 < * the forms {@link #threadFail}, {@link #threadAssertTrue}, {@link
122 < * #threadAssertEquals}, or {@link #threadAssertNull}, (not
123 < * {@code fail}, {@code assertTrue}, etc.) It is OK (but not
124 < * particularly recommended) for other code to use these forms too.
125 < * Only the most typically used JUnit assertion methods are defined
126 < * this way, but enough to live with.
120 > * <li>All code not running in the main test thread (manually spawned threads
121 > * or the common fork join pool) must be checked for failure (and completion!).
122 > * Mechanisms that can be used to ensure this are:
123 > *   <ol>
124 > *   <li>Signalling via a synchronizer like AtomicInteger or CountDownLatch
125 > *    that the task completed normally, which is checked before returning from
126 > *    the test method in the main thread.
127 > *   <li>Using the forms {@link #threadFail}, {@link #threadAssertTrue},
128 > *    or {@link #threadAssertNull}, (not {@code fail}, {@code assertTrue}, etc.)
129 > *    Only the most typically used JUnit assertion methods are defined
130 > *    this way, but enough to live with.
131 > *   <li>Recording failure explicitly using {@link #threadUnexpectedException}
132 > *    or {@link #threadRecordFailure}.
133 > *   <li>Using a wrapper like CheckedRunnable that uses one the mechanisms above.
134 > *   </ol>
135   *
136   * <li>If you override {@link #setUp} or {@link #tearDown}, make sure
137   * to invoke {@code super.setUp} and {@code super.tearDown} within
# Line 112 | Line 164 | import junit.framework.TestSuite;
164   * methods as there are exceptions the method can throw. Sometimes
165   * there are multiple tests per JSR166 method when the different
166   * "normal" behaviors differ significantly. And sometimes testcases
167 < * cover multiple methods when they cannot be tested in
116 < * isolation.
167 > * cover multiple methods when they cannot be tested in isolation.
168   *
169   * <li>The documentation style for testcases is to provide as javadoc
170   * a simple sentence or two describing the property that the testcase
# Line 176 | Line 227 | public class JSR166TestCase extends Test
227      private static final int suiteRuns =
228          Integer.getInteger("jsr166.suiteRuns", 1);
229  
230 +    /**
231 +     * Returns the value of the system property, or NaN if not defined.
232 +     */
233 +    private static float systemPropertyValue(String name) {
234 +        String floatString = System.getProperty(name);
235 +        if (floatString == null)
236 +            return Float.NaN;
237 +        try {
238 +            return Float.parseFloat(floatString);
239 +        } catch (NumberFormatException ex) {
240 +            throw new IllegalArgumentException(
241 +                String.format("Bad float value in system property %s=%s",
242 +                              name, floatString));
243 +        }
244 +    }
245 +
246 +    /**
247 +     * The scaling factor to apply to standard delays used in tests.
248 +     * May be initialized from any of:
249 +     * - the "jsr166.delay.factor" system property
250 +     * - the "test.timeout.factor" system property (as used by jtreg)
251 +     *   See: http://openjdk.java.net/jtreg/tag-spec.html
252 +     * - hard-coded fuzz factor when using a known slowpoke VM
253 +     */
254 +    private static final float delayFactor = delayFactor();
255 +
256 +    private static float delayFactor() {
257 +        float x;
258 +        if (!Float.isNaN(x = systemPropertyValue("jsr166.delay.factor")))
259 +            return x;
260 +        if (!Float.isNaN(x = systemPropertyValue("test.timeout.factor")))
261 +            return x;
262 +        String prop = System.getProperty("java.vm.version");
263 +        if (prop != null && prop.matches(".*debug.*"))
264 +            return 4.0f; // How much slower is fastdebug than product?!
265 +        return 1.0f;
266 +    }
267 +
268      public JSR166TestCase() { super(); }
269      public JSR166TestCase(String name) { super(name); }
270  
# Line 199 | Line 288 | public class JSR166TestCase extends Test
288              // Avoid spurious reports with enormous runsPerTest.
289              // A single test case run should never take more than 1 second.
290              // But let's cap it at the high end too ...
291 <            final int timeoutMinutes =
292 <                Math.min(15, Math.max(runsPerTest / 60, 1));
291 >            final int timeoutMinutesMin = Math.max(runsPerTest / 60, 1)
292 >                * Math.max((int) delayFactor, 1);
293 >            final int timeoutMinutes = Math.min(15, timeoutMinutesMin);
294              for (TestCase lastTestCase = currentTestCase;;) {
295                  try { MINUTES.sleep(timeoutMinutes); }
296                  catch (InterruptedException unexpected) { break; }
# Line 227 | Line 317 | public class JSR166TestCase extends Test
317  
318   //     public static String cpuModel() {
319   //         try {
320 < //             Matcher matcher = Pattern.compile("model name\\s*: (.*)")
320 > //             java.util.regex.Matcher matcher
321 > //               = Pattern.compile("model name\\s*: (.*)")
322   //                 .matcher(new String(
323 < //                      Files.readAllBytes(Paths.get("/proc/cpuinfo")), "UTF-8"));
323 > //                     java.nio.file.Files.readAllBytes(
324 > //                         java.nio.file.Paths.get("/proc/cpuinfo")), "UTF-8"));
325   //             matcher.find();
326   //             return matcher.group(1);
327   //         } catch (Exception ex) { return null; }
# Line 338 | Line 430 | public class JSR166TestCase extends Test
430          for (String testClassName : testClassNames) {
431              try {
432                  Class<?> testClass = Class.forName(testClassName);
433 <                Method m = testClass.getDeclaredMethod("suite",
342 <                                                       new Class<?>[0]);
433 >                Method m = testClass.getDeclaredMethod("suite");
434                  suite.addTest(newTestSuite((Test)m.invoke(null)));
435 <            } catch (Exception e) {
436 <                throw new Error("Missing test class", e);
435 >            } catch (ReflectiveOperationException e) {
436 >                throw new AssertionError("Missing test class", e);
437              }
438          }
439      }
# Line 364 | Line 455 | public class JSR166TestCase extends Test
455          }
456      }
457  
458 <    public static boolean atLeastJava6() { return JAVA_CLASS_VERSION >= 50.0; }
459 <    public static boolean atLeastJava7() { return JAVA_CLASS_VERSION >= 51.0; }
460 <    public static boolean atLeastJava8() { return JAVA_CLASS_VERSION >= 52.0; }
461 <    public static boolean atLeastJava9() {
462 <        return JAVA_CLASS_VERSION >= 53.0
463 <            // As of 2015-09, java9 still uses 52.0 class file version
464 <            || JAVA_SPECIFICATION_VERSION.matches("^(1\\.)?(9|[0-9][0-9])$");
465 <    }
466 <    public static boolean atLeastJava10() {
467 <        return JAVA_CLASS_VERSION >= 54.0
468 <            || JAVA_SPECIFICATION_VERSION.matches("^(1\\.)?[0-9][0-9]$");
469 <    }
458 >    public static boolean atLeastJava6()  { return JAVA_CLASS_VERSION >= 50.0; }
459 >    public static boolean atLeastJava7()  { return JAVA_CLASS_VERSION >= 51.0; }
460 >    public static boolean atLeastJava8()  { return JAVA_CLASS_VERSION >= 52.0; }
461 >    public static boolean atLeastJava9()  { return JAVA_CLASS_VERSION >= 53.0; }
462 >    public static boolean atLeastJava10() { return JAVA_CLASS_VERSION >= 54.0; }
463 >    public static boolean atLeastJava11() { return JAVA_CLASS_VERSION >= 55.0; }
464 >    public static boolean atLeastJava12() { return JAVA_CLASS_VERSION >= 56.0; }
465 >    public static boolean atLeastJava13() { return JAVA_CLASS_VERSION >= 57.0; }
466 >    public static boolean atLeastJava14() { return JAVA_CLASS_VERSION >= 58.0; }
467 >    public static boolean atLeastJava15() { return JAVA_CLASS_VERSION >= 59.0; }
468 >    public static boolean atLeastJava16() { return JAVA_CLASS_VERSION >= 60.0; }
469 >    public static boolean atLeastJava17() { return JAVA_CLASS_VERSION >= 61.0; }
470  
471      /**
472       * Collects all JSR166 unit tests as one suite.
# Line 396 | Line 487 | public class JSR166TestCase extends Test
487              AbstractQueuedLongSynchronizerTest.suite(),
488              ArrayBlockingQueueTest.suite(),
489              ArrayDequeTest.suite(),
490 +            ArrayListTest.suite(),
491              AtomicBooleanTest.suite(),
492              AtomicIntegerArrayTest.suite(),
493              AtomicIntegerFieldUpdaterTest.suite(),
# Line 418 | Line 510 | public class JSR166TestCase extends Test
510              CopyOnWriteArrayListTest.suite(),
511              CopyOnWriteArraySetTest.suite(),
512              CountDownLatchTest.suite(),
513 +            CountedCompleterTest.suite(),
514              CyclicBarrierTest.suite(),
515              DelayQueueTest.suite(),
516              EntryTest.suite(),
# Line 425 | Line 518 | public class JSR166TestCase extends Test
518              ExecutorsTest.suite(),
519              ExecutorCompletionServiceTest.suite(),
520              FutureTaskTest.suite(),
521 +            HashtableTest.suite(),
522              LinkedBlockingDequeTest.suite(),
523              LinkedBlockingQueueTest.suite(),
524              LinkedListTest.suite(),
# Line 446 | Line 540 | public class JSR166TestCase extends Test
540              TreeMapTest.suite(),
541              TreeSetTest.suite(),
542              TreeSubMapTest.suite(),
543 <            TreeSubSetTest.suite());
543 >            TreeSubSetTest.suite(),
544 >            VectorTest.suite());
545  
546          // Java8+ test classes
547          if (atLeastJava8()) {
548              String[] java8TestClassNames = {
549 +                "ArrayDeque8Test",
550                  "Atomic8Test",
551                  "CompletableFutureTest",
552                  "ConcurrentHashMap8Test",
553 <                "CountedCompleterTest",
553 >                "CountedCompleter8Test",
554                  "DoubleAccumulatorTest",
555                  "DoubleAdderTest",
556                  "ForkJoinPool8Test",
557                  "ForkJoinTask8Test",
558 +                "HashMapTest",
559 +                "LinkedBlockingDeque8Test",
560 +                "LinkedBlockingQueue8Test",
561 +                "LinkedHashMapTest",
562                  "LongAccumulatorTest",
563                  "LongAdderTest",
564                  "SplittableRandomTest",
565                  "StampedLockTest",
566                  "SubmissionPublisherTest",
567                  "ThreadLocalRandom8Test",
568 +                "TimeUnit8Test",
569              };
570              addNamedTestClasses(suite, java8TestClassNames);
571          }
# Line 472 | Line 573 | public class JSR166TestCase extends Test
573          // Java9+ test classes
574          if (atLeastJava9()) {
575              String[] java9TestClassNames = {
576 <                // Currently empty, but expecting varhandle tests
576 >                "AtomicBoolean9Test",
577 >                "AtomicInteger9Test",
578 >                "AtomicIntegerArray9Test",
579 >                "AtomicLong9Test",
580 >                "AtomicLongArray9Test",
581 >                "AtomicReference9Test",
582 >                "AtomicReferenceArray9Test",
583 >                "ExecutorCompletionService9Test",
584 >                "ForkJoinPool9Test",
585              };
586              addNamedTestClasses(suite, java9TestClassNames);
587          }
# Line 483 | Line 592 | public class JSR166TestCase extends Test
592      /** Returns list of junit-style test method names in given class. */
593      public static ArrayList<String> testMethodNames(Class<?> testClass) {
594          Method[] methods = testClass.getDeclaredMethods();
595 <        ArrayList<String> names = new ArrayList<String>(methods.length);
595 >        ArrayList<String> names = new ArrayList<>(methods.length);
596          for (Method method : methods) {
597              if (method.getName().startsWith("test")
598                  && Modifier.isPublic(method.getModifiers())
# Line 510 | Line 619 | public class JSR166TestCase extends Test
619              for (String methodName : testMethodNames(testClass))
620                  suite.addTest((Test) c.newInstance(data, methodName));
621              return suite;
622 <        } catch (Exception e) {
623 <            throw new Error(e);
622 >        } catch (ReflectiveOperationException e) {
623 >            throw new AssertionError(e);
624          }
625      }
626  
# Line 527 | Line 636 | public class JSR166TestCase extends Test
636          if (atLeastJava8()) {
637              String name = testClass.getName();
638              String name8 = name.replaceAll("Test$", "8Test");
639 <            if (name.equals(name8)) throw new Error(name);
639 >            if (name.equals(name8)) throw new AssertionError(name);
640              try {
641                  return (Test)
642                      Class.forName(name8)
643 <                    .getMethod("testSuite", new Class[] { dataClass })
643 >                    .getMethod("testSuite", dataClass)
644                      .invoke(null, data);
645 <            } catch (Exception e) {
646 <                throw new Error(e);
645 >            } catch (ReflectiveOperationException e) {
646 >                throw new AssertionError(e);
647              }
648          } else {
649              return new TestSuite();
# Line 548 | Line 657 | public class JSR166TestCase extends Test
657      public static long MEDIUM_DELAY_MS;
658      public static long LONG_DELAY_MS;
659  
660 +    private static final long RANDOM_TIMEOUT;
661 +    private static final long RANDOM_EXPIRED_TIMEOUT;
662 +    private static final TimeUnit RANDOM_TIMEUNIT;
663 +    static {
664 +        ThreadLocalRandom rnd = ThreadLocalRandom.current();
665 +        long[] timeouts = { Long.MIN_VALUE, -1, 0, 1, Long.MAX_VALUE };
666 +        RANDOM_TIMEOUT = timeouts[rnd.nextInt(timeouts.length)];
667 +        RANDOM_EXPIRED_TIMEOUT = timeouts[rnd.nextInt(3)];
668 +        TimeUnit[] timeUnits = TimeUnit.values();
669 +        RANDOM_TIMEUNIT = timeUnits[rnd.nextInt(timeUnits.length)];
670 +    }
671 +
672 +    /**
673 +     * Returns a timeout for use when any value at all will do.
674 +     */
675 +    static long randomTimeout() { return RANDOM_TIMEOUT; }
676 +
677 +    /**
678 +     * Returns a timeout that means "no waiting", i.e. not positive.
679 +     */
680 +    static long randomExpiredTimeout() { return RANDOM_EXPIRED_TIMEOUT; }
681 +
682 +    /**
683 +     * Returns a random non-null TimeUnit.
684 +     */
685 +    static TimeUnit randomTimeUnit() { return RANDOM_TIMEUNIT; }
686 +
687      /**
688 <     * Returns the shortest timed delay. This could
689 <     * be reimplemented to use for example a Property.
688 >     * Returns a random boolean; a "coin flip".
689 >     */
690 >    static boolean randomBoolean() {
691 >        return ThreadLocalRandom.current().nextBoolean();
692 >    }
693 >
694 >    /**
695 >     * Returns a random element from given choices.
696 >     */
697 >    <T> T chooseRandomly(T... choices) {
698 >        return choices[ThreadLocalRandom.current().nextInt(choices.length)];
699 >    }
700 >
701 >    /**
702 >     * Returns the shortest timed delay. This can be scaled up for
703 >     * slow machines using the jsr166.delay.factor system property,
704 >     * or via jtreg's -timeoutFactor: flag.
705 >     * http://openjdk.java.net/jtreg/command-help.html
706       */
707      protected long getShortDelay() {
708 <        return 50;
708 >        return (long) (50 * delayFactor);
709      }
710  
711      /**
# Line 566 | Line 718 | public class JSR166TestCase extends Test
718          LONG_DELAY_MS   = SHORT_DELAY_MS * 200;
719      }
720  
721 +    private static final long TIMEOUT_DELAY_MS
722 +        = (long) (12.0 * Math.cbrt(delayFactor));
723 +
724      /**
725 <     * Returns a timeout in milliseconds to be used in tests that
726 <     * verify that operations block or time out.
725 >     * Returns a timeout in milliseconds to be used in tests that verify
726 >     * that operations block or time out.  We want this to be longer
727 >     * than the OS scheduling quantum, but not too long, so don't scale
728 >     * linearly with delayFactor; we use "crazy" cube root instead.
729       */
730 <    long timeoutMillis() {
731 <        return SHORT_DELAY_MS / 4;
730 >    static long timeoutMillis() {
731 >        return TIMEOUT_DELAY_MS;
732      }
733  
734      /**
# Line 587 | Line 744 | public class JSR166TestCase extends Test
744       * The first exception encountered if any threadAssertXXX method fails.
745       */
746      private final AtomicReference<Throwable> threadFailure
747 <        = new AtomicReference<Throwable>(null);
747 >        = new AtomicReference<>(null);
748  
749      /**
750       * Records an exception so that it can be rethrown later in the test
# Line 609 | Line 766 | public class JSR166TestCase extends Test
766          String msg = toString() + ": " + String.format(format, args);
767          System.err.println(msg);
768          dumpTestThreads();
769 <        throw new AssertionFailedError(msg);
769 >        throw new AssertionError(msg);
770      }
771  
772      /**
# Line 630 | Line 787 | public class JSR166TestCase extends Test
787                  throw (RuntimeException) t;
788              else if (t instanceof Exception)
789                  throw (Exception) t;
790 <            else {
791 <                AssertionFailedError afe =
635 <                    new AssertionFailedError(t.toString());
636 <                afe.initCause(t);
637 <                throw afe;
638 <            }
790 >            else
791 >                throw new AssertionError(t.toString(), t);
792          }
793  
794          if (Thread.interrupted())
# Line 669 | Line 822 | public class JSR166TestCase extends Test
822  
823      /**
824       * Just like fail(reason), but additionally recording (using
825 <     * threadRecordFailure) any AssertionFailedError thrown, so that
826 <     * the current testcase will fail.
825 >     * threadRecordFailure) any AssertionError thrown, so that the
826 >     * current testcase will fail.
827       */
828      public void threadFail(String reason) {
829          try {
830              fail(reason);
831 <        } catch (AssertionFailedError t) {
832 <            threadRecordFailure(t);
833 <            throw t;
831 >        } catch (AssertionError fail) {
832 >            threadRecordFailure(fail);
833 >            throw fail;
834          }
835      }
836  
837      /**
838       * Just like assertTrue(b), but additionally recording (using
839 <     * threadRecordFailure) any AssertionFailedError thrown, so that
840 <     * the current testcase will fail.
839 >     * threadRecordFailure) any AssertionError thrown, so that the
840 >     * current testcase will fail.
841       */
842      public void threadAssertTrue(boolean b) {
843          try {
844              assertTrue(b);
845 <        } catch (AssertionFailedError t) {
846 <            threadRecordFailure(t);
847 <            throw t;
845 >        } catch (AssertionError fail) {
846 >            threadRecordFailure(fail);
847 >            throw fail;
848          }
849      }
850  
851      /**
852       * Just like assertFalse(b), but additionally recording (using
853 <     * threadRecordFailure) any AssertionFailedError thrown, so that
854 <     * the current testcase will fail.
853 >     * threadRecordFailure) any AssertionError thrown, so that the
854 >     * current testcase will fail.
855       */
856      public void threadAssertFalse(boolean b) {
857          try {
858              assertFalse(b);
859 <        } catch (AssertionFailedError t) {
860 <            threadRecordFailure(t);
861 <            throw t;
859 >        } catch (AssertionError fail) {
860 >            threadRecordFailure(fail);
861 >            throw fail;
862          }
863      }
864  
865      /**
866       * Just like assertNull(x), but additionally recording (using
867 <     * threadRecordFailure) any AssertionFailedError thrown, so that
868 <     * the current testcase will fail.
867 >     * threadRecordFailure) any AssertionError thrown, so that the
868 >     * current testcase will fail.
869       */
870      public void threadAssertNull(Object x) {
871          try {
872              assertNull(x);
873 <        } catch (AssertionFailedError t) {
874 <            threadRecordFailure(t);
875 <            throw t;
873 >        } catch (AssertionError fail) {
874 >            threadRecordFailure(fail);
875 >            throw fail;
876          }
877      }
878  
879      /**
880       * Just like assertEquals(x, y), but additionally recording (using
881 <     * threadRecordFailure) any AssertionFailedError thrown, so that
882 <     * the current testcase will fail.
881 >     * threadRecordFailure) any AssertionError thrown, so that the
882 >     * current testcase will fail.
883       */
884      public void threadAssertEquals(long x, long y) {
885          try {
886              assertEquals(x, y);
887 <        } catch (AssertionFailedError t) {
888 <            threadRecordFailure(t);
889 <            throw t;
887 >        } catch (AssertionError fail) {
888 >            threadRecordFailure(fail);
889 >            throw fail;
890          }
891      }
892  
893      /**
894       * Just like assertEquals(x, y), but additionally recording (using
895 <     * threadRecordFailure) any AssertionFailedError thrown, so that
896 <     * the current testcase will fail.
895 >     * threadRecordFailure) any AssertionError thrown, so that the
896 >     * current testcase will fail.
897       */
898      public void threadAssertEquals(Object x, Object y) {
899          try {
900              assertEquals(x, y);
901 <        } catch (AssertionFailedError fail) {
901 >        } catch (AssertionError fail) {
902              threadRecordFailure(fail);
903              throw fail;
904          } catch (Throwable fail) {
# Line 755 | Line 908 | public class JSR166TestCase extends Test
908  
909      /**
910       * Just like assertSame(x, y), but additionally recording (using
911 <     * threadRecordFailure) any AssertionFailedError thrown, so that
912 <     * the current testcase will fail.
911 >     * threadRecordFailure) any AssertionError thrown, so that the
912 >     * current testcase will fail.
913       */
914      public void threadAssertSame(Object x, Object y) {
915          try {
916              assertSame(x, y);
917 <        } catch (AssertionFailedError fail) {
917 >        } catch (AssertionError fail) {
918              threadRecordFailure(fail);
919              throw fail;
920          }
# Line 783 | Line 936 | public class JSR166TestCase extends Test
936  
937      /**
938       * Records the given exception using {@link #threadRecordFailure},
939 <     * then rethrows the exception, wrapping it in an
940 <     * AssertionFailedError if necessary.
939 >     * then rethrows the exception, wrapping it in an AssertionError
940 >     * if necessary.
941       */
942      public void threadUnexpectedException(Throwable t) {
943          threadRecordFailure(t);
# Line 793 | Line 946 | public class JSR166TestCase extends Test
946              throw (RuntimeException) t;
947          else if (t instanceof Error)
948              throw (Error) t;
949 <        else {
950 <            AssertionFailedError afe =
798 <                new AssertionFailedError("unexpected exception: " + t);
799 <            afe.initCause(t);
800 <            throw afe;
801 <        }
949 >        else
950 >            throw new AssertionError("unexpected exception: " + t, t);
951      }
952  
953      /**
# Line 866 | Line 1015 | public class JSR166TestCase extends Test
1015          }};
1016      }
1017  
1018 +    PoolCleaner cleaner(ExecutorService pool, AtomicBoolean flag) {
1019 +        return new PoolCleanerWithReleaser(pool, releaser(flag));
1020 +    }
1021 +
1022 +    Runnable releaser(final AtomicBoolean flag) {
1023 +        return new Runnable() { public void run() { flag.set(true); }};
1024 +    }
1025 +
1026      /**
1027       * Waits out termination of a thread pool or fails doing so.
1028       */
# Line 889 | Line 1046 | public class JSR166TestCase extends Test
1046          }
1047      }
1048  
1049 <    /** Like Runnable, but with the freedom to throw anything */
1049 >    /**
1050 >     * Like Runnable, but with the freedom to throw anything.
1051 >     * junit folks had the same idea:
1052 >     * http://junit.org/junit5/docs/snapshot/api/org/junit/gen5/api/Executable.html
1053 >     */
1054      interface Action { public void run() throws Throwable; }
1055  
1056      /**
# Line 920 | Line 1081 | public class JSR166TestCase extends Test
1081       * Uninteresting threads are filtered out.
1082       */
1083      static void dumpTestThreads() {
1084 +        SecurityManager sm = System.getSecurityManager();
1085 +        if (sm != null) {
1086 +            try {
1087 +                System.setSecurityManager(null);
1088 +            } catch (SecurityException giveUp) {
1089 +                return;
1090 +            }
1091 +        }
1092 +
1093          ThreadMXBean threadMXBean = ManagementFactory.getThreadMXBean();
1094          System.err.println("------ stacktrace dump start ------");
1095          for (ThreadInfo info : threadMXBean.dumpAllThreads(true, true)) {
1096 <            String name = info.getThreadName();
1096 >            final String name = info.getThreadName();
1097 >            String lockName;
1098              if ("Signal Dispatcher".equals(name))
1099                  continue;
1100              if ("Reference Handler".equals(name)
1101 <                && info.getLockName().startsWith("java.lang.ref.Reference$Lock"))
1101 >                && (lockName = info.getLockName()) != null
1102 >                && lockName.startsWith("java.lang.ref.Reference$Lock"))
1103                  continue;
1104              if ("Finalizer".equals(name)
1105 <                && info.getLockName().startsWith("java.lang.ref.ReferenceQueue$Lock"))
1105 >                && (lockName = info.getLockName()) != null
1106 >                && lockName.startsWith("java.lang.ref.ReferenceQueue$Lock"))
1107                  continue;
1108              if ("checkForWedgedTest".equals(name))
1109                  continue;
1110              System.err.print(info);
1111          }
1112          System.err.println("------ stacktrace dump end ------");
940    }
1113  
1114 <    /**
943 <     * Checks that thread does not terminate within the default
944 <     * millisecond delay of {@code timeoutMillis()}.
945 <     */
946 <    void assertThreadStaysAlive(Thread thread) {
947 <        assertThreadStaysAlive(thread, timeoutMillis());
948 <    }
949 <
950 <    /**
951 <     * Checks that thread does not terminate within the given millisecond delay.
952 <     */
953 <    void assertThreadStaysAlive(Thread thread, long millis) {
954 <        try {
955 <            // No need to optimize the failing case via Thread.join.
956 <            delay(millis);
957 <            assertTrue(thread.isAlive());
958 <        } catch (InterruptedException fail) {
959 <            threadFail("Unexpected InterruptedException");
960 <        }
1114 >        if (sm != null) System.setSecurityManager(sm);
1115      }
1116  
1117      /**
1118 <     * Checks that the threads do not terminate within the default
965 <     * millisecond delay of {@code timeoutMillis()}.
1118 >     * Checks that thread eventually enters the expected blocked thread state.
1119       */
1120 <    void assertThreadsStayAlive(Thread... threads) {
1121 <        assertThreadsStayAlive(timeoutMillis(), threads);
1122 <    }
1123 <
1124 <    /**
1125 <     * Checks that the threads do not terminate within the given millisecond delay.
1126 <     */
1127 <    void assertThreadsStayAlive(long millis, Thread... threads) {
1128 <        try {
1129 <            // No need to optimize the failing case via Thread.join.
1130 <            delay(millis);
1131 <            for (Thread thread : threads)
1132 <                assertTrue(thread.isAlive());
980 <        } catch (InterruptedException fail) {
981 <            threadFail("Unexpected InterruptedException");
1120 >    void assertThreadBlocks(Thread thread, Thread.State expected) {
1121 >        // always sleep at least 1 ms, with high probability avoiding
1122 >        // transitory states
1123 >        for (long retries = LONG_DELAY_MS * 3 / 4; retries-->0; ) {
1124 >            try { delay(1); }
1125 >            catch (InterruptedException fail) {
1126 >                throw new AssertionError("Unexpected InterruptedException", fail);
1127 >            }
1128 >            Thread.State s = thread.getState();
1129 >            if (s == expected)
1130 >                return;
1131 >            else if (s == Thread.State.TERMINATED)
1132 >                fail("Unexpected thread termination");
1133          }
1134 +        fail("timed out waiting for thread to enter thread state " + expected);
1135      }
1136  
1137      /**
# Line 1020 | Line 1172 | public class JSR166TestCase extends Test
1172      }
1173  
1174      /**
1175 +     * The maximum number of consecutive spurious wakeups we should
1176 +     * tolerate (from APIs like LockSupport.park) before failing a test.
1177 +     */
1178 +    static final int MAX_SPURIOUS_WAKEUPS = 10;
1179 +
1180 +    /**
1181       * The number of elements to place in collections, arrays, etc.
1182       */
1183      public static final int SIZE = 20;
# Line 1123 | Line 1281 | public class JSR166TestCase extends Test
1281          }
1282          public void refresh() {}
1283          public String toString() {
1284 <            List<Permission> ps = new ArrayList<Permission>();
1284 >            List<Permission> ps = new ArrayList<>();
1285              for (Enumeration<Permission> e = perms.elements(); e.hasMoreElements();)
1286                  ps.add(e.nextElement());
1287              return "AdjustablePolicy with permissions " + ps;
# Line 1151 | Line 1309 | public class JSR166TestCase extends Test
1309  
1310      /**
1311       * Sleeps until the given time has elapsed.
1312 <     * Throws AssertionFailedError if interrupted.
1312 >     * Throws AssertionError if interrupted.
1313       */
1314 <    void sleep(long millis) {
1314 >    static void sleep(long millis) {
1315          try {
1316              delay(millis);
1317          } catch (InterruptedException fail) {
1318 <            AssertionFailedError afe =
1161 <                new AssertionFailedError("Unexpected InterruptedException");
1162 <            afe.initCause(fail);
1163 <            throw afe;
1318 >            throw new AssertionError("Unexpected InterruptedException", fail);
1319          }
1320      }
1321  
1322      /**
1323       * Spin-waits up to the specified number of milliseconds for the given
1324       * thread to enter a wait state: BLOCKED, WAITING, or TIMED_WAITING.
1325 +     * @param waitingForGodot if non-null, an additional condition to satisfy
1326       */
1327 <    void waitForThreadToEnterWaitState(Thread thread, long timeoutMillis) {
1328 <        long startTime = System.nanoTime();
1329 <        for (;;) {
1330 <            Thread.State s = thread.getState();
1331 <            if (s == Thread.State.BLOCKED ||
1332 <                s == Thread.State.WAITING ||
1333 <                s == Thread.State.TIMED_WAITING)
1334 <                return;
1335 <            else if (s == Thread.State.TERMINATED)
1327 >    void waitForThreadToEnterWaitState(Thread thread, long timeoutMillis,
1328 >                                       Callable<Boolean> waitingForGodot) {
1329 >        for (long startTime = 0L;;) {
1330 >            switch (thread.getState()) {
1331 >            default: break;
1332 >            case BLOCKED: case WAITING: case TIMED_WAITING:
1333 >                try {
1334 >                    if (waitingForGodot == null || waitingForGodot.call())
1335 >                        return;
1336 >                } catch (Throwable fail) { threadUnexpectedException(fail); }
1337 >                break;
1338 >            case TERMINATED:
1339                  fail("Unexpected thread termination");
1340 +            }
1341 +
1342 +            if (startTime == 0L)
1343 +                startTime = System.nanoTime();
1344              else if (millisElapsedSince(startTime) > timeoutMillis) {
1345 <                threadAssertTrue(thread.isAlive());
1346 <                return;
1345 >                assertTrue(thread.isAlive());
1346 >                if (waitingForGodot == null
1347 >                    || thread.getState() == Thread.State.RUNNABLE)
1348 >                    fail("timed out waiting for thread to enter wait state");
1349 >                else
1350 >                    fail("timed out waiting for condition, thread state="
1351 >                         + thread.getState());
1352              }
1353              Thread.yield();
1354          }
1355      }
1356  
1357      /**
1358 <     * Waits up to LONG_DELAY_MS for the given thread to enter a wait
1359 <     * state: BLOCKED, WAITING, or TIMED_WAITING.
1358 >     * Spin-waits up to the specified number of milliseconds for the given
1359 >     * thread to enter a wait state: BLOCKED, WAITING, or TIMED_WAITING.
1360 >     */
1361 >    void waitForThreadToEnterWaitState(Thread thread, long timeoutMillis) {
1362 >        waitForThreadToEnterWaitState(thread, timeoutMillis, null);
1363 >    }
1364 >
1365 >    /**
1366 >     * Spin-waits up to LONG_DELAY_MS milliseconds for the given thread to
1367 >     * enter a wait state: BLOCKED, WAITING, or TIMED_WAITING.
1368       */
1369      void waitForThreadToEnterWaitState(Thread thread) {
1370 <        waitForThreadToEnterWaitState(thread, LONG_DELAY_MS);
1370 >        waitForThreadToEnterWaitState(thread, LONG_DELAY_MS, null);
1371 >    }
1372 >
1373 >    /**
1374 >     * Spin-waits up to LONG_DELAY_MS milliseconds for the given thread to
1375 >     * enter a wait state: BLOCKED, WAITING, or TIMED_WAITING,
1376 >     * and additionally satisfy the given condition.
1377 >     */
1378 >    void waitForThreadToEnterWaitState(Thread thread,
1379 >                                       Callable<Boolean> waitingForGodot) {
1380 >        waitForThreadToEnterWaitState(thread, LONG_DELAY_MS, waitingForGodot);
1381 >    }
1382 >
1383 >    /**
1384 >     * Spin-waits up to LONG_DELAY_MS milliseconds for the current thread to
1385 >     * be interrupted.  Clears the interrupt status before returning.
1386 >     */
1387 >    void awaitInterrupted() {
1388 >        for (long startTime = 0L; !Thread.interrupted(); ) {
1389 >            if (startTime == 0L)
1390 >                startTime = System.nanoTime();
1391 >            else if (millisElapsedSince(startTime) > LONG_DELAY_MS)
1392 >                fail("timed out waiting for thread interrupt");
1393 >            Thread.yield();
1394 >        }
1395      }
1396  
1397      /**
# Line 1209 | Line 1409 | public class JSR166TestCase extends Test
1409   //             r.run();
1410   //         } catch (Throwable fail) { threadUnexpectedException(fail); }
1411   //         if (millisElapsedSince(startTime) > timeoutMillis/2)
1412 < //             throw new AssertionFailedError("did not return promptly");
1412 > //             throw new AssertionError("did not return promptly");
1413   //     }
1414  
1415   //     void assertTerminatesPromptly(Runnable r) {
# Line 1222 | Line 1422 | public class JSR166TestCase extends Test
1422       */
1423      <T> void checkTimedGet(Future<T> f, T expectedValue, long timeoutMillis) {
1424          long startTime = System.nanoTime();
1425 +        T actual = null;
1426          try {
1427 <            assertEquals(expectedValue, f.get(timeoutMillis, MILLISECONDS));
1427 >            actual = f.get(timeoutMillis, MILLISECONDS);
1428          } catch (Throwable fail) { threadUnexpectedException(fail); }
1429 +        assertEquals(expectedValue, actual);
1430          if (millisElapsedSince(startTime) > timeoutMillis/2)
1431 <            throw new AssertionFailedError("timed get did not return promptly");
1431 >            throw new AssertionError("timed get did not return promptly");
1432      }
1433  
1434      <T> void checkTimedGet(Future<T> f, T expectedValue) {
# Line 1284 | Line 1486 | public class JSR166TestCase extends Test
1486          }
1487      }
1488  
1287    public abstract class RunnableShouldThrow implements Runnable {
1288        protected abstract void realRun() throws Throwable;
1289
1290        final Class<?> exceptionClass;
1291
1292        <T extends Throwable> RunnableShouldThrow(Class<T> exceptionClass) {
1293            this.exceptionClass = exceptionClass;
1294        }
1295
1296        public final void run() {
1297            try {
1298                realRun();
1299                threadShouldThrow(exceptionClass.getSimpleName());
1300            } catch (Throwable t) {
1301                if (! exceptionClass.isInstance(t))
1302                    threadUnexpectedException(t);
1303            }
1304        }
1305    }
1306
1489      public abstract class ThreadShouldThrow extends Thread {
1490          protected abstract void realRun() throws Throwable;
1491  
# Line 1316 | Line 1498 | public class JSR166TestCase extends Test
1498          public final void run() {
1499              try {
1500                  realRun();
1319                threadShouldThrow(exceptionClass.getSimpleName());
1501              } catch (Throwable t) {
1502                  if (! exceptionClass.isInstance(t))
1503                      threadUnexpectedException(t);
1504 +                return;
1505              }
1506 +            threadShouldThrow(exceptionClass.getSimpleName());
1507          }
1508      }
1509  
# Line 1330 | Line 1513 | public class JSR166TestCase extends Test
1513          public final void run() {
1514              try {
1515                  realRun();
1333                threadShouldThrow("InterruptedException");
1516              } catch (InterruptedException success) {
1517                  threadAssertFalse(Thread.interrupted());
1518 +                return;
1519              } catch (Throwable fail) {
1520                  threadUnexpectedException(fail);
1521              }
1522 +            threadShouldThrow("InterruptedException");
1523          }
1524      }
1525  
# Line 1347 | Line 1531 | public class JSR166TestCase extends Test
1531                  return realCall();
1532              } catch (Throwable fail) {
1533                  threadUnexpectedException(fail);
1350                return null;
1351            }
1352        }
1353    }
1354
1355    public abstract class CheckedInterruptedCallable<T>
1356        implements Callable<T> {
1357        protected abstract T realCall() throws Throwable;
1358
1359        public final T call() {
1360            try {
1361                T result = realCall();
1362                threadShouldThrow("InterruptedException");
1363                return result;
1364            } catch (InterruptedException success) {
1365                threadAssertFalse(Thread.interrupted());
1366            } catch (Throwable fail) {
1367                threadUnexpectedException(fail);
1534              }
1535 <            return null;
1535 >            throw new AssertionError("unreached");
1536          }
1537      }
1538  
# Line 1422 | Line 1588 | public class JSR166TestCase extends Test
1588          return new LatchAwaiter(latch);
1589      }
1590  
1591 <    public void await(CountDownLatch latch) {
1591 >    public void await(CountDownLatch latch, long timeoutMillis) {
1592 >        boolean timedOut = false;
1593          try {
1594 <            if (!latch.await(LONG_DELAY_MS, MILLISECONDS))
1428 <                fail("timed out waiting for CountDownLatch for "
1429 <                     + (LONG_DELAY_MS/1000) + " sec");
1594 >            timedOut = !latch.await(timeoutMillis, MILLISECONDS);
1595          } catch (Throwable fail) {
1596              threadUnexpectedException(fail);
1597          }
1598 +        if (timedOut)
1599 +            fail("timed out waiting for CountDownLatch for "
1600 +                 + (timeoutMillis/1000) + " sec");
1601 +    }
1602 +
1603 +    public void await(CountDownLatch latch) {
1604 +        await(latch, LONG_DELAY_MS);
1605      }
1606  
1607      public void await(Semaphore semaphore) {
1608 +        boolean timedOut = false;
1609 +        try {
1610 +            timedOut = !semaphore.tryAcquire(LONG_DELAY_MS, MILLISECONDS);
1611 +        } catch (Throwable fail) {
1612 +            threadUnexpectedException(fail);
1613 +        }
1614 +        if (timedOut)
1615 +            fail("timed out waiting for Semaphore for "
1616 +                 + (LONG_DELAY_MS/1000) + " sec");
1617 +    }
1618 +
1619 +    public void await(CyclicBarrier barrier) {
1620          try {
1621 <            if (!semaphore.tryAcquire(LONG_DELAY_MS, MILLISECONDS))
1438 <                fail("timed out waiting for Semaphore for "
1439 <                     + (LONG_DELAY_MS/1000) + " sec");
1621 >            barrier.await(LONG_DELAY_MS, MILLISECONDS);
1622          } catch (Throwable fail) {
1623              threadUnexpectedException(fail);
1624          }
# Line 1456 | Line 1638 | public class JSR166TestCase extends Test
1638   //         long startTime = System.nanoTime();
1639   //         while (!flag.get()) {
1640   //             if (millisElapsedSince(startTime) > timeoutMillis)
1641 < //                 throw new AssertionFailedError("timed out");
1641 > //                 throw new AssertionError("timed out");
1642   //             Thread.yield();
1643   //         }
1644   //     }
# Line 1465 | Line 1647 | public class JSR166TestCase extends Test
1647          public String call() { throw new NullPointerException(); }
1648      }
1649  
1468    public static class CallableOne implements Callable<Integer> {
1469        public Integer call() { return one; }
1470    }
1471
1472    public class ShortRunnable extends CheckedRunnable {
1473        protected void realRun() throws Throwable {
1474            delay(SHORT_DELAY_MS);
1475        }
1476    }
1477
1478    public class ShortInterruptedRunnable extends CheckedInterruptedRunnable {
1479        protected void realRun() throws InterruptedException {
1480            delay(SHORT_DELAY_MS);
1481        }
1482    }
1483
1484    public class SmallRunnable extends CheckedRunnable {
1485        protected void realRun() throws Throwable {
1486            delay(SMALL_DELAY_MS);
1487        }
1488    }
1489
1490    public class SmallPossiblyInterruptedRunnable extends CheckedRunnable {
1491        protected void realRun() {
1492            try {
1493                delay(SMALL_DELAY_MS);
1494            } catch (InterruptedException ok) {}
1495        }
1496    }
1497
1498    public class SmallCallable extends CheckedCallable {
1499        protected Object realCall() throws InterruptedException {
1500            delay(SMALL_DELAY_MS);
1501            return Boolean.TRUE;
1502        }
1503    }
1504
1505    public class MediumRunnable extends CheckedRunnable {
1506        protected void realRun() throws Throwable {
1507            delay(MEDIUM_DELAY_MS);
1508        }
1509    }
1510
1511    public class MediumInterruptedRunnable extends CheckedInterruptedRunnable {
1512        protected void realRun() throws InterruptedException {
1513            delay(MEDIUM_DELAY_MS);
1514        }
1515    }
1516
1650      public Runnable possiblyInterruptedRunnable(final long timeoutMillis) {
1651          return new CheckedRunnable() {
1652              protected void realRun() {
# Line 1523 | Line 1656 | public class JSR166TestCase extends Test
1656              }};
1657      }
1658  
1526    public class MediumPossiblyInterruptedRunnable extends CheckedRunnable {
1527        protected void realRun() {
1528            try {
1529                delay(MEDIUM_DELAY_MS);
1530            } catch (InterruptedException ok) {}
1531        }
1532    }
1533
1534    public class LongPossiblyInterruptedRunnable extends CheckedRunnable {
1535        protected void realRun() {
1536            try {
1537                delay(LONG_DELAY_MS);
1538            } catch (InterruptedException ok) {}
1539        }
1540    }
1541
1659      /**
1660       * For use as ThreadFactory in constructors
1661       */
# Line 1552 | Line 1669 | public class JSR166TestCase extends Test
1669          boolean isDone();
1670      }
1671  
1555    public static TrackedRunnable trackedRunnable(final long timeoutMillis) {
1556        return new TrackedRunnable() {
1557                private volatile boolean done = false;
1558                public boolean isDone() { return done; }
1559                public void run() {
1560                    try {
1561                        delay(timeoutMillis);
1562                        done = true;
1563                    } catch (InterruptedException ok) {}
1564                }
1565            };
1566    }
1567
1568    public static class TrackedShortRunnable implements Runnable {
1569        public volatile boolean done = false;
1570        public void run() {
1571            try {
1572                delay(SHORT_DELAY_MS);
1573                done = true;
1574            } catch (InterruptedException ok) {}
1575        }
1576    }
1577
1578    public static class TrackedSmallRunnable implements Runnable {
1579        public volatile boolean done = false;
1580        public void run() {
1581            try {
1582                delay(SMALL_DELAY_MS);
1583                done = true;
1584            } catch (InterruptedException ok) {}
1585        }
1586    }
1587
1588    public static class TrackedMediumRunnable implements Runnable {
1589        public volatile boolean done = false;
1590        public void run() {
1591            try {
1592                delay(MEDIUM_DELAY_MS);
1593                done = true;
1594            } catch (InterruptedException ok) {}
1595        }
1596    }
1597
1598    public static class TrackedLongRunnable implements Runnable {
1599        public volatile boolean done = false;
1600        public void run() {
1601            try {
1602                delay(LONG_DELAY_MS);
1603                done = true;
1604            } catch (InterruptedException ok) {}
1605        }
1606    }
1607
1672      public static class TrackedNoOpRunnable implements Runnable {
1673          public volatile boolean done = false;
1674          public void run() {
# Line 1612 | Line 1676 | public class JSR166TestCase extends Test
1676          }
1677      }
1678  
1615    public static class TrackedCallable implements Callable {
1616        public volatile boolean done = false;
1617        public Object call() {
1618            try {
1619                delay(SMALL_DELAY_MS);
1620                done = true;
1621            } catch (InterruptedException ok) {}
1622            return Boolean.TRUE;
1623        }
1624    }
1625
1679      /**
1680       * Analog of CheckedRunnable for RecursiveAction
1681       */
# Line 1649 | Line 1702 | public class JSR166TestCase extends Test
1702                  return realCompute();
1703              } catch (Throwable fail) {
1704                  threadUnexpectedException(fail);
1652                return null;
1705              }
1706 +            throw new AssertionError("unreached");
1707          }
1708      }
1709  
# Line 1664 | Line 1717 | public class JSR166TestCase extends Test
1717  
1718      /**
1719       * A CyclicBarrier that uses timed await and fails with
1720 <     * AssertionFailedErrors instead of throwing checked exceptions.
1720 >     * AssertionErrors instead of throwing checked exceptions.
1721       */
1722 <    public class CheckedBarrier extends CyclicBarrier {
1722 >    public static class CheckedBarrier extends CyclicBarrier {
1723          public CheckedBarrier(int parties) { super(parties); }
1724  
1725          public int await() {
1726              try {
1727                  return super.await(2 * LONG_DELAY_MS, MILLISECONDS);
1728              } catch (TimeoutException timedOut) {
1729 <                throw new AssertionFailedError("timed out");
1729 >                throw new AssertionError("timed out");
1730              } catch (Exception fail) {
1731 <                AssertionFailedError afe =
1679 <                    new AssertionFailedError("Unexpected exception: " + fail);
1680 <                afe.initCause(fail);
1681 <                throw afe;
1731 >                throw new AssertionError("Unexpected exception: " + fail, fail);
1732              }
1733          }
1734      }
# Line 1689 | Line 1739 | public class JSR166TestCase extends Test
1739              assertEquals(0, q.size());
1740              assertNull(q.peek());
1741              assertNull(q.poll());
1742 <            assertNull(q.poll(0, MILLISECONDS));
1742 >            assertNull(q.poll(randomExpiredTimeout(), randomTimeUnit()));
1743              assertEquals(q.toString(), "[]");
1744              assertTrue(Arrays.equals(q.toArray(), new Object[0]));
1745              assertFalse(q.iterator().hasNext());
# Line 1730 | Line 1780 | public class JSR166TestCase extends Test
1780          }
1781      }
1782  
1783 +    void assertImmutable(Object o) {
1784 +        if (o instanceof Collection) {
1785 +            assertThrows(
1786 +                UnsupportedOperationException.class,
1787 +                () -> ((Collection) o).add(null));
1788 +        }
1789 +    }
1790 +
1791      @SuppressWarnings("unchecked")
1792      <T> T serialClone(T o) {
1793 +        T clone = null;
1794          try {
1795              ObjectInputStream ois = new ObjectInputStream
1796                  (new ByteArrayInputStream(serialBytes(o)));
1797 <            T clone = (T) ois.readObject();
1739 <            assertSame(o.getClass(), clone.getClass());
1740 <            return clone;
1797 >            clone = (T) ois.readObject();
1798          } catch (Throwable fail) {
1799              threadUnexpectedException(fail);
1800 +        }
1801 +        if (o == clone) assertImmutable(o);
1802 +        else assertSame(o.getClass(), clone.getClass());
1803 +        return clone;
1804 +    }
1805 +
1806 +    /**
1807 +     * A version of serialClone that leaves error handling (for
1808 +     * e.g. NotSerializableException) up to the caller.
1809 +     */
1810 +    @SuppressWarnings("unchecked")
1811 +    <T> T serialClonePossiblyFailing(T o)
1812 +        throws ReflectiveOperationException, java.io.IOException {
1813 +        ByteArrayOutputStream bos = new ByteArrayOutputStream();
1814 +        ObjectOutputStream oos = new ObjectOutputStream(bos);
1815 +        oos.writeObject(o);
1816 +        oos.flush();
1817 +        oos.close();
1818 +        ObjectInputStream ois = new ObjectInputStream
1819 +            (new ByteArrayInputStream(bos.toByteArray()));
1820 +        T clone = (T) ois.readObject();
1821 +        if (o == clone) assertImmutable(o);
1822 +        else assertSame(o.getClass(), clone.getClass());
1823 +        return clone;
1824 +    }
1825 +
1826 +    /**
1827 +     * If o implements Cloneable and has a public clone method,
1828 +     * returns a clone of o, else null.
1829 +     */
1830 +    @SuppressWarnings("unchecked")
1831 +    <T> T cloneableClone(T o) {
1832 +        if (!(o instanceof Cloneable)) return null;
1833 +        final T clone;
1834 +        try {
1835 +            clone = (T) o.getClass().getMethod("clone").invoke(o);
1836 +        } catch (NoSuchMethodException ok) {
1837              return null;
1838 +        } catch (ReflectiveOperationException unexpected) {
1839 +            throw new Error(unexpected);
1840          }
1841 +        assertNotSame(o, clone); // not 100% guaranteed by spec
1842 +        assertSame(o.getClass(), clone.getClass());
1843 +        return clone;
1844      }
1845  
1846      public void assertThrows(Class<? extends Throwable> expectedExceptionClass,
1847 <                             Runnable... throwingActions) {
1848 <        for (Runnable throwingAction : throwingActions) {
1847 >                             Action... throwingActions) {
1848 >        for (Action throwingAction : throwingActions) {
1849              boolean threw = false;
1850              try { throwingAction.run(); }
1851              catch (Throwable t) {
1852                  threw = true;
1853 <                if (!expectedExceptionClass.isInstance(t)) {
1854 <                    AssertionFailedError afe =
1855 <                        new AssertionFailedError
1856 <                        ("Expected " + expectedExceptionClass.getName() +
1857 <                         ", got " + t.getClass().getName());
1759 <                    afe.initCause(t);
1760 <                    threadUnexpectedException(afe);
1761 <                }
1853 >                if (!expectedExceptionClass.isInstance(t))
1854 >                    throw new AssertionError(
1855 >                            "Expected " + expectedExceptionClass.getName() +
1856 >                            ", got " + t.getClass().getName(),
1857 >                            t);
1858              }
1859              if (!threw)
1860                  shouldThrow(expectedExceptionClass.getName());
# Line 1772 | Line 1868 | public class JSR166TestCase extends Test
1868          } catch (NoSuchElementException success) {}
1869          assertFalse(it.hasNext());
1870      }
1871 +
1872 +    public <T> Callable<T> callableThrowing(final Exception ex) {
1873 +        return new Callable<T>() { public T call() throws Exception { throw ex; }};
1874 +    }
1875 +
1876 +    public Runnable runnableThrowing(final RuntimeException ex) {
1877 +        return new Runnable() { public void run() { throw ex; }};
1878 +    }
1879 +
1880 +    /** A reusable thread pool to be shared by tests. */
1881 +    static final ExecutorService cachedThreadPool =
1882 +        new ThreadPoolExecutor(0, Integer.MAX_VALUE,
1883 +                               1000L, MILLISECONDS,
1884 +                               new SynchronousQueue<Runnable>());
1885 +
1886 +    static <T> void shuffle(T[] array) {
1887 +        Collections.shuffle(Arrays.asList(array), ThreadLocalRandom.current());
1888 +    }
1889 +
1890 +    /**
1891 +     * Returns the same String as would be returned by {@link
1892 +     * Object#toString}, whether or not the given object's class
1893 +     * overrides toString().
1894 +     *
1895 +     * @see System#identityHashCode
1896 +     */
1897 +    static String identityString(Object x) {
1898 +        return x.getClass().getName()
1899 +            + "@" + Integer.toHexString(System.identityHashCode(x));
1900 +    }
1901 +
1902 +    // --- Shared assertions for Executor tests ---
1903 +
1904 +    /**
1905 +     * Returns maximum number of tasks that can be submitted to given
1906 +     * pool (with bounded queue) before saturation (when submission
1907 +     * throws RejectedExecutionException).
1908 +     */
1909 +    static final int saturatedSize(ThreadPoolExecutor pool) {
1910 +        BlockingQueue<Runnable> q = pool.getQueue();
1911 +        return pool.getMaximumPoolSize() + q.size() + q.remainingCapacity();
1912 +    }
1913 +
1914 +    @SuppressWarnings("FutureReturnValueIgnored")
1915 +    void assertNullTaskSubmissionThrowsNullPointerException(Executor e) {
1916 +        try {
1917 +            e.execute((Runnable) null);
1918 +            shouldThrow();
1919 +        } catch (NullPointerException success) {}
1920 +
1921 +        if (! (e instanceof ExecutorService)) return;
1922 +        ExecutorService es = (ExecutorService) e;
1923 +        try {
1924 +            es.submit((Runnable) null);
1925 +            shouldThrow();
1926 +        } catch (NullPointerException success) {}
1927 +        try {
1928 +            es.submit((Runnable) null, Boolean.TRUE);
1929 +            shouldThrow();
1930 +        } catch (NullPointerException success) {}
1931 +        try {
1932 +            es.submit((Callable) null);
1933 +            shouldThrow();
1934 +        } catch (NullPointerException success) {}
1935 +
1936 +        if (! (e instanceof ScheduledExecutorService)) return;
1937 +        ScheduledExecutorService ses = (ScheduledExecutorService) e;
1938 +        try {
1939 +            ses.schedule((Runnable) null,
1940 +                         randomTimeout(), randomTimeUnit());
1941 +            shouldThrow();
1942 +        } catch (NullPointerException success) {}
1943 +        try {
1944 +            ses.schedule((Callable) null,
1945 +                         randomTimeout(), randomTimeUnit());
1946 +            shouldThrow();
1947 +        } catch (NullPointerException success) {}
1948 +        try {
1949 +            ses.scheduleAtFixedRate((Runnable) null,
1950 +                                    randomTimeout(), LONG_DELAY_MS, MILLISECONDS);
1951 +            shouldThrow();
1952 +        } catch (NullPointerException success) {}
1953 +        try {
1954 +            ses.scheduleWithFixedDelay((Runnable) null,
1955 +                                       randomTimeout(), LONG_DELAY_MS, MILLISECONDS);
1956 +            shouldThrow();
1957 +        } catch (NullPointerException success) {}
1958 +    }
1959 +
1960 +    void setRejectedExecutionHandler(
1961 +        ThreadPoolExecutor p, RejectedExecutionHandler handler) {
1962 +        p.setRejectedExecutionHandler(handler);
1963 +        assertSame(handler, p.getRejectedExecutionHandler());
1964 +    }
1965 +
1966 +    void assertTaskSubmissionsAreRejected(ThreadPoolExecutor p) {
1967 +        final RejectedExecutionHandler savedHandler = p.getRejectedExecutionHandler();
1968 +        final long savedTaskCount = p.getTaskCount();
1969 +        final long savedCompletedTaskCount = p.getCompletedTaskCount();
1970 +        final int savedQueueSize = p.getQueue().size();
1971 +        final boolean stock = (p.getClass().getClassLoader() == null);
1972 +
1973 +        Runnable r = () -> {};
1974 +        Callable<Boolean> c = () -> Boolean.TRUE;
1975 +
1976 +        class Recorder implements RejectedExecutionHandler {
1977 +            public volatile Runnable r = null;
1978 +            public volatile ThreadPoolExecutor p = null;
1979 +            public void reset() { r = null; p = null; }
1980 +            public void rejectedExecution(Runnable r, ThreadPoolExecutor p) {
1981 +                assertNull(this.r);
1982 +                assertNull(this.p);
1983 +                this.r = r;
1984 +                this.p = p;
1985 +            }
1986 +        }
1987 +
1988 +        // check custom handler is invoked exactly once per task
1989 +        Recorder recorder = new Recorder();
1990 +        setRejectedExecutionHandler(p, recorder);
1991 +        for (int i = 2; i--> 0; ) {
1992 +            recorder.reset();
1993 +            p.execute(r);
1994 +            if (stock && p.getClass() == ThreadPoolExecutor.class)
1995 +                assertSame(r, recorder.r);
1996 +            assertSame(p, recorder.p);
1997 +
1998 +            recorder.reset();
1999 +            assertFalse(p.submit(r).isDone());
2000 +            if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2001 +            assertSame(p, recorder.p);
2002 +
2003 +            recorder.reset();
2004 +            assertFalse(p.submit(r, Boolean.TRUE).isDone());
2005 +            if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2006 +            assertSame(p, recorder.p);
2007 +
2008 +            recorder.reset();
2009 +            assertFalse(p.submit(c).isDone());
2010 +            if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2011 +            assertSame(p, recorder.p);
2012 +
2013 +            if (p instanceof ScheduledExecutorService) {
2014 +                ScheduledExecutorService s = (ScheduledExecutorService) p;
2015 +                ScheduledFuture<?> future;
2016 +
2017 +                recorder.reset();
2018 +                future = s.schedule(r, randomTimeout(), randomTimeUnit());
2019 +                assertFalse(future.isDone());
2020 +                if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2021 +                assertSame(p, recorder.p);
2022 +
2023 +                recorder.reset();
2024 +                future = s.schedule(c, randomTimeout(), randomTimeUnit());
2025 +                assertFalse(future.isDone());
2026 +                if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2027 +                assertSame(p, recorder.p);
2028 +
2029 +                recorder.reset();
2030 +                future = s.scheduleAtFixedRate(r, randomTimeout(), LONG_DELAY_MS, MILLISECONDS);
2031 +                assertFalse(future.isDone());
2032 +                if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2033 +                assertSame(p, recorder.p);
2034 +
2035 +                recorder.reset();
2036 +                future = s.scheduleWithFixedDelay(r, randomTimeout(), LONG_DELAY_MS, MILLISECONDS);
2037 +                assertFalse(future.isDone());
2038 +                if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2039 +                assertSame(p, recorder.p);
2040 +            }
2041 +        }
2042 +
2043 +        // Checking our custom handler above should be sufficient, but
2044 +        // we add some integration tests of standard handlers.
2045 +        final AtomicReference<Thread> thread = new AtomicReference<>();
2046 +        final Runnable setThread = () -> thread.set(Thread.currentThread());
2047 +
2048 +        setRejectedExecutionHandler(p, new ThreadPoolExecutor.AbortPolicy());
2049 +        try {
2050 +            p.execute(setThread);
2051 +            shouldThrow();
2052 +        } catch (RejectedExecutionException success) {}
2053 +        assertNull(thread.get());
2054 +
2055 +        setRejectedExecutionHandler(p, new ThreadPoolExecutor.DiscardPolicy());
2056 +        p.execute(setThread);
2057 +        assertNull(thread.get());
2058 +
2059 +        setRejectedExecutionHandler(p, new ThreadPoolExecutor.CallerRunsPolicy());
2060 +        p.execute(setThread);
2061 +        if (p.isShutdown())
2062 +            assertNull(thread.get());
2063 +        else
2064 +            assertSame(Thread.currentThread(), thread.get());
2065 +
2066 +        setRejectedExecutionHandler(p, savedHandler);
2067 +
2068 +        // check that pool was not perturbed by handlers
2069 +        assertEquals(savedTaskCount, p.getTaskCount());
2070 +        assertEquals(savedCompletedTaskCount, p.getCompletedTaskCount());
2071 +        assertEquals(savedQueueSize, p.getQueue().size());
2072 +    }
2073 +
2074 +    void assertCollectionsEquals(Collection<?> x, Collection<?> y) {
2075 +        assertEquals(x, y);
2076 +        assertEquals(y, x);
2077 +        assertEquals(x.isEmpty(), y.isEmpty());
2078 +        assertEquals(x.size(), y.size());
2079 +        if (x instanceof List) {
2080 +            assertEquals(x.toString(), y.toString());
2081 +        }
2082 +        if (x instanceof List || x instanceof Set) {
2083 +            assertEquals(x.hashCode(), y.hashCode());
2084 +        }
2085 +        if (x instanceof List || x instanceof Deque) {
2086 +            assertTrue(Arrays.equals(x.toArray(), y.toArray()));
2087 +            assertTrue(Arrays.equals(x.toArray(new Object[0]),
2088 +                                     y.toArray(new Object[0])));
2089 +        }
2090 +    }
2091 +
2092 +    /**
2093 +     * A weaker form of assertCollectionsEquals which does not insist
2094 +     * that the two collections satisfy Object#equals(Object), since
2095 +     * they may use identity semantics as Deques do.
2096 +     */
2097 +    void assertCollectionsEquivalent(Collection<?> x, Collection<?> y) {
2098 +        if (x instanceof List || x instanceof Set)
2099 +            assertCollectionsEquals(x, y);
2100 +        else {
2101 +            assertEquals(x.isEmpty(), y.isEmpty());
2102 +            assertEquals(x.size(), y.size());
2103 +            assertEquals(new HashSet(x), new HashSet(y));
2104 +            if (x instanceof Deque) {
2105 +                assertTrue(Arrays.equals(x.toArray(), y.toArray()));
2106 +                assertTrue(Arrays.equals(x.toArray(new Object[0]),
2107 +                                         y.toArray(new Object[0])));
2108 +            }
2109 +        }
2110 +    }
2111   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines