ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/JSR166TestCase.java
(Generate patch)

Comparing jsr166/src/test/tck/JSR166TestCase.java (file contents):
Revision 1.130 by jsr166, Tue Apr 21 05:00:23 2015 UTC vs.
Revision 1.206 by jsr166, Tue Oct 25 01:32:55 2016 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 + /*
10 + * @test
11 + * @summary JSR-166 tck tests
12 + * @modules java.management
13 + * @build *
14 + * @run junit/othervm/timeout=1000 -Djsr166.testImplementationDetails=true JSR166TestCase
15 + * @run junit/othervm/timeout=1000 -Djava.util.concurrent.ForkJoinPool.common.parallelism=0 -Djsr166.testImplementationDetails=true JSR166TestCase
16 + * @run junit/othervm/timeout=1000 -Djava.util.concurrent.ForkJoinPool.common.parallelism=1 -Djava.util.secureRandomSeed=true JSR166TestCase
17 + */
18 +
19   import static java.util.concurrent.TimeUnit.MILLISECONDS;
20 + import static java.util.concurrent.TimeUnit.MINUTES;
21   import static java.util.concurrent.TimeUnit.NANOSECONDS;
22  
23   import java.io.ByteArrayInputStream;
# Line 15 | Line 26 | import java.io.ObjectInputStream;
26   import java.io.ObjectOutputStream;
27   import java.lang.management.ManagementFactory;
28   import java.lang.management.ThreadInfo;
29 + import java.lang.management.ThreadMXBean;
30 + import java.lang.reflect.Constructor;
31   import java.lang.reflect.Method;
32 + import java.lang.reflect.Modifier;
33 + import java.nio.file.Files;
34 + import java.nio.file.Paths;
35   import java.security.CodeSource;
36   import java.security.Permission;
37   import java.security.PermissionCollection;
# Line 25 | Line 41 | import java.security.ProtectionDomain;
41   import java.security.SecurityPermission;
42   import java.util.ArrayList;
43   import java.util.Arrays;
44 + import java.util.Collections;
45   import java.util.Date;
46   import java.util.Enumeration;
47   import java.util.Iterator;
# Line 35 | Line 52 | import java.util.concurrent.BlockingQueu
52   import java.util.concurrent.Callable;
53   import java.util.concurrent.CountDownLatch;
54   import java.util.concurrent.CyclicBarrier;
55 + import java.util.concurrent.ExecutionException;
56 + import java.util.concurrent.Executors;
57   import java.util.concurrent.ExecutorService;
58 + import java.util.concurrent.ForkJoinPool;
59   import java.util.concurrent.Future;
60   import java.util.concurrent.RecursiveAction;
61   import java.util.concurrent.RecursiveTask;
62   import java.util.concurrent.RejectedExecutionHandler;
63   import java.util.concurrent.Semaphore;
64 + import java.util.concurrent.SynchronousQueue;
65   import java.util.concurrent.ThreadFactory;
66 + import java.util.concurrent.ThreadLocalRandom;
67   import java.util.concurrent.ThreadPoolExecutor;
68   import java.util.concurrent.TimeoutException;
69 + import java.util.concurrent.atomic.AtomicBoolean;
70   import java.util.concurrent.atomic.AtomicReference;
71 + import java.util.regex.Matcher;
72   import java.util.regex.Pattern;
73  
74   import junit.framework.AssertionFailedError;
75   import junit.framework.Test;
76   import junit.framework.TestCase;
77 + import junit.framework.TestResult;
78   import junit.framework.TestSuite;
79  
80   /**
# Line 62 | Line 87 | import junit.framework.TestSuite;
87   *
88   * <ol>
89   *
90 < * <li> All assertions in code running in generated threads must use
90 > * <li>All assertions in code running in generated threads must use
91   * the forms {@link #threadFail}, {@link #threadAssertTrue}, {@link
92   * #threadAssertEquals}, or {@link #threadAssertNull}, (not
93   * {@code fail}, {@code assertTrue}, etc.) It is OK (but not
94   * particularly recommended) for other code to use these forms too.
95   * Only the most typically used JUnit assertion methods are defined
96 < * this way, but enough to live with.</li>
96 > * this way, but enough to live with.
97   *
98 < * <li> If you override {@link #setUp} or {@link #tearDown}, make sure
98 > * <li>If you override {@link #setUp} or {@link #tearDown}, make sure
99   * to invoke {@code super.setUp} and {@code super.tearDown} within
100   * them. These methods are used to clear and check for thread
101 < * assertion failures.</li>
101 > * assertion failures.
102   *
103   * <li>All delays and timeouts must use one of the constants {@code
104   * SHORT_DELAY_MS}, {@code SMALL_DELAY_MS}, {@code MEDIUM_DELAY_MS},
# Line 84 | Line 109 | import junit.framework.TestSuite;
109   * is always discriminable as larger than SHORT and smaller than
110   * MEDIUM.  And so on. These constants are set to conservative values,
111   * but even so, if there is ever any doubt, they can all be increased
112 < * in one spot to rerun tests on slower platforms.</li>
112 > * in one spot to rerun tests on slower platforms.
113   *
114 < * <li> All threads generated must be joined inside each test case
114 > * <li>All threads generated must be joined inside each test case
115   * method (or {@code fail} to do so) before returning from the
116   * method. The {@code joinPool} method can be used to do this when
117 < * using Executors.</li>
117 > * using Executors.
118   *
119   * </ol>
120   *
121   * <p><b>Other notes</b>
122   * <ul>
123   *
124 < * <li> Usually, there is one testcase method per JSR166 method
124 > * <li>Usually, there is one testcase method per JSR166 method
125   * covering "normal" operation, and then as many exception-testing
126   * methods as there are exceptions the method can throw. Sometimes
127   * there are multiple tests per JSR166 method when the different
128   * "normal" behaviors differ significantly. And sometimes testcases
129 < * cover multiple methods when they cannot be tested in
105 < * isolation.</li>
129 > * cover multiple methods when they cannot be tested in isolation.
130   *
131 < * <li> The documentation style for testcases is to provide as javadoc
131 > * <li>The documentation style for testcases is to provide as javadoc
132   * a simple sentence or two describing the property that the testcase
133   * method purports to test. The javadocs do not say anything about how
134 < * the property is tested. To find out, read the code.</li>
134 > * the property is tested. To find out, read the code.
135   *
136 < * <li> These tests are "conformance tests", and do not attempt to
136 > * <li>These tests are "conformance tests", and do not attempt to
137   * test throughput, latency, scalability or other performance factors
138   * (see the separate "jtreg" tests for a set intended to check these
139   * for the most central aspects of functionality.) So, most tests use
140   * the smallest sensible numbers of threads, collection sizes, etc
141 < * needed to check basic conformance.</li>
141 > * needed to check basic conformance.
142   *
143   * <li>The test classes currently do not declare inclusion in
144   * any particular package to simplify things for people integrating
145 < * them in TCK test suites.</li>
145 > * them in TCK test suites.
146   *
147 < * <li> As a convenience, the {@code main} of this class (JSR166TestCase)
148 < * runs all JSR166 unit tests.</li>
147 > * <li>As a convenience, the {@code main} of this class (JSR166TestCase)
148 > * runs all JSR166 unit tests.
149   *
150   * </ul>
151   */
# Line 160 | Line 184 | public class JSR166TestCase extends Test
184          Integer.getInteger("jsr166.runsPerTest", 1);
185  
186      /**
187 +     * The number of repetitions of the test suite (for finding leaks?).
188 +     */
189 +    private static final int suiteRuns =
190 +        Integer.getInteger("jsr166.suiteRuns", 1);
191 +
192 +    /**
193 +     * Returns the value of the system property, or NaN if not defined.
194 +     */
195 +    private static float systemPropertyValue(String name) {
196 +        String floatString = System.getProperty(name);
197 +        if (floatString == null)
198 +            return Float.NaN;
199 +        try {
200 +            return Float.parseFloat(floatString);
201 +        } catch (NumberFormatException ex) {
202 +            throw new IllegalArgumentException(
203 +                String.format("Bad float value in system property %s=%s",
204 +                              name, floatString));
205 +        }
206 +    }
207 +
208 +    /**
209 +     * The scaling factor to apply to standard delays used in tests.
210 +     * May be initialized from any of:
211 +     * - the "jsr166.delay.factor" system property
212 +     * - the "test.timeout.factor" system property (as used by jtreg)
213 +     *   See: http://openjdk.java.net/jtreg/tag-spec.html
214 +     * - hard-coded fuzz factor when using a known slowpoke VM
215 +     */
216 +    private static final float delayFactor = delayFactor();
217 +
218 +    private static float delayFactor() {
219 +        float x;
220 +        if (!Float.isNaN(x = systemPropertyValue("jsr166.delay.factor")))
221 +            return x;
222 +        if (!Float.isNaN(x = systemPropertyValue("test.timeout.factor")))
223 +            return x;
224 +        String prop = System.getProperty("java.vm.version");
225 +        if (prop != null && prop.matches(".*debug.*"))
226 +            return 4.0f; // How much slower is fastdebug than product?!
227 +        return 1.0f;
228 +    }
229 +
230 +    public JSR166TestCase() { super(); }
231 +    public JSR166TestCase(String name) { super(name); }
232 +
233 +    /**
234       * A filter for tests to run, matching strings of the form
235       * methodName(className), e.g. "testInvokeAll5(ForkJoinPoolTest)"
236       * Usefully combined with jsr166.runsPerTest.
# Line 171 | Line 242 | public class JSR166TestCase extends Test
242          return (regex == null) ? null : Pattern.compile(regex);
243      }
244  
245 <    protected void runTest() throws Throwable {
245 >    // Instrumentation to debug very rare, but very annoying hung test runs.
246 >    static volatile TestCase currentTestCase;
247 >    // static volatile int currentRun = 0;
248 >    static {
249 >        Runnable checkForWedgedTest = new Runnable() { public void run() {
250 >            // Avoid spurious reports with enormous runsPerTest.
251 >            // A single test case run should never take more than 1 second.
252 >            // But let's cap it at the high end too ...
253 >            final int timeoutMinutes =
254 >                Math.min(15, Math.max(runsPerTest / 60, 1));
255 >            for (TestCase lastTestCase = currentTestCase;;) {
256 >                try { MINUTES.sleep(timeoutMinutes); }
257 >                catch (InterruptedException unexpected) { break; }
258 >                if (lastTestCase == currentTestCase) {
259 >                    System.err.printf(
260 >                        "Looks like we're stuck running test: %s%n",
261 >                        lastTestCase);
262 > //                     System.err.printf(
263 > //                         "Looks like we're stuck running test: %s (%d/%d)%n",
264 > //                         lastTestCase, currentRun, runsPerTest);
265 > //                     System.err.println("availableProcessors=" +
266 > //                         Runtime.getRuntime().availableProcessors());
267 > //                     System.err.printf("cpu model = %s%n", cpuModel());
268 >                    dumpTestThreads();
269 >                    // one stack dump is probably enough; more would be spam
270 >                    break;
271 >                }
272 >                lastTestCase = currentTestCase;
273 >            }}};
274 >        Thread thread = new Thread(checkForWedgedTest, "checkForWedgedTest");
275 >        thread.setDaemon(true);
276 >        thread.start();
277 >    }
278 >
279 > //     public static String cpuModel() {
280 > //         try {
281 > //             Matcher matcher = Pattern.compile("model name\\s*: (.*)")
282 > //                 .matcher(new String(
283 > //                      Files.readAllBytes(Paths.get("/proc/cpuinfo")), "UTF-8"));
284 > //             matcher.find();
285 > //             return matcher.group(1);
286 > //         } catch (Exception ex) { return null; }
287 > //     }
288 >
289 >    public void runBare() throws Throwable {
290 >        currentTestCase = this;
291          if (methodFilter == null
292 <            || methodFilter.matcher(toString()).find()) {
293 <            for (int i = 0; i < runsPerTest; i++) {
294 <                if (profileTests)
295 <                    runTestProfiled();
296 <                else
297 <                    super.runTest();
298 <            }
292 >            || methodFilter.matcher(toString()).find())
293 >            super.runBare();
294 >    }
295 >
296 >    protected void runTest() throws Throwable {
297 >        for (int i = 0; i < runsPerTest; i++) {
298 >            // currentRun = i;
299 >            if (profileTests)
300 >                runTestProfiled();
301 >            else
302 >                super.runTest();
303          }
304      }
305  
306      protected void runTestProfiled() throws Throwable {
307 <        // Warmup run, notably to trigger all needed classloading.
308 <        super.runTest();
189 <        long t0 = System.nanoTime();
190 <        try {
307 >        for (int i = 0; i < 2; i++) {
308 >            long startTime = System.nanoTime();
309              super.runTest();
310 <        } finally {
311 <            long elapsedMillis = millisElapsedSince(t0);
312 <            if (elapsedMillis >= profileThreshold)
310 >            long elapsedMillis = millisElapsedSince(startTime);
311 >            if (elapsedMillis < profileThreshold)
312 >                break;
313 >            // Never report first run of any test; treat it as a
314 >            // warmup run, notably to trigger all needed classloading,
315 >            if (i > 0)
316                  System.out.printf("%n%s: %d%n", toString(), elapsedMillis);
317          }
318      }
319  
320      /**
321       * Runs all JSR166 unit tests using junit.textui.TestRunner.
201     * Optional command line arg provides the number of iterations to
202     * repeat running the tests.
322       */
323      public static void main(String[] args) {
324 +        main(suite(), args);
325 +    }
326 +
327 +    static class PithyResultPrinter extends junit.textui.ResultPrinter {
328 +        PithyResultPrinter(java.io.PrintStream writer) { super(writer); }
329 +        long runTime;
330 +        public void startTest(Test test) {}
331 +        protected void printHeader(long runTime) {
332 +            this.runTime = runTime; // defer printing for later
333 +        }
334 +        protected void printFooter(TestResult result) {
335 +            if (result.wasSuccessful()) {
336 +                getWriter().println("OK (" + result.runCount() + " tests)"
337 +                    + "  Time: " + elapsedTimeAsString(runTime));
338 +            } else {
339 +                getWriter().println("Time: " + elapsedTimeAsString(runTime));
340 +                super.printFooter(result);
341 +            }
342 +        }
343 +    }
344 +
345 +    /**
346 +     * Returns a TestRunner that doesn't bother with unnecessary
347 +     * fluff, like printing a "." for each test case.
348 +     */
349 +    static junit.textui.TestRunner newPithyTestRunner() {
350 +        junit.textui.TestRunner runner = new junit.textui.TestRunner();
351 +        runner.setPrinter(new PithyResultPrinter(System.out));
352 +        return runner;
353 +    }
354 +
355 +    /**
356 +     * Runs all unit tests in the given test suite.
357 +     * Actual behavior influenced by jsr166.* system properties.
358 +     */
359 +    static void main(Test suite, String[] args) {
360          if (useSecurityManager) {
361              System.err.println("Setting a permissive security manager");
362              Policy.setPolicy(permissivePolicy());
363              System.setSecurityManager(new SecurityManager());
364          }
365 <        int iters = (args.length == 0) ? 1 : Integer.parseInt(args[0]);
366 <
367 <        Test s = suite();
368 <        for (int i = 0; i < iters; ++i) {
214 <            junit.textui.TestRunner.run(s);
365 >        for (int i = 0; i < suiteRuns; i++) {
366 >            TestResult result = newPithyTestRunner().doRun(suite);
367 >            if (!result.wasSuccessful())
368 >                System.exit(1);
369              System.gc();
370              System.runFinalization();
371          }
218        System.exit(0);
372      }
373  
374      public static TestSuite newTestSuite(Object... suiteOrClasses) {
# Line 265 | Line 418 | public class JSR166TestCase extends Test
418      public static boolean atLeastJava6() { return JAVA_CLASS_VERSION >= 50.0; }
419      public static boolean atLeastJava7() { return JAVA_CLASS_VERSION >= 51.0; }
420      public static boolean atLeastJava8() { return JAVA_CLASS_VERSION >= 52.0; }
421 <    public static boolean atLeastJava9() { return JAVA_CLASS_VERSION >= 53.0; }
421 >    public static boolean atLeastJava9() {
422 >        return JAVA_CLASS_VERSION >= 53.0
423 >            // As of 2015-09, java9 still uses 52.0 class file version
424 >            || JAVA_SPECIFICATION_VERSION.matches("^(1\\.)?(9|[0-9][0-9])$");
425 >    }
426 >    public static boolean atLeastJava10() {
427 >        return JAVA_CLASS_VERSION >= 54.0
428 >            || JAVA_SPECIFICATION_VERSION.matches("^(1\\.)?[0-9][0-9]$");
429 >    }
430  
431      /**
432       * Collects all JSR166 unit tests as one suite.
# Line 286 | Line 447 | public class JSR166TestCase extends Test
447              AbstractQueuedLongSynchronizerTest.suite(),
448              ArrayBlockingQueueTest.suite(),
449              ArrayDequeTest.suite(),
450 +            ArrayListTest.suite(),
451              AtomicBooleanTest.suite(),
452              AtomicIntegerArrayTest.suite(),
453              AtomicIntegerFieldUpdaterTest.suite(),
# Line 308 | Line 470 | public class JSR166TestCase extends Test
470              CopyOnWriteArrayListTest.suite(),
471              CopyOnWriteArraySetTest.suite(),
472              CountDownLatchTest.suite(),
473 +            CountedCompleterTest.suite(),
474              CyclicBarrierTest.suite(),
475              DelayQueueTest.suite(),
476              EntryTest.suite(),
# Line 341 | Line 504 | public class JSR166TestCase extends Test
504          // Java8+ test classes
505          if (atLeastJava8()) {
506              String[] java8TestClassNames = {
507 +                "ArrayDeque8Test",
508                  "Atomic8Test",
509                  "CompletableFutureTest",
510                  "ConcurrentHashMap8Test",
511 <                "CountedCompleterTest",
511 >                "CountedCompleter8Test",
512                  "DoubleAccumulatorTest",
513                  "DoubleAdderTest",
514                  "ForkJoinPool8Test",
# Line 353 | Line 517 | public class JSR166TestCase extends Test
517                  "LongAdderTest",
518                  "SplittableRandomTest",
519                  "StampedLockTest",
520 +                "SubmissionPublisherTest",
521                  "ThreadLocalRandom8Test",
522 +                "TimeUnit8Test",
523              };
524              addNamedTestClasses(suite, java8TestClassNames);
525          }
# Line 361 | Line 527 | public class JSR166TestCase extends Test
527          // Java9+ test classes
528          if (atLeastJava9()) {
529              String[] java9TestClassNames = {
530 <                "ThreadPoolExecutor9Test",
530 >                "AtomicBoolean9Test",
531 >                "AtomicInteger9Test",
532 >                "AtomicIntegerArray9Test",
533 >                "AtomicLong9Test",
534 >                "AtomicLongArray9Test",
535 >                "AtomicReference9Test",
536 >                "AtomicReferenceArray9Test",
537 >                "ExecutorCompletionService9Test",
538              };
539              addNamedTestClasses(suite, java9TestClassNames);
540          }
# Line 369 | Line 542 | public class JSR166TestCase extends Test
542          return suite;
543      }
544  
545 +    /** Returns list of junit-style test method names in given class. */
546 +    public static ArrayList<String> testMethodNames(Class<?> testClass) {
547 +        Method[] methods = testClass.getDeclaredMethods();
548 +        ArrayList<String> names = new ArrayList<String>(methods.length);
549 +        for (Method method : methods) {
550 +            if (method.getName().startsWith("test")
551 +                && Modifier.isPublic(method.getModifiers())
552 +                // method.getParameterCount() requires jdk8+
553 +                && method.getParameterTypes().length == 0) {
554 +                names.add(method.getName());
555 +            }
556 +        }
557 +        return names;
558 +    }
559 +
560 +    /**
561 +     * Returns junit-style testSuite for the given test class, but
562 +     * parameterized by passing extra data to each test.
563 +     */
564 +    public static <ExtraData> Test parameterizedTestSuite
565 +        (Class<? extends JSR166TestCase> testClass,
566 +         Class<ExtraData> dataClass,
567 +         ExtraData data) {
568 +        try {
569 +            TestSuite suite = new TestSuite();
570 +            Constructor c =
571 +                testClass.getDeclaredConstructor(dataClass, String.class);
572 +            for (String methodName : testMethodNames(testClass))
573 +                suite.addTest((Test) c.newInstance(data, methodName));
574 +            return suite;
575 +        } catch (Exception e) {
576 +            throw new Error(e);
577 +        }
578 +    }
579 +
580 +    /**
581 +     * Returns junit-style testSuite for the jdk8 extension of the
582 +     * given test class, but parameterized by passing extra data to
583 +     * each test.  Uses reflection to allow compilation in jdk7.
584 +     */
585 +    public static <ExtraData> Test jdk8ParameterizedTestSuite
586 +        (Class<? extends JSR166TestCase> testClass,
587 +         Class<ExtraData> dataClass,
588 +         ExtraData data) {
589 +        if (atLeastJava8()) {
590 +            String name = testClass.getName();
591 +            String name8 = name.replaceAll("Test$", "8Test");
592 +            if (name.equals(name8)) throw new Error(name);
593 +            try {
594 +                return (Test)
595 +                    Class.forName(name8)
596 +                    .getMethod("testSuite", new Class[] { dataClass })
597 +                    .invoke(null, data);
598 +            } catch (Exception e) {
599 +                throw new Error(e);
600 +            }
601 +        } else {
602 +            return new TestSuite();
603 +        }
604 +    }
605 +
606      // Delays for timing-dependent tests, in milliseconds.
607  
608      public static long SHORT_DELAY_MS;
# Line 377 | Line 611 | public class JSR166TestCase extends Test
611      public static long LONG_DELAY_MS;
612  
613      /**
614 <     * Returns the shortest timed delay. This could
615 <     * be reimplemented to use for example a Property.
614 >     * Returns the shortest timed delay. This can be scaled up for
615 >     * slow machines using the jsr166.delay.factor system property,
616 >     * or via jtreg's -timeoutFactor: flag.
617 >     * http://openjdk.java.net/jtreg/command-help.html
618       */
619      protected long getShortDelay() {
620 <        return 50;
620 >        return (long) (50 * delayFactor);
621      }
622  
623      /**
# Line 403 | Line 639 | public class JSR166TestCase extends Test
639      }
640  
641      /**
642 <     * Returns a new Date instance representing a time delayMillis
643 <     * milliseconds in the future.
642 >     * Returns a new Date instance representing a time at least
643 >     * delayMillis milliseconds in the future.
644       */
645      Date delayedDate(long delayMillis) {
646 <        return new Date(System.currentTimeMillis() + delayMillis);
646 >        // Add 1 because currentTimeMillis is known to round into the past.
647 >        return new Date(System.currentTimeMillis() + delayMillis + 1);
648      }
649  
650      /**
# Line 423 | Line 660 | public class JSR166TestCase extends Test
660       * the same test have no effect.
661       */
662      public void threadRecordFailure(Throwable t) {
663 +        System.err.println(t);
664 +        dumpTestThreads();
665          threadFailure.compareAndSet(null, t);
666      }
667  
# Line 430 | Line 669 | public class JSR166TestCase extends Test
669          setDelays();
670      }
671  
672 +    void tearDownFail(String format, Object... args) {
673 +        String msg = toString() + ": " + String.format(format, args);
674 +        System.err.println(msg);
675 +        dumpTestThreads();
676 +        throw new AssertionFailedError(msg);
677 +    }
678 +
679      /**
680       * Extra checks that get done for all test cases.
681       *
# Line 457 | Line 703 | public class JSR166TestCase extends Test
703          }
704  
705          if (Thread.interrupted())
706 <            throw new AssertionFailedError("interrupt status set in main thread");
706 >            tearDownFail("interrupt status set in main thread");
707  
708          checkForkJoinPoolThreadLeaks();
709      }
710  
711      /**
712 <     * Finds missing try { ... } finally { joinPool(e); }
712 >     * Finds missing PoolCleaners
713       */
714      void checkForkJoinPoolThreadLeaks() throws InterruptedException {
715 <        Thread[] survivors = new Thread[5];
715 >        Thread[] survivors = new Thread[7];
716          int count = Thread.enumerate(survivors);
717          for (int i = 0; i < count; i++) {
718              Thread thread = survivors[i];
# Line 474 | Line 720 | public class JSR166TestCase extends Test
720              if (name.startsWith("ForkJoinPool-")) {
721                  // give thread some time to terminate
722                  thread.join(LONG_DELAY_MS);
723 <                if (!thread.isAlive()) continue;
724 <                thread.stop();
725 <                throw new AssertionFailedError
480 <                    (String.format("Found leaked ForkJoinPool thread test=%s thread=%s%n",
481 <                                   toString(), name));
723 >                if (thread.isAlive())
724 >                    tearDownFail("Found leaked ForkJoinPool thread thread=%s",
725 >                                 thread);
726              }
727          }
728 +
729 +        if (!ForkJoinPool.commonPool()
730 +            .awaitQuiescence(LONG_DELAY_MS, MILLISECONDS))
731 +            tearDownFail("ForkJoin common pool thread stuck");
732      }
733  
734      /**
# Line 493 | Line 741 | public class JSR166TestCase extends Test
741              fail(reason);
742          } catch (AssertionFailedError t) {
743              threadRecordFailure(t);
744 <            fail(reason);
744 >            throw t;
745          }
746      }
747  
# Line 620 | Line 868 | public class JSR166TestCase extends Test
868      /**
869       * Delays, via Thread.sleep, for the given millisecond delay, but
870       * if the sleep is shorter than specified, may re-sleep or yield
871 <     * until time elapses.
871 >     * until time elapses.  Ensures that the given time, as measured
872 >     * by System.nanoTime(), has elapsed.
873       */
874      static void delay(long millis) throws InterruptedException {
875 <        long startTime = System.nanoTime();
876 <        long ns = millis * 1000 * 1000;
877 <        for (;;) {
875 >        long nanos = millis * (1000 * 1000);
876 >        final long wakeupTime = System.nanoTime() + nanos;
877 >        do {
878              if (millis > 0L)
879                  Thread.sleep(millis);
880              else // too short to sleep
881                  Thread.yield();
882 <            long d = ns - (System.nanoTime() - startTime);
883 <            if (d > 0L)
884 <                millis = d / (1000 * 1000);
885 <            else
886 <                break;
882 >            nanos = wakeupTime - System.nanoTime();
883 >            millis = nanos / (1000 * 1000);
884 >        } while (nanos >= 0L);
885 >    }
886 >
887 >    /**
888 >     * Allows use of try-with-resources with per-test thread pools.
889 >     */
890 >    class PoolCleaner implements AutoCloseable {
891 >        private final ExecutorService pool;
892 >        public PoolCleaner(ExecutorService pool) { this.pool = pool; }
893 >        public void close() { joinPool(pool); }
894 >    }
895 >
896 >    /**
897 >     * An extension of PoolCleaner that has an action to release the pool.
898 >     */
899 >    class PoolCleanerWithReleaser extends PoolCleaner {
900 >        private final Runnable releaser;
901 >        public PoolCleanerWithReleaser(ExecutorService pool, Runnable releaser) {
902 >            super(pool);
903 >            this.releaser = releaser;
904 >        }
905 >        public void close() {
906 >            try {
907 >                releaser.run();
908 >            } finally {
909 >                super.close();
910 >            }
911          }
912      }
913  
914 +    PoolCleaner cleaner(ExecutorService pool) {
915 +        return new PoolCleaner(pool);
916 +    }
917 +
918 +    PoolCleaner cleaner(ExecutorService pool, Runnable releaser) {
919 +        return new PoolCleanerWithReleaser(pool, releaser);
920 +    }
921 +
922 +    PoolCleaner cleaner(ExecutorService pool, CountDownLatch latch) {
923 +        return new PoolCleanerWithReleaser(pool, releaser(latch));
924 +    }
925 +
926 +    Runnable releaser(final CountDownLatch latch) {
927 +        return new Runnable() { public void run() {
928 +            do { latch.countDown(); }
929 +            while (latch.getCount() > 0);
930 +        }};
931 +    }
932 +
933 +    PoolCleaner cleaner(ExecutorService pool, AtomicBoolean flag) {
934 +        return new PoolCleanerWithReleaser(pool, releaser(flag));
935 +    }
936 +
937 +    Runnable releaser(final AtomicBoolean flag) {
938 +        return new Runnable() { public void run() { flag.set(true); }};
939 +    }
940 +
941      /**
942       * Waits out termination of a thread pool or fails doing so.
943       */
944 <    void joinPool(ExecutorService exec) {
944 >    void joinPool(ExecutorService pool) {
945          try {
946 <            exec.shutdown();
947 <            if (!exec.awaitTermination(2 * LONG_DELAY_MS, MILLISECONDS))
948 <                fail("ExecutorService " + exec +
949 <                     " did not terminate in a timely manner");
946 >            pool.shutdown();
947 >            if (!pool.awaitTermination(2 * LONG_DELAY_MS, MILLISECONDS)) {
948 >                try {
949 >                    threadFail("ExecutorService " + pool +
950 >                               " did not terminate in a timely manner");
951 >                } finally {
952 >                    // last resort, for the benefit of subsequent tests
953 >                    pool.shutdownNow();
954 >                    pool.awaitTermination(MEDIUM_DELAY_MS, MILLISECONDS);
955 >                }
956 >            }
957          } catch (SecurityException ok) {
958              // Allowed in case test doesn't have privs
959          } catch (InterruptedException fail) {
960 <            fail("Unexpected InterruptedException");
960 >            threadFail("Unexpected InterruptedException");
961          }
962      }
963  
964      /**
965 <     * A debugging tool to print all stack traces, as jstack does.
965 >     * Like Runnable, but with the freedom to throw anything.
966 >     * junit folks had the same idea:
967 >     * http://junit.org/junit5/docs/snapshot/api/org/junit/gen5/api/Executable.html
968       */
969 <    static void printAllStackTraces() {
970 <        for (ThreadInfo info :
971 <                 ManagementFactory.getThreadMXBean()
972 <                 .dumpAllThreads(true, true))
969 >    interface Action { public void run() throws Throwable; }
970 >
971 >    /**
972 >     * Runs all the given actions in parallel, failing if any fail.
973 >     * Useful for running multiple variants of tests that are
974 >     * necessarily individually slow because they must block.
975 >     */
976 >    void testInParallel(Action ... actions) {
977 >        ExecutorService pool = Executors.newCachedThreadPool();
978 >        try (PoolCleaner cleaner = cleaner(pool)) {
979 >            ArrayList<Future<?>> futures = new ArrayList<>(actions.length);
980 >            for (final Action action : actions)
981 >                futures.add(pool.submit(new CheckedRunnable() {
982 >                    public void realRun() throws Throwable { action.run();}}));
983 >            for (Future<?> future : futures)
984 >                try {
985 >                    assertNull(future.get(LONG_DELAY_MS, MILLISECONDS));
986 >                } catch (ExecutionException ex) {
987 >                    threadUnexpectedException(ex.getCause());
988 >                } catch (Exception ex) {
989 >                    threadUnexpectedException(ex);
990 >                }
991 >        }
992 >    }
993 >
994 >    /**
995 >     * A debugging tool to print stack traces of most threads, as jstack does.
996 >     * Uninteresting threads are filtered out.
997 >     */
998 >    static void dumpTestThreads() {
999 >        SecurityManager sm = System.getSecurityManager();
1000 >        if (sm != null) {
1001 >            try {
1002 >                System.setSecurityManager(null);
1003 >            } catch (SecurityException giveUp) {
1004 >                return;
1005 >            }
1006 >        }
1007 >
1008 >        ThreadMXBean threadMXBean = ManagementFactory.getThreadMXBean();
1009 >        System.err.println("------ stacktrace dump start ------");
1010 >        for (ThreadInfo info : threadMXBean.dumpAllThreads(true, true)) {
1011 >            final String name = info.getThreadName();
1012 >            String lockName;
1013 >            if ("Signal Dispatcher".equals(name))
1014 >                continue;
1015 >            if ("Reference Handler".equals(name)
1016 >                && (lockName = info.getLockName()) != null
1017 >                && lockName.startsWith("java.lang.ref.Reference$Lock"))
1018 >                continue;
1019 >            if ("Finalizer".equals(name)
1020 >                && (lockName = info.getLockName()) != null
1021 >                && lockName.startsWith("java.lang.ref.ReferenceQueue$Lock"))
1022 >                continue;
1023 >            if ("checkForWedgedTest".equals(name))
1024 >                continue;
1025              System.err.print(info);
1026 +        }
1027 +        System.err.println("------ stacktrace dump end ------");
1028 +
1029 +        if (sm != null) System.setSecurityManager(sm);
1030      }
1031  
1032      /**
# Line 681 | Line 1046 | public class JSR166TestCase extends Test
1046              delay(millis);
1047              assertTrue(thread.isAlive());
1048          } catch (InterruptedException fail) {
1049 <            fail("Unexpected InterruptedException");
1049 >            threadFail("Unexpected InterruptedException");
1050          }
1051      }
1052  
# Line 703 | Line 1068 | public class JSR166TestCase extends Test
1068              for (Thread thread : threads)
1069                  assertTrue(thread.isAlive());
1070          } catch (InterruptedException fail) {
1071 <            fail("Unexpected InterruptedException");
1071 >            threadFail("Unexpected InterruptedException");
1072          }
1073      }
1074  
# Line 878 | Line 1243 | public class JSR166TestCase extends Test
1243       * Sleeps until the given time has elapsed.
1244       * Throws AssertionFailedError if interrupted.
1245       */
1246 <    void sleep(long millis) {
1246 >    static void sleep(long millis) {
1247          try {
1248              delay(millis);
1249          } catch (InterruptedException fail) {
# Line 894 | Line 1259 | public class JSR166TestCase extends Test
1259       * thread to enter a wait state: BLOCKED, WAITING, or TIMED_WAITING.
1260       */
1261      void waitForThreadToEnterWaitState(Thread thread, long timeoutMillis) {
1262 <        long startTime = System.nanoTime();
1262 >        long startTime = 0L;
1263          for (;;) {
1264              Thread.State s = thread.getState();
1265              if (s == Thread.State.BLOCKED ||
# Line 903 | Line 1268 | public class JSR166TestCase extends Test
1268                  return;
1269              else if (s == Thread.State.TERMINATED)
1270                  fail("Unexpected thread termination");
1271 +            else if (startTime == 0L)
1272 +                startTime = System.nanoTime();
1273              else if (millisElapsedSince(startTime) > timeoutMillis) {
1274                  threadAssertTrue(thread.isAlive());
1275                  return;
# Line 981 | Line 1348 | public class JSR166TestCase extends Test
1348          } finally {
1349              if (t.getState() != Thread.State.TERMINATED) {
1350                  t.interrupt();
1351 <                fail("Test timed out");
1351 >                threadFail("timed out waiting for thread to terminate");
1352              }
1353          }
1354      }
# Line 1106 | Line 1473 | public class JSR166TestCase extends Test
1473      public static final String TEST_STRING = "a test string";
1474  
1475      public static class StringTask implements Callable<String> {
1476 <        public String call() { return TEST_STRING; }
1476 >        final String value;
1477 >        public StringTask() { this(TEST_STRING); }
1478 >        public StringTask(String value) { this.value = value; }
1479 >        public String call() { return value; }
1480      }
1481  
1482      public Callable<String> latchAwaitingStringTask(final CountDownLatch latch) {
# Line 1119 | Line 1489 | public class JSR166TestCase extends Test
1489              }};
1490      }
1491  
1492 <    public Runnable awaiter(final CountDownLatch latch) {
1492 >    public Runnable countDowner(final CountDownLatch latch) {
1493          return new CheckedRunnable() {
1494              public void realRun() throws InterruptedException {
1495 <                await(latch);
1495 >                latch.countDown();
1496              }};
1497      }
1498  
1499 <    public void await(CountDownLatch latch) {
1499 >    class LatchAwaiter extends CheckedRunnable {
1500 >        static final int NEW = 0;
1501 >        static final int RUNNING = 1;
1502 >        static final int DONE = 2;
1503 >        final CountDownLatch latch;
1504 >        int state = NEW;
1505 >        LatchAwaiter(CountDownLatch latch) { this.latch = latch; }
1506 >        public void realRun() throws InterruptedException {
1507 >            state = 1;
1508 >            await(latch);
1509 >            state = 2;
1510 >        }
1511 >    }
1512 >
1513 >    public LatchAwaiter awaiter(CountDownLatch latch) {
1514 >        return new LatchAwaiter(latch);
1515 >    }
1516 >
1517 >    public void await(CountDownLatch latch, long timeoutMillis) {
1518          try {
1519 <            assertTrue(latch.await(LONG_DELAY_MS, MILLISECONDS));
1519 >            if (!latch.await(timeoutMillis, MILLISECONDS))
1520 >                fail("timed out waiting for CountDownLatch for "
1521 >                     + (timeoutMillis/1000) + " sec");
1522          } catch (Throwable fail) {
1523              threadUnexpectedException(fail);
1524          }
1525      }
1526  
1527 +    public void await(CountDownLatch latch) {
1528 +        await(latch, LONG_DELAY_MS);
1529 +    }
1530 +
1531      public void await(Semaphore semaphore) {
1532          try {
1533 <            assertTrue(semaphore.tryAcquire(LONG_DELAY_MS, MILLISECONDS));
1533 >            if (!semaphore.tryAcquire(LONG_DELAY_MS, MILLISECONDS))
1534 >                fail("timed out waiting for Semaphore for "
1535 >                     + (LONG_DELAY_MS/1000) + " sec");
1536          } catch (Throwable fail) {
1537              threadUnexpectedException(fail);
1538          }
# Line 1366 | Line 1762 | public class JSR166TestCase extends Test
1762       * A CyclicBarrier that uses timed await and fails with
1763       * AssertionFailedErrors instead of throwing checked exceptions.
1764       */
1765 <    public class CheckedBarrier extends CyclicBarrier {
1765 >    public static class CheckedBarrier extends CyclicBarrier {
1766          public CheckedBarrier(int parties) { super(parties); }
1767  
1768          public int await() {
# Line 1472 | Line 1868 | public class JSR166TestCase extends Test
1868          } catch (NoSuchElementException success) {}
1869          assertFalse(it.hasNext());
1870      }
1871 +
1872 +    public <T> Callable<T> callableThrowing(final Exception ex) {
1873 +        return new Callable<T>() { public T call() throws Exception { throw ex; }};
1874 +    }
1875 +
1876 +    public Runnable runnableThrowing(final RuntimeException ex) {
1877 +        return new Runnable() { public void run() { throw ex; }};
1878 +    }
1879 +
1880 +    /** A reusable thread pool to be shared by tests. */
1881 +    static final ExecutorService cachedThreadPool =
1882 +        new ThreadPoolExecutor(0, Integer.MAX_VALUE,
1883 +                               1000L, MILLISECONDS,
1884 +                               new SynchronousQueue<Runnable>());
1885 +
1886 +    static <T> void shuffle(T[] array) {
1887 +        Collections.shuffle(Arrays.asList(array), ThreadLocalRandom.current());
1888 +    }
1889   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines