ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/JSR166TestCase.java
(Generate patch)

Comparing jsr166/src/test/tck/JSR166TestCase.java (file contents):
Revision 1.195 by jsr166, Sat Jun 4 23:49:29 2016 UTC vs.
Revision 1.265 by jsr166, Sat Sep 7 15:03:44 2019 UTC

# Line 1 | Line 1
1   /*
2 < * Written by Doug Lea with assistance from members of JCP JSR-166
3 < * Expert Group and released to the public domain, as explained at
2 > * Written by Doug Lea and Martin Buchholz with assistance from
3 > * members of JCP JSR-166 Expert Group and released to the public
4 > * domain, as explained at
5   * http://creativecommons.org/publicdomain/zero/1.0/
6   * Other contributors include Andrew Wright, Jeffrey Hayes,
7   * Pat Fisher, Mike Judd.
# Line 8 | Line 9
9  
10   /*
11   * @test
12 < * @summary JSR-166 tck tests
13 < * @modules java.management
12 > * @summary JSR-166 tck tests, in a number of variations.
13 > *          The first is the conformance testing variant,
14 > *          while others also test implementation details.
15   * @build *
16 < * @run junit/othervm/timeout=1000 -Djsr166.testImplementationDetails=true JSR166TestCase
17 < * @run junit/othervm/timeout=1000 -Djava.util.concurrent.ForkJoinPool.common.parallelism=0 -Djsr166.testImplementationDetails=true JSR166TestCase
16 > * @modules java.management
17 > * @run junit/othervm/timeout=1000 JSR166TestCase
18 > * @run junit/othervm/timeout=1000
19 > *      --add-opens java.base/java.util.concurrent=ALL-UNNAMED
20 > *      --add-opens java.base/java.lang=ALL-UNNAMED
21 > *      -Djsr166.testImplementationDetails=true
22 > *      JSR166TestCase
23 > * @run junit/othervm/timeout=1000
24 > *      --add-opens java.base/java.util.concurrent=ALL-UNNAMED
25 > *      --add-opens java.base/java.lang=ALL-UNNAMED
26 > *      -Djsr166.testImplementationDetails=true
27 > *      -Djava.util.concurrent.ForkJoinPool.common.parallelism=0
28 > *      JSR166TestCase
29 > * @run junit/othervm/timeout=1000
30 > *      --add-opens java.base/java.util.concurrent=ALL-UNNAMED
31 > *      --add-opens java.base/java.lang=ALL-UNNAMED
32 > *      -Djsr166.testImplementationDetails=true
33 > *      -Djava.util.concurrent.ForkJoinPool.common.parallelism=1
34 > *      -Djava.util.secureRandomSeed=true
35 > *      JSR166TestCase
36 > * @run junit/othervm/timeout=1000/policy=tck.policy
37 > *      --add-opens java.base/java.util.concurrent=ALL-UNNAMED
38 > *      --add-opens java.base/java.lang=ALL-UNNAMED
39 > *      -Djsr166.testImplementationDetails=true
40 > *      JSR166TestCase
41   */
42  
43   import static java.util.concurrent.TimeUnit.MILLISECONDS;
# Line 29 | Line 54 | import java.lang.management.ThreadMXBean
54   import java.lang.reflect.Constructor;
55   import java.lang.reflect.Method;
56   import java.lang.reflect.Modifier;
32 import java.nio.file.Files;
33 import java.nio.file.Paths;
57   import java.security.CodeSource;
58   import java.security.Permission;
59   import java.security.PermissionCollection;
# Line 40 | Line 63 | import java.security.ProtectionDomain;
63   import java.security.SecurityPermission;
64   import java.util.ArrayList;
65   import java.util.Arrays;
66 + import java.util.Collection;
67 + import java.util.Collections;
68   import java.util.Date;
69 + import java.util.Deque;
70   import java.util.Enumeration;
71 + import java.util.HashSet;
72   import java.util.Iterator;
73   import java.util.List;
74   import java.util.NoSuchElementException;
75   import java.util.PropertyPermission;
76 + import java.util.Set;
77   import java.util.concurrent.BlockingQueue;
78   import java.util.concurrent.Callable;
79   import java.util.concurrent.CountDownLatch;
80   import java.util.concurrent.CyclicBarrier;
81   import java.util.concurrent.ExecutionException;
82 + import java.util.concurrent.Executor;
83   import java.util.concurrent.Executors;
84   import java.util.concurrent.ExecutorService;
85   import java.util.concurrent.ForkJoinPool;
86   import java.util.concurrent.Future;
87 + import java.util.concurrent.FutureTask;
88   import java.util.concurrent.RecursiveAction;
89   import java.util.concurrent.RecursiveTask;
90 + import java.util.concurrent.RejectedExecutionException;
91   import java.util.concurrent.RejectedExecutionHandler;
92   import java.util.concurrent.Semaphore;
93 + import java.util.concurrent.ScheduledExecutorService;
94 + import java.util.concurrent.ScheduledFuture;
95   import java.util.concurrent.SynchronousQueue;
96   import java.util.concurrent.ThreadFactory;
97 + import java.util.concurrent.ThreadLocalRandom;
98   import java.util.concurrent.ThreadPoolExecutor;
99 + import java.util.concurrent.TimeUnit;
100   import java.util.concurrent.TimeoutException;
101   import java.util.concurrent.atomic.AtomicBoolean;
102   import java.util.concurrent.atomic.AtomicReference;
68 import java.util.regex.Matcher;
103   import java.util.regex.Pattern;
104  
71 import junit.framework.AssertionFailedError;
105   import junit.framework.Test;
106   import junit.framework.TestCase;
107   import junit.framework.TestResult;
# Line 84 | Line 117 | import junit.framework.TestSuite;
117   *
118   * <ol>
119   *
120 < * <li>All assertions in code running in generated threads must use
121 < * the forms {@link #threadFail}, {@link #threadAssertTrue}, {@link
122 < * #threadAssertEquals}, or {@link #threadAssertNull}, (not
123 < * {@code fail}, {@code assertTrue}, etc.) It is OK (but not
124 < * particularly recommended) for other code to use these forms too.
125 < * Only the most typically used JUnit assertion methods are defined
126 < * this way, but enough to live with.
120 > * <li>All code not running in the main test thread (manually spawned threads
121 > * or the common fork join pool) must be checked for failure (and completion!).
122 > * Mechanisms that can be used to ensure this are:
123 > *   <ol>
124 > *   <li>Signalling via a synchronizer like AtomicInteger or CountDownLatch
125 > *    that the task completed normally, which is checked before returning from
126 > *    the test method in the main thread.
127 > *   <li>Using the forms {@link #threadFail}, {@link #threadAssertTrue},
128 > *    or {@link #threadAssertNull}, (not {@code fail}, {@code assertTrue}, etc.)
129 > *    Only the most typically used JUnit assertion methods are defined
130 > *    this way, but enough to live with.
131 > *   <li>Recording failure explicitly using {@link #threadUnexpectedException}
132 > *    or {@link #threadRecordFailure}.
133 > *   <li>Using a wrapper like CheckedRunnable that uses one the mechanisms above.
134 > *   </ol>
135   *
136   * <li>If you override {@link #setUp} or {@link #tearDown}, make sure
137   * to invoke {@code super.setUp} and {@code super.tearDown} within
# Line 243 | Line 284 | public class JSR166TestCase extends Test
284      static volatile TestCase currentTestCase;
285      // static volatile int currentRun = 0;
286      static {
287 <        Runnable checkForWedgedTest = new Runnable() { public void run() {
287 >        Runnable wedgedTestDetector = new Runnable() { public void run() {
288              // Avoid spurious reports with enormous runsPerTest.
289              // A single test case run should never take more than 1 second.
290              // But let's cap it at the high end too ...
291 <            final int timeoutMinutes =
292 <                Math.min(15, Math.max(runsPerTest / 60, 1));
291 >            final int timeoutMinutesMin = Math.max(runsPerTest / 60, 1)
292 >                * Math.max((int) delayFactor, 1);
293 >            final int timeoutMinutes = Math.min(15, timeoutMinutesMin);
294              for (TestCase lastTestCase = currentTestCase;;) {
295                  try { MINUTES.sleep(timeoutMinutes); }
296                  catch (InterruptedException unexpected) { break; }
# Line 268 | Line 310 | public class JSR166TestCase extends Test
310                  }
311                  lastTestCase = currentTestCase;
312              }}};
313 <        Thread thread = new Thread(checkForWedgedTest, "checkForWedgedTest");
313 >        Thread thread = new Thread(wedgedTestDetector, "WedgedTestDetector");
314          thread.setDaemon(true);
315          thread.start();
316      }
317  
318   //     public static String cpuModel() {
319   //         try {
320 < //             Matcher matcher = Pattern.compile("model name\\s*: (.*)")
320 > //             java.util.regex.Matcher matcher
321 > //               = Pattern.compile("model name\\s*: (.*)")
322   //                 .matcher(new String(
323 < //                      Files.readAllBytes(Paths.get("/proc/cpuinfo")), "UTF-8"));
323 > //                     java.nio.file.Files.readAllBytes(
324 > //                         java.nio.file.Paths.get("/proc/cpuinfo")), "UTF-8"));
325   //             matcher.find();
326   //             return matcher.group(1);
327   //         } catch (Exception ex) { return null; }
# Line 386 | Line 430 | public class JSR166TestCase extends Test
430          for (String testClassName : testClassNames) {
431              try {
432                  Class<?> testClass = Class.forName(testClassName);
433 <                Method m = testClass.getDeclaredMethod("suite",
390 <                                                       new Class<?>[0]);
433 >                Method m = testClass.getDeclaredMethod("suite");
434                  suite.addTest(newTestSuite((Test)m.invoke(null)));
435 <            } catch (Exception e) {
436 <                throw new Error("Missing test class", e);
435 >            } catch (ReflectiveOperationException e) {
436 >                throw new AssertionError("Missing test class", e);
437              }
438          }
439      }
# Line 412 | Line 455 | public class JSR166TestCase extends Test
455          }
456      }
457  
458 <    public static boolean atLeastJava6() { return JAVA_CLASS_VERSION >= 50.0; }
459 <    public static boolean atLeastJava7() { return JAVA_CLASS_VERSION >= 51.0; }
460 <    public static boolean atLeastJava8() { return JAVA_CLASS_VERSION >= 52.0; }
461 <    public static boolean atLeastJava9() {
462 <        return JAVA_CLASS_VERSION >= 53.0
463 <            // As of 2015-09, java9 still uses 52.0 class file version
464 <            || JAVA_SPECIFICATION_VERSION.matches("^(1\\.)?(9|[0-9][0-9])$");
465 <    }
466 <    public static boolean atLeastJava10() {
467 <        return JAVA_CLASS_VERSION >= 54.0
468 <            || JAVA_SPECIFICATION_VERSION.matches("^(1\\.)?[0-9][0-9]$");
469 <    }
458 >    public static boolean atLeastJava6()  { return JAVA_CLASS_VERSION >= 50.0; }
459 >    public static boolean atLeastJava7()  { return JAVA_CLASS_VERSION >= 51.0; }
460 >    public static boolean atLeastJava8()  { return JAVA_CLASS_VERSION >= 52.0; }
461 >    public static boolean atLeastJava9()  { return JAVA_CLASS_VERSION >= 53.0; }
462 >    public static boolean atLeastJava10() { return JAVA_CLASS_VERSION >= 54.0; }
463 >    public static boolean atLeastJava11() { return JAVA_CLASS_VERSION >= 55.0; }
464 >    public static boolean atLeastJava12() { return JAVA_CLASS_VERSION >= 56.0; }
465 >    public static boolean atLeastJava13() { return JAVA_CLASS_VERSION >= 57.0; }
466 >    public static boolean atLeastJava14() { return JAVA_CLASS_VERSION >= 58.0; }
467 >    public static boolean atLeastJava15() { return JAVA_CLASS_VERSION >= 59.0; }
468 >    public static boolean atLeastJava16() { return JAVA_CLASS_VERSION >= 60.0; }
469 >    public static boolean atLeastJava17() { return JAVA_CLASS_VERSION >= 61.0; }
470  
471      /**
472       * Collects all JSR166 unit tests as one suite.
# Line 444 | Line 487 | public class JSR166TestCase extends Test
487              AbstractQueuedLongSynchronizerTest.suite(),
488              ArrayBlockingQueueTest.suite(),
489              ArrayDequeTest.suite(),
490 +            ArrayListTest.suite(),
491              AtomicBooleanTest.suite(),
492              AtomicIntegerArrayTest.suite(),
493              AtomicIntegerFieldUpdaterTest.suite(),
# Line 466 | Line 510 | public class JSR166TestCase extends Test
510              CopyOnWriteArrayListTest.suite(),
511              CopyOnWriteArraySetTest.suite(),
512              CountDownLatchTest.suite(),
513 +            CountedCompleterTest.suite(),
514              CyclicBarrierTest.suite(),
515              DelayQueueTest.suite(),
516              EntryTest.suite(),
# Line 473 | Line 518 | public class JSR166TestCase extends Test
518              ExecutorsTest.suite(),
519              ExecutorCompletionServiceTest.suite(),
520              FutureTaskTest.suite(),
521 +            HashtableTest.suite(),
522              LinkedBlockingDequeTest.suite(),
523              LinkedBlockingQueueTest.suite(),
524              LinkedListTest.suite(),
# Line 494 | Line 540 | public class JSR166TestCase extends Test
540              TreeMapTest.suite(),
541              TreeSetTest.suite(),
542              TreeSubMapTest.suite(),
543 <            TreeSubSetTest.suite());
543 >            TreeSubSetTest.suite(),
544 >            VectorTest.suite());
545  
546          // Java8+ test classes
547          if (atLeastJava8()) {
548              String[] java8TestClassNames = {
549 +                "ArrayDeque8Test",
550                  "Atomic8Test",
551                  "CompletableFutureTest",
552                  "ConcurrentHashMap8Test",
553 <                "CountedCompleterTest",
553 >                "CountedCompleter8Test",
554                  "DoubleAccumulatorTest",
555                  "DoubleAdderTest",
556                  "ForkJoinPool8Test",
557                  "ForkJoinTask8Test",
558 +                "HashMapTest",
559 +                "LinkedBlockingDeque8Test",
560 +                "LinkedBlockingQueue8Test",
561 +                "LinkedHashMapTest",
562                  "LongAccumulatorTest",
563                  "LongAdderTest",
564                  "SplittableRandomTest",
# Line 521 | Line 573 | public class JSR166TestCase extends Test
573          // Java9+ test classes
574          if (atLeastJava9()) {
575              String[] java9TestClassNames = {
576 +                "AtomicBoolean9Test",
577 +                "AtomicInteger9Test",
578 +                "AtomicIntegerArray9Test",
579 +                "AtomicLong9Test",
580 +                "AtomicLongArray9Test",
581 +                "AtomicReference9Test",
582 +                "AtomicReferenceArray9Test",
583                  "ExecutorCompletionService9Test",
584 +                "ForkJoinPool9Test",
585              };
586              addNamedTestClasses(suite, java9TestClassNames);
587          }
# Line 532 | Line 592 | public class JSR166TestCase extends Test
592      /** Returns list of junit-style test method names in given class. */
593      public static ArrayList<String> testMethodNames(Class<?> testClass) {
594          Method[] methods = testClass.getDeclaredMethods();
595 <        ArrayList<String> names = new ArrayList<String>(methods.length);
595 >        ArrayList<String> names = new ArrayList<>(methods.length);
596          for (Method method : methods) {
597              if (method.getName().startsWith("test")
598                  && Modifier.isPublic(method.getModifiers())
# Line 559 | Line 619 | public class JSR166TestCase extends Test
619              for (String methodName : testMethodNames(testClass))
620                  suite.addTest((Test) c.newInstance(data, methodName));
621              return suite;
622 <        } catch (Exception e) {
623 <            throw new Error(e);
622 >        } catch (ReflectiveOperationException e) {
623 >            throw new AssertionError(e);
624          }
625      }
626  
# Line 576 | Line 636 | public class JSR166TestCase extends Test
636          if (atLeastJava8()) {
637              String name = testClass.getName();
638              String name8 = name.replaceAll("Test$", "8Test");
639 <            if (name.equals(name8)) throw new Error(name);
639 >            if (name.equals(name8)) throw new AssertionError(name);
640              try {
641                  return (Test)
642                      Class.forName(name8)
643 <                    .getMethod("testSuite", new Class[] { dataClass })
643 >                    .getMethod("testSuite", dataClass)
644                      .invoke(null, data);
645 <            } catch (Exception e) {
646 <                throw new Error(e);
645 >            } catch (ReflectiveOperationException e) {
646 >                throw new AssertionError(e);
647              }
648          } else {
649              return new TestSuite();
# Line 598 | Line 658 | public class JSR166TestCase extends Test
658      public static long LONG_DELAY_MS;
659  
660      /**
661 +     * A delay significantly longer than LONG_DELAY_MS.
662 +     * Use this in a thread that is waited for via awaitTermination(Thread).
663 +     */
664 +    public static long LONGER_DELAY_MS;
665 +
666 +    private static final long RANDOM_TIMEOUT;
667 +    private static final long RANDOM_EXPIRED_TIMEOUT;
668 +    private static final TimeUnit RANDOM_TIMEUNIT;
669 +    static {
670 +        ThreadLocalRandom rnd = ThreadLocalRandom.current();
671 +        long[] timeouts = { Long.MIN_VALUE, -1, 0, 1, Long.MAX_VALUE };
672 +        RANDOM_TIMEOUT = timeouts[rnd.nextInt(timeouts.length)];
673 +        RANDOM_EXPIRED_TIMEOUT = timeouts[rnd.nextInt(3)];
674 +        TimeUnit[] timeUnits = TimeUnit.values();
675 +        RANDOM_TIMEUNIT = timeUnits[rnd.nextInt(timeUnits.length)];
676 +    }
677 +
678 +    /**
679 +     * Returns a timeout for use when any value at all will do.
680 +     */
681 +    static long randomTimeout() { return RANDOM_TIMEOUT; }
682 +
683 +    /**
684 +     * Returns a timeout that means "no waiting", i.e. not positive.
685 +     */
686 +    static long randomExpiredTimeout() { return RANDOM_EXPIRED_TIMEOUT; }
687 +
688 +    /**
689 +     * Returns a random non-null TimeUnit.
690 +     */
691 +    static TimeUnit randomTimeUnit() { return RANDOM_TIMEUNIT; }
692 +
693 +    /**
694 +     * Returns a random boolean; a "coin flip".
695 +     */
696 +    static boolean randomBoolean() {
697 +        return ThreadLocalRandom.current().nextBoolean();
698 +    }
699 +
700 +    /**
701 +     * Returns a random element from given choices.
702 +     */
703 +    <T> T chooseRandomly(T... choices) {
704 +        return choices[ThreadLocalRandom.current().nextInt(choices.length)];
705 +    }
706 +
707 +    /**
708       * Returns the shortest timed delay. This can be scaled up for
709       * slow machines using the jsr166.delay.factor system property,
710       * or via jtreg's -timeoutFactor: flag.
# Line 615 | Line 722 | public class JSR166TestCase extends Test
722          SMALL_DELAY_MS  = SHORT_DELAY_MS * 5;
723          MEDIUM_DELAY_MS = SHORT_DELAY_MS * 10;
724          LONG_DELAY_MS   = SHORT_DELAY_MS * 200;
725 +        LONGER_DELAY_MS = 2 * LONG_DELAY_MS;
726      }
727  
728 +    private static final long TIMEOUT_DELAY_MS
729 +        = (long) (12.0 * Math.cbrt(delayFactor));
730 +
731      /**
732 <     * Returns a timeout in milliseconds to be used in tests that
733 <     * verify that operations block or time out.
732 >     * Returns a timeout in milliseconds to be used in tests that verify
733 >     * that operations block or time out.  We want this to be longer
734 >     * than the OS scheduling quantum, but not too long, so don't scale
735 >     * linearly with delayFactor; we use "crazy" cube root instead.
736       */
737 <    long timeoutMillis() {
738 <        return SHORT_DELAY_MS / 4;
737 >    static long timeoutMillis() {
738 >        return TIMEOUT_DELAY_MS;
739      }
740  
741      /**
# Line 638 | Line 751 | public class JSR166TestCase extends Test
751       * The first exception encountered if any threadAssertXXX method fails.
752       */
753      private final AtomicReference<Throwable> threadFailure
754 <        = new AtomicReference<Throwable>(null);
754 >        = new AtomicReference<>(null);
755  
756      /**
757       * Records an exception so that it can be rethrown later in the test
# Line 648 | Line 761 | public class JSR166TestCase extends Test
761       */
762      public void threadRecordFailure(Throwable t) {
763          System.err.println(t);
764 <        dumpTestThreads();
765 <        threadFailure.compareAndSet(null, t);
764 >        if (threadFailure.compareAndSet(null, t))
765 >            dumpTestThreads();
766      }
767  
768      public void setUp() {
# Line 660 | Line 773 | public class JSR166TestCase extends Test
773          String msg = toString() + ": " + String.format(format, args);
774          System.err.println(msg);
775          dumpTestThreads();
776 <        throw new AssertionFailedError(msg);
776 >        throw new AssertionError(msg);
777      }
778  
779      /**
# Line 681 | Line 794 | public class JSR166TestCase extends Test
794                  throw (RuntimeException) t;
795              else if (t instanceof Exception)
796                  throw (Exception) t;
797 <            else {
798 <                AssertionFailedError afe =
686 <                    new AssertionFailedError(t.toString());
687 <                afe.initCause(t);
688 <                throw afe;
689 <            }
797 >            else
798 >                throw new AssertionError(t.toString(), t);
799          }
800  
801          if (Thread.interrupted())
# Line 720 | Line 829 | public class JSR166TestCase extends Test
829  
830      /**
831       * Just like fail(reason), but additionally recording (using
832 <     * threadRecordFailure) any AssertionFailedError thrown, so that
833 <     * the current testcase will fail.
832 >     * threadRecordFailure) any AssertionError thrown, so that the
833 >     * current testcase will fail.
834       */
835      public void threadFail(String reason) {
836          try {
837              fail(reason);
838 <        } catch (AssertionFailedError t) {
839 <            threadRecordFailure(t);
840 <            throw t;
838 >        } catch (AssertionError fail) {
839 >            threadRecordFailure(fail);
840 >            throw fail;
841          }
842      }
843  
844      /**
845       * Just like assertTrue(b), but additionally recording (using
846 <     * threadRecordFailure) any AssertionFailedError thrown, so that
847 <     * the current testcase will fail.
846 >     * threadRecordFailure) any AssertionError thrown, so that the
847 >     * current testcase will fail.
848       */
849      public void threadAssertTrue(boolean b) {
850          try {
851              assertTrue(b);
852 <        } catch (AssertionFailedError t) {
853 <            threadRecordFailure(t);
854 <            throw t;
852 >        } catch (AssertionError fail) {
853 >            threadRecordFailure(fail);
854 >            throw fail;
855          }
856      }
857  
858      /**
859       * Just like assertFalse(b), but additionally recording (using
860 <     * threadRecordFailure) any AssertionFailedError thrown, so that
861 <     * the current testcase will fail.
860 >     * threadRecordFailure) any AssertionError thrown, so that the
861 >     * current testcase will fail.
862       */
863      public void threadAssertFalse(boolean b) {
864          try {
865              assertFalse(b);
866 <        } catch (AssertionFailedError t) {
867 <            threadRecordFailure(t);
868 <            throw t;
866 >        } catch (AssertionError fail) {
867 >            threadRecordFailure(fail);
868 >            throw fail;
869          }
870      }
871  
872      /**
873       * Just like assertNull(x), but additionally recording (using
874 <     * threadRecordFailure) any AssertionFailedError thrown, so that
875 <     * the current testcase will fail.
874 >     * threadRecordFailure) any AssertionError thrown, so that the
875 >     * current testcase will fail.
876       */
877      public void threadAssertNull(Object x) {
878          try {
879              assertNull(x);
880 <        } catch (AssertionFailedError t) {
881 <            threadRecordFailure(t);
882 <            throw t;
880 >        } catch (AssertionError fail) {
881 >            threadRecordFailure(fail);
882 >            throw fail;
883          }
884      }
885  
886      /**
887       * Just like assertEquals(x, y), but additionally recording (using
888 <     * threadRecordFailure) any AssertionFailedError thrown, so that
889 <     * the current testcase will fail.
888 >     * threadRecordFailure) any AssertionError thrown, so that the
889 >     * current testcase will fail.
890       */
891      public void threadAssertEquals(long x, long y) {
892          try {
893              assertEquals(x, y);
894 <        } catch (AssertionFailedError t) {
895 <            threadRecordFailure(t);
896 <            throw t;
894 >        } catch (AssertionError fail) {
895 >            threadRecordFailure(fail);
896 >            throw fail;
897          }
898      }
899  
900      /**
901       * Just like assertEquals(x, y), but additionally recording (using
902 <     * threadRecordFailure) any AssertionFailedError thrown, so that
903 <     * the current testcase will fail.
902 >     * threadRecordFailure) any AssertionError thrown, so that the
903 >     * current testcase will fail.
904       */
905      public void threadAssertEquals(Object x, Object y) {
906          try {
907              assertEquals(x, y);
908 <        } catch (AssertionFailedError fail) {
908 >        } catch (AssertionError fail) {
909              threadRecordFailure(fail);
910              throw fail;
911          } catch (Throwable fail) {
# Line 806 | Line 915 | public class JSR166TestCase extends Test
915  
916      /**
917       * Just like assertSame(x, y), but additionally recording (using
918 <     * threadRecordFailure) any AssertionFailedError thrown, so that
919 <     * the current testcase will fail.
918 >     * threadRecordFailure) any AssertionError thrown, so that the
919 >     * current testcase will fail.
920       */
921      public void threadAssertSame(Object x, Object y) {
922          try {
923              assertSame(x, y);
924 <        } catch (AssertionFailedError fail) {
924 >        } catch (AssertionError fail) {
925              threadRecordFailure(fail);
926              throw fail;
927          }
# Line 834 | Line 943 | public class JSR166TestCase extends Test
943  
944      /**
945       * Records the given exception using {@link #threadRecordFailure},
946 <     * then rethrows the exception, wrapping it in an
947 <     * AssertionFailedError if necessary.
946 >     * then rethrows the exception, wrapping it in an AssertionError
947 >     * if necessary.
948       */
949      public void threadUnexpectedException(Throwable t) {
950          threadRecordFailure(t);
# Line 844 | Line 953 | public class JSR166TestCase extends Test
953              throw (RuntimeException) t;
954          else if (t instanceof Error)
955              throw (Error) t;
956 <        else {
957 <            AssertionFailedError afe =
849 <                new AssertionFailedError("unexpected exception: " + t);
850 <            afe.initCause(t);
851 <            throw afe;
852 <        }
956 >        else
957 >            throw new AssertionError("unexpected exception: " + t, t);
958      }
959  
960      /**
# Line 948 | Line 1053 | public class JSR166TestCase extends Test
1053          }
1054      }
1055  
1056 <    /** Like Runnable, but with the freedom to throw anything */
1056 >    /**
1057 >     * Like Runnable, but with the freedom to throw anything.
1058 >     * junit folks had the same idea:
1059 >     * http://junit.org/junit5/docs/snapshot/api/org/junit/gen5/api/Executable.html
1060 >     */
1061      interface Action { public void run() throws Throwable; }
1062  
1063      /**
# Line 991 | Line 1100 | public class JSR166TestCase extends Test
1100          ThreadMXBean threadMXBean = ManagementFactory.getThreadMXBean();
1101          System.err.println("------ stacktrace dump start ------");
1102          for (ThreadInfo info : threadMXBean.dumpAllThreads(true, true)) {
1103 <            String name = info.getThreadName();
1103 >            final String name = info.getThreadName();
1104 >            String lockName;
1105              if ("Signal Dispatcher".equals(name))
1106                  continue;
1107              if ("Reference Handler".equals(name)
1108 <                && info.getLockName().startsWith("java.lang.ref.Reference$Lock"))
1108 >                && (lockName = info.getLockName()) != null
1109 >                && lockName.startsWith("java.lang.ref"))
1110                  continue;
1111 <            if ("Finalizer".equals(name)
1112 <                && info.getLockName().startsWith("java.lang.ref.ReferenceQueue$Lock"))
1111 >            if (("Finalizer".equals(name) || "Common-Cleaner".equals(name))
1112 >                && (lockName = info.getLockName()) != null
1113 >                && lockName.startsWith("java.lang.ref"))
1114                  continue;
1115 <            if ("checkForWedgedTest".equals(name))
1115 >            if ("WedgedTestDetector".equals(name))
1116                  continue;
1117              System.err.print(info);
1118          }
# Line 1010 | Line 1122 | public class JSR166TestCase extends Test
1122      }
1123  
1124      /**
1125 <     * Checks that thread does not terminate within the default
1014 <     * millisecond delay of {@code timeoutMillis()}.
1015 <     */
1016 <    void assertThreadStaysAlive(Thread thread) {
1017 <        assertThreadStaysAlive(thread, timeoutMillis());
1018 <    }
1019 <
1020 <    /**
1021 <     * Checks that thread does not terminate within the given millisecond delay.
1125 >     * Checks that thread eventually enters the expected blocked thread state.
1126       */
1127 <    void assertThreadStaysAlive(Thread thread, long millis) {
1128 <        try {
1129 <            // No need to optimize the failing case via Thread.join.
1130 <            delay(millis);
1131 <            assertTrue(thread.isAlive());
1132 <        } catch (InterruptedException fail) {
1133 <            threadFail("Unexpected InterruptedException");
1134 <        }
1135 <    }
1136 <
1137 <    /**
1138 <     * Checks that the threads do not terminate within the default
1139 <     * millisecond delay of {@code timeoutMillis()}.
1036 <     */
1037 <    void assertThreadsStayAlive(Thread... threads) {
1038 <        assertThreadsStayAlive(timeoutMillis(), threads);
1039 <    }
1040 <
1041 <    /**
1042 <     * Checks that the threads do not terminate within the given millisecond delay.
1043 <     */
1044 <    void assertThreadsStayAlive(long millis, Thread... threads) {
1045 <        try {
1046 <            // No need to optimize the failing case via Thread.join.
1047 <            delay(millis);
1048 <            for (Thread thread : threads)
1049 <                assertTrue(thread.isAlive());
1050 <        } catch (InterruptedException fail) {
1051 <            threadFail("Unexpected InterruptedException");
1127 >    void assertThreadBlocks(Thread thread, Thread.State expected) {
1128 >        // always sleep at least 1 ms, with high probability avoiding
1129 >        // transitory states
1130 >        for (long retries = LONG_DELAY_MS * 3 / 4; retries-->0; ) {
1131 >            try { delay(1); }
1132 >            catch (InterruptedException fail) {
1133 >                throw new AssertionError("Unexpected InterruptedException", fail);
1134 >            }
1135 >            Thread.State s = thread.getState();
1136 >            if (s == expected)
1137 >                return;
1138 >            else if (s == Thread.State.TERMINATED)
1139 >                fail("Unexpected thread termination");
1140          }
1141 +        fail("timed out waiting for thread to enter thread state " + expected);
1142      }
1143  
1144      /**
# Line 1090 | Line 1179 | public class JSR166TestCase extends Test
1179      }
1180  
1181      /**
1182 +     * The maximum number of consecutive spurious wakeups we should
1183 +     * tolerate (from APIs like LockSupport.park) before failing a test.
1184 +     */
1185 +    static final int MAX_SPURIOUS_WAKEUPS = 10;
1186 +
1187 +    /**
1188       * The number of elements to place in collections, arrays, etc.
1189       */
1190      public static final int SIZE = 20;
# Line 1193 | Line 1288 | public class JSR166TestCase extends Test
1288          }
1289          public void refresh() {}
1290          public String toString() {
1291 <            List<Permission> ps = new ArrayList<Permission>();
1291 >            List<Permission> ps = new ArrayList<>();
1292              for (Enumeration<Permission> e = perms.elements(); e.hasMoreElements();)
1293                  ps.add(e.nextElement());
1294              return "AdjustablePolicy with permissions " + ps;
# Line 1221 | Line 1316 | public class JSR166TestCase extends Test
1316  
1317      /**
1318       * Sleeps until the given time has elapsed.
1319 <     * Throws AssertionFailedError if interrupted.
1319 >     * Throws AssertionError if interrupted.
1320       */
1321 <    void sleep(long millis) {
1321 >    static void sleep(long millis) {
1322          try {
1323              delay(millis);
1324          } catch (InterruptedException fail) {
1325 <            AssertionFailedError afe =
1231 <                new AssertionFailedError("Unexpected InterruptedException");
1232 <            afe.initCause(fail);
1233 <            throw afe;
1325 >            throw new AssertionError("Unexpected InterruptedException", fail);
1326          }
1327      }
1328  
1329      /**
1330       * Spin-waits up to the specified number of milliseconds for the given
1331       * thread to enter a wait state: BLOCKED, WAITING, or TIMED_WAITING.
1332 +     * @param waitingForGodot if non-null, an additional condition to satisfy
1333       */
1334 <    void waitForThreadToEnterWaitState(Thread thread, long timeoutMillis) {
1335 <        long startTime = System.nanoTime();
1336 <        for (;;) {
1337 <            Thread.State s = thread.getState();
1338 <            if (s == Thread.State.BLOCKED ||
1339 <                s == Thread.State.WAITING ||
1340 <                s == Thread.State.TIMED_WAITING)
1341 <                return;
1342 <            else if (s == Thread.State.TERMINATED)
1334 >    void waitForThreadToEnterWaitState(Thread thread, long timeoutMillis,
1335 >                                       Callable<Boolean> waitingForGodot) {
1336 >        for (long startTime = 0L;;) {
1337 >            switch (thread.getState()) {
1338 >            default: break;
1339 >            case BLOCKED: case WAITING: case TIMED_WAITING:
1340 >                try {
1341 >                    if (waitingForGodot == null || waitingForGodot.call())
1342 >                        return;
1343 >                } catch (Throwable fail) { threadUnexpectedException(fail); }
1344 >                break;
1345 >            case TERMINATED:
1346                  fail("Unexpected thread termination");
1347 +            }
1348 +
1349 +            if (startTime == 0L)
1350 +                startTime = System.nanoTime();
1351              else if (millisElapsedSince(startTime) > timeoutMillis) {
1352 <                threadAssertTrue(thread.isAlive());
1353 <                return;
1352 >                assertTrue(thread.isAlive());
1353 >                if (waitingForGodot == null
1354 >                    || thread.getState() == Thread.State.RUNNABLE)
1355 >                    fail("timed out waiting for thread to enter wait state");
1356 >                else
1357 >                    fail("timed out waiting for condition, thread state="
1358 >                         + thread.getState());
1359              }
1360              Thread.yield();
1361          }
1362      }
1363  
1364      /**
1365 <     * Waits up to LONG_DELAY_MS for the given thread to enter a wait
1366 <     * state: BLOCKED, WAITING, or TIMED_WAITING.
1365 >     * Spin-waits up to the specified number of milliseconds for the given
1366 >     * thread to enter a wait state: BLOCKED, WAITING, or TIMED_WAITING.
1367 >     */
1368 >    void waitForThreadToEnterWaitState(Thread thread, long timeoutMillis) {
1369 >        waitForThreadToEnterWaitState(thread, timeoutMillis, null);
1370 >    }
1371 >
1372 >    /**
1373 >     * Spin-waits up to LONG_DELAY_MS milliseconds for the given thread to
1374 >     * enter a wait state: BLOCKED, WAITING, or TIMED_WAITING.
1375       */
1376      void waitForThreadToEnterWaitState(Thread thread) {
1377 <        waitForThreadToEnterWaitState(thread, LONG_DELAY_MS);
1377 >        waitForThreadToEnterWaitState(thread, LONG_DELAY_MS, null);
1378 >    }
1379 >
1380 >    /**
1381 >     * Spin-waits up to LONG_DELAY_MS milliseconds for the given thread to
1382 >     * enter a wait state: BLOCKED, WAITING, or TIMED_WAITING,
1383 >     * and additionally satisfy the given condition.
1384 >     */
1385 >    void waitForThreadToEnterWaitState(Thread thread,
1386 >                                       Callable<Boolean> waitingForGodot) {
1387 >        waitForThreadToEnterWaitState(thread, LONG_DELAY_MS, waitingForGodot);
1388 >    }
1389 >
1390 >    /**
1391 >     * Spin-waits up to LONG_DELAY_MS milliseconds for the current thread to
1392 >     * be interrupted.  Clears the interrupt status before returning.
1393 >     */
1394 >    void awaitInterrupted() {
1395 >        for (long startTime = 0L; !Thread.interrupted(); ) {
1396 >            if (startTime == 0L)
1397 >                startTime = System.nanoTime();
1398 >            else if (millisElapsedSince(startTime) > LONG_DELAY_MS)
1399 >                fail("timed out waiting for thread interrupt");
1400 >            Thread.yield();
1401 >        }
1402      }
1403  
1404      /**
# Line 1273 | Line 1410 | public class JSR166TestCase extends Test
1410          return NANOSECONDS.toMillis(System.nanoTime() - startNanoTime);
1411      }
1412  
1276 //     void assertTerminatesPromptly(long timeoutMillis, Runnable r) {
1277 //         long startTime = System.nanoTime();
1278 //         try {
1279 //             r.run();
1280 //         } catch (Throwable fail) { threadUnexpectedException(fail); }
1281 //         if (millisElapsedSince(startTime) > timeoutMillis/2)
1282 //             throw new AssertionFailedError("did not return promptly");
1283 //     }
1284
1285 //     void assertTerminatesPromptly(Runnable r) {
1286 //         assertTerminatesPromptly(LONG_DELAY_MS/2, r);
1287 //     }
1288
1413      /**
1414       * Checks that timed f.get() returns the expected value, and does not
1415       * wait for the timeout to elapse before returning.
1416       */
1417      <T> void checkTimedGet(Future<T> f, T expectedValue, long timeoutMillis) {
1418          long startTime = System.nanoTime();
1419 +        T actual = null;
1420          try {
1421 <            assertEquals(expectedValue, f.get(timeoutMillis, MILLISECONDS));
1421 >            actual = f.get(timeoutMillis, MILLISECONDS);
1422          } catch (Throwable fail) { threadUnexpectedException(fail); }
1423 +        assertEquals(expectedValue, actual);
1424          if (millisElapsedSince(startTime) > timeoutMillis/2)
1425 <            throw new AssertionFailedError("timed get did not return promptly");
1425 >            throw new AssertionError("timed get did not return promptly");
1426      }
1427  
1428      <T> void checkTimedGet(Future<T> f, T expectedValue) {
# Line 1318 | Line 1444 | public class JSR166TestCase extends Test
1444       * to terminate (using {@link Thread#join(long)}), else interrupts
1445       * the thread (in the hope that it may terminate later) and fails.
1446       */
1447 <    void awaitTermination(Thread t, long timeoutMillis) {
1447 >    void awaitTermination(Thread thread, long timeoutMillis) {
1448          try {
1449 <            t.join(timeoutMillis);
1449 >            thread.join(timeoutMillis);
1450          } catch (InterruptedException fail) {
1451              threadUnexpectedException(fail);
1452 <        } finally {
1453 <            if (t.getState() != Thread.State.TERMINATED) {
1454 <                t.interrupt();
1455 <                threadFail("timed out waiting for thread to terminate");
1452 >        }
1453 >        if (thread.getState() != Thread.State.TERMINATED) {
1454 >            String detail = String.format(
1455 >                    "timed out waiting for thread to terminate, thread=%s, state=%s" ,
1456 >                    thread, thread.getState());
1457 >            try {
1458 >                threadFail(detail);
1459 >            } finally {
1460 >                // Interrupt thread __after__ having reported its stack trace
1461 >                thread.interrupt();
1462              }
1463          }
1464      }
# Line 1354 | Line 1486 | public class JSR166TestCase extends Test
1486          }
1487      }
1488  
1357    public abstract class RunnableShouldThrow implements Runnable {
1358        protected abstract void realRun() throws Throwable;
1359
1360        final Class<?> exceptionClass;
1361
1362        <T extends Throwable> RunnableShouldThrow(Class<T> exceptionClass) {
1363            this.exceptionClass = exceptionClass;
1364        }
1365
1366        public final void run() {
1367            try {
1368                realRun();
1369                threadShouldThrow(exceptionClass.getSimpleName());
1370            } catch (Throwable t) {
1371                if (! exceptionClass.isInstance(t))
1372                    threadUnexpectedException(t);
1373            }
1374        }
1375    }
1376
1489      public abstract class ThreadShouldThrow extends Thread {
1490          protected abstract void realRun() throws Throwable;
1491  
# Line 1386 | Line 1498 | public class JSR166TestCase extends Test
1498          public final void run() {
1499              try {
1500                  realRun();
1389                threadShouldThrow(exceptionClass.getSimpleName());
1501              } catch (Throwable t) {
1502                  if (! exceptionClass.isInstance(t))
1503                      threadUnexpectedException(t);
1504 +                return;
1505              }
1506 +            threadShouldThrow(exceptionClass.getSimpleName());
1507          }
1508      }
1509  
# Line 1400 | Line 1513 | public class JSR166TestCase extends Test
1513          public final void run() {
1514              try {
1515                  realRun();
1403                threadShouldThrow("InterruptedException");
1516              } catch (InterruptedException success) {
1517                  threadAssertFalse(Thread.interrupted());
1518 +                return;
1519              } catch (Throwable fail) {
1520                  threadUnexpectedException(fail);
1521              }
1522 +            threadShouldThrow("InterruptedException");
1523          }
1524      }
1525  
# Line 1417 | Line 1531 | public class JSR166TestCase extends Test
1531                  return realCall();
1532              } catch (Throwable fail) {
1533                  threadUnexpectedException(fail);
1420                return null;
1421            }
1422        }
1423    }
1424
1425    public abstract class CheckedInterruptedCallable<T>
1426        implements Callable<T> {
1427        protected abstract T realCall() throws Throwable;
1428
1429        public final T call() {
1430            try {
1431                T result = realCall();
1432                threadShouldThrow("InterruptedException");
1433                return result;
1434            } catch (InterruptedException success) {
1435                threadAssertFalse(Thread.interrupted());
1436            } catch (Throwable fail) {
1437                threadUnexpectedException(fail);
1534              }
1535 <            return null;
1535 >            throw new AssertionError("unreached");
1536          }
1537      }
1538  
# Line 1493 | Line 1589 | public class JSR166TestCase extends Test
1589      }
1590  
1591      public void await(CountDownLatch latch, long timeoutMillis) {
1592 +        boolean timedOut = false;
1593          try {
1594 <            if (!latch.await(timeoutMillis, MILLISECONDS))
1498 <                fail("timed out waiting for CountDownLatch for "
1499 <                     + (timeoutMillis/1000) + " sec");
1594 >            timedOut = !latch.await(timeoutMillis, MILLISECONDS);
1595          } catch (Throwable fail) {
1596              threadUnexpectedException(fail);
1597          }
1598 +        if (timedOut)
1599 +            fail("timed out waiting for CountDownLatch for "
1600 +                 + (timeoutMillis/1000) + " sec");
1601      }
1602  
1603      public void await(CountDownLatch latch) {
# Line 1507 | Line 1605 | public class JSR166TestCase extends Test
1605      }
1606  
1607      public void await(Semaphore semaphore) {
1608 +        boolean timedOut = false;
1609          try {
1610 <            if (!semaphore.tryAcquire(LONG_DELAY_MS, MILLISECONDS))
1611 <                fail("timed out waiting for Semaphore for "
1612 <                     + (LONG_DELAY_MS/1000) + " sec");
1610 >            timedOut = !semaphore.tryAcquire(LONG_DELAY_MS, MILLISECONDS);
1611 >        } catch (Throwable fail) {
1612 >            threadUnexpectedException(fail);
1613 >        }
1614 >        if (timedOut)
1615 >            fail("timed out waiting for Semaphore for "
1616 >                 + (LONG_DELAY_MS/1000) + " sec");
1617 >    }
1618 >
1619 >    public void await(CyclicBarrier barrier) {
1620 >        try {
1621 >            barrier.await(LONG_DELAY_MS, MILLISECONDS);
1622          } catch (Throwable fail) {
1623              threadUnexpectedException(fail);
1624          }
# Line 1530 | Line 1638 | public class JSR166TestCase extends Test
1638   //         long startTime = System.nanoTime();
1639   //         while (!flag.get()) {
1640   //             if (millisElapsedSince(startTime) > timeoutMillis)
1641 < //                 throw new AssertionFailedError("timed out");
1641 > //                 throw new AssertionError("timed out");
1642   //             Thread.yield();
1643   //         }
1644   //     }
# Line 1539 | Line 1647 | public class JSR166TestCase extends Test
1647          public String call() { throw new NullPointerException(); }
1648      }
1649  
1542    public static class CallableOne implements Callable<Integer> {
1543        public Integer call() { return one; }
1544    }
1545
1546    public class ShortRunnable extends CheckedRunnable {
1547        protected void realRun() throws Throwable {
1548            delay(SHORT_DELAY_MS);
1549        }
1550    }
1551
1552    public class ShortInterruptedRunnable extends CheckedInterruptedRunnable {
1553        protected void realRun() throws InterruptedException {
1554            delay(SHORT_DELAY_MS);
1555        }
1556    }
1557
1558    public class SmallRunnable extends CheckedRunnable {
1559        protected void realRun() throws Throwable {
1560            delay(SMALL_DELAY_MS);
1561        }
1562    }
1563
1564    public class SmallPossiblyInterruptedRunnable extends CheckedRunnable {
1565        protected void realRun() {
1566            try {
1567                delay(SMALL_DELAY_MS);
1568            } catch (InterruptedException ok) {}
1569        }
1570    }
1571
1572    public class SmallCallable extends CheckedCallable {
1573        protected Object realCall() throws InterruptedException {
1574            delay(SMALL_DELAY_MS);
1575            return Boolean.TRUE;
1576        }
1577    }
1578
1579    public class MediumRunnable extends CheckedRunnable {
1580        protected void realRun() throws Throwable {
1581            delay(MEDIUM_DELAY_MS);
1582        }
1583    }
1584
1585    public class MediumInterruptedRunnable extends CheckedInterruptedRunnable {
1586        protected void realRun() throws InterruptedException {
1587            delay(MEDIUM_DELAY_MS);
1588        }
1589    }
1590
1650      public Runnable possiblyInterruptedRunnable(final long timeoutMillis) {
1651          return new CheckedRunnable() {
1652              protected void realRun() {
# Line 1597 | Line 1656 | public class JSR166TestCase extends Test
1656              }};
1657      }
1658  
1600    public class MediumPossiblyInterruptedRunnable extends CheckedRunnable {
1601        protected void realRun() {
1602            try {
1603                delay(MEDIUM_DELAY_MS);
1604            } catch (InterruptedException ok) {}
1605        }
1606    }
1607
1608    public class LongPossiblyInterruptedRunnable extends CheckedRunnable {
1609        protected void realRun() {
1610            try {
1611                delay(LONG_DELAY_MS);
1612            } catch (InterruptedException ok) {}
1613        }
1614    }
1615
1659      /**
1660       * For use as ThreadFactory in constructors
1661       */
# Line 1626 | Line 1669 | public class JSR166TestCase extends Test
1669          boolean isDone();
1670      }
1671  
1629    public static TrackedRunnable trackedRunnable(final long timeoutMillis) {
1630        return new TrackedRunnable() {
1631                private volatile boolean done = false;
1632                public boolean isDone() { return done; }
1633                public void run() {
1634                    try {
1635                        delay(timeoutMillis);
1636                        done = true;
1637                    } catch (InterruptedException ok) {}
1638                }
1639            };
1640    }
1641
1642    public static class TrackedShortRunnable implements Runnable {
1643        public volatile boolean done = false;
1644        public void run() {
1645            try {
1646                delay(SHORT_DELAY_MS);
1647                done = true;
1648            } catch (InterruptedException ok) {}
1649        }
1650    }
1651
1652    public static class TrackedSmallRunnable implements Runnable {
1653        public volatile boolean done = false;
1654        public void run() {
1655            try {
1656                delay(SMALL_DELAY_MS);
1657                done = true;
1658            } catch (InterruptedException ok) {}
1659        }
1660    }
1661
1662    public static class TrackedMediumRunnable implements Runnable {
1663        public volatile boolean done = false;
1664        public void run() {
1665            try {
1666                delay(MEDIUM_DELAY_MS);
1667                done = true;
1668            } catch (InterruptedException ok) {}
1669        }
1670    }
1671
1672    public static class TrackedLongRunnable implements Runnable {
1673        public volatile boolean done = false;
1674        public void run() {
1675            try {
1676                delay(LONG_DELAY_MS);
1677                done = true;
1678            } catch (InterruptedException ok) {}
1679        }
1680    }
1681
1672      public static class TrackedNoOpRunnable implements Runnable {
1673          public volatile boolean done = false;
1674          public void run() {
# Line 1686 | Line 1676 | public class JSR166TestCase extends Test
1676          }
1677      }
1678  
1689    public static class TrackedCallable implements Callable {
1690        public volatile boolean done = false;
1691        public Object call() {
1692            try {
1693                delay(SMALL_DELAY_MS);
1694                done = true;
1695            } catch (InterruptedException ok) {}
1696            return Boolean.TRUE;
1697        }
1698    }
1699
1679      /**
1680       * Analog of CheckedRunnable for RecursiveAction
1681       */
# Line 1723 | Line 1702 | public class JSR166TestCase extends Test
1702                  return realCompute();
1703              } catch (Throwable fail) {
1704                  threadUnexpectedException(fail);
1726                return null;
1705              }
1706 +            throw new AssertionError("unreached");
1707          }
1708      }
1709  
# Line 1738 | Line 1717 | public class JSR166TestCase extends Test
1717  
1718      /**
1719       * A CyclicBarrier that uses timed await and fails with
1720 <     * AssertionFailedErrors instead of throwing checked exceptions.
1720 >     * AssertionErrors instead of throwing checked exceptions.
1721       */
1722 <    public class CheckedBarrier extends CyclicBarrier {
1722 >    public static class CheckedBarrier extends CyclicBarrier {
1723          public CheckedBarrier(int parties) { super(parties); }
1724  
1725          public int await() {
1726              try {
1727                  return super.await(2 * LONG_DELAY_MS, MILLISECONDS);
1728              } catch (TimeoutException timedOut) {
1729 <                throw new AssertionFailedError("timed out");
1729 >                throw new AssertionError("timed out");
1730              } catch (Exception fail) {
1731 <                AssertionFailedError afe =
1753 <                    new AssertionFailedError("Unexpected exception: " + fail);
1754 <                afe.initCause(fail);
1755 <                throw afe;
1731 >                throw new AssertionError("Unexpected exception: " + fail, fail);
1732              }
1733          }
1734      }
# Line 1763 | Line 1739 | public class JSR166TestCase extends Test
1739              assertEquals(0, q.size());
1740              assertNull(q.peek());
1741              assertNull(q.poll());
1742 <            assertNull(q.poll(0, MILLISECONDS));
1742 >            assertNull(q.poll(randomExpiredTimeout(), randomTimeUnit()));
1743              assertEquals(q.toString(), "[]");
1744              assertTrue(Arrays.equals(q.toArray(), new Object[0]));
1745              assertFalse(q.iterator().hasNext());
# Line 1804 | Line 1780 | public class JSR166TestCase extends Test
1780          }
1781      }
1782  
1783 +    void assertImmutable(Object o) {
1784 +        if (o instanceof Collection) {
1785 +            assertThrows(
1786 +                UnsupportedOperationException.class,
1787 +                () -> ((Collection) o).add(null));
1788 +        }
1789 +    }
1790 +
1791      @SuppressWarnings("unchecked")
1792      <T> T serialClone(T o) {
1793 +        T clone = null;
1794          try {
1795              ObjectInputStream ois = new ObjectInputStream
1796                  (new ByteArrayInputStream(serialBytes(o)));
1797 <            T clone = (T) ois.readObject();
1813 <            assertSame(o.getClass(), clone.getClass());
1814 <            return clone;
1797 >            clone = (T) ois.readObject();
1798          } catch (Throwable fail) {
1799              threadUnexpectedException(fail);
1800 +        }
1801 +        if (o == clone) assertImmutable(o);
1802 +        else assertSame(o.getClass(), clone.getClass());
1803 +        return clone;
1804 +    }
1805 +
1806 +    /**
1807 +     * A version of serialClone that leaves error handling (for
1808 +     * e.g. NotSerializableException) up to the caller.
1809 +     */
1810 +    @SuppressWarnings("unchecked")
1811 +    <T> T serialClonePossiblyFailing(T o)
1812 +        throws ReflectiveOperationException, java.io.IOException {
1813 +        ByteArrayOutputStream bos = new ByteArrayOutputStream();
1814 +        ObjectOutputStream oos = new ObjectOutputStream(bos);
1815 +        oos.writeObject(o);
1816 +        oos.flush();
1817 +        oos.close();
1818 +        ObjectInputStream ois = new ObjectInputStream
1819 +            (new ByteArrayInputStream(bos.toByteArray()));
1820 +        T clone = (T) ois.readObject();
1821 +        if (o == clone) assertImmutable(o);
1822 +        else assertSame(o.getClass(), clone.getClass());
1823 +        return clone;
1824 +    }
1825 +
1826 +    /**
1827 +     * If o implements Cloneable and has a public clone method,
1828 +     * returns a clone of o, else null.
1829 +     */
1830 +    @SuppressWarnings("unchecked")
1831 +    <T> T cloneableClone(T o) {
1832 +        if (!(o instanceof Cloneable)) return null;
1833 +        final T clone;
1834 +        try {
1835 +            clone = (T) o.getClass().getMethod("clone").invoke(o);
1836 +        } catch (NoSuchMethodException ok) {
1837              return null;
1838 +        } catch (ReflectiveOperationException unexpected) {
1839 +            throw new Error(unexpected);
1840          }
1841 +        assertNotSame(o, clone); // not 100% guaranteed by spec
1842 +        assertSame(o.getClass(), clone.getClass());
1843 +        return clone;
1844      }
1845  
1846      public void assertThrows(Class<? extends Throwable> expectedExceptionClass,
1847 <                             Runnable... throwingActions) {
1848 <        for (Runnable throwingAction : throwingActions) {
1847 >                             Action... throwingActions) {
1848 >        for (Action throwingAction : throwingActions) {
1849              boolean threw = false;
1850              try { throwingAction.run(); }
1851              catch (Throwable t) {
1852                  threw = true;
1853 <                if (!expectedExceptionClass.isInstance(t)) {
1854 <                    AssertionFailedError afe =
1855 <                        new AssertionFailedError
1856 <                        ("Expected " + expectedExceptionClass.getName() +
1857 <                         ", got " + t.getClass().getName());
1833 <                    afe.initCause(t);
1834 <                    threadUnexpectedException(afe);
1835 <                }
1853 >                if (!expectedExceptionClass.isInstance(t))
1854 >                    throw new AssertionError(
1855 >                            "Expected " + expectedExceptionClass.getName() +
1856 >                            ", got " + t.getClass().getName(),
1857 >                            t);
1858              }
1859              if (!threw)
1860                  shouldThrow(expectedExceptionClass.getName());
# Line 1861 | Line 1883 | public class JSR166TestCase extends Test
1883                                 1000L, MILLISECONDS,
1884                                 new SynchronousQueue<Runnable>());
1885  
1886 +    static <T> void shuffle(T[] array) {
1887 +        Collections.shuffle(Arrays.asList(array), ThreadLocalRandom.current());
1888 +    }
1889 +
1890 +    /**
1891 +     * Returns the same String as would be returned by {@link
1892 +     * Object#toString}, whether or not the given object's class
1893 +     * overrides toString().
1894 +     *
1895 +     * @see System#identityHashCode
1896 +     */
1897 +    static String identityString(Object x) {
1898 +        return x.getClass().getName()
1899 +            + "@" + Integer.toHexString(System.identityHashCode(x));
1900 +    }
1901 +
1902 +    // --- Shared assertions for Executor tests ---
1903 +
1904 +    /**
1905 +     * Returns maximum number of tasks that can be submitted to given
1906 +     * pool (with bounded queue) before saturation (when submission
1907 +     * throws RejectedExecutionException).
1908 +     */
1909 +    static final int saturatedSize(ThreadPoolExecutor pool) {
1910 +        BlockingQueue<Runnable> q = pool.getQueue();
1911 +        return pool.getMaximumPoolSize() + q.size() + q.remainingCapacity();
1912 +    }
1913 +
1914 +    @SuppressWarnings("FutureReturnValueIgnored")
1915 +    void assertNullTaskSubmissionThrowsNullPointerException(Executor e) {
1916 +        try {
1917 +            e.execute((Runnable) null);
1918 +            shouldThrow();
1919 +        } catch (NullPointerException success) {}
1920 +
1921 +        if (! (e instanceof ExecutorService)) return;
1922 +        ExecutorService es = (ExecutorService) e;
1923 +        try {
1924 +            es.submit((Runnable) null);
1925 +            shouldThrow();
1926 +        } catch (NullPointerException success) {}
1927 +        try {
1928 +            es.submit((Runnable) null, Boolean.TRUE);
1929 +            shouldThrow();
1930 +        } catch (NullPointerException success) {}
1931 +        try {
1932 +            es.submit((Callable) null);
1933 +            shouldThrow();
1934 +        } catch (NullPointerException success) {}
1935 +
1936 +        if (! (e instanceof ScheduledExecutorService)) return;
1937 +        ScheduledExecutorService ses = (ScheduledExecutorService) e;
1938 +        try {
1939 +            ses.schedule((Runnable) null,
1940 +                         randomTimeout(), randomTimeUnit());
1941 +            shouldThrow();
1942 +        } catch (NullPointerException success) {}
1943 +        try {
1944 +            ses.schedule((Callable) null,
1945 +                         randomTimeout(), randomTimeUnit());
1946 +            shouldThrow();
1947 +        } catch (NullPointerException success) {}
1948 +        try {
1949 +            ses.scheduleAtFixedRate((Runnable) null,
1950 +                                    randomTimeout(), LONG_DELAY_MS, MILLISECONDS);
1951 +            shouldThrow();
1952 +        } catch (NullPointerException success) {}
1953 +        try {
1954 +            ses.scheduleWithFixedDelay((Runnable) null,
1955 +                                       randomTimeout(), LONG_DELAY_MS, MILLISECONDS);
1956 +            shouldThrow();
1957 +        } catch (NullPointerException success) {}
1958 +    }
1959 +
1960 +    void setRejectedExecutionHandler(
1961 +        ThreadPoolExecutor p, RejectedExecutionHandler handler) {
1962 +        p.setRejectedExecutionHandler(handler);
1963 +        assertSame(handler, p.getRejectedExecutionHandler());
1964 +    }
1965 +
1966 +    void assertTaskSubmissionsAreRejected(ThreadPoolExecutor p) {
1967 +        final RejectedExecutionHandler savedHandler = p.getRejectedExecutionHandler();
1968 +        final long savedTaskCount = p.getTaskCount();
1969 +        final long savedCompletedTaskCount = p.getCompletedTaskCount();
1970 +        final int savedQueueSize = p.getQueue().size();
1971 +        final boolean stock = (p.getClass().getClassLoader() == null);
1972 +
1973 +        Runnable r = () -> {};
1974 +        Callable<Boolean> c = () -> Boolean.TRUE;
1975 +
1976 +        class Recorder implements RejectedExecutionHandler {
1977 +            public volatile Runnable r = null;
1978 +            public volatile ThreadPoolExecutor p = null;
1979 +            public void reset() { r = null; p = null; }
1980 +            public void rejectedExecution(Runnable r, ThreadPoolExecutor p) {
1981 +                assertNull(this.r);
1982 +                assertNull(this.p);
1983 +                this.r = r;
1984 +                this.p = p;
1985 +            }
1986 +        }
1987 +
1988 +        // check custom handler is invoked exactly once per task
1989 +        Recorder recorder = new Recorder();
1990 +        setRejectedExecutionHandler(p, recorder);
1991 +        for (int i = 2; i--> 0; ) {
1992 +            recorder.reset();
1993 +            p.execute(r);
1994 +            if (stock && p.getClass() == ThreadPoolExecutor.class)
1995 +                assertSame(r, recorder.r);
1996 +            assertSame(p, recorder.p);
1997 +
1998 +            recorder.reset();
1999 +            assertFalse(p.submit(r).isDone());
2000 +            if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2001 +            assertSame(p, recorder.p);
2002 +
2003 +            recorder.reset();
2004 +            assertFalse(p.submit(r, Boolean.TRUE).isDone());
2005 +            if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2006 +            assertSame(p, recorder.p);
2007 +
2008 +            recorder.reset();
2009 +            assertFalse(p.submit(c).isDone());
2010 +            if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2011 +            assertSame(p, recorder.p);
2012 +
2013 +            if (p instanceof ScheduledExecutorService) {
2014 +                ScheduledExecutorService s = (ScheduledExecutorService) p;
2015 +                ScheduledFuture<?> future;
2016 +
2017 +                recorder.reset();
2018 +                future = s.schedule(r, randomTimeout(), randomTimeUnit());
2019 +                assertFalse(future.isDone());
2020 +                if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2021 +                assertSame(p, recorder.p);
2022 +
2023 +                recorder.reset();
2024 +                future = s.schedule(c, randomTimeout(), randomTimeUnit());
2025 +                assertFalse(future.isDone());
2026 +                if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2027 +                assertSame(p, recorder.p);
2028 +
2029 +                recorder.reset();
2030 +                future = s.scheduleAtFixedRate(r, randomTimeout(), LONG_DELAY_MS, MILLISECONDS);
2031 +                assertFalse(future.isDone());
2032 +                if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2033 +                assertSame(p, recorder.p);
2034 +
2035 +                recorder.reset();
2036 +                future = s.scheduleWithFixedDelay(r, randomTimeout(), LONG_DELAY_MS, MILLISECONDS);
2037 +                assertFalse(future.isDone());
2038 +                if (stock) assertTrue(!((FutureTask) recorder.r).isDone());
2039 +                assertSame(p, recorder.p);
2040 +            }
2041 +        }
2042 +
2043 +        // Checking our custom handler above should be sufficient, but
2044 +        // we add some integration tests of standard handlers.
2045 +        final AtomicReference<Thread> thread = new AtomicReference<>();
2046 +        final Runnable setThread = () -> thread.set(Thread.currentThread());
2047 +
2048 +        setRejectedExecutionHandler(p, new ThreadPoolExecutor.AbortPolicy());
2049 +        try {
2050 +            p.execute(setThread);
2051 +            shouldThrow();
2052 +        } catch (RejectedExecutionException success) {}
2053 +        assertNull(thread.get());
2054 +
2055 +        setRejectedExecutionHandler(p, new ThreadPoolExecutor.DiscardPolicy());
2056 +        p.execute(setThread);
2057 +        assertNull(thread.get());
2058 +
2059 +        setRejectedExecutionHandler(p, new ThreadPoolExecutor.CallerRunsPolicy());
2060 +        p.execute(setThread);
2061 +        if (p.isShutdown())
2062 +            assertNull(thread.get());
2063 +        else
2064 +            assertSame(Thread.currentThread(), thread.get());
2065 +
2066 +        setRejectedExecutionHandler(p, savedHandler);
2067 +
2068 +        // check that pool was not perturbed by handlers
2069 +        assertEquals(savedTaskCount, p.getTaskCount());
2070 +        assertEquals(savedCompletedTaskCount, p.getCompletedTaskCount());
2071 +        assertEquals(savedQueueSize, p.getQueue().size());
2072 +    }
2073 +
2074 +    void assertCollectionsEquals(Collection<?> x, Collection<?> y) {
2075 +        assertEquals(x, y);
2076 +        assertEquals(y, x);
2077 +        assertEquals(x.isEmpty(), y.isEmpty());
2078 +        assertEquals(x.size(), y.size());
2079 +        if (x instanceof List) {
2080 +            assertEquals(x.toString(), y.toString());
2081 +        }
2082 +        if (x instanceof List || x instanceof Set) {
2083 +            assertEquals(x.hashCode(), y.hashCode());
2084 +        }
2085 +        if (x instanceof List || x instanceof Deque) {
2086 +            assertTrue(Arrays.equals(x.toArray(), y.toArray()));
2087 +            assertTrue(Arrays.equals(x.toArray(new Object[0]),
2088 +                                     y.toArray(new Object[0])));
2089 +        }
2090 +    }
2091 +
2092 +    /**
2093 +     * A weaker form of assertCollectionsEquals which does not insist
2094 +     * that the two collections satisfy Object#equals(Object), since
2095 +     * they may use identity semantics as Deques do.
2096 +     */
2097 +    void assertCollectionsEquivalent(Collection<?> x, Collection<?> y) {
2098 +        if (x instanceof List || x instanceof Set)
2099 +            assertCollectionsEquals(x, y);
2100 +        else {
2101 +            assertEquals(x.isEmpty(), y.isEmpty());
2102 +            assertEquals(x.size(), y.size());
2103 +            assertEquals(new HashSet(x), new HashSet(y));
2104 +            if (x instanceof Deque) {
2105 +                assertTrue(Arrays.equals(x.toArray(), y.toArray()));
2106 +                assertTrue(Arrays.equals(x.toArray(new Object[0]),
2107 +                                         y.toArray(new Object[0])));
2108 +            }
2109 +        }
2110 +    }
2111   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines