ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/LinkedBlockingQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/LinkedBlockingQueueTest.java (file contents):
Revision 1.18 by jsr166, Sat Nov 21 10:25:05 2009 UTC vs.
Revision 1.81 by jsr166, Thu Sep 5 21:11:13 2019 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include Andrew Wright, Jeffrey Hayes,
6   * Pat Fisher, Mike Judd.
7   */
8  
9 import junit.framework.*;
10 import java.util.*;
11 import java.util.concurrent.*;
9   import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 < import java.io.*;
10 >
11 > import java.util.ArrayList;
12 > import java.util.Arrays;
13 > import java.util.Collection;
14 > import java.util.Iterator;
15 > import java.util.NoSuchElementException;
16 > import java.util.Queue;
17 > import java.util.concurrent.BlockingQueue;
18 > import java.util.concurrent.CountDownLatch;
19 > import java.util.concurrent.Executors;
20 > import java.util.concurrent.ExecutorService;
21 > import java.util.concurrent.LinkedBlockingQueue;
22 >
23 > import junit.framework.Test;
24  
25   public class LinkedBlockingQueueTest extends JSR166TestCase {
26  
27 +    public static class Unbounded extends BlockingQueueTest {
28 +        protected BlockingQueue emptyCollection() {
29 +            return new LinkedBlockingQueue();
30 +        }
31 +    }
32 +
33 +    public static class Bounded extends BlockingQueueTest {
34 +        protected BlockingQueue emptyCollection() {
35 +            return new LinkedBlockingQueue(SIZE);
36 +        }
37 +    }
38 +
39      public static void main(String[] args) {
40 <        junit.textui.TestRunner.run (suite());
40 >        main(suite(), args);
41      }
42  
43      public static Test suite() {
44 <        return new TestSuite(LinkedBlockingQueueTest.class);
44 >        class Implementation implements CollectionImplementation {
45 >            public Class<?> klazz() { return LinkedBlockingQueue.class; }
46 >            public Collection emptyCollection() { return new LinkedBlockingQueue(); }
47 >            public Object makeElement(int i) { return i; }
48 >            public boolean isConcurrent() { return true; }
49 >            public boolean permitsNulls() { return false; }
50 >        }
51 >        return newTestSuite(LinkedBlockingQueueTest.class,
52 >                            new Unbounded().testSuite(),
53 >                            new Bounded().testSuite(),
54 >                            CollectionTest.testSuite(new Implementation()));
55      }
56  
25
57      /**
58 <     * Create a queue of given size containing consecutive
59 <     * Integers 0 ... n.
58 >     * Returns a new queue of given size containing consecutive
59 >     * Integers 0 ... n - 1.
60       */
61 <    private LinkedBlockingQueue populatedQueue(int n) {
62 <        LinkedBlockingQueue q = new LinkedBlockingQueue(n);
61 >    private static LinkedBlockingQueue<Integer> populatedQueue(int n) {
62 >        LinkedBlockingQueue<Integer> q = new LinkedBlockingQueue<>(n);
63          assertTrue(q.isEmpty());
64          for (int i = 0; i < n; i++)
65              assertTrue(q.offer(new Integer(i)));
66          assertFalse(q.isEmpty());
67          assertEquals(0, q.remainingCapacity());
68          assertEquals(n, q.size());
69 +        assertEquals((Integer) 0, q.peek());
70          return q;
71      }
72  
# Line 48 | Line 80 | public class LinkedBlockingQueueTest ext
80      }
81  
82      /**
83 <     * Constructor throws IAE if capacity argument nonpositive
83 >     * Constructor throws IllegalArgumentException if capacity argument nonpositive
84       */
85      public void testConstructor2() {
86          try {
87 <            LinkedBlockingQueue q = new LinkedBlockingQueue(0);
87 >            new LinkedBlockingQueue(0);
88              shouldThrow();
89          } catch (IllegalArgumentException success) {}
90      }
91  
92      /**
93 <     * Initializing from null Collection throws NPE
93 >     * Initializing from null Collection throws NullPointerException
94       */
95      public void testConstructor3() {
96          try {
97 <            LinkedBlockingQueue q = new LinkedBlockingQueue(null);
97 >            new LinkedBlockingQueue(null);
98              shouldThrow();
99          } catch (NullPointerException success) {}
100      }
101  
102      /**
103 <     * Initializing from Collection of null elements throws NPE
103 >     * Initializing from Collection of null elements throws NullPointerException
104       */
105      public void testConstructor4() {
106 +        Collection<Integer> elements = Arrays.asList(new Integer[SIZE]);
107          try {
108 <            Integer[] ints = new Integer[SIZE];
76 <            LinkedBlockingQueue q = new LinkedBlockingQueue(Arrays.asList(ints));
108 >            new LinkedBlockingQueue(elements);
109              shouldThrow();
110          } catch (NullPointerException success) {}
111      }
112  
113      /**
114 <     * Initializing from Collection with some null elements throws NPE
114 >     * Initializing from Collection with some null elements throws
115 >     * NullPointerException
116       */
117      public void testConstructor5() {
118 +        Integer[] ints = new Integer[SIZE];
119 +        for (int i = 0; i < SIZE - 1; ++i)
120 +            ints[i] = new Integer(i);
121 +        Collection<Integer> elements = Arrays.asList(ints);
122          try {
123 <            Integer[] ints = new Integer[SIZE];
87 <            for (int i = 0; i < SIZE-1; ++i)
88 <                ints[i] = new Integer(i);
89 <            LinkedBlockingQueue q = new LinkedBlockingQueue(Arrays.asList(ints));
123 >            new LinkedBlockingQueue(elements);
124              shouldThrow();
125          } catch (NullPointerException success) {}
126      }
# Line 122 | Line 156 | public class LinkedBlockingQueueTest ext
156       * remainingCapacity decreases on add, increases on remove
157       */
158      public void testRemainingCapacity() {
159 <        LinkedBlockingQueue q = populatedQueue(SIZE);
159 >        BlockingQueue q = populatedQueue(SIZE);
160          for (int i = 0; i < SIZE; ++i) {
161              assertEquals(i, q.remainingCapacity());
162 <            assertEquals(SIZE-i, q.size());
163 <            q.remove();
162 >            assertEquals(SIZE, q.size() + q.remainingCapacity());
163 >            assertEquals(i, q.remove());
164          }
165          for (int i = 0; i < SIZE; ++i) {
166 <            assertEquals(SIZE-i, q.remainingCapacity());
167 <            assertEquals(i, q.size());
168 <            q.add(new Integer(i));
166 >            assertEquals(SIZE - i, q.remainingCapacity());
167 >            assertEquals(SIZE, q.size() + q.remainingCapacity());
168 >            assertTrue(q.add(i));
169          }
170      }
171  
172      /**
139     * offer(null) throws NPE
140     */
141    public void testOfferNull() {
142        try {
143            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
144            q.offer(null);
145            shouldThrow();
146        } catch (NullPointerException success) {}
147    }
148
149    /**
150     * add(null) throws NPE
151     */
152    public void testAddNull() {
153        try {
154            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
155            q.add(null);
156            shouldThrow();
157        } catch (NullPointerException success) {}
158    }
159
160    /**
173       * Offer succeeds if not full; fails if full
174       */
175      public void testOffer() {
# Line 167 | Line 179 | public class LinkedBlockingQueueTest ext
179      }
180  
181      /**
182 <     * add succeeds if not full; throws ISE if full
182 >     * add succeeds if not full; throws IllegalStateException if full
183       */
184      public void testAdd() {
185 +        LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
186 +        for (int i = 0; i < SIZE; ++i)
187 +            assertTrue(q.add(new Integer(i)));
188 +        assertEquals(0, q.remainingCapacity());
189          try {
174            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
175            for (int i = 0; i < SIZE; ++i) {
176                assertTrue(q.add(new Integer(i)));
177            }
178            assertEquals(0, q.remainingCapacity());
190              q.add(new Integer(SIZE));
191              shouldThrow();
192          } catch (IllegalStateException success) {}
193      }
194  
195      /**
196 <     * addAll(null) throws NPE
186 <     */
187 <    public void testAddAll1() {
188 <        try {
189 <            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
190 <            q.addAll(null);
191 <            shouldThrow();
192 <        } catch (NullPointerException success) {}
193 <    }
194 <
195 <    /**
196 <     * addAll(this) throws IAE
196 >     * addAll(this) throws IllegalArgumentException
197       */
198      public void testAddAllSelf() {
199 +        LinkedBlockingQueue q = populatedQueue(SIZE);
200          try {
200            LinkedBlockingQueue q = populatedQueue(SIZE);
201              q.addAll(q);
202              shouldThrow();
203          } catch (IllegalArgumentException success) {}
204      }
205  
206      /**
207     * addAll of a collection with null elements throws NPE
208     */
209    public void testAddAll2() {
210        try {
211            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
212            Integer[] ints = new Integer[SIZE];
213            q.addAll(Arrays.asList(ints));
214            shouldThrow();
215        } catch (NullPointerException success) {}
216    }
217    /**
207       * addAll of a collection with any null elements throws NPE after
208       * possibly adding some elements
209       */
210      public void testAddAll3() {
211 +        LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
212 +        Integer[] ints = new Integer[SIZE];
213 +        for (int i = 0; i < SIZE - 1; ++i)
214 +            ints[i] = new Integer(i);
215 +        Collection<Integer> elements = Arrays.asList(ints);
216          try {
217 <            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
224 <            Integer[] ints = new Integer[SIZE];
225 <            for (int i = 0; i < SIZE-1; ++i)
226 <                ints[i] = new Integer(i);
227 <            q.addAll(Arrays.asList(ints));
217 >            q.addAll(elements);
218              shouldThrow();
219          } catch (NullPointerException success) {}
220      }
221 +
222      /**
223 <     * addAll throws ISE if not enough room
223 >     * addAll throws IllegalStateException if not enough room
224       */
225      public void testAddAll4() {
226 +        LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE - 1);
227 +        Integer[] ints = new Integer[SIZE];
228 +        for (int i = 0; i < SIZE; ++i)
229 +            ints[i] = new Integer(i);
230 +        Collection<Integer> elements = Arrays.asList(ints);
231          try {
232 <            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
237 <            Integer[] ints = new Integer[SIZE];
238 <            for (int i = 0; i < SIZE; ++i)
239 <                ints[i] = new Integer(i);
240 <            q.addAll(Arrays.asList(ints));
232 >            q.addAll(elements);
233              shouldThrow();
234          } catch (IllegalStateException success) {}
235      }
236 +
237      /**
238       * Queue contains all elements, in traversal order, of successful addAll
239       */
# Line 257 | Line 250 | public class LinkedBlockingQueueTest ext
250      }
251  
252      /**
260     * put(null) throws NPE
261     */
262     public void testPutNull() throws InterruptedException {
263        try {
264            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
265            q.put(null);
266            shouldThrow();
267        } catch (NullPointerException success) {}
268     }
269
270    /**
253       * all elements successfully put are contained
254       */
255      public void testPut() throws InterruptedException {
256          LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
257          for (int i = 0; i < SIZE; ++i) {
258 <            Integer I = new Integer(i);
259 <            q.put(I);
260 <            assertTrue(q.contains(I));
258 >            Integer x = new Integer(i);
259 >            q.put(x);
260 >            assertTrue(q.contains(x));
261          }
262          assertEquals(0, q.remainingCapacity());
263      }
# Line 284 | Line 266 | public class LinkedBlockingQueueTest ext
266       * put blocks interruptibly if full
267       */
268      public void testBlockingPut() throws InterruptedException {
269 <        Thread t = new Thread(new CheckedRunnable() {
270 <            public void realRun() {
271 <                int added = 0;
269 >        final LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
270 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
271 >        Thread t = newStartedThread(new CheckedRunnable() {
272 >            public void realRun() throws InterruptedException {
273 >                for (int i = 0; i < SIZE; ++i)
274 >                    q.put(i);
275 >                assertEquals(SIZE, q.size());
276 >                assertEquals(0, q.remainingCapacity());
277 >
278 >                Thread.currentThread().interrupt();
279                  try {
280 <                    LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
281 <                    for (int i = 0; i < SIZE; ++i) {
282 <                        q.put(new Integer(i));
283 <                        ++added;
284 <                    }
285 <                    q.put(new Integer(SIZE));
286 <                    threadShouldThrow();
287 <                } catch (InterruptedException success) {
288 <                    threadAssertEquals(added, SIZE);
289 <                }
280 >                    q.put(99);
281 >                    shouldThrow();
282 >                } catch (InterruptedException success) {}
283 >                assertFalse(Thread.interrupted());
284 >
285 >                pleaseInterrupt.countDown();
286 >                try {
287 >                    q.put(99);
288 >                    shouldThrow();
289 >                } catch (InterruptedException success) {}
290 >                assertFalse(Thread.interrupted());
291              }});
292  
293 <        t.start();
294 <        Thread.sleep(SHORT_DELAY_MS);
293 >        await(pleaseInterrupt);
294 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
295          t.interrupt();
296 <        t.join();
296 >        awaitTermination(t);
297 >        assertEquals(SIZE, q.size());
298 >        assertEquals(0, q.remainingCapacity());
299      }
300  
301      /**
302 <     * put blocks waiting for take when full
302 >     * put blocks interruptibly waiting for take when full
303       */
304      public void testPutWithTake() throws InterruptedException {
305 +        final int capacity = 2;
306          final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
307 <        Thread t = new Thread(new CheckedRunnable() {
308 <            public void realRun() {
309 <                int added = 0;
307 >        final CountDownLatch pleaseTake = new CountDownLatch(1);
308 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
309 >        Thread t = newStartedThread(new CheckedRunnable() {
310 >            public void realRun() throws InterruptedException {
311 >                for (int i = 0; i < capacity; i++)
312 >                    q.put(i);
313 >                pleaseTake.countDown();
314 >                q.put(86);
315 >
316 >                Thread.currentThread().interrupt();
317 >                try {
318 >                    q.put(99);
319 >                    shouldThrow();
320 >                } catch (InterruptedException success) {}
321 >                assertFalse(Thread.interrupted());
322 >
323 >                pleaseInterrupt.countDown();
324                  try {
325 <                    q.put(new Object());
326 <                    ++added;
327 <                    q.put(new Object());
328 <                    ++added;
322 <                    q.put(new Object());
323 <                    ++added;
324 <                    q.put(new Object());
325 <                    ++added;
326 <                    threadShouldThrow();
327 <                } catch (InterruptedException success) {
328 <                    threadAssertTrue(added >= 2);
329 <                }
325 >                    q.put(99);
326 >                    shouldThrow();
327 >                } catch (InterruptedException success) {}
328 >                assertFalse(Thread.interrupted());
329              }});
330  
331 <        t.start();
332 <        Thread.sleep(SHORT_DELAY_MS);
333 <        q.take();
331 >        await(pleaseTake);
332 >        assertEquals(0, q.remainingCapacity());
333 >        assertEquals(0, q.take());
334 >
335 >        await(pleaseInterrupt);
336 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
337          t.interrupt();
338 <        t.join();
338 >        awaitTermination(t);
339 >        assertEquals(0, q.remainingCapacity());
340      }
341  
342      /**
343       * timed offer times out if full and elements not taken
344       */
345 <    public void testTimedOffer() throws InterruptedException {
345 >    public void testTimedOffer() {
346          final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
347 <        Thread t = new ThreadShouldThrow(InterruptedException.class) {
347 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
348 >        Thread t = newStartedThread(new CheckedRunnable() {
349              public void realRun() throws InterruptedException {
350                  q.put(new Object());
351                  q.put(new Object());
352 <                threadAssertFalse(q.offer(new Object(), SHORT_DELAY_MS, MILLISECONDS));
349 <                q.offer(new Object(), LONG_DELAY_MS, MILLISECONDS);
350 <            }};
352 >                long startTime = System.nanoTime();
353  
354 <        t.start();
355 <        Thread.sleep(SMALL_DELAY_MS);
354 >                assertFalse(q.offer(new Object(), timeoutMillis(), MILLISECONDS));
355 >                assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
356 >
357 >                Thread.currentThread().interrupt();
358 >                try {
359 >                    q.offer(new Object(), randomTimeout(), randomTimeUnit());
360 >                    shouldThrow();
361 >                } catch (InterruptedException success) {}
362 >                assertFalse(Thread.interrupted());
363 >
364 >                pleaseInterrupt.countDown();
365 >                try {
366 >                    q.offer(new Object(), LONGER_DELAY_MS, MILLISECONDS);
367 >                    shouldThrow();
368 >                } catch (InterruptedException success) {}
369 >                assertFalse(Thread.interrupted());
370 >            }});
371 >
372 >        await(pleaseInterrupt);
373 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.TIMED_WAITING);
374          t.interrupt();
375 <        t.join();
375 >        awaitTermination(t);
376      }
377  
378      /**
# Line 361 | Line 381 | public class LinkedBlockingQueueTest ext
381      public void testTake() throws InterruptedException {
382          LinkedBlockingQueue q = populatedQueue(SIZE);
383          for (int i = 0; i < SIZE; ++i) {
384 <            assertEquals(i, ((Integer)q.take()).intValue());
384 >            assertEquals(i, q.take());
385          }
386      }
387  
388      /**
369     * take blocks interruptibly when empty
370     */
371    public void testTakeFromEmpty() throws InterruptedException {
372        final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
373        Thread t = new ThreadShouldThrow(InterruptedException.class) {
374            public void realRun() throws InterruptedException {
375                q.take();
376            }};
377
378        t.start();
379        Thread.sleep(SHORT_DELAY_MS);
380        t.interrupt();
381        t.join();
382    }
383
384    /**
389       * Take removes existing elements until empty, then blocks interruptibly
390       */
391      public void testBlockingTake() throws InterruptedException {
392 <        Thread t = new ThreadShouldThrow(InterruptedException.class) {
392 >        final BlockingQueue q = populatedQueue(SIZE);
393 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
394 >        Thread t = newStartedThread(new CheckedRunnable() {
395              public void realRun() throws InterruptedException {
396 <                LinkedBlockingQueue q = populatedQueue(SIZE);
391 <                for (int i = 0; i < SIZE; ++i) {
392 <                    assertEquals(i, ((Integer)q.take()).intValue());
393 <                }
394 <                q.take();
395 <            }};
396 >                for (int i = 0; i < SIZE; i++) assertEquals(i, q.take());
397  
398 <        t.start();
399 <        Thread.sleep(SHORT_DELAY_MS);
398 >                Thread.currentThread().interrupt();
399 >                try {
400 >                    q.take();
401 >                    shouldThrow();
402 >                } catch (InterruptedException success) {}
403 >                assertFalse(Thread.interrupted());
404 >
405 >                pleaseInterrupt.countDown();
406 >                try {
407 >                    q.take();
408 >                    shouldThrow();
409 >                } catch (InterruptedException success) {}
410 >                assertFalse(Thread.interrupted());
411 >            }});
412 >
413 >        await(pleaseInterrupt);
414 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
415          t.interrupt();
416 <        t.join();
416 >        awaitTermination(t);
417      }
418  
403
419      /**
420       * poll succeeds unless empty
421       */
422      public void testPoll() {
423          LinkedBlockingQueue q = populatedQueue(SIZE);
424          for (int i = 0; i < SIZE; ++i) {
425 <            assertEquals(i, ((Integer)q.poll()).intValue());
425 >            assertEquals(i, q.poll());
426          }
427          assertNull(q.poll());
428      }
429  
430      /**
431 <     * timed pool with zero timeout succeeds when non-empty, else times out
431 >     * timed poll with zero timeout succeeds when non-empty, else times out
432       */
433      public void testTimedPoll0() throws InterruptedException {
434          LinkedBlockingQueue q = populatedQueue(SIZE);
435          for (int i = 0; i < SIZE; ++i) {
436 <            assertEquals(i, ((Integer)q.poll(0, MILLISECONDS)).intValue());
436 >            assertEquals(i, q.poll(0, MILLISECONDS));
437          }
438          assertNull(q.poll(0, MILLISECONDS));
439      }
440  
441      /**
442 <     * timed pool with nonzero timeout succeeds when non-empty, else times out
442 >     * timed poll with nonzero timeout succeeds when non-empty, else times out
443       */
444      public void testTimedPoll() throws InterruptedException {
445 <        LinkedBlockingQueue q = populatedQueue(SIZE);
445 >        LinkedBlockingQueue<Integer> q = populatedQueue(SIZE);
446          for (int i = 0; i < SIZE; ++i) {
447 <            assertEquals(i, ((Integer)q.poll(SHORT_DELAY_MS, MILLISECONDS)).intValue());
448 <        }
449 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
447 >            long startTime = System.nanoTime();
448 >            assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
449 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
450 >        }
451 >        long startTime = System.nanoTime();
452 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
453 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
454 >        checkEmpty(q);
455      }
456  
457      /**
# Line 439 | Line 459 | public class LinkedBlockingQueueTest ext
459       * returning timeout status
460       */
461      public void testInterruptedTimedPoll() throws InterruptedException {
462 <        Thread t = new ThreadShouldThrow(InterruptedException.class) {
462 >        final BlockingQueue<Integer> q = populatedQueue(SIZE);
463 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
464 >        Thread t = newStartedThread(new CheckedRunnable() {
465              public void realRun() throws InterruptedException {
466 <                LinkedBlockingQueue q = populatedQueue(SIZE);
467 <                for (int i = 0; i < SIZE; ++i) {
446 <                    threadAssertEquals(i, ((Integer)q.poll(SHORT_DELAY_MS, MILLISECONDS)).intValue());
447 <                }
448 <                q.poll(SMALL_DELAY_MS, MILLISECONDS);
449 <            }};
466 >                for (int i = 0; i < SIZE; i++)
467 >                    assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
468  
469 <        t.start();
470 <        Thread.sleep(SHORT_DELAY_MS);
471 <        t.interrupt();
472 <        t.join();
473 <    }
469 >                Thread.currentThread().interrupt();
470 >                try {
471 >                    q.poll(randomTimeout(), randomTimeUnit());
472 >                    shouldThrow();
473 >                } catch (InterruptedException success) {}
474 >                assertFalse(Thread.interrupted());
475  
476 <    /**
477 <     *  timed poll before a delayed offer fails; after offer succeeds;
478 <     *  on interruption throws
479 <     */
480 <    public void testTimedPollWithOffer() throws InterruptedException {
481 <        final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
482 <        Thread t = new ThreadShouldThrow(InterruptedException.class) {
464 <            public void realRun() throws InterruptedException {
465 <                threadAssertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
466 <                q.poll(LONG_DELAY_MS, MILLISECONDS);
467 <                q.poll(LONG_DELAY_MS, MILLISECONDS);
468 <            }};
476 >                pleaseInterrupt.countDown();
477 >                try {
478 >                    q.poll(LONGER_DELAY_MS, MILLISECONDS);
479 >                    shouldThrow();
480 >                } catch (InterruptedException success) {}
481 >                assertFalse(Thread.interrupted());
482 >            }});
483  
484 <        t.start();
485 <        Thread.sleep(SMALL_DELAY_MS);
472 <        assertTrue(q.offer(zero, SHORT_DELAY_MS, MILLISECONDS));
484 >        await(pleaseInterrupt);
485 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.TIMED_WAITING);
486          t.interrupt();
487 <        t.join();
487 >        awaitTermination(t);
488 >        checkEmpty(q);
489      }
490  
491      /**
# Line 480 | Line 494 | public class LinkedBlockingQueueTest ext
494      public void testPeek() {
495          LinkedBlockingQueue q = populatedQueue(SIZE);
496          for (int i = 0; i < SIZE; ++i) {
497 <            assertEquals(i, ((Integer)q.peek()).intValue());
498 <            q.poll();
497 >            assertEquals(i, q.peek());
498 >            assertEquals(i, q.poll());
499              assertTrue(q.peek() == null ||
500 <                       i != ((Integer)q.peek()).intValue());
500 >                       !q.peek().equals(i));
501          }
502          assertNull(q.peek());
503      }
# Line 494 | Line 508 | public class LinkedBlockingQueueTest ext
508      public void testElement() {
509          LinkedBlockingQueue q = populatedQueue(SIZE);
510          for (int i = 0; i < SIZE; ++i) {
511 <            assertEquals(i, ((Integer)q.element()).intValue());
512 <            q.poll();
511 >            assertEquals(i, q.element());
512 >            assertEquals(i, q.poll());
513          }
514          try {
515              q.element();
# Line 509 | Line 523 | public class LinkedBlockingQueueTest ext
523      public void testRemove() {
524          LinkedBlockingQueue q = populatedQueue(SIZE);
525          for (int i = 0; i < SIZE; ++i) {
526 <            assertEquals(i, ((Integer)q.remove()).intValue());
526 >            assertEquals(i, q.remove());
527          }
528          try {
529              q.remove();
# Line 518 | Line 532 | public class LinkedBlockingQueueTest ext
532      }
533  
534      /**
521     * remove(x) removes x and returns true if present
522     */
523    public void testRemoveElement() {
524        LinkedBlockingQueue q = populatedQueue(SIZE);
525        for (int i = 1; i < SIZE; i+=2) {
526            assertTrue(q.remove(new Integer(i)));
527        }
528        for (int i = 0; i < SIZE; i+=2) {
529            assertTrue(q.remove(new Integer(i)));
530            assertFalse(q.remove(new Integer(i+1)));
531        }
532        assertTrue(q.isEmpty());
533    }
534
535    /**
535       * An add following remove(x) succeeds
536       */
537      public void testRemoveElementAndAdd() throws InterruptedException {
# Line 542 | Line 541 | public class LinkedBlockingQueueTest ext
541          assertTrue(q.remove(new Integer(1)));
542          assertTrue(q.remove(new Integer(2)));
543          assertTrue(q.add(new Integer(3)));
544 <        assertTrue(q.take() != null);
544 >        assertNotNull(q.take());
545      }
546  
547      /**
# Line 601 | Line 600 | public class LinkedBlockingQueueTest ext
600                  assertTrue(changed);
601  
602              assertTrue(q.containsAll(p));
603 <            assertEquals(SIZE-i, q.size());
603 >            assertEquals(SIZE - i, q.size());
604              p.remove();
605          }
606      }
# Line 614 | Line 613 | public class LinkedBlockingQueueTest ext
613              LinkedBlockingQueue q = populatedQueue(SIZE);
614              LinkedBlockingQueue p = populatedQueue(i);
615              assertTrue(q.removeAll(p));
616 <            assertEquals(SIZE-i, q.size());
616 >            assertEquals(SIZE - i, q.size());
617              for (int j = 0; j < i; ++j) {
618 <                Integer I = (Integer)(p.remove());
619 <                assertFalse(q.contains(I));
618 >                Integer x = (Integer)(p.remove());
619 >                assertFalse(q.contains(x));
620              }
621          }
622      }
623  
624      /**
625 <     * toArray contains all elements
625 >     * toArray contains all elements in FIFO order
626       */
627 <    public void testToArray() throws InterruptedException {
627 >    public void testToArray() {
628          LinkedBlockingQueue q = populatedQueue(SIZE);
629 <        Object[] o = q.toArray();
630 <        for (int i = 0; i < o.length; i++)
631 <            assertEquals(o[i], q.take());
629 >        Object[] a = q.toArray();
630 >        assertSame(Object[].class, a.getClass());
631 >        for (Object o : a)
632 >            assertSame(o, q.poll());
633 >        assertTrue(q.isEmpty());
634      }
635  
636      /**
637 <     * toArray(a) contains all elements
637 >     * toArray(a) contains all elements in FIFO order
638       */
639      public void testToArray2() throws InterruptedException {
640 <        LinkedBlockingQueue q = populatedQueue(SIZE);
640 >        LinkedBlockingQueue<Integer> q = populatedQueue(SIZE);
641          Integer[] ints = new Integer[SIZE];
642 <        ints = (Integer[])q.toArray(ints);
643 <        for (int i = 0; i < ints.length; i++)
644 <            assertEquals(ints[i], q.take());
645 <    }
646 <
646 <    /**
647 <     * toArray(null) throws NPE
648 <     */
649 <    public void testToArray_BadArg() {
650 <        try {
651 <            LinkedBlockingQueue q = populatedQueue(SIZE);
652 <            Object o[] = q.toArray(null);
653 <            shouldThrow();
654 <        } catch (NullPointerException success) {}
642 >        Integer[] array = q.toArray(ints);
643 >        assertSame(ints, array);
644 >        for (Integer o : ints)
645 >            assertSame(o, q.poll());
646 >        assertTrue(q.isEmpty());
647      }
648  
649      /**
650 <     * toArray with incompatible array type throws CCE
650 >     * toArray(incompatible array type) throws ArrayStoreException
651       */
652      public void testToArray1_BadArg() {
653 +        LinkedBlockingQueue q = populatedQueue(SIZE);
654          try {
655 <            LinkedBlockingQueue q = populatedQueue(SIZE);
663 <            Object o[] = q.toArray(new String[10] );
655 >            q.toArray(new String[10]);
656              shouldThrow();
657          } catch (ArrayStoreException success) {}
658      }
659  
668
660      /**
661       * iterator iterates through all elements
662       */
663      public void testIterator() throws InterruptedException {
664          LinkedBlockingQueue q = populatedQueue(SIZE);
665          Iterator it = q.iterator();
666 <        while (it.hasNext()) {
666 >        int i;
667 >        for (i = 0; it.hasNext(); i++)
668 >            assertTrue(q.contains(it.next()));
669 >        assertEquals(i, SIZE);
670 >        assertIteratorExhausted(it);
671 >
672 >        it = q.iterator();
673 >        for (i = 0; it.hasNext(); i++)
674              assertEquals(it.next(), q.take());
675 <        }
675 >        assertEquals(i, SIZE);
676 >        assertIteratorExhausted(it);
677 >    }
678 >
679 >    /**
680 >     * iterator of empty collection has no elements
681 >     */
682 >    public void testEmptyIterator() {
683 >        assertIteratorExhausted(new LinkedBlockingQueue().iterator());
684      }
685  
686      /**
687       * iterator.remove removes current element
688       */
689 <    public void testIteratorRemove () {
689 >    public void testIteratorRemove() {
690          final LinkedBlockingQueue q = new LinkedBlockingQueue(3);
691          q.add(two);
692          q.add(one);
# Line 691 | Line 697 | public class LinkedBlockingQueueTest ext
697          it.remove();
698  
699          it = q.iterator();
700 <        assertEquals(it.next(), one);
701 <        assertEquals(it.next(), three);
700 >        assertSame(it.next(), one);
701 >        assertSame(it.next(), three);
702          assertFalse(it.hasNext());
703      }
704  
699
705      /**
706       * iterator ordering is FIFO
707       */
# Line 708 | Line 713 | public class LinkedBlockingQueueTest ext
713          assertEquals(0, q.remainingCapacity());
714          int k = 0;
715          for (Iterator it = q.iterator(); it.hasNext();) {
716 <            int i = ((Integer)(it.next())).intValue();
712 <            assertEquals(++k, i);
716 >            assertEquals(++k, it.next());
717          }
718          assertEquals(3, k);
719      }
# Line 717 | Line 721 | public class LinkedBlockingQueueTest ext
721      /**
722       * Modifications do not cause iterators to fail
723       */
724 <    public void testWeaklyConsistentIteration () {
724 >    public void testWeaklyConsistentIteration() {
725          final LinkedBlockingQueue q = new LinkedBlockingQueue(3);
726          q.add(one);
727          q.add(two);
# Line 729 | Line 733 | public class LinkedBlockingQueueTest ext
733          assertEquals(0, q.size());
734      }
735  
732
736      /**
737       * toString contains toStrings of elements
738       */
# Line 737 | Line 740 | public class LinkedBlockingQueueTest ext
740          LinkedBlockingQueue q = populatedQueue(SIZE);
741          String s = q.toString();
742          for (int i = 0; i < SIZE; ++i) {
743 <            assertTrue(s.indexOf(String.valueOf(i)) >= 0);
743 >            assertTrue(s.contains(String.valueOf(i)));
744          }
745      }
746  
744
747      /**
748       * offer transfers elements across Executor tasks
749       */
# Line 749 | Line 751 | public class LinkedBlockingQueueTest ext
751          final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
752          q.add(one);
753          q.add(two);
754 <        ExecutorService executor = Executors.newFixedThreadPool(2);
755 <        executor.execute(new CheckedRunnable() {
756 <            public void realRun() throws InterruptedException {
757 <                threadAssertFalse(q.offer(three));
758 <                threadAssertTrue(q.offer(three, MEDIUM_DELAY_MS, MILLISECONDS));
759 <                threadAssertEquals(0, q.remainingCapacity());
760 <            }});
761 <
762 <        executor.execute(new CheckedRunnable() {
763 <            public void realRun() throws InterruptedException {
764 <                Thread.sleep(SMALL_DELAY_MS);
765 <                threadAssertEquals(one, q.take());
766 <            }});
767 <
768 <        joinPool(executor);
754 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
755 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
756 >        try (PoolCleaner cleaner = cleaner(executor)) {
757 >            executor.execute(new CheckedRunnable() {
758 >                public void realRun() throws InterruptedException {
759 >                    assertFalse(q.offer(three));
760 >                    threadsStarted.await();
761 >                    assertTrue(q.offer(three, LONG_DELAY_MS, MILLISECONDS));
762 >                    assertEquals(0, q.remainingCapacity());
763 >                }});
764 >
765 >            executor.execute(new CheckedRunnable() {
766 >                public void realRun() throws InterruptedException {
767 >                    threadsStarted.await();
768 >                    assertSame(one, q.take());
769 >                }});
770 >        }
771      }
772  
773      /**
774 <     * poll retrieves elements across Executor threads
774 >     * timed poll retrieves elements across Executor threads
775       */
776      public void testPollInExecutor() {
777          final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
778 <        ExecutorService executor = Executors.newFixedThreadPool(2);
779 <        executor.execute(new CheckedRunnable() {
780 <            public void realRun() throws InterruptedException {
781 <                threadAssertNull(q.poll());
782 <                threadAssertTrue(null != q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
783 <                threadAssertTrue(q.isEmpty());
784 <            }});
785 <
786 <        executor.execute(new CheckedRunnable() {
787 <            public void realRun() throws InterruptedException {
788 <                Thread.sleep(SMALL_DELAY_MS);
789 <                q.put(one);
790 <            }});
791 <
792 <        joinPool(executor);
778 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
779 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
780 >        try (PoolCleaner cleaner = cleaner(executor)) {
781 >            executor.execute(new CheckedRunnable() {
782 >                public void realRun() throws InterruptedException {
783 >                    assertNull(q.poll());
784 >                    threadsStarted.await();
785 >                    assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
786 >                    checkEmpty(q);
787 >                }});
788 >
789 >            executor.execute(new CheckedRunnable() {
790 >                public void realRun() throws InterruptedException {
791 >                    threadsStarted.await();
792 >                    q.put(one);
793 >                }});
794 >        }
795      }
796  
797      /**
798 <     * A deserialized serialized queue has same elements in same order
798 >     * A deserialized/reserialized queue has same elements in same order
799       */
800      public void testSerialization() throws Exception {
801 <        LinkedBlockingQueue q = populatedQueue(SIZE);
802 <
797 <        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
798 <        ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
799 <        out.writeObject(q);
800 <        out.close();
801 <
802 <        ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
803 <        ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
804 <        LinkedBlockingQueue r = (LinkedBlockingQueue)in.readObject();
805 <        assertEquals(q.size(), r.size());
806 <        while (!q.isEmpty())
807 <            assertEquals(q.remove(), r.remove());
808 <    }
801 >        Queue x = populatedQueue(SIZE);
802 >        Queue y = serialClone(x);
803  
804 <    /**
805 <     * drainTo(null) throws NPE
806 <     */
807 <    public void testDrainToNull() {
808 <        LinkedBlockingQueue q = populatedQueue(SIZE);
809 <        try {
810 <            q.drainTo(null);
811 <            shouldThrow();
812 <        } catch (NullPointerException success) {}
819 <    }
820 <
821 <    /**
822 <     * drainTo(this) throws IAE
823 <     */
824 <    public void testDrainToSelf() {
825 <        LinkedBlockingQueue q = populatedQueue(SIZE);
826 <        try {
827 <            q.drainTo(q);
828 <            shouldThrow();
829 <        } catch (IllegalArgumentException success) {}
804 >        assertNotSame(x, y);
805 >        assertEquals(x.size(), y.size());
806 >        assertEquals(x.toString(), y.toString());
807 >        assertTrue(Arrays.equals(x.toArray(), y.toArray()));
808 >        while (!x.isEmpty()) {
809 >            assertFalse(y.isEmpty());
810 >            assertEquals(x.remove(), y.remove());
811 >        }
812 >        assertTrue(y.isEmpty());
813      }
814  
815      /**
# Line 836 | Line 819 | public class LinkedBlockingQueueTest ext
819          LinkedBlockingQueue q = populatedQueue(SIZE);
820          ArrayList l = new ArrayList();
821          q.drainTo(l);
822 <        assertEquals(q.size(), 0);
823 <        assertEquals(l.size(), SIZE);
822 >        assertEquals(0, q.size());
823 >        assertEquals(SIZE, l.size());
824          for (int i = 0; i < SIZE; ++i)
825              assertEquals(l.get(i), new Integer(i));
826          q.add(zero);
# Line 847 | Line 830 | public class LinkedBlockingQueueTest ext
830          assertTrue(q.contains(one));
831          l.clear();
832          q.drainTo(l);
833 <        assertEquals(q.size(), 0);
834 <        assertEquals(l.size(), 2);
833 >        assertEquals(0, q.size());
834 >        assertEquals(2, l.size());
835          for (int i = 0; i < 2; ++i)
836              assertEquals(l.get(i), new Integer(i));
837      }
# Line 860 | Line 843 | public class LinkedBlockingQueueTest ext
843          final LinkedBlockingQueue q = populatedQueue(SIZE);
844          Thread t = new Thread(new CheckedRunnable() {
845              public void realRun() throws InterruptedException {
846 <                q.put(new Integer(SIZE+1));
846 >                q.put(new Integer(SIZE + 1));
847              }});
848  
849          t.start();
# Line 874 | Line 857 | public class LinkedBlockingQueueTest ext
857      }
858  
859      /**
860 <     * drainTo(null, n) throws NPE
878 <     */
879 <    public void testDrainToNullN() {
880 <        LinkedBlockingQueue q = populatedQueue(SIZE);
881 <        try {
882 <            q.drainTo(null, 0);
883 <            shouldThrow();
884 <        } catch (NullPointerException success) {}
885 <    }
886 <
887 <    /**
888 <     * drainTo(this, n) throws IAE
889 <     */
890 <    public void testDrainToSelfN() {
891 <        LinkedBlockingQueue q = populatedQueue(SIZE);
892 <        try {
893 <            q.drainTo(q, 0);
894 <            shouldThrow();
895 <        } catch (IllegalArgumentException success) {}
896 <    }
897 <
898 <    /**
899 <     * drainTo(c, n) empties first max {n, size} elements of queue into c
860 >     * drainTo(c, n) empties first min(n, size) elements of queue into c
861       */
862      public void testDrainToN() {
863          LinkedBlockingQueue q = new LinkedBlockingQueue();
# Line 905 | Line 866 | public class LinkedBlockingQueueTest ext
866                  assertTrue(q.offer(new Integer(j)));
867              ArrayList l = new ArrayList();
868              q.drainTo(l, i);
869 <            int k = (i < SIZE)? i : SIZE;
870 <            assertEquals(l.size(), k);
871 <            assertEquals(q.size(), SIZE-k);
869 >            int k = (i < SIZE) ? i : SIZE;
870 >            assertEquals(k, l.size());
871 >            assertEquals(SIZE - k, q.size());
872              for (int j = 0; j < k; ++j)
873                  assertEquals(l.get(j), new Integer(j));
874 <            while (q.poll() != null) ;
874 >            do {} while (q.poll() != null);
875 >        }
876 >    }
877 >
878 >    /**
879 >     * remove(null), contains(null) always return false
880 >     */
881 >    public void testNeverContainsNull() {
882 >        Collection<?>[] qs = {
883 >            new LinkedBlockingQueue<Object>(),
884 >            populatedQueue(2),
885 >        };
886 >
887 >        for (Collection<?> q : qs) {
888 >            assertFalse(q.contains(null));
889 >            assertFalse(q.remove(null));
890          }
891      }
892  

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines