ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/LinkedBlockingQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/LinkedBlockingQueueTest.java (file contents):
Revision 1.35 by jsr166, Wed Nov 3 16:46:34 2010 UTC vs.
Revision 1.76 by jsr166, Fri Aug 4 03:30:21 2017 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include Andrew Wright, Jeffrey Hayes,
6   * Pat Fisher, Mike Judd.
7   */
8  
9 import junit.framework.*;
10 import java.util.*;
11 import java.util.concurrent.*;
9   import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 < import java.io.*;
10 >
11 > import java.util.ArrayList;
12 > import java.util.Arrays;
13 > import java.util.Collection;
14 > import java.util.Iterator;
15 > import java.util.NoSuchElementException;
16 > import java.util.Queue;
17 > import java.util.concurrent.BlockingQueue;
18 > import java.util.concurrent.CountDownLatch;
19 > import java.util.concurrent.Executors;
20 > import java.util.concurrent.ExecutorService;
21 > import java.util.concurrent.LinkedBlockingQueue;
22 >
23 > import junit.framework.Test;
24  
25   public class LinkedBlockingQueueTest extends JSR166TestCase {
26  
# Line 22 | Line 32 | public class LinkedBlockingQueueTest ext
32  
33      public static class Bounded extends BlockingQueueTest {
34          protected BlockingQueue emptyCollection() {
35 <            return new LinkedBlockingQueue(20);
35 >            return new LinkedBlockingQueue(SIZE);
36          }
37      }
38  
39      public static void main(String[] args) {
40 <        junit.textui.TestRunner.run(suite());
40 >        main(suite(), args);
41      }
42  
43      public static Test suite() {
44 +        class Implementation implements CollectionImplementation {
45 +            public Class<?> klazz() { return LinkedBlockingQueue.class; }
46 +            public Collection emptyCollection() { return new LinkedBlockingQueue(); }
47 +            public Object makeElement(int i) { return i; }
48 +            public boolean isConcurrent() { return true; }
49 +            public boolean permitsNulls() { return false; }
50 +        }
51          return newTestSuite(LinkedBlockingQueueTest.class,
52                              new Unbounded().testSuite(),
53 <                            new Bounded().testSuite());
53 >                            new Bounded().testSuite(),
54 >                            CollectionTest.testSuite(new Implementation()));
55      }
56  
39
57      /**
58 <     * Create a queue of given size containing consecutive
59 <     * Integers 0 ... n.
58 >     * Returns a new queue of given size containing consecutive
59 >     * Integers 0 ... n - 1.
60       */
61 <    private LinkedBlockingQueue populatedQueue(int n) {
62 <        LinkedBlockingQueue q = new LinkedBlockingQueue(n);
61 >    private static LinkedBlockingQueue<Integer> populatedQueue(int n) {
62 >        LinkedBlockingQueue<Integer> q =
63 >            new LinkedBlockingQueue<Integer>(n);
64          assertTrue(q.isEmpty());
65          for (int i = 0; i < n; i++)
66              assertTrue(q.offer(new Integer(i)));
67          assertFalse(q.isEmpty());
68          assertEquals(0, q.remainingCapacity());
69          assertEquals(n, q.size());
70 +        assertEquals((Integer) 0, q.peek());
71          return q;
72      }
73  
# Line 62 | Line 81 | public class LinkedBlockingQueueTest ext
81      }
82  
83      /**
84 <     * Constructor throws IAE if capacity argument nonpositive
84 >     * Constructor throws IllegalArgumentException if capacity argument nonpositive
85       */
86      public void testConstructor2() {
87          try {
88 <            LinkedBlockingQueue q = new LinkedBlockingQueue(0);
88 >            new LinkedBlockingQueue(0);
89              shouldThrow();
90          } catch (IllegalArgumentException success) {}
91      }
92  
93      /**
94 <     * Initializing from null Collection throws NPE
94 >     * Initializing from null Collection throws NullPointerException
95       */
96      public void testConstructor3() {
97          try {
98 <            LinkedBlockingQueue q = new LinkedBlockingQueue(null);
98 >            new LinkedBlockingQueue(null);
99              shouldThrow();
100          } catch (NullPointerException success) {}
101      }
102  
103      /**
104 <     * Initializing from Collection of null elements throws NPE
104 >     * Initializing from Collection of null elements throws NullPointerException
105       */
106      public void testConstructor4() {
107 +        Collection<Integer> elements = Arrays.asList(new Integer[SIZE]);
108          try {
109 <            Integer[] ints = new Integer[SIZE];
90 <            LinkedBlockingQueue q = new LinkedBlockingQueue(Arrays.asList(ints));
109 >            new LinkedBlockingQueue(elements);
110              shouldThrow();
111          } catch (NullPointerException success) {}
112      }
113  
114      /**
115 <     * Initializing from Collection with some null elements throws NPE
115 >     * Initializing from Collection with some null elements throws
116 >     * NullPointerException
117       */
118      public void testConstructor5() {
119 +        Integer[] ints = new Integer[SIZE];
120 +        for (int i = 0; i < SIZE - 1; ++i)
121 +            ints[i] = new Integer(i);
122 +        Collection<Integer> elements = Arrays.asList(ints);
123          try {
124 <            Integer[] ints = new Integer[SIZE];
101 <            for (int i = 0; i < SIZE-1; ++i)
102 <                ints[i] = new Integer(i);
103 <            LinkedBlockingQueue q = new LinkedBlockingQueue(Arrays.asList(ints));
124 >            new LinkedBlockingQueue(elements);
125              shouldThrow();
126          } catch (NullPointerException success) {}
127      }
# Line 136 | Line 157 | public class LinkedBlockingQueueTest ext
157       * remainingCapacity decreases on add, increases on remove
158       */
159      public void testRemainingCapacity() {
160 <        LinkedBlockingQueue q = populatedQueue(SIZE);
160 >        BlockingQueue q = populatedQueue(SIZE);
161          for (int i = 0; i < SIZE; ++i) {
162              assertEquals(i, q.remainingCapacity());
163 <            assertEquals(SIZE-i, q.size());
164 <            q.remove();
163 >            assertEquals(SIZE, q.size() + q.remainingCapacity());
164 >            assertEquals(i, q.remove());
165          }
166          for (int i = 0; i < SIZE; ++i) {
167 <            assertEquals(SIZE-i, q.remainingCapacity());
168 <            assertEquals(i, q.size());
169 <            q.add(new Integer(i));
167 >            assertEquals(SIZE - i, q.remainingCapacity());
168 >            assertEquals(SIZE, q.size() + q.remainingCapacity());
169 >            assertTrue(q.add(i));
170          }
171      }
172  
173      /**
153     * offer(null) throws NPE
154     */
155    public void testOfferNull() {
156        try {
157            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
158            q.offer(null);
159            shouldThrow();
160        } catch (NullPointerException success) {}
161    }
162
163    /**
164     * add(null) throws NPE
165     */
166    public void testAddNull() {
167        try {
168            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
169            q.add(null);
170            shouldThrow();
171        } catch (NullPointerException success) {}
172    }
173
174    /**
174       * Offer succeeds if not full; fails if full
175       */
176      public void testOffer() {
# Line 181 | Line 180 | public class LinkedBlockingQueueTest ext
180      }
181  
182      /**
183 <     * add succeeds if not full; throws ISE if full
183 >     * add succeeds if not full; throws IllegalStateException if full
184       */
185      public void testAdd() {
186 +        LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
187 +        for (int i = 0; i < SIZE; ++i)
188 +            assertTrue(q.add(new Integer(i)));
189 +        assertEquals(0, q.remainingCapacity());
190          try {
188            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
189            for (int i = 0; i < SIZE; ++i) {
190                assertTrue(q.add(new Integer(i)));
191            }
192            assertEquals(0, q.remainingCapacity());
191              q.add(new Integer(SIZE));
192              shouldThrow();
193          } catch (IllegalStateException success) {}
194      }
195  
196      /**
197 <     * addAll(null) throws NPE
200 <     */
201 <    public void testAddAll1() {
202 <        try {
203 <            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
204 <            q.addAll(null);
205 <            shouldThrow();
206 <        } catch (NullPointerException success) {}
207 <    }
208 <
209 <    /**
210 <     * addAll(this) throws IAE
197 >     * addAll(this) throws IllegalArgumentException
198       */
199      public void testAddAllSelf() {
200 +        LinkedBlockingQueue q = populatedQueue(SIZE);
201          try {
214            LinkedBlockingQueue q = populatedQueue(SIZE);
202              q.addAll(q);
203              shouldThrow();
204          } catch (IllegalArgumentException success) {}
205      }
206  
207      /**
221     * addAll of a collection with null elements throws NPE
222     */
223    public void testAddAll2() {
224        try {
225            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
226            Integer[] ints = new Integer[SIZE];
227            q.addAll(Arrays.asList(ints));
228            shouldThrow();
229        } catch (NullPointerException success) {}
230    }
231
232    /**
208       * addAll of a collection with any null elements throws NPE after
209       * possibly adding some elements
210       */
211      public void testAddAll3() {
212 +        LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
213 +        Integer[] ints = new Integer[SIZE];
214 +        for (int i = 0; i < SIZE - 1; ++i)
215 +            ints[i] = new Integer(i);
216 +        Collection<Integer> elements = Arrays.asList(ints);
217          try {
218 <            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
239 <            Integer[] ints = new Integer[SIZE];
240 <            for (int i = 0; i < SIZE-1; ++i)
241 <                ints[i] = new Integer(i);
242 <            q.addAll(Arrays.asList(ints));
218 >            q.addAll(elements);
219              shouldThrow();
220          } catch (NullPointerException success) {}
221      }
222  
223      /**
224 <     * addAll throws ISE if not enough room
224 >     * addAll throws IllegalStateException if not enough room
225       */
226      public void testAddAll4() {
227 +        LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE - 1);
228 +        Integer[] ints = new Integer[SIZE];
229 +        for (int i = 0; i < SIZE; ++i)
230 +            ints[i] = new Integer(i);
231 +        Collection<Integer> elements = Arrays.asList(ints);
232          try {
233 <            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
253 <            Integer[] ints = new Integer[SIZE];
254 <            for (int i = 0; i < SIZE; ++i)
255 <                ints[i] = new Integer(i);
256 <            q.addAll(Arrays.asList(ints));
233 >            q.addAll(elements);
234              shouldThrow();
235          } catch (IllegalStateException success) {}
236      }
# Line 274 | Line 251 | public class LinkedBlockingQueueTest ext
251      }
252  
253      /**
277     * put(null) throws NPE
278     */
279     public void testPutNull() throws InterruptedException {
280        try {
281            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
282            q.put(null);
283            shouldThrow();
284        } catch (NullPointerException success) {}
285     }
286
287    /**
254       * all elements successfully put are contained
255       */
256      public void testPut() throws InterruptedException {
257          LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
258          for (int i = 0; i < SIZE; ++i) {
259 <            Integer I = new Integer(i);
260 <            q.put(I);
261 <            assertTrue(q.contains(I));
259 >            Integer x = new Integer(i);
260 >            q.put(x);
261 >            assertTrue(q.contains(x));
262          }
263          assertEquals(0, q.remainingCapacity());
264      }
# Line 302 | Line 268 | public class LinkedBlockingQueueTest ext
268       */
269      public void testBlockingPut() throws InterruptedException {
270          final LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
271 <        Thread t = new Thread(new CheckedRunnable() {
271 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
272 >        Thread t = newStartedThread(new CheckedRunnable() {
273              public void realRun() throws InterruptedException {
274                  for (int i = 0; i < SIZE; ++i)
275                      q.put(i);
276                  assertEquals(SIZE, q.size());
277                  assertEquals(0, q.remainingCapacity());
278 +
279 +                Thread.currentThread().interrupt();
280 +                try {
281 +                    q.put(99);
282 +                    shouldThrow();
283 +                } catch (InterruptedException success) {}
284 +                assertFalse(Thread.interrupted());
285 +
286 +                pleaseInterrupt.countDown();
287                  try {
288                      q.put(99);
289                      shouldThrow();
290                  } catch (InterruptedException success) {}
291 +                assertFalse(Thread.interrupted());
292              }});
293  
294 <        t.start();
295 <        Thread.sleep(SHORT_DELAY_MS);
294 >        await(pleaseInterrupt);
295 >        assertThreadBlocks(t, Thread.State.WAITING);
296          t.interrupt();
297 <        t.join();
297 >        awaitTermination(t);
298          assertEquals(SIZE, q.size());
299          assertEquals(0, q.remainingCapacity());
300      }
301  
302      /**
303 <     * put blocks waiting for take when full
303 >     * put blocks interruptibly waiting for take when full
304       */
305      public void testPutWithTake() throws InterruptedException {
306          final int capacity = 2;
307          final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
308 <        Thread t = new Thread(new CheckedRunnable() {
308 >        final CountDownLatch pleaseTake = new CountDownLatch(1);
309 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
310 >        Thread t = newStartedThread(new CheckedRunnable() {
311              public void realRun() throws InterruptedException {
312 <                for (int i = 0; i < capacity + 1; i++)
312 >                for (int i = 0; i < capacity; i++)
313                      q.put(i);
314 +                pleaseTake.countDown();
315 +                q.put(86);
316 +
317 +                Thread.currentThread().interrupt();
318                  try {
319                      q.put(99);
320                      shouldThrow();
321                  } catch (InterruptedException success) {}
322 +                assertFalse(Thread.interrupted());
323 +
324 +                pleaseInterrupt.countDown();
325 +                try {
326 +                    q.put(99);
327 +                    shouldThrow();
328 +                } catch (InterruptedException success) {}
329 +                assertFalse(Thread.interrupted());
330              }});
331  
332 <        t.start();
333 <        Thread.sleep(SHORT_DELAY_MS);
343 <        assertEquals(q.remainingCapacity(), 0);
332 >        await(pleaseTake);
333 >        assertEquals(0, q.remainingCapacity());
334          assertEquals(0, q.take());
335 <        Thread.sleep(SHORT_DELAY_MS);
335 >
336 >        await(pleaseInterrupt);
337 >        assertThreadBlocks(t, Thread.State.WAITING);
338          t.interrupt();
339 <        t.join();
340 <        assertEquals(q.remainingCapacity(), 0);
339 >        awaitTermination(t);
340 >        assertEquals(0, q.remainingCapacity());
341      }
342  
343      /**
344       * timed offer times out if full and elements not taken
345       */
346 <    public void testTimedOffer() throws InterruptedException {
346 >    public void testTimedOffer() {
347          final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
348 <        Thread t = new Thread(new CheckedRunnable() {
348 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
349 >        Thread t = newStartedThread(new CheckedRunnable() {
350              public void realRun() throws InterruptedException {
351                  q.put(new Object());
352                  q.put(new Object());
353 <                assertFalse(q.offer(new Object(), SHORT_DELAY_MS, MILLISECONDS));
353 >
354 >                long startTime = System.nanoTime();
355 >                assertFalse(q.offer(new Object(), timeoutMillis(), MILLISECONDS));
356 >                assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
357 >
358 >                Thread.currentThread().interrupt();
359 >                try {
360 >                    q.offer(new Object(), 2 * LONG_DELAY_MS, MILLISECONDS);
361 >                    shouldThrow();
362 >                } catch (InterruptedException success) {}
363 >                assertFalse(Thread.interrupted());
364 >
365 >                pleaseInterrupt.countDown();
366                  try {
367 <                    q.offer(new Object(), LONG_DELAY_MS, MILLISECONDS);
367 >                    q.offer(new Object(), 2 * LONG_DELAY_MS, MILLISECONDS);
368                      shouldThrow();
369                  } catch (InterruptedException success) {}
370 +                assertFalse(Thread.interrupted());
371              }});
372  
373 <        t.start();
374 <        Thread.sleep(SMALL_DELAY_MS);
373 >        await(pleaseInterrupt);
374 >        assertThreadBlocks(t, Thread.State.TIMED_WAITING);
375          t.interrupt();
376 <        t.join();
376 >        awaitTermination(t);
377      }
378  
379      /**
# Line 384 | Line 390 | public class LinkedBlockingQueueTest ext
390       * Take removes existing elements until empty, then blocks interruptibly
391       */
392      public void testBlockingTake() throws InterruptedException {
393 <        final LinkedBlockingQueue q = populatedQueue(SIZE);
394 <        Thread t = new Thread(new CheckedRunnable() {
393 >        final BlockingQueue q = populatedQueue(SIZE);
394 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
395 >        Thread t = newStartedThread(new CheckedRunnable() {
396              public void realRun() throws InterruptedException {
397 <                for (int i = 0; i < SIZE; ++i) {
398 <                    assertEquals(i, q.take());
399 <                }
397 >                for (int i = 0; i < SIZE; i++) assertEquals(i, q.take());
398 >
399 >                Thread.currentThread().interrupt();
400 >                try {
401 >                    q.take();
402 >                    shouldThrow();
403 >                } catch (InterruptedException success) {}
404 >                assertFalse(Thread.interrupted());
405 >
406 >                pleaseInterrupt.countDown();
407                  try {
408                      q.take();
409                      shouldThrow();
410                  } catch (InterruptedException success) {}
411 +                assertFalse(Thread.interrupted());
412              }});
413  
414 <        t.start();
415 <        Thread.sleep(SHORT_DELAY_MS);
414 >        await(pleaseInterrupt);
415 >        assertThreadBlocks(t, Thread.State.WAITING);
416          t.interrupt();
417 <        t.join();
417 >        awaitTermination(t);
418      }
419  
420      /**
# Line 428 | Line 443 | public class LinkedBlockingQueueTest ext
443       * timed poll with nonzero timeout succeeds when non-empty, else times out
444       */
445      public void testTimedPoll() throws InterruptedException {
446 <        LinkedBlockingQueue q = populatedQueue(SIZE);
446 >        LinkedBlockingQueue<Integer> q = populatedQueue(SIZE);
447          for (int i = 0; i < SIZE; ++i) {
448 <            assertEquals(i, q.poll(SHORT_DELAY_MS, MILLISECONDS));
449 <        }
450 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
448 >            long startTime = System.nanoTime();
449 >            assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
450 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
451 >        }
452 >        long startTime = System.nanoTime();
453 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
454 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
455 >        checkEmpty(q);
456      }
457  
458      /**
# Line 440 | Line 460 | public class LinkedBlockingQueueTest ext
460       * returning timeout status
461       */
462      public void testInterruptedTimedPoll() throws InterruptedException {
463 <        Thread t = new Thread(new CheckedRunnable() {
463 >        final BlockingQueue<Integer> q = populatedQueue(SIZE);
464 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
465 >        Thread t = newStartedThread(new CheckedRunnable() {
466              public void realRun() throws InterruptedException {
467 <                LinkedBlockingQueue q = populatedQueue(SIZE);
468 <                for (int i = 0; i < SIZE; ++i) {
469 <                    assertEquals(i, q.poll(SHORT_DELAY_MS, MILLISECONDS));
470 <                }
467 >                long startTime = System.nanoTime();
468 >                for (int i = 0; i < SIZE; i++)
469 >                    assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
470 >
471 >                Thread.currentThread().interrupt();
472 >                try {
473 >                    q.poll(LONG_DELAY_MS, MILLISECONDS);
474 >                    shouldThrow();
475 >                } catch (InterruptedException success) {}
476 >                assertFalse(Thread.interrupted());
477 >
478 >                pleaseInterrupt.countDown();
479                  try {
480 <                    q.poll(SMALL_DELAY_MS, MILLISECONDS);
480 >                    q.poll(LONG_DELAY_MS, MILLISECONDS);
481                      shouldThrow();
482                  } catch (InterruptedException success) {}
483 +                assertFalse(Thread.interrupted());
484 +
485 +                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
486              }});
487  
488 <        t.start();
489 <        Thread.sleep(SHORT_DELAY_MS);
488 >        await(pleaseInterrupt);
489 >        assertThreadBlocks(t, Thread.State.TIMED_WAITING);
490          t.interrupt();
491 <        t.join();
491 >        awaitTermination(t);
492 >        checkEmpty(q);
493      }
494  
495      /**
# Line 502 | Line 536 | public class LinkedBlockingQueueTest ext
536      }
537  
538      /**
505     * remove(x) removes x and returns true if present
506     */
507    public void testRemoveElement() {
508        LinkedBlockingQueue q = populatedQueue(SIZE);
509        for (int i = 1; i < SIZE; i+=2) {
510            assertTrue(q.remove(new Integer(i)));
511        }
512        for (int i = 0; i < SIZE; i+=2) {
513            assertTrue(q.remove(new Integer(i)));
514            assertFalse(q.remove(new Integer(i+1)));
515        }
516        assertTrue(q.isEmpty());
517    }
518
519    /**
539       * An add following remove(x) succeeds
540       */
541      public void testRemoveElementAndAdd() throws InterruptedException {
# Line 526 | Line 545 | public class LinkedBlockingQueueTest ext
545          assertTrue(q.remove(new Integer(1)));
546          assertTrue(q.remove(new Integer(2)));
547          assertTrue(q.add(new Integer(3)));
548 <        assertTrue(q.take() != null);
548 >        assertNotNull(q.take());
549      }
550  
551      /**
# Line 585 | Line 604 | public class LinkedBlockingQueueTest ext
604                  assertTrue(changed);
605  
606              assertTrue(q.containsAll(p));
607 <            assertEquals(SIZE-i, q.size());
607 >            assertEquals(SIZE - i, q.size());
608              p.remove();
609          }
610      }
# Line 598 | Line 617 | public class LinkedBlockingQueueTest ext
617              LinkedBlockingQueue q = populatedQueue(SIZE);
618              LinkedBlockingQueue p = populatedQueue(i);
619              assertTrue(q.removeAll(p));
620 <            assertEquals(SIZE-i, q.size());
620 >            assertEquals(SIZE - i, q.size());
621              for (int j = 0; j < i; ++j) {
622 <                Integer I = (Integer)(p.remove());
623 <                assertFalse(q.contains(I));
622 >                Integer x = (Integer)(p.remove());
623 >                assertFalse(q.contains(x));
624              }
625          }
626      }
627  
628      /**
629 <     * toArray contains all elements
629 >     * toArray contains all elements in FIFO order
630       */
631 <    public void testToArray() throws InterruptedException {
631 >    public void testToArray() {
632          LinkedBlockingQueue q = populatedQueue(SIZE);
633          Object[] o = q.toArray();
634          for (int i = 0; i < o.length; i++)
635 <            assertEquals(o[i], q.take());
635 >            assertSame(o[i], q.poll());
636      }
637  
638      /**
639 <     * toArray(a) contains all elements
639 >     * toArray(a) contains all elements in FIFO order
640       */
641      public void testToArray2() throws InterruptedException {
642 <        LinkedBlockingQueue q = populatedQueue(SIZE);
642 >        LinkedBlockingQueue<Integer> q = populatedQueue(SIZE);
643          Integer[] ints = new Integer[SIZE];
644 <        ints = (Integer[])q.toArray(ints);
644 >        Integer[] array = q.toArray(ints);
645 >        assertSame(ints, array);
646          for (int i = 0; i < ints.length; i++)
647 <            assertEquals(ints[i], q.take());
628 <    }
629 <
630 <    /**
631 <     * toArray(null) throws NullPointerException
632 <     */
633 <    public void testToArray_NullArg() {
634 <        LinkedBlockingQueue q = populatedQueue(SIZE);
635 <        try {
636 <            q.toArray(null);
637 <            shouldThrow();
638 <        } catch (NullPointerException success) {}
647 >            assertSame(ints[i], q.poll());
648      }
649  
650      /**
# Line 649 | Line 658 | public class LinkedBlockingQueueTest ext
658          } catch (ArrayStoreException success) {}
659      }
660  
652
661      /**
662       * iterator iterates through all elements
663       */
664      public void testIterator() throws InterruptedException {
665          LinkedBlockingQueue q = populatedQueue(SIZE);
666          Iterator it = q.iterator();
667 <        while (it.hasNext()) {
667 >        int i;
668 >        for (i = 0; it.hasNext(); i++)
669 >            assertTrue(q.contains(it.next()));
670 >        assertEquals(i, SIZE);
671 >        assertIteratorExhausted(it);
672 >
673 >        it = q.iterator();
674 >        for (i = 0; it.hasNext(); i++)
675              assertEquals(it.next(), q.take());
676 <        }
676 >        assertEquals(i, SIZE);
677 >        assertIteratorExhausted(it);
678 >    }
679 >
680 >    /**
681 >     * iterator of empty collection has no elements
682 >     */
683 >    public void testEmptyIterator() {
684 >        assertIteratorExhausted(new LinkedBlockingQueue().iterator());
685      }
686  
687      /**
# Line 680 | Line 703 | public class LinkedBlockingQueueTest ext
703          assertFalse(it.hasNext());
704      }
705  
683
706      /**
707       * iterator ordering is FIFO
708       */
# Line 712 | Line 734 | public class LinkedBlockingQueueTest ext
734          assertEquals(0, q.size());
735      }
736  
715
737      /**
738       * toString contains toStrings of elements
739       */
# Line 720 | Line 741 | public class LinkedBlockingQueueTest ext
741          LinkedBlockingQueue q = populatedQueue(SIZE);
742          String s = q.toString();
743          for (int i = 0; i < SIZE; ++i) {
744 <            assertTrue(s.indexOf(String.valueOf(i)) >= 0);
744 >            assertTrue(s.contains(String.valueOf(i)));
745          }
746      }
747  
727
748      /**
749       * offer transfers elements across Executor tasks
750       */
# Line 732 | Line 752 | public class LinkedBlockingQueueTest ext
752          final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
753          q.add(one);
754          q.add(two);
755 <        ExecutorService executor = Executors.newFixedThreadPool(2);
756 <        executor.execute(new CheckedRunnable() {
757 <            public void realRun() throws InterruptedException {
758 <                assertFalse(q.offer(three));
759 <                assertTrue(q.offer(three, MEDIUM_DELAY_MS, MILLISECONDS));
760 <                assertEquals(0, q.remainingCapacity());
761 <            }});
762 <
763 <        executor.execute(new CheckedRunnable() {
764 <            public void realRun() throws InterruptedException {
765 <                Thread.sleep(SMALL_DELAY_MS);
766 <                assertSame(one, q.take());
767 <            }});
768 <
769 <        joinPool(executor);
755 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
756 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
757 >        try (PoolCleaner cleaner = cleaner(executor)) {
758 >            executor.execute(new CheckedRunnable() {
759 >                public void realRun() throws InterruptedException {
760 >                    assertFalse(q.offer(three));
761 >                    threadsStarted.await();
762 >                    assertTrue(q.offer(three, LONG_DELAY_MS, MILLISECONDS));
763 >                    assertEquals(0, q.remainingCapacity());
764 >                }});
765 >
766 >            executor.execute(new CheckedRunnable() {
767 >                public void realRun() throws InterruptedException {
768 >                    threadsStarted.await();
769 >                    assertSame(one, q.take());
770 >                }});
771 >        }
772      }
773  
774      /**
775 <     * poll retrieves elements across Executor threads
775 >     * timed poll retrieves elements across Executor threads
776       */
777      public void testPollInExecutor() {
778          final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
779 <        ExecutorService executor = Executors.newFixedThreadPool(2);
780 <        executor.execute(new CheckedRunnable() {
781 <            public void realRun() throws InterruptedException {
782 <                assertNull(q.poll());
783 <                assertSame(one, q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
784 <                assertTrue(q.isEmpty());
785 <            }});
786 <
787 <        executor.execute(new CheckedRunnable() {
788 <            public void realRun() throws InterruptedException {
789 <                Thread.sleep(SMALL_DELAY_MS);
790 <                q.put(one);
791 <            }});
792 <
793 <        joinPool(executor);
779 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
780 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
781 >        try (PoolCleaner cleaner = cleaner(executor)) {
782 >            executor.execute(new CheckedRunnable() {
783 >                public void realRun() throws InterruptedException {
784 >                    assertNull(q.poll());
785 >                    threadsStarted.await();
786 >                    assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
787 >                    checkEmpty(q);
788 >                }});
789 >
790 >            executor.execute(new CheckedRunnable() {
791 >                public void realRun() throws InterruptedException {
792 >                    threadsStarted.await();
793 >                    q.put(one);
794 >                }});
795 >        }
796      }
797  
798      /**
799 <     * A deserialized serialized queue has same elements in same order
799 >     * A deserialized/reserialized queue has same elements in same order
800       */
801      public void testSerialization() throws Exception {
802 <        LinkedBlockingQueue q = populatedQueue(SIZE);
803 <
780 <        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
781 <        ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
782 <        out.writeObject(q);
783 <        out.close();
784 <
785 <        ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
786 <        ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
787 <        LinkedBlockingQueue r = (LinkedBlockingQueue)in.readObject();
788 <        assertEquals(q.size(), r.size());
789 <        while (!q.isEmpty())
790 <            assertEquals(q.remove(), r.remove());
791 <    }
792 <
793 <    /**
794 <     * drainTo(null) throws NPE
795 <     */
796 <    public void testDrainToNull() {
797 <        LinkedBlockingQueue q = populatedQueue(SIZE);
798 <        try {
799 <            q.drainTo(null);
800 <            shouldThrow();
801 <        } catch (NullPointerException success) {}
802 <    }
802 >        Queue x = populatedQueue(SIZE);
803 >        Queue y = serialClone(x);
804  
805 <    /**
806 <     * drainTo(this) throws IAE
807 <     */
808 <    public void testDrainToSelf() {
809 <        LinkedBlockingQueue q = populatedQueue(SIZE);
810 <        try {
811 <            q.drainTo(q);
812 <            shouldThrow();
813 <        } catch (IllegalArgumentException success) {}
805 >        assertNotSame(x, y);
806 >        assertEquals(x.size(), y.size());
807 >        assertEquals(x.toString(), y.toString());
808 >        assertTrue(Arrays.equals(x.toArray(), y.toArray()));
809 >        while (!x.isEmpty()) {
810 >            assertFalse(y.isEmpty());
811 >            assertEquals(x.remove(), y.remove());
812 >        }
813 >        assertTrue(y.isEmpty());
814      }
815  
816      /**
# Line 819 | Line 820 | public class LinkedBlockingQueueTest ext
820          LinkedBlockingQueue q = populatedQueue(SIZE);
821          ArrayList l = new ArrayList();
822          q.drainTo(l);
823 <        assertEquals(q.size(), 0);
824 <        assertEquals(l.size(), SIZE);
823 >        assertEquals(0, q.size());
824 >        assertEquals(SIZE, l.size());
825          for (int i = 0; i < SIZE; ++i)
826              assertEquals(l.get(i), new Integer(i));
827          q.add(zero);
# Line 830 | Line 831 | public class LinkedBlockingQueueTest ext
831          assertTrue(q.contains(one));
832          l.clear();
833          q.drainTo(l);
834 <        assertEquals(q.size(), 0);
835 <        assertEquals(l.size(), 2);
834 >        assertEquals(0, q.size());
835 >        assertEquals(2, l.size());
836          for (int i = 0; i < 2; ++i)
837              assertEquals(l.get(i), new Integer(i));
838      }
# Line 843 | Line 844 | public class LinkedBlockingQueueTest ext
844          final LinkedBlockingQueue q = populatedQueue(SIZE);
845          Thread t = new Thread(new CheckedRunnable() {
846              public void realRun() throws InterruptedException {
847 <                q.put(new Integer(SIZE+1));
847 >                q.put(new Integer(SIZE + 1));
848              }});
849  
850          t.start();
# Line 857 | Line 858 | public class LinkedBlockingQueueTest ext
858      }
859  
860      /**
860     * drainTo(null, n) throws NPE
861     */
862    public void testDrainToNullN() {
863        LinkedBlockingQueue q = populatedQueue(SIZE);
864        try {
865            q.drainTo(null, 0);
866            shouldThrow();
867        } catch (NullPointerException success) {}
868    }
869
870    /**
871     * drainTo(this, n) throws IAE
872     */
873    public void testDrainToSelfN() {
874        LinkedBlockingQueue q = populatedQueue(SIZE);
875        try {
876            q.drainTo(q, 0);
877            shouldThrow();
878        } catch (IllegalArgumentException success) {}
879    }
880
881    /**
861       * drainTo(c, n) empties first min(n, size) elements of queue into c
862       */
863      public void testDrainToN() {
# Line 889 | Line 868 | public class LinkedBlockingQueueTest ext
868              ArrayList l = new ArrayList();
869              q.drainTo(l, i);
870              int k = (i < SIZE) ? i : SIZE;
871 <            assertEquals(l.size(), k);
872 <            assertEquals(q.size(), SIZE-k);
871 >            assertEquals(k, l.size());
872 >            assertEquals(SIZE - k, q.size());
873              for (int j = 0; j < k; ++j)
874                  assertEquals(l.get(j), new Integer(j));
875 <            while (q.poll() != null) ;
875 >            do {} while (q.poll() != null);
876 >        }
877 >    }
878 >
879 >    /**
880 >     * remove(null), contains(null) always return false
881 >     */
882 >    public void testNeverContainsNull() {
883 >        Collection<?>[] qs = {
884 >            new LinkedBlockingQueue<Object>(),
885 >            populatedQueue(2),
886 >        };
887 >
888 >        for (Collection<?> q : qs) {
889 >            assertFalse(q.contains(null));
890 >            assertFalse(q.remove(null));
891          }
892      }
893  

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines