ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/LinkedBlockingQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/LinkedBlockingQueueTest.java (file contents):
Revision 1.20 by jsr166, Sat Nov 21 21:00:34 2009 UTC vs.
Revision 1.46 by jsr166, Tue May 31 16:16:24 2011 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include Andrew Wright, Jeffrey Hayes,
6   * Pat Fisher, Mike Judd.
7   */
8  
9   import junit.framework.*;
10 < import java.util.*;
11 < import java.util.concurrent.*;
10 > import java.util.Arrays;
11 > import java.util.ArrayList;
12 > import java.util.Collection;
13 > import java.util.Iterator;
14 > import java.util.NoSuchElementException;
15 > import java.util.Queue;
16 > import java.util.concurrent.BlockingQueue;
17 > import java.util.concurrent.CountDownLatch;
18 > import java.util.concurrent.LinkedBlockingQueue;
19 > import java.util.concurrent.Executors;
20 > import java.util.concurrent.ExecutorService;
21   import static java.util.concurrent.TimeUnit.MILLISECONDS;
13 import java.io.*;
22  
23   public class LinkedBlockingQueueTest extends JSR166TestCase {
24  
25 +    public static class Unbounded extends BlockingQueueTest {
26 +        protected BlockingQueue emptyCollection() {
27 +            return new LinkedBlockingQueue();
28 +        }
29 +    }
30 +
31 +    public static class Bounded extends BlockingQueueTest {
32 +        protected BlockingQueue emptyCollection() {
33 +            return new LinkedBlockingQueue(20);
34 +        }
35 +    }
36 +
37      public static void main(String[] args) {
38 <        junit.textui.TestRunner.run (suite());
38 >        junit.textui.TestRunner.run(suite());
39      }
40  
41      public static Test suite() {
42 <        return new TestSuite(LinkedBlockingQueueTest.class);
42 >        return newTestSuite(LinkedBlockingQueueTest.class,
43 >                            new Unbounded().testSuite(),
44 >                            new Bounded().testSuite());
45      }
46  
25
47      /**
48       * Create a queue of given size containing consecutive
49       * Integers 0 ... n.
50       */
51 <    private LinkedBlockingQueue populatedQueue(int n) {
52 <        LinkedBlockingQueue q = new LinkedBlockingQueue(n);
51 >    private LinkedBlockingQueue<Integer> populatedQueue(int n) {
52 >        LinkedBlockingQueue<Integer> q =
53 >            new LinkedBlockingQueue<Integer>(n);
54          assertTrue(q.isEmpty());
55          for (int i = 0; i < n; i++)
56              assertTrue(q.offer(new Integer(i)));
# Line 48 | Line 70 | public class LinkedBlockingQueueTest ext
70      }
71  
72      /**
73 <     * Constructor throws IAE if capacity argument nonpositive
73 >     * Constructor throws IllegalArgumentException if capacity argument nonpositive
74       */
75      public void testConstructor2() {
76          try {
77 <            LinkedBlockingQueue q = new LinkedBlockingQueue(0);
77 >            new LinkedBlockingQueue(0);
78              shouldThrow();
79          } catch (IllegalArgumentException success) {}
80      }
81  
82      /**
83 <     * Initializing from null Collection throws NPE
83 >     * Initializing from null Collection throws NullPointerException
84       */
85      public void testConstructor3() {
86          try {
87 <            LinkedBlockingQueue q = new LinkedBlockingQueue(null);
87 >            new LinkedBlockingQueue(null);
88              shouldThrow();
89          } catch (NullPointerException success) {}
90      }
91  
92      /**
93 <     * Initializing from Collection of null elements throws NPE
93 >     * Initializing from Collection of null elements throws NullPointerException
94       */
95      public void testConstructor4() {
96 +        Collection<Integer> elements = Arrays.asList(new Integer[SIZE]);
97          try {
98 <            Integer[] ints = new Integer[SIZE];
76 <            LinkedBlockingQueue q = new LinkedBlockingQueue(Arrays.asList(ints));
98 >            new LinkedBlockingQueue(elements);
99              shouldThrow();
100          } catch (NullPointerException success) {}
101      }
102  
103      /**
104 <     * Initializing from Collection with some null elements throws NPE
104 >     * Initializing from Collection with some null elements throws
105 >     * NullPointerException
106       */
107      public void testConstructor5() {
108 +        Integer[] ints = new Integer[SIZE];
109 +        for (int i = 0; i < SIZE-1; ++i)
110 +            ints[i] = new Integer(i);
111 +        Collection<Integer> elements = Arrays.asList(ints);
112          try {
113 <            Integer[] ints = new Integer[SIZE];
87 <            for (int i = 0; i < SIZE-1; ++i)
88 <                ints[i] = new Integer(i);
89 <            LinkedBlockingQueue q = new LinkedBlockingQueue(Arrays.asList(ints));
113 >            new LinkedBlockingQueue(elements);
114              shouldThrow();
115          } catch (NullPointerException success) {}
116      }
# Line 136 | Line 160 | public class LinkedBlockingQueueTest ext
160      }
161  
162      /**
139     * offer(null) throws NPE
140     */
141    public void testOfferNull() {
142        try {
143            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
144            q.offer(null);
145            shouldThrow();
146        } catch (NullPointerException success) {}
147    }
148
149    /**
150     * add(null) throws NPE
151     */
152    public void testAddNull() {
153        try {
154            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
155            q.add(null);
156            shouldThrow();
157        } catch (NullPointerException success) {}
158    }
159
160    /**
163       * Offer succeeds if not full; fails if full
164       */
165      public void testOffer() {
# Line 167 | Line 169 | public class LinkedBlockingQueueTest ext
169      }
170  
171      /**
172 <     * add succeeds if not full; throws ISE if full
172 >     * add succeeds if not full; throws IllegalStateException if full
173       */
174      public void testAdd() {
175 +        LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
176 +        for (int i = 0; i < SIZE; ++i)
177 +            assertTrue(q.add(new Integer(i)));
178 +        assertEquals(0, q.remainingCapacity());
179          try {
174            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
175            for (int i = 0; i < SIZE; ++i) {
176                assertTrue(q.add(new Integer(i)));
177            }
178            assertEquals(0, q.remainingCapacity());
180              q.add(new Integer(SIZE));
181              shouldThrow();
182          } catch (IllegalStateException success) {}
183      }
184  
185      /**
186 <     * addAll(null) throws NPE
186 <     */
187 <    public void testAddAll1() {
188 <        try {
189 <            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
190 <            q.addAll(null);
191 <            shouldThrow();
192 <        } catch (NullPointerException success) {}
193 <    }
194 <
195 <    /**
196 <     * addAll(this) throws IAE
186 >     * addAll(this) throws IllegalArgumentException
187       */
188      public void testAddAllSelf() {
189 +        LinkedBlockingQueue q = populatedQueue(SIZE);
190          try {
200            LinkedBlockingQueue q = populatedQueue(SIZE);
191              q.addAll(q);
192              shouldThrow();
193          } catch (IllegalArgumentException success) {}
194      }
195  
196      /**
207     * addAll of a collection with null elements throws NPE
208     */
209    public void testAddAll2() {
210        try {
211            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
212            Integer[] ints = new Integer[SIZE];
213            q.addAll(Arrays.asList(ints));
214            shouldThrow();
215        } catch (NullPointerException success) {}
216    }
217    /**
197       * addAll of a collection with any null elements throws NPE after
198       * possibly adding some elements
199       */
200      public void testAddAll3() {
201 +        LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
202 +        Integer[] ints = new Integer[SIZE];
203 +        for (int i = 0; i < SIZE-1; ++i)
204 +            ints[i] = new Integer(i);
205 +        Collection<Integer> elements = Arrays.asList(ints);
206          try {
207 <            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
224 <            Integer[] ints = new Integer[SIZE];
225 <            for (int i = 0; i < SIZE-1; ++i)
226 <                ints[i] = new Integer(i);
227 <            q.addAll(Arrays.asList(ints));
207 >            q.addAll(elements);
208              shouldThrow();
209          } catch (NullPointerException success) {}
210      }
211 +
212      /**
213 <     * addAll throws ISE if not enough room
213 >     * addAll throws IllegalStateException if not enough room
214       */
215      public void testAddAll4() {
216 +        LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE - 1);
217 +        Integer[] ints = new Integer[SIZE];
218 +        for (int i = 0; i < SIZE; ++i)
219 +            ints[i] = new Integer(i);
220 +        Collection<Integer> elements = Arrays.asList(ints);
221          try {
222 <            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
237 <            Integer[] ints = new Integer[SIZE];
238 <            for (int i = 0; i < SIZE; ++i)
239 <                ints[i] = new Integer(i);
240 <            q.addAll(Arrays.asList(ints));
222 >            q.addAll(elements);
223              shouldThrow();
224          } catch (IllegalStateException success) {}
225      }
226 +
227      /**
228       * Queue contains all elements, in traversal order, of successful addAll
229       */
# Line 257 | Line 240 | public class LinkedBlockingQueueTest ext
240      }
241  
242      /**
260     * put(null) throws NPE
261     */
262     public void testPutNull() throws InterruptedException {
263        try {
264            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
265            q.put(null);
266            shouldThrow();
267        } catch (NullPointerException success) {}
268     }
269
270    /**
243       * all elements successfully put are contained
244       */
245      public void testPut() throws InterruptedException {
# Line 284 | Line 256 | public class LinkedBlockingQueueTest ext
256       * put blocks interruptibly if full
257       */
258      public void testBlockingPut() throws InterruptedException {
259 <        Thread t = new Thread(new CheckedRunnable() {
260 <            public void realRun() {
261 <                int added = 0;
259 >        final LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
260 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
261 >        Thread t = newStartedThread(new CheckedRunnable() {
262 >            public void realRun() throws InterruptedException {
263 >                for (int i = 0; i < SIZE; ++i)
264 >                    q.put(i);
265 >                assertEquals(SIZE, q.size());
266 >                assertEquals(0, q.remainingCapacity());
267 >
268 >                Thread.currentThread().interrupt();
269                  try {
270 <                    LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
271 <                    for (int i = 0; i < SIZE; ++i) {
272 <                        q.put(new Integer(i));
273 <                        ++added;
274 <                    }
275 <                    q.put(new Integer(SIZE));
276 <                    threadShouldThrow();
277 <                } catch (InterruptedException success) {
278 <                    threadAssertEquals(added, SIZE);
279 <                }
270 >                    q.put(99);
271 >                    shouldThrow();
272 >                } catch (InterruptedException success) {}
273 >                assertFalse(Thread.interrupted());
274 >
275 >                pleaseInterrupt.countDown();
276 >                try {
277 >                    q.put(99);
278 >                    shouldThrow();
279 >                } catch (InterruptedException success) {}
280 >                assertFalse(Thread.interrupted());
281              }});
282  
283 <        t.start();
284 <        Thread.sleep(SHORT_DELAY_MS);
283 >        await(pleaseInterrupt);
284 >        assertThreadStaysAlive(t);
285          t.interrupt();
286 <        t.join();
286 >        awaitTermination(t);
287 >        assertEquals(SIZE, q.size());
288 >        assertEquals(0, q.remainingCapacity());
289      }
290  
291      /**
292 <     * put blocks waiting for take when full
292 >     * put blocks interruptibly waiting for take when full
293       */
294      public void testPutWithTake() throws InterruptedException {
295 +        final int capacity = 2;
296          final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
297 <        Thread t = new Thread(new CheckedRunnable() {
298 <            public void realRun() {
299 <                int added = 0;
297 >        final CountDownLatch pleaseTake = new CountDownLatch(1);
298 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
299 >        Thread t = newStartedThread(new CheckedRunnable() {
300 >            public void realRun() throws InterruptedException {
301 >                for (int i = 0; i < capacity; i++)
302 >                    q.put(i);
303 >                pleaseTake.countDown();
304 >                q.put(86);
305 >
306 >                pleaseInterrupt.countDown();
307                  try {
308 <                    q.put(new Object());
309 <                    ++added;
310 <                    q.put(new Object());
311 <                    ++added;
322 <                    q.put(new Object());
323 <                    ++added;
324 <                    q.put(new Object());
325 <                    ++added;
326 <                    threadShouldThrow();
327 <                } catch (InterruptedException success) {
328 <                    threadAssertTrue(added >= 2);
329 <                }
308 >                    q.put(99);
309 >                    shouldThrow();
310 >                } catch (InterruptedException success) {}
311 >                assertFalse(Thread.interrupted());
312              }});
313  
314 <        t.start();
315 <        Thread.sleep(SHORT_DELAY_MS);
316 <        q.take();
314 >        await(pleaseTake);
315 >        assertEquals(q.remainingCapacity(), 0);
316 >        assertEquals(0, q.take());
317 >
318 >        await(pleaseInterrupt);
319 >        assertThreadStaysAlive(t);
320          t.interrupt();
321 <        t.join();
321 >        awaitTermination(t);
322 >        assertEquals(q.remainingCapacity(), 0);
323      }
324  
325      /**
326       * timed offer times out if full and elements not taken
327       */
328 <    public void testTimedOffer() throws InterruptedException {
328 >    public void testTimedOffer() {
329          final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
330 <        Thread t = new ThreadShouldThrow(InterruptedException.class) {
330 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
331 >        Thread t = newStartedThread(new CheckedRunnable() {
332              public void realRun() throws InterruptedException {
333                  q.put(new Object());
334                  q.put(new Object());
335 <                threadAssertFalse(q.offer(new Object(), SHORT_DELAY_MS, MILLISECONDS));
336 <                q.offer(new Object(), LONG_DELAY_MS, MILLISECONDS);
337 <            }};
335 >                long startTime = System.nanoTime();
336 >                assertFalse(q.offer(new Object(), timeoutMillis(), MILLISECONDS));
337 >                assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
338 >                pleaseInterrupt.countDown();
339 >                try {
340 >                    q.offer(new Object(), 2 * LONG_DELAY_MS, MILLISECONDS);
341 >                    shouldThrow();
342 >                } catch (InterruptedException success) {}
343 >            }});
344  
345 <        t.start();
346 <        Thread.sleep(SMALL_DELAY_MS);
345 >        await(pleaseInterrupt);
346 >        assertThreadStaysAlive(t);
347          t.interrupt();
348 <        t.join();
348 >        awaitTermination(t);
349      }
350  
351      /**
# Line 361 | Line 354 | public class LinkedBlockingQueueTest ext
354      public void testTake() throws InterruptedException {
355          LinkedBlockingQueue q = populatedQueue(SIZE);
356          for (int i = 0; i < SIZE; ++i) {
357 <            assertEquals(i, ((Integer)q.take()).intValue());
357 >            assertEquals(i, q.take());
358          }
359      }
360  
361      /**
369     * take blocks interruptibly when empty
370     */
371    public void testTakeFromEmpty() throws InterruptedException {
372        final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
373        Thread t = new ThreadShouldThrow(InterruptedException.class) {
374            public void realRun() throws InterruptedException {
375                q.take();
376            }};
377
378        t.start();
379        Thread.sleep(SHORT_DELAY_MS);
380        t.interrupt();
381        t.join();
382    }
383
384    /**
362       * Take removes existing elements until empty, then blocks interruptibly
363       */
364      public void testBlockingTake() throws InterruptedException {
365 <        Thread t = new ThreadShouldThrow(InterruptedException.class) {
365 >        final BlockingQueue q = populatedQueue(SIZE);
366 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
367 >        Thread t = newStartedThread(new CheckedRunnable() {
368              public void realRun() throws InterruptedException {
390                LinkedBlockingQueue q = populatedQueue(SIZE);
369                  for (int i = 0; i < SIZE; ++i) {
370 <                    assertEquals(i, ((Integer)q.take()).intValue());
370 >                    assertEquals(i, q.take());
371                  }
394                q.take();
395            }};
372  
373 <        t.start();
374 <        Thread.sleep(SHORT_DELAY_MS);
373 >                Thread.currentThread().interrupt();
374 >                try {
375 >                    q.take();
376 >                    shouldThrow();
377 >                } catch (InterruptedException success) {}
378 >                assertFalse(Thread.interrupted());
379 >
380 >                pleaseInterrupt.countDown();
381 >                try {
382 >                    q.take();
383 >                    shouldThrow();
384 >                } catch (InterruptedException success) {}
385 >                assertFalse(Thread.interrupted());
386 >            }});
387 >
388 >        await(pleaseInterrupt);
389 >        assertThreadStaysAlive(t);
390          t.interrupt();
391 <        t.join();
391 >        awaitTermination(t);
392      }
393  
403
394      /**
395       * poll succeeds unless empty
396       */
397      public void testPoll() {
398          LinkedBlockingQueue q = populatedQueue(SIZE);
399          for (int i = 0; i < SIZE; ++i) {
400 <            assertEquals(i, ((Integer)q.poll()).intValue());
400 >            assertEquals(i, q.poll());
401          }
402          assertNull(q.poll());
403      }
404  
405      /**
406 <     * timed pool with zero timeout succeeds when non-empty, else times out
406 >     * timed poll with zero timeout succeeds when non-empty, else times out
407       */
408      public void testTimedPoll0() throws InterruptedException {
409          LinkedBlockingQueue q = populatedQueue(SIZE);
410          for (int i = 0; i < SIZE; ++i) {
411 <            assertEquals(i, ((Integer)q.poll(0, MILLISECONDS)).intValue());
411 >            assertEquals(i, q.poll(0, MILLISECONDS));
412          }
413          assertNull(q.poll(0, MILLISECONDS));
414      }
415  
416      /**
417 <     * timed pool with nonzero timeout succeeds when non-empty, else times out
417 >     * timed poll with nonzero timeout succeeds when non-empty, else times out
418       */
419      public void testTimedPoll() throws InterruptedException {
420 <        LinkedBlockingQueue q = populatedQueue(SIZE);
420 >        LinkedBlockingQueue<Integer> q = populatedQueue(SIZE);
421          for (int i = 0; i < SIZE; ++i) {
422 <            assertEquals(i, ((Integer)q.poll(SHORT_DELAY_MS, MILLISECONDS)).intValue());
423 <        }
424 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
422 >            long startTime = System.nanoTime();
423 >            assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
424 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
425 >        }
426 >        long startTime = System.nanoTime();
427 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
428 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
429 >        checkEmpty(q);
430      }
431  
432      /**
# Line 439 | Line 434 | public class LinkedBlockingQueueTest ext
434       * returning timeout status
435       */
436      public void testInterruptedTimedPoll() throws InterruptedException {
437 <        Thread t = new Thread(new CheckedRunnable() {
437 >        final BlockingQueue<Integer> q = populatedQueue(SIZE);
438 >        final CountDownLatch aboutToWait = new CountDownLatch(1);
439 >        Thread t = newStartedThread(new CheckedRunnable() {
440              public void realRun() throws InterruptedException {
444                LinkedBlockingQueue q = populatedQueue(SIZE);
441                  for (int i = 0; i < SIZE; ++i) {
442 <                    assertEquals(i, ((Integer)q.poll(SHORT_DELAY_MS, MILLISECONDS)).intValue());
442 >                    long t0 = System.nanoTime();
443 >                    assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
444 >                    assertTrue(millisElapsedSince(t0) < SMALL_DELAY_MS);
445                  }
446 +                long t0 = System.nanoTime();
447 +                aboutToWait.countDown();
448                  try {
449 <                    q.poll(SMALL_DELAY_MS, MILLISECONDS);
450 <                    shouldThrow();
451 <                } catch (InterruptedException success) {}
452 <            }});
453 <
454 <        t.start();
455 <        Thread.sleep(SHORT_DELAY_MS);
456 <        t.interrupt();
457 <        t.join();
458 <    }
459 <
460 <    /**
461 <     *  timed poll before a delayed offer fails; after offer succeeds;
462 <     *  on interruption throws
463 <     */
464 <    public void testTimedPollWithOffer() throws InterruptedException {
465 <        final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
466 <        Thread t = new Thread(new CheckedRunnable() {
467 <            public void realRun() throws InterruptedException {
468 <                assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
469 <                assertSame(zero, q.poll(LONG_DELAY_MS, MILLISECONDS));
470 <                try {
471 <                    q.poll(LONG_DELAY_MS, MILLISECONDS);
449 >                    q.poll(MEDIUM_DELAY_MS, MILLISECONDS);
450                      shouldThrow();
451 <                } catch (InterruptedException success) {}
451 >                } catch (InterruptedException success) {
452 >                    assertTrue(millisElapsedSince(t0) < MEDIUM_DELAY_MS);
453 >                }
454              }});
455  
456 <        t.start();
457 <        Thread.sleep(SMALL_DELAY_MS);
478 <        assertTrue(q.offer(zero, SHORT_DELAY_MS, MILLISECONDS));
456 >        aboutToWait.await();
457 >        waitForThreadToEnterWaitState(t, SMALL_DELAY_MS);
458          t.interrupt();
459 <        t.join();
459 >        awaitTermination(t, MEDIUM_DELAY_MS);
460 >        checkEmpty(q);
461      }
462  
463      /**
# Line 486 | Line 466 | public class LinkedBlockingQueueTest ext
466      public void testPeek() {
467          LinkedBlockingQueue q = populatedQueue(SIZE);
468          for (int i = 0; i < SIZE; ++i) {
469 <            assertEquals(i, ((Integer)q.peek()).intValue());
470 <            q.poll();
469 >            assertEquals(i, q.peek());
470 >            assertEquals(i, q.poll());
471              assertTrue(q.peek() == null ||
472 <                       i != ((Integer)q.peek()).intValue());
472 >                       !q.peek().equals(i));
473          }
474          assertNull(q.peek());
475      }
# Line 500 | Line 480 | public class LinkedBlockingQueueTest ext
480      public void testElement() {
481          LinkedBlockingQueue q = populatedQueue(SIZE);
482          for (int i = 0; i < SIZE; ++i) {
483 <            assertEquals(i, ((Integer)q.element()).intValue());
484 <            q.poll();
483 >            assertEquals(i, q.element());
484 >            assertEquals(i, q.poll());
485          }
486          try {
487              q.element();
# Line 515 | Line 495 | public class LinkedBlockingQueueTest ext
495      public void testRemove() {
496          LinkedBlockingQueue q = populatedQueue(SIZE);
497          for (int i = 0; i < SIZE; ++i) {
498 <            assertEquals(i, ((Integer)q.remove()).intValue());
498 >            assertEquals(i, q.remove());
499          }
500          try {
501              q.remove();
# Line 529 | Line 509 | public class LinkedBlockingQueueTest ext
509      public void testRemoveElement() {
510          LinkedBlockingQueue q = populatedQueue(SIZE);
511          for (int i = 1; i < SIZE; i+=2) {
512 <            assertTrue(q.remove(new Integer(i)));
512 >            assertTrue(q.contains(i));
513 >            assertTrue(q.remove(i));
514 >            assertFalse(q.contains(i));
515 >            assertTrue(q.contains(i-1));
516          }
517          for (int i = 0; i < SIZE; i+=2) {
518 <            assertTrue(q.remove(new Integer(i)));
519 <            assertFalse(q.remove(new Integer(i+1)));
518 >            assertTrue(q.contains(i));
519 >            assertTrue(q.remove(i));
520 >            assertFalse(q.contains(i));
521 >            assertFalse(q.remove(i+1));
522 >            assertFalse(q.contains(i+1));
523          }
524          assertTrue(q.isEmpty());
525      }
# Line 629 | Line 615 | public class LinkedBlockingQueueTest ext
615      }
616  
617      /**
618 <     * toArray contains all elements
618 >     * toArray contains all elements in FIFO order
619       */
620 <    public void testToArray() throws InterruptedException {
620 >    public void testToArray() {
621          LinkedBlockingQueue q = populatedQueue(SIZE);
622          Object[] o = q.toArray();
623          for (int i = 0; i < o.length; i++)
624 <            assertEquals(o[i], q.take());
624 >            assertSame(o[i], q.poll());
625      }
626  
627      /**
628 <     * toArray(a) contains all elements
628 >     * toArray(a) contains all elements in FIFO order
629       */
630      public void testToArray2() throws InterruptedException {
631 <        LinkedBlockingQueue q = populatedQueue(SIZE);
631 >        LinkedBlockingQueue<Integer> q = populatedQueue(SIZE);
632          Integer[] ints = new Integer[SIZE];
633 <        ints = (Integer[])q.toArray(ints);
633 >        Integer[] array = q.toArray(ints);
634 >        assertSame(ints, array);
635          for (int i = 0; i < ints.length; i++)
636 <            assertEquals(ints[i], q.take());
636 >            assertSame(ints[i], q.poll());
637      }
638  
639      /**
640 <     * toArray(null) throws NPE
654 <     */
655 <    public void testToArray_BadArg() {
656 <        try {
657 <            LinkedBlockingQueue q = populatedQueue(SIZE);
658 <            Object o[] = q.toArray(null);
659 <            shouldThrow();
660 <        } catch (NullPointerException success) {}
661 <    }
662 <
663 <    /**
664 <     * toArray with incompatible array type throws CCE
640 >     * toArray(incompatible array type) throws ArrayStoreException
641       */
642      public void testToArray1_BadArg() {
643 +        LinkedBlockingQueue q = populatedQueue(SIZE);
644          try {
645 <            LinkedBlockingQueue q = populatedQueue(SIZE);
669 <            Object o[] = q.toArray(new String[10] );
645 >            q.toArray(new String[10]);
646              shouldThrow();
647          } catch (ArrayStoreException success) {}
648      }
649  
674
650      /**
651       * iterator iterates through all elements
652       */
# Line 686 | Line 661 | public class LinkedBlockingQueueTest ext
661      /**
662       * iterator.remove removes current element
663       */
664 <    public void testIteratorRemove () {
664 >    public void testIteratorRemove() {
665          final LinkedBlockingQueue q = new LinkedBlockingQueue(3);
666          q.add(two);
667          q.add(one);
# Line 697 | Line 672 | public class LinkedBlockingQueueTest ext
672          it.remove();
673  
674          it = q.iterator();
675 <        assertEquals(it.next(), one);
676 <        assertEquals(it.next(), three);
675 >        assertSame(it.next(), one);
676 >        assertSame(it.next(), three);
677          assertFalse(it.hasNext());
678      }
679  
705
680      /**
681       * iterator ordering is FIFO
682       */
# Line 714 | Line 688 | public class LinkedBlockingQueueTest ext
688          assertEquals(0, q.remainingCapacity());
689          int k = 0;
690          for (Iterator it = q.iterator(); it.hasNext();) {
691 <            int i = ((Integer)(it.next())).intValue();
718 <            assertEquals(++k, i);
691 >            assertEquals(++k, it.next());
692          }
693          assertEquals(3, k);
694      }
# Line 723 | Line 696 | public class LinkedBlockingQueueTest ext
696      /**
697       * Modifications do not cause iterators to fail
698       */
699 <    public void testWeaklyConsistentIteration () {
699 >    public void testWeaklyConsistentIteration() {
700          final LinkedBlockingQueue q = new LinkedBlockingQueue(3);
701          q.add(one);
702          q.add(two);
# Line 735 | Line 708 | public class LinkedBlockingQueueTest ext
708          assertEquals(0, q.size());
709      }
710  
738
711      /**
712       * toString contains toStrings of elements
713       */
# Line 743 | Line 715 | public class LinkedBlockingQueueTest ext
715          LinkedBlockingQueue q = populatedQueue(SIZE);
716          String s = q.toString();
717          for (int i = 0; i < SIZE; ++i) {
718 <            assertTrue(s.indexOf(String.valueOf(i)) >= 0);
718 >            assertTrue(s.contains(String.valueOf(i)));
719          }
720      }
721  
750
722      /**
723       * offer transfers elements across Executor tasks
724       */
# Line 756 | Line 727 | public class LinkedBlockingQueueTest ext
727          q.add(one);
728          q.add(two);
729          ExecutorService executor = Executors.newFixedThreadPool(2);
730 +        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
731          executor.execute(new CheckedRunnable() {
732              public void realRun() throws InterruptedException {
733 <                threadAssertFalse(q.offer(three));
734 <                threadAssertTrue(q.offer(three, MEDIUM_DELAY_MS, MILLISECONDS));
735 <                threadAssertEquals(0, q.remainingCapacity());
733 >                assertFalse(q.offer(three));
734 >                threadsStarted.await();
735 >                assertTrue(q.offer(three, LONG_DELAY_MS, MILLISECONDS));
736 >                assertEquals(0, q.remainingCapacity());
737              }});
738  
739          executor.execute(new CheckedRunnable() {
740              public void realRun() throws InterruptedException {
741 <                Thread.sleep(SMALL_DELAY_MS);
742 <                threadAssertEquals(one, q.take());
741 >                threadsStarted.await();
742 >                assertSame(one, q.take());
743              }});
744  
745          joinPool(executor);
746      }
747  
748      /**
749 <     * poll retrieves elements across Executor threads
749 >     * timed poll retrieves elements across Executor threads
750       */
751      public void testPollInExecutor() {
752          final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
753 +        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
754          ExecutorService executor = Executors.newFixedThreadPool(2);
755          executor.execute(new CheckedRunnable() {
756              public void realRun() throws InterruptedException {
757 <                threadAssertNull(q.poll());
758 <                threadAssertTrue(null != q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
759 <                threadAssertTrue(q.isEmpty());
757 >                assertNull(q.poll());
758 >                threadsStarted.await();
759 >                assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
760 >                checkEmpty(q);
761              }});
762  
763          executor.execute(new CheckedRunnable() {
764              public void realRun() throws InterruptedException {
765 <                Thread.sleep(SMALL_DELAY_MS);
765 >                threadsStarted.await();
766                  q.put(one);
767              }});
768  
# Line 798 | Line 773 | public class LinkedBlockingQueueTest ext
773       * A deserialized serialized queue has same elements in same order
774       */
775      public void testSerialization() throws Exception {
776 <        LinkedBlockingQueue q = populatedQueue(SIZE);
777 <
803 <        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
804 <        ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
805 <        out.writeObject(q);
806 <        out.close();
776 >        Queue x = populatedQueue(SIZE);
777 >        Queue y = serialClone(x);
778  
779 <        ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
780 <        ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
781 <        LinkedBlockingQueue r = (LinkedBlockingQueue)in.readObject();
782 <        assertEquals(q.size(), r.size());
783 <        while (!q.isEmpty())
784 <            assertEquals(q.remove(), r.remove());
785 <    }
786 <
787 <    /**
817 <     * drainTo(null) throws NPE
818 <     */
819 <    public void testDrainToNull() {
820 <        LinkedBlockingQueue q = populatedQueue(SIZE);
821 <        try {
822 <            q.drainTo(null);
823 <            shouldThrow();
824 <        } catch (NullPointerException success) {}
825 <    }
826 <
827 <    /**
828 <     * drainTo(this) throws IAE
829 <     */
830 <    public void testDrainToSelf() {
831 <        LinkedBlockingQueue q = populatedQueue(SIZE);
832 <        try {
833 <            q.drainTo(q);
834 <            shouldThrow();
835 <        } catch (IllegalArgumentException success) {}
779 >        assertTrue(x != y);
780 >        assertEquals(x.size(), y.size());
781 >        assertEquals(x.toString(), y.toString());
782 >        assertTrue(Arrays.equals(x.toArray(), y.toArray()));
783 >        while (!x.isEmpty()) {
784 >            assertFalse(y.isEmpty());
785 >            assertEquals(x.remove(), y.remove());
786 >        }
787 >        assertTrue(y.isEmpty());
788      }
789  
790      /**
# Line 880 | Line 832 | public class LinkedBlockingQueueTest ext
832      }
833  
834      /**
835 <     * drainTo(null, n) throws NPE
884 <     */
885 <    public void testDrainToNullN() {
886 <        LinkedBlockingQueue q = populatedQueue(SIZE);
887 <        try {
888 <            q.drainTo(null, 0);
889 <            shouldThrow();
890 <        } catch (NullPointerException success) {}
891 <    }
892 <
893 <    /**
894 <     * drainTo(this, n) throws IAE
895 <     */
896 <    public void testDrainToSelfN() {
897 <        LinkedBlockingQueue q = populatedQueue(SIZE);
898 <        try {
899 <            q.drainTo(q, 0);
900 <            shouldThrow();
901 <        } catch (IllegalArgumentException success) {}
902 <    }
903 <
904 <    /**
905 <     * drainTo(c, n) empties first max {n, size} elements of queue into c
835 >     * drainTo(c, n) empties first min(n, size) elements of queue into c
836       */
837      public void testDrainToN() {
838          LinkedBlockingQueue q = new LinkedBlockingQueue();
# Line 911 | Line 841 | public class LinkedBlockingQueueTest ext
841                  assertTrue(q.offer(new Integer(j)));
842              ArrayList l = new ArrayList();
843              q.drainTo(l, i);
844 <            int k = (i < SIZE)? i : SIZE;
844 >            int k = (i < SIZE) ? i : SIZE;
845              assertEquals(l.size(), k);
846              assertEquals(q.size(), SIZE-k);
847              for (int j = 0; j < k; ++j)

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines