ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/LinkedBlockingQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/LinkedBlockingQueueTest.java (file contents):
Revision 1.44 by jsr166, Fri May 27 20:07:24 2011 UTC vs.
Revision 1.71 by jsr166, Sun May 14 00:48:20 2017 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 import junit.framework.*;
10 import java.util.*;
11 import java.util.concurrent.*;
9   import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 < import java.io.*;
10 >
11 > import java.util.ArrayList;
12 > import java.util.Arrays;
13 > import java.util.Collection;
14 > import java.util.Iterator;
15 > import java.util.NoSuchElementException;
16 > import java.util.Queue;
17 > import java.util.concurrent.BlockingQueue;
18 > import java.util.concurrent.CountDownLatch;
19 > import java.util.concurrent.Executors;
20 > import java.util.concurrent.ExecutorService;
21 > import java.util.concurrent.LinkedBlockingQueue;
22 >
23 > import junit.framework.Test;
24  
25   public class LinkedBlockingQueueTest extends JSR166TestCase {
26  
# Line 22 | Line 32 | public class LinkedBlockingQueueTest ext
32  
33      public static class Bounded extends BlockingQueueTest {
34          protected BlockingQueue emptyCollection() {
35 <            return new LinkedBlockingQueue(20);
35 >            return new LinkedBlockingQueue(SIZE);
36          }
37      }
38  
39      public static void main(String[] args) {
40 <        junit.textui.TestRunner.run(suite());
40 >        main(suite(), args);
41      }
42  
43      public static Test suite() {
44 +        class Implementation implements CollectionImplementation {
45 +            public Class<?> klazz() { return LinkedBlockingQueue.class; }
46 +            public Collection emptyCollection() { return new LinkedBlockingQueue(); }
47 +            public Object makeElement(int i) { return i; }
48 +            public boolean isConcurrent() { return true; }
49 +            public boolean permitsNulls() { return false; }
50 +        }
51          return newTestSuite(LinkedBlockingQueueTest.class,
52                              new Unbounded().testSuite(),
53 <                            new Bounded().testSuite());
53 >                            new Bounded().testSuite(),
54 >                            CollectionTest.testSuite(new Implementation()));
55      }
56  
57      /**
58 <     * Create a queue of given size containing consecutive
59 <     * Integers 0 ... n.
58 >     * Returns a new queue of given size containing consecutive
59 >     * Integers 0 ... n - 1.
60       */
61 <    private LinkedBlockingQueue<Integer> populatedQueue(int n) {
61 >    private static LinkedBlockingQueue<Integer> populatedQueue(int n) {
62          LinkedBlockingQueue<Integer> q =
63              new LinkedBlockingQueue<Integer>(n);
64          assertTrue(q.isEmpty());
# Line 49 | Line 67 | public class LinkedBlockingQueueTest ext
67          assertFalse(q.isEmpty());
68          assertEquals(0, q.remainingCapacity());
69          assertEquals(n, q.size());
70 +        assertEquals((Integer) 0, q.peek());
71          return q;
72      }
73  
# Line 62 | Line 81 | public class LinkedBlockingQueueTest ext
81      }
82  
83      /**
84 <     * Constructor throws IAE if capacity argument nonpositive
84 >     * Constructor throws IllegalArgumentException if capacity argument nonpositive
85       */
86      public void testConstructor2() {
87          try {
88 <            LinkedBlockingQueue q = new LinkedBlockingQueue(0);
88 >            new LinkedBlockingQueue(0);
89              shouldThrow();
90          } catch (IllegalArgumentException success) {}
91      }
92  
93      /**
94 <     * Initializing from null Collection throws NPE
94 >     * Initializing from null Collection throws NullPointerException
95       */
96      public void testConstructor3() {
97          try {
98 <            LinkedBlockingQueue q = new LinkedBlockingQueue(null);
98 >            new LinkedBlockingQueue(null);
99              shouldThrow();
100          } catch (NullPointerException success) {}
101      }
102  
103      /**
104 <     * Initializing from Collection of null elements throws NPE
104 >     * Initializing from Collection of null elements throws NullPointerException
105       */
106      public void testConstructor4() {
107 +        Collection<Integer> elements = Arrays.asList(new Integer[SIZE]);
108          try {
109 <            Integer[] ints = new Integer[SIZE];
90 <            LinkedBlockingQueue q = new LinkedBlockingQueue(Arrays.asList(ints));
109 >            new LinkedBlockingQueue(elements);
110              shouldThrow();
111          } catch (NullPointerException success) {}
112      }
113  
114      /**
115 <     * Initializing from Collection with some null elements throws NPE
115 >     * Initializing from Collection with some null elements throws
116 >     * NullPointerException
117       */
118      public void testConstructor5() {
119 +        Integer[] ints = new Integer[SIZE];
120 +        for (int i = 0; i < SIZE - 1; ++i)
121 +            ints[i] = new Integer(i);
122 +        Collection<Integer> elements = Arrays.asList(ints);
123          try {
124 <            Integer[] ints = new Integer[SIZE];
101 <            for (int i = 0; i < SIZE-1; ++i)
102 <                ints[i] = new Integer(i);
103 <            LinkedBlockingQueue q = new LinkedBlockingQueue(Arrays.asList(ints));
124 >            new LinkedBlockingQueue(elements);
125              shouldThrow();
126          } catch (NullPointerException success) {}
127      }
# Line 136 | Line 157 | public class LinkedBlockingQueueTest ext
157       * remainingCapacity decreases on add, increases on remove
158       */
159      public void testRemainingCapacity() {
160 <        LinkedBlockingQueue q = populatedQueue(SIZE);
160 >        BlockingQueue q = populatedQueue(SIZE);
161          for (int i = 0; i < SIZE; ++i) {
162              assertEquals(i, q.remainingCapacity());
163 <            assertEquals(SIZE-i, q.size());
164 <            q.remove();
163 >            assertEquals(SIZE, q.size() + q.remainingCapacity());
164 >            assertEquals(i, q.remove());
165          }
166          for (int i = 0; i < SIZE; ++i) {
167 <            assertEquals(SIZE-i, q.remainingCapacity());
168 <            assertEquals(i, q.size());
169 <            q.add(new Integer(i));
167 >            assertEquals(SIZE - i, q.remainingCapacity());
168 >            assertEquals(SIZE, q.size() + q.remainingCapacity());
169 >            assertTrue(q.add(i));
170          }
171      }
172  
173      /**
153     * offer(null) throws NPE
154     */
155    public void testOfferNull() {
156        try {
157            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
158            q.offer(null);
159            shouldThrow();
160        } catch (NullPointerException success) {}
161    }
162
163    /**
164     * add(null) throws NPE
165     */
166    public void testAddNull() {
167        try {
168            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
169            q.add(null);
170            shouldThrow();
171        } catch (NullPointerException success) {}
172    }
173
174    /**
174       * Offer succeeds if not full; fails if full
175       */
176      public void testOffer() {
# Line 181 | Line 180 | public class LinkedBlockingQueueTest ext
180      }
181  
182      /**
183 <     * add succeeds if not full; throws ISE if full
183 >     * add succeeds if not full; throws IllegalStateException if full
184       */
185      public void testAdd() {
186 +        LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
187 +        for (int i = 0; i < SIZE; ++i)
188 +            assertTrue(q.add(new Integer(i)));
189 +        assertEquals(0, q.remainingCapacity());
190          try {
188            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
189            for (int i = 0; i < SIZE; ++i) {
190                assertTrue(q.add(new Integer(i)));
191            }
192            assertEquals(0, q.remainingCapacity());
191              q.add(new Integer(SIZE));
192              shouldThrow();
193          } catch (IllegalStateException success) {}
194      }
195  
196      /**
197 <     * addAll(null) throws NPE
200 <     */
201 <    public void testAddAll1() {
202 <        try {
203 <            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
204 <            q.addAll(null);
205 <            shouldThrow();
206 <        } catch (NullPointerException success) {}
207 <    }
208 <
209 <    /**
210 <     * addAll(this) throws IAE
197 >     * addAll(this) throws IllegalArgumentException
198       */
199      public void testAddAllSelf() {
200 +        LinkedBlockingQueue q = populatedQueue(SIZE);
201          try {
214            LinkedBlockingQueue q = populatedQueue(SIZE);
202              q.addAll(q);
203              shouldThrow();
204          } catch (IllegalArgumentException success) {}
205      }
206  
207      /**
221     * addAll of a collection with null elements throws NPE
222     */
223    public void testAddAll2() {
224        try {
225            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
226            Integer[] ints = new Integer[SIZE];
227            q.addAll(Arrays.asList(ints));
228            shouldThrow();
229        } catch (NullPointerException success) {}
230    }
231
232    /**
208       * addAll of a collection with any null elements throws NPE after
209       * possibly adding some elements
210       */
211      public void testAddAll3() {
212 +        LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
213 +        Integer[] ints = new Integer[SIZE];
214 +        for (int i = 0; i < SIZE - 1; ++i)
215 +            ints[i] = new Integer(i);
216 +        Collection<Integer> elements = Arrays.asList(ints);
217          try {
218 <            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
239 <            Integer[] ints = new Integer[SIZE];
240 <            for (int i = 0; i < SIZE-1; ++i)
241 <                ints[i] = new Integer(i);
242 <            q.addAll(Arrays.asList(ints));
218 >            q.addAll(elements);
219              shouldThrow();
220          } catch (NullPointerException success) {}
221      }
222  
223      /**
224 <     * addAll throws ISE if not enough room
224 >     * addAll throws IllegalStateException if not enough room
225       */
226      public void testAddAll4() {
227 +        LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE - 1);
228 +        Integer[] ints = new Integer[SIZE];
229 +        for (int i = 0; i < SIZE; ++i)
230 +            ints[i] = new Integer(i);
231 +        Collection<Integer> elements = Arrays.asList(ints);
232          try {
233 <            LinkedBlockingQueue q = new LinkedBlockingQueue(1);
253 <            Integer[] ints = new Integer[SIZE];
254 <            for (int i = 0; i < SIZE; ++i)
255 <                ints[i] = new Integer(i);
256 <            q.addAll(Arrays.asList(ints));
233 >            q.addAll(elements);
234              shouldThrow();
235          } catch (IllegalStateException success) {}
236      }
# Line 274 | Line 251 | public class LinkedBlockingQueueTest ext
251      }
252  
253      /**
277     * put(null) throws NPE
278     */
279    public void testPutNull() throws InterruptedException {
280        try {
281            LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
282            q.put(null);
283            shouldThrow();
284        } catch (NullPointerException success) {}
285    }
286
287    /**
254       * all elements successfully put are contained
255       */
256      public void testPut() throws InterruptedException {
257          LinkedBlockingQueue q = new LinkedBlockingQueue(SIZE);
258          for (int i = 0; i < SIZE; ++i) {
259 <            Integer I = new Integer(i);
260 <            q.put(I);
261 <            assertTrue(q.contains(I));
259 >            Integer x = new Integer(i);
260 >            q.put(x);
261 >            assertTrue(q.contains(x));
262          }
263          assertEquals(0, q.remainingCapacity());
264      }
# Line 326 | Line 292 | public class LinkedBlockingQueueTest ext
292              }});
293  
294          await(pleaseInterrupt);
295 <        assertThreadStaysAlive(t);
295 >        assertThreadBlocks(t, Thread.State.WAITING);
296          t.interrupt();
297          awaitTermination(t);
298          assertEquals(SIZE, q.size());
# Line 357 | Line 323 | public class LinkedBlockingQueueTest ext
323              }});
324  
325          await(pleaseTake);
326 <        assertEquals(q.remainingCapacity(), 0);
326 >        assertEquals(0, q.remainingCapacity());
327          assertEquals(0, q.take());
328  
329          await(pleaseInterrupt);
330 <        assertThreadStaysAlive(t);
330 >        assertThreadBlocks(t, Thread.State.WAITING);
331          t.interrupt();
332          awaitTermination(t);
333 <        assertEquals(q.remainingCapacity(), 0);
333 >        assertEquals(0, q.remainingCapacity());
334      }
335  
336      /**
# Line 388 | Line 354 | public class LinkedBlockingQueueTest ext
354              }});
355  
356          await(pleaseInterrupt);
357 <        assertThreadStaysAlive(t);
357 >        assertThreadBlocks(t, Thread.State.TIMED_WAITING);
358          t.interrupt();
359          awaitTermination(t);
360      }
# Line 411 | Line 377 | public class LinkedBlockingQueueTest ext
377          final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
378          Thread t = newStartedThread(new CheckedRunnable() {
379              public void realRun() throws InterruptedException {
380 <                for (int i = 0; i < SIZE; ++i) {
415 <                    assertEquals(i, q.take());
416 <                }
380 >                for (int i = 0; i < SIZE; i++) assertEquals(i, q.take());
381  
382                  Thread.currentThread().interrupt();
383                  try {
# Line 431 | Line 395 | public class LinkedBlockingQueueTest ext
395              }});
396  
397          await(pleaseInterrupt);
398 <        assertThreadStaysAlive(t);
398 >        assertThreadBlocks(t, Thread.State.WAITING);
399          t.interrupt();
400          awaitTermination(t);
401      }
# Line 480 | Line 444 | public class LinkedBlockingQueueTest ext
444       */
445      public void testInterruptedTimedPoll() throws InterruptedException {
446          final BlockingQueue<Integer> q = populatedQueue(SIZE);
447 <        final CountDownLatch aboutToWait = new CountDownLatch(1);
447 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
448          Thread t = newStartedThread(new CheckedRunnable() {
449              public void realRun() throws InterruptedException {
450 +                long startTime = System.nanoTime();
451                  for (int i = 0; i < SIZE; ++i) {
487                    long t0 = System.nanoTime();
452                      assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
489                    assertTrue(millisElapsedSince(t0) < SMALL_DELAY_MS);
453                  }
454 <                long t0 = System.nanoTime();
455 <                aboutToWait.countDown();
454 >
455 >                pleaseInterrupt.countDown();
456                  try {
457 <                    q.poll(MEDIUM_DELAY_MS, MILLISECONDS);
457 >                    q.poll(LONG_DELAY_MS, MILLISECONDS);
458                      shouldThrow();
459 <                } catch (InterruptedException success) {
460 <                    assertTrue(millisElapsedSince(t0) < MEDIUM_DELAY_MS);
461 <                }
459 >                } catch (InterruptedException success) {}
460 >                assertFalse(Thread.interrupted());
461 >
462 >                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
463              }});
464  
465 <        aboutToWait.await();
466 <        waitForThreadToEnterWaitState(t, SMALL_DELAY_MS);
465 >        await(pleaseInterrupt);
466 >        assertThreadBlocks(t, Thread.State.TIMED_WAITING);
467          t.interrupt();
468 <        awaitTermination(t, MEDIUM_DELAY_MS);
468 >        awaitTermination(t);
469          checkEmpty(q);
470      }
471  
# Line 549 | Line 513 | public class LinkedBlockingQueueTest ext
513      }
514  
515      /**
552     * remove(x) removes x and returns true if present
553     */
554    public void testRemoveElement() {
555        LinkedBlockingQueue q = populatedQueue(SIZE);
556        for (int i = 1; i < SIZE; i+=2) {
557            assertTrue(q.contains(i));
558            assertTrue(q.remove(i));
559            assertFalse(q.contains(i));
560            assertTrue(q.contains(i-1));
561        }
562        for (int i = 0; i < SIZE; i+=2) {
563            assertTrue(q.contains(i));
564            assertTrue(q.remove(i));
565            assertFalse(q.contains(i));
566            assertFalse(q.remove(i+1));
567            assertFalse(q.contains(i+1));
568        }
569        assertTrue(q.isEmpty());
570    }
571
572    /**
516       * An add following remove(x) succeeds
517       */
518      public void testRemoveElementAndAdd() throws InterruptedException {
# Line 579 | Line 522 | public class LinkedBlockingQueueTest ext
522          assertTrue(q.remove(new Integer(1)));
523          assertTrue(q.remove(new Integer(2)));
524          assertTrue(q.add(new Integer(3)));
525 <        assertTrue(q.take() != null);
525 >        assertNotNull(q.take());
526      }
527  
528      /**
# Line 638 | Line 581 | public class LinkedBlockingQueueTest ext
581                  assertTrue(changed);
582  
583              assertTrue(q.containsAll(p));
584 <            assertEquals(SIZE-i, q.size());
584 >            assertEquals(SIZE - i, q.size());
585              p.remove();
586          }
587      }
# Line 651 | Line 594 | public class LinkedBlockingQueueTest ext
594              LinkedBlockingQueue q = populatedQueue(SIZE);
595              LinkedBlockingQueue p = populatedQueue(i);
596              assertTrue(q.removeAll(p));
597 <            assertEquals(SIZE-i, q.size());
597 >            assertEquals(SIZE - i, q.size());
598              for (int j = 0; j < i; ++j) {
599 <                Integer I = (Integer)(p.remove());
600 <                assertFalse(q.contains(I));
599 >                Integer x = (Integer)(p.remove());
600 >                assertFalse(q.contains(x));
601              }
602          }
603      }
# Line 682 | Line 625 | public class LinkedBlockingQueueTest ext
625      }
626  
627      /**
685     * toArray(null) throws NullPointerException
686     */
687    public void testToArray_NullArg() {
688        LinkedBlockingQueue q = populatedQueue(SIZE);
689        try {
690            q.toArray(null);
691            shouldThrow();
692        } catch (NullPointerException success) {}
693    }
694
695    /**
628       * toArray(incompatible array type) throws ArrayStoreException
629       */
630      public void testToArray1_BadArg() {
# Line 709 | Line 641 | public class LinkedBlockingQueueTest ext
641      public void testIterator() throws InterruptedException {
642          LinkedBlockingQueue q = populatedQueue(SIZE);
643          Iterator it = q.iterator();
644 <        while (it.hasNext()) {
644 >        int i;
645 >        for (i = 0; it.hasNext(); i++)
646 >            assertTrue(q.contains(it.next()));
647 >        assertEquals(i, SIZE);
648 >        assertIteratorExhausted(it);
649 >
650 >        it = q.iterator();
651 >        for (i = 0; it.hasNext(); i++)
652              assertEquals(it.next(), q.take());
653 <        }
653 >        assertEquals(i, SIZE);
654 >        assertIteratorExhausted(it);
655 >    }
656 >
657 >    /**
658 >     * iterator of empty collection has no elements
659 >     */
660 >    public void testEmptyIterator() {
661 >        assertIteratorExhausted(new LinkedBlockingQueue().iterator());
662      }
663  
664      /**
# Line 782 | Line 729 | public class LinkedBlockingQueueTest ext
729          final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
730          q.add(one);
731          q.add(two);
785        ExecutorService executor = Executors.newFixedThreadPool(2);
732          final CheckedBarrier threadsStarted = new CheckedBarrier(2);
733 <        executor.execute(new CheckedRunnable() {
734 <            public void realRun() throws InterruptedException {
735 <                assertFalse(q.offer(three));
736 <                threadsStarted.await();
737 <                assertTrue(q.offer(three, LONG_DELAY_MS, MILLISECONDS));
738 <                assertEquals(0, q.remainingCapacity());
739 <            }});
740 <
741 <        executor.execute(new CheckedRunnable() {
742 <            public void realRun() throws InterruptedException {
743 <                threadsStarted.await();
744 <                assertSame(one, q.take());
745 <            }});
746 <
747 <        joinPool(executor);
733 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
734 >        try (PoolCleaner cleaner = cleaner(executor)) {
735 >            executor.execute(new CheckedRunnable() {
736 >                public void realRun() throws InterruptedException {
737 >                    assertFalse(q.offer(three));
738 >                    threadsStarted.await();
739 >                    assertTrue(q.offer(three, LONG_DELAY_MS, MILLISECONDS));
740 >                    assertEquals(0, q.remainingCapacity());
741 >                }});
742 >
743 >            executor.execute(new CheckedRunnable() {
744 >                public void realRun() throws InterruptedException {
745 >                    threadsStarted.await();
746 >                    assertSame(one, q.take());
747 >                }});
748 >        }
749      }
750  
751      /**
# Line 807 | Line 754 | public class LinkedBlockingQueueTest ext
754      public void testPollInExecutor() {
755          final LinkedBlockingQueue q = new LinkedBlockingQueue(2);
756          final CheckedBarrier threadsStarted = new CheckedBarrier(2);
757 <        ExecutorService executor = Executors.newFixedThreadPool(2);
758 <        executor.execute(new CheckedRunnable() {
759 <            public void realRun() throws InterruptedException {
760 <                assertNull(q.poll());
761 <                threadsStarted.await();
762 <                assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
763 <                checkEmpty(q);
764 <            }});
765 <
766 <        executor.execute(new CheckedRunnable() {
767 <            public void realRun() throws InterruptedException {
768 <                threadsStarted.await();
769 <                q.put(one);
770 <            }});
771 <
772 <        joinPool(executor);
757 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
758 >        try (PoolCleaner cleaner = cleaner(executor)) {
759 >            executor.execute(new CheckedRunnable() {
760 >                public void realRun() throws InterruptedException {
761 >                    assertNull(q.poll());
762 >                    threadsStarted.await();
763 >                    assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
764 >                    checkEmpty(q);
765 >                }});
766 >
767 >            executor.execute(new CheckedRunnable() {
768 >                public void realRun() throws InterruptedException {
769 >                    threadsStarted.await();
770 >                    q.put(one);
771 >                }});
772 >        }
773      }
774  
775      /**
776       * A deserialized serialized queue has same elements in same order
777       */
778      public void testSerialization() throws Exception {
779 <        LinkedBlockingQueue q = populatedQueue(SIZE);
780 <
834 <        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
835 <        ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
836 <        out.writeObject(q);
837 <        out.close();
838 <
839 <        ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
840 <        ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
841 <        LinkedBlockingQueue r = (LinkedBlockingQueue)in.readObject();
842 <        assertEquals(q.size(), r.size());
843 <        while (!q.isEmpty())
844 <            assertEquals(q.remove(), r.remove());
845 <    }
846 <
847 <    /**
848 <     * drainTo(null) throws NPE
849 <     */
850 <    public void testDrainToNull() {
851 <        LinkedBlockingQueue q = populatedQueue(SIZE);
852 <        try {
853 <            q.drainTo(null);
854 <            shouldThrow();
855 <        } catch (NullPointerException success) {}
856 <    }
779 >        Queue x = populatedQueue(SIZE);
780 >        Queue y = serialClone(x);
781  
782 <    /**
783 <     * drainTo(this) throws IAE
784 <     */
785 <    public void testDrainToSelf() {
786 <        LinkedBlockingQueue q = populatedQueue(SIZE);
787 <        try {
788 <            q.drainTo(q);
789 <            shouldThrow();
790 <        } catch (IllegalArgumentException success) {}
782 >        assertNotSame(x, y);
783 >        assertEquals(x.size(), y.size());
784 >        assertEquals(x.toString(), y.toString());
785 >        assertTrue(Arrays.equals(x.toArray(), y.toArray()));
786 >        while (!x.isEmpty()) {
787 >            assertFalse(y.isEmpty());
788 >            assertEquals(x.remove(), y.remove());
789 >        }
790 >        assertTrue(y.isEmpty());
791      }
792  
793      /**
# Line 873 | Line 797 | public class LinkedBlockingQueueTest ext
797          LinkedBlockingQueue q = populatedQueue(SIZE);
798          ArrayList l = new ArrayList();
799          q.drainTo(l);
800 <        assertEquals(q.size(), 0);
801 <        assertEquals(l.size(), SIZE);
800 >        assertEquals(0, q.size());
801 >        assertEquals(SIZE, l.size());
802          for (int i = 0; i < SIZE; ++i)
803              assertEquals(l.get(i), new Integer(i));
804          q.add(zero);
# Line 884 | Line 808 | public class LinkedBlockingQueueTest ext
808          assertTrue(q.contains(one));
809          l.clear();
810          q.drainTo(l);
811 <        assertEquals(q.size(), 0);
812 <        assertEquals(l.size(), 2);
811 >        assertEquals(0, q.size());
812 >        assertEquals(2, l.size());
813          for (int i = 0; i < 2; ++i)
814              assertEquals(l.get(i), new Integer(i));
815      }
# Line 897 | Line 821 | public class LinkedBlockingQueueTest ext
821          final LinkedBlockingQueue q = populatedQueue(SIZE);
822          Thread t = new Thread(new CheckedRunnable() {
823              public void realRun() throws InterruptedException {
824 <                q.put(new Integer(SIZE+1));
824 >                q.put(new Integer(SIZE + 1));
825              }});
826  
827          t.start();
# Line 911 | Line 835 | public class LinkedBlockingQueueTest ext
835      }
836  
837      /**
914     * drainTo(null, n) throws NPE
915     */
916    public void testDrainToNullN() {
917        LinkedBlockingQueue q = populatedQueue(SIZE);
918        try {
919            q.drainTo(null, 0);
920            shouldThrow();
921        } catch (NullPointerException success) {}
922    }
923
924    /**
925     * drainTo(this, n) throws IAE
926     */
927    public void testDrainToSelfN() {
928        LinkedBlockingQueue q = populatedQueue(SIZE);
929        try {
930            q.drainTo(q, 0);
931            shouldThrow();
932        } catch (IllegalArgumentException success) {}
933    }
934
935    /**
838       * drainTo(c, n) empties first min(n, size) elements of queue into c
839       */
840      public void testDrainToN() {
# Line 943 | Line 845 | public class LinkedBlockingQueueTest ext
845              ArrayList l = new ArrayList();
846              q.drainTo(l, i);
847              int k = (i < SIZE) ? i : SIZE;
848 <            assertEquals(l.size(), k);
849 <            assertEquals(q.size(), SIZE-k);
848 >            assertEquals(k, l.size());
849 >            assertEquals(SIZE - k, q.size());
850              for (int j = 0; j < k; ++j)
851                  assertEquals(l.get(j), new Integer(j));
852 <            while (q.poll() != null) ;
852 >            do {} while (q.poll() != null);
853 >        }
854 >    }
855 >
856 >    /**
857 >     * remove(null), contains(null) always return false
858 >     */
859 >    public void testNeverContainsNull() {
860 >        Collection<?>[] qs = {
861 >            new LinkedBlockingQueue<Object>(),
862 >            populatedQueue(2),
863 >        };
864 >
865 >        for (Collection<?> q : qs) {
866 >            assertFalse(q.contains(null));
867 >            assertFalse(q.remove(null));
868          }
869      }
870  

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines