--- jsr166/src/test/tck/LinkedListTest.java 2010/08/25 00:07:03 1.19 +++ jsr166/src/test/tck/LinkedListTest.java 2010/11/04 01:04:54 1.23 @@ -174,7 +174,7 @@ public class LinkedListTest extends JSR1 } /** - * poll succeeds unless empty + * poll succeeds unless empty */ public void testPoll() { LinkedList q = populatedQueue(SIZE); @@ -185,7 +185,7 @@ public class LinkedListTest extends JSR1 } /** - * peek returns next element, or null if empty + * peek returns next element, or null if empty */ public void testPeek() { LinkedList q = populatedQueue(SIZE); @@ -214,7 +214,7 @@ public class LinkedListTest extends JSR1 } /** - * remove removes next element, or throws NSEE if empty + * remove removes next element, or throws NSEE if empty */ public void testRemove() { LinkedList q = populatedQueue(SIZE); @@ -318,54 +318,52 @@ public class LinkedListTest extends JSR1 } /** - * toArray contains all elements + * toArray contains all elements in FIFO order */ public void testToArray() { LinkedList q = populatedQueue(SIZE); Object[] o = q.toArray(); - Arrays.sort(o); for (int i = 0; i < o.length; i++) - assertEquals(o[i], q.poll()); + assertSame(o[i], q.poll()); } /** - * toArray(a) contains all elements + * toArray(a) contains all elements in FIFO order */ public void testToArray2() { LinkedList q = populatedQueue(SIZE); Integer[] ints = new Integer[SIZE]; - ints = (Integer[])q.toArray(ints); - Arrays.sort(ints); + assertSame(ints, q.toArray(ints)); for (int i = 0; i < ints.length; i++) - assertEquals(ints[i], q.poll()); + assertSame(ints[i], q.poll()); } /** - * toArray(null) throws NPE + * toArray(null) throws NullPointerException */ - public void testToArray_BadArg() { + public void testToArray_NullArg() { LinkedList l = new LinkedList(); l.add(new Object()); try { - Object o[] = l.toArray(null); + l.toArray(null); shouldThrow(); } catch (NullPointerException success) {} } /** - * toArray with incompatible array type throws CCE + * toArray(incompatible array type) throws ArrayStoreException */ public void testToArray1_BadArg() { LinkedList l = new LinkedList(); l.add(new Integer(5)); try { - Object o[] = l.toArray(new String[10]); + l.toArray(new String[10]); shouldThrow(); } catch (ArrayStoreException success) {} } /** - * iterator iterates through all elements + * iterator iterates through all elements */ public void testIterator() { LinkedList q = populatedQueue(SIZE); @@ -379,7 +377,7 @@ public class LinkedListTest extends JSR1 } /** - * iterator ordering is FIFO + * iterator ordering is FIFO */ public void testIteratorOrdering() { final LinkedList q = new LinkedList(); @@ -412,7 +410,7 @@ public class LinkedListTest extends JSR1 } /** - * Descending iterator iterates through all elements + * Descending iterator iterates through all elements */ public void testDescendingIterator() { LinkedList q = populatedQueue(SIZE); @@ -431,7 +429,7 @@ public class LinkedListTest extends JSR1 } /** - * Descending iterator ordering is reverse FIFO + * Descending iterator ordering is reverse FIFO */ public void testDescendingIteratorOrdering() { final LinkedList q = new LinkedList(); @@ -494,7 +492,7 @@ public class LinkedListTest extends JSR1 } /** - * pop removes next element, or throws NSEE if empty + * pop removes next element, or throws NSEE if empty */ public void testPop() { LinkedList q = populatedQueue(SIZE); @@ -526,7 +524,7 @@ public class LinkedListTest extends JSR1 } /** - * pollLast succeeds unless empty + * pollLast succeeds unless empty */ public void testPollLast() { LinkedList q = populatedQueue(SIZE); @@ -537,7 +535,7 @@ public class LinkedListTest extends JSR1 } /** - * peekFirst returns next element, or null if empty + * peekFirst returns next element, or null if empty */ public void testPeekFirst() { LinkedList q = populatedQueue(SIZE); @@ -552,7 +550,7 @@ public class LinkedListTest extends JSR1 /** - * peekLast returns next element, or null if empty + * peekLast returns next element, or null if empty */ public void testPeekLast() { LinkedList q = populatedQueue(SIZE); @@ -578,7 +576,7 @@ public class LinkedListTest extends JSR1 } /** - * getLast returns next element, or throws NSEE if empty + * getLast returns next element, or throws NSEE if empty */ public void testLastElement() { LinkedList q = populatedQueue(SIZE);