--- jsr166/src/test/tck/LinkedListTest.java 2010/11/03 07:54:52 1.21 +++ jsr166/src/test/tck/LinkedListTest.java 2010/11/05 00:17:22 1.24 @@ -23,8 +23,8 @@ public class LinkedListTest extends JSR1 * Create a queue of given size containing consecutive * Integers 0 ... n. */ - private LinkedList populatedQueue(int n) { - LinkedList q = new LinkedList(); + private LinkedList populatedQueue(int n) { + LinkedList q = new LinkedList(); assertTrue(q.isEmpty()); for (int i = 0; i < n; ++i) assertTrue(q.offer(new Integer(i))); @@ -318,36 +318,35 @@ public class LinkedListTest extends JSR1 } /** - * toArray contains all elements + * toArray contains all elements in FIFO order */ public void testToArray() { LinkedList q = populatedQueue(SIZE); Object[] o = q.toArray(); - Arrays.sort(o); for (int i = 0; i < o.length; i++) - assertEquals(o[i], q.poll()); + assertSame(o[i], q.poll()); } /** - * toArray(a) contains all elements + * toArray(a) contains all elements in FIFO order */ public void testToArray2() { - LinkedList q = populatedQueue(SIZE); + LinkedList q = populatedQueue(SIZE); Integer[] ints = new Integer[SIZE]; - ints = (Integer[])q.toArray(ints); - Arrays.sort(ints); + Integer[] array = q.toArray(ints); + assertSame(ints, array); for (int i = 0; i < ints.length; i++) - assertEquals(ints[i], q.poll()); + assertSame(ints[i], q.poll()); } /** - * toArray(null) throws NPE + * toArray(null) throws NullPointerException */ - public void testToArray_BadArg() { + public void testToArray_NullArg() { LinkedList l = new LinkedList(); l.add(new Object()); try { - Object o[] = l.toArray(null); + l.toArray(null); shouldThrow(); } catch (NullPointerException success) {} }