ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/LinkedTransferQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/LinkedTransferQueueTest.java (file contents):
Revision 1.26 by jsr166, Tue Oct 19 00:41:14 2010 UTC vs.
Revision 1.63 by jsr166, Sun Oct 4 18:49:02 2015 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include John Vint
6   */
7  
8 < import java.io.BufferedInputStream;
9 < import java.io.BufferedOutputStream;
10 < import java.io.ByteArrayInputStream;
11 < import java.io.ByteArrayOutputStream;
12 < import java.io.ObjectInputStream;
13 < import java.io.ObjectOutputStream;
8 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
9 >
10   import java.util.ArrayList;
11   import java.util.Arrays;
12 + import java.util.Collection;
13   import java.util.Iterator;
14   import java.util.List;
15   import java.util.NoSuchElementException;
16 < import java.util.concurrent.*;
17 < import static java.util.concurrent.TimeUnit.MILLISECONDS;
16 > import java.util.Queue;
17 > import java.util.concurrent.BlockingQueue;
18 > import java.util.concurrent.CountDownLatch;
19 > import java.util.concurrent.Executors;
20 > import java.util.concurrent.ExecutorService;
21 > import java.util.concurrent.LinkedTransferQueue;
22 >
23   import junit.framework.Test;
22 import junit.framework.TestSuite;
24  
25   @SuppressWarnings({"unchecked", "rawtypes"})
26   public class LinkedTransferQueueTest extends JSR166TestCase {
27 +    static class Implementation implements CollectionImplementation {
28 +        public Class<?> klazz() { return LinkedTransferQueue.class; }
29 +        public Collection emptyCollection() { return new LinkedTransferQueue(); }
30 +        public Object makeElement(int i) { return i; }
31 +        public boolean isConcurrent() { return true; }
32 +        public boolean permitsNulls() { return false; }
33 +    }
34  
35      public static class Generic extends BlockingQueueTest {
36          protected BlockingQueue emptyCollection() {
# Line 31 | Line 39 | public class LinkedTransferQueueTest ext
39      }
40  
41      public static void main(String[] args) {
42 <        junit.textui.TestRunner.run(suite());
42 >        main(suite(), args);
43      }
44  
45      public static Test suite() {
46          return newTestSuite(LinkedTransferQueueTest.class,
47 <                            new Generic().testSuite());
48 <    }
41 <
42 <    void checkEmpty(LinkedTransferQueue q) throws InterruptedException {
43 <        assertTrue(q.isEmpty());
44 <        assertEquals(0, q.size());
45 <        assertNull(q.peek());
46 <        assertNull(q.poll());
47 <        assertNull(q.poll(0, MILLISECONDS));
48 <        assertEquals(q.toString(), "[]");
49 <        assertTrue(Arrays.equals(q.toArray(), new Object[0]));
50 <        assertFalse(q.iterator().hasNext());
51 <        try {
52 <            q.element();
53 <            shouldThrow();
54 <        } catch (NoSuchElementException success) {}
55 <        try {
56 <            q.iterator().next();
57 <            shouldThrow();
58 <        } catch (NoSuchElementException success) {}
59 <        try {
60 <            q.remove();
61 <            shouldThrow();
62 <        } catch (NoSuchElementException success) {}
47 >                            new Generic().testSuite(),
48 >                            CollectionTest.testSuite(new Implementation()));
49      }
50  
51      /**
# Line 87 | Line 73 | public class LinkedTransferQueueTest ext
73       * NullPointerException
74       */
75      public void testConstructor3() {
76 +        Collection<Integer> elements = Arrays.asList(new Integer[SIZE]);
77          try {
78 <            Integer[] ints = new Integer[SIZE];
92 <            new LinkedTransferQueue(Arrays.asList(ints));
78 >            new LinkedTransferQueue(elements);
79              shouldThrow();
80          } catch (NullPointerException success) {}
81      }
# Line 99 | Line 85 | public class LinkedTransferQueueTest ext
85       * throws NullPointerException
86       */
87      public void testConstructor4() {
88 +        Integer[] ints = new Integer[SIZE];
89 +        for (int i = 0; i < SIZE - 1; ++i)
90 +            ints[i] = i;
91 +        Collection<Integer> elements = Arrays.asList(ints);
92          try {
93 <            Integer[] ints = new Integer[SIZE];
104 <            for (int i = 0; i < SIZE - 1; ++i) {
105 <                ints[i] = i;
106 <            }
107 <            new LinkedTransferQueue(Arrays.asList(ints));
93 >            new LinkedTransferQueue(elements);
94              shouldThrow();
95          } catch (NullPointerException success) {}
96      }
# Line 137 | Line 123 | public class LinkedTransferQueueTest ext
123       * remainingCapacity() always returns Integer.MAX_VALUE
124       */
125      public void testRemainingCapacity() {
126 <        LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
126 >        BlockingQueue q = populatedQueue(SIZE);
127          for (int i = 0; i < SIZE; ++i) {
128              assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
129              assertEquals(SIZE - i, q.size());
130 <            q.remove();
130 >            assertEquals(i, q.remove());
131          }
132          for (int i = 0; i < SIZE; ++i) {
133              assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
134              assertEquals(i, q.size());
135 <            q.add(i);
135 >            assertTrue(q.add(i));
136          }
137      }
138  
139      /**
154     * offer(null) throws NullPointerException
155     */
156    public void testOfferNull() {
157        try {
158            LinkedTransferQueue q = new LinkedTransferQueue();
159            q.offer(null);
160            shouldThrow();
161        } catch (NullPointerException success) {}
162    }
163
164    /**
165     * add(null) throws NullPointerException
166     */
167    public void testAddNull() {
168        try {
169            LinkedTransferQueue q = new LinkedTransferQueue();
170            q.add(null);
171            shouldThrow();
172        } catch (NullPointerException success) {}
173    }
174
175    /**
176     * addAll(null) throws NullPointerException
177     */
178    public void testAddAll1() {
179        try {
180            LinkedTransferQueue q = new LinkedTransferQueue();
181            q.addAll(null);
182            shouldThrow();
183        } catch (NullPointerException success) {}
184    }
185
186    /**
140       * addAll(this) throws IllegalArgumentException
141       */
142      public void testAddAllSelf() {
143 +        LinkedTransferQueue q = populatedQueue(SIZE);
144          try {
191            LinkedTransferQueue q = populatedQueue(SIZE);
145              q.addAll(q);
146              shouldThrow();
147          } catch (IllegalArgumentException success) {}
148      }
149  
150      /**
198     * addAll of a collection with null elements throws NullPointerException
199     */
200    public void testAddAll2() {
201        try {
202            LinkedTransferQueue q = new LinkedTransferQueue();
203            Integer[] ints = new Integer[SIZE];
204            q.addAll(Arrays.asList(ints));
205            shouldThrow();
206        } catch (NullPointerException success) {}
207    }
208
209    /**
151       * addAll of a collection with any null elements throws
152       * NullPointerException after possibly adding some elements
153       */
154      public void testAddAll3() {
155 +        LinkedTransferQueue q = new LinkedTransferQueue();
156 +        Integer[] ints = new Integer[SIZE];
157 +        for (int i = 0; i < SIZE - 1; ++i)
158 +            ints[i] = i;
159          try {
215            LinkedTransferQueue q = new LinkedTransferQueue();
216            Integer[] ints = new Integer[SIZE];
217            for (int i = 0; i < SIZE - 1; ++i) {
218                ints[i] = i;
219            }
160              q.addAll(Arrays.asList(ints));
161              shouldThrow();
162          } catch (NullPointerException success) {}
# Line 240 | Line 180 | public class LinkedTransferQueueTest ext
180      }
181  
182      /**
243     * put(null) throws NullPointerException
244     */
245    public void testPutNull() throws InterruptedException {
246        try {
247            LinkedTransferQueue q = new LinkedTransferQueue();
248            q.put(null);
249            shouldThrow();
250        } catch (NullPointerException success) {}
251    }
252
253    /**
183       * all elements successfully put are contained
184       */
185      public void testPut() {
186          LinkedTransferQueue<Integer> q = new LinkedTransferQueue<Integer>();
187          for (int i = 0; i < SIZE; ++i) {
188 <            assertEquals(q.size(), i);
188 >            assertEquals(i, q.size());
189              q.put(i);
190              assertTrue(q.contains(i));
191          }
# Line 273 | Line 202 | public class LinkedTransferQueueTest ext
202      }
203  
204      /**
205 <     * take blocks interruptibly when empty
277 <     */
278 <    public void testTakeFromEmpty() throws InterruptedException {
279 <        final LinkedTransferQueue q = new LinkedTransferQueue();
280 <        Thread t = newStartedThread(new CheckedInterruptedRunnable() {
281 <            public void realRun() throws InterruptedException {
282 <                q.take();
283 <            }});
284 <        Thread.sleep(SHORT_DELAY_MS);
285 <        t.interrupt();
286 <        t.join();
287 <    }
288 <
289 <    /**
290 <     * Take removes existing elements until empty, then blocks interruptibly
205 >     * take removes existing elements until empty, then blocks interruptibly
206       */
207      public void testBlockingTake() throws InterruptedException {
208 <        final LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
209 <        Thread t = new Thread(new CheckedRunnable() {
208 >        final BlockingQueue q = populatedQueue(SIZE);
209 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
210 >        Thread t = newStartedThread(new CheckedRunnable() {
211              public void realRun() throws InterruptedException {
212                  for (int i = 0; i < SIZE; ++i) {
213 <                    assertEquals(i, (int) q.take());
213 >                    assertEquals(i, q.take());
214                  }
215 +
216 +                Thread.currentThread().interrupt();
217 +                try {
218 +                    q.take();
219 +                    shouldThrow();
220 +                } catch (InterruptedException success) {}
221 +                assertFalse(Thread.interrupted());
222 +
223 +                pleaseInterrupt.countDown();
224                  try {
225                      q.take();
226                      shouldThrow();
227                  } catch (InterruptedException success) {}
228 +                assertFalse(Thread.interrupted());
229              }});
230  
231 <        t.start();
232 <        Thread.sleep(SHORT_DELAY_MS);
231 >        await(pleaseInterrupt);
232 >        assertThreadStaysAlive(t);
233          t.interrupt();
234 <        t.join();
309 <        checkEmpty(q);
234 >        awaitTermination(t);
235      }
236  
237      /**
# Line 322 | Line 247 | public class LinkedTransferQueueTest ext
247      }
248  
249      /**
250 <     * timed pool with zero timeout succeeds when non-empty, else times out
250 >     * timed poll with zero timeout succeeds when non-empty, else times out
251       */
252      public void testTimedPoll0() throws InterruptedException {
253          LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
# Line 334 | Line 259 | public class LinkedTransferQueueTest ext
259      }
260  
261      /**
262 <     * timed pool with nonzero timeout succeeds when non-empty, else times out
262 >     * timed poll with nonzero timeout succeeds when non-empty, else times out
263       */
264      public void testTimedPoll() throws InterruptedException {
265          LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
266          for (int i = 0; i < SIZE; ++i) {
267 <            long t0 = System.nanoTime();
267 >            long startTime = System.nanoTime();
268              assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
269 <            long millisElapsed = (System.nanoTime() - t0)/(1024 * 1024);
345 <            assertTrue(millisElapsed < SMALL_DELAY_MS);
269 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
270          }
271 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
271 >        long startTime = System.nanoTime();
272 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
273 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
274          checkEmpty(q);
275      }
276  
# Line 353 | Line 279 | public class LinkedTransferQueueTest ext
279       * returning timeout status
280       */
281      public void testInterruptedTimedPoll() throws InterruptedException {
282 <        final LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
282 >        final BlockingQueue<Integer> q = populatedQueue(SIZE);
283 >        final CountDownLatch aboutToWait = new CountDownLatch(1);
284          Thread t = newStartedThread(new CheckedRunnable() {
285              public void realRun() throws InterruptedException {
286                  for (int i = 0; i < SIZE; ++i) {
287                      long t0 = System.nanoTime();
288                      assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
289 <                    long millisElapsed = (System.nanoTime() - t0)/(1024 * 1024);
363 <                    assertTrue(millisElapsed < SMALL_DELAY_MS);
289 >                    assertTrue(millisElapsedSince(t0) < SMALL_DELAY_MS);
290                  }
291 +                long t0 = System.nanoTime();
292 +                aboutToWait.countDown();
293                  try {
294 <                    q.poll(LONG_DELAY_MS, MILLISECONDS);
294 >                    q.poll(MEDIUM_DELAY_MS, MILLISECONDS);
295                      shouldThrow();
296 <                } catch (InterruptedException success) {}
296 >                } catch (InterruptedException success) {
297 >                    assertTrue(millisElapsedSince(t0) < MEDIUM_DELAY_MS);
298 >                }
299              }});
300  
301 <        Thread.sleep(SMALL_DELAY_MS);
301 >        aboutToWait.await();
302 >        waitForThreadToEnterWaitState(t, SMALL_DELAY_MS);
303          t.interrupt();
304 <        t.join();
304 >        awaitTermination(t, MEDIUM_DELAY_MS);
305 >        checkEmpty(q);
306 >    }
307 >
308 >    /**
309 >     * timed poll after thread interrupted throws InterruptedException
310 >     * instead of returning timeout status
311 >     */
312 >    public void testTimedPollAfterInterrupt() throws InterruptedException {
313 >        final BlockingQueue<Integer> q = populatedQueue(SIZE);
314 >        Thread t = newStartedThread(new CheckedRunnable() {
315 >            public void realRun() throws InterruptedException {
316 >                Thread.currentThread().interrupt();
317 >                for (int i = 0; i < SIZE; ++i) {
318 >                    long t0 = System.nanoTime();
319 >                    assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
320 >                    assertTrue(millisElapsedSince(t0) < SMALL_DELAY_MS);
321 >                }
322 >                try {
323 >                    q.poll(MEDIUM_DELAY_MS, MILLISECONDS);
324 >                    shouldThrow();
325 >                } catch (InterruptedException success) {}
326 >            }});
327 >
328 >        awaitTermination(t, MEDIUM_DELAY_MS);
329          checkEmpty(q);
330      }
331  
# Line 421 | Line 376 | public class LinkedTransferQueueTest ext
376      }
377  
378      /**
424     * remove(x) removes x and returns true if present
425     */
426    public void testRemoveElement() throws InterruptedException {
427        LinkedTransferQueue q = populatedQueue(SIZE);
428        for (int i = 1; i < SIZE; i += 2) {
429            assertTrue(q.remove(i));
430        }
431        for (int i = 0; i < SIZE; i += 2) {
432            assertTrue(q.remove(i));
433            assertFalse(q.remove(i + 1));
434        }
435        checkEmpty(q);
436    }
437
438    /**
379       * An add following remove(x) succeeds
380       */
381      public void testRemoveElementAndAdd() throws InterruptedException {
# Line 527 | Line 467 | public class LinkedTransferQueueTest ext
467      }
468  
469      /**
470 <     * toArray() contains all elements
470 >     * toArray() contains all elements in FIFO order
471       */
472 <    public void testToArray() throws InterruptedException {
472 >    public void testToArray() {
473          LinkedTransferQueue q = populatedQueue(SIZE);
474          Object[] o = q.toArray();
475          for (int i = 0; i < o.length; i++) {
476 <            assertEquals(o[i], q.take());
476 >            assertSame(o[i], q.poll());
477          }
478      }
479  
480      /**
481 <     * toArray(a) contains all elements
481 >     * toArray(a) contains all elements in FIFO order
482       */
483 <    public void testToArray2() throws InterruptedException {
483 >    public void testToArray2() {
484          LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
485          Integer[] ints = new Integer[SIZE];
486 <        ints = q.toArray(ints);
486 >        Integer[] array = q.toArray(ints);
487 >        assertSame(ints, array);
488          for (int i = 0; i < ints.length; i++) {
489 <            assertEquals(ints[i], q.take());
489 >            assertSame(ints[i], q.poll());
490          }
491      }
492  
493      /**
494 <     * toArray(null) throws NullPointerException
554 <     */
555 <    public void testToArray_BadArg() {
556 <        LinkedTransferQueue q = populatedQueue(SIZE);
557 <        try {
558 <            Object o[] = q.toArray(null);
559 <            shouldThrow();
560 <        } catch (NullPointerException success) {}
561 <    }
562 <
563 <    /**
564 <     * toArray(incompatible array type) throws CCE
494 >     * toArray(incompatible array type) throws ArrayStoreException
495       */
496      public void testToArray1_BadArg() {
497          LinkedTransferQueue q = populatedQueue(SIZE);
498          try {
499 <            Object o[] = q.toArray(new String[10]);
499 >            q.toArray(new String[10]);
500              shouldThrow();
501          } catch (ArrayStoreException success) {}
502      }
# Line 577 | Line 507 | public class LinkedTransferQueueTest ext
507      public void testIterator() throws InterruptedException {
508          LinkedTransferQueue q = populatedQueue(SIZE);
509          Iterator it = q.iterator();
510 <        int i = 0;
511 <        while (it.hasNext()) {
512 <            assertEquals(it.next(), i++);
583 <        }
510 >        int i;
511 >        for (i = 0; it.hasNext(); i++)
512 >            assertTrue(q.contains(it.next()));
513          assertEquals(i, SIZE);
514 +        assertIteratorExhausted(it);
515 +
516 +        it = q.iterator();
517 +        for (i = 0; it.hasNext(); i++)
518 +            assertEquals(it.next(), q.take());
519 +        assertEquals(i, SIZE);
520 +        assertIteratorExhausted(it);
521 +    }
522 +
523 +    /**
524 +     * iterator of empty collection has no elements
525 +     */
526 +    public void testEmptyIterator() {
527 +        assertIteratorExhausted(new LinkedTransferQueue().iterator());
528      }
529  
530      /**
# Line 643 | Line 586 | public class LinkedTransferQueueTest ext
586          LinkedTransferQueue q = populatedQueue(SIZE);
587          String s = q.toString();
588          for (int i = 0; i < SIZE; ++i) {
589 <            assertTrue(s.indexOf(String.valueOf(i)) >= 0);
589 >            assertTrue(s.contains(String.valueOf(i)));
590          }
591      }
592  
# Line 652 | Line 595 | public class LinkedTransferQueueTest ext
595       */
596      public void testOfferInExecutor() {
597          final LinkedTransferQueue q = new LinkedTransferQueue();
598 <        q.add(one);
599 <        q.add(two);
600 <        ExecutorService executor = Executors.newFixedThreadPool(2);
658 <
659 <        executor.execute(new CheckedRunnable() {
660 <            public void realRun() {
661 <                assertTrue(q.offer(three, MEDIUM_DELAY_MS, MILLISECONDS));
662 <            }});
598 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
599 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
600 >        try (PoolCleaner cleaner = cleaner(executor)) {
601  
602 <        executor.execute(new CheckedRunnable() {
603 <            public void realRun() throws InterruptedException {
604 <                Thread.sleep(SMALL_DELAY_MS);
605 <                assertSame(one, q.take());
606 <            }});
602 >            executor.execute(new CheckedRunnable() {
603 >                public void realRun() throws InterruptedException {
604 >                    threadsStarted.await();
605 >                    assertTrue(q.offer(one, LONG_DELAY_MS, MILLISECONDS));
606 >                }});
607  
608 <        joinPool(executor);
608 >            executor.execute(new CheckedRunnable() {
609 >                public void realRun() throws InterruptedException {
610 >                    threadsStarted.await();
611 >                    assertSame(one, q.take());
612 >                    checkEmpty(q);
613 >                }});
614 >        }
615      }
616  
617      /**
# Line 675 | Line 619 | public class LinkedTransferQueueTest ext
619       */
620      public void testPollInExecutor() {
621          final LinkedTransferQueue q = new LinkedTransferQueue();
622 <        ExecutorService executor = Executors.newFixedThreadPool(2);
623 <
624 <        executor.execute(new CheckedRunnable() {
681 <            public void realRun() throws InterruptedException {
682 <                assertNull(q.poll());
683 <                assertSame(one, q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
684 <                assertTrue(q.isEmpty());
685 <            }});
622 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
623 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
624 >        try (PoolCleaner cleaner = cleaner(executor)) {
625  
626 <        executor.execute(new CheckedRunnable() {
627 <            public void realRun() throws InterruptedException {
628 <                Thread.sleep(SMALL_DELAY_MS);
629 <                q.put(one);
630 <            }});
626 >            executor.execute(new CheckedRunnable() {
627 >                public void realRun() throws InterruptedException {
628 >                    assertNull(q.poll());
629 >                    threadsStarted.await();
630 >                    assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
631 >                    checkEmpty(q);
632 >                }});
633  
634 <        joinPool(executor);
634 >            executor.execute(new CheckedRunnable() {
635 >                public void realRun() throws InterruptedException {
636 >                    threadsStarted.await();
637 >                    q.put(one);
638 >                }});
639 >        }
640      }
641  
642      /**
643       * A deserialized serialized queue has same elements in same order
644       */
645      public void testSerialization() throws Exception {
646 <        LinkedTransferQueue q = populatedQueue(SIZE);
646 >        Queue x = populatedQueue(SIZE);
647 >        Queue y = serialClone(x);
648  
649 <        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
650 <        ObjectOutputStream out
651 <            = new ObjectOutputStream(new BufferedOutputStream(bout));
652 <        out.writeObject(q);
653 <        out.close();
654 <
655 <        ByteArrayInputStream bin
709 <            = new ByteArrayInputStream(bout.toByteArray());
710 <        ObjectInputStream in
711 <            = new ObjectInputStream(new BufferedInputStream(bin));
712 <        LinkedTransferQueue r = (LinkedTransferQueue) in.readObject();
713 <
714 <        assertEquals(q.size(), r.size());
715 <        while (!q.isEmpty()) {
716 <            assertEquals(q.remove(), r.remove());
649 >        assertNotSame(y, x);
650 >        assertEquals(x.size(), y.size());
651 >        assertEquals(x.toString(), y.toString());
652 >        assertTrue(Arrays.equals(x.toArray(), y.toArray()));
653 >        while (!x.isEmpty()) {
654 >            assertFalse(y.isEmpty());
655 >            assertEquals(x.remove(), y.remove());
656          }
657 <    }
719 <
720 <    /**
721 <     * drainTo(null) throws NullPointerException
722 <     */
723 <    public void testDrainToNull() {
724 <        LinkedTransferQueue q = populatedQueue(SIZE);
725 <        try {
726 <            q.drainTo(null);
727 <            shouldThrow();
728 <        } catch (NullPointerException success) {}
729 <    }
730 <
731 <    /**
732 <     * drainTo(this) throws IllegalArgumentException
733 <     */
734 <    public void testDrainToSelf() {
735 <        LinkedTransferQueue q = populatedQueue(SIZE);
736 <        try {
737 <            q.drainTo(q);
738 <            shouldThrow();
739 <        } catch (IllegalArgumentException success) {}
657 >        assertTrue(y.isEmpty());
658      }
659  
660      /**
# Line 746 | Line 664 | public class LinkedTransferQueueTest ext
664          LinkedTransferQueue q = populatedQueue(SIZE);
665          ArrayList l = new ArrayList();
666          q.drainTo(l);
667 <        assertEquals(q.size(), 0);
668 <        assertEquals(l.size(), SIZE);
667 >        assertEquals(0, q.size());
668 >        assertEquals(SIZE, l.size());
669          for (int i = 0; i < SIZE; ++i) {
670 <            assertEquals(l.get(i), i);
670 >            assertEquals(i, l.get(i));
671          }
672          q.add(zero);
673          q.add(one);
# Line 758 | Line 676 | public class LinkedTransferQueueTest ext
676          assertTrue(q.contains(one));
677          l.clear();
678          q.drainTo(l);
679 <        assertEquals(q.size(), 0);
680 <        assertEquals(l.size(), 2);
679 >        assertEquals(0, q.size());
680 >        assertEquals(2, l.size());
681          for (int i = 0; i < 2; ++i) {
682 <            assertEquals(l.get(i), i);
682 >            assertEquals(i, l.get(i));
683          }
684      }
685  
# Line 777 | Line 695 | public class LinkedTransferQueueTest ext
695          ArrayList l = new ArrayList();
696          q.drainTo(l);
697          assertTrue(l.size() >= SIZE);
698 <        for (int i = 0; i < SIZE; ++i) {
699 <            assertEquals(l.get(i), i);
700 <        }
783 <        t.join();
698 >        for (int i = 0; i < SIZE; ++i)
699 >            assertEquals(i, l.get(i));
700 >        awaitTermination(t, MEDIUM_DELAY_MS);
701          assertTrue(q.size() + l.size() >= SIZE);
702      }
703  
704      /**
788     * drainTo(null, n) throws NullPointerException
789     */
790    public void testDrainToNullN() {
791        LinkedTransferQueue q = populatedQueue(SIZE);
792        try {
793            q.drainTo(null, SIZE);
794            shouldThrow();
795        } catch (NullPointerException success) {}
796    }
797
798    /**
799     * drainTo(this, n) throws IllegalArgumentException
800     */
801    public void testDrainToSelfN() {
802        LinkedTransferQueue q = populatedQueue(SIZE);
803        try {
804            q.drainTo(q, SIZE);
805            shouldThrow();
806        } catch (IllegalArgumentException success) {}
807    }
808
809    /**
705       * drainTo(c, n) empties first min(n, size) elements of queue into c
706       */
707      public void testDrainToN() {
# Line 818 | Line 713 | public class LinkedTransferQueueTest ext
713              ArrayList l = new ArrayList();
714              q.drainTo(l, i);
715              int k = (i < SIZE) ? i : SIZE;
716 <            assertEquals(l.size(), k);
717 <            assertEquals(q.size(), SIZE - k);
718 <            for (int j = 0; j < k; ++j) {
719 <                assertEquals(l.get(j), j);
720 <            }
826 <            while (q.poll() != null)
827 <                ;
716 >            assertEquals(k, l.size());
717 >            assertEquals(SIZE - k, q.size());
718 >            for (int j = 0; j < k; ++j)
719 >                assertEquals(j, l.get(j));
720 >            do {} while (q.poll() != null);
721          }
722      }
723  
# Line 834 | Line 727 | public class LinkedTransferQueueTest ext
727       */
728      public void testWaitingConsumer() throws InterruptedException {
729          final LinkedTransferQueue q = new LinkedTransferQueue();
730 <        assertEquals(q.getWaitingConsumerCount(), 0);
730 >        assertEquals(0, q.getWaitingConsumerCount());
731          assertFalse(q.hasWaitingConsumer());
732 +        final CountDownLatch threadStarted = new CountDownLatch(1);
733  
734          Thread t = newStartedThread(new CheckedRunnable() {
735              public void realRun() throws InterruptedException {
736 <                Thread.sleep(SMALL_DELAY_MS);
737 <                assertTrue(q.hasWaitingConsumer());
738 <                assertEquals(q.getWaitingConsumerCount(), 1);
845 <                assertTrue(q.offer(one));
736 >                threadStarted.countDown();
737 >                assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
738 >                assertEquals(0, q.getWaitingConsumerCount());
739                  assertFalse(q.hasWaitingConsumer());
847                assertEquals(q.getWaitingConsumerCount(), 0);
740              }});
741  
742 <        assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
743 <        assertEquals(q.getWaitingConsumerCount(), 0);
742 >        threadStarted.await();
743 >        waitForThreadToEnterWaitState(t, SMALL_DELAY_MS);
744 >        assertEquals(1, q.getWaitingConsumerCount());
745 >        assertTrue(q.hasWaitingConsumer());
746 >
747 >        assertTrue(q.offer(one));
748 >        assertEquals(0, q.getWaitingConsumerCount());
749          assertFalse(q.hasWaitingConsumer());
750 <        t.join();
750 >
751 >        awaitTermination(t, MEDIUM_DELAY_MS);
752      }
753  
754      /**
# Line 871 | Line 769 | public class LinkedTransferQueueTest ext
769      public void testTransfer2() throws InterruptedException {
770          final LinkedTransferQueue<Integer> q
771              = new LinkedTransferQueue<Integer>();
772 +        final CountDownLatch threadStarted = new CountDownLatch(1);
773  
774          Thread t = newStartedThread(new CheckedRunnable() {
775              public void realRun() throws InterruptedException {
776 <                q.transfer(SIZE);
777 <                assertTrue(q.isEmpty());
776 >                threadStarted.countDown();
777 >                q.transfer(five);
778 >                checkEmpty(q);
779              }});
780  
781 <        Thread.sleep(SHORT_DELAY_MS);
781 >        threadStarted.await();
782 >        waitForThreadToEnterWaitState(t, SMALL_DELAY_MS);
783          assertEquals(1, q.size());
784 <        assertEquals(SIZE, (int) q.poll());
785 <        assertTrue(q.isEmpty());
786 <        t.join();
784 >        assertSame(five, q.poll());
785 >        checkEmpty(q);
786 >        awaitTermination(t, MEDIUM_DELAY_MS);
787      }
788  
789      /**
# Line 894 | Line 795 | public class LinkedTransferQueueTest ext
795  
796          Thread first = newStartedThread(new CheckedRunnable() {
797              public void realRun() throws InterruptedException {
798 <                Integer i = SIZE + 1;
799 <                q.transfer(i);
899 <                assertTrue(!q.contains(i));
798 >                q.transfer(four);
799 >                assertTrue(!q.contains(four));
800                  assertEquals(1, q.size());
801              }});
802  
803          Thread interruptedThread = newStartedThread(
804              new CheckedInterruptedRunnable() {
805                  public void realRun() throws InterruptedException {
806 <                    while (q.size() == 0)
806 >                    while (q.isEmpty())
807                          Thread.yield();
808 <                    q.transfer(SIZE);
808 >                    q.transfer(five);
809                  }});
810  
811          while (q.size() < 2)
812              Thread.yield();
813          assertEquals(2, q.size());
814 <        assertEquals(SIZE + 1, (int) q.poll());
814 >        assertSame(four, q.poll());
815          first.join();
816          assertEquals(1, q.size());
817          interruptedThread.interrupt();
818          interruptedThread.join();
819 <        assertEquals(0, q.size());
920 <        assertTrue(q.isEmpty());
819 >        checkEmpty(q);
820      }
821  
822      /**
# Line 934 | Line 833 | public class LinkedTransferQueueTest ext
833                  assertSame(three, q.poll());
834              }});
835  
836 <        Thread.sleep(SHORT_DELAY_MS);
836 >        while (q.isEmpty())
837 >            Thread.yield();
838 >        assertFalse(q.isEmpty());
839 >        assertEquals(1, q.size());
840          assertTrue(q.offer(three));
841          assertSame(four, q.poll());
842 <        t.join();
842 >        awaitTermination(t, MEDIUM_DELAY_MS);
843      }
844  
845      /**
# Line 950 | Line 852 | public class LinkedTransferQueueTest ext
852  
853          Thread t = newStartedThread(new CheckedRunnable() {
854              public void realRun() throws InterruptedException {
855 <                q.transfer(SIZE);
855 >                q.transfer(four);
856                  checkEmpty(q);
857              }});
858  
859 <        Thread.sleep(SHORT_DELAY_MS);
860 <        assertEquals(SIZE, (int) q.take());
859 >        while (q.isEmpty())
860 >            Thread.yield();
861 >        assertFalse(q.isEmpty());
862 >        assertEquals(1, q.size());
863 >        assertSame(four, q.take());
864          checkEmpty(q);
865 <        t.join();
865 >        awaitTermination(t, MEDIUM_DELAY_MS);
866      }
867  
868      /**
869       * tryTransfer(null) throws NullPointerException
870       */
871      public void testTryTransfer1() {
872 +        final LinkedTransferQueue q = new LinkedTransferQueue();
873          try {
968            final LinkedTransferQueue q = new LinkedTransferQueue();
874              q.tryTransfer(null);
875              shouldThrow();
876          } catch (NullPointerException success) {}
# Line 995 | Line 900 | public class LinkedTransferQueueTest ext
900                  while (! q.hasWaitingConsumer())
901                      Thread.yield();
902                  assertTrue(q.hasWaitingConsumer());
903 <                assertTrue(q.isEmpty());
999 <                assertEquals(q.size(), 0);
903 >                checkEmpty(q);
904                  assertTrue(q.tryTransfer(hotPotato));
905              }});
906  
907          assertSame(hotPotato, q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
908          checkEmpty(q);
909 <        t.join();
909 >        awaitTermination(t, MEDIUM_DELAY_MS);
910      }
911  
912      /**
# Line 1018 | Line 922 | public class LinkedTransferQueueTest ext
922                  while (! q.hasWaitingConsumer())
923                      Thread.yield();
924                  assertTrue(q.hasWaitingConsumer());
925 <                assertTrue(q.isEmpty());
1022 <                assertEquals(q.size(), 0);
925 >                checkEmpty(q);
926                  assertTrue(q.tryTransfer(hotPotato));
927              }});
928  
929          assertSame(q.take(), hotPotato);
930          checkEmpty(q);
931 <        t.join();
931 >        awaitTermination(t, MEDIUM_DELAY_MS);
932      }
933  
934      /**
935 <     * tryTransfer waits the amount given if interrupted, and
1033 <     * throws interrupted exception
935 >     * tryTransfer blocks interruptibly if no takers
936       */
937      public void testTryTransfer5() throws InterruptedException {
938          final LinkedTransferQueue q = new LinkedTransferQueue();
939 +        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
940 +        assertTrue(q.isEmpty());
941  
942 <        Thread toInterrupt = newStartedThread(new CheckedInterruptedRunnable() {
942 >        Thread t = newStartedThread(new CheckedRunnable() {
943              public void realRun() throws InterruptedException {
944 <                q.tryTransfer(new Object(), LONG_DELAY_MS, MILLISECONDS);
944 >                Thread.currentThread().interrupt();
945 >                try {
946 >                    q.tryTransfer(new Object(), LONG_DELAY_MS, MILLISECONDS);
947 >                    shouldThrow();
948 >                } catch (InterruptedException success) {}
949 >                assertFalse(Thread.interrupted());
950 >
951 >                pleaseInterrupt.countDown();
952 >                try {
953 >                    q.tryTransfer(new Object(), LONG_DELAY_MS, MILLISECONDS);
954 >                    shouldThrow();
955 >                } catch (InterruptedException success) {}
956 >                assertFalse(Thread.interrupted());
957              }});
958  
959 <        Thread.sleep(SMALL_DELAY_MS);
960 <        toInterrupt.interrupt();
961 <        toInterrupt.join();
959 >        await(pleaseInterrupt);
960 >        assertThreadStaysAlive(t);
961 >        t.interrupt();
962 >        awaitTermination(t);
963 >        checkEmpty(q);
964      }
965  
966      /**
967 <     * tryTransfer gives up after the timeout and return false
967 >     * tryTransfer gives up after the timeout and returns false
968       */
969      public void testTryTransfer6() throws InterruptedException {
970          final LinkedTransferQueue q = new LinkedTransferQueue();
971  
972          Thread t = newStartedThread(new CheckedRunnable() {
973              public void realRun() throws InterruptedException {
974 +                long t0 = System.nanoTime();
975                  assertFalse(q.tryTransfer(new Object(),
976 <                                          SHORT_DELAY_MS, MILLISECONDS));
976 >                                          timeoutMillis(), MILLISECONDS));
977 >                assertTrue(millisElapsedSince(t0) >= timeoutMillis());
978 >                checkEmpty(q);
979              }});
980  
981 <        Thread.sleep(SMALL_DELAY_MS);
981 >        awaitTermination(t);
982          checkEmpty(q);
1062        t.join();
983      }
984  
985      /**
# Line 1073 | Line 993 | public class LinkedTransferQueueTest ext
993          Thread t = newStartedThread(new CheckedRunnable() {
994              public void realRun() throws InterruptedException {
995                  assertTrue(q.tryTransfer(five, MEDIUM_DELAY_MS, MILLISECONDS));
996 <                assertTrue(q.isEmpty());
996 >                checkEmpty(q);
997              }});
998  
999 <        Thread.sleep(SHORT_DELAY_MS);
999 >        while (q.size() != 2)
1000 >            Thread.yield();
1001          assertEquals(2, q.size());
1002          assertSame(four, q.poll());
1003          assertSame(five, q.poll());
1004          checkEmpty(q);
1005 <        t.join();
1005 >        awaitTermination(t, MEDIUM_DELAY_MS);
1006      }
1007  
1008      /**
1009 <     * tryTransfer attempts to enqueue into the q and fails returning
1010 <     * false not enqueueing and the successive poll is null
1009 >     * tryTransfer attempts to enqueue into the queue and fails
1010 >     * returning false not enqueueing and the successive poll is null
1011       */
1012      public void testTryTransfer8() throws InterruptedException {
1013          final LinkedTransferQueue q = new LinkedTransferQueue();
1014          assertTrue(q.offer(four));
1015          assertEquals(1, q.size());
1016 <        assertFalse(q.tryTransfer(five, SHORT_DELAY_MS, MILLISECONDS));
1016 >        long t0 = System.nanoTime();
1017 >        assertFalse(q.tryTransfer(five, timeoutMillis(), MILLISECONDS));
1018 >        assertTrue(millisElapsedSince(t0) >= timeoutMillis());
1019          assertEquals(1, q.size());
1020          assertSame(four, q.poll());
1021          assertNull(q.poll());
# Line 1101 | Line 1024 | public class LinkedTransferQueueTest ext
1024  
1025      private LinkedTransferQueue<Integer> populatedQueue(int n) {
1026          LinkedTransferQueue<Integer> q = new LinkedTransferQueue<Integer>();
1027 <        assertTrue(q.isEmpty());
1027 >        checkEmpty(q);
1028          for (int i = 0; i < n; i++) {
1029              assertEquals(i, q.size());
1030              assertTrue(q.offer(i));
# Line 1110 | Line 1033 | public class LinkedTransferQueueTest ext
1033          assertFalse(q.isEmpty());
1034          return q;
1035      }
1036 +
1037 +    /**
1038 +     * remove(null), contains(null) always return false
1039 +     */
1040 +    public void testNeverContainsNull() {
1041 +        Collection<?>[] qs = {
1042 +            new LinkedTransferQueue<Object>(),
1043 +            populatedQueue(2),
1044 +        };
1045 +
1046 +        for (Collection<?> q : qs) {
1047 +            assertFalse(q.contains(null));
1048 +            assertFalse(q.remove(null));
1049 +        }
1050 +    }
1051   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines