ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/PhaserTest.java
(Generate patch)

Comparing jsr166/src/test/tck/PhaserTest.java (file contents):
Revision 1.33 by jsr166, Wed Jun 22 07:46:57 2011 UTC vs.
Revision 1.45 by jsr166, Sat Feb 18 15:05:55 2017 UTC

# Line 5 | Line 5
5   * Other contributors include John Vint
6   */
7  
8 < import junit.framework.*;
8 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
9 >
10   import java.util.ArrayList;
11   import java.util.List;
11 import java.util.concurrent.Phaser;
12   import java.util.concurrent.CountDownLatch;
13 + import java.util.concurrent.Phaser;
14   import java.util.concurrent.TimeoutException;
14 import static java.util.concurrent.TimeUnit.MILLISECONDS;
15 import static java.util.concurrent.TimeUnit.NANOSECONDS;
16 import java.util.concurrent.atomic.AtomicBoolean;
15   import java.util.concurrent.atomic.AtomicInteger;
16  
17 + import junit.framework.Test;
18 + import junit.framework.TestSuite;
19 +
20   public class PhaserTest extends JSR166TestCase {
21  
22      public static void main(String[] args) {
23 <        junit.textui.TestRunner.run(suite());
23 >        main(suite(), args);
24      }
25  
26      public static Test suite() {
# Line 165 | Line 166 | public class PhaserTest extends JSR166Te
166      }
167  
168      /**
169 <     * register() correctly returns the current barrier phase number when
170 <     * invoked
169 >     * register() correctly returns the current barrier phase number
170 >     * when invoked
171       */
172      public void testRegister3() {
173          Phaser phaser = new Phaser();
# Line 177 | Line 178 | public class PhaserTest extends JSR166Te
178      }
179  
180      /**
181 <     * register causes the next arrive to not increment the phase rather retain
182 <     * the phase number
181 >     * register causes the next arrive to not increment the phase
182 >     * rather retain the phase number
183       */
184      public void testRegister4() {
185          Phaser phaser = new Phaser(1);
# Line 189 | Line 190 | public class PhaserTest extends JSR166Te
190      }
191  
192      /**
193 +     * register on a subphaser that is currently empty succeeds, even
194 +     * in the presence of another non-empty subphaser
195 +     */
196 +    public void testRegisterEmptySubPhaser() {
197 +        Phaser root = new Phaser();
198 +        Phaser child1 = new Phaser(root, 1);
199 +        Phaser child2 = new Phaser(root, 0);
200 +        assertEquals(0, child2.register());
201 +        assertState(root, 0, 2, 2);
202 +        assertState(child1, 0, 1, 1);
203 +        assertState(child2, 0, 1, 1);
204 +        assertEquals(0, child2.arriveAndDeregister());
205 +        assertState(root, 0, 1, 1);
206 +        assertState(child1, 0, 1, 1);
207 +        assertState(child2, 0, 0, 0);
208 +        assertEquals(0, child2.register());
209 +        assertEquals(0, child2.arriveAndDeregister());
210 +        assertState(root, 0, 1, 1);
211 +        assertState(child1, 0, 1, 1);
212 +        assertState(child2, 0, 0, 0);
213 +        assertEquals(0, child1.arriveAndDeregister());
214 +        assertTerminated(root, 1);
215 +        assertTerminated(child1, 1);
216 +        assertTerminated(child2, 1);
217 +    }
218 +
219 +    /**
220       * Invoking bulkRegister with a negative parameter throws an
221       * IllegalArgumentException
222       */
# Line 200 | Line 228 | public class PhaserTest extends JSR166Te
228      }
229  
230      /**
231 <     * bulkRegister should correctly record the number of unarrived parties with
232 <     * the number of parties being registered
231 >     * bulkRegister should correctly record the number of unarrived
232 >     * parties with the number of parties being registered
233       */
234      public void testBulkRegister2() {
235          Phaser phaser = new Phaser();
# Line 274 | Line 302 | public class PhaserTest extends JSR166Te
302      public void testArrive2() {
303          final Phaser phaser = new Phaser();
304          assertEquals(0, phaser.register());
305 <        List<Thread> threads = new ArrayList<Thread>();
305 >        List<Thread> threads = new ArrayList<>();
306          for (int i = 0; i < 10; i++) {
307              assertEquals(0, phaser.register());
308              threads.add(newStartedThread(new CheckedRunnable() {
# Line 310 | Line 338 | public class PhaserTest extends JSR166Te
338       * registered or unarrived parties would become negative
339       */
340      public void testArriveAndDeregister1() {
341 +        Phaser phaser = new Phaser();
342          try {
314            Phaser phaser = new Phaser();
343              phaser.arriveAndDeregister();
344              shouldThrow();
345          } catch (IllegalStateException success) {}
# Line 495 | Line 523 | public class PhaserTest extends JSR166Te
523              }});
524  
525          await(pleaseArrive);
526 <        waitForThreadToEnterWaitState(t, SHORT_DELAY_MS);
526 >        waitForThreadToEnterWaitState(t);
527          assertEquals(0, phaser.arrive());
528          awaitTermination(t);
529  
# Line 523 | Line 551 | public class PhaserTest extends JSR166Te
551              }});
552  
553          await(pleaseArrive);
554 <        waitForThreadToEnterWaitState(t, SHORT_DELAY_MS);
554 >        waitForThreadToEnterWaitState(t);
555          t.interrupt();
556          assertEquals(0, phaser.arrive());
557          awaitTermination(t);
# Line 539 | Line 567 | public class PhaserTest extends JSR166Te
567      public void testArriveAndAwaitAdvanceAfterInterrupt() {
568          final Phaser phaser = new Phaser();
569          assertEquals(0, phaser.register());
570 <        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
570 >        final CountDownLatch pleaseArrive = new CountDownLatch(1);
571  
572          Thread t = newStartedThread(new CheckedRunnable() {
573              public void realRun() {
574                  Thread.currentThread().interrupt();
575                  assertEquals(0, phaser.register());
576 <                pleaseInterrupt.countDown();
576 >                pleaseArrive.countDown();
577                  assertTrue(Thread.currentThread().isInterrupted());
578                  assertEquals(1, phaser.arriveAndAwaitAdvance());
579 <                assertTrue(Thread.currentThread().isInterrupted());
579 >                assertTrue(Thread.interrupted());
580              }});
581  
582 <        await(pleaseInterrupt);
583 <        waitForThreadToEnterWaitState(t, SHORT_DELAY_MS);
582 >        await(pleaseArrive);
583 >        waitForThreadToEnterWaitState(t);
584          Thread.currentThread().interrupt();
585          assertEquals(1, phaser.arriveAndAwaitAdvance());
586          assertTrue(Thread.interrupted());
# Line 573 | Line 601 | public class PhaserTest extends JSR166Te
601                  assertFalse(Thread.currentThread().isInterrupted());
602                  pleaseInterrupt.countDown();
603                  assertEquals(1, phaser.arriveAndAwaitAdvance());
604 <                assertTrue(Thread.currentThread().isInterrupted());
604 >                assertTrue(Thread.interrupted());
605              }});
606  
607          await(pleaseInterrupt);
608 <        waitForThreadToEnterWaitState(t, SHORT_DELAY_MS);
608 >        waitForThreadToEnterWaitState(t);
609          t.interrupt();
610          Thread.currentThread().interrupt();
611          assertEquals(1, phaser.arriveAndAwaitAdvance());
# Line 592 | Line 620 | public class PhaserTest extends JSR166Te
620      public void testAwaitAdvance4() {
621          final Phaser phaser = new Phaser(4);
622          final AtomicInteger count = new AtomicInteger(0);
623 <        List<Thread> threads = new ArrayList<Thread>();
623 >        List<Thread> threads = new ArrayList<>();
624          for (int i = 0; i < 4; i++)
625              threads.add(newStartedThread(new CheckedRunnable() {
626                  public void realRun() {
627                      for (int k = 0; k < 3; k++) {
628 <                        assertEquals(2*k+1, phaser.arriveAndAwaitAdvance());
628 >                        assertEquals(2 * k + 1, phaser.arriveAndAwaitAdvance());
629                          count.incrementAndGet();
630 <                        assertEquals(2*k+1, phaser.arrive());
631 <                        assertEquals(2*k+2, phaser.awaitAdvance(2*k+1));
632 <                        assertEquals(count.get(), 4*(k+1));
630 >                        assertEquals(2 * k + 1, phaser.arrive());
631 >                        assertEquals(2 * k + 2, phaser.awaitAdvance(2 * k + 1));
632 >                        assertEquals(4 * (k + 1), count.get());
633                      }}}));
634  
635          for (Thread thread : threads)
# Line 616 | Line 644 | public class PhaserTest extends JSR166Te
644          assertEquals(1, phaser.awaitAdvance(phaser.arrive()));
645          assertEquals(1, phaser.getPhase());
646          assertEquals(1, phaser.register());
647 <        List<Thread> threads = new ArrayList<Thread>();
647 >        List<Thread> threads = new ArrayList<>();
648          for (int i = 0; i < 8; i++) {
649              final CountDownLatch latch = new CountDownLatch(1);
650              final boolean goesFirst = ((i & 1) == 0);
# Line 644 | Line 672 | public class PhaserTest extends JSR166Te
672       */
673      public void testAwaitAdvanceTieredPhaser() throws Exception {
674          final Phaser parent = new Phaser();
675 <        final List<Phaser> zeroPartyChildren = new ArrayList<Phaser>(3);
676 <        final List<Phaser> onePartyChildren = new ArrayList<Phaser>(3);
675 >        final List<Phaser> zeroPartyChildren = new ArrayList<>(3);
676 >        final List<Phaser> onePartyChildren = new ArrayList<>(3);
677          for (int i = 0; i < 3; i++) {
678              zeroPartyChildren.add(new Phaser(parent, 0));
679              onePartyChildren.add(new Phaser(parent, 1));
680          }
681 <        final List<Phaser> phasers = new ArrayList<Phaser>();
681 >        final List<Phaser> phasers = new ArrayList<>();
682          phasers.addAll(zeroPartyChildren);
683          phasers.addAll(onePartyChildren);
684          phasers.add(parent);
685          for (Phaser phaser : phasers) {
686              assertEquals(-42, phaser.awaitAdvance(-42));
687              assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42));
688 <            assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42, SMALL_DELAY_MS, MILLISECONDS));
688 >            assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42, MEDIUM_DELAY_MS, MILLISECONDS));
689          }
690  
691          for (Phaser child : onePartyChildren)
# Line 665 | Line 693 | public class PhaserTest extends JSR166Te
693          for (Phaser phaser : phasers) {
694              assertEquals(-42, phaser.awaitAdvance(-42));
695              assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42));
696 <            assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42, SMALL_DELAY_MS, MILLISECONDS));
696 >            assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42, MEDIUM_DELAY_MS, MILLISECONDS));
697              assertEquals(1, phaser.awaitAdvance(0));
698              assertEquals(1, phaser.awaitAdvanceInterruptibly(0));
699 <            assertEquals(1, phaser.awaitAdvanceInterruptibly(0, SMALL_DELAY_MS, MILLISECONDS));
699 >            assertEquals(1, phaser.awaitAdvanceInterruptibly(0, MEDIUM_DELAY_MS, MILLISECONDS));
700          }
701  
702          for (Phaser child : onePartyChildren)
# Line 676 | Line 704 | public class PhaserTest extends JSR166Te
704          for (Phaser phaser : phasers) {
705              assertEquals(-42, phaser.awaitAdvance(-42));
706              assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42));
707 <            assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42, SMALL_DELAY_MS, MILLISECONDS));
707 >            assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42, MEDIUM_DELAY_MS, MILLISECONDS));
708              assertEquals(2, phaser.awaitAdvance(0));
709              assertEquals(2, phaser.awaitAdvanceInterruptibly(0));
710 <            assertEquals(2, phaser.awaitAdvanceInterruptibly(0, SMALL_DELAY_MS, MILLISECONDS));
710 >            assertEquals(2, phaser.awaitAdvanceInterruptibly(0, MEDIUM_DELAY_MS, MILLISECONDS));
711              assertEquals(2, phaser.awaitAdvance(1));
712              assertEquals(2, phaser.awaitAdvanceInterruptibly(1));
713 <            assertEquals(2, phaser.awaitAdvanceInterruptibly(1, SMALL_DELAY_MS, MILLISECONDS));
713 >            assertEquals(2, phaser.awaitAdvanceInterruptibly(1, MEDIUM_DELAY_MS, MILLISECONDS));
714          }
715      }
716  
# Line 692 | Line 720 | public class PhaserTest extends JSR166Te
720      public void testAwaitAdvance6() {
721          final Phaser phaser = new Phaser(3);
722          final CountDownLatch pleaseForceTermination = new CountDownLatch(2);
723 <        final List<Thread> threads = new ArrayList<Thread>();
723 >        final List<Thread> threads = new ArrayList<>();
724          for (int i = 0; i < 2; i++) {
725              Runnable r = new CheckedRunnable() {
726                  public void realRun() {
# Line 720 | Line 748 | public class PhaserTest extends JSR166Te
748       * unarrived parties
749       */
750      public void testArriveAndAwaitAdvance1() {
751 +        Phaser phaser = new Phaser();
752          try {
724            Phaser phaser = new Phaser();
753              phaser.arriveAndAwaitAdvance();
754              shouldThrow();
755          } catch (IllegalStateException success) {}
# Line 736 | Line 764 | public class PhaserTest extends JSR166Te
764          final Phaser phaser = new Phaser(1);
765          final int THREADS = 3;
766          final CountDownLatch pleaseArrive = new CountDownLatch(THREADS);
767 <        final List<Thread> threads = new ArrayList<Thread>();
767 >        final List<Thread> threads = new ArrayList<>();
768          for (int i = 0; i < THREADS; i++)
769              threads.add(newStartedThread(new CheckedRunnable() {
770                  public void realRun() {
# Line 752 | Line 780 | public class PhaserTest extends JSR166Te
780          assertEquals(THREADS, phaser.getArrivedParties());
781          assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
782          for (Thread thread : threads)
783 <            waitForThreadToEnterWaitState(thread, SHORT_DELAY_MS);
783 >            waitForThreadToEnterWaitState(thread);
784          for (Thread thread : threads)
785              assertTrue(thread.isAlive());
786          assertState(phaser, 0, THREADS + 1, 1);

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines