ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/PhaserTest.java
(Generate patch)

Comparing jsr166/src/test/tck/PhaserTest.java (file contents):
Revision 1.18 by jsr166, Tue Oct 12 06:19:44 2010 UTC vs.
Revision 1.48 by jsr166, Sun Aug 11 22:29:27 2019 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include John Vint
6   */
7  
8 + import static java.util.concurrent.TimeUnit.MILLISECONDS;
9 +
10   import java.util.ArrayList;
11   import java.util.List;
12 + import java.util.concurrent.CountDownLatch;
13 + import java.util.concurrent.Phaser;
14 + import java.util.concurrent.TimeoutException;
15   import java.util.concurrent.atomic.AtomicInteger;
16 < import java.util.concurrent.atomic.AtomicBoolean;
12 < import java.util.concurrent.*;
13 < import static java.util.concurrent.TimeUnit.MILLISECONDS;
16 >
17   import junit.framework.Test;
18   import junit.framework.TestSuite;
19  
20   public class PhaserTest extends JSR166TestCase {
21  
22      public static void main(String[] args) {
23 <        junit.textui.TestRunner.run(suite());
23 >        main(suite(), args);
24      }
25  
26      public static Test suite() {
27          return new TestSuite(PhaserTest.class);
28      }
29  
30 +    private static final int maxParties = 65535;
31 +
32 +    /** Checks state of unterminated phaser. */
33 +    protected void assertState(Phaser phaser,
34 +                               int phase, int parties, int unarrived) {
35 +        assertEquals(phase, phaser.getPhase());
36 +        assertEquals(parties, phaser.getRegisteredParties());
37 +        assertEquals(unarrived, phaser.getUnarrivedParties());
38 +        assertEquals(parties - unarrived, phaser.getArrivedParties());
39 +        assertFalse(phaser.isTerminated());
40 +    }
41 +
42 +    /** Checks state of terminated phaser. */
43 +    protected void assertTerminated(Phaser phaser, int maxPhase, int parties) {
44 +        assertTrue(phaser.isTerminated());
45 +        int expectedPhase = maxPhase + Integer.MIN_VALUE;
46 +        assertEquals(expectedPhase, phaser.getPhase());
47 +        assertEquals(parties, phaser.getRegisteredParties());
48 +        assertEquals(expectedPhase, phaser.register());
49 +        assertEquals(expectedPhase, phaser.arrive());
50 +        assertEquals(expectedPhase, phaser.arriveAndDeregister());
51 +    }
52 +
53 +    protected void assertTerminated(Phaser phaser, int maxPhase) {
54 +        assertTerminated(phaser, maxPhase, 0);
55 +    }
56 +
57      /**
58       * Empty constructor builds a new Phaser with no parent, no registered
59       * parties and initial phase number of 0
60       */
61 <    public void testConstructor1() {
61 >    public void testConstructorDefaultValues() {
62          Phaser phaser = new Phaser();
63          assertNull(phaser.getParent());
64 +        assertEquals(0, phaser.getRegisteredParties());
65          assertEquals(0, phaser.getArrivedParties());
66 +        assertEquals(0, phaser.getUnarrivedParties());
67          assertEquals(0, phaser.getPhase());
68      }
69  
70      /**
71 <     * A negative party number for the constructor throws illegal argument
72 <     * exception
71 >     * Constructing with a negative number of parties throws
72 >     * IllegalArgumentException
73       */
74 <    public void testConstructor2() {
74 >    public void testConstructorNegativeParties() {
75          try {
76              new Phaser(-1);
77              shouldThrow();
# Line 47 | Line 79 | public class PhaserTest extends JSR166Te
79      }
80  
81      /**
82 <     * The parent being input into the constructor should equal the original
83 <     * parent when being returned
82 >     * Constructing with a negative number of parties throws
83 >     * IllegalArgumentException
84       */
85 <    public void testConstructor3() {
86 <        Phaser parent = new Phaser();
87 <        assertEquals(parent, new Phaser(parent).getParent());
85 >    public void testConstructorNegativeParties2() {
86 >        try {
87 >            new Phaser(new Phaser(), -1);
88 >            shouldThrow();
89 >        } catch (IllegalArgumentException success) {}
90      }
91  
92      /**
93 <     * A negative party number for the constructor throws illegal argument
94 <     * exception
93 >     * Constructing with a number of parties > 65535 throws
94 >     * IllegalArgumentException
95       */
96 <    public void testConstructor4() {
96 >    public void testConstructorPartiesExceedsLimit() {
97 >        new Phaser(maxParties);
98          try {
99 <            new Phaser(new Phaser(), -1);
99 >            new Phaser(maxParties + 1);
100 >            shouldThrow();
101 >        } catch (IllegalArgumentException success) {}
102 >
103 >        new Phaser(new Phaser(), maxParties);
104 >        try {
105 >            new Phaser(new Phaser(), maxParties + 1);
106              shouldThrow();
107          } catch (IllegalArgumentException success) {}
108      }
109  
110      /**
111 +     * The parent provided to the constructor should be returned from
112 +     * a later call to getParent
113 +     */
114 +    public void testConstructor3() {
115 +        Phaser parent = new Phaser();
116 +        assertSame(parent, new Phaser(parent).getParent());
117 +        assertNull(new Phaser(null).getParent());
118 +    }
119 +
120 +    /**
121       * The parent being input into the parameter should equal the original
122       * parent when being returned
123       */
124      public void testConstructor5() {
125          Phaser parent = new Phaser();
126 <        assertEquals(parent, new Phaser(parent, 0).getParent());
126 >        assertSame(parent, new Phaser(parent, 0).getParent());
127 >        assertNull(new Phaser(null, 0).getParent());
128      }
129  
130      /**
131 <     * register() will increment the number of unarrived parties by one and not
132 <     * affect its arrived parties
131 >     * register() will increment the number of unarrived parties by
132 >     * one and not affect its arrived parties
133       */
134      public void testRegister1() {
135          Phaser phaser = new Phaser();
136 <        assertEquals(0, phaser.getUnarrivedParties());
137 <        phaser.register();
138 <        assertEquals(1, phaser.getUnarrivedParties());
87 <        assertEquals(0, phaser.getArrivedParties());
136 >        assertState(phaser, 0, 0, 0);
137 >        assertEquals(0, phaser.register());
138 >        assertState(phaser, 0, 1, 1);
139      }
140  
141      /**
# Line 92 | Line 143 | public class PhaserTest extends JSR166Te
143       */
144      public void testRegister2() {
145          Phaser phaser = new Phaser(0);
146 <        int expectedUnnarivedParties = (1 << 16) - 1;
147 <        for (int i = 0; i < expectedUnnarivedParties; i++) {
148 <            phaser.register();
149 <            assertEquals(i + 1, phaser.getUnarrivedParties());
146 >        assertState(phaser, 0, 0, 0);
147 >        assertEquals(0, phaser.bulkRegister(maxParties - 10));
148 >        assertState(phaser, 0, maxParties - 10, maxParties - 10);
149 >        for (int i = 0; i < 10; i++) {
150 >            assertState(phaser, 0, maxParties - 10 + i, maxParties - 10 + i);
151 >            assertEquals(0, phaser.register());
152          }
153 +        assertState(phaser, 0, maxParties, maxParties);
154          try {
155              phaser.register();
156              shouldThrow();
157          } catch (IllegalStateException success) {}
158 +
159 +        try {
160 +            phaser.bulkRegister(Integer.MAX_VALUE);
161 +            shouldThrow();
162 +        } catch (IllegalStateException success) {}
163 +
164 +        assertEquals(0, phaser.bulkRegister(0));
165 +        assertState(phaser, 0, maxParties, maxParties);
166      }
167  
168      /**
169 <     * register() correctly returns the current barrier phase number when
170 <     * invoked
169 >     * register() correctly returns the current barrier phase number
170 >     * when invoked
171       */
172      public void testRegister3() {
173          Phaser phaser = new Phaser();
174          assertEquals(0, phaser.register());
175 <        phaser.arrive();
175 >        assertEquals(0, phaser.arrive());
176          assertEquals(1, phaser.register());
177 +        assertState(phaser, 1, 2, 2);
178      }
179  
180      /**
181 <     * register causes the next arrive to not increment the phase rather retain
182 <     * the phase number
181 >     * register causes the next arrive to not increment the phase
182 >     * rather retain the phase number
183       */
184      public void testRegister4() {
185          Phaser phaser = new Phaser(1);
186 <        phaser.arrive();
187 <        int expectedPhase = phaser.register();
188 <        phaser.arrive();
189 <        assertEquals(expectedPhase, phaser.getPhase());
186 >        assertEquals(0, phaser.arrive());
187 >        assertEquals(1, phaser.register());
188 >        assertEquals(1, phaser.arrive());
189 >        assertState(phaser, 1, 2, 1);
190      }
191  
192 <    public void testRegister5() {
193 <        Phaser phaser = new Phaser();
194 <        phaser.register();
195 <        assertEquals(1, phaser.getUnarrivedParties());
192 >    /**
193 >     * register on a subphaser that is currently empty succeeds, even
194 >     * in the presence of another non-empty subphaser
195 >     */
196 >    public void testRegisterEmptySubPhaser() {
197 >        Phaser root = new Phaser();
198 >        Phaser child1 = new Phaser(root, 1);
199 >        Phaser child2 = new Phaser(root, 0);
200 >        assertEquals(0, child2.register());
201 >        assertState(root, 0, 2, 2);
202 >        assertState(child1, 0, 1, 1);
203 >        assertState(child2, 0, 1, 1);
204 >        assertEquals(0, child2.arriveAndDeregister());
205 >        assertState(root, 0, 1, 1);
206 >        assertState(child1, 0, 1, 1);
207 >        assertState(child2, 0, 0, 0);
208 >        assertEquals(0, child2.register());
209 >        assertEquals(0, child2.arriveAndDeregister());
210 >        assertState(root, 0, 1, 1);
211 >        assertState(child1, 0, 1, 1);
212 >        assertState(child2, 0, 0, 0);
213 >        assertEquals(0, child1.arriveAndDeregister());
214 >        assertTerminated(root, 1);
215 >        assertTerminated(child1, 1);
216 >        assertTerminated(child2, 1);
217      }
218  
219      /**
# Line 144 | Line 228 | public class PhaserTest extends JSR166Te
228      }
229  
230      /**
231 <     * bulkRegister should correctly record the number of unarrived parties with
232 <     * the number of parties being registered
231 >     * bulkRegister should correctly record the number of unarrived
232 >     * parties with the number of parties being registered
233       */
234      public void testBulkRegister2() {
235          Phaser phaser = new Phaser();
236 <        phaser.bulkRegister(20);
237 <        assertEquals(20, phaser.getUnarrivedParties());
236 >        assertEquals(0, phaser.bulkRegister(0));
237 >        assertState(phaser, 0, 0, 0);
238 >        assertEquals(0, phaser.bulkRegister(20));
239 >        assertState(phaser, 0, 20, 20);
240      }
241  
242      /**
# Line 158 | Line 244 | public class PhaserTest extends JSR166Te
244       * throws IllegalStateException.
245       */
246      public void testBulkRegister3() {
247 +        assertEquals(0, new Phaser().bulkRegister((1 << 16) - 1));
248 +
249          try {
250              new Phaser().bulkRegister(1 << 16);
251              shouldThrow();
252          } catch (IllegalStateException success) {}
253 +
254 +        try {
255 +            new Phaser(2).bulkRegister((1 << 16) - 2);
256 +            shouldThrow();
257 +        } catch (IllegalStateException success) {}
258      }
259  
260      /**
# Line 178 | Line 271 | public class PhaserTest extends JSR166Te
271      }
272  
273      /**
274 <     * Arrive() on a registered phaser increments phase.
274 >     * arrive() on a registered phaser increments phase.
275       */
276      public void testArrive1() {
277          Phaser phaser = new Phaser(1);
278 <        phaser.arrive();
279 <        assertEquals(1, phaser.getPhase());
278 >        assertState(phaser, 0, 1, 1);
279 >        assertEquals(0, phaser.arrive());
280 >        assertState(phaser, 1, 1, 1);
281      }
282  
283      /**
284       * arriveAndDeregister does not wait for others to arrive at barrier
285       */
286 <    public void testArrive2() throws InterruptedException {
286 >    public void testArriveAndDeregister() {
287          final Phaser phaser = new Phaser(1);
288 <        phaser.register();
289 <        List<Thread> threads = new ArrayList<Thread>();
290 <        for (int i = 0; i < 10; i++)
291 <            phaser.register();
288 >        for (int i = 0; i < 10; i++) {
289 >            assertState(phaser, 0, 1, 1);
290 >            assertEquals(0, phaser.register());
291 >            assertState(phaser, 0, 2, 2);
292 >            assertEquals(0, phaser.arriveAndDeregister());
293 >            assertState(phaser, 0, 1, 1);
294 >        }
295 >        assertEquals(0, phaser.arriveAndDeregister());
296 >        assertTerminated(phaser, 1);
297 >    }
298 >
299 >    /**
300 >     * arriveAndDeregister does not wait for others to arrive at barrier
301 >     */
302 >    public void testArrive2() {
303 >        final Phaser phaser = new Phaser();
304 >        assertEquals(0, phaser.register());
305 >        List<Thread> threads = new ArrayList<>();
306 >        for (int i = 0; i < 10; i++) {
307 >            assertEquals(0, phaser.register());
308              threads.add(newStartedThread(new CheckedRunnable() {
309 <                public void realRun() throws InterruptedException {
310 <                    Thread.sleep(SMALL_DELAY_MS);
201 <                    phaser.arriveAndDeregister();
309 >                public void realRun() {
310 >                    assertEquals(0, phaser.arriveAndDeregister());
311                  }}));
312 +        }
313  
204        phaser.arrive();
205        assertTrue(threads.get(0).isAlive());
206        assertFalse(phaser.isTerminated());
314          for (Thread thread : threads)
315 <            thread.join();
315 >            awaitTermination(thread);
316 >        assertState(phaser, 0, 1, 1);
317 >        assertEquals(0, phaser.arrive());
318 >        assertState(phaser, 1, 1, 1);
319      }
320  
321      /**
# Line 214 | Line 324 | public class PhaserTest extends JSR166Te
324      public void testArrive3() {
325          Phaser phaser = new Phaser(1);
326          phaser.forceTermination();
327 +        assertTerminated(phaser, 0, 1);
328 +        assertEquals(0, phaser.getPhase() + Integer.MIN_VALUE);
329          assertTrue(phaser.arrive() < 0);
330 +        assertTrue(phaser.register() < 0);
331 +        assertTrue(phaser.arriveAndDeregister() < 0);
332 +        assertTrue(phaser.awaitAdvance(1) < 0);
333 +        assertTrue(phaser.getPhase() < 0);
334      }
335  
336      /**
# Line 222 | Line 338 | public class PhaserTest extends JSR166Te
338       * registered or unarrived parties would become negative
339       */
340      public void testArriveAndDeregister1() {
341 +        Phaser phaser = new Phaser();
342          try {
226            Phaser phaser = new Phaser();
343              phaser.arriveAndDeregister();
344              shouldThrow();
345          } catch (IllegalStateException success) {}
346      }
347  
348      /**
349 <     * arriveAndDeregister deregisters reduces the number of arrived parties
349 >     * arriveAndDeregister reduces the number of arrived parties
350       */
351 <    public void testArriveAndDergeister2() {
351 >    public void testArriveAndDeregister2() {
352          final Phaser phaser = new Phaser(1);
353 <        phaser.register();
354 <        phaser.arrive();
355 <        int p = phaser.getArrivedParties();
356 <        assertEquals(1, p);
357 <        phaser.arriveAndDeregister();
242 <        assertTrue(phaser.getArrivedParties() < p);
353 >        assertEquals(0, phaser.register());
354 >        assertEquals(0, phaser.arrive());
355 >        assertState(phaser, 0, 2, 1);
356 >        assertEquals(0, phaser.arriveAndDeregister());
357 >        assertState(phaser, 1, 1, 1);
358      }
359  
360      /**
361 <     * arriveAndDeregister arrives to the barrier on a phaser with a parent and
361 >     * arriveAndDeregister arrives at the barrier on a phaser with a parent and
362       * when a deregistration occurs and causes the phaser to have zero parties
363       * its parent will be deregistered as well
364       */
365 <    public void testArriveAndDeregsiter3() {
365 >    public void testArriveAndDeregister3() {
366          Phaser parent = new Phaser();
367 <        Phaser root = new Phaser(parent);
368 <        root.register();
369 <        assertTrue(parent.getUnarrivedParties() > 0);
370 <        assertTrue(root.getUnarrivedParties() > 0);
371 <        root.arriveAndDeregister();
372 <        assertEquals(0, parent.getUnarrivedParties());
373 <        assertEquals(0, root.getUnarrivedParties());
374 <        assertTrue(root.isTerminated() && parent.isTerminated());
367 >        Phaser child = new Phaser(parent);
368 >        assertState(child, 0, 0, 0);
369 >        assertState(parent, 0, 0, 0);
370 >        assertEquals(0, child.register());
371 >        assertState(child, 0, 1, 1);
372 >        assertState(parent, 0, 1, 1);
373 >        assertEquals(0, child.arriveAndDeregister());
374 >        assertTerminated(child, 1);
375 >        assertTerminated(parent, 1);
376      }
377  
378      /**
379       * arriveAndDeregister deregisters one party from its parent when
380 <     * the number of parties of root is zero after deregistration
380 >     * the number of parties of child is zero after deregistration
381       */
382 <    public void testArriveAndDeregsiter4() {
382 >    public void testArriveAndDeregister4() {
383          Phaser parent = new Phaser();
384 <        Phaser root = new Phaser(parent);
385 <        parent.register();
386 <        root.register();
387 <        int parentParties = parent.getUnarrivedParties();
388 <        root.arriveAndDeregister();
389 <        assertEquals(parentParties - 1, parent.getUnarrivedParties());
384 >        Phaser child = new Phaser(parent);
385 >        assertEquals(0, parent.register());
386 >        assertEquals(0, child.register());
387 >        assertState(child, 0, 1, 1);
388 >        assertState(parent, 0, 2, 2);
389 >        assertEquals(0, child.arriveAndDeregister());
390 >        assertState(child, 0, 0, 0);
391 >        assertState(parent, 0, 1, 1);
392      }
393  
394      /**
# Line 278 | Line 396 | public class PhaserTest extends JSR166Te
396       * the number of parties of root is nonzero after deregistration.
397       */
398      public void testArriveAndDeregister5() {
399 <        Phaser parent = new Phaser();
399 >        Phaser root = new Phaser();
400 >        Phaser parent = new Phaser(root);
401          Phaser child = new Phaser(parent);
402 <        Phaser root = new Phaser(child);
403 <        assertTrue(parent.getUnarrivedParties() > 0);
404 <        assertTrue(child.getUnarrivedParties() > 0);
405 <        root.register();
406 <        root.arriveAndDeregister();
407 <        assertEquals(0, parent.getUnarrivedParties());
408 <        assertEquals(0, child.getUnarrivedParties());
409 <        assertTrue(root.isTerminated());
402 >        assertState(root, 0, 0, 0);
403 >        assertState(parent, 0, 0, 0);
404 >        assertState(child, 0, 0, 0);
405 >        assertEquals(0, child.register());
406 >        assertState(root, 0, 1, 1);
407 >        assertState(parent, 0, 1, 1);
408 >        assertState(child, 0, 1, 1);
409 >        assertEquals(0, child.arriveAndDeregister());
410 >        assertTerminated(child, 1);
411 >        assertTerminated(parent, 1);
412 >        assertTerminated(root, 1);
413      }
414  
415      /**
416       * arriveAndDeregister returns the phase in which it leaves the
417       * phaser in after deregistration
418       */
419 <    public void testArriveAndDeregister6() throws InterruptedException {
419 >    public void testArriveAndDeregister6() {
420          final Phaser phaser = new Phaser(2);
421          Thread t = newStartedThread(new CheckedRunnable() {
422              public void realRun() {
423 <                sleepTillInterrupted(SHORT_DELAY_MS);
302 <                phaser.arrive();
423 >                assertEquals(0, phaser.arrive());
424              }});
425 <        phaser.arriveAndAwaitAdvance();
426 <        int phase = phaser.arriveAndDeregister();
427 <        assertEquals(phase, phaser.getPhase());
428 <        t.join();
425 >        assertEquals(1, phaser.arriveAndAwaitAdvance());
426 >        assertState(phaser, 1, 2, 2);
427 >        assertEquals(1, phaser.arriveAndDeregister());
428 >        assertState(phaser, 1, 1, 1);
429 >        assertEquals(1, phaser.arriveAndDeregister());
430 >        assertTerminated(phaser, 2);
431 >        awaitTermination(t);
432      }
433  
434      /**
# Line 312 | Line 436 | public class PhaserTest extends JSR166Te
436       */
437      public void testAwaitAdvance1() {
438          final Phaser phaser = new Phaser(1);
439 <        phaser.awaitAdvance(phaser.arrive());
439 >        assertEquals(0, phaser.arrive());
440 >        assertEquals(1, phaser.awaitAdvance(0));
441      }
442  
443      /**
# Line 321 | Line 446 | public class PhaserTest extends JSR166Te
446       */
447      public void testAwaitAdvance2() {
448          Phaser phaser = new Phaser();
449 <        phaser.awaitAdvance(-1);
449 >        assertTrue(phaser.awaitAdvance(-1) < 0);
450 >        assertState(phaser, 0, 0, 0);
451      }
452  
453      /**
454 <     * awaitAdvance while waiting does not abort on interrupt.
454 >     * awaitAdvanceInterruptibly blocks interruptibly
455       */
456 <    public void testAwaitAdvance3() throws InterruptedException {
456 >    public void testAwaitAdvanceInterruptibly_interruptible() throws InterruptedException {
457 >        final Phaser phaser = new Phaser(1);
458 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(2);
459 >
460 >        Thread t1 = newStartedThread(new CheckedRunnable() {
461 >            public void realRun() {
462 >                Thread.currentThread().interrupt();
463 >                try {
464 >                    phaser.awaitAdvanceInterruptibly(0);
465 >                    shouldThrow();
466 >                } catch (InterruptedException success) {}
467 >                assertFalse(Thread.interrupted());
468 >
469 >                pleaseInterrupt.countDown();
470 >                try {
471 >                    phaser.awaitAdvanceInterruptibly(0);
472 >                    shouldThrow();
473 >                } catch (InterruptedException success) {}
474 >                assertFalse(Thread.interrupted());
475 >            }});
476 >
477 >        Thread t2 = newStartedThread(new CheckedRunnable() {
478 >            public void realRun() throws TimeoutException {
479 >                long startTime = System.nanoTime();
480 >
481 >                Thread.currentThread().interrupt();
482 >                try {
483 >                    phaser.awaitAdvanceInterruptibly(0, randomTimeout(), randomTimeUnit());
484 >                    shouldThrow();
485 >                } catch (InterruptedException success) {}
486 >                assertFalse(Thread.interrupted());
487 >
488 >                pleaseInterrupt.countDown();
489 >                try {
490 >                    phaser.awaitAdvanceInterruptibly(0, LONG_DELAY_MS, MILLISECONDS);
491 >                    shouldThrow();
492 >                } catch (InterruptedException success) {}
493 >                assertFalse(Thread.interrupted());
494 >
495 >                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
496 >            }});
497 >
498 >        await(pleaseInterrupt);
499 >        assertState(phaser, 0, 1, 1);
500 >        assertThreadBlocks(t1, Thread.State.WAITING);
501 >        assertThreadBlocks(t2, Thread.State.TIMED_WAITING);
502 >        t1.interrupt();
503 >        t2.interrupt();
504 >        awaitTermination(t1);
505 >        awaitTermination(t2);
506 >        assertState(phaser, 0, 1, 1);
507 >        assertEquals(0, phaser.arrive());
508 >        assertState(phaser, 1, 1, 1);
509 >    }
510 >
511 >    /**
512 >     * awaitAdvance continues waiting if interrupted before waiting
513 >     */
514 >    public void testAwaitAdvanceAfterInterrupt() {
515          final Phaser phaser = new Phaser();
516 <        phaser.register();
517 <        final CountDownLatch threadStarted = new CountDownLatch(1);
516 >        assertEquals(0, phaser.register());
517 >        final CountDownLatch pleaseArrive = new CountDownLatch(1);
518  
519          Thread t = newStartedThread(new CheckedRunnable() {
520 <            public void realRun() throws InterruptedException {
521 <                phaser.register();
522 <                threadStarted.countDown();
523 <                phaser.awaitAdvance(phaser.arrive());
520 >            public void realRun() {
521 >                Thread.currentThread().interrupt();
522 >                assertEquals(0, phaser.register());
523 >                assertEquals(0, phaser.arrive());
524 >                pleaseArrive.countDown();
525                  assertTrue(Thread.currentThread().isInterrupted());
526 +                assertEquals(1, phaser.awaitAdvance(0));
527 +                assertTrue(Thread.interrupted());
528 +            }});
529 +
530 +        await(pleaseArrive);
531 +        assertThreadBlocks(t, Thread.State.WAITING);
532 +        assertEquals(0, phaser.arrive());
533 +        awaitTermination(t);
534 +
535 +        Thread.currentThread().interrupt();
536 +        assertEquals(1, phaser.awaitAdvance(0));
537 +        assertTrue(Thread.interrupted());
538 +    }
539 +
540 +    /**
541 +     *  awaitAdvance continues waiting if interrupted while waiting
542 +     */
543 +    public void testAwaitAdvanceBeforeInterrupt() {
544 +        final Phaser phaser = new Phaser();
545 +        assertEquals(0, phaser.register());
546 +        final CountDownLatch pleaseArrive = new CountDownLatch(1);
547 +
548 +        Thread t = newStartedThread(new CheckedRunnable() {
549 +            public void realRun() {
550 +                assertEquals(0, phaser.register());
551 +                assertEquals(0, phaser.arrive());
552 +                assertFalse(Thread.currentThread().isInterrupted());
553 +                pleaseArrive.countDown();
554 +                assertEquals(1, phaser.awaitAdvance(0));
555 +                assertTrue(Thread.interrupted());
556 +            }});
557 +
558 +        await(pleaseArrive);
559 +        assertThreadBlocks(t, Thread.State.WAITING);
560 +        t.interrupt();
561 +        assertEquals(0, phaser.arrive());
562 +        awaitTermination(t);
563 +
564 +        Thread.currentThread().interrupt();
565 +        assertEquals(1, phaser.awaitAdvance(0));
566 +        assertTrue(Thread.interrupted());
567 +    }
568 +
569 +    /**
570 +     * arriveAndAwaitAdvance continues waiting if interrupted before waiting
571 +     */
572 +    public void testArriveAndAwaitAdvanceAfterInterrupt() {
573 +        final Phaser phaser = new Phaser();
574 +        assertEquals(0, phaser.register());
575 +        final CountDownLatch pleaseArrive = new CountDownLatch(1);
576 +
577 +        Thread t = newStartedThread(new CheckedRunnable() {
578 +            public void realRun() {
579 +                Thread.currentThread().interrupt();
580 +                assertEquals(0, phaser.register());
581 +                pleaseArrive.countDown();
582 +                assertTrue(Thread.currentThread().isInterrupted());
583 +                assertEquals(1, phaser.arriveAndAwaitAdvance());
584 +                assertTrue(Thread.interrupted());
585 +            }});
586 +
587 +        await(pleaseArrive);
588 +        assertThreadBlocks(t, Thread.State.WAITING);
589 +        Thread.currentThread().interrupt();
590 +        assertEquals(1, phaser.arriveAndAwaitAdvance());
591 +        assertTrue(Thread.interrupted());
592 +        awaitTermination(t);
593 +    }
594 +
595 +    /**
596 +     * arriveAndAwaitAdvance continues waiting if interrupted while waiting
597 +     */
598 +    public void testArriveAndAwaitAdvanceBeforeInterrupt() {
599 +        final Phaser phaser = new Phaser();
600 +        assertEquals(0, phaser.register());
601 +        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
602 +
603 +        Thread t = newStartedThread(new CheckedRunnable() {
604 +            public void realRun() {
605 +                assertEquals(0, phaser.register());
606 +                assertFalse(Thread.currentThread().isInterrupted());
607 +                pleaseInterrupt.countDown();
608 +                assertEquals(1, phaser.arriveAndAwaitAdvance());
609 +                assertTrue(Thread.interrupted());
610              }});
611 <        assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
611 >
612 >        await(pleaseInterrupt);
613 >        assertThreadBlocks(t, Thread.State.WAITING);
614          t.interrupt();
615 <        phaser.arrive();
616 <        awaitTermination(t, SMALL_DELAY_MS);
615 >        Thread.currentThread().interrupt();
616 >        assertEquals(1, phaser.arriveAndAwaitAdvance());
617 >        assertTrue(Thread.interrupted());
618 >        awaitTermination(t);
619      }
620  
621      /**
622       * awaitAdvance atomically waits for all parties within the same phase to
623       * complete before continuing
624       */
625 <    public void testAwaitAdvance4() throws InterruptedException {
625 >    public void testAwaitAdvance4() {
626          final Phaser phaser = new Phaser(4);
627 <        final AtomicInteger phaseCount = new AtomicInteger(0);
628 <        List<Thread> threads = new ArrayList<Thread>();
629 <        for (int i = 0; i < 4; i++) {
627 >        final AtomicInteger count = new AtomicInteger(0);
628 >        List<Thread> threads = new ArrayList<>();
629 >        for (int i = 0; i < 4; i++)
630              threads.add(newStartedThread(new CheckedRunnable() {
631                  public void realRun() {
632 <                    int phase = phaser.arrive();
633 <                    phaseCount.incrementAndGet();
634 <                    sleepTillInterrupted(SMALL_DELAY_MS);
635 <                    phaser.awaitAdvance(phase);
636 <                    assertEquals(phaseCount.get(), 4);
637 <                }}));
638 <        }
632 >                    for (int k = 0; k < 3; k++) {
633 >                        assertEquals(2 * k + 1, phaser.arriveAndAwaitAdvance());
634 >                        count.incrementAndGet();
635 >                        assertEquals(2 * k + 1, phaser.arrive());
636 >                        assertEquals(2 * k + 2, phaser.awaitAdvance(2 * k + 1));
637 >                        assertEquals(4 * (k + 1), count.get());
638 >                    }}}));
639 >
640          for (Thread thread : threads)
641 <            thread.join();
641 >            awaitTermination(thread);
642      }
643  
644      /**
645       * awaitAdvance returns the current phase
646       */
647 <    public void testAwaitAdvance5() throws InterruptedException {
647 >    public void testAwaitAdvance5() {
648          final Phaser phaser = new Phaser(1);
649 <        int phase = phaser.awaitAdvance(phaser.arrive());
650 <        assertEquals(phase, phaser.getPhase());
651 <        phaser.register();
652 <        List<Thread> threads = new ArrayList<Thread>();
649 >        assertEquals(1, phaser.awaitAdvance(phaser.arrive()));
650 >        assertEquals(1, phaser.getPhase());
651 >        assertEquals(1, phaser.register());
652 >        List<Thread> threads = new ArrayList<>();
653          for (int i = 0; i < 8; i++) {
654              final CountDownLatch latch = new CountDownLatch(1);
655              final boolean goesFirst = ((i & 1) == 0);
656              threads.add(newStartedThread(new CheckedRunnable() {
657 <                public void realRun() throws InterruptedException {
657 >                public void realRun() {
658                      if (goesFirst)
659                          latch.countDown();
660                      else
661 <                        assertTrue(latch.await(SMALL_DELAY_MS, MILLISECONDS));
661 >                        await(latch);
662                      phaser.arrive();
663                  }}));
664              if (goesFirst)
665 <                assertTrue(latch.await(SMALL_DELAY_MS, MILLISECONDS));
665 >                await(latch);
666              else
667                  latch.countDown();
668 <            phase = phaser.awaitAdvance(phaser.arrive());
669 <            assertEquals(phase, phaser.getPhase());
668 >            assertEquals(i + 2, phaser.awaitAdvance(phaser.arrive()));
669 >            assertEquals(i + 2, phaser.getPhase());
670          }
671          for (Thread thread : threads)
672 <            awaitTermination(thread, SMALL_DELAY_MS);
672 >            awaitTermination(thread);
673 >    }
674 >
675 >    /**
676 >     * awaitAdvance returns the current phase in child phasers
677 >     */
678 >    public void testAwaitAdvanceTieredPhaser() throws Exception {
679 >        final Phaser parent = new Phaser();
680 >        final List<Phaser> zeroPartyChildren = new ArrayList<>(3);
681 >        final List<Phaser> onePartyChildren = new ArrayList<>(3);
682 >        for (int i = 0; i < 3; i++) {
683 >            zeroPartyChildren.add(new Phaser(parent, 0));
684 >            onePartyChildren.add(new Phaser(parent, 1));
685 >        }
686 >        final List<Phaser> phasers = new ArrayList<>();
687 >        phasers.addAll(zeroPartyChildren);
688 >        phasers.addAll(onePartyChildren);
689 >        phasers.add(parent);
690 >        for (Phaser phaser : phasers) {
691 >            assertEquals(-42, phaser.awaitAdvance(-42));
692 >            assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42));
693 >            assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42, MEDIUM_DELAY_MS, MILLISECONDS));
694 >        }
695 >
696 >        for (Phaser child : onePartyChildren)
697 >            assertEquals(0, child.arrive());
698 >        for (Phaser phaser : phasers) {
699 >            assertEquals(-42, phaser.awaitAdvance(-42));
700 >            assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42));
701 >            assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42, MEDIUM_DELAY_MS, MILLISECONDS));
702 >            assertEquals(1, phaser.awaitAdvance(0));
703 >            assertEquals(1, phaser.awaitAdvanceInterruptibly(0));
704 >            assertEquals(1, phaser.awaitAdvanceInterruptibly(0, MEDIUM_DELAY_MS, MILLISECONDS));
705 >        }
706 >
707 >        for (Phaser child : onePartyChildren)
708 >            assertEquals(1, child.arrive());
709 >        for (Phaser phaser : phasers) {
710 >            assertEquals(-42, phaser.awaitAdvance(-42));
711 >            assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42));
712 >            assertEquals(-42, phaser.awaitAdvanceInterruptibly(-42, MEDIUM_DELAY_MS, MILLISECONDS));
713 >            assertEquals(2, phaser.awaitAdvance(0));
714 >            assertEquals(2, phaser.awaitAdvanceInterruptibly(0));
715 >            assertEquals(2, phaser.awaitAdvanceInterruptibly(0, MEDIUM_DELAY_MS, MILLISECONDS));
716 >            assertEquals(2, phaser.awaitAdvance(1));
717 >            assertEquals(2, phaser.awaitAdvanceInterruptibly(1));
718 >            assertEquals(2, phaser.awaitAdvanceInterruptibly(1, MEDIUM_DELAY_MS, MILLISECONDS));
719 >        }
720      }
721  
722      /**
723       * awaitAdvance returns when the phaser is externally terminated
724       */
725 <    public void testAwaitAdvance6() throws InterruptedException {
725 >    public void testAwaitAdvance6() {
726          final Phaser phaser = new Phaser(3);
727 <        final CountDownLatch threadsStarted = new CountDownLatch(2);
728 <        final List<Thread> threads = new ArrayList<Thread>();
727 >        final CountDownLatch pleaseForceTermination = new CountDownLatch(2);
728 >        final List<Thread> threads = new ArrayList<>();
729          for (int i = 0; i < 2; i++) {
730              Runnable r = new CheckedRunnable() {
731                  public void realRun() {
732 <                    int p1 = phaser.arrive();
733 <                    assertTrue(p1 >= 0);
734 <                    threadsStarted.countDown();
414 <                    int phase = phaser.awaitAdvance(p1);
415 <                    assertTrue(phase < 0);
732 >                    assertEquals(0, phaser.arrive());
733 >                    pleaseForceTermination.countDown();
734 >                    assertTrue(phaser.awaitAdvance(0) < 0);
735                      assertTrue(phaser.isTerminated());
736 +                    assertTrue(phaser.getPhase() < 0);
737 +                    assertEquals(0, phaser.getPhase() + Integer.MIN_VALUE);
738 +                    assertEquals(3, phaser.getRegisteredParties());
739                  }};
740              threads.add(newStartedThread(r));
741          }
742 <        threadsStarted.await();
742 >        await(pleaseForceTermination);
743          phaser.forceTermination();
744 +        assertTrue(phaser.isTerminated());
745 +        assertEquals(0, phaser.getPhase() + Integer.MIN_VALUE);
746          for (Thread thread : threads)
747 <            awaitTermination(thread, SMALL_DELAY_MS);
747 >            awaitTermination(thread);
748 >        assertEquals(3, phaser.getRegisteredParties());
749      }
750  
751      /**
# Line 428 | Line 753 | public class PhaserTest extends JSR166Te
753       * unarrived parties
754       */
755      public void testArriveAndAwaitAdvance1() {
756 +        Phaser phaser = new Phaser();
757          try {
432            Phaser phaser = new Phaser();
758              phaser.arriveAndAwaitAdvance();
759              shouldThrow();
760          } catch (IllegalStateException success) {}
761      }
762  
763      /**
439     * Interrupted arriveAndAwaitAdvance does not throw InterruptedException
440     */
441    public void testArriveAndAwaitAdvance2() throws InterruptedException {
442        final Phaser phaser = new Phaser(2);
443        final CountDownLatch threadStarted = new CountDownLatch(1);
444        final AtomicBoolean advanced = new AtomicBoolean(false);
445        final AtomicBoolean checkedInterruptStatus = new AtomicBoolean(false);
446        Thread t = newStartedThread(new CheckedRunnable() {
447            public void realRun() throws InterruptedException {
448                threadStarted.countDown();
449                phaser.arriveAndAwaitAdvance();
450                advanced.set(true);
451                assertTrue(Thread.currentThread().isInterrupted());
452                while (!checkedInterruptStatus.get())
453                    Thread.yield();
454            }});
455
456        assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
457        t.interrupt();
458        phaser.arrive();
459        while (!advanced.get())
460            Thread.yield();
461        assertTrue(t.isInterrupted());
462        checkedInterruptStatus.set(true);
463        awaitTermination(t, SMALL_DELAY_MS);
464    }
465
466    /**
764       * arriveAndAwaitAdvance waits for all threads to arrive, the
765       * number of arrived parties is the same number that is accounted
766       * for when the main thread awaitsAdvance
767       */
768 <    public void testArriveAndAwaitAdvance3() throws InterruptedException {
768 >    public void testArriveAndAwaitAdvance3() {
769          final Phaser phaser = new Phaser(1);
770 <        final List<Thread> threads = new ArrayList<Thread>();
771 <        for (int i = 0; i < 3; i++) {
770 >        final int THREADS = 3;
771 >        final CountDownLatch pleaseArrive = new CountDownLatch(THREADS);
772 >        final List<Thread> threads = new ArrayList<>();
773 >        for (int i = 0; i < THREADS; i++)
774              threads.add(newStartedThread(new CheckedRunnable() {
775 <                    public void realRun() throws InterruptedException {
776 <                        phaser.register();
777 <                        phaser.arriveAndAwaitAdvance();
778 <                    }}));
779 <        }
780 <        Thread.sleep(MEDIUM_DELAY_MS);
781 <        assertEquals(phaser.getArrivedParties(), 3);
775 >                public void realRun() {
776 >                    assertEquals(0, phaser.register());
777 >                    pleaseArrive.countDown();
778 >                    assertEquals(1, phaser.arriveAndAwaitAdvance());
779 >                }}));
780 >
781 >        await(pleaseArrive);
782 >        long startTime = System.nanoTime();
783 >        while (phaser.getArrivedParties() < THREADS)
784 >            Thread.yield();
785 >        assertEquals(THREADS, phaser.getArrivedParties());
786 >        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
787 >        for (Thread thread : threads)
788 >            assertThreadBlocks(thread, Thread.State.WAITING);
789 >        for (Thread thread : threads)
790 >            assertTrue(thread.isAlive());
791 >        assertState(phaser, 0, THREADS + 1, 1);
792          phaser.arriveAndAwaitAdvance();
793          for (Thread thread : threads)
794 <            thread.join();
794 >            awaitTermination(thread);
795 >        assertState(phaser, 1, THREADS + 1, THREADS + 1);
796      }
797  
798   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines