ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/PriorityBlockingQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/PriorityBlockingQueueTest.java (file contents):
Revision 1.13 by jsr166, Mon Nov 16 04:57:10 2009 UTC vs.
Revision 1.45 by jsr166, Mon May 30 22:43:20 2011 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include Andrew Wright, Jeffrey Hayes,
6   * Pat Fisher, Mike Judd.
7   */
8  
9   import junit.framework.*;
10 < import java.util.*;
11 < import java.util.concurrent.*;
10 > import java.util.Arrays;
11 > import java.util.ArrayList;
12 > import java.util.Collection;
13 > import java.util.Comparator;
14 > import java.util.Iterator;
15 > import java.util.NoSuchElementException;
16 > import java.util.concurrent.PriorityBlockingQueue;
17 > import java.util.concurrent.BlockingQueue;
18 > import java.util.concurrent.CountDownLatch;
19 > import java.util.concurrent.Executors;
20 > import java.util.concurrent.ExecutorService;
21 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
22   import java.io.*;
23  
24   public class PriorityBlockingQueueTest extends JSR166TestCase {
25 +
26 +    public static class Generic extends BlockingQueueTest {
27 +        protected BlockingQueue emptyCollection() {
28 +            return new PriorityBlockingQueue();
29 +        }
30 +    }
31 +
32 +    public static class InitialCapacity extends BlockingQueueTest {
33 +        protected BlockingQueue emptyCollection() {
34 +            return new PriorityBlockingQueue(20);
35 +        }
36 +    }
37 +
38      public static void main(String[] args) {
39 <        junit.textui.TestRunner.run (suite());
39 >        junit.textui.TestRunner.run(suite());
40      }
41 +
42      public static Test suite() {
43 <        return new TestSuite(PriorityBlockingQueueTest.class);
43 >        return newTestSuite(PriorityBlockingQueueTest.class,
44 >                            new Generic().testSuite(),
45 >                            new InitialCapacity().testSuite());
46      }
47  
48      private static final int NOCAP = Integer.MAX_VALUE;
# Line 24 | Line 50 | public class PriorityBlockingQueueTest e
50      /** Sample Comparator */
51      static class MyReverseComparator implements Comparator {
52          public int compare(Object x, Object y) {
53 <            int i = ((Integer)x).intValue();
28 <            int j = ((Integer)y).intValue();
29 <            if (i < j) return 1;
30 <            if (i > j) return -1;
31 <            return 0;
53 >            return ((Comparable)y).compareTo(x);
54          }
55      }
56  
# Line 36 | Line 58 | public class PriorityBlockingQueueTest e
58       * Create a queue of given size containing consecutive
59       * Integers 0 ... n.
60       */
61 <    private PriorityBlockingQueue populatedQueue(int n) {
62 <        PriorityBlockingQueue q = new PriorityBlockingQueue(n);
61 >    private PriorityBlockingQueue<Integer> populatedQueue(int n) {
62 >        PriorityBlockingQueue<Integer> q =
63 >            new PriorityBlockingQueue<Integer>(n);
64          assertTrue(q.isEmpty());
65 <        for (int i = n-1; i >= 0; i-=2)
66 <            assertTrue(q.offer(new Integer(i)));
67 <        for (int i = (n & 1); i < n; i+=2)
68 <            assertTrue(q.offer(new Integer(i)));
65 >        for (int i = n-1; i >= 0; i-=2)
66 >            assertTrue(q.offer(new Integer(i)));
67 >        for (int i = (n & 1); i < n; i+=2)
68 >            assertTrue(q.offer(new Integer(i)));
69          assertFalse(q.isEmpty());
70          assertEquals(NOCAP, q.remainingCapacity());
71 <        assertEquals(n, q.size());
71 >        assertEquals(n, q.size());
72          return q;
73      }
74  
# Line 57 | Line 80 | public class PriorityBlockingQueueTest e
80      }
81  
82      /**
83 <     * Constructor throws IAE if  capacity argument nonpositive
83 >     * Constructor throws IAE if capacity argument nonpositive
84       */
85      public void testConstructor2() {
86          try {
87 <            PriorityBlockingQueue q = new PriorityBlockingQueue(0);
87 >            new PriorityBlockingQueue(0);
88              shouldThrow();
89 <        }
67 <        catch (IllegalArgumentException success) {}
89 >        } catch (IllegalArgumentException success) {}
90      }
91  
92      /**
# Line 72 | Line 94 | public class PriorityBlockingQueueTest e
94       */
95      public void testConstructor3() {
96          try {
97 <            PriorityBlockingQueue q = new PriorityBlockingQueue(null);
97 >            new PriorityBlockingQueue(null);
98              shouldThrow();
99 <        }
78 <        catch (NullPointerException success) {}
99 >        } catch (NullPointerException success) {}
100      }
101  
102      /**
103       * Initializing from Collection of null elements throws NPE
104       */
105      public void testConstructor4() {
106 +        Collection<Integer> elements = Arrays.asList(new Integer[SIZE]);
107          try {
108 <            Integer[] ints = new Integer[SIZE];
87 <            PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
108 >            new PriorityBlockingQueue(elements);
109              shouldThrow();
110 <        }
90 <        catch (NullPointerException success) {}
110 >        } catch (NullPointerException success) {}
111      }
112  
113      /**
114       * Initializing from Collection with some null elements throws NPE
115       */
116      public void testConstructor5() {
117 +        Integer[] ints = new Integer[SIZE];
118 +        for (int i = 0; i < SIZE-1; ++i)
119 +            ints[i] = i;
120 +        Collection<Integer> elements = Arrays.asList(ints);
121          try {
122 <            Integer[] ints = new Integer[SIZE];
99 <            for (int i = 0; i < SIZE-1; ++i)
100 <                ints[i] = new Integer(i);
101 <            PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
122 >            new PriorityBlockingQueue(elements);
123              shouldThrow();
124 <        }
104 <        catch (NullPointerException success) {}
124 >        } catch (NullPointerException success) {}
125      }
126  
127      /**
128       * Queue contains all elements of collection used to initialize
129       */
130      public void testConstructor6() {
131 <        try {
132 <            Integer[] ints = new Integer[SIZE];
133 <            for (int i = 0; i < SIZE; ++i)
134 <                ints[i] = new Integer(i);
135 <            PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
136 <            for (int i = 0; i < SIZE; ++i)
117 <                assertEquals(ints[i], q.poll());
118 <        }
119 <        finally {}
131 >        Integer[] ints = new Integer[SIZE];
132 >        for (int i = 0; i < SIZE; ++i)
133 >            ints[i] = i;
134 >        PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
135 >        for (int i = 0; i < SIZE; ++i)
136 >            assertEquals(ints[i], q.poll());
137      }
138  
139      /**
140       * The comparator used in constructor is used
141       */
142      public void testConstructor7() {
143 <        try {
144 <            MyReverseComparator cmp = new MyReverseComparator();
145 <            PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE, cmp);
146 <            assertEquals(cmp, q.comparator());
147 <            Integer[] ints = new Integer[SIZE];
148 <            for (int i = 0; i < SIZE; ++i)
149 <                ints[i] = new Integer(i);
150 <            q.addAll(Arrays.asList(ints));
151 <            for (int i = SIZE-1; i >= 0; --i)
135 <                assertEquals(ints[i], q.poll());
136 <        }
137 <        finally {}
143 >        MyReverseComparator cmp = new MyReverseComparator();
144 >        PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE, cmp);
145 >        assertEquals(cmp, q.comparator());
146 >        Integer[] ints = new Integer[SIZE];
147 >        for (int i = 0; i < SIZE; ++i)
148 >            ints[i] = new Integer(i);
149 >        q.addAll(Arrays.asList(ints));
150 >        for (int i = SIZE-1; i >= 0; --i)
151 >            assertEquals(ints[i], q.poll());
152      }
153  
154      /**
# Line 171 | Line 185 | public class PriorityBlockingQueueTest e
185      }
186  
187      /**
174     * offer(null) throws NPE
175     */
176    public void testOfferNull() {
177        try {
178            PriorityBlockingQueue q = new PriorityBlockingQueue(1);
179            q.offer(null);
180            shouldThrow();
181        } catch (NullPointerException success) { }
182    }
183
184    /**
185     * add(null) throws NPE
186     */
187    public void testAddNull() {
188        try {
189            PriorityBlockingQueue q = new PriorityBlockingQueue(1);
190            q.add(null);
191            shouldThrow();
192        } catch (NullPointerException success) { }
193    }
194
195    /**
188       * Offer of comparable element succeeds
189       */
190      public void testOffer() {
# Line 211 | Line 203 | public class PriorityBlockingQueueTest e
203              q.offer(new Object());
204              q.offer(new Object());
205              shouldThrow();
206 <        }
215 <        catch (ClassCastException success) {}
206 >        } catch (ClassCastException success) {}
207      }
208  
209      /**
# Line 227 | Line 218 | public class PriorityBlockingQueueTest e
218      }
219  
220      /**
230     * addAll(null) throws NPE
231     */
232    public void testAddAll1() {
233        try {
234            PriorityBlockingQueue q = new PriorityBlockingQueue(1);
235            q.addAll(null);
236            shouldThrow();
237        }
238        catch (NullPointerException success) {}
239    }
240
241    /**
221       * addAll(this) throws IAE
222       */
223      public void testAddAllSelf() {
# Line 246 | Line 225 | public class PriorityBlockingQueueTest e
225              PriorityBlockingQueue q = populatedQueue(SIZE);
226              q.addAll(q);
227              shouldThrow();
228 <        }
250 <        catch (IllegalArgumentException success) {}
228 >        } catch (IllegalArgumentException success) {}
229      }
230  
231      /**
254     * addAll of a collection with null elements throws NPE
255     */
256    public void testAddAll2() {
257        try {
258            PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
259            Integer[] ints = new Integer[SIZE];
260            q.addAll(Arrays.asList(ints));
261            shouldThrow();
262        }
263        catch (NullPointerException success) {}
264    }
265    /**
232       * addAll of a collection with any null elements throws NPE after
233       * possibly adding some elements
234       */
# Line 274 | Line 240 | public class PriorityBlockingQueueTest e
240                  ints[i] = new Integer(i);
241              q.addAll(Arrays.asList(ints));
242              shouldThrow();
243 <        }
278 <        catch (NullPointerException success) {}
243 >        } catch (NullPointerException success) {}
244      }
245  
246      /**
247       * Queue contains all elements of successful addAll
248       */
249      public void testAddAll5() {
250 <        try {
251 <            Integer[] empty = new Integer[0];
252 <            Integer[] ints = new Integer[SIZE];
253 <            for (int i = SIZE-1; i >= 0; --i)
254 <                ints[i] = new Integer(i);
255 <            PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
256 <            assertFalse(q.addAll(Arrays.asList(empty)));
257 <            assertTrue(q.addAll(Arrays.asList(ints)));
258 <            for (int i = 0; i < SIZE; ++i)
294 <                assertEquals(ints[i], q.poll());
295 <        }
296 <        finally {}
250 >        Integer[] empty = new Integer[0];
251 >        Integer[] ints = new Integer[SIZE];
252 >        for (int i = SIZE-1; i >= 0; --i)
253 >            ints[i] = new Integer(i);
254 >        PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
255 >        assertFalse(q.addAll(Arrays.asList(empty)));
256 >        assertTrue(q.addAll(Arrays.asList(ints)));
257 >        for (int i = 0; i < SIZE; ++i)
258 >            assertEquals(ints[i], q.poll());
259      }
260  
261      /**
300     * put(null) throws NPE
301     */
302     public void testPutNull() {
303        try {
304            PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
305            q.put(null);
306            shouldThrow();
307        }
308        catch (NullPointerException success){
309        }
310     }
311
312    /**
262       * all elements successfully put are contained
263       */
264 <     public void testPut() {
265 <         try {
266 <             PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
267 <             for (int i = 0; i < SIZE; ++i) {
268 <                 Integer I = new Integer(i);
269 <                 q.put(I);
321 <                 assertTrue(q.contains(I));
322 <             }
323 <             assertEquals(SIZE, q.size());
324 <         }
325 <         finally {
264 >    public void testPut() {
265 >        PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
266 >        for (int i = 0; i < SIZE; ++i) {
267 >            Integer I = new Integer(i);
268 >            q.put(I);
269 >            assertTrue(q.contains(I));
270          }
271 +        assertEquals(SIZE, q.size());
272      }
273  
274      /**
275       * put doesn't block waiting for take
276       */
277 <    public void testPutWithTake() {
277 >    public void testPutWithTake() throws InterruptedException {
278          final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
279 <        Thread t = new Thread(new Runnable() {
280 <                public void run() {
281 <                    int added = 0;
282 <                    try {
283 <                        q.put(new Integer(0));
284 <                        ++added;
285 <                        q.put(new Integer(0));
286 <                        ++added;
287 <                        q.put(new Integer(0));
288 <                        ++added;
344 <                        q.put(new Integer(0));
345 <                        ++added;
346 <                        threadAssertTrue(added == 4);
347 <                    } finally {
348 <                    }
349 <                }
350 <            });
351 <        try {
352 <            t.start();
353 <            Thread.sleep(SHORT_DELAY_MS);
354 <            q.take();
355 <            t.interrupt();
356 <            t.join();
357 <        } catch (Exception e){
358 <            unexpectedException();
359 <        }
279 >        final int size = 4;
280 >        Thread t = newStartedThread(new CheckedRunnable() {
281 >            public void realRun() {
282 >                for (int i = 0; i < size; i++)
283 >                    q.put(new Integer(0));
284 >            }});
285 >
286 >        awaitTermination(t);
287 >        assertEquals(size, q.size());
288 >        q.take();
289      }
290  
291      /**
292       * timed offer does not time out
293       */
294 <    public void testTimedOffer() {
294 >    public void testTimedOffer() throws InterruptedException {
295          final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
296 <        Thread t = new Thread(new Runnable() {
297 <                public void run() {
298 <                    try {
299 <                        q.put(new Integer(0));
300 <                        q.put(new Integer(0));
301 <                        threadAssertTrue(q.offer(new Integer(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
302 <                        threadAssertTrue(q.offer(new Integer(0), LONG_DELAY_MS, TimeUnit.MILLISECONDS));
374 <                    } finally { }
375 <                }
376 <            });
296 >        Thread t = newStartedThread(new CheckedRunnable() {
297 >            public void realRun() {
298 >                q.put(new Integer(0));
299 >                q.put(new Integer(0));
300 >                assertTrue(q.offer(new Integer(0), SHORT_DELAY_MS, MILLISECONDS));
301 >                assertTrue(q.offer(new Integer(0), LONG_DELAY_MS, MILLISECONDS));
302 >            }});
303  
304 <        try {
379 <            t.start();
380 <            Thread.sleep(SMALL_DELAY_MS);
381 <            t.interrupt();
382 <            t.join();
383 <        } catch (Exception e){
384 <            unexpectedException();
385 <        }
304 >        awaitTermination(t);
305      }
306  
307      /**
308       * take retrieves elements in priority order
309       */
310 <    public void testTake() {
311 <        try {
312 <            PriorityBlockingQueue q = populatedQueue(SIZE);
313 <            for (int i = 0; i < SIZE; ++i) {
395 <                assertEquals(i, ((Integer)q.take()).intValue());
396 <            }
397 <        } catch (InterruptedException e){
398 <            unexpectedException();
399 <        }
400 <    }
401 <
402 <    /**
403 <     * take blocks interruptibly when empty
404 <     */
405 <    public void testTakeFromEmpty() {
406 <        final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
407 <        Thread t = new Thread(new Runnable() {
408 <                public void run() {
409 <                    try {
410 <                        q.take();
411 <                        threadShouldThrow();
412 <                    } catch (InterruptedException success){ }
413 <                }
414 <            });
415 <        try {
416 <            t.start();
417 <            Thread.sleep(SHORT_DELAY_MS);
418 <            t.interrupt();
419 <            t.join();
420 <        } catch (Exception e){
421 <            unexpectedException();
310 >    public void testTake() throws InterruptedException {
311 >        PriorityBlockingQueue q = populatedQueue(SIZE);
312 >        for (int i = 0; i < SIZE; ++i) {
313 >            assertEquals(i, q.take());
314          }
315      }
316  
317      /**
318       * Take removes existing elements until empty, then blocks interruptibly
319       */
320 <    public void testBlockingTake() {
321 <        Thread t = new Thread(new Runnable() {
322 <                public void run() {
323 <                    try {
324 <                        PriorityBlockingQueue q = populatedQueue(SIZE);
325 <                        for (int i = 0; i < SIZE; ++i) {
326 <                            threadAssertEquals(i, ((Integer)q.take()).intValue());
327 <                        }
436 <                        q.take();
437 <                        threadShouldThrow();
438 <                    } catch (InterruptedException success){
439 <                    }
440 <                }});
441 <        t.start();
442 <        try {
443 <           Thread.sleep(SHORT_DELAY_MS);
444 <           t.interrupt();
445 <           t.join();
446 <        }
447 <        catch (InterruptedException ie) {
448 <            unexpectedException();
449 <        }
450 <    }
320 >    public void testBlockingTake() throws InterruptedException {
321 >        final PriorityBlockingQueue q = populatedQueue(SIZE);
322 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
323 >        Thread t = newStartedThread(new CheckedRunnable() {
324 >            public void realRun() throws InterruptedException {
325 >                for (int i = 0; i < SIZE; ++i) {
326 >                    assertEquals(i, q.take());
327 >                }
328  
329 +                Thread.currentThread().interrupt();
330 +                try {
331 +                    q.take();
332 +                    shouldThrow();
333 +                } catch (InterruptedException success) {}
334 +                assertFalse(Thread.interrupted());
335 +
336 +                pleaseInterrupt.countDown();
337 +                try {
338 +                    q.take();
339 +                    shouldThrow();
340 +                } catch (InterruptedException success) {}
341 +                assertFalse(Thread.interrupted());
342 +            }});
343 +
344 +        await(pleaseInterrupt);
345 +        assertThreadStaysAlive(t);
346 +        t.interrupt();
347 +        awaitTermination(t);
348 +    }
349  
350      /**
351       * poll succeeds unless empty
# Line 456 | Line 353 | public class PriorityBlockingQueueTest e
353      public void testPoll() {
354          PriorityBlockingQueue q = populatedQueue(SIZE);
355          for (int i = 0; i < SIZE; ++i) {
356 <            assertEquals(i, ((Integer)q.poll()).intValue());
356 >            assertEquals(i, q.poll());
357          }
358 <        assertNull(q.poll());
358 >        assertNull(q.poll());
359      }
360  
361      /**
362 <     * timed pool with zero timeout succeeds when non-empty, else times out
362 >     * timed poll with zero timeout succeeds when non-empty, else times out
363       */
364 <    public void testTimedPoll0() {
365 <        try {
366 <            PriorityBlockingQueue q = populatedQueue(SIZE);
367 <            for (int i = 0; i < SIZE; ++i) {
368 <                assertEquals(i, ((Integer)q.poll(0, TimeUnit.MILLISECONDS)).intValue());
369 <            }
473 <            assertNull(q.poll(0, TimeUnit.MILLISECONDS));
474 <        } catch (InterruptedException e){
475 <            unexpectedException();
476 <        }
364 >    public void testTimedPoll0() throws InterruptedException {
365 >        PriorityBlockingQueue q = populatedQueue(SIZE);
366 >        for (int i = 0; i < SIZE; ++i) {
367 >            assertEquals(i, q.poll(0, MILLISECONDS));
368 >        }
369 >        assertNull(q.poll(0, MILLISECONDS));
370      }
371  
372      /**
373 <     * timed pool with nonzero timeout succeeds when non-empty, else times out
373 >     * timed poll with nonzero timeout succeeds when non-empty, else times out
374       */
375 <    public void testTimedPoll() {
376 <        try {
377 <            PriorityBlockingQueue q = populatedQueue(SIZE);
378 <            for (int i = 0; i < SIZE; ++i) {
379 <                assertEquals(i, ((Integer)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)).intValue());
380 <            }
381 <            assertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
382 <        } catch (InterruptedException e){
383 <            unexpectedException();
384 <        }
375 >    public void testTimedPoll() throws InterruptedException {
376 >        PriorityBlockingQueue<Integer> q = populatedQueue(SIZE);
377 >        for (int i = 0; i < SIZE; ++i) {
378 >            long startTime = System.nanoTime();
379 >            assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
380 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
381 >        }
382 >        long startTime = System.nanoTime();
383 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
384 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
385 >        checkEmpty(q);
386      }
387  
388      /**
389       * Interrupted timed poll throws InterruptedException instead of
390       * returning timeout status
391       */
392 <    public void testInterruptedTimedPoll() {
393 <        Thread t = new Thread(new Runnable() {
394 <                public void run() {
395 <                    try {
396 <                        PriorityBlockingQueue q = populatedQueue(SIZE);
397 <                        for (int i = 0; i < SIZE; ++i) {
398 <                            threadAssertEquals(i, ((Integer)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)).intValue());
399 <                        }
400 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
507 <                    } catch (InterruptedException success){
508 <                    }
509 <                }});
510 <        t.start();
511 <        try {
512 <           Thread.sleep(SHORT_DELAY_MS);
513 <           t.interrupt();
514 <           t.join();
515 <        }
516 <        catch (InterruptedException ie) {
517 <            unexpectedException();
518 <        }
519 <    }
520 <
521 <    /**
522 <     *  timed poll before a delayed offer fails; after offer succeeds;
523 <     *  on interruption throws
524 <     */
525 <    public void testTimedPollWithOffer() {
526 <        final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
527 <        Thread t = new Thread(new Runnable() {
528 <                public void run() {
529 <                    try {
530 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
531 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
532 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
533 <                        threadShouldThrow();
534 <                    } catch (InterruptedException success) { }
392 >    public void testInterruptedTimedPoll() throws InterruptedException {
393 >        final BlockingQueue<Integer> q = populatedQueue(SIZE);
394 >        final CountDownLatch aboutToWait = new CountDownLatch(1);
395 >        Thread t = newStartedThread(new CheckedRunnable() {
396 >            public void realRun() throws InterruptedException {
397 >                for (int i = 0; i < SIZE; ++i) {
398 >                    long t0 = System.nanoTime();
399 >                    assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
400 >                    assertTrue(millisElapsedSince(t0) < SMALL_DELAY_MS);
401                  }
402 <            });
403 <        try {
404 <            t.start();
405 <            Thread.sleep(SMALL_DELAY_MS);
406 <            assertTrue(q.offer(new Integer(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
407 <            t.interrupt();
408 <            t.join();
409 <        } catch (Exception e){
410 <            unexpectedException();
545 <        }
546 <    }
402 >                long t0 = System.nanoTime();
403 >                aboutToWait.countDown();
404 >                try {
405 >                    q.poll(LONG_DELAY_MS, MILLISECONDS);
406 >                    shouldThrow();
407 >                } catch (InterruptedException success) {
408 >                    assertTrue(millisElapsedSince(t0) < MEDIUM_DELAY_MS);
409 >                }
410 >            }});
411  
412 +        aboutToWait.await();
413 +        waitForThreadToEnterWaitState(t, SMALL_DELAY_MS);
414 +        t.interrupt();
415 +        awaitTermination(t, MEDIUM_DELAY_MS);
416 +    }
417  
418      /**
419       * peek returns next element, or null if empty
# Line 552 | Line 421 | public class PriorityBlockingQueueTest e
421      public void testPeek() {
422          PriorityBlockingQueue q = populatedQueue(SIZE);
423          for (int i = 0; i < SIZE; ++i) {
424 <            assertEquals(i, ((Integer)q.peek()).intValue());
425 <            q.poll();
424 >            assertEquals(i, q.peek());
425 >            assertEquals(i, q.poll());
426              assertTrue(q.peek() == null ||
427 <                       i != ((Integer)q.peek()).intValue());
427 >                       !q.peek().equals(i));
428          }
429 <        assertNull(q.peek());
429 >        assertNull(q.peek());
430      }
431  
432      /**
# Line 566 | Line 435 | public class PriorityBlockingQueueTest e
435      public void testElement() {
436          PriorityBlockingQueue q = populatedQueue(SIZE);
437          for (int i = 0; i < SIZE; ++i) {
438 <            assertEquals(i, ((Integer)q.element()).intValue());
439 <            q.poll();
438 >            assertEquals(i, q.element());
439 >            assertEquals(i, q.poll());
440          }
441          try {
442              q.element();
443              shouldThrow();
444 <        }
576 <        catch (NoSuchElementException success) {}
444 >        } catch (NoSuchElementException success) {}
445      }
446  
447      /**
# Line 582 | Line 450 | public class PriorityBlockingQueueTest e
450      public void testRemove() {
451          PriorityBlockingQueue q = populatedQueue(SIZE);
452          for (int i = 0; i < SIZE; ++i) {
453 <            assertEquals(i, ((Integer)q.remove()).intValue());
453 >            assertEquals(i, q.remove());
454          }
455          try {
456              q.remove();
457              shouldThrow();
458 <        } catch (NoSuchElementException success){
591 <        }
458 >        } catch (NoSuchElementException success) {}
459      }
460  
461      /**
# Line 597 | Line 464 | public class PriorityBlockingQueueTest e
464      public void testRemoveElement() {
465          PriorityBlockingQueue q = populatedQueue(SIZE);
466          for (int i = 1; i < SIZE; i+=2) {
467 <            assertTrue(q.remove(new Integer(i)));
467 >            assertTrue(q.contains(i));
468 >            assertTrue(q.remove(i));
469 >            assertFalse(q.contains(i));
470 >            assertTrue(q.contains(i-1));
471          }
472          for (int i = 0; i < SIZE; i+=2) {
473 <            assertTrue(q.remove(new Integer(i)));
474 <            assertFalse(q.remove(new Integer(i+1)));
473 >            assertTrue(q.contains(i));
474 >            assertTrue(q.remove(i));
475 >            assertFalse(q.contains(i));
476 >            assertFalse(q.remove(i+1));
477 >            assertFalse(q.contains(i+1));
478          }
479          assertTrue(q.isEmpty());
480      }
# Line 683 | Line 556 | public class PriorityBlockingQueueTest e
556      }
557  
558      /**
559 <     *  toArray contains all elements
559 >     * toArray contains all elements
560       */
561 <    public void testToArray() {
561 >    public void testToArray() throws InterruptedException {
562          PriorityBlockingQueue q = populatedQueue(SIZE);
563 <        Object[] o = q.toArray();
563 >        Object[] o = q.toArray();
564          Arrays.sort(o);
565 <        try {
566 <        for (int i = 0; i < o.length; i++)
694 <            assertEquals(o[i], q.take());
695 <        } catch (InterruptedException e){
696 <            unexpectedException();
697 <        }
565 >        for (int i = 0; i < o.length; i++)
566 >            assertSame(o[i], q.take());
567      }
568  
569      /**
570       * toArray(a) contains all elements
571       */
572 <    public void testToArray2() {
573 <        PriorityBlockingQueue q = populatedQueue(SIZE);
574 <        Integer[] ints = new Integer[SIZE];
575 <        ints = (Integer[])q.toArray(ints);
572 >    public void testToArray2() throws InterruptedException {
573 >        PriorityBlockingQueue<Integer> q = populatedQueue(SIZE);
574 >        Integer[] ints = new Integer[SIZE];
575 >        Integer[] array = q.toArray(ints);
576 >        assertSame(ints, array);
577          Arrays.sort(ints);
578 <        try {
579 <            for (int i = 0; i < ints.length; i++)
710 <                assertEquals(ints[i], q.take());
711 <        } catch (InterruptedException e){
712 <            unexpectedException();
713 <        }
714 <    }
715 <
716 <    /**
717 <     * toArray(null) throws NPE
718 <     */
719 <    public void testToArray_BadArg() {
720 <        try {
721 <            PriorityBlockingQueue q = populatedQueue(SIZE);
722 <            Object o[] = q.toArray(null);
723 <            shouldThrow();
724 <        } catch (NullPointerException success){}
578 >        for (int i = 0; i < ints.length; i++)
579 >            assertSame(ints[i], q.take());
580      }
581  
582      /**
583 <     * toArray with incompatible array type throws CCE
583 >     * toArray(incompatible array type) throws ArrayStoreException
584       */
585      public void testToArray1_BadArg() {
586 <        try {
587 <            PriorityBlockingQueue q = populatedQueue(SIZE);
588 <            Object o[] = q.toArray(new String[10] );
589 <            shouldThrow();
590 <        } catch (ArrayStoreException  success){}
586 >        PriorityBlockingQueue q = populatedQueue(SIZE);
587 >        try {
588 >            q.toArray(new String[10]);
589 >            shouldThrow();
590 >        } catch (ArrayStoreException success) {}
591      }
592  
593      /**
# Line 741 | Line 596 | public class PriorityBlockingQueueTest e
596      public void testIterator() {
597          PriorityBlockingQueue q = populatedQueue(SIZE);
598          int i = 0;
599 <        Iterator it = q.iterator();
599 >        Iterator it = q.iterator();
600          while (it.hasNext()) {
601              assertTrue(q.contains(it.next()));
602              ++i;
# Line 752 | Line 607 | public class PriorityBlockingQueueTest e
607      /**
608       * iterator.remove removes current element
609       */
610 <    public void testIteratorRemove () {
610 >    public void testIteratorRemove() {
611          final PriorityBlockingQueue q = new PriorityBlockingQueue(3);
612          q.add(new Integer(2));
613          q.add(new Integer(1));
# Line 768 | Line 623 | public class PriorityBlockingQueueTest e
623          assertFalse(it.hasNext());
624      }
625  
771
626      /**
627       * toString contains toStrings of elements
628       */
# Line 776 | Line 630 | public class PriorityBlockingQueueTest e
630          PriorityBlockingQueue q = populatedQueue(SIZE);
631          String s = q.toString();
632          for (int i = 0; i < SIZE; ++i) {
633 <            assertTrue(s.indexOf(String.valueOf(i)) >= 0);
633 >            assertTrue(s.contains(String.valueOf(i)));
634          }
635      }
636  
637      /**
638 <     * offer transfers elements across Executor tasks
638 >     * timed poll transfers elements across Executor tasks
639       */
640      public void testPollInExecutor() {
641          final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
642 +        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
643          ExecutorService executor = Executors.newFixedThreadPool(2);
644 <        executor.execute(new Runnable() {
645 <            public void run() {
646 <                threadAssertNull(q.poll());
647 <                try {
648 <                    threadAssertTrue(null != q.poll(MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS));
649 <                    threadAssertTrue(q.isEmpty());
650 <                }
651 <                catch (InterruptedException e) {
652 <                    threadUnexpectedException();
653 <                }
654 <            }
655 <        });
656 <
802 <        executor.execute(new Runnable() {
803 <            public void run() {
804 <                try {
805 <                    Thread.sleep(SMALL_DELAY_MS);
806 <                    q.put(new Integer(1));
807 <                }
808 <                catch (InterruptedException e) {
809 <                    threadUnexpectedException();
810 <                }
811 <            }
812 <        });
644 >        executor.execute(new CheckedRunnable() {
645 >            public void realRun() throws InterruptedException {
646 >                assertNull(q.poll());
647 >                threadsStarted.await();
648 >                assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
649 >                checkEmpty(q);
650 >            }});
651 >
652 >        executor.execute(new CheckedRunnable() {
653 >            public void realRun() throws InterruptedException {
654 >                threadsStarted.await();
655 >                q.put(one);
656 >            }});
657  
658          joinPool(executor);
659      }
# Line 817 | Line 661 | public class PriorityBlockingQueueTest e
661      /**
662       * A deserialized serialized queue has same elements
663       */
664 <    public void testSerialization() {
664 >    public void testSerialization() throws Exception {
665          PriorityBlockingQueue q = populatedQueue(SIZE);
666 <        try {
667 <            ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
668 <            ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
669 <            out.writeObject(q);
670 <            out.close();
671 <
672 <            ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
673 <            ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
674 <            PriorityBlockingQueue r = (PriorityBlockingQueue)in.readObject();
675 <            assertEquals(q.size(), r.size());
676 <            while (!q.isEmpty())
833 <                assertEquals(q.remove(), r.remove());
834 <        } catch (Exception e){
835 <            unexpectedException();
836 <        }
837 <    }
838 <
839 <    /**
840 <     * drainTo(null) throws NPE
841 <     */
842 <    public void testDrainToNull() {
843 <        PriorityBlockingQueue q = populatedQueue(SIZE);
844 <        try {
845 <            q.drainTo(null);
846 <            shouldThrow();
847 <        } catch (NullPointerException success) {
848 <        }
849 <    }
850 <
851 <    /**
852 <     * drainTo(this) throws IAE
853 <     */
854 <    public void testDrainToSelf() {
855 <        PriorityBlockingQueue q = populatedQueue(SIZE);
856 <        try {
857 <            q.drainTo(q);
858 <            shouldThrow();
859 <        } catch (IllegalArgumentException success) {
860 <        }
666 >        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
667 >        ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
668 >        out.writeObject(q);
669 >        out.close();
670 >
671 >        ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
672 >        ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
673 >        PriorityBlockingQueue r = (PriorityBlockingQueue)in.readObject();
674 >        assertEquals(q.size(), r.size());
675 >        while (!q.isEmpty())
676 >            assertEquals(q.remove(), r.remove());
677      }
678  
679      /**
# Line 887 | Line 703 | public class PriorityBlockingQueueTest e
703      /**
704       * drainTo empties queue
705       */
706 <    public void testDrainToWithActivePut() {
706 >    public void testDrainToWithActivePut() throws InterruptedException {
707          final PriorityBlockingQueue q = populatedQueue(SIZE);
708 <        Thread t = new Thread(new Runnable() {
709 <                public void run() {
710 <                    q.put(new Integer(SIZE+1));
711 <                }
896 <            });
897 <        try {
898 <            t.start();
899 <            ArrayList l = new ArrayList();
900 <            q.drainTo(l);
901 <            assertTrue(l.size() >= SIZE);
902 <            for (int i = 0; i < SIZE; ++i)
903 <                assertEquals(l.get(i), new Integer(i));
904 <            t.join();
905 <            assertTrue(q.size() + l.size() >= SIZE);
906 <        } catch (Exception e){
907 <            unexpectedException();
908 <        }
909 <    }
910 <
911 <    /**
912 <     * drainTo(null, n) throws NPE
913 <     */
914 <    public void testDrainToNullN() {
915 <        PriorityBlockingQueue q = populatedQueue(SIZE);
916 <        try {
917 <            q.drainTo(null, 0);
918 <            shouldThrow();
919 <        } catch (NullPointerException success) {
920 <        }
921 <    }
708 >        Thread t = new Thread(new CheckedRunnable() {
709 >            public void realRun() {
710 >                q.put(new Integer(SIZE+1));
711 >            }});
712  
713 <    /**
714 <     * drainTo(this, n) throws IAE
715 <     */
716 <    public void testDrainToSelfN() {
717 <        PriorityBlockingQueue q = populatedQueue(SIZE);
718 <        try {
719 <            q.drainTo(q, 0);
720 <            shouldThrow();
931 <        } catch (IllegalArgumentException success) {
932 <        }
713 >        t.start();
714 >        ArrayList l = new ArrayList();
715 >        q.drainTo(l);
716 >        assertTrue(l.size() >= SIZE);
717 >        for (int i = 0; i < SIZE; ++i)
718 >            assertEquals(l.get(i), new Integer(i));
719 >        t.join();
720 >        assertTrue(q.size() + l.size() >= SIZE);
721      }
722  
723      /**
724 <     * drainTo(c, n) empties first max {n, size} elements of queue into c
724 >     * drainTo(c, n) empties first min(n, size) elements of queue into c
725       */
726      public void testDrainToN() {
727          PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE*2);
# Line 942 | Line 730 | public class PriorityBlockingQueueTest e
730                  assertTrue(q.offer(new Integer(j)));
731              ArrayList l = new ArrayList();
732              q.drainTo(l, i);
733 <            int k = (i < SIZE)? i : SIZE;
733 >            int k = (i < SIZE) ? i : SIZE;
734              assertEquals(l.size(), k);
735              assertEquals(q.size(), SIZE-k);
736              for (int j = 0; j < k; ++j)
# Line 951 | Line 739 | public class PriorityBlockingQueueTest e
739          }
740      }
741  
954
742   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines