ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/PriorityBlockingQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/PriorityBlockingQueueTest.java (file contents):
Revision 1.11 by dl, Sun Oct 31 14:55:14 2004 UTC vs.
Revision 1.38 by jsr166, Fri Nov 5 00:17:22 2010 UTC

# Line 2 | Line 2
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4   * http://creativecommons.org/licenses/publicdomain
5 < * Other contributors include Andrew Wright, Jeffrey Hayes,
6 < * Pat Fisher, Mike Judd.
5 > * Other contributors include Andrew Wright, Jeffrey Hayes,
6 > * Pat Fisher, Mike Judd.
7   */
8  
9   import junit.framework.*;
10   import java.util.*;
11   import java.util.concurrent.*;
12 + import static java.util.concurrent.TimeUnit.MILLISECONDS;
13   import java.io.*;
14  
15   public class PriorityBlockingQueueTest extends JSR166TestCase {
16 +
17 +    public static class Generic extends BlockingQueueTest {
18 +        protected BlockingQueue emptyCollection() {
19 +            return new PriorityBlockingQueue();
20 +        }
21 +    }
22 +
23 +    public static class InitialCapacity extends BlockingQueueTest {
24 +        protected BlockingQueue emptyCollection() {
25 +            return new PriorityBlockingQueue(20);
26 +        }
27 +    }
28 +
29      public static void main(String[] args) {
30 <        junit.textui.TestRunner.run (suite());  
30 >        junit.textui.TestRunner.run(suite());
31      }
32 +
33      public static Test suite() {
34 <        return new TestSuite(PriorityBlockingQueueTest.class);
34 >        return newTestSuite(PriorityBlockingQueueTest.class,
35 >                            new Generic().testSuite(),
36 >                            new InitialCapacity().testSuite());
37      }
38  
39      private static final int NOCAP = Integer.MAX_VALUE;
40  
41      /** Sample Comparator */
42 <    static class MyReverseComparator implements Comparator {
42 >    static class MyReverseComparator implements Comparator {
43          public int compare(Object x, Object y) {
44 <            int i = ((Integer)x).intValue();
28 <            int j = ((Integer)y).intValue();
29 <            if (i < j) return 1;
30 <            if (i > j) return -1;
31 <            return 0;
44 >            return ((Comparable)y).compareTo(x);
45          }
46      }
47  
# Line 36 | Line 49 | public class PriorityBlockingQueueTest e
49       * Create a queue of given size containing consecutive
50       * Integers 0 ... n.
51       */
52 <    private PriorityBlockingQueue populatedQueue(int n) {
53 <        PriorityBlockingQueue q = new PriorityBlockingQueue(n);
52 >    private PriorityBlockingQueue<Integer> populatedQueue(int n) {
53 >        PriorityBlockingQueue<Integer> q =
54 >            new PriorityBlockingQueue<Integer>(n);
55          assertTrue(q.isEmpty());
56 <        for(int i = n-1; i >= 0; i-=2)
57 <            assertTrue(q.offer(new Integer(i)));
58 <        for(int i = (n & 1); i < n; i+=2)
59 <            assertTrue(q.offer(new Integer(i)));
56 >        for (int i = n-1; i >= 0; i-=2)
57 >            assertTrue(q.offer(new Integer(i)));
58 >        for (int i = (n & 1); i < n; i+=2)
59 >            assertTrue(q.offer(new Integer(i)));
60          assertFalse(q.isEmpty());
61          assertEquals(NOCAP, q.remainingCapacity());
62 <        assertEquals(n, q.size());
62 >        assertEquals(n, q.size());
63          return q;
64      }
65 <
65 >
66      /**
67       * A new queue has unbounded capacity
68       */
# Line 57 | Line 71 | public class PriorityBlockingQueueTest e
71      }
72  
73      /**
74 <     * Constructor throws IAE if  capacity argument nonpositive
74 >     * Constructor throws IAE if capacity argument nonpositive
75       */
76      public void testConstructor2() {
77          try {
78              PriorityBlockingQueue q = new PriorityBlockingQueue(0);
79              shouldThrow();
80 <        }
67 <        catch (IllegalArgumentException success) {}
80 >        } catch (IllegalArgumentException success) {}
81      }
82  
83      /**
# Line 74 | Line 87 | public class PriorityBlockingQueueTest e
87          try {
88              PriorityBlockingQueue q = new PriorityBlockingQueue(null);
89              shouldThrow();
90 <        }
78 <        catch (NullPointerException success) {}
90 >        } catch (NullPointerException success) {}
91      }
92  
93      /**
# Line 86 | Line 98 | public class PriorityBlockingQueueTest e
98              Integer[] ints = new Integer[SIZE];
99              PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
100              shouldThrow();
101 <        }
90 <        catch (NullPointerException success) {}
101 >        } catch (NullPointerException success) {}
102      }
103  
104      /**
# Line 100 | Line 111 | public class PriorityBlockingQueueTest e
111                  ints[i] = new Integer(i);
112              PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
113              shouldThrow();
114 <        }
104 <        catch (NullPointerException success) {}
114 >        } catch (NullPointerException success) {}
115      }
116  
117      /**
118       * Queue contains all elements of collection used to initialize
119       */
120      public void testConstructor6() {
121 <        try {
122 <            Integer[] ints = new Integer[SIZE];
123 <            for (int i = 0; i < SIZE; ++i)
124 <                ints[i] = new Integer(i);
125 <            PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
126 <            for (int i = 0; i < SIZE; ++i)
117 <                assertEquals(ints[i], q.poll());
118 <        }
119 <        finally {}
121 >        Integer[] ints = new Integer[SIZE];
122 >        for (int i = 0; i < SIZE; ++i)
123 >            ints[i] = new Integer(i);
124 >        PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
125 >        for (int i = 0; i < SIZE; ++i)
126 >            assertEquals(ints[i], q.poll());
127      }
128  
129      /**
130       * The comparator used in constructor is used
131       */
132      public void testConstructor7() {
133 <        try {
134 <            MyReverseComparator cmp = new MyReverseComparator();
135 <            PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE, cmp);
136 <            assertEquals(cmp, q.comparator());
137 <            Integer[] ints = new Integer[SIZE];
138 <            for (int i = 0; i < SIZE; ++i)
139 <                ints[i] = new Integer(i);
140 <            q.addAll(Arrays.asList(ints));
141 <            for (int i = SIZE-1; i >= 0; --i)
135 <                assertEquals(ints[i], q.poll());
136 <        }
137 <        finally {}
133 >        MyReverseComparator cmp = new MyReverseComparator();
134 >        PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE, cmp);
135 >        assertEquals(cmp, q.comparator());
136 >        Integer[] ints = new Integer[SIZE];
137 >        for (int i = 0; i < SIZE; ++i)
138 >            ints[i] = new Integer(i);
139 >        q.addAll(Arrays.asList(ints));
140 >        for (int i = SIZE-1; i >= 0; --i)
141 >            assertEquals(ints[i], q.poll());
142      }
143  
144      /**
# Line 174 | Line 178 | public class PriorityBlockingQueueTest e
178       * offer(null) throws NPE
179       */
180      public void testOfferNull() {
181 <        try {
181 >        try {
182              PriorityBlockingQueue q = new PriorityBlockingQueue(1);
183              q.offer(null);
184              shouldThrow();
185 <        } catch (NullPointerException success) { }  
185 >        } catch (NullPointerException success) {}
186      }
187  
188      /**
189       * add(null) throws NPE
190       */
191      public void testAddNull() {
192 <        try {
192 >        try {
193              PriorityBlockingQueue q = new PriorityBlockingQueue(1);
194              q.add(null);
195              shouldThrow();
196 <        } catch (NullPointerException success) { }  
196 >        } catch (NullPointerException success) {}
197      }
198  
199      /**
# Line 211 | Line 215 | public class PriorityBlockingQueueTest e
215              q.offer(new Object());
216              q.offer(new Object());
217              shouldThrow();
218 <        }
215 <        catch(ClassCastException success) {}
218 >        } catch (ClassCastException success) {}
219      }
220  
221      /**
# Line 234 | Line 237 | public class PriorityBlockingQueueTest e
237              PriorityBlockingQueue q = new PriorityBlockingQueue(1);
238              q.addAll(null);
239              shouldThrow();
240 <        }
238 <        catch (NullPointerException success) {}
240 >        } catch (NullPointerException success) {}
241      }
242  
243      /**
# Line 246 | Line 248 | public class PriorityBlockingQueueTest e
248              PriorityBlockingQueue q = populatedQueue(SIZE);
249              q.addAll(q);
250              shouldThrow();
251 <        }
250 <        catch (IllegalArgumentException success) {}
251 >        } catch (IllegalArgumentException success) {}
252      }
253  
254      /**
# Line 259 | Line 260 | public class PriorityBlockingQueueTest e
260              Integer[] ints = new Integer[SIZE];
261              q.addAll(Arrays.asList(ints));
262              shouldThrow();
263 <        }
263 <        catch (NullPointerException success) {}
263 >        } catch (NullPointerException success) {}
264      }
265 +
266      /**
267       * addAll of a collection with any null elements throws NPE after
268       * possibly adding some elements
# Line 274 | Line 275 | public class PriorityBlockingQueueTest e
275                  ints[i] = new Integer(i);
276              q.addAll(Arrays.asList(ints));
277              shouldThrow();
278 <        }
278 <        catch (NullPointerException success) {}
278 >        } catch (NullPointerException success) {}
279      }
280  
281      /**
282       * Queue contains all elements of successful addAll
283       */
284      public void testAddAll5() {
285 <        try {
286 <            Integer[] empty = new Integer[0];
287 <            Integer[] ints = new Integer[SIZE];
288 <            for (int i = SIZE-1; i >= 0; --i)
289 <                ints[i] = new Integer(i);
290 <            PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
291 <            assertFalse(q.addAll(Arrays.asList(empty)));
292 <            assertTrue(q.addAll(Arrays.asList(ints)));
293 <            for (int i = 0; i < SIZE; ++i)
294 <                assertEquals(ints[i], q.poll());
295 <        }
296 <        finally {}
285 >        Integer[] empty = new Integer[0];
286 >        Integer[] ints = new Integer[SIZE];
287 >        for (int i = SIZE-1; i >= 0; --i)
288 >            ints[i] = new Integer(i);
289 >        PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
290 >        assertFalse(q.addAll(Arrays.asList(empty)));
291 >        assertTrue(q.addAll(Arrays.asList(ints)));
292 >        for (int i = 0; i < SIZE; ++i)
293 >            assertEquals(ints[i], q.poll());
294      }
295  
296      /**
297       * put(null) throws NPE
298       */
299       public void testPutNull() {
300 <        try {
300 >        try {
301              PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
302              q.put(null);
303              shouldThrow();
304 <        }
308 <        catch (NullPointerException success){
309 <        }  
304 >        } catch (NullPointerException success) {}
305       }
306  
307      /**
308       * all elements successfully put are contained
309       */
310       public void testPut() {
311 <         try {
312 <             PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
313 <             for (int i = 0; i < SIZE; ++i) {
314 <                 Integer I = new Integer(i);
315 <                 q.put(I);
321 <                 assertTrue(q.contains(I));
322 <             }
323 <             assertEquals(SIZE, q.size());
311 >         PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
312 >         for (int i = 0; i < SIZE; ++i) {
313 >             Integer I = new Integer(i);
314 >             q.put(I);
315 >             assertTrue(q.contains(I));
316           }
317 <         finally {
326 <        }
317 >         assertEquals(SIZE, q.size());
318      }
319  
320      /**
321       * put doesn't block waiting for take
322       */
323 <    public void testPutWithTake() {
323 >    public void testPutWithTake() throws InterruptedException {
324          final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
325 <        Thread t = new Thread(new Runnable() {
326 <                public void run() {
327 <                    int added = 0;
328 <                    try {
329 <                        q.put(new Integer(0));
330 <                        ++added;
331 <                        q.put(new Integer(0));
332 <                        ++added;
333 <                        q.put(new Integer(0));
334 <                        ++added;
335 <                        q.put(new Integer(0));
336 <                        ++added;
337 <                        threadAssertTrue(added == 4);
347 <                    } finally {
348 <                    }
349 <                }
350 <            });
351 <        try {
352 <            t.start();
353 <            Thread.sleep(SHORT_DELAY_MS);
354 <            q.take();
355 <            t.interrupt();
356 <            t.join();
357 <        } catch (Exception e){
358 <            unexpectedException();
359 <        }
325 >        final int size = 4;
326 >        Thread t = new Thread(new CheckedRunnable() {
327 >            public void realRun() {
328 >                for (int i = 0; i < size; i++)
329 >                    q.put(new Integer(0));
330 >            }});
331 >
332 >        t.start();
333 >        Thread.sleep(SHORT_DELAY_MS);
334 >        assertEquals(q.size(), size);
335 >        q.take();
336 >        t.interrupt();
337 >        t.join();
338      }
339  
340      /**
341       * timed offer does not time out
342       */
343 <    public void testTimedOffer() {
343 >    public void testTimedOffer() throws InterruptedException {
344          final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
345 <        Thread t = new Thread(new Runnable() {
346 <                public void run() {
347 <                    try {
348 <                        q.put(new Integer(0));
349 <                        q.put(new Integer(0));
350 <                        threadAssertTrue(q.offer(new Integer(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
351 <                        threadAssertTrue(q.offer(new Integer(0), LONG_DELAY_MS, TimeUnit.MILLISECONDS));
374 <                    } finally { }
375 <                }
376 <            });
377 <        
378 <        try {
379 <            t.start();
380 <            Thread.sleep(SMALL_DELAY_MS);
381 <            t.interrupt();
382 <            t.join();
383 <        } catch (Exception e){
384 <            unexpectedException();
385 <        }
386 <    }
345 >        Thread t = new Thread(new CheckedRunnable() {
346 >            public void realRun() {
347 >                q.put(new Integer(0));
348 >                q.put(new Integer(0));
349 >                assertTrue(q.offer(new Integer(0), SHORT_DELAY_MS, MILLISECONDS));
350 >                assertTrue(q.offer(new Integer(0), LONG_DELAY_MS, MILLISECONDS));
351 >            }});
352  
353 <    /**
354 <     * take retrieves elements in priority order
355 <     */
356 <    public void testTake() {
392 <        try {
393 <            PriorityBlockingQueue q = populatedQueue(SIZE);
394 <            for (int i = 0; i < SIZE; ++i) {
395 <                assertEquals(i, ((Integer)q.take()).intValue());
396 <            }
397 <        } catch (InterruptedException e){
398 <            unexpectedException();
399 <        }  
353 >        t.start();
354 >        Thread.sleep(SMALL_DELAY_MS);
355 >        t.interrupt();
356 >        t.join();
357      }
358  
359      /**
360 <     * take blocks interruptibly when empty
360 >     * take retrieves elements in priority order
361       */
362 <    public void testTakeFromEmpty() {
363 <        final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
364 <        Thread t = new Thread(new Runnable() {
365 <                public void run() {
409 <                    try {
410 <                        q.take();
411 <                        threadShouldThrow();
412 <                    } catch (InterruptedException success){ }                
413 <                }
414 <            });
415 <        try {
416 <            t.start();
417 <            Thread.sleep(SHORT_DELAY_MS);
418 <            t.interrupt();
419 <            t.join();
420 <        } catch (Exception e){
421 <            unexpectedException();
362 >    public void testTake() throws InterruptedException {
363 >        PriorityBlockingQueue q = populatedQueue(SIZE);
364 >        for (int i = 0; i < SIZE; ++i) {
365 >            assertEquals(i, q.take());
366          }
367      }
368  
369      /**
370       * Take removes existing elements until empty, then blocks interruptibly
371       */
372 <    public void testBlockingTake() {
373 <        Thread t = new Thread(new Runnable() {
374 <                public void run() {
375 <                    try {
376 <                        PriorityBlockingQueue q = populatedQueue(SIZE);
377 <                        for (int i = 0; i < SIZE; ++i) {
378 <                            threadAssertEquals(i, ((Integer)q.take()).intValue());
379 <                        }
380 <                        q.take();
381 <                        threadShouldThrow();
382 <                    } catch (InterruptedException success){
383 <                    }  
384 <                }});
372 >    public void testBlockingTake() throws InterruptedException {
373 >        final PriorityBlockingQueue q = populatedQueue(SIZE);
374 >        Thread t = new Thread(new CheckedRunnable() {
375 >            public void realRun() throws InterruptedException {
376 >                for (int i = 0; i < SIZE; ++i) {
377 >                    assertEquals(i, q.take());
378 >                }
379 >                try {
380 >                    q.take();
381 >                    shouldThrow();
382 >                } catch (InterruptedException success) {}
383 >            }});
384 >
385          t.start();
386 <        try {
387 <           Thread.sleep(SHORT_DELAY_MS);
388 <           t.interrupt();
445 <           t.join();
446 <        }
447 <        catch (InterruptedException ie) {
448 <            unexpectedException();
449 <        }
386 >        Thread.sleep(SHORT_DELAY_MS);
387 >        t.interrupt();
388 >        t.join();
389      }
390  
391  
# Line 456 | Line 395 | public class PriorityBlockingQueueTest e
395      public void testPoll() {
396          PriorityBlockingQueue q = populatedQueue(SIZE);
397          for (int i = 0; i < SIZE; ++i) {
398 <            assertEquals(i, ((Integer)q.poll()).intValue());
398 >            assertEquals(i, q.poll());
399          }
400 <        assertNull(q.poll());
400 >        assertNull(q.poll());
401      }
402  
403      /**
404 <     * timed pool with zero timeout succeeds when non-empty, else times out
404 >     * timed poll with zero timeout succeeds when non-empty, else times out
405       */
406 <    public void testTimedPoll0() {
407 <        try {
408 <            PriorityBlockingQueue q = populatedQueue(SIZE);
409 <            for (int i = 0; i < SIZE; ++i) {
410 <                assertEquals(i, ((Integer)q.poll(0, TimeUnit.MILLISECONDS)).intValue());
411 <            }
473 <            assertNull(q.poll(0, TimeUnit.MILLISECONDS));
474 <        } catch (InterruptedException e){
475 <            unexpectedException();
476 <        }  
406 >    public void testTimedPoll0() throws InterruptedException {
407 >        PriorityBlockingQueue q = populatedQueue(SIZE);
408 >        for (int i = 0; i < SIZE; ++i) {
409 >            assertEquals(i, q.poll(0, MILLISECONDS));
410 >        }
411 >        assertNull(q.poll(0, MILLISECONDS));
412      }
413  
414      /**
415 <     * timed pool with nonzero timeout succeeds when non-empty, else times out
415 >     * timed poll with nonzero timeout succeeds when non-empty, else times out
416       */
417 <    public void testTimedPoll() {
418 <        try {
419 <            PriorityBlockingQueue q = populatedQueue(SIZE);
420 <            for (int i = 0; i < SIZE; ++i) {
421 <                assertEquals(i, ((Integer)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)).intValue());
422 <            }
488 <            assertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
489 <        } catch (InterruptedException e){
490 <            unexpectedException();
491 <        }  
417 >    public void testTimedPoll() throws InterruptedException {
418 >        PriorityBlockingQueue q = populatedQueue(SIZE);
419 >        for (int i = 0; i < SIZE; ++i) {
420 >            assertEquals(i, q.poll(SHORT_DELAY_MS, MILLISECONDS));
421 >        }
422 >        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
423      }
424  
425      /**
426       * Interrupted timed poll throws InterruptedException instead of
427       * returning timeout status
428       */
429 <    public void testInterruptedTimedPoll() {
430 <        Thread t = new Thread(new Runnable() {
431 <                public void run() {
432 <                    try {
433 <                        PriorityBlockingQueue q = populatedQueue(SIZE);
434 <                        for (int i = 0; i < SIZE; ++i) {
504 <                            threadAssertEquals(i, ((Integer)q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS)).intValue());
505 <                        }
506 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
507 <                    } catch (InterruptedException success){
508 <                    }  
509 <                }});
510 <        t.start();
511 <        try {
512 <           Thread.sleep(SHORT_DELAY_MS);
513 <           t.interrupt();
514 <           t.join();
515 <        }
516 <        catch (InterruptedException ie) {
517 <            unexpectedException();
518 <        }
519 <    }
520 <
521 <    /**
522 <     *  timed poll before a delayed offer fails; after offer succeeds;
523 <     *  on interruption throws
524 <     */
525 <    public void testTimedPollWithOffer() {
526 <        final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
527 <        Thread t = new Thread(new Runnable() {
528 <                public void run() {
529 <                    try {
530 <                        threadAssertNull(q.poll(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
531 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
532 <                        q.poll(LONG_DELAY_MS, TimeUnit.MILLISECONDS);
533 <                        threadShouldThrow();
534 <                    } catch (InterruptedException success) { }                
429 >    public void testInterruptedTimedPoll() throws InterruptedException {
430 >        Thread t = new Thread(new CheckedRunnable() {
431 >            public void realRun() throws InterruptedException {
432 >                PriorityBlockingQueue q = populatedQueue(SIZE);
433 >                for (int i = 0; i < SIZE; ++i) {
434 >                    assertEquals(i, q.poll(SHORT_DELAY_MS, MILLISECONDS));
435                  }
436 <            });
437 <        try {
438 <            t.start();
439 <            Thread.sleep(SMALL_DELAY_MS);
440 <            assertTrue(q.offer(new Integer(0), SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
541 <            t.interrupt();
542 <            t.join();
543 <        } catch (Exception e){
544 <            unexpectedException();
545 <        }
546 <    }  
436 >                try {
437 >                    q.poll(SMALL_DELAY_MS, MILLISECONDS);
438 >                    shouldThrow();
439 >                } catch (InterruptedException success) {}
440 >            }});
441  
442 +        t.start();
443 +        Thread.sleep(SHORT_DELAY_MS);
444 +        t.interrupt();
445 +        t.join();
446 +    }
447  
448      /**
449       * peek returns next element, or null if empty
# Line 552 | Line 451 | public class PriorityBlockingQueueTest e
451      public void testPeek() {
452          PriorityBlockingQueue q = populatedQueue(SIZE);
453          for (int i = 0; i < SIZE; ++i) {
454 <            assertEquals(i, ((Integer)q.peek()).intValue());
455 <            q.poll();
454 >            assertEquals(i, q.peek());
455 >            assertEquals(i, q.poll());
456              assertTrue(q.peek() == null ||
457 <                       i != ((Integer)q.peek()).intValue());
457 >                       !q.peek().equals(i));
458          }
459 <        assertNull(q.peek());
459 >        assertNull(q.peek());
460      }
461  
462      /**
# Line 566 | Line 465 | public class PriorityBlockingQueueTest e
465      public void testElement() {
466          PriorityBlockingQueue q = populatedQueue(SIZE);
467          for (int i = 0; i < SIZE; ++i) {
468 <            assertEquals(i, ((Integer)q.element()).intValue());
469 <            q.poll();
468 >            assertEquals(i, q.element());
469 >            assertEquals(i, q.poll());
470          }
471          try {
472              q.element();
473              shouldThrow();
474 <        }
576 <        catch (NoSuchElementException success) {}
474 >        } catch (NoSuchElementException success) {}
475      }
476  
477      /**
# Line 582 | Line 480 | public class PriorityBlockingQueueTest e
480      public void testRemove() {
481          PriorityBlockingQueue q = populatedQueue(SIZE);
482          for (int i = 0; i < SIZE; ++i) {
483 <            assertEquals(i, ((Integer)q.remove()).intValue());
483 >            assertEquals(i, q.remove());
484          }
485          try {
486              q.remove();
487              shouldThrow();
488 <        } catch (NoSuchElementException success){
591 <        }  
488 >        } catch (NoSuchElementException success) {}
489      }
490  
491      /**
# Line 605 | Line 502 | public class PriorityBlockingQueueTest e
502          }
503          assertTrue(q.isEmpty());
504      }
505 <        
505 >
506      /**
507       * contains(x) reports true when elements added but not yet removed
508       */
# Line 683 | Line 580 | public class PriorityBlockingQueueTest e
580      }
581  
582      /**
583 <     *  toArray contains all elements
583 >     * toArray contains all elements
584       */
585 <    public void testToArray() {
585 >    public void testToArray() throws InterruptedException {
586          PriorityBlockingQueue q = populatedQueue(SIZE);
587 <        Object[] o = q.toArray();
587 >        Object[] o = q.toArray();
588          Arrays.sort(o);
589 <        try {
590 <        for(int i = 0; i < o.length; i++)
694 <            assertEquals(o[i], q.take());
695 <        } catch (InterruptedException e){
696 <            unexpectedException();
697 <        }    
589 >        for (int i = 0; i < o.length; i++)
590 >            assertSame(o[i], q.take());
591      }
592  
593      /**
594       * toArray(a) contains all elements
595       */
596 <    public void testToArray2() {
597 <        PriorityBlockingQueue q = populatedQueue(SIZE);
598 <        Integer[] ints = new Integer[SIZE];
599 <        ints = (Integer[])q.toArray(ints);
596 >    public void testToArray2() throws InterruptedException {
597 >        PriorityBlockingQueue<Integer> q = populatedQueue(SIZE);
598 >        Integer[] ints = new Integer[SIZE];
599 >        Integer[] array = q.toArray(ints);
600 >        assertSame(ints, array);
601          Arrays.sort(ints);
602 <        try {
603 <            for(int i = 0; i < ints.length; i++)
710 <                assertEquals(ints[i], q.take());
711 <        } catch (InterruptedException e){
712 <            unexpectedException();
713 <        }    
602 >        for (int i = 0; i < ints.length; i++)
603 >            assertSame(ints[i], q.take());
604      }
605  
606      /**
607 <     * toArray(null) throws NPE
607 >     * toArray(null) throws NullPointerException
608       */
609 <    public void testToArray_BadArg() {
610 <        try {
611 <            PriorityBlockingQueue q = populatedQueue(SIZE);
612 <            Object o[] = q.toArray(null);
613 <            shouldThrow();
614 <        } catch(NullPointerException success){}
609 >    public void testToArray_NullArg() {
610 >        PriorityBlockingQueue q = populatedQueue(SIZE);
611 >        try {
612 >            q.toArray(null);
613 >            shouldThrow();
614 >        } catch (NullPointerException success) {}
615      }
616  
617      /**
618 <     * toArray with incompatible array type throws CCE
618 >     * toArray(incompatible array type) throws ArrayStoreException
619       */
620      public void testToArray1_BadArg() {
621 <        try {
622 <            PriorityBlockingQueue q = populatedQueue(SIZE);
623 <            Object o[] = q.toArray(new String[10] );
624 <            shouldThrow();
625 <        } catch(ArrayStoreException  success){}
621 >        PriorityBlockingQueue q = populatedQueue(SIZE);
622 >        try {
623 >            q.toArray(new String[10]);
624 >            shouldThrow();
625 >        } catch (ArrayStoreException success) {}
626      }
627 <    
627 >
628      /**
629       * iterator iterates through all elements
630       */
631      public void testIterator() {
632          PriorityBlockingQueue q = populatedQueue(SIZE);
633          int i = 0;
634 <        Iterator it = q.iterator();
635 <        while(it.hasNext()) {
634 >        Iterator it = q.iterator();
635 >        while (it.hasNext()) {
636              assertTrue(q.contains(it.next()));
637              ++i;
638          }
# Line 752 | Line 642 | public class PriorityBlockingQueueTest e
642      /**
643       * iterator.remove removes current element
644       */
645 <    public void testIteratorRemove () {
645 >    public void testIteratorRemove() {
646          final PriorityBlockingQueue q = new PriorityBlockingQueue(3);
647          q.add(new Integer(2));
648          q.add(new Integer(1));
# Line 778 | Line 668 | public class PriorityBlockingQueueTest e
668          for (int i = 0; i < SIZE; ++i) {
669              assertTrue(s.indexOf(String.valueOf(i)) >= 0);
670          }
671 <    }        
671 >    }
672  
673      /**
674       * offer transfers elements across Executor tasks
# Line 786 | Line 676 | public class PriorityBlockingQueueTest e
676      public void testPollInExecutor() {
677          final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
678          ExecutorService executor = Executors.newFixedThreadPool(2);
679 <        executor.execute(new Runnable() {
680 <            public void run() {
681 <                threadAssertNull(q.poll());
682 <                try {
683 <                    threadAssertTrue(null != q.poll(MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS));
684 <                    threadAssertTrue(q.isEmpty());
685 <                }
686 <                catch (InterruptedException e) {
687 <                    threadUnexpectedException();
688 <                }
689 <            }
690 <        });
679 >        executor.execute(new CheckedRunnable() {
680 >            public void realRun() throws InterruptedException {
681 >                assertNull(q.poll());
682 >                assertSame(one, q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
683 >                assertTrue(q.isEmpty());
684 >            }});
685 >
686 >        executor.execute(new CheckedRunnable() {
687 >            public void realRun() throws InterruptedException {
688 >                Thread.sleep(SMALL_DELAY_MS);
689 >                q.put(one);
690 >            }});
691  
802        executor.execute(new Runnable() {
803            public void run() {
804                try {
805                    Thread.sleep(SMALL_DELAY_MS);
806                    q.put(new Integer(1));
807                }
808                catch (InterruptedException e) {
809                    threadUnexpectedException();
810                }
811            }
812        });
813        
692          joinPool(executor);
693      }
694  
695      /**
696 <     * A deserialized serialized queue has same elements
696 >     * A deserialized serialized queue has same elements
697       */
698 <    public void testSerialization() {
698 >    public void testSerialization() throws Exception {
699          PriorityBlockingQueue q = populatedQueue(SIZE);
700 <        try {
701 <            ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
702 <            ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
703 <            out.writeObject(q);
704 <            out.close();
705 <
706 <            ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
707 <            ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
708 <            PriorityBlockingQueue r = (PriorityBlockingQueue)in.readObject();
709 <            assertEquals(q.size(), r.size());
710 <            while (!q.isEmpty())
833 <                assertEquals(q.remove(), r.remove());
834 <        } catch(Exception e){
835 <            unexpectedException();
836 <        }
700 >        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
701 >        ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
702 >        out.writeObject(q);
703 >        out.close();
704 >
705 >        ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
706 >        ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
707 >        PriorityBlockingQueue r = (PriorityBlockingQueue)in.readObject();
708 >        assertEquals(q.size(), r.size());
709 >        while (!q.isEmpty())
710 >            assertEquals(q.remove(), r.remove());
711      }
712  
713      /**
714       * drainTo(null) throws NPE
715 <     */
715 >     */
716      public void testDrainToNull() {
717          PriorityBlockingQueue q = populatedQueue(SIZE);
718          try {
719              q.drainTo(null);
720              shouldThrow();
721 <        } catch(NullPointerException success) {
848 <        }
721 >        } catch (NullPointerException success) {}
722      }
723  
724      /**
725       * drainTo(this) throws IAE
726 <     */
726 >     */
727      public void testDrainToSelf() {
728          PriorityBlockingQueue q = populatedQueue(SIZE);
729          try {
730              q.drainTo(q);
731              shouldThrow();
732 <        } catch(IllegalArgumentException success) {
860 <        }
732 >        } catch (IllegalArgumentException success) {}
733      }
734  
735      /**
736       * drainTo(c) empties queue into another collection c
737 <     */
737 >     */
738      public void testDrainTo() {
739          PriorityBlockingQueue q = populatedQueue(SIZE);
740          ArrayList l = new ArrayList();
741          q.drainTo(l);
742          assertEquals(q.size(), 0);
743          assertEquals(l.size(), SIZE);
744 <        for (int i = 0; i < SIZE; ++i)
744 >        for (int i = 0; i < SIZE; ++i)
745              assertEquals(l.get(i), new Integer(i));
746          q.add(zero);
747          q.add(one);
# Line 880 | Line 752 | public class PriorityBlockingQueueTest e
752          q.drainTo(l);
753          assertEquals(q.size(), 0);
754          assertEquals(l.size(), 2);
755 <        for (int i = 0; i < 2; ++i)
755 >        for (int i = 0; i < 2; ++i)
756              assertEquals(l.get(i), new Integer(i));
757      }
758  
759      /**
760       * drainTo empties queue
761 <     */
762 <    public void testDrainToWithActivePut() {
761 >     */
762 >    public void testDrainToWithActivePut() throws InterruptedException {
763          final PriorityBlockingQueue q = populatedQueue(SIZE);
764 <        Thread t = new Thread(new Runnable() {
765 <                public void run() {
766 <                    q.put(new Integer(SIZE+1));
767 <                }
768 <            });
769 <        try {
770 <            t.start();
771 <            ArrayList l = new ArrayList();
772 <            q.drainTo(l);
773 <            assertTrue(l.size() >= SIZE);
774 <            for (int i = 0; i < SIZE; ++i)
775 <                assertEquals(l.get(i), new Integer(i));
776 <            t.join();
905 <            assertTrue(q.size() + l.size() >= SIZE);
906 <        } catch(Exception e){
907 <            unexpectedException();
908 <        }
764 >        Thread t = new Thread(new CheckedRunnable() {
765 >            public void realRun() {
766 >                q.put(new Integer(SIZE+1));
767 >            }});
768 >
769 >        t.start();
770 >        ArrayList l = new ArrayList();
771 >        q.drainTo(l);
772 >        assertTrue(l.size() >= SIZE);
773 >        for (int i = 0; i < SIZE; ++i)
774 >            assertEquals(l.get(i), new Integer(i));
775 >        t.join();
776 >        assertTrue(q.size() + l.size() >= SIZE);
777      }
778  
779      /**
780       * drainTo(null, n) throws NPE
781 <     */
781 >     */
782      public void testDrainToNullN() {
783          PriorityBlockingQueue q = populatedQueue(SIZE);
784          try {
785              q.drainTo(null, 0);
786              shouldThrow();
787 <        } catch(NullPointerException success) {
920 <        }
787 >        } catch (NullPointerException success) {}
788      }
789  
790      /**
791       * drainTo(this, n) throws IAE
792 <     */
792 >     */
793      public void testDrainToSelfN() {
794          PriorityBlockingQueue q = populatedQueue(SIZE);
795          try {
796              q.drainTo(q, 0);
797              shouldThrow();
798 <        } catch(IllegalArgumentException success) {
932 <        }
798 >        } catch (IllegalArgumentException success) {}
799      }
800  
801      /**
802 <     * drainTo(c, n) empties first max {n, size} elements of queue into c
803 <     */
802 >     * drainTo(c, n) empties first min(n, size) elements of queue into c
803 >     */
804      public void testDrainToN() {
805          PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE*2);
806          for (int i = 0; i < SIZE + 2; ++i) {
807 <            for(int j = 0; j < SIZE; j++)
807 >            for (int j = 0; j < SIZE; j++)
808                  assertTrue(q.offer(new Integer(j)));
809              ArrayList l = new ArrayList();
810              q.drainTo(l, i);
811 <            int k = (i < SIZE)? i : SIZE;
811 >            int k = (i < SIZE) ? i : SIZE;
812              assertEquals(l.size(), k);
813              assertEquals(q.size(), SIZE-k);
814 <            for (int j = 0; j < k; ++j)
814 >            for (int j = 0; j < k; ++j)
815                  assertEquals(l.get(j), new Integer(j));
816              while (q.poll() != null) ;
817          }
818      }
819  
954
820   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines