ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/PriorityBlockingQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/PriorityBlockingQueueTest.java (file contents):
Revision 1.43 by dl, Fri May 6 11:22:07 2011 UTC vs.
Revision 1.65 by jsr166, Sun Oct 4 18:49:02 2015 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 import junit.framework.*;
10 import java.util.*;
11 import java.util.concurrent.*;
9   import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 < import java.io.*;
10 >
11 > import java.util.ArrayList;
12 > import java.util.Arrays;
13 > import java.util.Collection;
14 > import java.util.Comparator;
15 > import java.util.Iterator;
16 > import java.util.NoSuchElementException;
17 > import java.util.Queue;
18 > import java.util.concurrent.BlockingQueue;
19 > import java.util.concurrent.CountDownLatch;
20 > import java.util.concurrent.Executors;
21 > import java.util.concurrent.ExecutorService;
22 > import java.util.concurrent.PriorityBlockingQueue;
23 >
24 > import junit.framework.Test;
25  
26   public class PriorityBlockingQueueTest extends JSR166TestCase {
27  
# Line 22 | Line 33 | public class PriorityBlockingQueueTest e
33  
34      public static class InitialCapacity extends BlockingQueueTest {
35          protected BlockingQueue emptyCollection() {
36 <            return new PriorityBlockingQueue(20);
36 >            return new PriorityBlockingQueue(SIZE);
37          }
38      }
39  
40      public static void main(String[] args) {
41 <        junit.textui.TestRunner.run(suite());
41 >        main(suite(), args);
42      }
43  
44      public static Test suite() {
# Line 36 | Line 47 | public class PriorityBlockingQueueTest e
47                              new InitialCapacity().testSuite());
48      }
49  
39    private static final int NOCAP = Integer.MAX_VALUE;
40
50      /** Sample Comparator */
51      static class MyReverseComparator implements Comparator {
52          public int compare(Object x, Object y) {
# Line 46 | Line 55 | public class PriorityBlockingQueueTest e
55      }
56  
57      /**
58 <     * Create a queue of given size containing consecutive
58 >     * Returns a new queue of given size containing consecutive
59       * Integers 0 ... n.
60       */
61      private PriorityBlockingQueue<Integer> populatedQueue(int n) {
62          PriorityBlockingQueue<Integer> q =
63              new PriorityBlockingQueue<Integer>(n);
64          assertTrue(q.isEmpty());
65 <        for (int i = n-1; i >= 0; i-=2)
65 >        for (int i = n - 1; i >= 0; i -= 2)
66              assertTrue(q.offer(new Integer(i)));
67 <        for (int i = (n & 1); i < n; i+=2)
67 >        for (int i = (n & 1); i < n; i += 2)
68              assertTrue(q.offer(new Integer(i)));
69          assertFalse(q.isEmpty());
70 <        assertEquals(NOCAP, q.remainingCapacity());
70 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
71          assertEquals(n, q.size());
72          return q;
73      }
# Line 67 | Line 76 | public class PriorityBlockingQueueTest e
76       * A new queue has unbounded capacity
77       */
78      public void testConstructor1() {
79 <        assertEquals(NOCAP, new PriorityBlockingQueue(SIZE).remainingCapacity());
79 >        assertEquals(Integer.MAX_VALUE,
80 >                     new PriorityBlockingQueue(SIZE).remainingCapacity());
81      }
82  
83      /**
# Line 75 | Line 85 | public class PriorityBlockingQueueTest e
85       */
86      public void testConstructor2() {
87          try {
88 <            PriorityBlockingQueue q = new PriorityBlockingQueue(0);
88 >            new PriorityBlockingQueue(0);
89              shouldThrow();
90          } catch (IllegalArgumentException success) {}
91      }
# Line 85 | Line 95 | public class PriorityBlockingQueueTest e
95       */
96      public void testConstructor3() {
97          try {
98 <            PriorityBlockingQueue q = new PriorityBlockingQueue(null);
98 >            new PriorityBlockingQueue(null);
99              shouldThrow();
100          } catch (NullPointerException success) {}
101      }
# Line 94 | Line 104 | public class PriorityBlockingQueueTest e
104       * Initializing from Collection of null elements throws NPE
105       */
106      public void testConstructor4() {
107 +        Collection<Integer> elements = Arrays.asList(new Integer[SIZE]);
108          try {
109 <            Integer[] ints = new Integer[SIZE];
99 <            PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
109 >            new PriorityBlockingQueue(elements);
110              shouldThrow();
111          } catch (NullPointerException success) {}
112      }
# Line 105 | Line 115 | public class PriorityBlockingQueueTest e
115       * Initializing from Collection with some null elements throws NPE
116       */
117      public void testConstructor5() {
118 +        Integer[] ints = new Integer[SIZE];
119 +        for (int i = 0; i < SIZE - 1; ++i)
120 +            ints[i] = i;
121 +        Collection<Integer> elements = Arrays.asList(ints);
122          try {
123 <            Integer[] ints = new Integer[SIZE];
110 <            for (int i = 0; i < SIZE-1; ++i)
111 <                ints[i] = new Integer(i);
112 <            PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
123 >            new PriorityBlockingQueue(elements);
124              shouldThrow();
125          } catch (NullPointerException success) {}
126      }
# Line 120 | Line 131 | public class PriorityBlockingQueueTest e
131      public void testConstructor6() {
132          Integer[] ints = new Integer[SIZE];
133          for (int i = 0; i < SIZE; ++i)
134 <            ints[i] = new Integer(i);
134 >            ints[i] = i;
135          PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
136          for (int i = 0; i < SIZE; ++i)
137              assertEquals(ints[i], q.poll());
# Line 137 | Line 148 | public class PriorityBlockingQueueTest e
148          for (int i = 0; i < SIZE; ++i)
149              ints[i] = new Integer(i);
150          q.addAll(Arrays.asList(ints));
151 <        for (int i = SIZE-1; i >= 0; --i)
151 >        for (int i = SIZE - 1; i >= 0; --i)
152              assertEquals(ints[i], q.poll());
153      }
154  
# Line 147 | Line 158 | public class PriorityBlockingQueueTest e
158      public void testEmpty() {
159          PriorityBlockingQueue q = new PriorityBlockingQueue(2);
160          assertTrue(q.isEmpty());
161 <        assertEquals(NOCAP, q.remainingCapacity());
161 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
162          q.add(one);
163          assertFalse(q.isEmpty());
164          q.add(two);
# Line 157 | Line 168 | public class PriorityBlockingQueueTest e
168      }
169  
170      /**
171 <     * remainingCapacity does not change when elements added or removed,
161 <     * but size does
171 >     * remainingCapacity() always returns Integer.MAX_VALUE
172       */
173      public void testRemainingCapacity() {
174 <        PriorityBlockingQueue q = populatedQueue(SIZE);
174 >        BlockingQueue q = populatedQueue(SIZE);
175          for (int i = 0; i < SIZE; ++i) {
176 <            assertEquals(NOCAP, q.remainingCapacity());
177 <            assertEquals(SIZE-i, q.size());
178 <            q.remove();
176 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
177 >            assertEquals(SIZE - i, q.size());
178 >            assertEquals(i, q.remove());
179          }
180          for (int i = 0; i < SIZE; ++i) {
181 <            assertEquals(NOCAP, q.remainingCapacity());
181 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
182              assertEquals(i, q.size());
183 <            q.add(new Integer(i));
183 >            assertTrue(q.add(i));
184          }
185      }
186  
187      /**
178     * offer(null) throws NPE
179     */
180    public void testOfferNull() {
181        try {
182            PriorityBlockingQueue q = new PriorityBlockingQueue(1);
183            q.offer(null);
184            shouldThrow();
185        } catch (NullPointerException success) {}
186    }
187
188    /**
189     * add(null) throws NPE
190     */
191    public void testAddNull() {
192        try {
193            PriorityBlockingQueue q = new PriorityBlockingQueue(1);
194            q.add(null);
195            shouldThrow();
196        } catch (NullPointerException success) {}
197    }
198
199    /**
188       * Offer of comparable element succeeds
189       */
190      public void testOffer() {
# Line 209 | Line 197 | public class PriorityBlockingQueueTest e
197       * Offer of non-Comparable throws CCE
198       */
199      public void testOfferNonComparable() {
200 +        PriorityBlockingQueue q = new PriorityBlockingQueue(1);
201          try {
213            PriorityBlockingQueue q = new PriorityBlockingQueue(1);
214            q.offer(new Object());
202              q.offer(new Object());
203              q.offer(new Object());
204              shouldThrow();
# Line 230 | Line 217 | public class PriorityBlockingQueueTest e
217      }
218  
219      /**
233     * addAll(null) throws NPE
234     */
235    public void testAddAll1() {
236        try {
237            PriorityBlockingQueue q = new PriorityBlockingQueue(1);
238            q.addAll(null);
239            shouldThrow();
240        } catch (NullPointerException success) {}
241    }
242
243    /**
220       * addAll(this) throws IAE
221       */
222      public void testAddAllSelf() {
223 +        PriorityBlockingQueue q = populatedQueue(SIZE);
224          try {
248            PriorityBlockingQueue q = populatedQueue(SIZE);
225              q.addAll(q);
226              shouldThrow();
227          } catch (IllegalArgumentException success) {}
228      }
229  
230      /**
255     * addAll of a collection with null elements throws NPE
256     */
257    public void testAddAll2() {
258        try {
259            PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
260            Integer[] ints = new Integer[SIZE];
261            q.addAll(Arrays.asList(ints));
262            shouldThrow();
263        } catch (NullPointerException success) {}
264    }
265
266    /**
231       * addAll of a collection with any null elements throws NPE after
232       * possibly adding some elements
233       */
234      public void testAddAll3() {
235 +        PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
236 +        Integer[] ints = new Integer[SIZE];
237 +        for (int i = 0; i < SIZE - 1; ++i)
238 +            ints[i] = new Integer(i);
239          try {
272            PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
273            Integer[] ints = new Integer[SIZE];
274            for (int i = 0; i < SIZE-1; ++i)
275                ints[i] = new Integer(i);
240              q.addAll(Arrays.asList(ints));
241              shouldThrow();
242          } catch (NullPointerException success) {}
# Line 284 | Line 248 | public class PriorityBlockingQueueTest e
248      public void testAddAll5() {
249          Integer[] empty = new Integer[0];
250          Integer[] ints = new Integer[SIZE];
251 <        for (int i = SIZE-1; i >= 0; --i)
251 >        for (int i = SIZE - 1; i >= 0; --i)
252              ints[i] = new Integer(i);
253          PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
254          assertFalse(q.addAll(Arrays.asList(empty)));
# Line 294 | Line 258 | public class PriorityBlockingQueueTest e
258      }
259  
260      /**
297     * put(null) throws NPE
298     */
299    public void testPutNull() {
300        try {
301            PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
302            q.put(null);
303            shouldThrow();
304        } catch (NullPointerException success) {}
305    }
306
307    /**
261       * all elements successfully put are contained
262       */
263      public void testPut() {
264          PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
265          for (int i = 0; i < SIZE; ++i) {
266 <            Integer I = new Integer(i);
267 <            q.put(I);
268 <            assertTrue(q.contains(I));
266 >            Integer x = new Integer(i);
267 >            q.put(x);
268 >            assertTrue(q.contains(x));
269          }
270          assertEquals(SIZE, q.size());
271      }
# Line 323 | Line 276 | public class PriorityBlockingQueueTest e
276      public void testPutWithTake() throws InterruptedException {
277          final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
278          final int size = 4;
279 <        Thread t = new Thread(new CheckedRunnable() {
279 >        Thread t = newStartedThread(new CheckedRunnable() {
280              public void realRun() {
281                  for (int i = 0; i < size; i++)
282                      q.put(new Integer(0));
283              }});
284  
285 <        t.start();
286 <        delay(SHORT_DELAY_MS);
334 <        assertEquals(q.size(), size);
285 >        awaitTermination(t);
286 >        assertEquals(size, q.size());
287          q.take();
336        t.interrupt();
337        t.join();
288      }
289  
290      /**
# Line 342 | Line 292 | public class PriorityBlockingQueueTest e
292       */
293      public void testTimedOffer() throws InterruptedException {
294          final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
295 <        Thread t = new Thread(new CheckedRunnable() {
295 >        Thread t = newStartedThread(new CheckedRunnable() {
296              public void realRun() {
297                  q.put(new Integer(0));
298                  q.put(new Integer(0));
# Line 350 | Line 300 | public class PriorityBlockingQueueTest e
300                  assertTrue(q.offer(new Integer(0), LONG_DELAY_MS, MILLISECONDS));
301              }});
302  
303 <        t.start();
354 <        delay(SMALL_DELAY_MS);
355 <        t.interrupt();
356 <        t.join();
303 >        awaitTermination(t);
304      }
305  
306      /**
# Line 371 | Line 318 | public class PriorityBlockingQueueTest e
318       */
319      public void testBlockingTake() throws InterruptedException {
320          final PriorityBlockingQueue q = populatedQueue(SIZE);
321 <        Thread t = new Thread(new CheckedRunnable() {
321 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
322 >        Thread t = newStartedThread(new CheckedRunnable() {
323              public void realRun() throws InterruptedException {
324                  for (int i = 0; i < SIZE; ++i) {
325                      assertEquals(i, q.take());
326                  }
327 +
328 +                Thread.currentThread().interrupt();
329                  try {
330                      q.take();
331                      shouldThrow();
332                  } catch (InterruptedException success) {}
333 +                assertFalse(Thread.interrupted());
334 +
335 +                pleaseInterrupt.countDown();
336 +                try {
337 +                    q.take();
338 +                    shouldThrow();
339 +                } catch (InterruptedException success) {}
340 +                assertFalse(Thread.interrupted());
341              }});
342  
343 <        t.start();
344 <        delay(SHORT_DELAY_MS);
343 >        await(pleaseInterrupt);
344 >        assertThreadStaysAlive(t);
345          t.interrupt();
346 <        t.join();
346 >        awaitTermination(t);
347      }
348  
391
349      /**
350       * poll succeeds unless empty
351       */
# Line 415 | Line 372 | public class PriorityBlockingQueueTest e
372       * timed poll with nonzero timeout succeeds when non-empty, else times out
373       */
374      public void testTimedPoll() throws InterruptedException {
375 <        PriorityBlockingQueue q = populatedQueue(SIZE);
375 >        PriorityBlockingQueue<Integer> q = populatedQueue(SIZE);
376          for (int i = 0; i < SIZE; ++i) {
377 <            assertEquals(i, q.poll(SHORT_DELAY_MS, MILLISECONDS));
378 <        }
379 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
377 >            long startTime = System.nanoTime();
378 >            assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
379 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
380 >        }
381 >        long startTime = System.nanoTime();
382 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
383 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
384 >        checkEmpty(q);
385      }
386  
387      /**
# Line 439 | Line 401 | public class PriorityBlockingQueueTest e
401                  long t0 = System.nanoTime();
402                  aboutToWait.countDown();
403                  try {
404 <                    q.poll(MEDIUM_DELAY_MS, MILLISECONDS);
404 >                    q.poll(LONG_DELAY_MS, MILLISECONDS);
405                      shouldThrow();
406                  } catch (InterruptedException success) {
407                      assertTrue(millisElapsedSince(t0) < MEDIUM_DELAY_MS);
# Line 496 | Line 458 | public class PriorityBlockingQueueTest e
458      }
459  
460      /**
499     * remove(x) removes x and returns true if present
500     */
501    public void testRemoveElement() {
502        PriorityBlockingQueue q = populatedQueue(SIZE);
503        for (int i = 1; i < SIZE; i+=2) {
504            assertTrue(q.contains(i));
505            assertTrue(q.remove(i));
506            assertFalse(q.contains(i));
507            assertTrue(q.contains(i-1));
508        }
509        for (int i = 0; i < SIZE; i+=2) {
510            assertTrue(q.contains(i));
511            assertTrue(q.remove(i));
512            assertFalse(q.contains(i));
513            assertFalse(q.remove(i+1));
514            assertFalse(q.contains(i+1));
515        }
516        assertTrue(q.isEmpty());
517    }
518
519    /**
461       * contains(x) reports true when elements added but not yet removed
462       */
463      public void testContains() {
# Line 571 | Line 512 | public class PriorityBlockingQueueTest e
512                  assertTrue(changed);
513  
514              assertTrue(q.containsAll(p));
515 <            assertEquals(SIZE-i, q.size());
515 >            assertEquals(SIZE - i, q.size());
516              p.remove();
517          }
518      }
# Line 584 | Line 525 | public class PriorityBlockingQueueTest e
525              PriorityBlockingQueue q = populatedQueue(SIZE);
526              PriorityBlockingQueue p = populatedQueue(i);
527              assertTrue(q.removeAll(p));
528 <            assertEquals(SIZE-i, q.size());
528 >            assertEquals(SIZE - i, q.size());
529              for (int j = 0; j < i; ++j) {
530 <                Integer I = (Integer)(p.remove());
531 <                assertFalse(q.contains(I));
530 >                Integer x = (Integer)(p.remove());
531 >                assertFalse(q.contains(x));
532              }
533          }
534      }
# Line 617 | Line 558 | public class PriorityBlockingQueueTest e
558      }
559  
560      /**
620     * toArray(null) throws NullPointerException
621     */
622    public void testToArray_NullArg() {
623        PriorityBlockingQueue q = populatedQueue(SIZE);
624        try {
625            q.toArray(null);
626            shouldThrow();
627        } catch (NullPointerException success) {}
628    }
629
630    /**
561       * toArray(incompatible array type) throws ArrayStoreException
562       */
563      public void testToArray1_BadArg() {
# Line 643 | Line 573 | public class PriorityBlockingQueueTest e
573       */
574      public void testIterator() {
575          PriorityBlockingQueue q = populatedQueue(SIZE);
646        int i = 0;
576          Iterator it = q.iterator();
577 <        while (it.hasNext()) {
577 >        int i;
578 >        for (i = 0; it.hasNext(); i++)
579              assertTrue(q.contains(it.next()));
650            ++i;
651        }
580          assertEquals(i, SIZE);
581 +        assertIteratorExhausted(it);
582 +    }
583 +
584 +    /**
585 +     * iterator of empty collection has no elements
586 +     */
587 +    public void testEmptyIterator() {
588 +        assertIteratorExhausted(new PriorityBlockingQueue().iterator());
589      }
590  
591      /**
# Line 671 | Line 607 | public class PriorityBlockingQueueTest e
607          assertFalse(it.hasNext());
608      }
609  
674
610      /**
611       * toString contains toStrings of elements
612       */
# Line 679 | Line 614 | public class PriorityBlockingQueueTest e
614          PriorityBlockingQueue q = populatedQueue(SIZE);
615          String s = q.toString();
616          for (int i = 0; i < SIZE; ++i) {
617 <            assertTrue(s.indexOf(String.valueOf(i)) >= 0);
617 >            assertTrue(s.contains(String.valueOf(i)));
618          }
619      }
620  
621      /**
622 <     * offer transfers elements across Executor tasks
622 >     * timed poll transfers elements across Executor tasks
623       */
624      public void testPollInExecutor() {
625          final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
626 <        ExecutorService executor = Executors.newFixedThreadPool(2);
627 <        executor.execute(new CheckedRunnable() {
628 <            public void realRun() throws InterruptedException {
629 <                assertNull(q.poll());
630 <                assertSame(one, q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
631 <                assertTrue(q.isEmpty());
632 <            }});
633 <
634 <        executor.execute(new CheckedRunnable() {
635 <            public void realRun() throws InterruptedException {
636 <                delay(SMALL_DELAY_MS);
637 <                q.put(one);
638 <            }});
639 <
640 <        joinPool(executor);
626 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
627 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
628 >        try (PoolCleaner cleaner = cleaner(executor)) {
629 >            executor.execute(new CheckedRunnable() {
630 >                public void realRun() throws InterruptedException {
631 >                    assertNull(q.poll());
632 >                    threadsStarted.await();
633 >                    assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
634 >                    checkEmpty(q);
635 >                }});
636 >
637 >            executor.execute(new CheckedRunnable() {
638 >                public void realRun() throws InterruptedException {
639 >                    threadsStarted.await();
640 >                    q.put(one);
641 >                }});
642 >        }
643      }
644  
645      /**
646       * A deserialized serialized queue has same elements
647       */
648      public void testSerialization() throws Exception {
649 <        PriorityBlockingQueue q = populatedQueue(SIZE);
650 <        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
714 <        ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
715 <        out.writeObject(q);
716 <        out.close();
717 <
718 <        ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
719 <        ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
720 <        PriorityBlockingQueue r = (PriorityBlockingQueue)in.readObject();
721 <        assertEquals(q.size(), r.size());
722 <        while (!q.isEmpty())
723 <            assertEquals(q.remove(), r.remove());
724 <    }
725 <
726 <    /**
727 <     * drainTo(null) throws NPE
728 <     */
729 <    public void testDrainToNull() {
730 <        PriorityBlockingQueue q = populatedQueue(SIZE);
731 <        try {
732 <            q.drainTo(null);
733 <            shouldThrow();
734 <        } catch (NullPointerException success) {}
735 <    }
649 >        Queue x = populatedQueue(SIZE);
650 >        Queue y = serialClone(x);
651  
652 <    /**
653 <     * drainTo(this) throws IAE
654 <     */
655 <    public void testDrainToSelf() {
656 <        PriorityBlockingQueue q = populatedQueue(SIZE);
657 <        try {
658 <            q.drainTo(q);
744 <            shouldThrow();
745 <        } catch (IllegalArgumentException success) {}
652 >        assertNotSame(x, y);
653 >        assertEquals(x.size(), y.size());
654 >        while (!x.isEmpty()) {
655 >            assertFalse(y.isEmpty());
656 >            assertEquals(x.remove(), y.remove());
657 >        }
658 >        assertTrue(y.isEmpty());
659      }
660  
661      /**
# Line 752 | Line 665 | public class PriorityBlockingQueueTest e
665          PriorityBlockingQueue q = populatedQueue(SIZE);
666          ArrayList l = new ArrayList();
667          q.drainTo(l);
668 <        assertEquals(q.size(), 0);
669 <        assertEquals(l.size(), SIZE);
668 >        assertEquals(0, q.size());
669 >        assertEquals(SIZE, l.size());
670          for (int i = 0; i < SIZE; ++i)
671              assertEquals(l.get(i), new Integer(i));
672          q.add(zero);
# Line 763 | Line 676 | public class PriorityBlockingQueueTest e
676          assertTrue(q.contains(one));
677          l.clear();
678          q.drainTo(l);
679 <        assertEquals(q.size(), 0);
680 <        assertEquals(l.size(), 2);
679 >        assertEquals(0, q.size());
680 >        assertEquals(2, l.size());
681          for (int i = 0; i < 2; ++i)
682              assertEquals(l.get(i), new Integer(i));
683      }
# Line 776 | Line 689 | public class PriorityBlockingQueueTest e
689          final PriorityBlockingQueue q = populatedQueue(SIZE);
690          Thread t = new Thread(new CheckedRunnable() {
691              public void realRun() {
692 <                q.put(new Integer(SIZE+1));
692 >                q.put(new Integer(SIZE + 1));
693              }});
694  
695          t.start();
# Line 790 | Line 703 | public class PriorityBlockingQueueTest e
703      }
704  
705      /**
793     * drainTo(null, n) throws NPE
794     */
795    public void testDrainToNullN() {
796        PriorityBlockingQueue q = populatedQueue(SIZE);
797        try {
798            q.drainTo(null, 0);
799            shouldThrow();
800        } catch (NullPointerException success) {}
801    }
802
803    /**
804     * drainTo(this, n) throws IAE
805     */
806    public void testDrainToSelfN() {
807        PriorityBlockingQueue q = populatedQueue(SIZE);
808        try {
809            q.drainTo(q, 0);
810            shouldThrow();
811        } catch (IllegalArgumentException success) {}
812    }
813
814    /**
706       * drainTo(c, n) empties first min(n, size) elements of queue into c
707       */
708      public void testDrainToN() {
709 <        PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE*2);
709 >        PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE * 2);
710          for (int i = 0; i < SIZE + 2; ++i) {
711              for (int j = 0; j < SIZE; j++)
712                  assertTrue(q.offer(new Integer(j)));
713              ArrayList l = new ArrayList();
714              q.drainTo(l, i);
715              int k = (i < SIZE) ? i : SIZE;
716 <            assertEquals(l.size(), k);
717 <            assertEquals(q.size(), SIZE-k);
716 >            assertEquals(k, l.size());
717 >            assertEquals(SIZE - k, q.size());
718              for (int j = 0; j < k; ++j)
719                  assertEquals(l.get(j), new Integer(j));
720 <            while (q.poll() != null) ;
720 >            do {} while (q.poll() != null);
721 >        }
722 >    }
723 >
724 >    /**
725 >     * remove(null), contains(null) always return false
726 >     */
727 >    public void testNeverContainsNull() {
728 >        Collection<?>[] qs = {
729 >            new PriorityBlockingQueue<Object>(),
730 >            populatedQueue(2),
731 >        };
732 >
733 >        for (Collection<?> q : qs) {
734 >            assertFalse(q.contains(null));
735 >            assertFalse(q.remove(null));
736          }
737      }
738  

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines