ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/PriorityBlockingQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/PriorityBlockingQueueTest.java (file contents):
Revision 1.54 by jsr166, Wed Dec 31 19:05:43 2014 UTC vs.
Revision 1.60 by jsr166, Sat Feb 28 20:13:46 2015 UTC

# Line 47 | Line 47 | public class PriorityBlockingQueueTest e
47                              new InitialCapacity().testSuite());
48      }
49  
50 –    private static final int NOCAP = Integer.MAX_VALUE;
51 –
50      /** Sample Comparator */
51      static class MyReverseComparator implements Comparator {
52          public int compare(Object x, Object y) {
# Line 64 | Line 62 | public class PriorityBlockingQueueTest e
62          PriorityBlockingQueue<Integer> q =
63              new PriorityBlockingQueue<Integer>(n);
64          assertTrue(q.isEmpty());
65 <        for (int i = n-1; i >= 0; i-=2)
65 >        for (int i = n-1; i >= 0; i -= 2)
66              assertTrue(q.offer(new Integer(i)));
67 <        for (int i = (n & 1); i < n; i+=2)
67 >        for (int i = (n & 1); i < n; i += 2)
68              assertTrue(q.offer(new Integer(i)));
69          assertFalse(q.isEmpty());
70 <        assertEquals(NOCAP, q.remainingCapacity());
70 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
71          assertEquals(n, q.size());
72          return q;
73      }
# Line 78 | Line 76 | public class PriorityBlockingQueueTest e
76       * A new queue has unbounded capacity
77       */
78      public void testConstructor1() {
79 <        assertEquals(NOCAP, new PriorityBlockingQueue(SIZE).remainingCapacity());
79 >        assertEquals(Integer.MAX_VALUE,
80 >                     new PriorityBlockingQueue(SIZE).remainingCapacity());
81      }
82  
83      /**
# Line 159 | Line 158 | public class PriorityBlockingQueueTest e
158      public void testEmpty() {
159          PriorityBlockingQueue q = new PriorityBlockingQueue(2);
160          assertTrue(q.isEmpty());
161 <        assertEquals(NOCAP, q.remainingCapacity());
161 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
162          q.add(one);
163          assertFalse(q.isEmpty());
164          q.add(two);
# Line 169 | Line 168 | public class PriorityBlockingQueueTest e
168      }
169  
170      /**
171 <     * remainingCapacity does not change when elements added or removed,
173 <     * but size does
171 >     * remainingCapacity() always returns Integer.MAX_VALUE
172       */
173      public void testRemainingCapacity() {
174 <        PriorityBlockingQueue q = populatedQueue(SIZE);
174 >        BlockingQueue q = populatedQueue(SIZE);
175          for (int i = 0; i < SIZE; ++i) {
176 <            assertEquals(NOCAP, q.remainingCapacity());
177 <            assertEquals(SIZE-i, q.size());
178 <            q.remove();
176 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
177 >            assertEquals(SIZE - i, q.size());
178 >            assertEquals(i, q.remove());
179          }
180          for (int i = 0; i < SIZE; ++i) {
181 <            assertEquals(NOCAP, q.remainingCapacity());
181 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
182              assertEquals(i, q.size());
183 <            q.add(new Integer(i));
183 >            assertTrue(q.add(i));
184          }
185      }
186  
# Line 199 | Line 197 | public class PriorityBlockingQueueTest e
197       * Offer of non-Comparable throws CCE
198       */
199      public void testOfferNonComparable() {
200 +        PriorityBlockingQueue q = new PriorityBlockingQueue(1);
201          try {
203 –            PriorityBlockingQueue q = new PriorityBlockingQueue(1);
204 –            q.offer(new Object());
202              q.offer(new Object());
203              q.offer(new Object());
204              shouldThrow();
# Line 266 | Line 263 | public class PriorityBlockingQueueTest e
263      public void testPut() {
264          PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
265          for (int i = 0; i < SIZE; ++i) {
266 <            Integer I = new Integer(i);
267 <            q.put(I);
268 <            assertTrue(q.contains(I));
266 >            Integer x = new Integer(i);
267 >            q.put(x);
268 >            assertTrue(q.contains(x));
269          }
270          assertEquals(SIZE, q.size());
271      }
# Line 530 | Line 527 | public class PriorityBlockingQueueTest e
527              assertTrue(q.removeAll(p));
528              assertEquals(SIZE-i, q.size());
529              for (int j = 0; j < i; ++j) {
530 <                Integer I = (Integer)(p.remove());
531 <                assertFalse(q.contains(I));
530 >                Integer x = (Integer)(p.remove());
531 >                assertFalse(q.contains(x));
532              }
533          }
534      }
# Line 576 | Line 573 | public class PriorityBlockingQueueTest e
573       */
574      public void testIterator() {
575          PriorityBlockingQueue q = populatedQueue(SIZE);
579 –        int i = 0;
576          Iterator it = q.iterator();
577 <        while (it.hasNext()) {
577 >        int i;
578 >        for (i = 0; it.hasNext(); i++)
579              assertTrue(q.contains(it.next()));
583 –            ++i;
584 –        }
580          assertEquals(i, SIZE);
581 +        assertIteratorExhausted(it);
582 +    }
583 +
584 +    /**
585 +     * iterator of empty collection has no elements
586 +     */
587 +    public void testEmptyIterator() {
588 +        assertIteratorExhausted(new PriorityBlockingQueue().iterator());
589      }
590  
591      /**
# Line 714 | Line 717 | public class PriorityBlockingQueueTest e
717              assertEquals(SIZE-k, q.size());
718              for (int j = 0; j < k; ++j)
719                  assertEquals(l.get(j), new Integer(j));
720 <            while (q.poll() != null) ;
720 >            do {} while (q.poll() != null);
721          }
722      }
723  

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines