ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/PriorityBlockingQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/PriorityBlockingQueueTest.java (file contents):
Revision 1.41 by jsr166, Tue Mar 15 19:47:07 2011 UTC vs.
Revision 1.74 by jsr166, Sat May 13 22:49:01 2017 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 import junit.framework.*;
10 import java.util.*;
11 import java.util.concurrent.*;
9   import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 < import java.io.*;
10 >
11 > import java.util.ArrayList;
12 > import java.util.Arrays;
13 > import java.util.Collection;
14 > import java.util.Comparator;
15 > import java.util.Iterator;
16 > import java.util.NoSuchElementException;
17 > import java.util.Queue;
18 > import java.util.concurrent.BlockingQueue;
19 > import java.util.concurrent.CountDownLatch;
20 > import java.util.concurrent.Executors;
21 > import java.util.concurrent.ExecutorService;
22 > import java.util.concurrent.PriorityBlockingQueue;
23 >
24 > import junit.framework.Test;
25  
26   public class PriorityBlockingQueueTest extends JSR166TestCase {
27  
# Line 22 | Line 33 | public class PriorityBlockingQueueTest e
33  
34      public static class InitialCapacity extends BlockingQueueTest {
35          protected BlockingQueue emptyCollection() {
36 <            return new PriorityBlockingQueue(20);
36 >            return new PriorityBlockingQueue(SIZE);
37          }
38      }
39  
40      public static void main(String[] args) {
41 <        junit.textui.TestRunner.run(suite());
41 >        main(suite(), args);
42      }
43  
44      public static Test suite() {
45 +        class Implementation implements CollectionImplementation {
46 +            public Class<?> klazz() { return PriorityBlockingQueue.class; }
47 +            public Collection emptyCollection() { return new PriorityBlockingQueue(); }
48 +            public Object makeElement(int i) { return i; }
49 +            public boolean isConcurrent() { return true; }
50 +            public boolean permitsNulls() { return false; }
51 +        }
52          return newTestSuite(PriorityBlockingQueueTest.class,
53                              new Generic().testSuite(),
54 <                            new InitialCapacity().testSuite());
54 >                            new InitialCapacity().testSuite(),
55 >                            CollectionTest.testSuite(new Implementation()));
56      }
57  
39    private static final int NOCAP = Integer.MAX_VALUE;
40
58      /** Sample Comparator */
59      static class MyReverseComparator implements Comparator {
60          public int compare(Object x, Object y) {
# Line 46 | Line 63 | public class PriorityBlockingQueueTest e
63      }
64  
65      /**
66 <     * Create a queue of given size containing consecutive
67 <     * Integers 0 ... n.
66 >     * Returns a new queue of given size containing consecutive
67 >     * Integers 0 ... n - 1.
68       */
69 <    private PriorityBlockingQueue<Integer> populatedQueue(int n) {
69 >    private static PriorityBlockingQueue<Integer> populatedQueue(int n) {
70          PriorityBlockingQueue<Integer> q =
71              new PriorityBlockingQueue<Integer>(n);
72          assertTrue(q.isEmpty());
73 <        for (int i = n-1; i >= 0; i-=2)
73 >        for (int i = n - 1; i >= 0; i -= 2)
74              assertTrue(q.offer(new Integer(i)));
75 <        for (int i = (n & 1); i < n; i+=2)
75 >        for (int i = (n & 1); i < n; i += 2)
76              assertTrue(q.offer(new Integer(i)));
77          assertFalse(q.isEmpty());
78 <        assertEquals(NOCAP, q.remainingCapacity());
78 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
79          assertEquals(n, q.size());
80 +        assertEquals((Integer) 0, q.peek());
81          return q;
82      }
83  
# Line 67 | Line 85 | public class PriorityBlockingQueueTest e
85       * A new queue has unbounded capacity
86       */
87      public void testConstructor1() {
88 <        assertEquals(NOCAP, new PriorityBlockingQueue(SIZE).remainingCapacity());
88 >        assertEquals(Integer.MAX_VALUE,
89 >                     new PriorityBlockingQueue(SIZE).remainingCapacity());
90      }
91  
92      /**
# Line 75 | Line 94 | public class PriorityBlockingQueueTest e
94       */
95      public void testConstructor2() {
96          try {
97 <            PriorityBlockingQueue q = new PriorityBlockingQueue(0);
97 >            new PriorityBlockingQueue(0);
98              shouldThrow();
99          } catch (IllegalArgumentException success) {}
100      }
# Line 85 | Line 104 | public class PriorityBlockingQueueTest e
104       */
105      public void testConstructor3() {
106          try {
107 <            PriorityBlockingQueue q = new PriorityBlockingQueue(null);
107 >            new PriorityBlockingQueue(null);
108              shouldThrow();
109          } catch (NullPointerException success) {}
110      }
# Line 94 | Line 113 | public class PriorityBlockingQueueTest e
113       * Initializing from Collection of null elements throws NPE
114       */
115      public void testConstructor4() {
116 +        Collection<Integer> elements = Arrays.asList(new Integer[SIZE]);
117          try {
118 <            Integer[] ints = new Integer[SIZE];
99 <            PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
118 >            new PriorityBlockingQueue(elements);
119              shouldThrow();
120          } catch (NullPointerException success) {}
121      }
# Line 105 | Line 124 | public class PriorityBlockingQueueTest e
124       * Initializing from Collection with some null elements throws NPE
125       */
126      public void testConstructor5() {
127 +        Integer[] ints = new Integer[SIZE];
128 +        for (int i = 0; i < SIZE - 1; ++i)
129 +            ints[i] = i;
130 +        Collection<Integer> elements = Arrays.asList(ints);
131          try {
132 <            Integer[] ints = new Integer[SIZE];
110 <            for (int i = 0; i < SIZE-1; ++i)
111 <                ints[i] = new Integer(i);
112 <            PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
132 >            new PriorityBlockingQueue(elements);
133              shouldThrow();
134          } catch (NullPointerException success) {}
135      }
# Line 120 | Line 140 | public class PriorityBlockingQueueTest e
140      public void testConstructor6() {
141          Integer[] ints = new Integer[SIZE];
142          for (int i = 0; i < SIZE; ++i)
143 <            ints[i] = new Integer(i);
143 >            ints[i] = i;
144          PriorityBlockingQueue q = new PriorityBlockingQueue(Arrays.asList(ints));
145          for (int i = 0; i < SIZE; ++i)
146              assertEquals(ints[i], q.poll());
# Line 137 | Line 157 | public class PriorityBlockingQueueTest e
157          for (int i = 0; i < SIZE; ++i)
158              ints[i] = new Integer(i);
159          q.addAll(Arrays.asList(ints));
160 <        for (int i = SIZE-1; i >= 0; --i)
160 >        for (int i = SIZE - 1; i >= 0; --i)
161              assertEquals(ints[i], q.poll());
162      }
163  
# Line 147 | Line 167 | public class PriorityBlockingQueueTest e
167      public void testEmpty() {
168          PriorityBlockingQueue q = new PriorityBlockingQueue(2);
169          assertTrue(q.isEmpty());
170 <        assertEquals(NOCAP, q.remainingCapacity());
170 >        assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
171          q.add(one);
172          assertFalse(q.isEmpty());
173          q.add(two);
# Line 157 | Line 177 | public class PriorityBlockingQueueTest e
177      }
178  
179      /**
180 <     * remainingCapacity does not change when elements added or removed,
161 <     * but size does
180 >     * remainingCapacity() always returns Integer.MAX_VALUE
181       */
182      public void testRemainingCapacity() {
183 <        PriorityBlockingQueue q = populatedQueue(SIZE);
183 >        BlockingQueue q = populatedQueue(SIZE);
184          for (int i = 0; i < SIZE; ++i) {
185 <            assertEquals(NOCAP, q.remainingCapacity());
186 <            assertEquals(SIZE-i, q.size());
187 <            q.remove();
185 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
186 >            assertEquals(SIZE - i, q.size());
187 >            assertEquals(i, q.remove());
188          }
189          for (int i = 0; i < SIZE; ++i) {
190 <            assertEquals(NOCAP, q.remainingCapacity());
190 >            assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
191              assertEquals(i, q.size());
192 <            q.add(new Integer(i));
192 >            assertTrue(q.add(i));
193          }
194      }
195  
196      /**
178     * offer(null) throws NPE
179     */
180    public void testOfferNull() {
181        try {
182            PriorityBlockingQueue q = new PriorityBlockingQueue(1);
183            q.offer(null);
184            shouldThrow();
185        } catch (NullPointerException success) {}
186    }
187
188    /**
189     * add(null) throws NPE
190     */
191    public void testAddNull() {
192        try {
193            PriorityBlockingQueue q = new PriorityBlockingQueue(1);
194            q.add(null);
195            shouldThrow();
196        } catch (NullPointerException success) {}
197    }
198
199    /**
197       * Offer of comparable element succeeds
198       */
199      public void testOffer() {
# Line 209 | Line 206 | public class PriorityBlockingQueueTest e
206       * Offer of non-Comparable throws CCE
207       */
208      public void testOfferNonComparable() {
209 +        PriorityBlockingQueue q = new PriorityBlockingQueue(1);
210          try {
213            PriorityBlockingQueue q = new PriorityBlockingQueue(1);
214            q.offer(new Object());
215            q.offer(new Object());
211              q.offer(new Object());
212              shouldThrow();
213 <        } catch (ClassCastException success) {}
213 >        } catch (ClassCastException success) {
214 >            assertTrue(q.isEmpty());
215 >            assertEquals(0, q.size());
216 >            assertNull(q.poll());
217 >        }
218      }
219  
220      /**
# Line 230 | Line 229 | public class PriorityBlockingQueueTest e
229      }
230  
231      /**
233     * addAll(null) throws NPE
234     */
235    public void testAddAll1() {
236        try {
237            PriorityBlockingQueue q = new PriorityBlockingQueue(1);
238            q.addAll(null);
239            shouldThrow();
240        } catch (NullPointerException success) {}
241    }
242
243    /**
232       * addAll(this) throws IAE
233       */
234      public void testAddAllSelf() {
235 +        PriorityBlockingQueue q = populatedQueue(SIZE);
236          try {
248            PriorityBlockingQueue q = populatedQueue(SIZE);
237              q.addAll(q);
238              shouldThrow();
239          } catch (IllegalArgumentException success) {}
240      }
241  
242      /**
255     * addAll of a collection with null elements throws NPE
256     */
257    public void testAddAll2() {
258        try {
259            PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
260            Integer[] ints = new Integer[SIZE];
261            q.addAll(Arrays.asList(ints));
262            shouldThrow();
263        } catch (NullPointerException success) {}
264    }
265
266    /**
243       * addAll of a collection with any null elements throws NPE after
244       * possibly adding some elements
245       */
246      public void testAddAll3() {
247 +        PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
248 +        Integer[] ints = new Integer[SIZE];
249 +        for (int i = 0; i < SIZE - 1; ++i)
250 +            ints[i] = new Integer(i);
251          try {
272            PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
273            Integer[] ints = new Integer[SIZE];
274            for (int i = 0; i < SIZE-1; ++i)
275                ints[i] = new Integer(i);
252              q.addAll(Arrays.asList(ints));
253              shouldThrow();
254          } catch (NullPointerException success) {}
# Line 284 | Line 260 | public class PriorityBlockingQueueTest e
260      public void testAddAll5() {
261          Integer[] empty = new Integer[0];
262          Integer[] ints = new Integer[SIZE];
263 <        for (int i = SIZE-1; i >= 0; --i)
263 >        for (int i = SIZE - 1; i >= 0; --i)
264              ints[i] = new Integer(i);
265          PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
266          assertFalse(q.addAll(Arrays.asList(empty)));
# Line 294 | Line 270 | public class PriorityBlockingQueueTest e
270      }
271  
272      /**
297     * put(null) throws NPE
298     */
299     public void testPutNull() {
300        try {
301            PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
302            q.put(null);
303            shouldThrow();
304        } catch (NullPointerException success) {}
305     }
306
307    /**
273       * all elements successfully put are contained
274       */
275 <     public void testPut() {
276 <         PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
277 <         for (int i = 0; i < SIZE; ++i) {
278 <             Integer I = new Integer(i);
279 <             q.put(I);
280 <             assertTrue(q.contains(I));
281 <         }
282 <         assertEquals(SIZE, q.size());
275 >    public void testPut() {
276 >        PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE);
277 >        for (int i = 0; i < SIZE; ++i) {
278 >            Integer x = new Integer(i);
279 >            q.put(x);
280 >            assertTrue(q.contains(x));
281 >        }
282 >        assertEquals(SIZE, q.size());
283      }
284  
285      /**
# Line 323 | Line 288 | public class PriorityBlockingQueueTest e
288      public void testPutWithTake() throws InterruptedException {
289          final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
290          final int size = 4;
291 <        Thread t = new Thread(new CheckedRunnable() {
291 >        Thread t = newStartedThread(new CheckedRunnable() {
292              public void realRun() {
293                  for (int i = 0; i < size; i++)
294                      q.put(new Integer(0));
295              }});
296  
297 <        t.start();
298 <        Thread.sleep(SHORT_DELAY_MS);
334 <        assertEquals(q.size(), size);
297 >        awaitTermination(t);
298 >        assertEquals(size, q.size());
299          q.take();
336        t.interrupt();
337        t.join();
300      }
301  
302      /**
# Line 342 | Line 304 | public class PriorityBlockingQueueTest e
304       */
305      public void testTimedOffer() throws InterruptedException {
306          final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
307 <        Thread t = new Thread(new CheckedRunnable() {
307 >        Thread t = newStartedThread(new CheckedRunnable() {
308              public void realRun() {
309                  q.put(new Integer(0));
310                  q.put(new Integer(0));
# Line 350 | Line 312 | public class PriorityBlockingQueueTest e
312                  assertTrue(q.offer(new Integer(0), LONG_DELAY_MS, MILLISECONDS));
313              }});
314  
315 <        t.start();
354 <        Thread.sleep(SMALL_DELAY_MS);
355 <        t.interrupt();
356 <        t.join();
315 >        awaitTermination(t);
316      }
317  
318      /**
# Line 371 | Line 330 | public class PriorityBlockingQueueTest e
330       */
331      public void testBlockingTake() throws InterruptedException {
332          final PriorityBlockingQueue q = populatedQueue(SIZE);
333 <        Thread t = new Thread(new CheckedRunnable() {
333 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
334 >        Thread t = newStartedThread(new CheckedRunnable() {
335              public void realRun() throws InterruptedException {
336 <                for (int i = 0; i < SIZE; ++i) {
337 <                    assertEquals(i, q.take());
338 <                }
336 >                for (int i = 0; i < SIZE; i++) assertEquals(i, q.take());
337 >
338 >                Thread.currentThread().interrupt();
339 >                try {
340 >                    q.take();
341 >                    shouldThrow();
342 >                } catch (InterruptedException success) {}
343 >                assertFalse(Thread.interrupted());
344 >
345 >                pleaseInterrupt.countDown();
346                  try {
347                      q.take();
348                      shouldThrow();
349                  } catch (InterruptedException success) {}
350 +                assertFalse(Thread.interrupted());
351              }});
352  
353 <        t.start();
354 <        Thread.sleep(SHORT_DELAY_MS);
353 >        await(pleaseInterrupt);
354 >        assertThreadBlocks(t, Thread.State.WAITING);
355          t.interrupt();
356 <        t.join();
356 >        awaitTermination(t);
357      }
358  
391
359      /**
360       * poll succeeds unless empty
361       */
# Line 415 | Line 382 | public class PriorityBlockingQueueTest e
382       * timed poll with nonzero timeout succeeds when non-empty, else times out
383       */
384      public void testTimedPoll() throws InterruptedException {
385 <        PriorityBlockingQueue q = populatedQueue(SIZE);
385 >        PriorityBlockingQueue<Integer> q = populatedQueue(SIZE);
386          for (int i = 0; i < SIZE; ++i) {
387 <            assertEquals(i, q.poll(SHORT_DELAY_MS, MILLISECONDS));
388 <        }
389 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
387 >            long startTime = System.nanoTime();
388 >            assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
389 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
390 >        }
391 >        long startTime = System.nanoTime();
392 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
393 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
394 >        checkEmpty(q);
395      }
396  
397      /**
# Line 431 | Line 403 | public class PriorityBlockingQueueTest e
403          final CountDownLatch aboutToWait = new CountDownLatch(1);
404          Thread t = newStartedThread(new CheckedRunnable() {
405              public void realRun() throws InterruptedException {
406 +                long startTime = System.nanoTime();
407                  for (int i = 0; i < SIZE; ++i) {
435                    long t0 = System.nanoTime();
408                      assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
437                    assertTrue(millisElapsedSince(t0) < SMALL_DELAY_MS);
409                  }
439                long t0 = System.nanoTime();
410                  aboutToWait.countDown();
411                  try {
412 <                    q.poll(MEDIUM_DELAY_MS, MILLISECONDS);
412 >                    q.poll(LONG_DELAY_MS, MILLISECONDS);
413                      shouldThrow();
414                  } catch (InterruptedException success) {
415 <                    assertTrue(millisElapsedSince(t0) < MEDIUM_DELAY_MS);
415 >                    assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
416                  }
417              }});
418  
419 <        aboutToWait.await();
420 <        waitForThreadToEnterWaitState(t, SMALL_DELAY_MS);
419 >        await(aboutToWait);
420 >        assertThreadBlocks(t, Thread.State.TIMED_WAITING);
421          t.interrupt();
422 <        awaitTermination(t, MEDIUM_DELAY_MS);
422 >        awaitTermination(t);
423      }
424  
425      /**
# Line 496 | Line 466 | public class PriorityBlockingQueueTest e
466      }
467  
468      /**
499     * remove(x) removes x and returns true if present
500     */
501    public void testRemoveElement() {
502        PriorityBlockingQueue q = populatedQueue(SIZE);
503        for (int i = 1; i < SIZE; i+=2) {
504            assertTrue(q.contains(i));
505            assertTrue(q.remove(i));
506            assertFalse(q.contains(i));
507            assertTrue(q.contains(i-1));
508        }
509        for (int i = 0; i < SIZE; i+=2) {
510            assertTrue(q.contains(i));
511            assertTrue(q.remove(i));
512            assertFalse(q.contains(i));
513            assertFalse(q.remove(i+1));
514            assertFalse(q.contains(i+1));
515        }
516        assertTrue(q.isEmpty());
517    }
518
519    /**
469       * contains(x) reports true when elements added but not yet removed
470       */
471      public void testContains() {
# Line 571 | Line 520 | public class PriorityBlockingQueueTest e
520                  assertTrue(changed);
521  
522              assertTrue(q.containsAll(p));
523 <            assertEquals(SIZE-i, q.size());
523 >            assertEquals(SIZE - i, q.size());
524              p.remove();
525          }
526      }
# Line 584 | Line 533 | public class PriorityBlockingQueueTest e
533              PriorityBlockingQueue q = populatedQueue(SIZE);
534              PriorityBlockingQueue p = populatedQueue(i);
535              assertTrue(q.removeAll(p));
536 <            assertEquals(SIZE-i, q.size());
536 >            assertEquals(SIZE - i, q.size());
537              for (int j = 0; j < i; ++j) {
538 <                Integer I = (Integer)(p.remove());
539 <                assertFalse(q.contains(I));
538 >                Integer x = (Integer)(p.remove());
539 >                assertFalse(q.contains(x));
540              }
541          }
542      }
# Line 617 | Line 566 | public class PriorityBlockingQueueTest e
566      }
567  
568      /**
620     * toArray(null) throws NullPointerException
621     */
622    public void testToArray_NullArg() {
623        PriorityBlockingQueue q = populatedQueue(SIZE);
624        try {
625            q.toArray(null);
626            shouldThrow();
627        } catch (NullPointerException success) {}
628    }
629
630    /**
569       * toArray(incompatible array type) throws ArrayStoreException
570       */
571      public void testToArray1_BadArg() {
# Line 643 | Line 581 | public class PriorityBlockingQueueTest e
581       */
582      public void testIterator() {
583          PriorityBlockingQueue q = populatedQueue(SIZE);
646        int i = 0;
584          Iterator it = q.iterator();
585 <        while (it.hasNext()) {
585 >        int i;
586 >        for (i = 0; it.hasNext(); i++)
587              assertTrue(q.contains(it.next()));
650            ++i;
651        }
588          assertEquals(i, SIZE);
589 +        assertIteratorExhausted(it);
590 +    }
591 +
592 +    /**
593 +     * iterator of empty collection has no elements
594 +     */
595 +    public void testEmptyIterator() {
596 +        assertIteratorExhausted(new PriorityBlockingQueue().iterator());
597      }
598  
599      /**
# Line 671 | Line 615 | public class PriorityBlockingQueueTest e
615          assertFalse(it.hasNext());
616      }
617  
674
618      /**
619       * toString contains toStrings of elements
620       */
# Line 679 | Line 622 | public class PriorityBlockingQueueTest e
622          PriorityBlockingQueue q = populatedQueue(SIZE);
623          String s = q.toString();
624          for (int i = 0; i < SIZE; ++i) {
625 <            assertTrue(s.indexOf(String.valueOf(i)) >= 0);
625 >            assertTrue(s.contains(String.valueOf(i)));
626          }
627      }
628  
629      /**
630 <     * offer transfers elements across Executor tasks
630 >     * timed poll transfers elements across Executor tasks
631       */
632      public void testPollInExecutor() {
633          final PriorityBlockingQueue q = new PriorityBlockingQueue(2);
634 <        ExecutorService executor = Executors.newFixedThreadPool(2);
635 <        executor.execute(new CheckedRunnable() {
636 <            public void realRun() throws InterruptedException {
637 <                assertNull(q.poll());
638 <                assertSame(one, q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
639 <                assertTrue(q.isEmpty());
640 <            }});
641 <
642 <        executor.execute(new CheckedRunnable() {
643 <            public void realRun() throws InterruptedException {
644 <                Thread.sleep(SMALL_DELAY_MS);
645 <                q.put(one);
646 <            }});
647 <
648 <        joinPool(executor);
634 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
635 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
636 >        try (PoolCleaner cleaner = cleaner(executor)) {
637 >            executor.execute(new CheckedRunnable() {
638 >                public void realRun() throws InterruptedException {
639 >                    assertNull(q.poll());
640 >                    threadsStarted.await();
641 >                    assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
642 >                    checkEmpty(q);
643 >                }});
644 >
645 >            executor.execute(new CheckedRunnable() {
646 >                public void realRun() throws InterruptedException {
647 >                    threadsStarted.await();
648 >                    q.put(one);
649 >                }});
650 >        }
651      }
652  
653      /**
654       * A deserialized serialized queue has same elements
655       */
656      public void testSerialization() throws Exception {
657 <        PriorityBlockingQueue q = populatedQueue(SIZE);
658 <        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
714 <        ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
715 <        out.writeObject(q);
716 <        out.close();
717 <
718 <        ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
719 <        ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
720 <        PriorityBlockingQueue r = (PriorityBlockingQueue)in.readObject();
721 <        assertEquals(q.size(), r.size());
722 <        while (!q.isEmpty())
723 <            assertEquals(q.remove(), r.remove());
724 <    }
725 <
726 <    /**
727 <     * drainTo(null) throws NPE
728 <     */
729 <    public void testDrainToNull() {
730 <        PriorityBlockingQueue q = populatedQueue(SIZE);
731 <        try {
732 <            q.drainTo(null);
733 <            shouldThrow();
734 <        } catch (NullPointerException success) {}
735 <    }
657 >        Queue x = populatedQueue(SIZE);
658 >        Queue y = serialClone(x);
659  
660 <    /**
661 <     * drainTo(this) throws IAE
662 <     */
663 <    public void testDrainToSelf() {
664 <        PriorityBlockingQueue q = populatedQueue(SIZE);
665 <        try {
666 <            q.drainTo(q);
744 <            shouldThrow();
745 <        } catch (IllegalArgumentException success) {}
660 >        assertNotSame(x, y);
661 >        assertEquals(x.size(), y.size());
662 >        while (!x.isEmpty()) {
663 >            assertFalse(y.isEmpty());
664 >            assertEquals(x.remove(), y.remove());
665 >        }
666 >        assertTrue(y.isEmpty());
667      }
668  
669      /**
# Line 752 | Line 673 | public class PriorityBlockingQueueTest e
673          PriorityBlockingQueue q = populatedQueue(SIZE);
674          ArrayList l = new ArrayList();
675          q.drainTo(l);
676 <        assertEquals(q.size(), 0);
677 <        assertEquals(l.size(), SIZE);
676 >        assertEquals(0, q.size());
677 >        assertEquals(SIZE, l.size());
678          for (int i = 0; i < SIZE; ++i)
679              assertEquals(l.get(i), new Integer(i));
680          q.add(zero);
# Line 763 | Line 684 | public class PriorityBlockingQueueTest e
684          assertTrue(q.contains(one));
685          l.clear();
686          q.drainTo(l);
687 <        assertEquals(q.size(), 0);
688 <        assertEquals(l.size(), 2);
687 >        assertEquals(0, q.size());
688 >        assertEquals(2, l.size());
689          for (int i = 0; i < 2; ++i)
690              assertEquals(l.get(i), new Integer(i));
691      }
# Line 776 | Line 697 | public class PriorityBlockingQueueTest e
697          final PriorityBlockingQueue q = populatedQueue(SIZE);
698          Thread t = new Thread(new CheckedRunnable() {
699              public void realRun() {
700 <                q.put(new Integer(SIZE+1));
700 >                q.put(new Integer(SIZE + 1));
701              }});
702  
703          t.start();
# Line 790 | Line 711 | public class PriorityBlockingQueueTest e
711      }
712  
713      /**
793     * drainTo(null, n) throws NPE
794     */
795    public void testDrainToNullN() {
796        PriorityBlockingQueue q = populatedQueue(SIZE);
797        try {
798            q.drainTo(null, 0);
799            shouldThrow();
800        } catch (NullPointerException success) {}
801    }
802
803    /**
804     * drainTo(this, n) throws IAE
805     */
806    public void testDrainToSelfN() {
807        PriorityBlockingQueue q = populatedQueue(SIZE);
808        try {
809            q.drainTo(q, 0);
810            shouldThrow();
811        } catch (IllegalArgumentException success) {}
812    }
813
814    /**
714       * drainTo(c, n) empties first min(n, size) elements of queue into c
715       */
716      public void testDrainToN() {
717 <        PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE*2);
717 >        PriorityBlockingQueue q = new PriorityBlockingQueue(SIZE * 2);
718          for (int i = 0; i < SIZE + 2; ++i) {
719              for (int j = 0; j < SIZE; j++)
720                  assertTrue(q.offer(new Integer(j)));
721              ArrayList l = new ArrayList();
722              q.drainTo(l, i);
723              int k = (i < SIZE) ? i : SIZE;
724 <            assertEquals(l.size(), k);
725 <            assertEquals(q.size(), SIZE-k);
724 >            assertEquals(k, l.size());
725 >            assertEquals(SIZE - k, q.size());
726              for (int j = 0; j < k; ++j)
727                  assertEquals(l.get(j), new Integer(j));
728 <            while (q.poll() != null) ;
728 >            do {} while (q.poll() != null);
729 >        }
730 >    }
731 >
732 >    /**
733 >     * remove(null), contains(null) always return false
734 >     */
735 >    public void testNeverContainsNull() {
736 >        Collection<?>[] qs = {
737 >            new PriorityBlockingQueue<Object>(),
738 >            populatedQueue(2),
739 >        };
740 >
741 >        for (Collection<?> q : qs) {
742 >            assertFalse(q.contains(null));
743 >            assertFalse(q.remove(null));
744          }
745      }
746  

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines