ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/RecursiveActionTest.java
(Generate patch)

Comparing jsr166/src/test/tck/RecursiveActionTest.java (file contents):
Revision 1.47 by jsr166, Tue Aug 16 23:02:57 2016 UTC vs.
Revision 1.54 by jsr166, Mon May 28 21:49:32 2018 UTC

# Line 4 | Line 4
4   * http://creativecommons.org/publicdomain/zero/1.0/
5   */
6  
7 < import static java.util.concurrent.TimeUnit.SECONDS;
7 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
8  
9   import java.util.Arrays;
10   import java.util.HashSet;
# Line 73 | Line 73 | public class RecursiveActionTest extends
73  
74              Thread.currentThread().interrupt();
75              try {
76 <                a.get(5L, SECONDS);
76 >                a.get(randomTimeout(), randomTimeUnit());
77                  shouldThrow();
78              } catch (InterruptedException success) {
79              } catch (Throwable fail) { threadUnexpectedException(fail); }
80          }
81  
82          try {
83 <            a.get(0L, SECONDS);
83 >            a.get(randomExpiredTimeout(), randomTimeUnit());
84              shouldThrow();
85          } catch (TimeoutException success) {
86          } catch (Throwable fail) { threadUnexpectedException(fail); }
# Line 98 | Line 98 | public class RecursiveActionTest extends
98          assertFalse(a.cancel(true));
99          try {
100              assertNull(a.get());
101 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
102 <        try {
103 <            assertNull(a.get(5L, SECONDS));
101 >            assertNull(a.get(randomTimeout(), randomTimeUnit()));
102          } catch (Throwable fail) { threadUnexpectedException(fail); }
103      }
104  
# Line 125 | Line 123 | public class RecursiveActionTest extends
123          } catch (Throwable fail) { threadUnexpectedException(fail); }
124  
125          try {
126 <            a.get(5L, SECONDS);
126 >            a.get(randomTimeout(), randomTimeUnit());
127              shouldThrow();
128          } catch (CancellationException success) {
129          } catch (Throwable fail) { threadUnexpectedException(fail); }
# Line 156 | Line 154 | public class RecursiveActionTest extends
154          } catch (Throwable fail) { threadUnexpectedException(fail); }
155  
156          try {
157 <            a.get(5L, SECONDS);
157 >            a.get(randomTimeout(), randomTimeUnit());
158              shouldThrow();
159          } catch (ExecutionException success) {
160              assertSame(t.getClass(), success.getCause().getClass());
# Line 168 | Line 166 | public class RecursiveActionTest extends
166          public FJException(Throwable cause) { super(cause); }
167      }
168  
169 <    // A simple recursive action for testing
169 >    /** A simple recursive action for testing. */
170      final class FibAction extends CheckedRecursiveAction {
171          final int number;
172          int result;
# Line 186 | Line 184 | public class RecursiveActionTest extends
184          }
185      }
186  
187 <    // A recursive action failing in base case
187 >    /** A recursive action failing in base case. */
188      static final class FailingFibAction extends RecursiveAction {
189          final int number;
190          int result;
# Line 263 | Line 261 | public class RecursiveActionTest extends
261                  // test join()
262                  assertSame(f, f.fork());
263                  currentThread.interrupt();
266 –                assertTrue(currentThread.isInterrupted());
264                  assertNull(f.join());
265                  Thread.interrupted();
266                  assertEquals(21, f.result);
# Line 273 | Line 270 | public class RecursiveActionTest extends
270                  f.cancel(true);
271                  assertSame(f, f.fork());
272                  currentThread.interrupt();
276 –                assertTrue(currentThread.isInterrupted());
273                  try {
274                      f.join();
275                      shouldThrow();
# Line 286 | Line 282 | public class RecursiveActionTest extends
282                  f.completeExceptionally(new FJException());
283                  assertSame(f, f.fork());
284                  currentThread.interrupt();
289 –                assertTrue(currentThread.isInterrupted());
285                  try {
286                      f.join();
287                      shouldThrow();
# Line 299 | Line 294 | public class RecursiveActionTest extends
294                  f = new FibAction(8);
295                  assertSame(f, f.fork());
296                  currentThread.interrupt();
302 –                assertTrue(currentThread.isInterrupted());
297                  f.quietlyJoin();
298                  Thread.interrupted();
299                  assertEquals(21, f.result);
# Line 309 | Line 303 | public class RecursiveActionTest extends
303                  f.cancel(true);
304                  assertSame(f, f.fork());
305                  currentThread.interrupt();
312 –                assertTrue(currentThread.isInterrupted());
306                  f.quietlyJoin();
307                  Thread.interrupted();
308                  checkCancelled(f);
# Line 318 | Line 311 | public class RecursiveActionTest extends
311                  f.completeExceptionally(new FJException());
312                  assertSame(f, f.fork());
313                  currentThread.interrupt();
321 –                assertTrue(currentThread.isInterrupted());
314                  f.quietlyJoin();
315                  Thread.interrupted();
316                  checkCompletedAbnormally(f, f.getException());
# Line 333 | Line 325 | public class RecursiveActionTest extends
325       * succeeds in the presence of interrupts
326       */
327      public void testJoinIgnoresInterruptsOutsideForkJoinPool() {
328 <        final SynchronousQueue<FibAction[]> sq =
337 <            new SynchronousQueue<FibAction[]>();
328 >        final SynchronousQueue<FibAction[]> sq = new SynchronousQueue<>();
329          RecursiveAction a = new CheckedRecursiveAction() {
330              protected void realCompute() throws InterruptedException {
331                  FibAction[] fibActions = new FibAction[6];
# Line 346 | Line 337 | public class RecursiveActionTest extends
337                  fibActions[4].cancel(true);
338                  fibActions[5].completeExceptionally(new FJException());
339  
340 <                for (int i = 0; i < fibActions.length; i++)
341 <                    fibActions[i].fork();
340 >                for (FibAction fibAction : fibActions)
341 >                    fibAction.fork();
342  
343                  sq.put(fibActions);
344  
# Line 365 | Line 356 | public class RecursiveActionTest extends
356                  f = fibActions[0];
357                  assertFalse(ForkJoinTask.inForkJoinPool());
358                  currentThread.interrupt();
368 –                assertTrue(currentThread.isInterrupted());
359                  assertNull(f.join());
360                  assertTrue(Thread.interrupted());
361                  assertEquals(21, f.result);
# Line 373 | Line 363 | public class RecursiveActionTest extends
363  
364                  f = fibActions[1];
365                  currentThread.interrupt();
376 –                assertTrue(currentThread.isInterrupted());
366                  try {
367                      f.join();
368                      shouldThrow();
# Line 384 | Line 373 | public class RecursiveActionTest extends
373  
374                  f = fibActions[2];
375                  currentThread.interrupt();
387 –                assertTrue(currentThread.isInterrupted());
376                  try {
377                      f.join();
378                      shouldThrow();
# Line 397 | Line 385 | public class RecursiveActionTest extends
385  
386                  f = fibActions[3];
387                  currentThread.interrupt();
400 –                assertTrue(currentThread.isInterrupted());
388                  f.quietlyJoin();
389                  assertTrue(Thread.interrupted());
390                  assertEquals(21, f.result);
# Line 405 | Line 392 | public class RecursiveActionTest extends
392  
393                  f = fibActions[4];
394                  currentThread.interrupt();
408 –                assertTrue(currentThread.isInterrupted());
395                  f.quietlyJoin();
396                  assertTrue(Thread.interrupted());
397                  checkCancelled(f);
398  
399                  f = fibActions[5];
400                  currentThread.interrupt();
415 –                assertTrue(currentThread.isInterrupted());
401                  f.quietlyJoin();
402                  assertTrue(Thread.interrupted());
403                  assertTrue(f.getException() instanceof FJException);
# Line 454 | Line 439 | public class RecursiveActionTest extends
439              protected void realCompute() throws Exception {
440                  FibAction f = new FibAction(8);
441                  assertSame(f, f.fork());
442 <                assertNull(f.get(5L, SECONDS));
442 >                assertNull(f.get(LONG_DELAY_MS, MILLISECONDS));
443                  assertEquals(21, f.result);
444                  checkCompletedNormally(f);
445              }};
# Line 470 | Line 455 | public class RecursiveActionTest extends
455                  FibAction f = new FibAction(8);
456                  assertSame(f, f.fork());
457                  try {
458 <                    f.get(5L, null);
458 >                    f.get(randomTimeout(), null);
459                      shouldThrow();
460                  } catch (NullPointerException success) {}
461              }};
# Line 589 | Line 574 | public class RecursiveActionTest extends
574                  FailingFibAction f = new FailingFibAction(8);
575                  assertSame(f, f.fork());
576                  try {
577 <                    f.get(5L, SECONDS);
577 >                    f.get(LONG_DELAY_MS, MILLISECONDS);
578                      shouldThrow();
579                  } catch (ExecutionException success) {
580                      Throwable cause = success.getCause();
# Line 681 | Line 666 | public class RecursiveActionTest extends
666                  assertTrue(f.cancel(true));
667                  assertSame(f, f.fork());
668                  try {
669 <                    f.get(5L, SECONDS);
669 >                    f.get(LONG_DELAY_MS, MILLISECONDS);
670                      shouldThrow();
671                  } catch (CancellationException success) {
672                      checkCancelled(f);

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines