ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ReentrantLockTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ReentrantLockTest.java (file contents):
Revision 1.2 by dl, Sat Sep 6 19:36:05 2003 UTC vs.
Revision 1.41 by jsr166, Sat May 7 02:51:33 2011 UTC

# Line 1 | Line 1
1   /*
2 < * Written by members of JCP JSR-166 Expert Group and released to the
3 < * public domain. Use, modify, and redistribute this code in any way
4 < * without acknowledgement. Other contributors include Andrew Wright,
5 < * Jeffrey Hayes, Pat Fischer, Mike Judd.
2 > * Written by Doug Lea with assistance from members of JCP JSR-166
3 > * Expert Group and released to the public domain, as explained at
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5 > * Other contributors include Andrew Wright, Jeffrey Hayes,
6 > * Pat Fisher, Mike Judd.
7   */
8  
9   import junit.framework.*;
10   import java.util.concurrent.locks.*;
11   import java.util.concurrent.*;
12 + import static java.util.concurrent.TimeUnit.MILLISECONDS;
13 + import java.util.*;
14 + import java.io.*;
15  
16 < public class ReentrantLockTest extends TestCase {
13 <    static int HOLD_COUNT_TEST_LIMIT = 20;
14 <
16 > public class ReentrantLockTest extends JSR166TestCase {
17      public static void main(String[] args) {
18 <        junit.textui.TestRunner.run (suite());  
18 >        junit.textui.TestRunner.run(suite());
19      }
18    
20      public static Test suite() {
21 <        return new TestSuite(ReentrantLockTest.class);
21 >        return new TestSuite(ReentrantLockTest.class);
22 >    }
23 >
24 >    /**
25 >     * A runnable calling lockInterruptibly
26 >     */
27 >    class InterruptibleLockRunnable extends CheckedRunnable {
28 >        final ReentrantLock lock;
29 >        InterruptibleLockRunnable(ReentrantLock l) { lock = l; }
30 >        public void realRun() throws InterruptedException {
31 >            lock.lockInterruptibly();
32 >        }
33 >    }
34 >
35 >
36 >    /**
37 >     * A runnable calling lockInterruptibly that expects to be
38 >     * interrupted
39 >     */
40 >    class InterruptedLockRunnable extends CheckedInterruptedRunnable {
41 >        final ReentrantLock lock;
42 >        InterruptedLockRunnable(ReentrantLock l) { lock = l; }
43 >        public void realRun() throws InterruptedException {
44 >            lock.lockInterruptibly();
45 >        }
46 >    }
47 >
48 >    /**
49 >     * Subclass to expose protected methods
50 >     */
51 >    static class PublicReentrantLock extends ReentrantLock {
52 >        PublicReentrantLock() { super(); }
53 >        public Collection<Thread> getQueuedThreads() {
54 >            return super.getQueuedThreads();
55 >        }
56 >        public Collection<Thread> getWaitingThreads(Condition c) {
57 >            return super.getWaitingThreads(c);
58 >        }
59 >    }
60 >
61 >    /**
62 >     * Constructor sets given fairness
63 >     */
64 >    public void testConstructor() {
65 >        assertFalse(new ReentrantLock().isFair());
66 >        assertFalse(new ReentrantLock(false).isFair());
67 >        assertTrue(new ReentrantLock(true).isFair());
68 >    }
69 >
70 >    /**
71 >     * locking an unlocked lock succeeds
72 >     */
73 >    public void testLock() {
74 >        ReentrantLock rl = new ReentrantLock();
75 >        rl.lock();
76 >        assertTrue(rl.isLocked());
77 >        rl.unlock();
78 >        assertFalse(rl.isLocked());
79 >    }
80 >
81 >    /**
82 >     * locking an unlocked fair lock succeeds
83 >     */
84 >    public void testFairLock() {
85 >        ReentrantLock rl = new ReentrantLock(true);
86 >        rl.lock();
87 >        assertTrue(rl.isLocked());
88 >        rl.unlock();
89      }
90  
91 <    private static long SHORT_DELAY_MS = 100;
92 <    private static long MEDIUM_DELAY_MS = 1000;
93 <    private static long LONG_DELAY_MS = 10000;
94 <
95 <    /*
96 <     * Unlocks an unlocked lock, throws Illegal Monitor State
97 <     *
98 <     */
99 <    
100 <    public void testIllegalMonitorStateException(){
101 <        ReentrantLock rl = new ReentrantLock();
102 <        try{
103 <            rl.unlock();
104 <            fail("Should of thown Illegal Monitor State Exception");
105 <
106 <        }catch(IllegalMonitorStateException sucess){}
107 <
108 <
109 <    }
110 <    
111 <    /*
112 <     * makes a lock, locks it, tries to aquire the lock in another thread
113 <     * interrupts that thread and waits for an interrupted Exception to
114 <     * be thrown.
115 <     */
116 <
117 <    public void testInterruptedException(){
118 <        final ReentrantLock lock = new ReentrantLock();
119 <        lock.lock();
120 <        Thread t = new Thread(new Runnable() {
121 <                public void run(){
122 <                    try{
123 <                        lock.lockInterruptibly();
124 <                        fail("should throw");
125 <                    }catch(InterruptedException sucess){}
126 <                }
127 <            });
128 <        t.start();
129 <        t.interrupt();
130 <        lock.unlock();
131 <    }
132 <
133 <    /*
134 <     * tests for interrupted exception on a timed wait
135 <     *
136 <     */
137 <    
138 <
139 <    public void testInterruptedException2(){
140 <        final ReentrantLock lock = new ReentrantLock();
141 <        lock.lock();
142 <        Thread t = new Thread(new Runnable() {
143 <                public void run(){
144 <                    try{
145 <                        lock.tryLock(1000,TimeUnit.MILLISECONDS);
146 <                        fail("should throw");
147 <                    }catch(InterruptedException sucess){}
148 <                }
149 <            });
150 <        t.start();
151 <        t.interrupt();
91 >    /**
92 >     * Unlocking an unlocked lock throws IllegalMonitorStateException
93 >     */
94 >    public void testUnlock_IllegalMonitorStateException() {
95 >        ReentrantLock rl = new ReentrantLock();
96 >        try {
97 >            rl.unlock();
98 >            shouldThrow();
99 >        } catch (IllegalMonitorStateException success) {}
100 >    }
101 >
102 >    /**
103 >     * tryLock on an unlocked lock succeeds
104 >     */
105 >    public void testTryLock() {
106 >        ReentrantLock rl = new ReentrantLock();
107 >        assertTrue(rl.tryLock());
108 >        assertTrue(rl.isLocked());
109 >        rl.unlock();
110 >    }
111 >
112 >
113 >    /**
114 >     * hasQueuedThreads reports whether there are waiting threads
115 >     */
116 >    public void testhasQueuedThreads() throws InterruptedException {
117 >        final ReentrantLock lock = new ReentrantLock();
118 >        Thread t1 = new Thread(new InterruptedLockRunnable(lock));
119 >        Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
120 >        assertFalse(lock.hasQueuedThreads());
121 >        lock.lock();
122 >        t1.start();
123 >        delay(SHORT_DELAY_MS);
124 >        assertTrue(lock.hasQueuedThreads());
125 >        t2.start();
126 >        delay(SHORT_DELAY_MS);
127 >        assertTrue(lock.hasQueuedThreads());
128 >        t1.interrupt();
129 >        delay(SHORT_DELAY_MS);
130 >        assertTrue(lock.hasQueuedThreads());
131 >        lock.unlock();
132 >        delay(SHORT_DELAY_MS);
133 >        assertFalse(lock.hasQueuedThreads());
134 >        t1.join();
135 >        t2.join();
136 >    }
137 >
138 >    /**
139 >     * getQueueLength reports number of waiting threads
140 >     */
141 >    public void testGetQueueLength() throws InterruptedException {
142 >        final ReentrantLock lock = new ReentrantLock();
143 >        Thread t1 = new Thread(new InterruptedLockRunnable(lock));
144 >        Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
145 >        assertEquals(0, lock.getQueueLength());
146 >        lock.lock();
147 >        t1.start();
148 >        delay(SHORT_DELAY_MS);
149 >        assertEquals(1, lock.getQueueLength());
150 >        t2.start();
151 >        delay(SHORT_DELAY_MS);
152 >        assertEquals(2, lock.getQueueLength());
153 >        t1.interrupt();
154 >        delay(SHORT_DELAY_MS);
155 >        assertEquals(1, lock.getQueueLength());
156 >        lock.unlock();
157 >        delay(SHORT_DELAY_MS);
158 >        assertEquals(0, lock.getQueueLength());
159 >        t1.join();
160 >        t2.join();
161      }
162  
163 <    
163 >    /**
164 >     * getQueueLength reports number of waiting threads
165 >     */
166 >    public void testGetQueueLength_fair() throws InterruptedException {
167 >        final ReentrantLock lock = new ReentrantLock(true);
168 >        Thread t1 = new Thread(new InterruptedLockRunnable(lock));
169 >        Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
170 >        assertEquals(0, lock.getQueueLength());
171 >        lock.lock();
172 >        t1.start();
173 >        delay(SHORT_DELAY_MS);
174 >        assertEquals(1, lock.getQueueLength());
175 >        t2.start();
176 >        delay(SHORT_DELAY_MS);
177 >        assertEquals(2, lock.getQueueLength());
178 >        t1.interrupt();
179 >        delay(SHORT_DELAY_MS);
180 >        assertEquals(1, lock.getQueueLength());
181 >        lock.unlock();
182 >        delay(SHORT_DELAY_MS);
183 >        assertEquals(0, lock.getQueueLength());
184 >        t1.join();
185 >        t2.join();
186 >    }
187 >
188 >    /**
189 >     * hasQueuedThread(null) throws NPE
190 >     */
191 >    public void testHasQueuedThreadNPE() {
192 >        final ReentrantLock sync = new ReentrantLock();
193 >        try {
194 >            sync.hasQueuedThread(null);
195 >            shouldThrow();
196 >        } catch (NullPointerException success) {}
197 >    }
198 >
199 >    /**
200 >     * hasQueuedThread reports whether a thread is queued.
201 >     */
202 >    public void testHasQueuedThread() throws InterruptedException {
203 >        final ReentrantLock sync = new ReentrantLock();
204 >        Thread t1 = new Thread(new InterruptedLockRunnable(sync));
205 >        Thread t2 = new Thread(new InterruptibleLockRunnable(sync));
206 >        assertFalse(sync.hasQueuedThread(t1));
207 >        assertFalse(sync.hasQueuedThread(t2));
208 >        sync.lock();
209 >        t1.start();
210 >        delay(SHORT_DELAY_MS);
211 >        assertTrue(sync.hasQueuedThread(t1));
212 >        t2.start();
213 >        delay(SHORT_DELAY_MS);
214 >        assertTrue(sync.hasQueuedThread(t1));
215 >        assertTrue(sync.hasQueuedThread(t2));
216 >        t1.interrupt();
217 >        delay(SHORT_DELAY_MS);
218 >        assertFalse(sync.hasQueuedThread(t1));
219 >        assertTrue(sync.hasQueuedThread(t2));
220 >        sync.unlock();
221 >        delay(SHORT_DELAY_MS);
222 >        assertFalse(sync.hasQueuedThread(t1));
223 >        delay(SHORT_DELAY_MS);
224 >        assertFalse(sync.hasQueuedThread(t2));
225 >        t1.join();
226 >        t2.join();
227 >    }
228 >
229 >
230 >    /**
231 >     * getQueuedThreads includes waiting threads
232 >     */
233 >    public void testGetQueuedThreads() throws InterruptedException {
234 >        final PublicReentrantLock lock = new PublicReentrantLock();
235 >        Thread t1 = new Thread(new InterruptedLockRunnable(lock));
236 >        Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
237 >        assertTrue(lock.getQueuedThreads().isEmpty());
238 >        lock.lock();
239 >        assertTrue(lock.getQueuedThreads().isEmpty());
240 >        t1.start();
241 >        delay(SHORT_DELAY_MS);
242 >        assertTrue(lock.getQueuedThreads().contains(t1));
243 >        t2.start();
244 >        delay(SHORT_DELAY_MS);
245 >        assertTrue(lock.getQueuedThreads().contains(t1));
246 >        assertTrue(lock.getQueuedThreads().contains(t2));
247 >        t1.interrupt();
248 >        delay(SHORT_DELAY_MS);
249 >        assertFalse(lock.getQueuedThreads().contains(t1));
250 >        assertTrue(lock.getQueuedThreads().contains(t2));
251 >        lock.unlock();
252 >        delay(SHORT_DELAY_MS);
253 >        assertTrue(lock.getQueuedThreads().isEmpty());
254 >        t1.join();
255 >        t2.join();
256 >    }
257 >
258 >
259 >    /**
260 >     * timed tryLock is interruptible.
261 >     */
262 >    public void testInterruptedException2() throws InterruptedException {
263 >        final ReentrantLock lock = new ReentrantLock();
264 >        lock.lock();
265 >        Thread t = newStartedThread(new CheckedInterruptedRunnable() {
266 >            public void realRun() throws InterruptedException {
267 >                lock.tryLock(MEDIUM_DELAY_MS,MILLISECONDS);
268 >            }});
269 >
270 >        delay(SHORT_DELAY_MS);
271 >        t.interrupt();
272 >        t.join();
273 >    }
274 >
275 >
276 >    /**
277 >     * TryLock on a locked lock fails
278 >     */
279 >    public void testTryLockWhenLocked() throws InterruptedException {
280 >        final ReentrantLock lock = new ReentrantLock();
281 >        lock.lock();
282 >        Thread t = newStartedThread(new CheckedRunnable() {
283 >            public void realRun() {
284 >                assertFalse(lock.tryLock());
285 >            }});
286 >
287 >        t.join();
288 >        lock.unlock();
289 >    }
290 >
291 >    /**
292 >     * Timed tryLock on a locked lock times out
293 >     */
294 >    public void testTryLock_Timeout() throws InterruptedException {
295 >        final ReentrantLock lock = new ReentrantLock();
296 >        lock.lock();
297 >        Thread t = newStartedThread(new CheckedRunnable() {
298 >            public void realRun() throws InterruptedException {
299 >                assertFalse(lock.tryLock(1, MILLISECONDS));
300 >            }});
301 >
302 >        t.join();
303 >        lock.unlock();
304 >    }
305 >
306 >    /**
307 >     * getHoldCount returns number of recursive holds
308 >     */
309      public void testGetHoldCount() {
310 <        ReentrantLock lock = new ReentrantLock();
311 <        for(int i = 1; i <= ReentrantLockTest.HOLD_COUNT_TEST_LIMIT;i++) {
312 <            lock.lock();
313 <            assertEquals(i,lock.getHoldCount());
314 <        }
315 <        for(int i = ReentrantLockTest.HOLD_COUNT_TEST_LIMIT; i > 0; i--) {
316 <            lock.unlock();
317 <            assertEquals(i-1,lock.getHoldCount());
96 <        }
97 <    }
98 <    
99 <  
100 <
101 <
102 <    public void testIsLocked() {
103 <        final ReentrantLock lock = new ReentrantLock();
104 <        lock.lock();
105 <        assertTrue(lock.isLocked());
106 <        lock.unlock();
107 <        assertFalse(lock.isLocked());
108 <        Thread t = new Thread(new Runnable() {
109 <                public void run() {
110 <                    lock.lock();
111 <                    try {
112 <                        Thread.sleep(SHORT_DELAY_MS * 2);
113 <                    }
114 <                    catch(Exception e) {}
115 <                    lock.unlock();
116 <                }
117 <            });
118 <        try{
119 <            t.start();
120 <            Thread.sleep(SHORT_DELAY_MS);
121 <            assertTrue(lock.isLocked());
122 <            t.join();
123 <            assertFalse(lock.isLocked());
124 <        } catch(Exception e){
125 <            fail("unexpected exception");
310 >        ReentrantLock lock = new ReentrantLock();
311 >        for (int i = 1; i <= SIZE; i++) {
312 >            lock.lock();
313 >            assertEquals(i, lock.getHoldCount());
314 >        }
315 >        for (int i = SIZE; i > 0; i--) {
316 >            lock.unlock();
317 >            assertEquals(i-1, lock.getHoldCount());
318          }
319 +    }
320 +
321  
322 +    /**
323 +     * isLocked is true when locked and false when not
324 +     */
325 +    public void testIsLocked() throws InterruptedException {
326 +        final ReentrantLock lock = new ReentrantLock();
327 +        lock.lock();
328 +        assertTrue(lock.isLocked());
329 +        lock.unlock();
330 +        assertFalse(lock.isLocked());
331 +        Thread t = newStartedThread(new CheckedRunnable() {
332 +            public void realRun() throws InterruptedException {
333 +                lock.lock();
334 +                delay(SMALL_DELAY_MS);
335 +                lock.unlock();
336 +            }});
337 +
338 +        delay(SHORT_DELAY_MS);
339 +        assertTrue(lock.isLocked());
340 +        t.join();
341 +        assertFalse(lock.isLocked());
342      }
343  
344 <    /*
345 <     * current thread locks interruptibly the thread
346 <     * another thread tries to aquire the lock and blocks
347 <     * on the call. interrupt the attempted aquireLock
348 <     * assert that the first lock() call actually locked the lock
349 <     * assert that the current thread is the one holding the lock
350 <     */
351 <
352 <    public void testLockedInterruptibly() {
353 <        final ReentrantLock lock = new ReentrantLock();
354 <        try {lock.lockInterruptibly();} catch(Exception e) {}
355 <        Thread t = new Thread(new Runnable() {
356 <                public void run() {
143 <                    try {
144 <                        lock.lockInterruptibly();
145 <                        fail("Failed to generate an Interrupted Exception");
146 <                    }
147 <                    catch(InterruptedException e) {}
148 <                }
149 <            });
150 <        t.start();
151 <        t.interrupt();
152 <        assertTrue(lock.isLocked());
153 <        assertTrue(lock.isHeldByCurrentThread());
344 >
345 >    /**
346 >     * lockInterruptibly is interruptible.
347 >     */
348 >    public void testLockInterruptibly1() throws InterruptedException {
349 >        final ReentrantLock lock = new ReentrantLock();
350 >        lock.lock();
351 >        Thread t = newStartedThread(new InterruptedLockRunnable(lock));
352 >        delay(SHORT_DELAY_MS);
353 >        t.interrupt();
354 >        delay(SHORT_DELAY_MS);
355 >        lock.unlock();
356 >        t.join();
357      }
358  
359 <    public void testAwait_IllegalMonitor() {
360 <        final ReentrantLock lock = new ReentrantLock();
359 >    /**
360 >     * lockInterruptibly succeeds when unlocked, else is interruptible
361 >     */
362 >    public void testLockInterruptibly2() throws InterruptedException {
363 >        final ReentrantLock lock = new ReentrantLock();
364 >        lock.lockInterruptibly();
365 >        Thread t = newStartedThread(new InterruptedLockRunnable(lock));
366 >        delay(SHORT_DELAY_MS);
367 >        t.interrupt();
368 >        assertTrue(lock.isLocked());
369 >        assertTrue(lock.isHeldByCurrentThread());
370 >        t.join();
371 >    }
372 >
373 >    /**
374 >     * Calling await without holding lock throws IllegalMonitorStateException
375 >     */
376 >    public void testAwait_IllegalMonitor() throws InterruptedException {
377 >        final ReentrantLock lock = new ReentrantLock();
378          final Condition c = lock.newCondition();
379          try {
380              c.await();
381 <            fail("should throw");
382 <        }
163 <        catch (IllegalMonitorStateException success) {
164 <        }
165 <        catch (Exception ex) {
166 <            fail("should throw IMSE");
167 <        }
381 >            shouldThrow();
382 >        } catch (IllegalMonitorStateException success) {}
383      }
384  
385 +    /**
386 +     * Calling signal without holding lock throws IllegalMonitorStateException
387 +     */
388      public void testSignal_IllegalMonitor() {
389 <        final ReentrantLock lock = new ReentrantLock();
389 >        final ReentrantLock lock = new ReentrantLock();
390          final Condition c = lock.newCondition();
391          try {
392              c.signal();
393 <            fail("should throw");
394 <        }
395 <        catch (IllegalMonitorStateException success) {
396 <        }
397 <        catch (Exception ex) {
398 <            fail("should throw IMSE");
399 <        }
393 >            shouldThrow();
394 >        } catch (IllegalMonitorStateException success) {}
395 >    }
396 >
397 >    /**
398 >     * awaitNanos without a signal times out
399 >     */
400 >    public void testAwaitNanos_Timeout() throws InterruptedException {
401 >        final ReentrantLock lock = new ReentrantLock();
402 >        final Condition c = lock.newCondition();
403 >        lock.lock();
404 >        long t = c.awaitNanos(100);
405 >        assertTrue(t <= 0);
406 >        lock.unlock();
407 >    }
408 >
409 >    /**
410 >     * timed await without a signal times out
411 >     */
412 >    public void testAwait_Timeout() throws InterruptedException {
413 >        final ReentrantLock lock = new ReentrantLock();
414 >        final Condition c = lock.newCondition();
415 >        lock.lock();
416 >        assertFalse(c.await(SHORT_DELAY_MS, MILLISECONDS));
417 >        lock.unlock();
418 >    }
419 >
420 >    /**
421 >     * awaitUntil without a signal times out
422 >     */
423 >    public void testAwaitUntil_Timeout() throws InterruptedException {
424 >        final ReentrantLock lock = new ReentrantLock();
425 >        final Condition c = lock.newCondition();
426 >        lock.lock();
427 >        java.util.Date d = new java.util.Date();
428 >        assertFalse(c.awaitUntil(new java.util.Date(d.getTime() + 10)));
429 >        lock.unlock();
430      }
431  
432 <    public void testAwaitNanos_Timeout() {
433 <        final ReentrantLock lock = new ReentrantLock();
432 >    /**
433 >     * await returns when signalled
434 >     */
435 >    public void testAwait() throws InterruptedException {
436 >        final ReentrantLock lock = new ReentrantLock();
437          final Condition c = lock.newCondition();
438 +        Thread t = newStartedThread(new CheckedRunnable() {
439 +            public void realRun() throws InterruptedException {
440 +                lock.lock();
441 +                c.await();
442 +                lock.unlock();
443 +            }});
444 +
445 +        delay(SHORT_DELAY_MS);
446 +        lock.lock();
447 +        c.signal();
448 +        lock.unlock();
449 +        t.join(SHORT_DELAY_MS);
450 +        assertFalse(t.isAlive());
451 +    }
452 +
453 +    /**
454 +     * hasWaiters throws NPE if null
455 +     */
456 +    public void testHasWaitersNPE() {
457 +        final ReentrantLock lock = new ReentrantLock();
458          try {
459 <            lock.lock();
460 <            long t = c.awaitNanos(100);
461 <            assertTrue(t <= 0);
462 <            lock.unlock();
463 <        }
464 <        catch (Exception ex) {
465 <            fail("unexpected exception");
466 <        }
459 >            lock.hasWaiters(null);
460 >            shouldThrow();
461 >        } catch (NullPointerException success) {}
462 >    }
463 >
464 >    /**
465 >     * getWaitQueueLength throws NPE if null
466 >     */
467 >    public void testGetWaitQueueLengthNPE() {
468 >        final ReentrantLock lock = new ReentrantLock();
469 >        try {
470 >            lock.getWaitQueueLength(null);
471 >            shouldThrow();
472 >        } catch (NullPointerException success) {}
473      }
474  
475 <    public void testAwait_Timeout() {
476 <        final ReentrantLock lock = new ReentrantLock();
475 >
476 >    /**
477 >     * getWaitingThreads throws NPE if null
478 >     */
479 >    public void testGetWaitingThreadsNPE() {
480 >        final PublicReentrantLock lock = new PublicReentrantLock();
481 >        try {
482 >            lock.getWaitingThreads(null);
483 >            shouldThrow();
484 >        } catch (NullPointerException success) {}
485 >    }
486 >
487 >
488 >    /**
489 >     * hasWaiters throws IAE if not owned
490 >     */
491 >    public void testHasWaitersIAE() {
492 >        final ReentrantLock lock = new ReentrantLock();
493          final Condition c = lock.newCondition();
494 +        final ReentrantLock lock2 = new ReentrantLock();
495          try {
496 <            lock.lock();
497 <            assertFalse(c.await(10, TimeUnit.MILLISECONDS));
498 <            lock.unlock();
499 <        }
500 <        catch (Exception ex) {
501 <            fail("unexpected exception");
502 <        }
496 >            lock2.hasWaiters(c);
497 >            shouldThrow();
498 >        } catch (IllegalArgumentException success) {}
499 >    }
500 >
501 >    /**
502 >     * hasWaiters throws IMSE if not locked
503 >     */
504 >    public void testHasWaitersIMSE() {
505 >        final ReentrantLock lock = new ReentrantLock();
506 >        final Condition c = lock.newCondition();
507 >        try {
508 >            lock.hasWaiters(c);
509 >            shouldThrow();
510 >        } catch (IllegalMonitorStateException success) {}
511      }
512  
513 <    public void testAwaitUntil_Timeout() {
514 <        final ReentrantLock lock = new ReentrantLock();
513 >
514 >    /**
515 >     * getWaitQueueLength throws IAE if not owned
516 >     */
517 >    public void testGetWaitQueueLengthIAE() {
518 >        final ReentrantLock lock = new ReentrantLock();
519          final Condition c = lock.newCondition();
520 +        final ReentrantLock lock2 = new ReentrantLock();
521          try {
522 <            lock.lock();
523 <            java.util.Date d = new java.util.Date();
524 <            assertFalse(c.awaitUntil(new java.util.Date(d.getTime() + 10)));
525 <            lock.unlock();
526 <        }
527 <        catch (Exception ex) {
528 <            fail("unexpected exception");
529 <        }
522 >            lock2.getWaitQueueLength(c);
523 >            shouldThrow();
524 >        } catch (IllegalArgumentException success) {}
525 >    }
526 >
527 >    /**
528 >     * getWaitQueueLength throws IMSE if not locked
529 >     */
530 >    public void testGetWaitQueueLengthIMSE() {
531 >        final ReentrantLock lock = new ReentrantLock();
532 >        final Condition c = lock.newCondition();
533 >        try {
534 >            lock.getWaitQueueLength(c);
535 >            shouldThrow();
536 >        } catch (IllegalMonitorStateException success) {}
537      }
538  
539 <    public void testAwait() {
540 <        final ReentrantLock lock = new ReentrantLock();
539 >
540 >    /**
541 >     * getWaitingThreads throws IAE if not owned
542 >     */
543 >    public void testGetWaitingThreadsIAE() {
544 >        final PublicReentrantLock lock = new PublicReentrantLock();
545          final Condition c = lock.newCondition();
546 <        Thread t = new Thread(new Runnable() {
547 <                public void run() {
548 <                    try {
549 <                        lock.lock();
550 <                        c.await();
551 <                        lock.unlock();
234 <                    }
235 <                    catch(InterruptedException e) {
236 <                        fail("unexpected exception");
237 <                    }
238 <                }
239 <            });
546 >        final PublicReentrantLock lock2 = new PublicReentrantLock();
547 >        try {
548 >            lock2.getWaitingThreads(c);
549 >            shouldThrow();
550 >        } catch (IllegalArgumentException success) {}
551 >    }
552  
553 +    /**
554 +     * getWaitingThreads throws IMSE if not locked
555 +     */
556 +    public void testGetWaitingThreadsIMSE() {
557 +        final PublicReentrantLock lock = new PublicReentrantLock();
558 +        final Condition c = lock.newCondition();
559          try {
560 <            t.start();
561 <            Thread.sleep(SHORT_DELAY_MS);
560 >            lock.getWaitingThreads(c);
561 >            shouldThrow();
562 >        } catch (IllegalMonitorStateException success) {}
563 >    }
564 >
565 >
566 >    /**
567 >     * hasWaiters returns true when a thread is waiting, else false
568 >     */
569 >    public void testHasWaiters() throws InterruptedException {
570 >        final ReentrantLock lock = new ReentrantLock();
571 >        final Condition c = lock.newCondition();
572 >        Thread t = newStartedThread(new CheckedRunnable() {
573 >            public void realRun() throws InterruptedException {
574 >                lock.lock();
575 >                assertFalse(lock.hasWaiters(c));
576 >                assertEquals(0, lock.getWaitQueueLength(c));
577 >                c.await();
578 >                lock.unlock();
579 >            }});
580 >
581 >        delay(SHORT_DELAY_MS);
582 >        lock.lock();
583 >        assertTrue(lock.hasWaiters(c));
584 >        assertEquals(1, lock.getWaitQueueLength(c));
585 >        c.signal();
586 >        lock.unlock();
587 >        delay(SHORT_DELAY_MS);
588 >        lock.lock();
589 >        assertFalse(lock.hasWaiters(c));
590 >        assertEquals(0, lock.getWaitQueueLength(c));
591 >        lock.unlock();
592 >        t.join(SHORT_DELAY_MS);
593 >        assertFalse(t.isAlive());
594 >    }
595 >
596 >    /**
597 >     * getWaitQueueLength returns number of waiting threads
598 >     */
599 >    public void testGetWaitQueueLength() throws InterruptedException {
600 >        final ReentrantLock lock = new ReentrantLock();
601 >        final Condition c = lock.newCondition();
602 >        Thread t1 = newStartedThread(new CheckedRunnable() {
603 >            public void realRun() throws InterruptedException {
604 >                lock.lock();
605 >                assertFalse(lock.hasWaiters(c));
606 >                assertEquals(0, lock.getWaitQueueLength(c));
607 >                c.await();
608 >                lock.unlock();
609 >            }});
610 >
611 >        delay(SHORT_DELAY_MS);
612 >
613 >        Thread t2 = newStartedThread(new CheckedRunnable() {
614 >            public void realRun() throws InterruptedException {
615 >                lock.lock();
616 >                assertTrue(lock.hasWaiters(c));
617 >                assertEquals(1, lock.getWaitQueueLength(c));
618 >                c.await();
619 >                lock.unlock();
620 >            }});
621 >
622 >        delay(SHORT_DELAY_MS);
623 >        lock.lock();
624 >        assertTrue(lock.hasWaiters(c));
625 >        assertEquals(2, lock.getWaitQueueLength(c));
626 >        c.signalAll();
627 >        lock.unlock();
628 >        delay(SHORT_DELAY_MS);
629 >        lock.lock();
630 >        assertFalse(lock.hasWaiters(c));
631 >        assertEquals(0, lock.getWaitQueueLength(c));
632 >        lock.unlock();
633 >        t1.join(SHORT_DELAY_MS);
634 >        t2.join(SHORT_DELAY_MS);
635 >        assertFalse(t1.isAlive());
636 >        assertFalse(t2.isAlive());
637 >    }
638 >
639 >    /**
640 >     * getWaitingThreads returns only and all waiting threads
641 >     */
642 >    public void testGetWaitingThreads() throws InterruptedException {
643 >        final PublicReentrantLock lock = new PublicReentrantLock();
644 >        final Condition c = lock.newCondition();
645 >        Thread t1 = new Thread(new CheckedRunnable() {
646 >            public void realRun() throws InterruptedException {
647 >                lock.lock();
648 >                assertTrue(lock.getWaitingThreads(c).isEmpty());
649 >                c.await();
650 >                lock.unlock();
651 >            }});
652 >
653 >        Thread t2 = new Thread(new CheckedRunnable() {
654 >            public void realRun() throws InterruptedException {
655 >                lock.lock();
656 >                assertFalse(lock.getWaitingThreads(c).isEmpty());
657 >                c.await();
658 >                lock.unlock();
659 >            }});
660 >
661 >        lock.lock();
662 >        assertTrue(lock.getWaitingThreads(c).isEmpty());
663 >        lock.unlock();
664 >        t1.start();
665 >        delay(SHORT_DELAY_MS);
666 >        t2.start();
667 >        delay(SHORT_DELAY_MS);
668 >        lock.lock();
669 >        assertTrue(lock.hasWaiters(c));
670 >        assertTrue(lock.getWaitingThreads(c).contains(t1));
671 >        assertTrue(lock.getWaitingThreads(c).contains(t2));
672 >        c.signalAll();
673 >        lock.unlock();
674 >        delay(SHORT_DELAY_MS);
675 >        lock.lock();
676 >        assertFalse(lock.hasWaiters(c));
677 >        assertTrue(lock.getWaitingThreads(c).isEmpty());
678 >        lock.unlock();
679 >        t1.join(SHORT_DELAY_MS);
680 >        t2.join(SHORT_DELAY_MS);
681 >        assertFalse(t1.isAlive());
682 >        assertFalse(t2.isAlive());
683 >    }
684 >
685 >    /** A helper class for uninterruptible wait tests */
686 >    class UninterruptibleThread extends Thread {
687 >        private ReentrantLock lock;
688 >        private Condition c;
689 >
690 >        public volatile boolean canAwake = false;
691 >        public volatile boolean interrupted = false;
692 >        public volatile boolean lockStarted = false;
693 >
694 >        public UninterruptibleThread(ReentrantLock lock, Condition c) {
695 >            this.lock = lock;
696 >            this.c = c;
697 >        }
698 >
699 >        public synchronized void run() {
700              lock.lock();
701 <            c.signal();
701 >            lockStarted = true;
702 >
703 >            while (!canAwake) {
704 >                c.awaitUninterruptibly();
705 >            }
706 >
707 >            interrupted = isInterrupted();
708              lock.unlock();
247            t.join(SHORT_DELAY_MS);
248            assertFalse(t.isAlive());
249        }
250        catch (Exception ex) {
251            fail("unexpected exception");
709          }
710      }
711  
712 <    public void testAwaitUninterruptibly() {
713 <        final ReentrantLock lock = new ReentrantLock();
712 >    /**
713 >     * awaitUninterruptibly doesn't abort on interrupt
714 >     */
715 >    public void testAwaitUninterruptibly() throws InterruptedException {
716 >        final ReentrantLock lock = new ReentrantLock();
717          final Condition c = lock.newCondition();
718 <        Thread t = new Thread(new Runnable() {
719 <                public void run() {
720 <                    lock.lock();
261 <                    c.awaitUninterruptibly();
262 <                    lock.unlock();
263 <                }
264 <            });
718 >        UninterruptibleThread thread = new UninterruptibleThread(lock, c);
719 >
720 >        thread.start();
721  
722 +        while (!thread.lockStarted) {
723 +            delay(100);
724 +        }
725 +
726 +        lock.lock();
727          try {
728 <            t.start();
729 <            Thread.sleep(SHORT_DELAY_MS);
269 <            t.interrupt();
270 <            lock.lock();
728 >            thread.interrupt();
729 >            thread.canAwake = true;
730              c.signal();
731 +        } finally {
732              lock.unlock();
273            t.join(SHORT_DELAY_MS);
274            assertFalse(t.isAlive());
275        }
276        catch (Exception ex) {
277            fail("unexpected exception");
733          }
734 +
735 +        thread.join();
736 +        assertTrue(thread.interrupted);
737 +        assertFalse(thread.isAlive());
738      }
739  
740 <    public void testAwait_Interrupt() {
741 <        final ReentrantLock lock = new ReentrantLock();
740 >    /**
741 >     * await is interruptible
742 >     */
743 >    public void testAwait_Interrupt() throws InterruptedException {
744 >        final ReentrantLock lock = new ReentrantLock();
745          final Condition c = lock.newCondition();
746 <        Thread t = new Thread(new Runnable() {
747 <                public void run() {
748 <                    try {
749 <                        lock.lock();
750 <                        c.await();
751 <                        lock.unlock();
752 <                        fail("should throw");
753 <                    }
754 <                    catch(InterruptedException success) {
755 <                    }
294 <                }
295 <            });
296 <
297 <        try {
298 <            t.start();
299 <            Thread.sleep(SHORT_DELAY_MS);
300 <            t.interrupt();
301 <            t.join(SHORT_DELAY_MS);
302 <            assertFalse(t.isAlive());
303 <        }
304 <        catch (Exception ex) {
305 <            fail("unexpected exception");
306 <        }
746 >        Thread t = newStartedThread(new CheckedInterruptedRunnable() {
747 >            public void realRun() throws InterruptedException {
748 >                lock.lock();
749 >                c.await();
750 >            }});
751 >
752 >        delay(SHORT_DELAY_MS);
753 >        t.interrupt();
754 >        t.join(SHORT_DELAY_MS);
755 >        assertFalse(t.isAlive());
756      }
757  
758 <    public void testAwaitNanos_Interrupt() {
759 <        final ReentrantLock lock = new ReentrantLock();
758 >    /**
759 >     * awaitNanos is interruptible
760 >     */
761 >    public void testAwaitNanos_Interrupt() throws InterruptedException {
762 >        final ReentrantLock lock = new ReentrantLock();
763          final Condition c = lock.newCondition();
764 <        Thread t = new Thread(new Runnable() {
765 <                public void run() {
766 <                    try {
767 <                        lock.lock();
768 <                        c.awaitNanos(SHORT_DELAY_MS * 2 * 1000000);
769 <                        lock.unlock();
770 <                        fail("should throw");
771 <                    }
772 <                    catch(InterruptedException success) {
773 <                    }
322 <                }
323 <            });
324 <
325 <        try {
326 <            t.start();
327 <            Thread.sleep(SHORT_DELAY_MS);
328 <            t.interrupt();
329 <            t.join(SHORT_DELAY_MS);
330 <            assertFalse(t.isAlive());
331 <        }
332 <        catch (Exception ex) {
333 <            fail("unexpected exception");
334 <        }
764 >        Thread t = newStartedThread(new CheckedInterruptedRunnable() {
765 >            public void realRun() throws InterruptedException {
766 >                lock.lock();
767 >                c.awaitNanos(MILLISECONDS.toNanos(LONG_DELAY_MS));
768 >            }});
769 >
770 >        delay(SHORT_DELAY_MS);
771 >        t.interrupt();
772 >        t.join(SHORT_DELAY_MS);
773 >        assertFalse(t.isAlive());
774      }
775  
776 <    public void testAwaitUntil_Interrupt() {
777 <        final ReentrantLock lock = new ReentrantLock();
776 >    /**
777 >     * awaitUntil is interruptible
778 >     */
779 >    public void testAwaitUntil_Interrupt() throws InterruptedException {
780 >        final ReentrantLock lock = new ReentrantLock();
781          final Condition c = lock.newCondition();
782 <        Thread t = new Thread(new Runnable() {
783 <                public void run() {
784 <                    try {
785 <                        lock.lock();
786 <                        java.util.Date d = new java.util.Date();
787 <                        c.awaitUntil(new java.util.Date(d.getTime() + 10000));
788 <                        lock.unlock();
789 <                        fail("should throw");
790 <                    }
791 <                    catch(InterruptedException success) {
792 <                    }
351 <                }
352 <            });
353 <
354 <        try {
355 <            t.start();
356 <            Thread.sleep(SHORT_DELAY_MS);
357 <            t.interrupt();
358 <            t.join(SHORT_DELAY_MS);
359 <            assertFalse(t.isAlive());
360 <        }
361 <        catch (Exception ex) {
362 <            fail("unexpected exception");
363 <        }
782 >        Thread t = newStartedThread(new CheckedInterruptedRunnable() {
783 >            public void realRun() throws InterruptedException {
784 >                lock.lock();
785 >                java.util.Date d = new java.util.Date();
786 >                c.awaitUntil(new java.util.Date(d.getTime() + 10000));
787 >            }});
788 >
789 >        delay(SHORT_DELAY_MS);
790 >        t.interrupt();
791 >        t.join(SHORT_DELAY_MS);
792 >        assertFalse(t.isAlive());
793      }
794  
795 <    public void testSignalAll() {
796 <        final ReentrantLock lock = new ReentrantLock();
795 >    /**
796 >     * signalAll wakes up all threads
797 >     */
798 >    public void testSignalAll() throws InterruptedException {
799 >        final ReentrantLock lock = new ReentrantLock();
800          final Condition c = lock.newCondition();
801 <        Thread t1 = new Thread(new Runnable() {
802 <                public void run() {
803 <                    try {
804 <                        lock.lock();
805 <                        c.await();
806 <                        lock.unlock();
807 <                    }
808 <                    catch(InterruptedException e) {
809 <                        fail("unexpected exception");
810 <                    }
811 <                }
812 <            });
813 <
814 <        Thread t2 = new Thread(new Runnable() {
815 <                public void run() {
816 <                    try {
817 <                        lock.lock();
818 <                        c.await();
819 <                        lock.unlock();
820 <                    }
821 <                    catch(InterruptedException e) {
822 <                        fail("unexpected exception");
823 <                    }
824 <                }
825 <            });
826 <
827 <        try {
828 <            t1.start();
829 <            t2.start();
830 <            Thread.sleep(SHORT_DELAY_MS);
831 <            lock.lock();
832 <            c.signalAll();
833 <            lock.unlock();
834 <            t1.join(SHORT_DELAY_MS);
835 <            t2.join(SHORT_DELAY_MS);
836 <            assertFalse(t1.isAlive());
837 <            assertFalse(t2.isAlive());
838 <        }
839 <        catch (Exception ex) {
840 <            fail("unexpected exception");
841 <        }
801 >        Thread t1 = newStartedThread(new CheckedRunnable() {
802 >            public void realRun() throws InterruptedException {
803 >                lock.lock();
804 >                c.await();
805 >                lock.unlock();
806 >            }});
807 >
808 >        Thread t2 = newStartedThread(new CheckedRunnable() {
809 >            public void realRun() throws InterruptedException {
810 >                lock.lock();
811 >                c.await();
812 >                lock.unlock();
813 >            }});
814 >
815 >        delay(SHORT_DELAY_MS);
816 >        lock.lock();
817 >        c.signalAll();
818 >        lock.unlock();
819 >        t1.join(SHORT_DELAY_MS);
820 >        t2.join(SHORT_DELAY_MS);
821 >        assertFalse(t1.isAlive());
822 >        assertFalse(t2.isAlive());
823 >    }
824 >
825 >    /**
826 >     * await after multiple reentrant locking preserves lock count
827 >     */
828 >    public void testAwaitLockCount() throws InterruptedException {
829 >        final ReentrantLock lock = new ReentrantLock();
830 >        final Condition c = lock.newCondition();
831 >        Thread t1 = newStartedThread(new CheckedRunnable() {
832 >            public void realRun() throws InterruptedException {
833 >                lock.lock();
834 >                assertEquals(1, lock.getHoldCount());
835 >                c.await();
836 >                assertEquals(1, lock.getHoldCount());
837 >                lock.unlock();
838 >            }});
839 >
840 >        Thread t2 = newStartedThread(new CheckedRunnable() {
841 >            public void realRun() throws InterruptedException {
842 >                lock.lock();
843 >                lock.lock();
844 >                assertEquals(2, lock.getHoldCount());
845 >                c.await();
846 >                assertEquals(2, lock.getHoldCount());
847 >                lock.unlock();
848 >                lock.unlock();
849 >            }});
850 >
851 >        delay(SHORT_DELAY_MS);
852 >        lock.lock();
853 >        c.signalAll();
854 >        lock.unlock();
855 >        t1.join(SHORT_DELAY_MS);
856 >        t2.join(SHORT_DELAY_MS);
857 >        assertFalse(t1.isAlive());
858 >        assertFalse(t2.isAlive());
859 >    }
860 >
861 >    /**
862 >     * A serialized lock deserializes as unlocked
863 >     */
864 >    public void testSerialization() throws Exception {
865 >        ReentrantLock l = new ReentrantLock();
866 >        l.lock();
867 >        l.unlock();
868 >
869 >        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
870 >        ObjectOutputStream out =
871 >            new ObjectOutputStream(new BufferedOutputStream(bout));
872 >        out.writeObject(l);
873 >        out.close();
874 >
875 >        ByteArrayInputStream bin =
876 >            new ByteArrayInputStream(bout.toByteArray());
877 >        ObjectInputStream in =
878 >            new ObjectInputStream(new BufferedInputStream(bin));
879 >        ReentrantLock r = (ReentrantLock) in.readObject();
880 >        r.lock();
881 >        r.unlock();
882 >    }
883 >
884 >    /**
885 >     * toString indicates current lock state
886 >     */
887 >    public void testToString() {
888 >        ReentrantLock lock = new ReentrantLock();
889 >        String us = lock.toString();
890 >        assertTrue(us.indexOf("Unlocked") >= 0);
891 >        lock.lock();
892 >        String ls = lock.toString();
893 >        assertTrue(ls.indexOf("Locked") >= 0);
894      }
895  
896   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines