ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ReentrantLockTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ReentrantLockTest.java (file contents):
Revision 1.43 by jsr166, Sat May 7 03:36:23 2011 UTC vs.
Revision 1.63 by jsr166, Fri Jul 3 05:48:30 2015 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 import junit.framework.*;
10 import java.util.concurrent.locks.*;
11 import java.util.concurrent.*;
9   import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 < import java.util.*;
11 < import java.io.*;
10 >
11 > import java.util.Arrays;
12 > import java.util.Collection;
13 > import java.util.HashSet;
14 > import java.util.concurrent.CountDownLatch;
15 > import java.util.concurrent.CyclicBarrier;
16 > import java.util.concurrent.locks.Condition;
17 > import java.util.concurrent.locks.ReentrantLock;
18 >
19 > import junit.framework.AssertionFailedError;
20 > import junit.framework.Test;
21 > import junit.framework.TestSuite;
22  
23   public class ReentrantLockTest extends JSR166TestCase {
24      public static void main(String[] args) {
25 <        junit.textui.TestRunner.run(suite());
25 >        main(suite(), args);
26      }
27      public static Test suite() {
28          return new TestSuite(ReentrantLockTest.class);
29      }
30  
31      /**
32 <     * A runnable calling lockInterruptibly
32 >     * A checked runnable calling lockInterruptibly
33       */
34      class InterruptibleLockRunnable extends CheckedRunnable {
35          final ReentrantLock lock;
36 <        InterruptibleLockRunnable(ReentrantLock l) { lock = l; }
36 >        InterruptibleLockRunnable(ReentrantLock lock) { this.lock = lock; }
37          public void realRun() throws InterruptedException {
38              lock.lockInterruptibly();
39          }
40      }
41  
35
42      /**
43 <     * A runnable calling lockInterruptibly that expects to be
43 >     * A checked runnable calling lockInterruptibly that expects to be
44       * interrupted
45       */
46      class InterruptedLockRunnable extends CheckedInterruptedRunnable {
47          final ReentrantLock lock;
48 <        InterruptedLockRunnable(ReentrantLock l) { lock = l; }
48 >        InterruptedLockRunnable(ReentrantLock lock) { this.lock = lock; }
49          public void realRun() throws InterruptedException {
50              lock.lockInterruptibly();
51          }
# Line 50 | Line 56 | public class ReentrantLockTest extends J
56       */
57      static class PublicReentrantLock extends ReentrantLock {
58          PublicReentrantLock() { super(); }
59 +        PublicReentrantLock(boolean fair) { super(fair); }
60 +        public Thread getOwner() {
61 +            return super.getOwner();
62 +        }
63          public Collection<Thread> getQueuedThreads() {
64              return super.getQueuedThreads();
65          }
# Line 59 | Line 69 | public class ReentrantLockTest extends J
69      }
70  
71      /**
72 +     * Releases write lock, checking that it had a hold count of 1.
73 +     */
74 +    void releaseLock(PublicReentrantLock lock) {
75 +        assertLockedByMoi(lock);
76 +        lock.unlock();
77 +        assertFalse(lock.isHeldByCurrentThread());
78 +        assertNotLocked(lock);
79 +    }
80 +
81 +    /**
82 +     * Spin-waits until lock.hasQueuedThread(t) becomes true.
83 +     */
84 +    void waitForQueuedThread(PublicReentrantLock lock, Thread t) {
85 +        long startTime = System.nanoTime();
86 +        while (!lock.hasQueuedThread(t)) {
87 +            if (millisElapsedSince(startTime) > LONG_DELAY_MS)
88 +                throw new AssertionFailedError("timed out");
89 +            Thread.yield();
90 +        }
91 +        assertTrue(t.isAlive());
92 +        assertNotSame(t, lock.getOwner());
93 +    }
94 +
95 +    /**
96 +     * Checks that lock is not locked.
97 +     */
98 +    void assertNotLocked(PublicReentrantLock lock) {
99 +        assertFalse(lock.isLocked());
100 +        assertFalse(lock.isHeldByCurrentThread());
101 +        assertNull(lock.getOwner());
102 +        assertEquals(0, lock.getHoldCount());
103 +    }
104 +
105 +    /**
106 +     * Checks that lock is locked by the given thread.
107 +     */
108 +    void assertLockedBy(PublicReentrantLock lock, Thread t) {
109 +        assertTrue(lock.isLocked());
110 +        assertSame(t, lock.getOwner());
111 +        assertEquals(t == Thread.currentThread(),
112 +                     lock.isHeldByCurrentThread());
113 +        assertEquals(t == Thread.currentThread(),
114 +                     lock.getHoldCount() > 0);
115 +    }
116 +
117 +    /**
118 +     * Checks that lock is locked by the current thread.
119 +     */
120 +    void assertLockedByMoi(PublicReentrantLock lock) {
121 +        assertLockedBy(lock, Thread.currentThread());
122 +    }
123 +
124 +    /**
125       * Checks that condition c has no waiters.
126       */
127      void assertHasNoWaiters(PublicReentrantLock lock, Condition c) {
# Line 80 | Line 143 | public class ReentrantLockTest extends J
143          lock.unlock();
144      }
145  
146 +    enum AwaitMethod { await, awaitTimed, awaitNanos, awaitUntil }
147 +
148      /**
149 <     * Constructor sets given fairness
149 >     * Awaits condition "indefinitely" using the specified AwaitMethod.
150       */
151 <    public void testConstructor() {
152 <        assertFalse(new ReentrantLock().isFair());
153 <        assertFalse(new ReentrantLock(false).isFair());
154 <        assertTrue(new ReentrantLock(true).isFair());
151 >    void await(Condition c, AwaitMethod awaitMethod)
152 >            throws InterruptedException {
153 >        long timeoutMillis = 2 * LONG_DELAY_MS;
154 >        switch (awaitMethod) {
155 >        case await:
156 >            c.await();
157 >            break;
158 >        case awaitTimed:
159 >            assertTrue(c.await(timeoutMillis, MILLISECONDS));
160 >            break;
161 >        case awaitNanos:
162 >            long timeoutNanos = MILLISECONDS.toNanos(timeoutMillis);
163 >            long nanosRemaining = c.awaitNanos(timeoutNanos);
164 >            assertTrue(nanosRemaining > timeoutNanos / 2);
165 >            assertTrue(nanosRemaining <= timeoutNanos);
166 >            break;
167 >        case awaitUntil:
168 >            assertTrue(c.awaitUntil(delayedDate(timeoutMillis)));
169 >            break;
170 >        default:
171 >            throw new AssertionError();
172 >        }
173      }
174  
175      /**
176 <     * locking an unlocked lock succeeds
176 >     * Constructor sets given fairness, and is in unlocked state
177       */
178 <    public void testLock() {
179 <        ReentrantLock rl = new ReentrantLock();
180 <        rl.lock();
181 <        assertTrue(rl.isLocked());
182 <        rl.unlock();
183 <        assertFalse(rl.isLocked());
178 >    public void testConstructor() {
179 >        PublicReentrantLock lock;
180 >
181 >        lock = new PublicReentrantLock();
182 >        assertFalse(lock.isFair());
183 >        assertNotLocked(lock);
184 >
185 >        lock = new PublicReentrantLock(true);
186 >        assertTrue(lock.isFair());
187 >        assertNotLocked(lock);
188 >
189 >        lock = new PublicReentrantLock(false);
190 >        assertFalse(lock.isFair());
191 >        assertNotLocked(lock);
192      }
193  
194      /**
195 <     * locking an unlocked fair lock succeeds
196 <     */
197 <    public void testFairLock() {
198 <        ReentrantLock rl = new ReentrantLock(true);
199 <        rl.lock();
200 <        assertTrue(rl.isLocked());
201 <        rl.unlock();
195 >     * locking an unlocked lock succeeds
196 >     */
197 >    public void testLock()      { testLock(false); }
198 >    public void testLock_fair() { testLock(true); }
199 >    public void testLock(boolean fair) {
200 >        PublicReentrantLock lock = new PublicReentrantLock(fair);
201 >        lock.lock();
202 >        assertLockedByMoi(lock);
203 >        releaseLock(lock);
204      }
205  
206      /**
207       * Unlocking an unlocked lock throws IllegalMonitorStateException
208       */
209 <    public void testUnlock_IllegalMonitorStateException() {
210 <        ReentrantLock rl = new ReentrantLock();
209 >    public void testUnlock_IMSE()      { testUnlock_IMSE(false); }
210 >    public void testUnlock_IMSE_fair() { testUnlock_IMSE(true); }
211 >    public void testUnlock_IMSE(boolean fair) {
212 >        ReentrantLock lock = new ReentrantLock(fair);
213          try {
214 <            rl.unlock();
214 >            lock.unlock();
215              shouldThrow();
216          } catch (IllegalMonitorStateException success) {}
217      }
# Line 124 | Line 219 | public class ReentrantLockTest extends J
219      /**
220       * tryLock on an unlocked lock succeeds
221       */
222 <    public void testTryLock() {
223 <        ReentrantLock rl = new ReentrantLock();
224 <        assertTrue(rl.tryLock());
225 <        assertTrue(rl.isLocked());
226 <        rl.unlock();
222 >    public void testTryLock()      { testTryLock(false); }
223 >    public void testTryLock_fair() { testTryLock(true); }
224 >    public void testTryLock(boolean fair) {
225 >        PublicReentrantLock lock = new PublicReentrantLock(fair);
226 >        assertTrue(lock.tryLock());
227 >        assertLockedByMoi(lock);
228 >        assertTrue(lock.tryLock());
229 >        assertLockedByMoi(lock);
230 >        lock.unlock();
231 >        releaseLock(lock);
232      }
233  
134
234      /**
235       * hasQueuedThreads reports whether there are waiting threads
236       */
237 <    public void testhasQueuedThreads() throws InterruptedException {
238 <        final ReentrantLock lock = new ReentrantLock();
237 >    public void testHasQueuedThreads()      { testHasQueuedThreads(false); }
238 >    public void testHasQueuedThreads_fair() { testHasQueuedThreads(true); }
239 >    public void testHasQueuedThreads(boolean fair) {
240 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
241          Thread t1 = new Thread(new InterruptedLockRunnable(lock));
242          Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
243          assertFalse(lock.hasQueuedThreads());
244          lock.lock();
245 +        assertFalse(lock.hasQueuedThreads());
246          t1.start();
247 <        delay(SHORT_DELAY_MS);
247 >        waitForQueuedThread(lock, t1);
248          assertTrue(lock.hasQueuedThreads());
249          t2.start();
250 <        delay(SHORT_DELAY_MS);
250 >        waitForQueuedThread(lock, t2);
251          assertTrue(lock.hasQueuedThreads());
252          t1.interrupt();
253 <        delay(SHORT_DELAY_MS);
253 >        awaitTermination(t1);
254          assertTrue(lock.hasQueuedThreads());
255          lock.unlock();
154        delay(SHORT_DELAY_MS);
155        assertFalse(lock.hasQueuedThreads());
156        awaitTermination(t1);
256          awaitTermination(t2);
257 +        assertFalse(lock.hasQueuedThreads());
258      }
259  
260      /**
261       * getQueueLength reports number of waiting threads
262       */
263 <    public void testGetQueueLength() throws InterruptedException {
264 <        final ReentrantLock lock = new ReentrantLock();
263 >    public void testGetQueueLength()      { testGetQueueLength(false); }
264 >    public void testGetQueueLength_fair() { testGetQueueLength(true); }
265 >    public void testGetQueueLength(boolean fair) {
266 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
267          Thread t1 = new Thread(new InterruptedLockRunnable(lock));
268          Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
269          assertEquals(0, lock.getQueueLength());
270          lock.lock();
271          t1.start();
272 <        delay(SHORT_DELAY_MS);
272 >        waitForQueuedThread(lock, t1);
273          assertEquals(1, lock.getQueueLength());
274          t2.start();
275 <        delay(SHORT_DELAY_MS);
275 >        waitForQueuedThread(lock, t2);
276          assertEquals(2, lock.getQueueLength());
277          t1.interrupt();
176        delay(SHORT_DELAY_MS);
177        assertEquals(1, lock.getQueueLength());
178        lock.unlock();
179        delay(SHORT_DELAY_MS);
180        assertEquals(0, lock.getQueueLength());
278          awaitTermination(t1);
182        awaitTermination(t2);
183    }
184
185    /**
186     * getQueueLength reports number of waiting threads
187     */
188    public void testGetQueueLength_fair() throws InterruptedException {
189        final ReentrantLock lock = new ReentrantLock(true);
190        Thread t1 = new Thread(new InterruptedLockRunnable(lock));
191        Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
192        assertEquals(0, lock.getQueueLength());
193        lock.lock();
194        t1.start();
195        delay(SHORT_DELAY_MS);
196        assertEquals(1, lock.getQueueLength());
197        t2.start();
198        delay(SHORT_DELAY_MS);
199        assertEquals(2, lock.getQueueLength());
200        t1.interrupt();
201        delay(SHORT_DELAY_MS);
279          assertEquals(1, lock.getQueueLength());
280          lock.unlock();
204        delay(SHORT_DELAY_MS);
205        assertEquals(0, lock.getQueueLength());
206        awaitTermination(t1);
281          awaitTermination(t2);
282 +        assertEquals(0, lock.getQueueLength());
283      }
284  
285      /**
286       * hasQueuedThread(null) throws NPE
287       */
288 <    public void testHasQueuedThreadNPE() {
289 <        final ReentrantLock sync = new ReentrantLock();
288 >    public void testHasQueuedThreadNPE()      { testHasQueuedThreadNPE(false); }
289 >    public void testHasQueuedThreadNPE_fair() { testHasQueuedThreadNPE(true); }
290 >    public void testHasQueuedThreadNPE(boolean fair) {
291 >        final ReentrantLock lock = new ReentrantLock(fair);
292          try {
293 <            sync.hasQueuedThread(null);
293 >            lock.hasQueuedThread(null);
294              shouldThrow();
295          } catch (NullPointerException success) {}
296      }
297  
298      /**
299 <     * hasQueuedThread reports whether a thread is queued.
299 >     * hasQueuedThread reports whether a thread is queued
300       */
301 <    public void testHasQueuedThread() throws InterruptedException {
302 <        final ReentrantLock sync = new ReentrantLock();
303 <        Thread t1 = new Thread(new InterruptedLockRunnable(sync));
304 <        Thread t2 = new Thread(new InterruptibleLockRunnable(sync));
305 <        assertFalse(sync.hasQueuedThread(t1));
306 <        assertFalse(sync.hasQueuedThread(t2));
307 <        sync.lock();
301 >    public void testHasQueuedThread()      { testHasQueuedThread(false); }
302 >    public void testHasQueuedThread_fair() { testHasQueuedThread(true); }
303 >    public void testHasQueuedThread(boolean fair) {
304 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
305 >        Thread t1 = new Thread(new InterruptedLockRunnable(lock));
306 >        Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
307 >        assertFalse(lock.hasQueuedThread(t1));
308 >        assertFalse(lock.hasQueuedThread(t2));
309 >        lock.lock();
310          t1.start();
311 <        delay(SHORT_DELAY_MS);
312 <        assertTrue(sync.hasQueuedThread(t1));
311 >        waitForQueuedThread(lock, t1);
312 >        assertTrue(lock.hasQueuedThread(t1));
313 >        assertFalse(lock.hasQueuedThread(t2));
314          t2.start();
315 <        delay(SHORT_DELAY_MS);
316 <        assertTrue(sync.hasQueuedThread(t1));
317 <        assertTrue(sync.hasQueuedThread(t2));
315 >        waitForQueuedThread(lock, t2);
316 >        assertTrue(lock.hasQueuedThread(t1));
317 >        assertTrue(lock.hasQueuedThread(t2));
318          t1.interrupt();
239        delay(SHORT_DELAY_MS);
240        assertFalse(sync.hasQueuedThread(t1));
241        assertTrue(sync.hasQueuedThread(t2));
242        sync.unlock();
243        delay(SHORT_DELAY_MS);
244        assertFalse(sync.hasQueuedThread(t1));
245        delay(SHORT_DELAY_MS);
246        assertFalse(sync.hasQueuedThread(t2));
319          awaitTermination(t1);
320 +        assertFalse(lock.hasQueuedThread(t1));
321 +        assertTrue(lock.hasQueuedThread(t2));
322 +        lock.unlock();
323          awaitTermination(t2);
324 +        assertFalse(lock.hasQueuedThread(t1));
325 +        assertFalse(lock.hasQueuedThread(t2));
326      }
327  
251
328      /**
329       * getQueuedThreads includes waiting threads
330       */
331 <    public void testGetQueuedThreads() throws InterruptedException {
332 <        final PublicReentrantLock lock = new PublicReentrantLock();
331 >    public void testGetQueuedThreads()      { testGetQueuedThreads(false); }
332 >    public void testGetQueuedThreads_fair() { testGetQueuedThreads(true); }
333 >    public void testGetQueuedThreads(boolean fair) {
334 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
335          Thread t1 = new Thread(new InterruptedLockRunnable(lock));
336          Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
337          assertTrue(lock.getQueuedThreads().isEmpty());
338          lock.lock();
339          assertTrue(lock.getQueuedThreads().isEmpty());
340          t1.start();
341 <        delay(SHORT_DELAY_MS);
341 >        waitForQueuedThread(lock, t1);
342 >        assertEquals(1, lock.getQueuedThreads().size());
343          assertTrue(lock.getQueuedThreads().contains(t1));
344          t2.start();
345 <        delay(SHORT_DELAY_MS);
345 >        waitForQueuedThread(lock, t2);
346 >        assertEquals(2, lock.getQueuedThreads().size());
347          assertTrue(lock.getQueuedThreads().contains(t1));
348          assertTrue(lock.getQueuedThreads().contains(t2));
349          t1.interrupt();
350 <        delay(SHORT_DELAY_MS);
350 >        awaitTermination(t1);
351          assertFalse(lock.getQueuedThreads().contains(t1));
352          assertTrue(lock.getQueuedThreads().contains(t2));
353 +        assertEquals(1, lock.getQueuedThreads().size());
354          lock.unlock();
274        delay(SHORT_DELAY_MS);
275        assertTrue(lock.getQueuedThreads().isEmpty());
276        awaitTermination(t1);
355          awaitTermination(t2);
356 +        assertTrue(lock.getQueuedThreads().isEmpty());
357      }
358  
280
359      /**
360 <     * timed tryLock is interruptible.
360 >     * timed tryLock is interruptible
361       */
362 <    public void testInterruptedException2() throws InterruptedException {
363 <        final ReentrantLock lock = new ReentrantLock();
362 >    public void testTryLock_Interruptible()      { testTryLock_Interruptible(false); }
363 >    public void testTryLock_Interruptible_fair() { testTryLock_Interruptible(true); }
364 >    public void testTryLock_Interruptible(boolean fair) {
365 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
366          lock.lock();
367          Thread t = newStartedThread(new CheckedInterruptedRunnable() {
368              public void realRun() throws InterruptedException {
369 <                lock.tryLock(MEDIUM_DELAY_MS,MILLISECONDS);
369 >                lock.tryLock(2 * LONG_DELAY_MS, MILLISECONDS);
370              }});
371  
372 <        delay(SHORT_DELAY_MS);
372 >        waitForQueuedThread(lock, t);
373          t.interrupt();
374          awaitTermination(t);
375 +        releaseLock(lock);
376      }
377  
297
378      /**
379 <     * TryLock on a locked lock fails
379 >     * tryLock on a locked lock fails
380       */
381 <    public void testTryLockWhenLocked() throws InterruptedException {
382 <        final ReentrantLock lock = new ReentrantLock();
381 >    public void testTryLockWhenLocked()      { testTryLockWhenLocked(false); }
382 >    public void testTryLockWhenLocked_fair() { testTryLockWhenLocked(true); }
383 >    public void testTryLockWhenLocked(boolean fair) {
384 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
385          lock.lock();
386          Thread t = newStartedThread(new CheckedRunnable() {
387              public void realRun() {
# Line 307 | Line 389 | public class ReentrantLockTest extends J
389              }});
390  
391          awaitTermination(t);
392 <        lock.unlock();
392 >        releaseLock(lock);
393      }
394  
395      /**
396       * Timed tryLock on a locked lock times out
397       */
398 <    public void testTryLock_Timeout() throws InterruptedException {
399 <        final ReentrantLock lock = new ReentrantLock();
398 >    public void testTryLock_Timeout()      { testTryLock_Timeout(false); }
399 >    public void testTryLock_Timeout_fair() { testTryLock_Timeout(true); }
400 >    public void testTryLock_Timeout(boolean fair) {
401 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
402          lock.lock();
403          Thread t = newStartedThread(new CheckedRunnable() {
404              public void realRun() throws InterruptedException {
405 <                assertFalse(lock.tryLock(1, MILLISECONDS));
405 >                long startTime = System.nanoTime();
406 >                long timeoutMillis = 10;
407 >                assertFalse(lock.tryLock(timeoutMillis, MILLISECONDS));
408 >                assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
409              }});
410  
411          awaitTermination(t);
412 <        lock.unlock();
412 >        releaseLock(lock);
413      }
414  
415      /**
416       * getHoldCount returns number of recursive holds
417       */
418 <    public void testGetHoldCount() {
419 <        ReentrantLock lock = new ReentrantLock();
418 >    public void testGetHoldCount()      { testGetHoldCount(false); }
419 >    public void testGetHoldCount_fair() { testGetHoldCount(true); }
420 >    public void testGetHoldCount(boolean fair) {
421 >        ReentrantLock lock = new ReentrantLock(fair);
422          for (int i = 1; i <= SIZE; i++) {
423              lock.lock();
424              assertEquals(i, lock.getHoldCount());
425          }
426          for (int i = SIZE; i > 0; i--) {
427              lock.unlock();
428 <            assertEquals(i-1, lock.getHoldCount());
428 >            assertEquals(i - 1, lock.getHoldCount());
429          }
430      }
431  
343
432      /**
433       * isLocked is true when locked and false when not
434       */
435 <    public void testIsLocked() throws InterruptedException {
436 <        final ReentrantLock lock = new ReentrantLock();
437 <        lock.lock();
438 <        assertTrue(lock.isLocked());
439 <        lock.unlock();
440 <        assertFalse(lock.isLocked());
441 <        Thread t = newStartedThread(new CheckedRunnable() {
442 <            public void realRun() throws InterruptedException {
443 <                lock.lock();
444 <                delay(SMALL_DELAY_MS);
445 <                lock.unlock();
446 <            }});
447 <
448 <        delay(SHORT_DELAY_MS);
449 <        assertTrue(lock.isLocked());
450 <        awaitTermination(t);
451 <        assertFalse(lock.isLocked());
452 <    }
453 <
454 <
455 <    /**
456 <     * lockInterruptibly is interruptible.
457 <     */
458 <    public void testLockInterruptibly1() throws InterruptedException {
459 <        final ReentrantLock lock = new ReentrantLock();
460 <        lock.lock();
461 <        Thread t = newStartedThread(new InterruptedLockRunnable(lock));
462 <        delay(SHORT_DELAY_MS);
463 <        t.interrupt();
464 <        delay(SHORT_DELAY_MS);
377 <        lock.unlock();
378 <        awaitTermination(t);
435 >    public void testIsLocked()      { testIsLocked(false); }
436 >    public void testIsLocked_fair() { testIsLocked(true); }
437 >    public void testIsLocked(boolean fair) {
438 >        try {
439 >            final ReentrantLock lock = new ReentrantLock(fair);
440 >            assertFalse(lock.isLocked());
441 >            lock.lock();
442 >            assertTrue(lock.isLocked());
443 >            lock.lock();
444 >            assertTrue(lock.isLocked());
445 >            lock.unlock();
446 >            assertTrue(lock.isLocked());
447 >            lock.unlock();
448 >            assertFalse(lock.isLocked());
449 >            final CyclicBarrier barrier = new CyclicBarrier(2);
450 >            Thread t = newStartedThread(new CheckedRunnable() {
451 >                    public void realRun() throws Exception {
452 >                        lock.lock();
453 >                        assertTrue(lock.isLocked());
454 >                        barrier.await();
455 >                        barrier.await();
456 >                        lock.unlock();
457 >                    }});
458 >
459 >            barrier.await();
460 >            assertTrue(lock.isLocked());
461 >            barrier.await();
462 >            awaitTermination(t);
463 >            assertFalse(lock.isLocked());
464 >        } catch (Exception fail) { threadUnexpectedException(fail); }
465      }
466  
467      /**
468       * lockInterruptibly succeeds when unlocked, else is interruptible
469       */
470 <    public void testLockInterruptibly2() throws InterruptedException {
471 <        final ReentrantLock lock = new ReentrantLock();
472 <        lock.lockInterruptibly();
470 >    public void testLockInterruptibly()      { testLockInterruptibly(false); }
471 >    public void testLockInterruptibly_fair() { testLockInterruptibly(true); }
472 >    public void testLockInterruptibly(boolean fair) {
473 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
474 >        try {
475 >            lock.lockInterruptibly();
476 >        } catch (InterruptedException fail) { threadUnexpectedException(fail); }
477 >        assertLockedByMoi(lock);
478          Thread t = newStartedThread(new InterruptedLockRunnable(lock));
479 <        delay(SHORT_DELAY_MS);
479 >        waitForQueuedThread(lock, t);
480          t.interrupt();
481          assertTrue(lock.isLocked());
482          assertTrue(lock.isHeldByCurrentThread());
483          awaitTermination(t);
484 +        releaseLock(lock);
485      }
486  
487      /**
488       * Calling await without holding lock throws IllegalMonitorStateException
489       */
490 <    public void testAwait_IllegalMonitor() throws InterruptedException {
491 <        final ReentrantLock lock = new ReentrantLock();
492 <        final Condition c = lock.newCondition();
493 <        try {
494 <            c.await();
495 <            shouldThrow();
496 <        } catch (IllegalMonitorStateException success) {}
490 >    public void testAwait_IMSE()      { testAwait_IMSE(false); }
491 >    public void testAwait_IMSE_fair() { testAwait_IMSE(true); }
492 >    public void testAwait_IMSE(boolean fair) {
493 >        final ReentrantLock lock = new ReentrantLock(fair);
494 >        final Condition c = lock.newCondition();
495 >        for (AwaitMethod awaitMethod : AwaitMethod.values()) {
496 >            long startTime = System.nanoTime();
497 >            try {
498 >                await(c, awaitMethod);
499 >                shouldThrow();
500 >            } catch (IllegalMonitorStateException success) {
501 >            } catch (InterruptedException e) { threadUnexpectedException(e); }
502 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
503 >        }
504      }
505  
506      /**
507       * Calling signal without holding lock throws IllegalMonitorStateException
508       */
509 <    public void testSignal_IllegalMonitor() {
510 <        final ReentrantLock lock = new ReentrantLock();
509 >    public void testSignal_IMSE()      { testSignal_IMSE(false); }
510 >    public void testSignal_IMSE_fair() { testSignal_IMSE(true); }
511 >    public void testSignal_IMSE(boolean fair) {
512 >        final ReentrantLock lock = new ReentrantLock(fair);
513          final Condition c = lock.newCondition();
514          try {
515              c.signal();
# Line 419 | Line 520 | public class ReentrantLockTest extends J
520      /**
521       * awaitNanos without a signal times out
522       */
523 <    public void testAwaitNanos_Timeout() throws InterruptedException {
524 <        final ReentrantLock lock = new ReentrantLock();
525 <        final Condition c = lock.newCondition();
526 <        lock.lock();
527 <        long t = c.awaitNanos(100);
528 <        assertTrue(t <= 0);
529 <        lock.unlock();
523 >    public void testAwaitNanos_Timeout()      { testAwaitNanos_Timeout(false); }
524 >    public void testAwaitNanos_Timeout_fair() { testAwaitNanos_Timeout(true); }
525 >    public void testAwaitNanos_Timeout(boolean fair) {
526 >        try {
527 >            final ReentrantLock lock = new ReentrantLock(fair);
528 >            final Condition c = lock.newCondition();
529 >            lock.lock();
530 >            long startTime = System.nanoTime();
531 >            long timeoutMillis = 10;
532 >            long timeoutNanos = MILLISECONDS.toNanos(timeoutMillis);
533 >            long nanosRemaining = c.awaitNanos(timeoutNanos);
534 >            assertTrue(nanosRemaining <= 0);
535 >            assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
536 >            lock.unlock();
537 >        } catch (InterruptedException fail) { threadUnexpectedException(fail); }
538      }
539  
540      /**
541       * timed await without a signal times out
542       */
543 <    public void testAwait_Timeout() throws InterruptedException {
544 <        final ReentrantLock lock = new ReentrantLock();
545 <        final Condition c = lock.newCondition();
546 <        lock.lock();
547 <        assertFalse(c.await(SHORT_DELAY_MS, MILLISECONDS));
548 <        lock.unlock();
543 >    public void testAwait_Timeout()      { testAwait_Timeout(false); }
544 >    public void testAwait_Timeout_fair() { testAwait_Timeout(true); }
545 >    public void testAwait_Timeout(boolean fair) {
546 >        try {
547 >            final ReentrantLock lock = new ReentrantLock(fair);
548 >            final Condition c = lock.newCondition();
549 >            lock.lock();
550 >            long startTime = System.nanoTime();
551 >            long timeoutMillis = 10;
552 >            assertFalse(c.await(timeoutMillis, MILLISECONDS));
553 >            assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
554 >            lock.unlock();
555 >        } catch (InterruptedException fail) { threadUnexpectedException(fail); }
556      }
557  
558      /**
559       * awaitUntil without a signal times out
560       */
561 <    public void testAwaitUntil_Timeout() throws InterruptedException {
562 <        final ReentrantLock lock = new ReentrantLock();
563 <        final Condition c = lock.newCondition();
564 <        lock.lock();
565 <        java.util.Date d = new java.util.Date();
566 <        assertFalse(c.awaitUntil(new java.util.Date(d.getTime() + 10)));
567 <        lock.unlock();
561 >    public void testAwaitUntil_Timeout()      { testAwaitUntil_Timeout(false); }
562 >    public void testAwaitUntil_Timeout_fair() { testAwaitUntil_Timeout(true); }
563 >    public void testAwaitUntil_Timeout(boolean fair) {
564 >        try {
565 >            final ReentrantLock lock = new ReentrantLock(fair);
566 >            final Condition c = lock.newCondition();
567 >            lock.lock();
568 >            // We shouldn't assume that nanoTime and currentTimeMillis
569 >            // use the same time source, so don't use nanoTime here.
570 >            java.util.Date delayedDate = delayedDate(timeoutMillis());
571 >            assertFalse(c.awaitUntil(delayedDate));
572 >            assertTrue(new java.util.Date().getTime() >= delayedDate.getTime());
573 >            lock.unlock();
574 >        } catch (InterruptedException fail) { threadUnexpectedException(fail); }
575      }
576  
577      /**
578       * await returns when signalled
579       */
580 <    public void testAwait() throws InterruptedException {
581 <        final ReentrantLock lock = new ReentrantLock();
580 >    public void testAwait()      { testAwait(false); }
581 >    public void testAwait_fair() { testAwait(true); }
582 >    public void testAwait(boolean fair) {
583 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
584          final Condition c = lock.newCondition();
585 +        final CountDownLatch locked = new CountDownLatch(1);
586          Thread t = newStartedThread(new CheckedRunnable() {
587              public void realRun() throws InterruptedException {
588                  lock.lock();
589 +                locked.countDown();
590                  c.await();
591                  lock.unlock();
592              }});
593  
594 <        delay(SHORT_DELAY_MS);
594 >        await(locked);
595          lock.lock();
596 +        assertHasWaiters(lock, c, t);
597          c.signal();
598 +        assertHasNoWaiters(lock, c);
599 +        assertTrue(t.isAlive());
600          lock.unlock();
601          awaitTermination(t);
602      }
# Line 474 | Line 604 | public class ReentrantLockTest extends J
604      /**
605       * hasWaiters throws NPE if null
606       */
607 <    public void testHasWaitersNPE() {
608 <        final ReentrantLock lock = new ReentrantLock();
607 >    public void testHasWaitersNPE()      { testHasWaitersNPE(false); }
608 >    public void testHasWaitersNPE_fair() { testHasWaitersNPE(true); }
609 >    public void testHasWaitersNPE(boolean fair) {
610 >        final ReentrantLock lock = new ReentrantLock(fair);
611          try {
612              lock.hasWaiters(null);
613              shouldThrow();
# Line 485 | Line 617 | public class ReentrantLockTest extends J
617      /**
618       * getWaitQueueLength throws NPE if null
619       */
620 <    public void testGetWaitQueueLengthNPE() {
621 <        final ReentrantLock lock = new ReentrantLock();
620 >    public void testGetWaitQueueLengthNPE()      { testGetWaitQueueLengthNPE(false); }
621 >    public void testGetWaitQueueLengthNPE_fair() { testGetWaitQueueLengthNPE(true); }
622 >    public void testGetWaitQueueLengthNPE(boolean fair) {
623 >        final ReentrantLock lock = new ReentrantLock(fair);
624          try {
625              lock.getWaitQueueLength(null);
626              shouldThrow();
627          } catch (NullPointerException success) {}
628      }
629  
496
630      /**
631       * getWaitingThreads throws NPE if null
632       */
633 <    public void testGetWaitingThreadsNPE() {
634 <        final PublicReentrantLock lock = new PublicReentrantLock();
633 >    public void testGetWaitingThreadsNPE()      { testGetWaitingThreadsNPE(false); }
634 >    public void testGetWaitingThreadsNPE_fair() { testGetWaitingThreadsNPE(true); }
635 >    public void testGetWaitingThreadsNPE(boolean fair) {
636 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
637          try {
638              lock.getWaitingThreads(null);
639              shouldThrow();
640          } catch (NullPointerException success) {}
641      }
642  
508
643      /**
644 <     * hasWaiters throws IAE if not owned
644 >     * hasWaiters throws IllegalArgumentException if not owned
645       */
646 <    public void testHasWaitersIAE() {
647 <        final ReentrantLock lock = new ReentrantLock();
646 >    public void testHasWaitersIAE()      { testHasWaitersIAE(false); }
647 >    public void testHasWaitersIAE_fair() { testHasWaitersIAE(true); }
648 >    public void testHasWaitersIAE(boolean fair) {
649 >        final ReentrantLock lock = new ReentrantLock(fair);
650          final Condition c = lock.newCondition();
651 <        final ReentrantLock lock2 = new ReentrantLock();
651 >        final ReentrantLock lock2 = new ReentrantLock(fair);
652          try {
653              lock2.hasWaiters(c);
654              shouldThrow();
# Line 520 | Line 656 | public class ReentrantLockTest extends J
656      }
657  
658      /**
659 <     * hasWaiters throws IMSE if not locked
659 >     * hasWaiters throws IllegalMonitorStateException if not locked
660       */
661 <    public void testHasWaitersIMSE() {
662 <        final ReentrantLock lock = new ReentrantLock();
661 >    public void testHasWaitersIMSE()      { testHasWaitersIMSE(false); }
662 >    public void testHasWaitersIMSE_fair() { testHasWaitersIMSE(true); }
663 >    public void testHasWaitersIMSE(boolean fair) {
664 >        final ReentrantLock lock = new ReentrantLock(fair);
665          final Condition c = lock.newCondition();
666          try {
667              lock.hasWaiters(c);
# Line 531 | Line 669 | public class ReentrantLockTest extends J
669          } catch (IllegalMonitorStateException success) {}
670      }
671  
534
672      /**
673 <     * getWaitQueueLength throws IAE if not owned
673 >     * getWaitQueueLength throws IllegalArgumentException if not owned
674       */
675 <    public void testGetWaitQueueLengthIAE() {
676 <        final ReentrantLock lock = new ReentrantLock();
675 >    public void testGetWaitQueueLengthIAE()      { testGetWaitQueueLengthIAE(false); }
676 >    public void testGetWaitQueueLengthIAE_fair() { testGetWaitQueueLengthIAE(true); }
677 >    public void testGetWaitQueueLengthIAE(boolean fair) {
678 >        final ReentrantLock lock = new ReentrantLock(fair);
679          final Condition c = lock.newCondition();
680 <        final ReentrantLock lock2 = new ReentrantLock();
680 >        final ReentrantLock lock2 = new ReentrantLock(fair);
681          try {
682              lock2.getWaitQueueLength(c);
683              shouldThrow();
# Line 546 | Line 685 | public class ReentrantLockTest extends J
685      }
686  
687      /**
688 <     * getWaitQueueLength throws IMSE if not locked
688 >     * getWaitQueueLength throws IllegalMonitorStateException if not locked
689       */
690 <    public void testGetWaitQueueLengthIMSE() {
691 <        final ReentrantLock lock = new ReentrantLock();
690 >    public void testGetWaitQueueLengthIMSE()      { testGetWaitQueueLengthIMSE(false); }
691 >    public void testGetWaitQueueLengthIMSE_fair() { testGetWaitQueueLengthIMSE(true); }
692 >    public void testGetWaitQueueLengthIMSE(boolean fair) {
693 >        final ReentrantLock lock = new ReentrantLock(fair);
694          final Condition c = lock.newCondition();
695          try {
696              lock.getWaitQueueLength(c);
# Line 557 | Line 698 | public class ReentrantLockTest extends J
698          } catch (IllegalMonitorStateException success) {}
699      }
700  
560
701      /**
702 <     * getWaitingThreads throws IAE if not owned
702 >     * getWaitingThreads throws IllegalArgumentException if not owned
703       */
704 <    public void testGetWaitingThreadsIAE() {
705 <        final PublicReentrantLock lock = new PublicReentrantLock();
704 >    public void testGetWaitingThreadsIAE()      { testGetWaitingThreadsIAE(false); }
705 >    public void testGetWaitingThreadsIAE_fair() { testGetWaitingThreadsIAE(true); }
706 >    public void testGetWaitingThreadsIAE(boolean fair) {
707 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
708          final Condition c = lock.newCondition();
709 <        final PublicReentrantLock lock2 = new PublicReentrantLock();
709 >        final PublicReentrantLock lock2 = new PublicReentrantLock(fair);
710          try {
711              lock2.getWaitingThreads(c);
712              shouldThrow();
# Line 572 | Line 714 | public class ReentrantLockTest extends J
714      }
715  
716      /**
717 <     * getWaitingThreads throws IMSE if not locked
717 >     * getWaitingThreads throws IllegalMonitorStateException if not locked
718       */
719 <    public void testGetWaitingThreadsIMSE() {
720 <        final PublicReentrantLock lock = new PublicReentrantLock();
719 >    public void testGetWaitingThreadsIMSE()      { testGetWaitingThreadsIMSE(false); }
720 >    public void testGetWaitingThreadsIMSE_fair() { testGetWaitingThreadsIMSE(true); }
721 >    public void testGetWaitingThreadsIMSE(boolean fair) {
722 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
723          final Condition c = lock.newCondition();
724          try {
725              lock.getWaitingThreads(c);
# Line 583 | Line 727 | public class ReentrantLockTest extends J
727          } catch (IllegalMonitorStateException success) {}
728      }
729  
586
730      /**
731       * hasWaiters returns true when a thread is waiting, else false
732       */
733 <    public void testHasWaiters() throws InterruptedException {
734 <        final ReentrantLock lock = new ReentrantLock();
733 >    public void testHasWaiters()      { testHasWaiters(false); }
734 >    public void testHasWaiters_fair() { testHasWaiters(true); }
735 >    public void testHasWaiters(boolean fair) {
736 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
737          final Condition c = lock.newCondition();
738 +        final CountDownLatch pleaseSignal = new CountDownLatch(1);
739          Thread t = newStartedThread(new CheckedRunnable() {
740              public void realRun() throws InterruptedException {
741                  lock.lock();
742 +                assertHasNoWaiters(lock, c);
743                  assertFalse(lock.hasWaiters(c));
744 <                assertEquals(0, lock.getWaitQueueLength(c));
744 >                pleaseSignal.countDown();
745                  c.await();
746 +                assertHasNoWaiters(lock, c);
747 +                assertFalse(lock.hasWaiters(c));
748                  lock.unlock();
749              }});
750  
751 <        delay(SHORT_DELAY_MS);
751 >        await(pleaseSignal);
752          lock.lock();
753 +        assertHasWaiters(lock, c, t);
754          assertTrue(lock.hasWaiters(c));
605        assertEquals(1, lock.getWaitQueueLength(c));
755          c.signal();
756 <        lock.unlock();
608 <        delay(SHORT_DELAY_MS);
609 <        lock.lock();
756 >        assertHasNoWaiters(lock, c);
757          assertFalse(lock.hasWaiters(c));
611        assertEquals(0, lock.getWaitQueueLength(c));
758          lock.unlock();
759          awaitTermination(t);
760 +        assertHasNoWaiters(lock, c);
761      }
762  
763      /**
764       * getWaitQueueLength returns number of waiting threads
765       */
766 <    public void testGetWaitQueueLength() throws InterruptedException {
767 <        final ReentrantLock lock = new ReentrantLock();
766 >    public void testGetWaitQueueLength()      { testGetWaitQueueLength(false); }
767 >    public void testGetWaitQueueLength_fair() { testGetWaitQueueLength(true); }
768 >    public void testGetWaitQueueLength(boolean fair) {
769 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
770          final Condition c = lock.newCondition();
771 <        Thread t1 = newStartedThread(new CheckedRunnable() {
771 >        final CountDownLatch locked1 = new CountDownLatch(1);
772 >        final CountDownLatch locked2 = new CountDownLatch(1);
773 >        Thread t1 = new Thread(new CheckedRunnable() {
774              public void realRun() throws InterruptedException {
775                  lock.lock();
776                  assertFalse(lock.hasWaiters(c));
777                  assertEquals(0, lock.getWaitQueueLength(c));
778 +                locked1.countDown();
779                  c.await();
780                  lock.unlock();
781              }});
782  
783 <        delay(SHORT_DELAY_MS);
632 <
633 <        Thread t2 = newStartedThread(new CheckedRunnable() {
783 >        Thread t2 = new Thread(new CheckedRunnable() {
784              public void realRun() throws InterruptedException {
785                  lock.lock();
786                  assertTrue(lock.hasWaiters(c));
787                  assertEquals(1, lock.getWaitQueueLength(c));
788 +                locked2.countDown();
789                  c.await();
790                  lock.unlock();
791              }});
792  
642        delay(SHORT_DELAY_MS);
793          lock.lock();
794 <        assertTrue(lock.hasWaiters(c));
645 <        assertEquals(2, lock.getWaitQueueLength(c));
646 <        c.signalAll();
794 >        assertEquals(0, lock.getWaitQueueLength(c));
795          lock.unlock();
796 <        delay(SHORT_DELAY_MS);
796 >
797 >        t1.start();
798 >        await(locked1);
799 >
800          lock.lock();
801 <        assertFalse(lock.hasWaiters(c));
802 <        assertEquals(0, lock.getWaitQueueLength(c));
801 >        assertHasWaiters(lock, c, t1);
802 >        assertEquals(1, lock.getWaitQueueLength(c));
803          lock.unlock();
804 +
805 +        t2.start();
806 +        await(locked2);
807 +
808 +        lock.lock();
809 +        assertHasWaiters(lock, c, t1, t2);
810 +        assertEquals(2, lock.getWaitQueueLength(c));
811 +        c.signalAll();
812 +        assertHasNoWaiters(lock, c);
813 +        lock.unlock();
814 +
815          awaitTermination(t1);
816          awaitTermination(t2);
817 +
818 +        assertHasNoWaiters(lock, c);
819      }
820  
821      /**
822       * getWaitingThreads returns only and all waiting threads
823       */
824 <    public void testGetWaitingThreads() throws InterruptedException {
825 <        final PublicReentrantLock lock = new PublicReentrantLock();
824 >    public void testGetWaitingThreads()      { testGetWaitingThreads(false); }
825 >    public void testGetWaitingThreads_fair() { testGetWaitingThreads(true); }
826 >    public void testGetWaitingThreads(boolean fair) {
827 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
828          final Condition c = lock.newCondition();
829 +        final CountDownLatch locked1 = new CountDownLatch(1);
830 +        final CountDownLatch locked2 = new CountDownLatch(1);
831          Thread t1 = new Thread(new CheckedRunnable() {
832              public void realRun() throws InterruptedException {
833                  lock.lock();
834                  assertTrue(lock.getWaitingThreads(c).isEmpty());
835 +                locked1.countDown();
836                  c.await();
837                  lock.unlock();
838              }});
# Line 672 | Line 841 | public class ReentrantLockTest extends J
841              public void realRun() throws InterruptedException {
842                  lock.lock();
843                  assertFalse(lock.getWaitingThreads(c).isEmpty());
844 +                locked2.countDown();
845                  c.await();
846                  lock.unlock();
847              }});
# Line 679 | Line 849 | public class ReentrantLockTest extends J
849          lock.lock();
850          assertTrue(lock.getWaitingThreads(c).isEmpty());
851          lock.unlock();
852 +
853          t1.start();
854 <        delay(SHORT_DELAY_MS);
854 >        await(locked1);
855 >
856 >        lock.lock();
857 >        assertHasWaiters(lock, c, t1);
858 >        assertTrue(lock.getWaitingThreads(c).contains(t1));
859 >        assertFalse(lock.getWaitingThreads(c).contains(t2));
860 >        assertEquals(1, lock.getWaitingThreads(c).size());
861 >        lock.unlock();
862 >
863          t2.start();
864 <        delay(SHORT_DELAY_MS);
864 >        await(locked2);
865 >
866          lock.lock();
867 <        assertTrue(lock.hasWaiters(c));
867 >        assertHasWaiters(lock, c, t1, t2);
868          assertTrue(lock.getWaitingThreads(c).contains(t1));
869          assertTrue(lock.getWaitingThreads(c).contains(t2));
870 +        assertEquals(2, lock.getWaitingThreads(c).size());
871          c.signalAll();
872 +        assertHasNoWaiters(lock, c);
873          lock.unlock();
874 <        delay(SHORT_DELAY_MS);
693 <        lock.lock();
694 <        assertFalse(lock.hasWaiters(c));
695 <        assertTrue(lock.getWaitingThreads(c).isEmpty());
696 <        lock.unlock();
874 >
875          awaitTermination(t1);
876          awaitTermination(t2);
699    }
700
701    /** A helper class for uninterruptible wait tests */
702    class UninterruptibleThread extends Thread {
703        private ReentrantLock lock;
704        private Condition c;
705
706        public volatile boolean canAwake = false;
707        public volatile boolean interrupted = false;
708        public volatile boolean lockStarted = false;
877  
878 <        public UninterruptibleThread(ReentrantLock lock, Condition c) {
711 <            this.lock = lock;
712 <            this.c = c;
713 <        }
714 <
715 <        public synchronized void run() {
716 <            lock.lock();
717 <            lockStarted = true;
718 <
719 <            while (!canAwake) {
720 <                c.awaitUninterruptibly();
721 <            }
722 <
723 <            interrupted = isInterrupted();
724 <            lock.unlock();
725 <        }
878 >        assertHasNoWaiters(lock, c);
879      }
880  
881      /**
882 <     * awaitUninterruptibly doesn't abort on interrupt
882 >     * awaitUninterruptibly is uninterruptible
883       */
884 <    public void testAwaitUninterruptibly() throws InterruptedException {
885 <        final ReentrantLock lock = new ReentrantLock();
884 >    public void testAwaitUninterruptibly()      { testAwaitUninterruptibly(false); }
885 >    public void testAwaitUninterruptibly_fair() { testAwaitUninterruptibly(true); }
886 >    public void testAwaitUninterruptibly(boolean fair) {
887 >        final ReentrantLock lock = new ReentrantLock(fair);
888          final Condition c = lock.newCondition();
889 <        UninterruptibleThread thread = new UninterruptibleThread(lock, c);
889 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(2);
890  
891 <        thread.start();
891 >        Thread t1 = newStartedThread(new CheckedRunnable() {
892 >            public void realRun() {
893 >                // Interrupt before awaitUninterruptibly
894 >                lock.lock();
895 >                pleaseInterrupt.countDown();
896 >                Thread.currentThread().interrupt();
897 >                c.awaitUninterruptibly();
898 >                assertTrue(Thread.interrupted());
899 >                lock.unlock();
900 >            }});
901  
902 <        while (!thread.lockStarted) {
903 <            delay(100);
904 <        }
902 >        Thread t2 = newStartedThread(new CheckedRunnable() {
903 >            public void realRun() {
904 >                // Interrupt during awaitUninterruptibly
905 >                lock.lock();
906 >                pleaseInterrupt.countDown();
907 >                c.awaitUninterruptibly();
908 >                assertTrue(Thread.interrupted());
909 >                lock.unlock();
910 >            }});
911  
912 +        await(pleaseInterrupt);
913          lock.lock();
914 <        try {
915 <            thread.interrupt();
916 <            thread.canAwake = true;
917 <            c.signal();
918 <        } finally {
919 <            lock.unlock();
920 <        }
914 >        lock.unlock();
915 >        t2.interrupt();
916 >
917 >        assertThreadStaysAlive(t1);
918 >        assertTrue(t2.isAlive());
919 >
920 >        lock.lock();
921 >        c.signalAll();
922 >        lock.unlock();
923  
924 <        thread.join();
925 <        assertTrue(thread.interrupted);
753 <        assertFalse(thread.isAlive());
924 >        awaitTermination(t1);
925 >        awaitTermination(t2);
926      }
927  
928      /**
929 <     * await is interruptible
929 >     * await/awaitNanos/awaitUntil is interruptible
930       */
931 <    public void testAwait_Interrupt() throws InterruptedException {
932 <        final PublicReentrantLock lock = new PublicReentrantLock();
931 >    public void testInterruptible_await()           { testInterruptible(false, AwaitMethod.await); }
932 >    public void testInterruptible_await_fair()      { testInterruptible(true,  AwaitMethod.await); }
933 >    public void testInterruptible_awaitTimed()      { testInterruptible(false, AwaitMethod.awaitTimed); }
934 >    public void testInterruptible_awaitTimed_fair() { testInterruptible(true,  AwaitMethod.awaitTimed); }
935 >    public void testInterruptible_awaitNanos()      { testInterruptible(false, AwaitMethod.awaitNanos); }
936 >    public void testInterruptible_awaitNanos_fair() { testInterruptible(true,  AwaitMethod.awaitNanos); }
937 >    public void testInterruptible_awaitUntil()      { testInterruptible(false, AwaitMethod.awaitUntil); }
938 >    public void testInterruptible_awaitUntil_fair() { testInterruptible(true,  AwaitMethod.awaitUntil); }
939 >    public void testInterruptible(boolean fair, final AwaitMethod awaitMethod) {
940 >        final PublicReentrantLock lock =
941 >            new PublicReentrantLock(fair);
942          final Condition c = lock.newCondition();
943 <        final CountDownLatch locked = new CountDownLatch(1);
943 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
944          Thread t = newStartedThread(new CheckedInterruptedRunnable() {
945              public void realRun() throws InterruptedException {
946                  lock.lock();
947 <                assertTrue(lock.isLocked());
767 <                assertTrue(lock.isHeldByCurrentThread());
947 >                assertLockedByMoi(lock);
948                  assertHasNoWaiters(lock, c);
949 <                locked.countDown();
949 >                pleaseInterrupt.countDown();
950                  try {
951 <                    c.await();
951 >                    await(c, awaitMethod);
952                  } finally {
953 <                    assertTrue(lock.isLocked());
774 <                    assertTrue(lock.isHeldByCurrentThread());
953 >                    assertLockedByMoi(lock);
954                      assertHasNoWaiters(lock, c);
955                      lock.unlock();
956                      assertFalse(Thread.interrupted());
957                  }
958              }});
959  
960 <        locked.await();
960 >        await(pleaseInterrupt);
961          assertHasWaiters(lock, c, t);
962          t.interrupt();
963          awaitTermination(t);
964 <        assertFalse(lock.isLocked());
964 >        assertNotLocked(lock);
965      }
966  
967      /**
968 <     * awaitNanos is interruptible
968 >     * signalAll wakes up all threads
969       */
970 <    public void testAwaitNanos_Interrupt() throws InterruptedException {
971 <        final ReentrantLock lock = new ReentrantLock();
970 >    public void testSignalAll_await()           { testSignalAll(false, AwaitMethod.await); }
971 >    public void testSignalAll_await_fair()      { testSignalAll(true,  AwaitMethod.await); }
972 >    public void testSignalAll_awaitTimed()      { testSignalAll(false, AwaitMethod.awaitTimed); }
973 >    public void testSignalAll_awaitTimed_fair() { testSignalAll(true,  AwaitMethod.awaitTimed); }
974 >    public void testSignalAll_awaitNanos()      { testSignalAll(false, AwaitMethod.awaitNanos); }
975 >    public void testSignalAll_awaitNanos_fair() { testSignalAll(true,  AwaitMethod.awaitNanos); }
976 >    public void testSignalAll_awaitUntil()      { testSignalAll(false, AwaitMethod.awaitUntil); }
977 >    public void testSignalAll_awaitUntil_fair() { testSignalAll(true,  AwaitMethod.awaitUntil); }
978 >    public void testSignalAll(boolean fair, final AwaitMethod awaitMethod) {
979 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
980          final Condition c = lock.newCondition();
981 <        Thread t = newStartedThread(new CheckedInterruptedRunnable() {
981 >        final CountDownLatch pleaseSignal = new CountDownLatch(2);
982 >        class Awaiter extends CheckedRunnable {
983              public void realRun() throws InterruptedException {
984                  lock.lock();
985 <                c.awaitNanos(MILLISECONDS.toNanos(LONG_DELAY_MS));
986 <            }});
987 <
988 <        delay(SHORT_DELAY_MS);
989 <        t.interrupt();
802 <        awaitTermination(t);
803 <    }
985 >                pleaseSignal.countDown();
986 >                await(c, awaitMethod);
987 >                lock.unlock();
988 >            }
989 >        }
990  
991 <    /**
992 <     * awaitUntil is interruptible
807 <     */
808 <    public void testAwaitUntil_Interrupt() throws InterruptedException {
809 <        final ReentrantLock lock = new ReentrantLock();
810 <        final Condition c = lock.newCondition();
811 <        Thread t = newStartedThread(new CheckedInterruptedRunnable() {
812 <            public void realRun() throws InterruptedException {
813 <                lock.lock();
814 <                java.util.Date d = new java.util.Date();
815 <                c.awaitUntil(new java.util.Date(d.getTime() + 10000));
816 <            }});
991 >        Thread t1 = newStartedThread(new Awaiter());
992 >        Thread t2 = newStartedThread(new Awaiter());
993  
994 <        delay(SHORT_DELAY_MS);
995 <        t.interrupt();
996 <        awaitTermination(t);
994 >        await(pleaseSignal);
995 >        lock.lock();
996 >        assertHasWaiters(lock, c, t1, t2);
997 >        c.signalAll();
998 >        assertHasNoWaiters(lock, c);
999 >        lock.unlock();
1000 >        awaitTermination(t1);
1001 >        awaitTermination(t2);
1002      }
1003  
1004      /**
1005 <     * signalAll wakes up all threads
1005 >     * signal wakes up waiting threads in FIFO order
1006       */
1007 <    public void testSignalAll() throws InterruptedException {
1008 <        final ReentrantLock lock = new ReentrantLock();
1007 >    public void testSignalWakesFifo()      { testSignalWakesFifo(false); }
1008 >    public void testSignalWakesFifo_fair() { testSignalWakesFifo(true); }
1009 >    public void testSignalWakesFifo(boolean fair) {
1010 >        final PublicReentrantLock lock =
1011 >            new PublicReentrantLock(fair);
1012          final Condition c = lock.newCondition();
1013 +        final CountDownLatch locked1 = new CountDownLatch(1);
1014 +        final CountDownLatch locked2 = new CountDownLatch(1);
1015          Thread t1 = newStartedThread(new CheckedRunnable() {
1016              public void realRun() throws InterruptedException {
1017                  lock.lock();
1018 +                locked1.countDown();
1019                  c.await();
1020                  lock.unlock();
1021              }});
1022  
1023 +        await(locked1);
1024 +
1025          Thread t2 = newStartedThread(new CheckedRunnable() {
1026              public void realRun() throws InterruptedException {
1027                  lock.lock();
1028 +                locked2.countDown();
1029                  c.await();
1030                  lock.unlock();
1031              }});
1032  
1033 <        delay(SHORT_DELAY_MS);
1033 >        await(locked2);
1034 >
1035          lock.lock();
1036 <        c.signalAll();
1036 >        assertHasWaiters(lock, c, t1, t2);
1037 >        assertFalse(lock.hasQueuedThreads());
1038 >        c.signal();
1039 >        assertHasWaiters(lock, c, t2);
1040 >        assertTrue(lock.hasQueuedThread(t1));
1041 >        assertFalse(lock.hasQueuedThread(t2));
1042 >        c.signal();
1043 >        assertHasNoWaiters(lock, c);
1044 >        assertTrue(lock.hasQueuedThread(t1));
1045 >        assertTrue(lock.hasQueuedThread(t2));
1046          lock.unlock();
1047          awaitTermination(t1);
1048          awaitTermination(t2);
# Line 851 | Line 1051 | public class ReentrantLockTest extends J
1051      /**
1052       * await after multiple reentrant locking preserves lock count
1053       */
1054 <    public void testAwaitLockCount() throws InterruptedException {
1055 <        final ReentrantLock lock = new ReentrantLock();
1054 >    public void testAwaitLockCount()      { testAwaitLockCount(false); }
1055 >    public void testAwaitLockCount_fair() { testAwaitLockCount(true); }
1056 >    public void testAwaitLockCount(boolean fair) {
1057 >        final PublicReentrantLock lock = new PublicReentrantLock(fair);
1058          final Condition c = lock.newCondition();
1059 +        final CountDownLatch pleaseSignal = new CountDownLatch(2);
1060          Thread t1 = newStartedThread(new CheckedRunnable() {
1061              public void realRun() throws InterruptedException {
1062                  lock.lock();
1063 +                assertLockedByMoi(lock);
1064                  assertEquals(1, lock.getHoldCount());
1065 +                pleaseSignal.countDown();
1066                  c.await();
1067 +                assertLockedByMoi(lock);
1068                  assertEquals(1, lock.getHoldCount());
1069                  lock.unlock();
1070              }});
# Line 867 | Line 1073 | public class ReentrantLockTest extends J
1073              public void realRun() throws InterruptedException {
1074                  lock.lock();
1075                  lock.lock();
1076 +                assertLockedByMoi(lock);
1077                  assertEquals(2, lock.getHoldCount());
1078 +                pleaseSignal.countDown();
1079                  c.await();
1080 +                assertLockedByMoi(lock);
1081                  assertEquals(2, lock.getHoldCount());
1082                  lock.unlock();
1083                  lock.unlock();
1084              }});
1085  
1086 <        delay(SHORT_DELAY_MS);
1086 >        await(pleaseSignal);
1087          lock.lock();
1088 +        assertHasWaiters(lock, c, t1, t2);
1089 +        assertEquals(1, lock.getHoldCount());
1090          c.signalAll();
1091 +        assertHasNoWaiters(lock, c);
1092          lock.unlock();
1093          awaitTermination(t1);
1094          awaitTermination(t2);
# Line 885 | Line 1097 | public class ReentrantLockTest extends J
1097      /**
1098       * A serialized lock deserializes as unlocked
1099       */
1100 <    public void testSerialization() throws Exception {
1101 <        ReentrantLock l = new ReentrantLock();
1102 <        l.lock();
1103 <        l.unlock();
1104 <
1105 <        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
1106 <        ObjectOutputStream out =
1107 <            new ObjectOutputStream(new BufferedOutputStream(bout));
1108 <        out.writeObject(l);
1109 <        out.close();
1110 <
1111 <        ByteArrayInputStream bin =
1112 <            new ByteArrayInputStream(bout.toByteArray());
1113 <        ObjectInputStream in =
1114 <            new ObjectInputStream(new BufferedInputStream(bin));
1115 <        ReentrantLock r = (ReentrantLock) in.readObject();
1116 <        r.lock();
1117 <        r.unlock();
1100 >    public void testSerialization()      { testSerialization(false); }
1101 >    public void testSerialization_fair() { testSerialization(true); }
1102 >    public void testSerialization(boolean fair) {
1103 >        ReentrantLock lock = new ReentrantLock(fair);
1104 >        lock.lock();
1105 >
1106 >        ReentrantLock clone = serialClone(lock);
1107 >        assertEquals(lock.isFair(), clone.isFair());
1108 >        assertTrue(lock.isLocked());
1109 >        assertFalse(clone.isLocked());
1110 >        assertEquals(1, lock.getHoldCount());
1111 >        assertEquals(0, clone.getHoldCount());
1112 >        clone.lock();
1113 >        clone.lock();
1114 >        assertTrue(clone.isLocked());
1115 >        assertEquals(2, clone.getHoldCount());
1116 >        assertEquals(1, lock.getHoldCount());
1117 >        clone.unlock();
1118 >        clone.unlock();
1119 >        assertTrue(lock.isLocked());
1120 >        assertFalse(clone.isLocked());
1121      }
1122  
1123      /**
1124       * toString indicates current lock state
1125       */
1126 <    public void testToString() {
1127 <        ReentrantLock lock = new ReentrantLock();
1128 <        String us = lock.toString();
1129 <        assertTrue(us.indexOf("Unlocked") >= 0);
1126 >    public void testToString()      { testToString(false); }
1127 >    public void testToString_fair() { testToString(true); }
1128 >    public void testToString(boolean fair) {
1129 >        ReentrantLock lock = new ReentrantLock(fair);
1130 >        assertTrue(lock.toString().contains("Unlocked"));
1131          lock.lock();
1132 <        String ls = lock.toString();
1133 <        assertTrue(ls.indexOf("Locked") >= 0);
1132 >        assertTrue(lock.toString().contains("Locked"));
1133 >        lock.unlock();
1134 >        assertTrue(lock.toString().contains("Unlocked"));
1135      }
919
1136   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines