ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ReentrantReadWriteLockTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ReentrantReadWriteLockTest.java (file contents):
Revision 1.2 by dl, Sun Sep 7 20:39:11 2003 UTC vs.
Revision 1.40 by jsr166, Tue Dec 1 06:03:49 2009 UTC

# Line 1 | Line 1
1   /*
2 < * Written by members of JCP JSR-166 Expert Group and released to the
3 < * public domain. Use, modify, and redistribute this code in any way
4 < * without acknowledgement. Other contributors include Andrew Wright,
5 < * Jeffrey Hayes, Pat Fischer, Mike Judd.
2 > * Written by Doug Lea with assistance from members of JCP JSR-166
3 > * Expert Group and released to the public domain, as explained at
4 > * http://creativecommons.org/licenses/publicdomain
5 > * Other contributors include Andrew Wright, Jeffrey Hayes,
6 > * Pat Fisher, Mike Judd.
7   */
8  
9   import junit.framework.*;
10   import java.util.concurrent.locks.*;
11   import java.util.concurrent.*;
12 + import static java.util.concurrent.TimeUnit.MILLISECONDS;
13   import java.io.*;
14 + import java.util.*;
15  
16 < public class ReentrantReadWriteLockTest extends TestCase {
14 <    static int HOLD_COUNT_TEST_LIMIT = 20;
15 <    
16 > public class ReentrantReadWriteLockTest extends JSR166TestCase {
17      public static void main(String[] args) {
18 <        junit.textui.TestRunner.run (suite());  
18 >        junit.textui.TestRunner.run (suite());
19      }
19    
20      public static Test suite() {
21 <        return new TestSuite(ReentrantReadWriteLockTest.class);
21 >        return new TestSuite(ReentrantReadWriteLockTest.class);
22      }
23  
24 +    /**
25 +     * A runnable calling lockInterruptibly
26 +     */
27 +    class InterruptibleLockRunnable extends CheckedRunnable {
28 +        final ReentrantReadWriteLock lock;
29 +        InterruptibleLockRunnable(ReentrantReadWriteLock l) { lock = l; }
30 +        public void realRun() throws InterruptedException {
31 +            lock.writeLock().lockInterruptibly();
32 +        }
33 +    }
34  
25    private static long SHORT_DELAY_MS = 100;
26    private static long MEDIUM_DELAY_MS = 1000;
27    private static long LONG_DELAY_MS = 10000;
35  
36 <    /*
37 <     * Unlocks an unlocked lock, throws Illegal Monitor State
38 <     *
36 >    /**
37 >     * A runnable calling lockInterruptibly that expects to be
38 >     * interrupted
39       */
40 <    
41 <    public void testIllegalMonitorStateException(){
42 <        ReentrantReadWriteLock rl = new ReentrantReadWriteLock();
43 <        try{
44 <            rl.writeLock().unlock();
45 <            fail("Should of thown Illegal Monitor State Exception");
40 >    class InterruptedLockRunnable extends CheckedInterruptedRunnable {
41 >        final ReentrantReadWriteLock lock;
42 >        InterruptedLockRunnable(ReentrantReadWriteLock l) { lock = l; }
43 >        public void realRun() throws InterruptedException {
44 >            lock.writeLock().lockInterruptibly();
45 >        }
46 >    }
47  
48 <        }catch(IllegalMonitorStateException success){}
48 >    /**
49 >     * Subclass to expose protected methods
50 >     */
51 >    static class PublicReentrantReadWriteLock extends ReentrantReadWriteLock {
52 >        PublicReentrantReadWriteLock() { super(); }
53 >        public Collection<Thread> getQueuedThreads() {
54 >            return super.getQueuedThreads();
55 >        }
56 >        public Collection<Thread> getWaitingThreads(Condition c) {
57 >            return super.getWaitingThreads(c);
58 >        }
59      }
60  
61 +    /**
62 +     * Constructor sets given fairness, and is in unlocked state
63 +     */
64 +    public void testConstructor() {
65 +        ReentrantReadWriteLock rl = new ReentrantReadWriteLock();
66 +        assertFalse(rl.isFair());
67 +        assertFalse(rl.isWriteLocked());
68 +        assertEquals(0, rl.getReadLockCount());
69 +        ReentrantReadWriteLock r2 = new ReentrantReadWriteLock(true);
70 +        assertTrue(r2.isFair());
71 +        assertFalse(r2.isWriteLocked());
72 +        assertEquals(0, r2.getReadLockCount());
73 +        ReentrantReadWriteLock r3 = new ReentrantReadWriteLock(false);
74 +        assertFalse(r3.isFair());
75 +        assertFalse(r3.isWriteLocked());
76 +        assertEquals(0, r3.getReadLockCount());
77 +    }
78  
79 +    /**
80 +     * write-locking and read-locking an unlocked lock succeed
81 +     */
82 +    public void testLock() {
83 +        ReentrantReadWriteLock rl = new ReentrantReadWriteLock();
84 +        rl.writeLock().lock();
85 +        assertTrue(rl.isWriteLocked());
86 +        assertTrue(rl.isWriteLockedByCurrentThread());
87 +        assertTrue(rl.writeLock().isHeldByCurrentThread());
88 +        assertEquals(0, rl.getReadLockCount());
89 +        rl.writeLock().unlock();
90 +        assertFalse(rl.isWriteLocked());
91 +        assertFalse(rl.isWriteLockedByCurrentThread());
92 +        assertFalse(rl.writeLock().isHeldByCurrentThread());
93 +        assertEquals(0, rl.getReadLockCount());
94 +        rl.readLock().lock();
95 +        assertFalse(rl.isWriteLocked());
96 +        assertFalse(rl.isWriteLockedByCurrentThread());
97 +        assertEquals(1, rl.getReadLockCount());
98 +        rl.readLock().unlock();
99 +        assertFalse(rl.isWriteLocked());
100 +        assertFalse(rl.isWriteLockedByCurrentThread());
101 +        assertEquals(0, rl.getReadLockCount());
102 +    }
103  
104 <    public void testInterruptedException(){
105 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
106 <        lock.writeLock().lock();
107 <        Thread t = new Thread(new Runnable() {
108 <                public void run(){
109 <                    try{
110 <                        lock.writeLock().lockInterruptibly();
111 <                        fail("should throw");
112 <                    }catch(InterruptedException success){}
113 <                }
114 <            });
115 <        try {
116 <            t.start();
117 <            t.interrupt();
118 <            lock.writeLock().unlock();
119 <            t.join();
120 <        } catch(Exception e){
121 <            fail("unexpected exception");
122 <        }
123 <    }
124 <
125 <    public void testInterruptedException2(){
126 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
127 <        lock.writeLock().lock();
69 <        Thread t = new Thread(new Runnable() {
70 <                public void run(){
71 <                    try{
72 <                        lock.writeLock().tryLock(1000,TimeUnit.MILLISECONDS);
73 <                        fail("should throw");
74 <                    }catch(InterruptedException success){}
75 <                }
76 <            });
77 <        try {
78 <            t.start();
79 <            t.interrupt();
80 <            lock.writeLock().unlock();
81 <            t.join();
82 <        } catch(Exception e){
83 <            fail("unexpected exception");
84 <        }
104 >
105 >    /**
106 >     * locking an unlocked fair lock succeeds
107 >     */
108 >    public void testFairLock() {
109 >        ReentrantReadWriteLock rl = new ReentrantReadWriteLock(true);
110 >        rl.writeLock().lock();
111 >        assertTrue(rl.isWriteLocked());
112 >        assertTrue(rl.isWriteLockedByCurrentThread());
113 >        assertTrue(rl.writeLock().isHeldByCurrentThread());
114 >        assertEquals(0, rl.getReadLockCount());
115 >        rl.writeLock().unlock();
116 >        assertFalse(rl.isWriteLocked());
117 >        assertFalse(rl.isWriteLockedByCurrentThread());
118 >        assertFalse(rl.writeLock().isHeldByCurrentThread());
119 >        assertEquals(0, rl.getReadLockCount());
120 >        rl.readLock().lock();
121 >        assertFalse(rl.isWriteLocked());
122 >        assertFalse(rl.isWriteLockedByCurrentThread());
123 >        assertEquals(1, rl.getReadLockCount());
124 >        rl.readLock().unlock();
125 >        assertFalse(rl.isWriteLocked());
126 >        assertFalse(rl.isWriteLockedByCurrentThread());
127 >        assertEquals(0, rl.getReadLockCount());
128      }
129  
130 <    public void testInterruptedException3(){
131 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
132 <        lock.writeLock().lock();
133 <        Thread t = new Thread(new Runnable() {
134 <                public void run(){
135 <                    try{
136 <                        lock.readLock().lockInterruptibly();
137 <                        fail("should throw");
138 <                    }catch(InterruptedException success){}
139 <                }
97 <            });
98 <        try {
99 <            t.start();
100 <            t.interrupt();
130 >    /**
131 >     * getWriteHoldCount returns number of recursive holds
132 >     */
133 >    public void testGetWriteHoldCount() {
134 >        ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
135 >        for (int i = 1; i <= SIZE; i++) {
136 >            lock.writeLock().lock();
137 >            assertEquals(i,lock.getWriteHoldCount());
138 >        }
139 >        for (int i = SIZE; i > 0; i--) {
140              lock.writeLock().unlock();
141 <            t.join();
103 <        } catch(Exception e){
104 <            fail("unexpected exception");
105 <        }
106 <    }
107 <
108 <    public void testInterruptedException4(){
109 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
110 <        lock.writeLock().lock();
111 <        Thread t = new Thread(new Runnable() {
112 <                public void run(){
113 <                    try{
114 <                        lock.readLock().tryLock(1000,TimeUnit.MILLISECONDS);
115 <                        fail("should throw");
116 <                    }catch(InterruptedException success){}
117 <                }
118 <            });
119 <        try {
120 <            t.start();
121 <            t.interrupt();
122 <            t.join();
123 <        } catch(Exception e){
124 <            fail("unexpected exception");
141 >            assertEquals(i-1,lock.getWriteHoldCount());
142          }
143      }
144  
145 <    
146 <    public void testTryLockWhenLocked() {
147 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
148 <        lock.writeLock().lock();
149 <        Thread t = new Thread(new Runnable() {
150 <                public void run(){
151 <                    assertFalse(lock.writeLock().tryLock());
152 <                }
136 <            });
137 <        try {
138 <            t.start();
139 <            t.join();
140 <            lock.writeLock().unlock();
141 <        } catch(Exception e){
142 <            fail("unexpected exception");
145 >    /**
146 >     * WriteLock.getHoldCount returns number of recursive holds
147 >     */
148 >    public void testGetHoldCount() {
149 >        ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
150 >        for (int i = 1; i <= SIZE; i++) {
151 >            lock.writeLock().lock();
152 >            assertEquals(i,lock.writeLock().getHoldCount());
153          }
154 <    }
145 <
146 <    public void testTryLockWhenLocked2() {
147 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
148 <        lock.writeLock().lock();
149 <        Thread t = new Thread(new Runnable() {
150 <                public void run(){
151 <                    assertFalse(lock.readLock().tryLock());
152 <                }
153 <            });
154 <        try {
155 <            t.start();
156 <            t.join();
154 >        for (int i = SIZE; i > 0; i--) {
155              lock.writeLock().unlock();
156 <        } catch(Exception e){
159 <            fail("unexpected exception");
156 >            assertEquals(i-1,lock.writeLock().getHoldCount());
157          }
158 <    }
158 >    }
159  
160 <    public void testMultipleReadLocks() {
161 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
162 <        lock.readLock().lock();
163 <        Thread t = new Thread(new Runnable() {
164 <                public void run(){
165 <                    assertTrue(lock.readLock().tryLock());
166 <                    lock.readLock().unlock();
167 <                }
171 <            });
172 <        try {
173 <            t.start();
174 <            t.join();
175 <            lock.readLock().unlock();
176 <        } catch(Exception e){
177 <            fail("unexpected exception");
160 >    /**
161 >     * getReadHoldCount returns number of recursive holds
162 >     */
163 >    public void testGetReadHoldCount() {
164 >        ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
165 >        for (int i = 1; i <= SIZE; i++) {
166 >            lock.readLock().lock();
167 >            assertEquals(i,lock.getReadHoldCount());
168          }
169 <    }
180 <
181 <    public void testWriteAfterMultipleReadLocks() {
182 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
183 <        lock.readLock().lock();
184 <        Thread t1 = new Thread(new Runnable() {
185 <                public void run(){
186 <                    lock.readLock().lock();
187 <                    lock.readLock().unlock();
188 <                }
189 <            });
190 <        Thread t2 = new Thread(new Runnable() {
191 <                public void run(){
192 <                    lock.writeLock().lock();
193 <                    lock.writeLock().unlock();
194 <                }
195 <            });
196 <
197 <        try {
198 <            t1.start();
199 <            t2.start();
200 <            Thread.sleep(SHORT_DELAY_MS);
169 >        for (int i = SIZE; i > 0; i--) {
170              lock.readLock().unlock();
171 <            t1.join(MEDIUM_DELAY_MS);
203 <            t2.join(MEDIUM_DELAY_MS);
204 <            assertTrue(!t1.isAlive());
205 <            assertTrue(!t2.isAlive());
206 <          
207 <        } catch(Exception e){
208 <            fail("unexpected exception");
209 <        }
210 <    }
211 <
212 <    public void testReadAfterWriteLock() {
213 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
214 <        lock.writeLock().lock();
215 <        Thread t1 = new Thread(new Runnable() {
216 <                public void run(){
217 <                    lock.readLock().lock();
218 <                    lock.readLock().unlock();
219 <                }
220 <            });
221 <        Thread t2 = new Thread(new Runnable() {
222 <                public void run(){
223 <                    lock.readLock().lock();
224 <                    lock.readLock().unlock();
225 <                }
226 <            });
227 <
228 <        try {
229 <            t1.start();
230 <            t2.start();
231 <            Thread.sleep(SHORT_DELAY_MS);
232 <            lock.writeLock().unlock();
233 <            t1.join(MEDIUM_DELAY_MS);
234 <            t2.join(MEDIUM_DELAY_MS);
235 <            assertTrue(!t1.isAlive());
236 <            assertTrue(!t2.isAlive());
237 <          
238 <        } catch(Exception e){
239 <            fail("unexpected exception");
240 <        }
241 <    }
242 <
243 <
244 <    public void testTryLockWhenReadLocked() {
245 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
246 <        lock.readLock().lock();
247 <        Thread t = new Thread(new Runnable() {
248 <                public void run(){
249 <                    assertTrue(lock.readLock().tryLock());
250 <                    lock.readLock().unlock();
251 <                }
252 <            });
253 <        try {
254 <            t.start();
255 <            t.join();
256 <            lock.readLock().unlock();
257 <        } catch(Exception e){
258 <            fail("unexpected exception");
171 >            assertEquals(i-1,lock.getReadHoldCount());
172          }
173 <    }
173 >    }
174  
262    
175  
176 <    public void testWriteTryLockWhenReadLocked() {
177 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
178 <        lock.readLock().lock();
179 <        Thread t = new Thread(new Runnable() {
180 <                public void run(){
269 <                    assertFalse(lock.writeLock().tryLock());
270 <                }
271 <            });
176 >    /**
177 >     * write-unlocking an unlocked lock throws IllegalMonitorStateException
178 >     */
179 >    public void testUnlock_IllegalMonitorStateException() {
180 >        ReentrantReadWriteLock rl = new ReentrantReadWriteLock();
181          try {
182 <            t.start();
183 <            t.join();
184 <            lock.readLock().unlock();
185 <        } catch(Exception e){
277 <            fail("unexpected exception");
278 <        }
279 <    }
182 >            rl.writeLock().unlock();
183 >            shouldThrow();
184 >        } catch (IllegalMonitorStateException success) {}
185 >    }
186  
281    
187  
188 <    public void testTryLock_Timeout(){
189 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
190 <        lock.writeLock().lock();
191 <        Thread t = new Thread(new Runnable() {
192 <                public void run(){
193 <                    try {
194 <                        assertFalse(lock.writeLock().tryLock(1, TimeUnit.MILLISECONDS));
195 <                    } catch (Exception ex) {
196 <                        fail("unexpected exception");
197 <                    }
198 <                }
199 <            });
200 <        try {
201 <            t.start();
202 <            t.join();
203 <            lock.writeLock().unlock();
204 <        } catch(Exception e){
205 <            fail("unexpected exception");
206 <        }
207 <    }
188 >    /**
189 >     * write-lockInterruptibly is interruptible
190 >     */
191 >    public void testWriteLockInterruptibly_Interrupted() throws Exception {
192 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
193 >        Thread t = new Thread(new CheckedInterruptedRunnable() {
194 >            public void realRun() throws InterruptedException {
195 >                lock.writeLock().lockInterruptibly();
196 >                lock.writeLock().unlock();
197 >                lock.writeLock().lockInterruptibly();
198 >                lock.writeLock().unlock();
199 >            }});
200 >
201 >        lock.writeLock().lock();
202 >        t.start();
203 >        Thread.sleep(SHORT_DELAY_MS);
204 >        t.interrupt();
205 >        Thread.sleep(SHORT_DELAY_MS);
206 >        lock.writeLock().unlock();
207 >        t.join();
208 >    }
209  
210 <    public void testTryLock_Timeout2(){
211 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
212 <        lock.writeLock().lock();
213 <        Thread t = new Thread(new Runnable() {
214 <                public void run(){
215 <                    try {
216 <                        assertFalse(lock.readLock().tryLock(1, TimeUnit.MILLISECONDS));
217 <                    } catch (Exception ex) {
218 <                        fail("unexpected exception");
219 <                    }
220 <                }
221 <            });
222 <        try {
223 <            t.start();
224 <            t.join();
225 <            lock.writeLock().unlock();
226 <        } catch(Exception e){
321 <            fail("unexpected exception");
322 <        }
323 <    }
210 >    /**
211 >     * timed write-tryLock is interruptible
212 >     */
213 >    public void testWriteTryLock_Interrupted() throws InterruptedException {
214 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
215 >        lock.writeLock().lock();
216 >        Thread t = new Thread(new CheckedInterruptedRunnable() {
217 >            public void realRun() throws InterruptedException {
218 >                lock.writeLock().tryLock(SMALL_DELAY_MS, MILLISECONDS);
219 >            }});
220 >
221 >        t.start();
222 >        Thread.sleep(SHORT_DELAY_MS);
223 >        t.interrupt();
224 >        lock.writeLock().unlock();
225 >        t.join();
226 >    }
227  
228 +    /**
229 +     * read-lockInterruptibly is interruptible
230 +     */
231 +    public void testReadLockInterruptibly_Interrupted() throws InterruptedException {
232 +        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
233 +        lock.writeLock().lock();
234 +        Thread t = new Thread(new CheckedInterruptedRunnable() {
235 +            public void realRun() throws InterruptedException {
236 +                lock.readLock().lockInterruptibly();
237 +            }});
238 +
239 +        t.start();
240 +        Thread.sleep(SHORT_DELAY_MS);
241 +        t.interrupt();
242 +        Thread.sleep(SHORT_DELAY_MS);
243 +        lock.writeLock().unlock();
244 +        t.join();
245 +    }
246  
247 <    public void testLockInterruptibly() {
248 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
249 <        try {
250 <            lock.writeLock().lockInterruptibly();
251 <        } catch(Exception e) {
252 <            fail("unexpected exception");
253 <        }
254 <        Thread t = new Thread(new Runnable() {
255 <                public void run() {
256 <                    try {
257 <                        lock.writeLock().lockInterruptibly();
258 <                        fail("should throw");
259 <                    }
260 <                    catch(InterruptedException success) {
261 <                    }
341 <                }
342 <            });
343 <        try {
344 <            t.start();
345 <            t.interrupt();
346 <            t.join();
347 <            lock.writeLock().unlock();
348 <        } catch(Exception e){
349 <            fail("unexpected exception");
350 <        }
247 >    /**
248 >     * timed read-tryLock is interruptible
249 >     */
250 >    public void testReadTryLock_Interrupted() throws InterruptedException {
251 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
252 >        lock.writeLock().lock();
253 >        Thread t = new Thread(new CheckedInterruptedRunnable() {
254 >            public void realRun() throws InterruptedException {
255 >                lock.readLock().tryLock(LONG_DELAY_MS, MILLISECONDS);
256 >            }});
257 >
258 >        t.start();
259 >        Thread.sleep(SHORT_DELAY_MS);
260 >        t.interrupt();
261 >        t.join();
262      }
263  
264 <    public void testLockInterruptibly2() {
265 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
266 <        try {
267 <            lock.writeLock().lockInterruptibly();
268 <        } catch(Exception e) {
269 <            fail("unexpected exception");
270 <        }
271 <        Thread t = new Thread(new Runnable() {
272 <                public void run() {
273 <                    try {
274 <                        lock.readLock().lockInterruptibly();
275 <                        fail("should throw");
276 <                    }
277 <                    catch(InterruptedException success) {
278 <                    }
368 <                }
369 <            });
370 <        try {
371 <            t.start();
372 <            t.interrupt();
373 <            t.join();
374 <            lock.writeLock().unlock();
375 <        } catch(Exception e){
376 <            fail("unexpected exception");
377 <        }
264 >
265 >    /**
266 >     * write-tryLock fails if locked
267 >     */
268 >    public void testWriteTryLockWhenLocked() throws InterruptedException {
269 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
270 >        lock.writeLock().lock();
271 >        Thread t = new Thread(new CheckedRunnable() {
272 >            public void realRun() {
273 >                threadAssertFalse(lock.writeLock().tryLock());
274 >            }});
275 >
276 >        t.start();
277 >        t.join();
278 >        lock.writeLock().unlock();
279      }
280  
281 <    public void testAwait_IllegalMonitor() {
282 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();      
281 >    /**
282 >     * read-tryLock fails if locked
283 >     */
284 >    public void testReadTryLockWhenLocked() throws InterruptedException {
285 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
286 >        lock.writeLock().lock();
287 >        Thread t = new Thread(new CheckedRunnable() {
288 >            public void realRun() {
289 >                threadAssertFalse(lock.readLock().tryLock());
290 >            }});
291 >
292 >        t.start();
293 >        t.join();
294 >        lock.writeLock().unlock();
295 >    }
296 >
297 >    /**
298 >     * Multiple threads can hold a read lock when not write-locked
299 >     */
300 >    public void testMultipleReadLocks() throws InterruptedException {
301 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
302 >        lock.readLock().lock();
303 >        Thread t = new Thread(new CheckedRunnable() {
304 >            public void realRun() {
305 >                threadAssertTrue(lock.readLock().tryLock());
306 >                lock.readLock().unlock();
307 >            }});
308 >
309 >        t.start();
310 >        t.join();
311 >        lock.readLock().unlock();
312 >    }
313 >
314 >    /**
315 >     * A writelock succeeds after reading threads unlock
316 >     */
317 >    public void testWriteAfterMultipleReadLocks() throws InterruptedException {
318 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
319 >        lock.readLock().lock();
320 >        Thread t1 = new Thread(new CheckedRunnable() {
321 >            public void realRun() {
322 >                lock.readLock().lock();
323 >                lock.readLock().unlock();
324 >            }});
325 >        Thread t2 = new Thread(new CheckedRunnable() {
326 >            public void realRun() {
327 >                lock.writeLock().lock();
328 >                lock.writeLock().unlock();
329 >            }});
330 >
331 >        t1.start();
332 >        t2.start();
333 >        Thread.sleep(SHORT_DELAY_MS);
334 >        lock.readLock().unlock();
335 >        t1.join(MEDIUM_DELAY_MS);
336 >        t2.join(MEDIUM_DELAY_MS);
337 >        assertTrue(!t1.isAlive());
338 >        assertTrue(!t2.isAlive());
339 >    }
340 >
341 >    /**
342 >     * Readlocks succeed after a writing thread unlocks
343 >     */
344 >    public void testReadAfterWriteLock() throws InterruptedException {
345 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
346 >        lock.writeLock().lock();
347 >        Thread t1 = new Thread(new CheckedRunnable() {
348 >            public void realRun() {
349 >                lock.readLock().lock();
350 >                lock.readLock().unlock();
351 >            }});
352 >        Thread t2 = new Thread(new CheckedRunnable() {
353 >            public void realRun() {
354 >                lock.readLock().lock();
355 >                lock.readLock().unlock();
356 >            }});
357 >
358 >        t1.start();
359 >        t2.start();
360 >        Thread.sleep(SHORT_DELAY_MS);
361 >        lock.writeLock().unlock();
362 >        t1.join(MEDIUM_DELAY_MS);
363 >        t2.join(MEDIUM_DELAY_MS);
364 >        assertTrue(!t1.isAlive());
365 >        assertTrue(!t2.isAlive());
366 >    }
367 >
368 >    /**
369 >     * Read trylock succeeds if write locked by current thread
370 >     */
371 >    public void testReadHoldingWriteLock() {
372 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
373 >        lock.writeLock().lock();
374 >        assertTrue(lock.readLock().tryLock());
375 >        lock.readLock().unlock();
376 >        lock.writeLock().unlock();
377 >    }
378 >
379 >    /**
380 >     * Read lock succeeds if write locked by current thread even if
381 >     * other threads are waiting for readlock
382 >     */
383 >    public void testReadHoldingWriteLock2() throws InterruptedException {
384 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
385 >        lock.writeLock().lock();
386 >        Thread t1 = new Thread(new CheckedRunnable() {
387 >            public void realRun() {
388 >                lock.readLock().lock();
389 >                lock.readLock().unlock();
390 >            }});
391 >        Thread t2 = new Thread(new CheckedRunnable() {
392 >            public void realRun() {
393 >                lock.readLock().lock();
394 >                lock.readLock().unlock();
395 >            }});
396 >
397 >        t1.start();
398 >        t2.start();
399 >        lock.readLock().lock();
400 >        lock.readLock().unlock();
401 >        Thread.sleep(SHORT_DELAY_MS);
402 >        lock.readLock().lock();
403 >        lock.readLock().unlock();
404 >        lock.writeLock().unlock();
405 >        t1.join(MEDIUM_DELAY_MS);
406 >        t2.join(MEDIUM_DELAY_MS);
407 >        assertTrue(!t1.isAlive());
408 >        assertTrue(!t2.isAlive());
409 >    }
410 >
411 >    /**
412 >     *  Read lock succeeds if write locked by current thread even if
413 >     * other threads are waiting for writelock
414 >     */
415 >    public void testReadHoldingWriteLock3() throws InterruptedException {
416 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
417 >        lock.writeLock().lock();
418 >        Thread t1 = new Thread(new CheckedRunnable() {
419 >            public void realRun() {
420 >                lock.writeLock().lock();
421 >                lock.writeLock().unlock();
422 >            }});
423 >        Thread t2 = new Thread(new CheckedRunnable() {
424 >            public void realRun() {
425 >                lock.writeLock().lock();
426 >                lock.writeLock().unlock();
427 >            }});
428 >
429 >        t1.start();
430 >        t2.start();
431 >        lock.readLock().lock();
432 >        lock.readLock().unlock();
433 >        Thread.sleep(SHORT_DELAY_MS);
434 >        lock.readLock().lock();
435 >        lock.readLock().unlock();
436 >        lock.writeLock().unlock();
437 >        t1.join(MEDIUM_DELAY_MS);
438 >        t2.join(MEDIUM_DELAY_MS);
439 >        assertTrue(!t1.isAlive());
440 >        assertTrue(!t2.isAlive());
441 >    }
442 >
443 >
444 >    /**
445 >     *  Write lock succeeds if write locked by current thread even if
446 >     * other threads are waiting for writelock
447 >     */
448 >    public void testWriteHoldingWriteLock4() throws InterruptedException {
449 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
450 >        lock.writeLock().lock();
451 >        Thread t1 = new Thread(new CheckedRunnable() {
452 >            public void realRun() {
453 >                lock.writeLock().lock();
454 >                lock.writeLock().unlock();
455 >            }});
456 >        Thread t2 = new Thread(new CheckedRunnable() {
457 >            public void realRun() {
458 >                lock.writeLock().lock();
459 >                lock.writeLock().unlock();
460 >            }});
461 >
462 >        t1.start();
463 >        t2.start();
464 >        lock.writeLock().lock();
465 >        lock.writeLock().unlock();
466 >        Thread.sleep(SHORT_DELAY_MS);
467 >        lock.writeLock().lock();
468 >        lock.writeLock().unlock();
469 >        lock.writeLock().unlock();
470 >        t1.join(MEDIUM_DELAY_MS);
471 >        t2.join(MEDIUM_DELAY_MS);
472 >        assertTrue(!t1.isAlive());
473 >        assertTrue(!t2.isAlive());
474 >    }
475 >
476 >
477 >    /**
478 >     * Fair Read trylock succeeds if write locked by current thread
479 >     */
480 >    public void testReadHoldingWriteLockFair() {
481 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(true);
482 >        lock.writeLock().lock();
483 >        assertTrue(lock.readLock().tryLock());
484 >        lock.readLock().unlock();
485 >        lock.writeLock().unlock();
486 >    }
487 >
488 >    /**
489 >     * Fair Read lock succeeds if write locked by current thread even if
490 >     * other threads are waiting for readlock
491 >     */
492 >    public void testReadHoldingWriteLockFair2() throws InterruptedException {
493 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(true);
494 >        lock.writeLock().lock();
495 >        Thread t1 = new Thread(new CheckedRunnable() {
496 >            public void realRun() {
497 >                lock.readLock().lock();
498 >                lock.readLock().unlock();
499 >            }});
500 >        Thread t2 = new Thread(new CheckedRunnable() {
501 >            public void realRun() {
502 >                lock.readLock().lock();
503 >                lock.readLock().unlock();
504 >            }});
505 >
506 >        t1.start();
507 >        t2.start();
508 >        lock.readLock().lock();
509 >        lock.readLock().unlock();
510 >        Thread.sleep(SHORT_DELAY_MS);
511 >        lock.readLock().lock();
512 >        lock.readLock().unlock();
513 >        lock.writeLock().unlock();
514 >        t1.join(MEDIUM_DELAY_MS);
515 >        t2.join(MEDIUM_DELAY_MS);
516 >        assertTrue(!t1.isAlive());
517 >        assertTrue(!t2.isAlive());
518 >    }
519 >
520 >
521 >    /**
522 >     * Fair Read lock succeeds if write locked by current thread even if
523 >     * other threads are waiting for writelock
524 >     */
525 >    public void testReadHoldingWriteLockFair3() throws InterruptedException {
526 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(true);
527 >        lock.writeLock().lock();
528 >        Thread t1 = new Thread(new CheckedRunnable() {
529 >            public void realRun() {
530 >                lock.writeLock().lock();
531 >                lock.writeLock().unlock();
532 >            }});
533 >        Thread t2 = new Thread(new CheckedRunnable() {
534 >            public void realRun() {
535 >                lock.writeLock().lock();
536 >                lock.writeLock().unlock();
537 >            }});
538 >
539 >        t1.start();
540 >        t2.start();
541 >        lock.readLock().lock();
542 >        lock.readLock().unlock();
543 >        Thread.sleep(SHORT_DELAY_MS);
544 >        lock.readLock().lock();
545 >        lock.readLock().unlock();
546 >        lock.writeLock().unlock();
547 >        t1.join(MEDIUM_DELAY_MS);
548 >        t2.join(MEDIUM_DELAY_MS);
549 >        assertTrue(!t1.isAlive());
550 >        assertTrue(!t2.isAlive());
551 >    }
552 >
553 >
554 >    /**
555 >     * Fair Write lock succeeds if write locked by current thread even if
556 >     * other threads are waiting for writelock
557 >     */
558 >    public void testWriteHoldingWriteLockFair4() throws InterruptedException {
559 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(true);
560 >        lock.writeLock().lock();
561 >        Thread t1 = new Thread(new CheckedRunnable() {
562 >            public void realRun() {
563 >                lock.writeLock().lock();
564 >                lock.writeLock().unlock();
565 >            }});
566 >        Thread t2 = new Thread(new CheckedRunnable() {
567 >            public void realRun() {
568 >                lock.writeLock().lock();
569 >                lock.writeLock().unlock();
570 >            }});
571 >
572 >        t1.start();
573 >        t2.start();
574 >        Thread.sleep(SHORT_DELAY_MS);
575 >        assertTrue(lock.isWriteLockedByCurrentThread());
576 >        assertTrue(lock.getWriteHoldCount() == 1);
577 >        lock.writeLock().lock();
578 >        assertTrue(lock.getWriteHoldCount() == 2);
579 >        lock.writeLock().unlock();
580 >        lock.writeLock().lock();
581 >        lock.writeLock().unlock();
582 >        lock.writeLock().unlock();
583 >        t1.join(MEDIUM_DELAY_MS);
584 >        t2.join(MEDIUM_DELAY_MS);
585 >        assertTrue(!t1.isAlive());
586 >        assertTrue(!t2.isAlive());
587 >    }
588 >
589 >
590 >    /**
591 >     * Read tryLock succeeds if readlocked but not writelocked
592 >     */
593 >    public void testTryLockWhenReadLocked() throws InterruptedException {
594 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
595 >        lock.readLock().lock();
596 >        Thread t = new Thread(new CheckedRunnable() {
597 >            public void realRun() {
598 >                threadAssertTrue(lock.readLock().tryLock());
599 >                lock.readLock().unlock();
600 >            }});
601 >
602 >        t.start();
603 >        t.join();
604 >        lock.readLock().unlock();
605 >    }
606 >
607 >
608 >
609 >    /**
610 >     * write tryLock fails when readlocked
611 >     */
612 >    public void testWriteTryLockWhenReadLocked() throws InterruptedException {
613 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
614 >        lock.readLock().lock();
615 >        Thread t = new Thread(new CheckedRunnable() {
616 >            public void realRun() {
617 >                threadAssertFalse(lock.writeLock().tryLock());
618 >            }});
619 >
620 >        t.start();
621 >        t.join();
622 >        lock.readLock().unlock();
623 >    }
624 >
625 >
626 >    /**
627 >     * Fair Read tryLock succeeds if readlocked but not writelocked
628 >     */
629 >    public void testTryLockWhenReadLockedFair() throws InterruptedException {
630 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(true);
631 >        lock.readLock().lock();
632 >        Thread t = new Thread(new CheckedRunnable() {
633 >            public void realRun() {
634 >                threadAssertTrue(lock.readLock().tryLock());
635 >                lock.readLock().unlock();
636 >            }});
637 >
638 >        t.start();
639 >        t.join();
640 >        lock.readLock().unlock();
641 >    }
642 >
643 >
644 >
645 >    /**
646 >     * Fair write tryLock fails when readlocked
647 >     */
648 >    public void testWriteTryLockWhenReadLockedFair() throws InterruptedException {
649 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(true);
650 >        lock.readLock().lock();
651 >        Thread t = new Thread(new CheckedRunnable() {
652 >            public void realRun() {
653 >                threadAssertFalse(lock.writeLock().tryLock());
654 >            }});
655 >
656 >        t.start();
657 >        t.join();
658 >        lock.readLock().unlock();
659 >    }
660 >
661 >
662 >
663 >    /**
664 >     * write timed tryLock times out if locked
665 >     */
666 >    public void testWriteTryLock_Timeout() throws InterruptedException {
667 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
668 >        lock.writeLock().lock();
669 >        Thread t = new Thread(new CheckedRunnable() {
670 >            public void realRun() throws InterruptedException {
671 >                threadAssertFalse(lock.writeLock().tryLock(1, MILLISECONDS));
672 >            }});
673 >
674 >        t.start();
675 >        t.join();
676 >        assertTrue(lock.writeLock().isHeldByCurrentThread());
677 >        lock.writeLock().unlock();
678 >    }
679 >
680 >    /**
681 >     * read timed tryLock times out if write-locked
682 >     */
683 >    public void testReadTryLock_Timeout() throws InterruptedException {
684 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
685 >        lock.writeLock().lock();
686 >        Thread t = new Thread(new CheckedRunnable() {
687 >            public void realRun() throws InterruptedException {
688 >                threadAssertFalse(lock.readLock().tryLock(1, MILLISECONDS));
689 >            }});
690 >
691 >        t.start();
692 >        t.join();
693 >        assertTrue(lock.writeLock().isHeldByCurrentThread());
694 >        lock.writeLock().unlock();
695 >    }
696 >
697 >
698 >    /**
699 >     * write lockInterruptibly succeeds if lock free else is interruptible
700 >     */
701 >    public void testWriteLockInterruptibly() throws InterruptedException {
702 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
703 >        lock.writeLock().lockInterruptibly();
704 >        Thread t = new Thread(new CheckedInterruptedRunnable() {
705 >            public void realRun() throws InterruptedException {
706 >                lock.writeLock().lockInterruptibly();
707 >            }});
708 >
709 >        t.start();
710 >        Thread.sleep(SHORT_DELAY_MS);
711 >        t.interrupt();
712 >        Thread.sleep(SHORT_DELAY_MS);
713 >        t.join();
714 >        lock.writeLock().unlock();
715 >    }
716 >
717 >    /**
718 >     *  read lockInterruptibly succeeds if lock free else is interruptible
719 >     */
720 >    public void testReadLockInterruptibly() throws InterruptedException {
721 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
722 >        lock.writeLock().lockInterruptibly();
723 >        Thread t = new Thread(new CheckedInterruptedRunnable() {
724 >            public void realRun() throws InterruptedException {
725 >                lock.readLock().lockInterruptibly();
726 >            }});
727 >
728 >        t.start();
729 >        Thread.sleep(SHORT_DELAY_MS);
730 >        t.interrupt();
731 >        t.join();
732 >        lock.writeLock().unlock();
733 >    }
734 >
735 >    /**
736 >     * Calling await without holding lock throws IllegalMonitorStateException
737 >     */
738 >    public void testAwait_IllegalMonitor() throws InterruptedException {
739 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
740          final Condition c = lock.writeLock().newCondition();
741          try {
742              c.await();
743 <            fail("should throw");
744 <        }
387 <        catch (IllegalMonitorStateException success) {
388 <        }
389 <        catch (Exception ex) {
390 <            fail("should throw IMSE");
391 <        }
743 >            shouldThrow();
744 >        } catch (IllegalMonitorStateException success) {}
745      }
746  
747 +    /**
748 +     * Calling signal without holding lock throws IllegalMonitorStateException
749 +     */
750      public void testSignal_IllegalMonitor() {
751 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();      
751 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
752          final Condition c = lock.writeLock().newCondition();
753          try {
754              c.signal();
755 <            fail("should throw");
756 <        }
401 <        catch (IllegalMonitorStateException success) {
402 <        }
403 <        catch (Exception ex) {
404 <            fail("should throw IMSE");
405 <        }
755 >            shouldThrow();
756 >        } catch (IllegalMonitorStateException success) {}
757      }
758  
759 <    public void testAwaitNanos_Timeout() {
760 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();      
759 >    /**
760 >     * awaitNanos without a signal times out
761 >     */
762 >    public void testAwaitNanos_Timeout() throws InterruptedException {
763 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
764          final Condition c = lock.writeLock().newCondition();
765 <        try {
766 <            lock.writeLock().lock();
767 <            long t = c.awaitNanos(100);
768 <            assertTrue(t <= 0);
769 <            lock.writeLock().unlock();
416 <        }
417 <        catch (Exception ex) {
418 <            fail("unexpected exception");
419 <        }
765 >
766 >        lock.writeLock().lock();
767 >        long t = c.awaitNanos(100);
768 >        assertTrue(t <= 0);
769 >        lock.writeLock().unlock();
770      }
771  
772 <    public void testAwait_Timeout() {
773 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();      
772 >
773 >    /**
774 >     *  timed await without a signal times out
775 >     */
776 >    public void testAwait_Timeout() throws InterruptedException {
777 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
778          final Condition c = lock.writeLock().newCondition();
779 <        try {
780 <            lock.writeLock().lock();
781 <            assertFalse(c.await(10, TimeUnit.MILLISECONDS));
428 <            lock.writeLock().unlock();
429 <        }
430 <        catch (Exception ex) {
431 <            fail("unexpected exception");
432 <        }
779 >        lock.writeLock().lock();
780 >        assertFalse(c.await(SHORT_DELAY_MS, MILLISECONDS));
781 >        lock.writeLock().unlock();
782      }
783  
784 <    public void testAwaitUntil_Timeout() {
785 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();      
784 >    /**
785 >     * awaitUntil without a signal times out
786 >     */
787 >    public void testAwaitUntil_Timeout() throws InterruptedException {
788 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
789          final Condition c = lock.writeLock().newCondition();
790 <        try {
791 <            lock.writeLock().lock();
792 <            java.util.Date d = new java.util.Date();
793 <            assertFalse(c.awaitUntil(new java.util.Date(d.getTime() + 10)));
442 <            lock.writeLock().unlock();
443 <        }
444 <        catch (Exception ex) {
445 <            fail("unexpected exception");
446 <        }
790 >        lock.writeLock().lock();
791 >        java.util.Date d = new java.util.Date();
792 >        assertFalse(c.awaitUntil(new java.util.Date(d.getTime() + 10)));
793 >        lock.writeLock().unlock();
794      }
795  
796 <    public void testAwait() {
797 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();      
796 >    /**
797 >     * await returns when signalled
798 >     */
799 >    public void testAwait() throws InterruptedException {
800 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
801          final Condition c = lock.writeLock().newCondition();
802 <        Thread t = new Thread(new Runnable() {
803 <                public void run() {
804 <                    try {
805 <                        lock.writeLock().lock();
806 <                        c.await();
807 <                        lock.writeLock().unlock();
808 <                    }
809 <                    catch(InterruptedException e) {
810 <                        fail("unexpected exception");
811 <                    }
812 <                }
813 <            });
802 >        Thread t = new Thread(new CheckedRunnable() {
803 >            public void realRun() throws InterruptedException {
804 >                lock.writeLock().lock();
805 >                c.await();
806 >                lock.writeLock().unlock();
807 >            }});
808 >
809 >        t.start();
810 >        Thread.sleep(SHORT_DELAY_MS);
811 >        lock.writeLock().lock();
812 >        c.signal();
813 >        lock.writeLock().unlock();
814 >        t.join(SHORT_DELAY_MS);
815 >        assertFalse(t.isAlive());
816 >    }
817  
818 <        try {
819 <            t.start();
820 <            Thread.sleep(SHORT_DELAY_MS);
821 <            lock.writeLock().lock();
822 <            c.signal();
823 <            lock.writeLock().unlock();
824 <            t.join(SHORT_DELAY_MS);
825 <            assertFalse(t.isAlive());
826 <        }
827 <        catch (Exception ex) {
828 <            fail("unexpected exception");
818 >    /** A helper class for uninterruptible wait tests */
819 >    class UninterruptableThread extends Thread {
820 >        private Lock lock;
821 >        private Condition c;
822 >
823 >        public volatile boolean canAwake = false;
824 >        public volatile boolean interrupted = false;
825 >        public volatile boolean lockStarted = false;
826 >
827 >        public UninterruptableThread(Lock lock, Condition c) {
828 >            this.lock = lock;
829 >            this.c = c;
830 >        }
831 >
832 >        public synchronized void run() {
833 >            lock.lock();
834 >            lockStarted = true;
835 >
836 >            while (!canAwake) {
837 >                c.awaitUninterruptibly();
838 >            }
839 >
840 >            interrupted = isInterrupted();
841 >            lock.unlock();
842          }
843      }
844  
845 <    public void testAwaitUninterruptibly() {
846 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();      
845 >    /**
846 >     * awaitUninterruptibly doesn't abort on interrupt
847 >     */
848 >    public void testAwaitUninterruptibly() throws InterruptedException {
849 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
850          final Condition c = lock.writeLock().newCondition();
851 <        Thread t = new Thread(new Runnable() {
852 <                public void run() {
853 <                    lock.writeLock().lock();
854 <                    c.awaitUninterruptibly();
855 <                    lock.writeLock().unlock();
856 <                }
857 <            });
851 >        UninterruptableThread thread = new UninterruptableThread(lock.writeLock(), c);
852 >
853 >        thread.start();
854 >
855 >        while (!thread.lockStarted) {
856 >            Thread.sleep(100);
857 >        }
858  
859 +        lock.writeLock().lock();
860          try {
861 <            t.start();
862 <            Thread.sleep(SHORT_DELAY_MS);
493 <            t.interrupt();
494 <            lock.writeLock().lock();
861 >            thread.interrupt();
862 >            thread.canAwake = true;
863              c.signal();
864 +        } finally {
865              lock.writeLock().unlock();
497            t.join(SHORT_DELAY_MS);
498            assertFalse(t.isAlive());
499        }
500        catch (Exception ex) {
501            fail("unexpected exception");
866          }
867 +
868 +        thread.join();
869 +        assertTrue(thread.interrupted);
870 +        assertFalse(thread.isAlive());
871      }
872  
873 <    public void testAwait_Interrupt() {
874 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();      
875 <        final Condition c = lock.writeLock().newCondition();
876 <        Thread t = new Thread(new Runnable() {
877 <                public void run() {
878 <                    try {
879 <                        lock.writeLock().lock();
880 <                        c.await();
881 <                        lock.writeLock().unlock();
882 <                        fail("should throw");
883 <                    }
884 <                    catch(InterruptedException success) {
885 <                    }
886 <                }
887 <            });
888 <
889 <        try {
890 <            t.start();
891 <            Thread.sleep(SHORT_DELAY_MS);
892 <            t.interrupt();
893 <            t.join(SHORT_DELAY_MS);
894 <            assertFalse(t.isAlive());
895 <        }
896 <        catch (Exception ex) {
897 <            fail("unexpected exception");
898 <        }
899 <    }
900 <
901 <    public void testAwaitNanos_Interrupt() {
902 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();      
903 <        final Condition c = lock.writeLock().newCondition();
904 <        Thread t = new Thread(new Runnable() {
905 <                public void run() {
906 <                    try {
907 <                        lock.writeLock().lock();
908 <                        c.awaitNanos(SHORT_DELAY_MS * 2 * 1000000);
909 <                        lock.writeLock().unlock();
910 <                        fail("should throw");
911 <                    }
912 <                    catch(InterruptedException success) {
913 <                    }
914 <                }
915 <            });
916 <
917 <        try {
918 <            t.start();
919 <            Thread.sleep(SHORT_DELAY_MS);
920 <            t.interrupt();
921 <            t.join(SHORT_DELAY_MS);
922 <            assertFalse(t.isAlive());
923 <        }
924 <        catch (Exception ex) {
925 <            fail("unexpected exception");
926 <        }
927 <    }
928 <
929 <    public void testAwaitUntil_Interrupt() {
930 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();      
931 <        final Condition c = lock.writeLock().newCondition();
564 <        Thread t = new Thread(new Runnable() {
565 <                public void run() {
566 <                    try {
567 <                        lock.writeLock().lock();
568 <                        java.util.Date d = new java.util.Date();
569 <                        c.awaitUntil(new java.util.Date(d.getTime() + 10000));
570 <                        lock.writeLock().unlock();
571 <                        fail("should throw");
572 <                    }
573 <                    catch(InterruptedException success) {
574 <                    }
575 <                }
576 <            });
577 <
578 <        try {
579 <            t.start();
580 <            Thread.sleep(SHORT_DELAY_MS);
581 <            t.interrupt();
582 <            t.join(SHORT_DELAY_MS);
583 <            assertFalse(t.isAlive());
584 <        }
585 <        catch (Exception ex) {
586 <            fail("unexpected exception");
587 <        }
588 <    }
589 <
590 <    public void testSignalAll() {
591 <        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();      
592 <        final Condition c = lock.writeLock().newCondition();
593 <        Thread t1 = new Thread(new Runnable() {
594 <                public void run() {
595 <                    try {
596 <                        lock.writeLock().lock();
597 <                        c.await();
598 <                        lock.writeLock().unlock();
599 <                    }
600 <                    catch(InterruptedException e) {
601 <                        fail("unexpected exception");
602 <                    }
603 <                }
604 <            });
605 <
606 <        Thread t2 = new Thread(new Runnable() {
607 <                public void run() {
608 <                    try {
609 <                        lock.writeLock().lock();
610 <                        c.await();
611 <                        lock.writeLock().unlock();
612 <                    }
613 <                    catch(InterruptedException e) {
614 <                        fail("unexpected exception");
615 <                    }
616 <                }
617 <            });
618 <
619 <        try {
620 <            t1.start();
621 <            t2.start();
622 <            Thread.sleep(SHORT_DELAY_MS);
623 <            lock.writeLock().lock();
624 <            c.signalAll();
625 <            lock.writeLock().unlock();
626 <            t1.join(SHORT_DELAY_MS);
627 <            t2.join(SHORT_DELAY_MS);
628 <            assertFalse(t1.isAlive());
629 <            assertFalse(t2.isAlive());
630 <        }
631 <        catch (Exception ex) {
632 <            fail("unexpected exception");
633 <        }
873 >    /**
874 >     * await is interruptible
875 >     */
876 >    public void testAwait_Interrupt() throws InterruptedException {
877 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
878 >        final Condition c = lock.writeLock().newCondition();
879 >        Thread t = new Thread(new CheckedInterruptedRunnable() {
880 >            public void realRun() throws InterruptedException {
881 >                lock.writeLock().lock();
882 >                c.await();
883 >                lock.writeLock().unlock();
884 >            }});
885 >
886 >        t.start();
887 >        Thread.sleep(SHORT_DELAY_MS);
888 >        t.interrupt();
889 >        t.join(SHORT_DELAY_MS);
890 >        assertFalse(t.isAlive());
891 >    }
892 >
893 >    /**
894 >     * awaitNanos is interruptible
895 >     */
896 >    public void testAwaitNanos_Interrupt() throws InterruptedException {
897 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
898 >        final Condition c = lock.writeLock().newCondition();
899 >        Thread t = new Thread(new CheckedInterruptedRunnable() {
900 >            public void realRun() throws InterruptedException {
901 >                lock.writeLock().lock();
902 >                c.awaitNanos(MILLISECONDS.toNanos(LONG_DELAY_MS));
903 >                lock.writeLock().unlock();
904 >            }});
905 >
906 >        t.start();
907 >        Thread.sleep(SHORT_DELAY_MS);
908 >        t.interrupt();
909 >        t.join(SHORT_DELAY_MS);
910 >        assertFalse(t.isAlive());
911 >    }
912 >
913 >    /**
914 >     * awaitUntil is interruptible
915 >     */
916 >    public void testAwaitUntil_Interrupt() throws InterruptedException {
917 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
918 >        final Condition c = lock.writeLock().newCondition();
919 >        Thread t = new Thread(new CheckedInterruptedRunnable() {
920 >            public void realRun() throws InterruptedException {
921 >                lock.writeLock().lock();
922 >                java.util.Date d = new java.util.Date();
923 >                c.awaitUntil(new java.util.Date(d.getTime() + 10000));
924 >                lock.writeLock().unlock();
925 >            }});
926 >
927 >        t.start();
928 >        Thread.sleep(SHORT_DELAY_MS);
929 >        t.interrupt();
930 >        t.join(SHORT_DELAY_MS);
931 >        assertFalse(t.isAlive());
932      }
933  
934 <    public void testSerialization() {
934 >    /**
935 >     * signalAll wakes up all threads
936 >     */
937 >    public void testSignalAll() throws InterruptedException {
938 >        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
939 >        final Condition c = lock.writeLock().newCondition();
940 >        Thread t1 = new Thread(new CheckedRunnable() {
941 >            public void realRun() throws InterruptedException {
942 >                lock.writeLock().lock();
943 >                c.await();
944 >                lock.writeLock().unlock();
945 >            }});
946 >
947 >        Thread t2 = new Thread(new CheckedRunnable() {
948 >            public void realRun() throws InterruptedException {
949 >                lock.writeLock().lock();
950 >                c.await();
951 >                lock.writeLock().unlock();
952 >            }});
953 >
954 >        t1.start();
955 >        t2.start();
956 >        Thread.sleep(SHORT_DELAY_MS);
957 >        lock.writeLock().lock();
958 >        c.signalAll();
959 >        lock.writeLock().unlock();
960 >        t1.join(SHORT_DELAY_MS);
961 >        t2.join(SHORT_DELAY_MS);
962 >        assertFalse(t1.isAlive());
963 >        assertFalse(t2.isAlive());
964 >    }
965 >
966 >    /**
967 >     * A serialized lock deserializes as unlocked
968 >     */
969 >    public void testSerialization() throws Exception {
970          ReentrantReadWriteLock l = new ReentrantReadWriteLock();
971          l.readLock().lock();
972          l.readLock().unlock();
973  
974 +        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
975 +        ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
976 +        out.writeObject(l);
977 +        out.close();
978 +
979 +        ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
980 +        ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
981 +        ReentrantReadWriteLock r = (ReentrantReadWriteLock) in.readObject();
982 +        r.readLock().lock();
983 +        r.readLock().unlock();
984 +    }
985 +
986 +    /**
987 +     * hasQueuedThreads reports whether there are waiting threads
988 +     */
989 +    public void testhasQueuedThreads() throws InterruptedException {
990 +        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
991 +        Thread t1 = new Thread(new InterruptedLockRunnable(lock));
992 +        Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
993 +        assertFalse(lock.hasQueuedThreads());
994 +        lock.writeLock().lock();
995 +        t1.start();
996 +        Thread.sleep(SHORT_DELAY_MS);
997 +        assertTrue(lock.hasQueuedThreads());
998 +        t2.start();
999 +        Thread.sleep(SHORT_DELAY_MS);
1000 +        assertTrue(lock.hasQueuedThreads());
1001 +        t1.interrupt();
1002 +        Thread.sleep(SHORT_DELAY_MS);
1003 +        assertTrue(lock.hasQueuedThreads());
1004 +        lock.writeLock().unlock();
1005 +        Thread.sleep(SHORT_DELAY_MS);
1006 +        assertFalse(lock.hasQueuedThreads());
1007 +        t1.join();
1008 +        t2.join();
1009 +    }
1010 +
1011 +    /**
1012 +     * hasQueuedThread(null) throws NPE
1013 +     */
1014 +    public void testHasQueuedThreadNPE() {
1015 +        final ReentrantReadWriteLock sync = new ReentrantReadWriteLock();
1016          try {
1017 <            ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
1018 <            ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
1019 <            out.writeObject(l);
645 <            out.close();
646 <
647 <            ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
648 <            ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
649 <            ReentrantReadWriteLock r = (ReentrantReadWriteLock) in.readObject();
650 <            r.readLock().lock();
651 <            r.readLock().unlock();
652 <        } catch(Exception e){
653 <            e.printStackTrace();
654 <            fail("unexpected exception");
655 <        }
1017 >            sync.hasQueuedThread(null);
1018 >            shouldThrow();
1019 >        } catch (NullPointerException success) {}
1020      }
1021  
1022 +    /**
1023 +     * hasQueuedThread reports whether a thread is queued.
1024 +     */
1025 +    public void testHasQueuedThread() throws InterruptedException {
1026 +        final ReentrantReadWriteLock sync = new ReentrantReadWriteLock();
1027 +        Thread t1 = new Thread(new InterruptedLockRunnable(sync));
1028 +        Thread t2 = new Thread(new InterruptibleLockRunnable(sync));
1029 +        assertFalse(sync.hasQueuedThread(t1));
1030 +        assertFalse(sync.hasQueuedThread(t2));
1031 +        sync.writeLock().lock();
1032 +        t1.start();
1033 +        Thread.sleep(SHORT_DELAY_MS);
1034 +        assertTrue(sync.hasQueuedThread(t1));
1035 +        t2.start();
1036 +        Thread.sleep(SHORT_DELAY_MS);
1037 +        assertTrue(sync.hasQueuedThread(t1));
1038 +        assertTrue(sync.hasQueuedThread(t2));
1039 +        t1.interrupt();
1040 +        Thread.sleep(SHORT_DELAY_MS);
1041 +        assertFalse(sync.hasQueuedThread(t1));
1042 +        assertTrue(sync.hasQueuedThread(t2));
1043 +        sync.writeLock().unlock();
1044 +        Thread.sleep(SHORT_DELAY_MS);
1045 +        assertFalse(sync.hasQueuedThread(t1));
1046 +        Thread.sleep(SHORT_DELAY_MS);
1047 +        assertFalse(sync.hasQueuedThread(t2));
1048 +        t1.join();
1049 +        t2.join();
1050 +    }
1051 +
1052 +
1053 +    /**
1054 +     * getQueueLength reports number of waiting threads
1055 +     */
1056 +    public void testGetQueueLength() throws InterruptedException {
1057 +        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
1058 +        Thread t1 = new Thread(new InterruptedLockRunnable(lock));
1059 +        Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
1060 +        assertEquals(0, lock.getQueueLength());
1061 +        lock.writeLock().lock();
1062 +        t1.start();
1063 +        Thread.sleep(SHORT_DELAY_MS);
1064 +        assertEquals(1, lock.getQueueLength());
1065 +        t2.start();
1066 +        Thread.sleep(SHORT_DELAY_MS);
1067 +        assertEquals(2, lock.getQueueLength());
1068 +        t1.interrupt();
1069 +        Thread.sleep(SHORT_DELAY_MS);
1070 +        assertEquals(1, lock.getQueueLength());
1071 +        lock.writeLock().unlock();
1072 +        Thread.sleep(SHORT_DELAY_MS);
1073 +        assertEquals(0, lock.getQueueLength());
1074 +        t1.join();
1075 +        t2.join();
1076 +    }
1077 +
1078 +    /**
1079 +     * getQueuedThreads includes waiting threads
1080 +     */
1081 +    public void testGetQueuedThreads() throws InterruptedException {
1082 +        final PublicReentrantReadWriteLock lock = new PublicReentrantReadWriteLock();
1083 +        Thread t1 = new Thread(new InterruptedLockRunnable(lock));
1084 +        Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
1085 +        assertTrue(lock.getQueuedThreads().isEmpty());
1086 +        lock.writeLock().lock();
1087 +        assertTrue(lock.getQueuedThreads().isEmpty());
1088 +        t1.start();
1089 +        Thread.sleep(SHORT_DELAY_MS);
1090 +        assertTrue(lock.getQueuedThreads().contains(t1));
1091 +        t2.start();
1092 +        Thread.sleep(SHORT_DELAY_MS);
1093 +        assertTrue(lock.getQueuedThreads().contains(t1));
1094 +        assertTrue(lock.getQueuedThreads().contains(t2));
1095 +        t1.interrupt();
1096 +        Thread.sleep(SHORT_DELAY_MS);
1097 +        assertFalse(lock.getQueuedThreads().contains(t1));
1098 +        assertTrue(lock.getQueuedThreads().contains(t2));
1099 +        lock.writeLock().unlock();
1100 +        Thread.sleep(SHORT_DELAY_MS);
1101 +        assertTrue(lock.getQueuedThreads().isEmpty());
1102 +        t1.join();
1103 +        t2.join();
1104 +    }
1105 +
1106 +    /**
1107 +     * hasWaiters throws NPE if null
1108 +     */
1109 +    public void testHasWaitersNPE() {
1110 +        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
1111 +        try {
1112 +            lock.hasWaiters(null);
1113 +            shouldThrow();
1114 +        } catch (NullPointerException success) {}
1115 +    }
1116 +
1117 +    /**
1118 +     * getWaitQueueLength throws NPE if null
1119 +     */
1120 +    public void testGetWaitQueueLengthNPE() {
1121 +        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
1122 +        try {
1123 +            lock.getWaitQueueLength(null);
1124 +            shouldThrow();
1125 +        } catch (NullPointerException success) {}
1126 +    }
1127 +
1128 +
1129 +    /**
1130 +     * getWaitingThreads throws NPE if null
1131 +     */
1132 +    public void testGetWaitingThreadsNPE() {
1133 +        final PublicReentrantReadWriteLock lock = new PublicReentrantReadWriteLock();
1134 +        try {
1135 +            lock.getWaitingThreads(null);
1136 +            shouldThrow();
1137 +        } catch (NullPointerException success) {}
1138 +    }
1139 +
1140 +    /**
1141 +     * hasWaiters throws IAE if not owned
1142 +     */
1143 +    public void testHasWaitersIAE() {
1144 +        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
1145 +        final Condition c = lock.writeLock().newCondition();
1146 +        final ReentrantReadWriteLock lock2 = new ReentrantReadWriteLock();
1147 +        try {
1148 +            lock2.hasWaiters(c);
1149 +            shouldThrow();
1150 +        } catch (IllegalArgumentException success) {}
1151 +    }
1152 +
1153 +    /**
1154 +     * hasWaiters throws IMSE if not locked
1155 +     */
1156 +    public void testHasWaitersIMSE() {
1157 +        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
1158 +        final Condition c = lock.writeLock().newCondition();
1159 +        try {
1160 +            lock.hasWaiters(c);
1161 +            shouldThrow();
1162 +        } catch (IllegalMonitorStateException success) {}
1163 +    }
1164 +
1165 +
1166 +    /**
1167 +     * getWaitQueueLength throws IAE if not owned
1168 +     */
1169 +    public void testGetWaitQueueLengthIAE() {
1170 +        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
1171 +        final Condition c = lock.writeLock().newCondition();
1172 +        final ReentrantReadWriteLock lock2 = new ReentrantReadWriteLock();
1173 +        try {
1174 +            lock2.getWaitQueueLength(c);
1175 +            shouldThrow();
1176 +        } catch (IllegalArgumentException success) {}
1177 +    }
1178 +
1179 +    /**
1180 +     * getWaitQueueLength throws IMSE if not locked
1181 +     */
1182 +    public void testGetWaitQueueLengthIMSE() {
1183 +        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
1184 +        final Condition c = lock.writeLock().newCondition();
1185 +        try {
1186 +            lock.getWaitQueueLength(c);
1187 +            shouldThrow();
1188 +        } catch (IllegalMonitorStateException success) {}
1189 +    }
1190 +
1191 +
1192 +    /**
1193 +     * getWaitingThreads throws IAE if not owned
1194 +     */
1195 +    public void testGetWaitingThreadsIAE() {
1196 +        final PublicReentrantReadWriteLock lock = new PublicReentrantReadWriteLock();
1197 +        final Condition c = lock.writeLock().newCondition();
1198 +        final PublicReentrantReadWriteLock lock2 = new PublicReentrantReadWriteLock();
1199 +        try {
1200 +            lock2.getWaitingThreads(c);
1201 +            shouldThrow();
1202 +        } catch (IllegalArgumentException success) {}
1203 +    }
1204 +
1205 +    /**
1206 +     * getWaitingThreads throws IMSE if not locked
1207 +     */
1208 +    public void testGetWaitingThreadsIMSE() {
1209 +        final PublicReentrantReadWriteLock lock = new PublicReentrantReadWriteLock();
1210 +        final Condition c = lock.writeLock().newCondition();
1211 +        try {
1212 +            lock.getWaitingThreads(c);
1213 +            shouldThrow();
1214 +        } catch (IllegalMonitorStateException success) {}
1215 +    }
1216 +
1217 +
1218 +    /**
1219 +     * hasWaiters returns true when a thread is waiting, else false
1220 +     */
1221 +    public void testHasWaiters() throws InterruptedException {
1222 +        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
1223 +        final Condition c = lock.writeLock().newCondition();
1224 +        Thread t = new Thread(new CheckedRunnable() {
1225 +            public void realRun() throws InterruptedException {
1226 +                lock.writeLock().lock();
1227 +                threadAssertFalse(lock.hasWaiters(c));
1228 +                threadAssertEquals(0, lock.getWaitQueueLength(c));
1229 +                c.await();
1230 +                lock.writeLock().unlock();
1231 +            }});
1232 +
1233 +        t.start();
1234 +        Thread.sleep(SHORT_DELAY_MS);
1235 +        lock.writeLock().lock();
1236 +        assertTrue(lock.hasWaiters(c));
1237 +        assertEquals(1, lock.getWaitQueueLength(c));
1238 +        c.signal();
1239 +        lock.writeLock().unlock();
1240 +        Thread.sleep(SHORT_DELAY_MS);
1241 +        lock.writeLock().lock();
1242 +        assertFalse(lock.hasWaiters(c));
1243 +        assertEquals(0, lock.getWaitQueueLength(c));
1244 +        lock.writeLock().unlock();
1245 +        t.join(SHORT_DELAY_MS);
1246 +        assertFalse(t.isAlive());
1247 +    }
1248 +
1249 +    /**
1250 +     * getWaitQueueLength returns number of waiting threads
1251 +     */
1252 +    public void testGetWaitQueueLength() throws InterruptedException {
1253 +        final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
1254 +        final Condition c = lock.writeLock().newCondition();
1255 +        Thread t = new Thread(new CheckedRunnable() {
1256 +            public void realRun() throws InterruptedException {
1257 +                lock.writeLock().lock();
1258 +                threadAssertFalse(lock.hasWaiters(c));
1259 +                threadAssertEquals(0, lock.getWaitQueueLength(c));
1260 +                c.await();
1261 +                lock.writeLock().unlock();
1262 +            }});
1263 +
1264 +        t.start();
1265 +        Thread.sleep(SHORT_DELAY_MS);
1266 +        lock.writeLock().lock();
1267 +        assertTrue(lock.hasWaiters(c));
1268 +        assertEquals(1, lock.getWaitQueueLength(c));
1269 +        c.signal();
1270 +        lock.writeLock().unlock();
1271 +        Thread.sleep(SHORT_DELAY_MS);
1272 +        lock.writeLock().lock();
1273 +        assertFalse(lock.hasWaiters(c));
1274 +        assertEquals(0, lock.getWaitQueueLength(c));
1275 +        lock.writeLock().unlock();
1276 +        t.join(SHORT_DELAY_MS);
1277 +        assertFalse(t.isAlive());
1278 +    }
1279 +
1280 +
1281 +    /**
1282 +     * getWaitingThreads returns only and all waiting threads
1283 +     */
1284 +    public void testGetWaitingThreads() throws InterruptedException {
1285 +        final PublicReentrantReadWriteLock lock = new PublicReentrantReadWriteLock();
1286 +        final Condition c = lock.writeLock().newCondition();
1287 +        Thread t1 = new Thread(new CheckedRunnable() {
1288 +            public void realRun() throws InterruptedException {
1289 +                lock.writeLock().lock();
1290 +                threadAssertTrue(lock.getWaitingThreads(c).isEmpty());
1291 +                c.await();
1292 +                lock.writeLock().unlock();
1293 +            }});
1294 +
1295 +        Thread t2 = new Thread(new CheckedRunnable() {
1296 +            public void realRun() throws InterruptedException {
1297 +                lock.writeLock().lock();
1298 +                threadAssertFalse(lock.getWaitingThreads(c).isEmpty());
1299 +                c.await();
1300 +                lock.writeLock().unlock();
1301 +            }});
1302 +
1303 +        lock.writeLock().lock();
1304 +        assertTrue(lock.getWaitingThreads(c).isEmpty());
1305 +        lock.writeLock().unlock();
1306 +        t1.start();
1307 +        Thread.sleep(SHORT_DELAY_MS);
1308 +        t2.start();
1309 +        Thread.sleep(SHORT_DELAY_MS);
1310 +        lock.writeLock().lock();
1311 +        assertTrue(lock.hasWaiters(c));
1312 +        assertTrue(lock.getWaitingThreads(c).contains(t1));
1313 +        assertTrue(lock.getWaitingThreads(c).contains(t2));
1314 +        c.signalAll();
1315 +        lock.writeLock().unlock();
1316 +        Thread.sleep(SHORT_DELAY_MS);
1317 +        lock.writeLock().lock();
1318 +        assertFalse(lock.hasWaiters(c));
1319 +        assertTrue(lock.getWaitingThreads(c).isEmpty());
1320 +        lock.writeLock().unlock();
1321 +        t1.join(SHORT_DELAY_MS);
1322 +        t2.join(SHORT_DELAY_MS);
1323 +        assertFalse(t1.isAlive());
1324 +        assertFalse(t2.isAlive());
1325 +    }
1326 +
1327 +    /**
1328 +     * toString indicates current lock state
1329 +     */
1330 +    public void testToString() {
1331 +        ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
1332 +        String us = lock.toString();
1333 +        assertTrue(us.indexOf("Write locks = 0") >= 0);
1334 +        assertTrue(us.indexOf("Read locks = 0") >= 0);
1335 +        lock.writeLock().lock();
1336 +        String ws = lock.toString();
1337 +        assertTrue(ws.indexOf("Write locks = 1") >= 0);
1338 +        assertTrue(ws.indexOf("Read locks = 0") >= 0);
1339 +        lock.writeLock().unlock();
1340 +        lock.readLock().lock();
1341 +        lock.readLock().lock();
1342 +        String rs = lock.toString();
1343 +        assertTrue(rs.indexOf("Write locks = 0") >= 0);
1344 +        assertTrue(rs.indexOf("Read locks = 2") >= 0);
1345 +    }
1346 +
1347 +    /**
1348 +     * readLock.toString indicates current lock state
1349 +     */
1350 +    public void testReadLockToString() {
1351 +        ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
1352 +        String us = lock.readLock().toString();
1353 +        assertTrue(us.indexOf("Read locks = 0") >= 0);
1354 +        lock.readLock().lock();
1355 +        lock.readLock().lock();
1356 +        String rs = lock.readLock().toString();
1357 +        assertTrue(rs.indexOf("Read locks = 2") >= 0);
1358 +    }
1359 +
1360 +    /**
1361 +     * writeLock.toString indicates current lock state
1362 +     */
1363 +    public void testWriteLockToString() {
1364 +        ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
1365 +        String us = lock.writeLock().toString();
1366 +        assertTrue(us.indexOf("Unlocked") >= 0);
1367 +        lock.writeLock().lock();
1368 +        String ls = lock.writeLock().toString();
1369 +        assertTrue(ls.indexOf("Locked") >= 0);
1370 +    }
1371  
1372   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines