--- jsr166/src/test/tck/ReentrantReadWriteLockTest.java 2003/09/07 20:39:11 1.2 +++ jsr166/src/test/tck/ReentrantReadWriteLockTest.java 2005/05/03 16:02:00 1.22 @@ -1,77 +1,193 @@ /* - * Written by members of JCP JSR-166 Expert Group and released to the - * public domain. Use, modify, and redistribute this code in any way - * without acknowledgement. Other contributors include Andrew Wright, - * Jeffrey Hayes, Pat Fischer, Mike Judd. + * Written by Doug Lea with assistance from members of JCP JSR-166 + * Expert Group and released to the public domain, as explained at + * http://creativecommons.org/licenses/publicdomain + * Other contributors include Andrew Wright, Jeffrey Hayes, + * Pat Fisher, Mike Judd. */ import junit.framework.*; import java.util.concurrent.locks.*; import java.util.concurrent.*; import java.io.*; +import java.util.*; -public class ReentrantReadWriteLockTest extends TestCase { - static int HOLD_COUNT_TEST_LIMIT = 20; - +public class ReentrantReadWriteLockTest extends JSR166TestCase { public static void main(String[] args) { junit.textui.TestRunner.run (suite()); } - public static Test suite() { return new TestSuite(ReentrantReadWriteLockTest.class); } + /** + * A runnable calling lockInterruptibly + */ + class InterruptibleLockRunnable implements Runnable { + final ReentrantReadWriteLock lock; + InterruptibleLockRunnable(ReentrantReadWriteLock l) { lock = l; } + public void run() { + try { + lock.writeLock().lockInterruptibly(); + } catch(InterruptedException success){} + } + } + - private static long SHORT_DELAY_MS = 100; - private static long MEDIUM_DELAY_MS = 1000; - private static long LONG_DELAY_MS = 10000; - - /* - * Unlocks an unlocked lock, throws Illegal Monitor State - * + /** + * A runnable calling lockInterruptibly that expects to be + * interrupted */ - - public void testIllegalMonitorStateException(){ + class InterruptedLockRunnable implements Runnable { + final ReentrantReadWriteLock lock; + InterruptedLockRunnable(ReentrantReadWriteLock l) { lock = l; } + public void run() { + try { + lock.writeLock().lockInterruptibly(); + threadShouldThrow(); + } catch(InterruptedException success){} + } + } + + /** + * Subclass to expose protected methods + */ + static class PublicReentrantReadWriteLock extends ReentrantReadWriteLock { + PublicReentrantReadWriteLock() { super(); } + public Collection getQueuedThreads() { + return super.getQueuedThreads(); + } + public Collection getWaitingThreads(Condition c) { + return super.getWaitingThreads(c); + } + } + + /** + * Constructor sets given fairness, and is in unlocked state + */ + public void testConstructor() { ReentrantReadWriteLock rl = new ReentrantReadWriteLock(); - try{ - rl.writeLock().unlock(); - fail("Should of thown Illegal Monitor State Exception"); + assertFalse(rl.isFair()); + assertFalse(rl.isWriteLocked()); + assertEquals(0, rl.getReadLockCount()); + ReentrantReadWriteLock r2 = new ReentrantReadWriteLock(true); + assertTrue(r2.isFair()); + assertFalse(r2.isWriteLocked()); + assertEquals(0, r2.getReadLockCount()); + } - }catch(IllegalMonitorStateException success){} + /** + * write-locking and read-locking an unlocked lock succeed + */ + public void testLock() { + ReentrantReadWriteLock rl = new ReentrantReadWriteLock(); + rl.writeLock().lock(); + assertTrue(rl.isWriteLocked()); + assertTrue(rl.isWriteLockedByCurrentThread()); + assertEquals(0, rl.getReadLockCount()); + rl.writeLock().unlock(); + assertFalse(rl.isWriteLocked()); + assertFalse(rl.isWriteLockedByCurrentThread()); + assertEquals(0, rl.getReadLockCount()); + rl.readLock().lock(); + assertFalse(rl.isWriteLocked()); + assertFalse(rl.isWriteLockedByCurrentThread()); + assertEquals(1, rl.getReadLockCount()); + rl.readLock().unlock(); + assertFalse(rl.isWriteLocked()); + assertFalse(rl.isWriteLockedByCurrentThread()); + assertEquals(0, rl.getReadLockCount()); } + /** + * locking an unlocked fair lock succeeds + */ + public void testFairLock() { + ReentrantReadWriteLock rl = new ReentrantReadWriteLock(true); + rl.writeLock().lock(); + assertTrue(rl.isWriteLocked()); + assertTrue(rl.isWriteLockedByCurrentThread()); + assertEquals(0, rl.getReadLockCount()); + rl.writeLock().unlock(); + assertFalse(rl.isWriteLocked()); + assertFalse(rl.isWriteLockedByCurrentThread()); + assertEquals(0, rl.getReadLockCount()); + rl.readLock().lock(); + assertFalse(rl.isWriteLocked()); + assertFalse(rl.isWriteLockedByCurrentThread()); + assertEquals(1, rl.getReadLockCount()); + rl.readLock().unlock(); + assertFalse(rl.isWriteLocked()); + assertFalse(rl.isWriteLockedByCurrentThread()); + assertEquals(0, rl.getReadLockCount()); + } - public void testInterruptedException(){ + /** + * getWriteHoldCount returns number of recursive holds + */ + public void testGetHoldCount() { + ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + for(int i = 1; i <= SIZE; i++) { + lock.writeLock().lock(); + assertEquals(i,lock.getWriteHoldCount()); + } + for(int i = SIZE; i > 0; i--) { + lock.writeLock().unlock(); + assertEquals(i-1,lock.getWriteHoldCount()); + } + } + + + /** + * write-unlocking an unlocked lock throws IllegalMonitorStateException + */ + public void testUnlock_IllegalMonitorStateException() { + ReentrantReadWriteLock rl = new ReentrantReadWriteLock(); + try { + rl.writeLock().unlock(); + shouldThrow(); + } catch(IllegalMonitorStateException success){} + } + + + /** + * write-lockInterruptibly is interruptible + */ + public void testWriteLockInterruptibly_Interrupted() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); - lock.writeLock().lock(); Thread t = new Thread(new Runnable() { - public void run(){ - try{ + public void run() { + try { + lock.writeLock().lockInterruptibly(); + lock.writeLock().unlock(); lock.writeLock().lockInterruptibly(); - fail("should throw"); - }catch(InterruptedException success){} + lock.writeLock().unlock(); + } catch(InterruptedException success){} } }); try { + lock.writeLock().lock(); t.start(); t.interrupt(); lock.writeLock().unlock(); t.join(); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } - public void testInterruptedException2(){ + /** + * timed write-tryLock is interruptible + */ + public void testWriteTryLock_Interrupted() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); lock.writeLock().lock(); Thread t = new Thread(new Runnable() { - public void run(){ - try{ + public void run() { + try { lock.writeLock().tryLock(1000,TimeUnit.MILLISECONDS); - fail("should throw"); - }catch(InterruptedException success){} + } catch(InterruptedException success){} } }); try { @@ -80,19 +196,21 @@ public class ReentrantReadWriteLockTest lock.writeLock().unlock(); t.join(); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } - public void testInterruptedException3(){ + /** + * read-lockInterruptibly is interruptible + */ + public void testReadLockInterruptibly_Interrupted() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); lock.writeLock().lock(); Thread t = new Thread(new Runnable() { - public void run(){ - try{ + public void run() { + try { lock.readLock().lockInterruptibly(); - fail("should throw"); - }catch(InterruptedException success){} + } catch(InterruptedException success){} } }); try { @@ -101,19 +219,22 @@ public class ReentrantReadWriteLockTest lock.writeLock().unlock(); t.join(); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } - public void testInterruptedException4(){ + /** + * timed read-tryLock is interruptible + */ + public void testReadTryLock_Interrupted() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); lock.writeLock().lock(); Thread t = new Thread(new Runnable() { - public void run(){ - try{ + public void run() { + try { lock.readLock().tryLock(1000,TimeUnit.MILLISECONDS); - fail("should throw"); - }catch(InterruptedException success){} + threadShouldThrow(); + } catch(InterruptedException success){} } }); try { @@ -121,17 +242,20 @@ public class ReentrantReadWriteLockTest t.interrupt(); t.join(); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } - public void testTryLockWhenLocked() { + /** + * write-tryLock fails if locked + */ + public void testWriteTryLockWhenLocked() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); lock.writeLock().lock(); Thread t = new Thread(new Runnable() { - public void run(){ - assertFalse(lock.writeLock().tryLock()); + public void run() { + threadAssertFalse(lock.writeLock().tryLock()); } }); try { @@ -139,16 +263,19 @@ public class ReentrantReadWriteLockTest t.join(); lock.writeLock().unlock(); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } - public void testTryLockWhenLocked2() { + /** + * read-tryLock fails if locked + */ + public void testReadTryLockWhenLocked() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); lock.writeLock().lock(); Thread t = new Thread(new Runnable() { - public void run(){ - assertFalse(lock.readLock().tryLock()); + public void run() { + threadAssertFalse(lock.readLock().tryLock()); } }); try { @@ -156,16 +283,19 @@ public class ReentrantReadWriteLockTest t.join(); lock.writeLock().unlock(); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } + /** + * Multiple threads can hold a read lock when not write-locked + */ public void testMultipleReadLocks() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); lock.readLock().lock(); Thread t = new Thread(new Runnable() { - public void run(){ - assertTrue(lock.readLock().tryLock()); + public void run() { + threadAssertTrue(lock.readLock().tryLock()); lock.readLock().unlock(); } }); @@ -174,21 +304,24 @@ public class ReentrantReadWriteLockTest t.join(); lock.readLock().unlock(); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } + /** + * A writelock succeeds after reading threads unlock + */ public void testWriteAfterMultipleReadLocks() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); lock.readLock().lock(); Thread t1 = new Thread(new Runnable() { - public void run(){ + public void run() { lock.readLock().lock(); lock.readLock().unlock(); } }); Thread t2 = new Thread(new Runnable() { - public void run(){ + public void run() { lock.writeLock().lock(); lock.writeLock().unlock(); } @@ -205,21 +338,120 @@ public class ReentrantReadWriteLockTest assertTrue(!t2.isAlive()); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } + /** + * Readlocks succeed after a writing thread unlocks + */ public void testReadAfterWriteLock() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); lock.writeLock().lock(); Thread t1 = new Thread(new Runnable() { - public void run(){ + public void run() { + lock.readLock().lock(); + lock.readLock().unlock(); + } + }); + Thread t2 = new Thread(new Runnable() { + public void run() { + lock.readLock().lock(); + lock.readLock().unlock(); + } + }); + + try { + t1.start(); + t2.start(); + Thread.sleep(SHORT_DELAY_MS); + lock.writeLock().unlock(); + t1.join(MEDIUM_DELAY_MS); + t2.join(MEDIUM_DELAY_MS); + assertTrue(!t1.isAlive()); + assertTrue(!t2.isAlive()); + + } catch(Exception e){ + unexpectedException(); + } + } + + /** + * Read trylock succeeds if write locked by current thread + */ + public void testReadHoldingWriteLock() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + lock.writeLock().lock(); + assertTrue(lock.readLock().tryLock()); + lock.readLock().unlock(); + lock.writeLock().unlock(); + } + + /** + * Read lock succeeds if write locked by current thread even if + * other threads are waiting + */ + public void testReadHoldingWriteLock2() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + lock.writeLock().lock(); + Thread t1 = new Thread(new Runnable() { + public void run() { + lock.readLock().lock(); + lock.readLock().unlock(); + } + }); + Thread t2 = new Thread(new Runnable() { + public void run() { + lock.readLock().lock(); + lock.readLock().unlock(); + } + }); + + try { + t1.start(); + t2.start(); + lock.readLock().lock(); + lock.readLock().unlock(); + Thread.sleep(SHORT_DELAY_MS); + lock.readLock().lock(); + lock.readLock().unlock(); + lock.writeLock().unlock(); + t1.join(MEDIUM_DELAY_MS); + t2.join(MEDIUM_DELAY_MS); + assertTrue(!t1.isAlive()); + assertTrue(!t2.isAlive()); + + } catch(Exception e){ + unexpectedException(); + } + } + + /** + * Fair Read trylock succeeds if write locked by current thread + */ + public void testReadHoldingWriteLockFair() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(true); + lock.writeLock().lock(); + assertTrue(lock.readLock().tryLock()); + lock.readLock().unlock(); + lock.writeLock().unlock(); + } + + /** + * Fair Read lock succeeds if write locked by current thread even if + * other threads are waiting + */ + public void testReadHoldingWriteLockFair2() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(true); + lock.writeLock().lock(); + Thread t1 = new Thread(new Runnable() { + public void run() { lock.readLock().lock(); lock.readLock().unlock(); } }); Thread t2 = new Thread(new Runnable() { - public void run(){ + public void run() { lock.readLock().lock(); lock.readLock().unlock(); } @@ -228,7 +460,11 @@ public class ReentrantReadWriteLockTest try { t1.start(); t2.start(); + lock.readLock().lock(); + lock.readLock().unlock(); Thread.sleep(SHORT_DELAY_MS); + lock.readLock().lock(); + lock.readLock().unlock(); lock.writeLock().unlock(); t1.join(MEDIUM_DELAY_MS); t2.join(MEDIUM_DELAY_MS); @@ -236,17 +472,20 @@ public class ReentrantReadWriteLockTest assertTrue(!t2.isAlive()); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } + /** + * Read tryLock succeeds if readlocked but not writelocked + */ public void testTryLockWhenReadLocked() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); lock.readLock().lock(); Thread t = new Thread(new Runnable() { - public void run(){ - assertTrue(lock.readLock().tryLock()); + public void run() { + threadAssertTrue(lock.readLock().tryLock()); lock.readLock().unlock(); } }); @@ -255,18 +494,21 @@ public class ReentrantReadWriteLockTest t.join(); lock.readLock().unlock(); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } + /** + * write tryLock fails when readlocked + */ public void testWriteTryLockWhenReadLocked() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); lock.readLock().lock(); Thread t = new Thread(new Runnable() { - public void run(){ - assertFalse(lock.writeLock().tryLock()); + public void run() { + threadAssertFalse(lock.writeLock().tryLock()); } }); try { @@ -274,21 +516,24 @@ public class ReentrantReadWriteLockTest t.join(); lock.readLock().unlock(); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } - public void testTryLock_Timeout(){ + /** + * write timed tryLock times out if locked + */ + public void testWriteTryLock_Timeout() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); lock.writeLock().lock(); Thread t = new Thread(new Runnable() { - public void run(){ + public void run() { try { - assertFalse(lock.writeLock().tryLock(1, TimeUnit.MILLISECONDS)); + threadAssertFalse(lock.writeLock().tryLock(1, TimeUnit.MILLISECONDS)); } catch (Exception ex) { - fail("unexpected exception"); + threadUnexpectedException(); } } }); @@ -297,19 +542,22 @@ public class ReentrantReadWriteLockTest t.join(); lock.writeLock().unlock(); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } - public void testTryLock_Timeout2(){ + /** + * read timed tryLock times out if write-locked + */ + public void testReadTryLock_Timeout() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); lock.writeLock().lock(); Thread t = new Thread(new Runnable() { - public void run(){ + public void run() { try { - assertFalse(lock.readLock().tryLock(1, TimeUnit.MILLISECONDS)); + threadAssertFalse(lock.readLock().tryLock(1, TimeUnit.MILLISECONDS)); } catch (Exception ex) { - fail("unexpected exception"); + threadUnexpectedException(); } } }); @@ -318,23 +566,26 @@ public class ReentrantReadWriteLockTest t.join(); lock.writeLock().unlock(); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } - public void testLockInterruptibly() { + /** + * write lockInterruptibly succeeds if lock free else is interruptible + */ + public void testWriteLockInterruptibly() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); try { lock.writeLock().lockInterruptibly(); } catch(Exception e) { - fail("unexpected exception"); + unexpectedException(); } Thread t = new Thread(new Runnable() { public void run() { try { lock.writeLock().lockInterruptibly(); - fail("should throw"); + threadShouldThrow(); } catch(InterruptedException success) { } @@ -346,22 +597,25 @@ public class ReentrantReadWriteLockTest t.join(); lock.writeLock().unlock(); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } - public void testLockInterruptibly2() { + /** + * read lockInterruptibly succeeds if lock free else is interruptible + */ + public void testReadLockInterruptibly() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); try { lock.writeLock().lockInterruptibly(); } catch(Exception e) { - fail("unexpected exception"); + unexpectedException(); } Thread t = new Thread(new Runnable() { public void run() { try { lock.readLock().lockInterruptibly(); - fail("should throw"); + threadShouldThrow(); } catch(InterruptedException success) { } @@ -373,38 +627,47 @@ public class ReentrantReadWriteLockTest t.join(); lock.writeLock().unlock(); } catch(Exception e){ - fail("unexpected exception"); + unexpectedException(); } } + /** + * Calling await without holding lock throws IllegalMonitorStateException + */ public void testAwait_IllegalMonitor() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); final Condition c = lock.writeLock().newCondition(); try { c.await(); - fail("should throw"); + shouldThrow(); } catch (IllegalMonitorStateException success) { } catch (Exception ex) { - fail("should throw IMSE"); + shouldThrow(); } } + /** + * Calling signal without holding lock throws IllegalMonitorStateException + */ public void testSignal_IllegalMonitor() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); final Condition c = lock.writeLock().newCondition(); try { c.signal(); - fail("should throw"); + shouldThrow(); } catch (IllegalMonitorStateException success) { } catch (Exception ex) { - fail("should throw IMSE"); + unexpectedException(); } } + /** + * awaitNanos without a signal times out + */ public void testAwaitNanos_Timeout() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); final Condition c = lock.writeLock().newCondition(); @@ -415,37 +678,45 @@ public class ReentrantReadWriteLockTest lock.writeLock().unlock(); } catch (Exception ex) { - fail("unexpected exception"); + unexpectedException(); } } + + /** + * timed await without a signal times out + */ public void testAwait_Timeout() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); final Condition c = lock.writeLock().newCondition(); try { lock.writeLock().lock(); - assertFalse(c.await(10, TimeUnit.MILLISECONDS)); lock.writeLock().unlock(); } catch (Exception ex) { - fail("unexpected exception"); + unexpectedException(); } } + /** + * awaitUntil without a signal times out + */ public void testAwaitUntil_Timeout() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); final Condition c = lock.writeLock().newCondition(); try { lock.writeLock().lock(); java.util.Date d = new java.util.Date(); - assertFalse(c.awaitUntil(new java.util.Date(d.getTime() + 10))); lock.writeLock().unlock(); } catch (Exception ex) { - fail("unexpected exception"); + unexpectedException(); } } + /** + * await returns when signalled + */ public void testAwait() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); final Condition c = lock.writeLock().newCondition(); @@ -457,7 +728,7 @@ public class ReentrantReadWriteLockTest lock.writeLock().unlock(); } catch(InterruptedException e) { - fail("unexpected exception"); + threadUnexpectedException(); } } }); @@ -472,36 +743,72 @@ public class ReentrantReadWriteLockTest assertFalse(t.isAlive()); } catch (Exception ex) { - fail("unexpected exception"); + unexpectedException(); } } + /** A helper class for uninterruptible wait tests */ + class UninterruptableThread extends Thread { + private Lock lock; + private Condition c; + + public volatile boolean canAwake = false; + public volatile boolean interrupted = false; + public volatile boolean lockStarted = false; + + public UninterruptableThread(Lock lock, Condition c) { + this.lock = lock; + this.c = c; + } + + public synchronized void run() { + lock.lock(); + lockStarted = true; + + while (!canAwake) { + c.awaitUninterruptibly(); + } + + interrupted = isInterrupted(); + lock.unlock(); + } + } + + /** + * awaitUninterruptibly doesn't abort on interrupt + */ public void testAwaitUninterruptibly() { - final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); final Condition c = lock.writeLock().newCondition(); - Thread t = new Thread(new Runnable() { - public void run() { - lock.writeLock().lock(); - c.awaitUninterruptibly(); - lock.writeLock().unlock(); - } - }); + UninterruptableThread thread = new UninterruptableThread(lock.writeLock(), c); try { - t.start(); - Thread.sleep(SHORT_DELAY_MS); - t.interrupt(); + thread.start(); + + while (!thread.lockStarted) { + Thread.sleep(100); + } + lock.writeLock().lock(); - c.signal(); - lock.writeLock().unlock(); - t.join(SHORT_DELAY_MS); - assertFalse(t.isAlive()); - } - catch (Exception ex) { - fail("unexpected exception"); + try { + thread.interrupt(); + thread.canAwake = true; + c.signal(); + } finally { + lock.writeLock().unlock(); + } + + thread.join(); + assertTrue(thread.interrupted); + assertFalse(thread.isAlive()); + } catch (Exception ex) { + unexpectedException(); } } + /** + * await is interruptible + */ public void testAwait_Interrupt() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); final Condition c = lock.writeLock().newCondition(); @@ -511,7 +818,7 @@ public class ReentrantReadWriteLockTest lock.writeLock().lock(); c.await(); lock.writeLock().unlock(); - fail("should throw"); + threadShouldThrow(); } catch(InterruptedException success) { } @@ -526,10 +833,13 @@ public class ReentrantReadWriteLockTest assertFalse(t.isAlive()); } catch (Exception ex) { - fail("unexpected exception"); + unexpectedException(); } } + /** + * awaitNanos is interruptible + */ public void testAwaitNanos_Interrupt() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); final Condition c = lock.writeLock().newCondition(); @@ -539,7 +849,7 @@ public class ReentrantReadWriteLockTest lock.writeLock().lock(); c.awaitNanos(SHORT_DELAY_MS * 2 * 1000000); lock.writeLock().unlock(); - fail("should throw"); + threadShouldThrow(); } catch(InterruptedException success) { } @@ -554,10 +864,13 @@ public class ReentrantReadWriteLockTest assertFalse(t.isAlive()); } catch (Exception ex) { - fail("unexpected exception"); + unexpectedException(); } } + /** + * awaitUntil is interruptible + */ public void testAwaitUntil_Interrupt() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); final Condition c = lock.writeLock().newCondition(); @@ -568,7 +881,7 @@ public class ReentrantReadWriteLockTest java.util.Date d = new java.util.Date(); c.awaitUntil(new java.util.Date(d.getTime() + 10000)); lock.writeLock().unlock(); - fail("should throw"); + threadShouldThrow(); } catch(InterruptedException success) { } @@ -583,10 +896,13 @@ public class ReentrantReadWriteLockTest assertFalse(t.isAlive()); } catch (Exception ex) { - fail("unexpected exception"); + unexpectedException(); } } + /** + * signalAll wakes up all threads + */ public void testSignalAll() { final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); final Condition c = lock.writeLock().newCondition(); @@ -598,7 +914,7 @@ public class ReentrantReadWriteLockTest lock.writeLock().unlock(); } catch(InterruptedException e) { - fail("unexpected exception"); + threadUnexpectedException(); } } }); @@ -611,7 +927,7 @@ public class ReentrantReadWriteLockTest lock.writeLock().unlock(); } catch(InterruptedException e) { - fail("unexpected exception"); + threadUnexpectedException(); } } }); @@ -629,10 +945,13 @@ public class ReentrantReadWriteLockTest assertFalse(t2.isAlive()); } catch (Exception ex) { - fail("unexpected exception"); + unexpectedException(); } } + /** + * A serialized lock deserializes as unlocked + */ public void testSerialization() { ReentrantReadWriteLock l = new ReentrantReadWriteLock(); l.readLock().lock(); @@ -651,9 +970,477 @@ public class ReentrantReadWriteLockTest r.readLock().unlock(); } catch(Exception e){ e.printStackTrace(); - fail("unexpected exception"); + unexpectedException(); + } + } + + /** + * hasQueuedThreads reports whether there are waiting threads + */ + public void testhasQueuedThreads() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + Thread t1 = new Thread(new InterruptedLockRunnable(lock)); + Thread t2 = new Thread(new InterruptibleLockRunnable(lock)); + try { + assertFalse(lock.hasQueuedThreads()); + lock.writeLock().lock(); + t1.start(); + Thread.sleep(SHORT_DELAY_MS); + assertTrue(lock.hasQueuedThreads()); + t2.start(); + Thread.sleep(SHORT_DELAY_MS); + assertTrue(lock.hasQueuedThreads()); + t1.interrupt(); + Thread.sleep(SHORT_DELAY_MS); + assertTrue(lock.hasQueuedThreads()); + lock.writeLock().unlock(); + Thread.sleep(SHORT_DELAY_MS); + assertFalse(lock.hasQueuedThreads()); + t1.join(); + t2.join(); + } catch(Exception e){ + unexpectedException(); + } + } + + /** + * hasQueuedThread(null) throws NPE + */ + public void testHasQueuedThreadNPE() { + final ReentrantReadWriteLock sync = new ReentrantReadWriteLock(); + try { + sync.hasQueuedThread(null); + shouldThrow(); + } catch (NullPointerException success) { } } + /** + * hasQueuedThread reports whether a thread is queued. + */ + public void testHasQueuedThread() { + final ReentrantReadWriteLock sync = new ReentrantReadWriteLock(); + Thread t1 = new Thread(new InterruptedLockRunnable(sync)); + Thread t2 = new Thread(new InterruptibleLockRunnable(sync)); + try { + assertFalse(sync.hasQueuedThread(t1)); + assertFalse(sync.hasQueuedThread(t2)); + sync.writeLock().lock(); + t1.start(); + Thread.sleep(SHORT_DELAY_MS); + assertTrue(sync.hasQueuedThread(t1)); + t2.start(); + Thread.sleep(SHORT_DELAY_MS); + assertTrue(sync.hasQueuedThread(t1)); + assertTrue(sync.hasQueuedThread(t2)); + t1.interrupt(); + Thread.sleep(SHORT_DELAY_MS); + assertFalse(sync.hasQueuedThread(t1)); + assertTrue(sync.hasQueuedThread(t2)); + sync.writeLock().unlock(); + Thread.sleep(SHORT_DELAY_MS); + assertFalse(sync.hasQueuedThread(t1)); + Thread.sleep(SHORT_DELAY_MS); + assertFalse(sync.hasQueuedThread(t2)); + t1.join(); + t2.join(); + } catch(Exception e){ + unexpectedException(); + } + } + + + /** + * getQueueLength reports number of waiting threads + */ + public void testGetQueueLength() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + Thread t1 = new Thread(new InterruptedLockRunnable(lock)); + Thread t2 = new Thread(new InterruptibleLockRunnable(lock)); + try { + assertEquals(0, lock.getQueueLength()); + lock.writeLock().lock(); + t1.start(); + Thread.sleep(SHORT_DELAY_MS); + assertEquals(1, lock.getQueueLength()); + t2.start(); + Thread.sleep(SHORT_DELAY_MS); + assertEquals(2, lock.getQueueLength()); + t1.interrupt(); + Thread.sleep(SHORT_DELAY_MS); + assertEquals(1, lock.getQueueLength()); + lock.writeLock().unlock(); + Thread.sleep(SHORT_DELAY_MS); + assertEquals(0, lock.getQueueLength()); + t1.join(); + t2.join(); + } catch(Exception e){ + unexpectedException(); + } + } + + /** + * getQueuedThreads includes waiting threads + */ + public void testGetQueuedThreads() { + final PublicReentrantReadWriteLock lock = new PublicReentrantReadWriteLock(); + Thread t1 = new Thread(new InterruptedLockRunnable(lock)); + Thread t2 = new Thread(new InterruptibleLockRunnable(lock)); + try { + assertTrue(lock.getQueuedThreads().isEmpty()); + lock.writeLock().lock(); + assertTrue(lock.getQueuedThreads().isEmpty()); + t1.start(); + Thread.sleep(SHORT_DELAY_MS); + assertTrue(lock.getQueuedThreads().contains(t1)); + t2.start(); + Thread.sleep(SHORT_DELAY_MS); + assertTrue(lock.getQueuedThreads().contains(t1)); + assertTrue(lock.getQueuedThreads().contains(t2)); + t1.interrupt(); + Thread.sleep(SHORT_DELAY_MS); + assertFalse(lock.getQueuedThreads().contains(t1)); + assertTrue(lock.getQueuedThreads().contains(t2)); + lock.writeLock().unlock(); + Thread.sleep(SHORT_DELAY_MS); + assertTrue(lock.getQueuedThreads().isEmpty()); + t1.join(); + t2.join(); + } catch(Exception e){ + unexpectedException(); + } + } + + /** + * hasWaiters throws NPE if null + */ + public void testHasWaitersNPE() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + try { + lock.hasWaiters(null); + shouldThrow(); + } catch (NullPointerException success) { + } catch (Exception ex) { + unexpectedException(); + } + } + + /** + * getWaitQueueLength throws NPE if null + */ + public void testGetWaitQueueLengthNPE() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + try { + lock.getWaitQueueLength(null); + shouldThrow(); + } catch (NullPointerException success) { + } catch (Exception ex) { + unexpectedException(); + } + } + + + /** + * getWaitingThreads throws NPE if null + */ + public void testGetWaitingThreadsNPE() { + final PublicReentrantReadWriteLock lock = new PublicReentrantReadWriteLock(); + try { + lock.getWaitingThreads(null); + shouldThrow(); + } catch (NullPointerException success) { + } catch (Exception ex) { + unexpectedException(); + } + } + + /** + * hasWaiters throws IAE if not owned + */ + public void testHasWaitersIAE() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + final Condition c = (lock.writeLock().newCondition()); + final ReentrantReadWriteLock lock2 = new ReentrantReadWriteLock(); + try { + lock2.hasWaiters(c); + shouldThrow(); + } catch (IllegalArgumentException success) { + } catch (Exception ex) { + unexpectedException(); + } + } + + /** + * hasWaiters throws IMSE if not locked + */ + public void testHasWaitersIMSE() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + final Condition c = (lock.writeLock().newCondition()); + try { + lock.hasWaiters(c); + shouldThrow(); + } catch (IllegalMonitorStateException success) { + } catch (Exception ex) { + unexpectedException(); + } + } + + + /** + * getWaitQueueLength throws IAE if not owned + */ + public void testGetWaitQueueLengthIAE() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + final Condition c = (lock.writeLock().newCondition()); + final ReentrantReadWriteLock lock2 = new ReentrantReadWriteLock(); + try { + lock2.getWaitQueueLength(c); + shouldThrow(); + } catch (IllegalArgumentException success) { + } catch (Exception ex) { + unexpectedException(); + } + } + + /** + * getWaitQueueLength throws IMSE if not locked + */ + public void testGetWaitQueueLengthIMSE() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + final Condition c = (lock.writeLock().newCondition()); + try { + lock.getWaitQueueLength(c); + shouldThrow(); + } catch (IllegalMonitorStateException success) { + } catch (Exception ex) { + unexpectedException(); + } + } + + + /** + * getWaitingThreads throws IAE if not owned + */ + public void testGetWaitingThreadsIAE() { + final PublicReentrantReadWriteLock lock = new PublicReentrantReadWriteLock(); + final Condition c = (lock.writeLock().newCondition()); + final PublicReentrantReadWriteLock lock2 = new PublicReentrantReadWriteLock(); + try { + lock2.getWaitingThreads(c); + shouldThrow(); + } catch (IllegalArgumentException success) { + } catch (Exception ex) { + unexpectedException(); + } + } + + /** + * getWaitingThreads throws IMSE if not locked + */ + public void testGetWaitingThreadsIMSE() { + final PublicReentrantReadWriteLock lock = new PublicReentrantReadWriteLock(); + final Condition c = (lock.writeLock().newCondition()); + try { + lock.getWaitingThreads(c); + shouldThrow(); + } catch (IllegalMonitorStateException success) { + } catch (Exception ex) { + unexpectedException(); + } + } + + + /** + * hasWaiters returns true when a thread is waiting, else false + */ + public void testHasWaiters() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + final Condition c = (lock.writeLock().newCondition()); + Thread t = new Thread(new Runnable() { + public void run() { + try { + lock.writeLock().lock(); + threadAssertFalse(lock.hasWaiters(c)); + threadAssertEquals(0, lock.getWaitQueueLength(c)); + c.await(); + lock.writeLock().unlock(); + } + catch(InterruptedException e) { + threadUnexpectedException(); + } + } + }); + + try { + t.start(); + Thread.sleep(SHORT_DELAY_MS); + lock.writeLock().lock(); + assertTrue(lock.hasWaiters(c)); + assertEquals(1, lock.getWaitQueueLength(c)); + c.signal(); + lock.writeLock().unlock(); + Thread.sleep(SHORT_DELAY_MS); + lock.writeLock().lock(); + assertFalse(lock.hasWaiters(c)); + assertEquals(0, lock.getWaitQueueLength(c)); + lock.writeLock().unlock(); + t.join(SHORT_DELAY_MS); + assertFalse(t.isAlive()); + } + catch (Exception ex) { + unexpectedException(); + } + } + + /** + * getWaitQueueLength returns number of waiting threads + */ + public void testGetWaitQueueLength() { + final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + final Condition c = (lock.writeLock().newCondition()); + Thread t = new Thread(new Runnable() { + public void run() { + try { + lock.writeLock().lock(); + threadAssertFalse(lock.hasWaiters(c)); + threadAssertEquals(0, lock.getWaitQueueLength(c)); + c.await(); + lock.writeLock().unlock(); + } + catch(InterruptedException e) { + threadUnexpectedException(); + } + } + }); + + try { + t.start(); + Thread.sleep(SHORT_DELAY_MS); + lock.writeLock().lock(); + assertTrue(lock.hasWaiters(c)); + assertEquals(1, lock.getWaitQueueLength(c)); + c.signal(); + lock.writeLock().unlock(); + Thread.sleep(SHORT_DELAY_MS); + lock.writeLock().lock(); + assertFalse(lock.hasWaiters(c)); + assertEquals(0, lock.getWaitQueueLength(c)); + lock.writeLock().unlock(); + t.join(SHORT_DELAY_MS); + assertFalse(t.isAlive()); + } + catch (Exception ex) { + unexpectedException(); + } + } + + + /** + * getWaitingThreads returns only and all waiting threads + */ + public void testGetWaitingThreads() { + final PublicReentrantReadWriteLock lock = new PublicReentrantReadWriteLock(); + final Condition c = lock.writeLock().newCondition(); + Thread t1 = new Thread(new Runnable() { + public void run() { + try { + lock.writeLock().lock(); + threadAssertTrue(lock.getWaitingThreads(c).isEmpty()); + c.await(); + lock.writeLock().unlock(); + } + catch(InterruptedException e) { + threadUnexpectedException(); + } + } + }); + + Thread t2 = new Thread(new Runnable() { + public void run() { + try { + lock.writeLock().lock(); + threadAssertFalse(lock.getWaitingThreads(c).isEmpty()); + c.await(); + lock.writeLock().unlock(); + } + catch(InterruptedException e) { + threadUnexpectedException(); + } + } + }); + + try { + lock.writeLock().lock(); + assertTrue(lock.getWaitingThreads(c).isEmpty()); + lock.writeLock().unlock(); + t1.start(); + Thread.sleep(SHORT_DELAY_MS); + t2.start(); + Thread.sleep(SHORT_DELAY_MS); + lock.writeLock().lock(); + assertTrue(lock.hasWaiters(c)); + assertTrue(lock.getWaitingThreads(c).contains(t1)); + assertTrue(lock.getWaitingThreads(c).contains(t2)); + c.signalAll(); + lock.writeLock().unlock(); + Thread.sleep(SHORT_DELAY_MS); + lock.writeLock().lock(); + assertFalse(lock.hasWaiters(c)); + assertTrue(lock.getWaitingThreads(c).isEmpty()); + lock.writeLock().unlock(); + t1.join(SHORT_DELAY_MS); + t2.join(SHORT_DELAY_MS); + assertFalse(t1.isAlive()); + assertFalse(t2.isAlive()); + } + catch (Exception ex) { + unexpectedException(); + } + } + + /** + * toString indicates current lock state + */ + public void testToString() { + ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + String us = lock.toString(); + assertTrue(us.indexOf("Write locks = 0") >= 0); + assertTrue(us.indexOf("Read locks = 0") >= 0); + lock.writeLock().lock(); + String ws = lock.toString(); + assertTrue(ws.indexOf("Write locks = 1") >= 0); + assertTrue(ws.indexOf("Read locks = 0") >= 0); + lock.writeLock().unlock(); + lock.readLock().lock(); + lock.readLock().lock(); + String rs = lock.toString(); + assertTrue(rs.indexOf("Write locks = 0") >= 0); + assertTrue(rs.indexOf("Read locks = 2") >= 0); + } + + /** + * readLock.toString indicates current lock state + */ + public void testReadLockToString() { + ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + String us = lock.readLock().toString(); + assertTrue(us.indexOf("Read locks = 0") >= 0); + lock.readLock().lock(); + lock.readLock().lock(); + String rs = lock.readLock().toString(); + assertTrue(rs.indexOf("Read locks = 2") >= 0); + } + + /** + * writeLock.toString indicates current lock state + */ + public void testWriteLockToString() { + ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + String us = lock.writeLock().toString(); + assertTrue(us.indexOf("Unlocked") >= 0); + lock.writeLock().lock(); + String ls = lock.writeLock().toString(); + assertTrue(ls.indexOf("Locked") >= 0); + } }